)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c3abe9a65b3f0872036c7873689dd122eea364ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix will allow Instantiation to be successful when"},{"line_number":10,"context_line":"Multiple Base Hot is defined in the VNFD Package."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2d5e677820a4978d609ab492aa64cdc5269fd5c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9f560f44_6df84ac3","line":11,"updated":"2020-09-25 04:44:58.000000000","message":"Please add the following commit message to link with the launchpad bug.\nCloses-Bug: # 1895830","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b5a7046371b03e8961f1afea8213c46c8578ebae","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix will allow Instantiation to be successful when"},{"line_number":10,"context_line":"Multiple Base Hot is defined in the VNFD Package."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2d5e677820a4978d609ab492aa64cdc5269fd5c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9f560f44_7f0743ca","line":11,"in_reply_to":"9f560f44_6df84ac3","updated":"2020-09-25 14:01:46.000000000","message":"Updated comment and added URL of the bug.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"}],"tacker/vnflcm/utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":986,"context_line":"    LOG.debug(\"Loaded base hot: %s\", base_hot_dict)"},{"line_number":987,"context_line":"    return base_hot_dict"},{"line_number":988,"context_line":""},{"line_number":989,"context_line":"def _get_base_nest_hot_dict(context, flavour_id, vnfd_id):"},{"line_number":990,"context_line":"    vnf_package_id \u003d _get_vnf_package_id(context, vnfd_id)"},{"line_number":991,"context_line":"    vnf_package_base_path \u003d cfg.CONF.vnf_package.vnf_package_csar_path"},{"line_number":992,"context_line":"    vnf_package_csar_path \u003d vnf_package_base_path + \u0027/\u0027 + vnf_package_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b06a2a18","line":989,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":994,"context_line":"    ext \u003d [\".yaml\", \".yml\"]"},{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    base_hot_path \u003d vnf_package_csar_path + \u0027/\u0027 + \\"},{"line_number":997,"context_line":"                    base_hot_dir + \u0027/\u0027 + flavour_id"},{"line_number":998,"context_line":"    base_hot_dict \u003d None"},{"line_number":999,"context_line":"    nested_hot_path \u003d base_hot_path + \u0027/nested\u0027"},{"line_number":1000,"context_line":"    nested_hot_dict \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_9065664c","line":997,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E127 continuation line over-indented for visual indent","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":1008,"context_line":"            if file.endswith(tuple(ext)):"},{"line_number":1009,"context_line":"                source_file_path \u003d os.path.join(nested_hot_path, file)"},{"line_number":1010,"context_line":"                nested_hot \u003d yaml.safe_load(open(source_file_path))"},{"line_number":1011,"context_line":"                nested_hot_dict[file]\u003dnested_hot"},{"line_number":1012,"context_line":"    LOG.debug(\"Loaded base hot: %s\", base_hot_dict)"},{"line_number":1013,"context_line":"    LOG.debug(\"Loaded nested_hot_dict: %s\", nested_hot_dict)"},{"line_number":1014,"context_line":"    return base_hot_dict, nested_hot_dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f074a200","line":1011,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E225 missing whitespace around operator","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c3abe9a65b3f0872036c7873689dd122eea364ed","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"    return base_hot_dict"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"def _get_base_nest_hot_dict(context, flavour_id, vnfd_id):"},{"line_number":1043,"context_line":"    vnf_package_id \u003d _get_vnf_package_id(context, vnfd_id)"},{"line_number":1044,"context_line":"    vnf_package_base_path \u003d cfg.CONF.vnf_package.vnf_package_csar_path"},{"line_number":1045,"context_line":"    vnf_package_csar_path \u003d vnf_package_base_path + \u0027/\u0027 + vnf_package_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_8df95ec6","line":1042,"range":{"start_line":1042,"start_character":4,"end_line":1042,"end_character":5},"updated":"2020-09-25 04:44:58.000000000","message":"It is not an inner function and should be modified as follows:\n  def get_base_nest_hot_dict","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b5a7046371b03e8961f1afea8213c46c8578ebae","unresolved":false,"context_lines":[{"line_number":1039,"context_line":"    return base_hot_dict"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"def _get_base_nest_hot_dict(context, flavour_id, vnfd_id):"},{"line_number":1043,"context_line":"    vnf_package_id \u003d _get_vnf_package_id(context, vnfd_id)"},{"line_number":1044,"context_line":"    vnf_package_base_path \u003d cfg.CONF.vnf_package.vnf_package_csar_path"},{"line_number":1045,"context_line":"    vnf_package_csar_path \u003d vnf_package_base_path + \u0027/\u0027 + vnf_package_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_3f6e6b63","line":1042,"range":{"start_line":1042,"start_character":4,"end_line":1042,"end_character":5},"in_reply_to":"9f560f44_8df95ec6","updated":"2020-09-25 14:01:46.000000000","message":"It was adapted to the existing one, anyway it will be improved separately. We placed this as a TODO function name improvement.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f3ae586921dc149eb9d3eb475eec150dfde45bae","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"    base_hot_dict \u003d None"},{"line_number":1052,"context_line":"    nested_hot_path \u003d base_hot_path + \u0027/nested\u0027"},{"line_number":1053,"context_line":"    nested_hot_dict \u003d {}"},{"line_number":1054,"context_line":"    if os.path.exists(base_hot_path):"},{"line_number":1055,"context_line":"        for file in os.listdir(base_hot_path):"},{"line_number":1056,"context_line":"            if file.endswith(tuple(ext)):"},{"line_number":1057,"context_line":"                source_file_path \u003d os.path.join(base_hot_path, file)"},{"line_number":1058,"context_line":"                base_hot_dict \u003d yaml.safe_load(open(source_file_path))"},{"line_number":1059,"context_line":"    if os.path.exists(nested_hot_path):"},{"line_number":1060,"context_line":"        for file in os.listdir(nested_hot_path):"},{"line_number":1061,"context_line":"            if file.endswith(tuple(ext)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_8a50242e","line":1058,"range":{"start_line":1054,"start_character":0,"end_line":1058,"end_character":70},"updated":"2020-09-25 03:59:08.000000000","message":"will this logic only load the last baseHOT file in base_hot_path? btw will base_hot_path includes multiple files in it?","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8b8b08b958400a30a21d8cd0d4b351be05d03984","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"    base_hot_dict \u003d None"},{"line_number":1052,"context_line":"    nested_hot_path \u003d base_hot_path + \u0027/nested\u0027"},{"line_number":1053,"context_line":"    nested_hot_dict \u003d {}"},{"line_number":1054,"context_line":"    if os.path.exists(base_hot_path):"},{"line_number":1055,"context_line":"        for file in os.listdir(base_hot_path):"},{"line_number":1056,"context_line":"            if file.endswith(tuple(ext)):"},{"line_number":1057,"context_line":"                source_file_path \u003d os.path.join(base_hot_path, file)"},{"line_number":1058,"context_line":"                base_hot_dict \u003d yaml.safe_load(open(source_file_path))"},{"line_number":1059,"context_line":"    if os.path.exists(nested_hot_path):"},{"line_number":1060,"context_line":"        for file in os.listdir(nested_hot_path):"},{"line_number":1061,"context_line":"            if file.endswith(tuple(ext)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_f4ca5a43","line":1058,"range":{"start_line":1054,"start_character":0,"end_line":1058,"end_character":70},"in_reply_to":"9f560f44_8a50242e","updated":"2020-09-25 13:16:31.000000000","message":"Parent baseHOT file is assumed to be one file in flavourId unit, child HOT is acquired by the following logic.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f69625b53bd67ca1a6712a18e8acaa6bb23ccca6","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"    base_hot_dict \u003d None"},{"line_number":1052,"context_line":"    nested_hot_path \u003d base_hot_path + \u0027/nested\u0027"},{"line_number":1053,"context_line":"    nested_hot_dict \u003d {}"},{"line_number":1054,"context_line":"    if os.path.exists(base_hot_path):"},{"line_number":1055,"context_line":"        for file in os.listdir(base_hot_path):"},{"line_number":1056,"context_line":"            if file.endswith(tuple(ext)):"},{"line_number":1057,"context_line":"                source_file_path \u003d os.path.join(base_hot_path, file)"},{"line_number":1058,"context_line":"                base_hot_dict \u003d yaml.safe_load(open(source_file_path))"},{"line_number":1059,"context_line":"    if os.path.exists(nested_hot_path):"},{"line_number":1060,"context_line":"        for file in os.listdir(nested_hot_path):"},{"line_number":1061,"context_line":"            if file.endswith(tuple(ext)):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e99e8a53","line":1058,"range":{"start_line":1054,"start_character":0,"end_line":1058,"end_character":70},"in_reply_to":"9f560f44_f4ca5a43","updated":"2020-10-05 09:58:48.000000000","message":"Okay, got it","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        vnfd_dict \u003d vnflcm_utils._get_vnfd_dict(context, vnf_instance.vnfd_id,"},{"line_number":139,"context_line":"                instantiate_vnf_req.flavour_id)"},{"line_number":140,"context_line":"        base_hot_dict, nested_hot_dict \u003d vnflcm_utils._get_base_nest_hot_dict("},{"line_number":141,"context_line":"                                               context,"},{"line_number":142,"context_line":"                                               instantiate_vnf_req.flavour_id,"},{"line_number":143,"context_line":"                                               vnf_instance.vnfd_id)"},{"line_number":144,"context_line":"        vnf_package_path \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_50846ed3","line":141,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":"import time"},{"line_number":23,"context_line":"import copy"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from collections import OrderedDict"},{"line_number":26,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d06fde25","line":23,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: H306: imports not in alphabetical order (time, copy)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from tacker.vnfm.infra_drivers.openstack import vdu"},{"line_number":49,"context_line":"from tacker.vnfm.infra_drivers import scale_driver"},{"line_number":50,"context_line":"from tacker.vnfm.lcm_user_data.constants import USER_DATA_TIMEOUT"},{"line_number":51,"context_line":"from tacker.vnflcm import utils as vnflcm_utils"},{"line_number":52,"context_line":"from tacker.tosca import utils as tosca_utils"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"eventlet.monkey_patch(time\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3060da35","line":51,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: H306: imports not in alphabetical order (tacker.vnfm.lcm_user_data.constants.user_data_timeout, tacker.vnflcm.utils)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from tacker.vnfm.infra_drivers import scale_driver"},{"line_number":50,"context_line":"from tacker.vnfm.lcm_user_data.constants import USER_DATA_TIMEOUT"},{"line_number":51,"context_line":"from tacker.vnflcm import utils as vnflcm_utils"},{"line_number":52,"context_line":"from tacker.tosca import utils as tosca_utils"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"eventlet.monkey_patch(time\u003dTrue)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_10631643","line":52,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: H306: imports not in alphabetical order (tacker.vnflcm.utils, tacker.tosca.utils)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if user_data_path is not None and user_data_class is not None:"},{"line_number":146,"context_line":"            LOG.info(\u0027Execute user data and create heat-stack.\u0027)"},{"line_number":147,"context_line":"            base_hot_dict, nested_hot_dict \u003d vnflcm_utils._get_base_nest_hot_dict("},{"line_number":148,"context_line":"                                                context,"},{"line_number":149,"context_line":"                                                inst_req_info.flavour_id,"},{"line_number":150,"context_line":"                                                vnf_instance.vnfd_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_705a5283","line":147,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        if user_data_path is not None and user_data_class is not None:"},{"line_number":146,"context_line":"            LOG.info(\u0027Execute user data and create heat-stack.\u0027)"},{"line_number":147,"context_line":"            base_hot_dict, nested_hot_dict \u003d vnflcm_utils._get_base_nest_hot_dict("},{"line_number":148,"context_line":"                                                context,"},{"line_number":149,"context_line":"                                                inst_req_info.flavour_id,"},{"line_number":150,"context_line":"                                                vnf_instance.vnfd_id)"},{"line_number":151,"context_line":"            if base_hot_dict is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_505d8e77","line":148,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            # Add stack param to vnf_attributes"},{"line_number":219,"context_line":"            vnf[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(hot_param_dict)})"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"            heal_interface \u003d vnflcm_utils._get_vnflcm_interface(context, \u0027heal\u0027,"},{"line_number":222,"context_line":"                                vnf_instance, inst_req_info.flavour_id)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            if not heal_interface is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b0534a6c","line":221,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":221,"context_line":"            heal_interface \u003d vnflcm_utils._get_vnflcm_interface(context, \u0027heal\u0027,"},{"line_number":222,"context_line":"                                vnf_instance, inst_req_info.flavour_id)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            if not heal_interface is None:"},{"line_number":225,"context_line":"                base_hot_dict \u003d self._add_event_alarm("},{"line_number":226,"context_line":"                    base_hot_dict, vnfd_dict, plugin, vnf, heal_interface)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_904e06c0","line":224,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E714 test for object identity should be \u0027is not\u0027","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        alarm_events \u003d {}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if isinstance(heal_interface, dict) and \\"},{"line_number":254,"context_line":"            \u0027implementation\u0027 in heal_interface.keys():"},{"line_number":255,"context_line":"            py_file \u003d tosca_utils.get_artifact_from_vnfd("},{"line_number":256,"context_line":"                            vnfd_dict, heal_interface[\u0027implementation\u0027])"},{"line_number":257,"context_line":"        pattern \u003d \u0027vdu_autoevacuate\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f04dc2c4","line":254,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E125 continuation line with same indent as next logical line","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        if isinstance(heal_interface, dict) and \\"},{"line_number":254,"context_line":"            \u0027implementation\u0027 in heal_interface.keys():"},{"line_number":255,"context_line":"            py_file \u003d tosca_utils.get_artifact_from_vnfd("},{"line_number":256,"context_line":"                            vnfd_dict, heal_interface[\u0027implementation\u0027])"},{"line_number":257,"context_line":"        pattern \u003d \u0027vdu_autoevacuate\u0027"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        for key, value in resources.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d0487eb4","line":256,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                    \u0027mon_policy_action\u0027: heal_type"},{"line_number":271,"context_line":"                }"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"                alarm_url \u003d plugin._vnf_alarm_monitor.call_alarm_url(\u0027ceilometer\u0027, vnf, params)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                alarm_events[alarm_key] \u003d  {"},{"line_number":276,"context_line":"                    \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_30c57a0b","line":273,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E501 line too long (95 \u003e 79 characters)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"                alarm_url \u003d plugin._vnf_alarm_monitor.call_alarm_url(\u0027ceilometer\u0027, vnf, params)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"                alarm_events[alarm_key] \u003d  {"},{"line_number":276,"context_line":"                    \u0027properties\u0027: {"},{"line_number":277,"context_line":"                        \u0027alarm_actions\u0027: [alarm_url],"},{"line_number":278,"context_line":"                        \u0027description\u0027: \u0027VM delete\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_10c8361f","line":275,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E222 multiple spaces after operator","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c3abe9a65b3f0872036c7873689dd122eea364ed","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        return stack[\u0027stack\u0027][\u0027id\u0027]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def _add_event_alarm(self, base_hot_dict, vnfd_dict,"},{"line_number":248,"context_line":"                    plugin, vnf, heal_interface):"},{"line_number":249,"context_line":"        resources \u003d base_hot_dict.get(\u0027resources\u0027, {})"},{"line_number":250,"context_line":"        py_file \u003d \u0027\u0027"},{"line_number":251,"context_line":"        alarm_events \u003d {}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if isinstance(heal_interface, dict) and \\"},{"line_number":254,"context_line":"           \u0027implementation\u0027 in heal_interface.keys():"},{"line_number":255,"context_line":"            py_file \u003d tosca_utils.get_artifact_from_vnfd("},{"line_number":256,"context_line":"                vnfd_dict, heal_interface[\u0027implementation\u0027])"},{"line_number":257,"context_line":"        pattern \u003d \u0027vdu_autoevacuate\u0027"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        for key, value in resources.items():"},{"line_number":260,"context_line":"            if value.get(\u0027type\u0027) \u003d\u003d NOVA_SERVER_RESOURCE:"},{"line_number":261,"context_line":"                alarm_key \u003d key + \u0027_event_healing\u0027"},{"line_number":262,"context_line":"                heal_type \u003d \u0027vdu_autoheal\u0027"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"                if py_file.find(pattern) \u003e 0:"},{"line_number":265,"context_line":"                    heal_type \u003d \u0027vdu_autoevacuate\u0027"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                params \u003d {"},{"line_number":268,"context_line":"                    \u0027mon_policy_name\u0027: alarm_key,"},{"line_number":269,"context_line":"                    \u0027vnf_id\u0027: vnf[\u0027id\u0027],"},{"line_number":270,"context_line":"                    \u0027mon_policy_action\u0027: heal_type"},{"line_number":271,"context_line":"                }"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"                alarm_url \u003d plugin._vnf_alarm_monitor.call_alarm_url("},{"line_number":274,"context_line":"                    \u0027ceilometer\u0027, vnf, params)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"                alarm_events[alarm_key] \u003d {"},{"line_number":277,"context_line":"                    \u0027properties\u0027: {"},{"line_number":278,"context_line":"                        \u0027alarm_actions\u0027: [alarm_url],"},{"line_number":279,"context_line":"                        \u0027description\u0027: \u0027VM delete\u0027,"},{"line_number":280,"context_line":"                        \u0027event_type\u0027: \u0027compute.instance.delete.end\u0027,"},{"line_number":281,"context_line":"                        \u0027query\u0027: [{"},{"line_number":282,"context_line":"                            \u0027field\u0027: \u0027traits.instance_id\u0027,"},{"line_number":283,"context_line":"                            \u0027op\u0027: \u0027eq\u0027,"},{"line_number":284,"context_line":"                            \u0027value\u0027: {\u0027get_resource\u0027: key}"},{"line_number":285,"context_line":"                        }],"},{"line_number":286,"context_line":"                        \u0027repeat_actions\u0027: True"},{"line_number":287,"context_line":"                    },"},{"line_number":288,"context_line":"                    \u0027type\u0027: \u0027OS::Aodh::EventAlarm\u0027"},{"line_number":289,"context_line":"                }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        base_hot_dict[\u0027resources\u0027] \u003d {**resources, **alarm_events}"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        return base_hot_dict"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @log.log"},{"line_number":296,"context_line":"    def _delete_user_data_module(self, user_data_module):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_edd29a33","line":293,"range":{"start_line":247,"start_character":4,"end_line":293,"end_character":28},"updated":"2020-09-25 04:44:58.000000000","message":"I thought this fix wasn\u0027t directly related to the 1895830 bug, is it necessary?\nDelete it if you don\u0027t need it.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b5a7046371b03e8961f1afea8213c46c8578ebae","unresolved":false,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        return stack[\u0027stack\u0027][\u0027id\u0027]"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def _add_event_alarm(self, base_hot_dict, vnfd_dict,"},{"line_number":248,"context_line":"                    plugin, vnf, heal_interface):"},{"line_number":249,"context_line":"        resources \u003d base_hot_dict.get(\u0027resources\u0027, {})"},{"line_number":250,"context_line":"        py_file \u003d \u0027\u0027"},{"line_number":251,"context_line":"        alarm_events \u003d {}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if isinstance(heal_interface, dict) and \\"},{"line_number":254,"context_line":"           \u0027implementation\u0027 in heal_interface.keys():"},{"line_number":255,"context_line":"            py_file \u003d tosca_utils.get_artifact_from_vnfd("},{"line_number":256,"context_line":"                vnfd_dict, heal_interface[\u0027implementation\u0027])"},{"line_number":257,"context_line":"        pattern \u003d \u0027vdu_autoevacuate\u0027"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        for key, value in resources.items():"},{"line_number":260,"context_line":"            if value.get(\u0027type\u0027) \u003d\u003d NOVA_SERVER_RESOURCE:"},{"line_number":261,"context_line":"                alarm_key \u003d key + \u0027_event_healing\u0027"},{"line_number":262,"context_line":"                heal_type \u003d \u0027vdu_autoheal\u0027"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"                if py_file.find(pattern) \u003e 0:"},{"line_number":265,"context_line":"                    heal_type \u003d \u0027vdu_autoevacuate\u0027"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"                params \u003d {"},{"line_number":268,"context_line":"                    \u0027mon_policy_name\u0027: alarm_key,"},{"line_number":269,"context_line":"                    \u0027vnf_id\u0027: vnf[\u0027id\u0027],"},{"line_number":270,"context_line":"                    \u0027mon_policy_action\u0027: heal_type"},{"line_number":271,"context_line":"                }"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"                alarm_url \u003d plugin._vnf_alarm_monitor.call_alarm_url("},{"line_number":274,"context_line":"                    \u0027ceilometer\u0027, vnf, params)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"                alarm_events[alarm_key] \u003d {"},{"line_number":277,"context_line":"                    \u0027properties\u0027: {"},{"line_number":278,"context_line":"                        \u0027alarm_actions\u0027: [alarm_url],"},{"line_number":279,"context_line":"                        \u0027description\u0027: \u0027VM delete\u0027,"},{"line_number":280,"context_line":"                        \u0027event_type\u0027: \u0027compute.instance.delete.end\u0027,"},{"line_number":281,"context_line":"                        \u0027query\u0027: [{"},{"line_number":282,"context_line":"                            \u0027field\u0027: \u0027traits.instance_id\u0027,"},{"line_number":283,"context_line":"                            \u0027op\u0027: \u0027eq\u0027,"},{"line_number":284,"context_line":"                            \u0027value\u0027: {\u0027get_resource\u0027: key}"},{"line_number":285,"context_line":"                        }],"},{"line_number":286,"context_line":"                        \u0027repeat_actions\u0027: True"},{"line_number":287,"context_line":"                    },"},{"line_number":288,"context_line":"                    \u0027type\u0027: \u0027OS::Aodh::EventAlarm\u0027"},{"line_number":289,"context_line":"                }"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        base_hot_dict[\u0027resources\u0027] \u003d {**resources, **alarm_events}"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        return base_hot_dict"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    @log.log"},{"line_number":296,"context_line":"    def _delete_user_data_module(self, user_data_module):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_5fa87f76","line":293,"range":{"start_line":247,"start_character":4,"end_line":293,"end_character":28},"in_reply_to":"9f560f44_edd29a33","updated":"2020-09-25 14:01:46.000000000","message":"Since it was an unnecessary correction, we removed as pointed out. The related processing in Line224-226 was removed as well.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"}],"tacker/vnfm/lcm_user_data/utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"HOT_NEUTRON_PORT \u003d \u0027OS::Neutron::Port\u0027"},{"line_number":36,"context_line":"AUTO_SCALING_GROUP \u003d \u0027OS::Heat::AutoScalingGroup\u0027"},{"line_number":37,"context_line":"HOT_CINDER_VOLUME \u003d \u0027OS::Cinder::Volume\u0027"},{"line_number":38,"context_line":"SUPPORTED_HOT_TYPE \u003d [HOT_NOVA_SERVER, HOT_NOVA_FLAVOR, HOT_NEUTRON_PORT, HOT_CINDER_VOLUME]"},{"line_number":39,"context_line":"PORT_SERVER_TYPE \u003d [HOT_NOVA_SERVER, HOT_NEUTRON_PORT, HOT_CINDER_VOLUME]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_70cff228","line":38,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E501 line too long (92 \u003e 79 characters)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    LOG.info(\u0027initial_param_dict: %s\u0027, initial_param_dict)"},{"line_number":109,"context_line":"    return initial_param_dict"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"def create_initial_param_server_port_dict(base_hot_dict):"},{"line_number":112,"context_line":"    \"\"\"Create initial dict containing information about get_param resources."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    :param base_hot_dict: dict(Base HOT dict format)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_50d2aed2","line":111,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    LOG.info(\u0027initial_param_dict: %s\u0027, initial_param_dict)"},{"line_number":179,"context_line":"    return initial_param_dict"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def create_final_param_dict(param_dict, vdu_flavor_dict,"},{"line_number":182,"context_line":"                            vdu_image_dict, cpd_vl_dict):"},{"line_number":183,"context_line":"    \"\"\"Create final dict containing information about HOT input parameter."},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_b0d86af0","line":181,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    LOG.info(\u0027cpd_vl_dict: %s\u0027, cpd_vl_dict)"},{"line_number":278,"context_line":"    return cpd_vl_dict"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"def get_diff_base_hot_param_from_api(base_hot_dict, inst_req_info):"},{"line_number":281,"context_line":"    \"\"\"Compare base hot param from API param."},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    :param base_hot_dict: dict(Base HOT dict format)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_90d3a6d3","line":280,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    return param_value"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def create_vdu_flavor_capability_name_dict(vnfd_dict):"},{"line_number":302,"context_line":"    \"\"\"Create a dict containing information about VDU\u0027s flavor."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    :param vnfd_dict: dict(VNFD dict format)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_f0e2e29f","line":301,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            for key, val in vdu_flavor_props.items():"},{"line_number":318,"context_line":"                if key \u003d\u003d \u0027requested_additional_capabilities\u0027:"},{"line_number":319,"context_line":"                    capability_props \u003d val.get(\u0027properties\u0027, {})"},{"line_number":320,"context_line":"                    if \u0027requested_additional_capability_name\u0027 in capability_props.keys():"},{"line_number":321,"context_line":"                        vdu_flavor_dict[vdu_name] \u003d capability_props[\u0027requested_additional_capability_name\u0027]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    LOG.info(\u0027vdu_flavor_dict: %s\u0027, vdu_flavor_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_d0dd1ede","line":320,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E501 line too long (89 \u003e 79 characters)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                if key \u003d\u003d \u0027requested_additional_capabilities\u0027:"},{"line_number":319,"context_line":"                    capability_props \u003d val.get(\u0027properties\u0027, {})"},{"line_number":320,"context_line":"                    if \u0027requested_additional_capability_name\u0027 in capability_props.keys():"},{"line_number":321,"context_line":"                        vdu_flavor_dict[vdu_name] \u003d capability_props[\u0027requested_additional_capability_name\u0027]"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    LOG.info(\u0027vdu_flavor_dict: %s\u0027, vdu_flavor_dict)"},{"line_number":324,"context_line":"    return vdu_flavor_dict"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_30ee1a8b","line":321,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E501 line too long (108 \u003e 79 characters)","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    LOG.info(\u0027vdu_flavor_dict: %s\u0027, vdu_flavor_dict)"},{"line_number":324,"context_line":"    return vdu_flavor_dict"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"def create_sw_image_dict(vnfd_dict):"},{"line_number":327,"context_line":"    \"\"\"Create a dict containing information about VDU\u0027s flavor."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    :param vnfd_dict: dict(VNFD dict format)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_10f1566b","line":326,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":344,"context_line":"    LOG.info(\u0027sw_image_data: %s\u0027, sw_image_data)"},{"line_number":345,"context_line":"    return sw_image_data"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"def create_network_dict(inst_req_info, param_dict):"},{"line_number":348,"context_line":"    \"\"\"Create a dict containing information about VDU\u0027s network."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    :param inst_req_info: dict(Instantiation request information format)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_70e8927b","line":347,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e24b5cdffdbede30d2c31191dfef6f4128a9739a","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    LOG.info(\u0027cp_data: %s\u0027, cp_data)"},{"line_number":364,"context_line":"    return cp_data"},{"line_number":365,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_50ebce76","line":365,"updated":"2020-09-18 16:31:51.000000000","message":"pep8: W391 blank line at end of file","commit_id":"5e388579024abb593375125bf76fab9dc5b550ba"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f3ae586921dc149eb9d3eb475eec150dfde45bae","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    for hot_dict in base_hot_dict.values():"},{"line_number":63,"context_line":"        param_nfv \u003d hot_dict.get(\u0027parameters\u0027, {}).get(\u0027nfv\u0027)"},{"line_number":64,"context_line":"        if not param_nfv:"},{"line_number":65,"context_line":"            continue"},{"line_number":66,"context_line":"        resources \u003d hot_dict.get(\u0027resources\u0027, {})"},{"line_number":67,"context_line":"        for resource_name, resource_val in resources.items():"},{"line_number":68,"context_line":"            resource_type \u003d resource_val.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_2a375800","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":20},"updated":"2020-09-25 03:59:08.000000000","message":"is this part a TODO? it seems doing nothing","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8b8b08b958400a30a21d8cd0d4b351be05d03984","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    for hot_dict in base_hot_dict.values():"},{"line_number":63,"context_line":"        param_nfv \u003d hot_dict.get(\u0027parameters\u0027, {}).get(\u0027nfv\u0027)"},{"line_number":64,"context_line":"        if not param_nfv:"},{"line_number":65,"context_line":"            continue"},{"line_number":66,"context_line":"        resources \u003d hot_dict.get(\u0027resources\u0027, {})"},{"line_number":67,"context_line":"        for resource_name, resource_val in resources.items():"},{"line_number":68,"context_line":"            resource_type \u003d resource_val.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_9405de7c","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":20},"in_reply_to":"9f560f44_2a375800","updated":"2020-09-25 13:16:31.000000000","message":"This is the logic for not processing files that do not have nfv settings. When processing multiple HOTs, child HOTs that do not use nfv naturally occur, so this is an essential process.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f69625b53bd67ca1a6712a18e8acaa6bb23ccca6","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    for hot_dict in base_hot_dict.values():"},{"line_number":63,"context_line":"        param_nfv \u003d hot_dict.get(\u0027parameters\u0027, {}).get(\u0027nfv\u0027)"},{"line_number":64,"context_line":"        if not param_nfv:"},{"line_number":65,"context_line":"            continue"},{"line_number":66,"context_line":"        resources \u003d hot_dict.get(\u0027resources\u0027, {})"},{"line_number":67,"context_line":"        for resource_name, resource_val in resources.items():"},{"line_number":68,"context_line":"            resource_type \u003d resource_val.get(\u0027type\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_8998ae69","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":20},"in_reply_to":"9f560f44_9405de7c","updated":"2020-10-05 09:58:48.000000000","message":"Thanks for explain! got it","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f3ae586921dc149eb9d3eb475eec150dfde45bae","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                            if b_param and \\"},{"line_number":87,"context_line":"                               isinstance(b_param, dict) and \\"},{"line_number":88,"context_line":"                               \u0027get_param\u0027 in b_param:"},{"line_number":89,"context_line":"                                param_list \u003d b_param[\u0027get_param\u0027]"},{"line_number":90,"context_line":"                                if len(param_list) \u003d\u003d 4:"},{"line_number":91,"context_line":"                                    resource_info \u003d initial_param_dict.get("},{"line_number":92,"context_line":"                                        param_list[0], {}).get("},{"line_number":93,"context_line":"                                            param_list[1], {})"},{"line_number":94,"context_line":"                                    if param_list[2] not in resource_info:"},{"line_number":95,"context_line":"                                        resource_info[param_list[2]] \u003d {}"},{"line_number":96,"context_line":"            elif resource_type \u003d\u003d AUTO_SCALING_GROUP:"},{"line_number":97,"context_line":"                resource_nest \u003d resource_val.get(\u0027properties\u0027).get(\u0027resource\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_2a10f858","line":94,"range":{"start_line":89,"start_character":0,"end_line":94,"end_character":74},"updated":"2020-09-25 03:59:08.000000000","message":"same as below","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8b8b08b958400a30a21d8cd0d4b351be05d03984","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                            if b_param and \\"},{"line_number":87,"context_line":"                               isinstance(b_param, dict) and \\"},{"line_number":88,"context_line":"                               \u0027get_param\u0027 in b_param:"},{"line_number":89,"context_line":"                                param_list \u003d b_param[\u0027get_param\u0027]"},{"line_number":90,"context_line":"                                if len(param_list) \u003d\u003d 4:"},{"line_number":91,"context_line":"                                    resource_info \u003d initial_param_dict.get("},{"line_number":92,"context_line":"                                        param_list[0], {}).get("},{"line_number":93,"context_line":"                                            param_list[1], {})"},{"line_number":94,"context_line":"                                    if param_list[2] not in resource_info:"},{"line_number":95,"context_line":"                                        resource_info[param_list[2]] \u003d {}"},{"line_number":96,"context_line":"            elif resource_type \u003d\u003d AUTO_SCALING_GROUP:"},{"line_number":97,"context_line":"                resource_nest \u003d resource_val.get(\u0027properties\u0027).get(\u0027resource\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_54efc6af","line":94,"range":{"start_line":89,"start_character":0,"end_line":94,"end_character":74},"in_reply_to":"9f560f44_2a10f858","updated":"2020-09-25 13:16:31.000000000","message":"same answer below.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f3ae586921dc149eb9d3eb475eec150dfde45bae","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    if isinstance(prop_val, dict) and \u0027get_param\u0027 in prop_val:"},{"line_number":101,"context_line":"                        param_list \u003d prop_val[\u0027get_param\u0027]"},{"line_number":102,"context_line":"                        if len(param_list) \u003d\u003d 4:"},{"line_number":103,"context_line":"                            resource_info \u003d initial_param_dict.get("},{"line_number":104,"context_line":"                                param_list[0], {}).get("},{"line_number":105,"context_line":"                                    param_list[1], {})"},{"line_number":106,"context_line":"                            if param_list[2] not in resource_info:"},{"line_number":107,"context_line":"                                resource_info[param_list[2]] \u003d {}"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_ca1cdc78","line":105,"range":{"start_line":103,"start_character":27,"end_line":105,"end_character":54},"updated":"2020-09-25 03:59:08.000000000","message":"it seems you are giving values to resource_info but initial_param_dict is returned?","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f69625b53bd67ca1a6712a18e8acaa6bb23ccca6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    if isinstance(prop_val, dict) and \u0027get_param\u0027 in prop_val:"},{"line_number":101,"context_line":"                        param_list \u003d prop_val[\u0027get_param\u0027]"},{"line_number":102,"context_line":"                        if len(param_list) \u003d\u003d 4:"},{"line_number":103,"context_line":"                            resource_info \u003d initial_param_dict.get("},{"line_number":104,"context_line":"                                param_list[0], {}).get("},{"line_number":105,"context_line":"                                    param_list[1], {})"},{"line_number":106,"context_line":"                            if param_list[2] not in resource_info:"},{"line_number":107,"context_line":"                                resource_info[param_list[2]] \u003d {}"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e9796a30","line":105,"range":{"start_line":103,"start_character":27,"end_line":105,"end_character":54},"in_reply_to":"9f560f44_34ea129f","updated":"2020-10-05 09:58:48.000000000","message":"Got it, thanks for your explaination!","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8b8b08b958400a30a21d8cd0d4b351be05d03984","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                    if isinstance(prop_val, dict) and \u0027get_param\u0027 in prop_val:"},{"line_number":101,"context_line":"                        param_list \u003d prop_val[\u0027get_param\u0027]"},{"line_number":102,"context_line":"                        if len(param_list) \u003d\u003d 4:"},{"line_number":103,"context_line":"                            resource_info \u003d initial_param_dict.get("},{"line_number":104,"context_line":"                                param_list[0], {}).get("},{"line_number":105,"context_line":"                                    param_list[1], {})"},{"line_number":106,"context_line":"                            if param_list[2] not in resource_info:"},{"line_number":107,"context_line":"                                resource_info[param_list[2]] \u003d {}"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_34ea129f","line":105,"range":{"start_line":103,"start_character":27,"end_line":105,"end_character":54},"in_reply_to":"9f560f44_ca1cdc78","updated":"2020-09-25 13:16:31.000000000","message":"The basis of python processing is address reference, and the parameter setting part of initial_param_dict is resource_info, so it is correct as the setting process.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"f3ae586921dc149eb9d3eb475eec150dfde45bae","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                resource_nest \u003d resource_val.get(\u0027properties\u0027).get(\u0027resource\u0027)"},{"line_number":169,"context_line":"                resource_props \u003d resource_nest.get(\u0027properties\u0027, {})"},{"line_number":170,"context_line":"                for prop_key, prop_val in resource_props.items():"},{"line_number":171,"context_line":"                    if isinstance(prop_val, dict) and \u0027get_param\u0027 in prop_val:"},{"line_number":172,"context_line":"                        param_list \u003d prop_val[\u0027get_param\u0027]"},{"line_number":173,"context_line":"                        if len(param_list) \u003d\u003d 4:"},{"line_number":174,"context_line":"                            resource_info \u003d initial_param_dict.get("},{"line_number":175,"context_line":"                                param_list[0], {}).get("},{"line_number":176,"context_line":"                                    param_list[1], {})"},{"line_number":177,"context_line":"                            if param_list[2] not in resource_info:"},{"line_number":178,"context_line":"                                resource_info[param_list[2]] \u003d {}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    LOG.info(\u0027initial_param_dict: %s\u0027, initial_param_dict)"},{"line_number":181,"context_line":"    return initial_param_dict"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_0a137466","line":178,"range":{"start_line":171,"start_character":6,"end_line":178,"end_character":65},"updated":"2020-09-25 03:59:08.000000000","message":"same as above","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8b8b08b958400a30a21d8cd0d4b351be05d03984","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                resource_nest \u003d resource_val.get(\u0027properties\u0027).get(\u0027resource\u0027)"},{"line_number":169,"context_line":"                resource_props \u003d resource_nest.get(\u0027properties\u0027, {})"},{"line_number":170,"context_line":"                for prop_key, prop_val in resource_props.items():"},{"line_number":171,"context_line":"                    if isinstance(prop_val, dict) and \u0027get_param\u0027 in prop_val:"},{"line_number":172,"context_line":"                        param_list \u003d prop_val[\u0027get_param\u0027]"},{"line_number":173,"context_line":"                        if len(param_list) \u003d\u003d 4:"},{"line_number":174,"context_line":"                            resource_info \u003d initial_param_dict.get("},{"line_number":175,"context_line":"                                param_list[0], {}).get("},{"line_number":176,"context_line":"                                    param_list[1], {})"},{"line_number":177,"context_line":"                            if param_list[2] not in resource_info:"},{"line_number":178,"context_line":"                                resource_info[param_list[2]] \u003d {}"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    LOG.info(\u0027initial_param_dict: %s\u0027, initial_param_dict)"},{"line_number":181,"context_line":"    return initial_param_dict"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_742daafb","line":178,"range":{"start_line":171,"start_character":6,"end_line":178,"end_character":65},"in_reply_to":"9f560f44_0a137466","updated":"2020-09-25 13:16:31.000000000","message":"Same answer as above.","commit_id":"7dd5dbe3fb574dd94f7ffd7cf76c34cdf1eba764"}]}