)]}'
{"tacker/tests/functional/common/test_cmd_executer.py":[{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"f70747057ab9037a86786170a5821d9505b33f13","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        vnf_id, mgmt_ip \u003d self._test_create_vnf(vnfd_file, vnf_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Wait for VM initialization. It takes time after VM started until"},{"line_number":55,"context_line":"        # sshd starts. It is a bit ad-hoc but adopted it for simplicity."},{"line_number":56,"context_line":"        time.sleep(100)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Login on VNF instance, and execute \u0027hostname\u0027 command to verify"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2bb423d4","line":55,"updated":"2020-10-01 06:14:37.000000000","message":"Have you considered wrapping RemoteCommandExecutor initialization inside of a try-except in a while loop, so that we can save test execution time? E.g. 3 sec. sleep interval + 100 sec. deadline. Or would it complicate the code too much?","commit_id":"b4d49961b968168b4654ca2449b16b6d7840fbd0"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"9f55122853bc41754cdacf7610eae223b890da75","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        vnf_id, mgmt_ip \u003d self._test_create_vnf(vnfd_file, vnf_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Wait for VM initialization. It takes time after VM started until"},{"line_number":55,"context_line":"        # sshd starts. It is a bit ad-hoc but adopted it for simplicity."},{"line_number":56,"context_line":"        time.sleep(100)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Login on VNF instance, and execute \u0027hostname\u0027 command to verify"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ab231306","line":55,"in_reply_to":"9f560f44_2bb423d4","updated":"2020-10-01 06:30:25.000000000","message":"Done","commit_id":"b4d49961b968168b4654ca2449b16b6d7840fbd0"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"75ab83446e4e30faadd83bf746e08420edbcc4ce","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        vnf_id, mgmt_ip \u003d self._test_create_vnf(vnfd_file, vnf_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Wait for VM initialization. It takes time after VM started until"},{"line_number":55,"context_line":"        # sshd starts. It is a bit ad-hoc but adopted it for simplicity."},{"line_number":56,"context_line":"        time.sleep(100)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Login on VNF instance, and execute \u0027hostname\u0027 command to verify"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ab3af331","line":55,"in_reply_to":"9f560f44_2bb423d4","updated":"2020-10-01 06:27:43.000000000","message":"Thank you for the comment.\nI considered your suggestion and felt it is over spec. It is the reason why I write \u0027simplicity\u0027.","commit_id":"b4d49961b968168b4654ca2449b16b6d7840fbd0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7ef743d7a9b4c4b59092434f3a90f686cda749c0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        vnf_id, mgmt_ip \u003d self._test_create_vnf(vnfd_file, vnf_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Wait for VM initialization. It takes time after VM started until"},{"line_number":55,"context_line":"        # sshd starts. It is a bit ad-hoc but adopted it for simplicity."},{"line_number":56,"context_line":"        time.sleep(100)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Login on VNF instance, and execute \u0027hostname\u0027 command to verify"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_8da0c8a6","line":55,"in_reply_to":"9f560f44_ab231306","updated":"2020-10-02 17:25:14.000000000","message":"For me, waiting 100 sec seems reasonable, not too much for sshd. Thanks!","commit_id":"b4d49961b968168b4654ca2449b16b6d7840fbd0"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"9f55122853bc41754cdacf7610eae223b890da75","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        vnf_id, mgmt_ip \u003d self._test_create_vnf(vnfd_file, vnf_name)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Wait for VM initialization. It takes time after VM started until"},{"line_number":55,"context_line":"        # sshd starts. It is a bit ad-hoc but adopted it for simplicity."},{"line_number":56,"context_line":"        time.sleep(100)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # Login on VNF instance, and execute \u0027hostname\u0027 command to verify"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_0b7affee","line":55,"in_reply_to":"9f560f44_ab3af331","updated":"2020-10-01 06:30:25.000000000","message":"Done","commit_id":"b4d49961b968168b4654ca2449b16b6d7840fbd0"}]}