)]}'
{"tacker/objects/vnf_deployment_flavour.py":[{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"e31ec91ecc3e124f9f7a39385106efbefae27d6a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \u0027package_uuid\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":99,"context_line":"        \u0027flavour_id\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":100,"context_line":"        \u0027flavour_description\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":101,"context_line":"        \u0027instantiation_levels\u0027: fields.DictOfNullableField("},{"line_number":102,"context_line":"            nullable\u003dTrue, default\u003d{}),"},{"line_number":103,"context_line":"        \u0027software_images\u0027: fields.ObjectField(\u0027VnfSoftwareImagesList\u0027),"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f621f24_a035fcdc","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":39},"updated":"2020-10-30 02:51:21.000000000","message":"I think it is better to change like the following instead of this change.\n\n---------------------------------------\ntacker/conductor/conductor_server.py\n\n    def _create_flavour(self, context, package_uuid, flavour):\n        deploy_flavour \u003d objects.VnfDeploymentFlavour(context\u003dcontext)\n        deploy_flavour.package_uuid \u003d package_uuid\n        deploy_flavour.flavour_id \u003d flavour[\u0027flavour_id\u0027]\n        deploy_flavour.flavour_description \u003d flavour[\u0027flavour_description\u0027]\n-        if flavour.get(\u0027instantiation_levels\u0027):\n-            deploy_flavour.instantiation_levels \u003d \\\n-                flavour.get(\u0027instantiation_levels\u0027)\n+        deploy_flavour.instantiation_levels \u003d \\\n+            flavour.get(\u0027instantiation_levels\u0027)\n        deploy_flavour.create()","commit_id":"db3ee6655a2f7d9ec502647ea296b886d5c315cb"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"995c1f0ccdf8cd242615f68d571c38faaff4456f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        \u0027package_uuid\u0027: fields.UUIDField(nullable\u003dFalse),"},{"line_number":99,"context_line":"        \u0027flavour_id\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":100,"context_line":"        \u0027flavour_description\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":101,"context_line":"        \u0027instantiation_levels\u0027: fields.DictOfNullableField("},{"line_number":102,"context_line":"            nullable\u003dTrue, default\u003d{}),"},{"line_number":103,"context_line":"        \u0027software_images\u0027: fields.ObjectField(\u0027VnfSoftwareImagesList\u0027),"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f621f24_4b3b52ea","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":39},"in_reply_to":"1f621f24_a035fcdc","updated":"2020-11-02 09:38:48.000000000","message":"I posted this comment also in the patch 760274. Please check it.","commit_id":"db3ee6655a2f7d9ec502647ea296b886d5c315cb"}],"tacker/tests/functional/base.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b0bbe7b5762661d3779790d4e04efbfa882a5112","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            except exceptions.NotFound:"},{"line_number":251,"context_line":"                return"},{"line_number":252,"context_line":"            except Exception as e:"},{"line_number":253,"context_line":"                LOG.error(\"Failed to get vnf status: %s\", str(e))"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"            if int(time.time()) - start_time \u003e timeout:"},{"line_number":256,"context_line":"                raise Exception(\"Timeout waiting unil vnf %s deleted.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_b949d733","line":253,"updated":"2020-10-28 09:06:51.000000000","message":"pep8: F821 undefined name \u0027LOG\u0027","commit_id":"e74a519719238ce33717d2ad338adfc33389cd03"}],"tacker/tests/functional/keystone.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"785608dc0063f376957d236fb224eac8f09d27e3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                cli \u003d client.Client(\u0027v3\u0027, session\u003dses)"},{"line_number":61,"context_line":"                break"},{"line_number":62,"context_line":"            except exceptions.InternalServerError:"},{"line_number":63,"context_line":"                LOG.warning(\"keystone service responds with 500 (InternalServerError).\")"},{"line_number":64,"context_line":"                client_retries \u003d client_retries - 1"},{"line_number":65,"context_line":"                if client_retries \u003d\u003d 0:"},{"line_number":66,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f65232a_a7a97b7c","line":63,"updated":"2020-10-26 05:05:40.000000000","message":"pep8: E501 line too long (88 \u003e 79 characters)","commit_id":"374e21b5e4ffabfe945ffa93b6149fbadd496b8e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"785608dc0063f376957d236fb224eac8f09d27e3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                client_retries \u003d client_retries - 1"},{"line_number":65,"context_line":"                if client_retries \u003d\u003d 0:"},{"line_number":66,"context_line":"                    raise"},{"line_number":67,"context_line":"                time.sleep(KEYSTONE_RETRY_WAIT)"},{"line_number":68,"context_line":"        return cli"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f65232a_07b82fc6","line":67,"updated":"2020-10-26 05:05:40.000000000","message":"pep8: F821 undefined name \u0027time\u0027","commit_id":"374e21b5e4ffabfe945ffa93b6149fbadd496b8e"}],"tacker/tests/functional/vnfm/test_tosca_vnf_alarm.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b0bbe7b5762661d3779790d4e04efbfa882a5112","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.addCleanup(self.wait_until_vnf_delete, vnf_id,"},{"line_number":112,"context_line":"                        constants.VNF_CIRROS_DELETE_TIMEOUT)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @unittest.skip(\"Until ceilometer is restored\")"},{"line_number":115,"context_line":"    def test_vnf_alarm_respawn(self):"},{"line_number":116,"context_line":"        self._test_vnf_tosca_alarm("},{"line_number":117,"context_line":"            \u0027sample-tosca-alarm-respawn.yaml\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_99469b21","line":114,"updated":"2020-10-28 09:06:51.000000000","message":"pep8: F821 undefined name \u0027unittest\u0027","commit_id":"e74a519719238ce33717d2ad338adfc33389cd03"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b0bbe7b5762661d3779790d4e04efbfa882a5112","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            \u0027sample-tosca-alarm-respawn.yaml\u0027,"},{"line_number":118,"context_line":"            \u0027alarm and respawn-vnf\u0027)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @unittest.skip(\"Until ceilometer is restored\")"},{"line_number":121,"context_line":"    def test_vnf_alarm_scale(self):"},{"line_number":122,"context_line":"        self._test_vnf_tosca_alarm("},{"line_number":123,"context_line":"            \u0027sample-tosca-alarm-scale.yaml\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f621f24_f9534fe1","line":120,"updated":"2020-10-28 09:06:51.000000000","message":"pep8: F821 undefined name \u0027unittest\u0027","commit_id":"e74a519719238ce33717d2ad338adfc33389cd03"}]}
