)]}'
{"doc/source/reference/block_storage_usage_guide.rst":[{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"9837296fe8b307ee53ba9a3dbca9189075fc491a","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        - virtualAttachment:"},{"line_number":64,"context_line":"            node: VB1"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"We can also attach an already created/existing volume with VNF by providing"},{"line_number":67,"context_line":"``volume_id`` in input."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1dbd2695_024adda2","line":66,"updated":"2021-01-14 15:08:51.000000000","message":"We choose this section or the section described in \"Create Volume\", so I think it\u0027s better that these two are consecutive.\nHow about move this section to after \"Create Volume\" as \"Use Existing Volume\"? And before that, we should explain that we have 2 options, \"Create Volume\" and \"Use Existing Volume\".","commit_id":"04f9ab23b576039fc641a20f972e993d512a7106"}],"tacker/tosca/utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ee555a1b1183c6cb6c29f29d2149358792174cde","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"VOLUME_IDs \u003d {}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"@log.log"},{"line_number":108,"context_line":"def updateimports(template):"},{"line_number":109,"context_line":"    path \u003d os.path.dirname(os.path.abspath(__file__)) + \u0027/lib/\u0027"},{"line_number":110,"context_line":"    defsfile \u003d path + \u0027tacker_defs.yaml\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_ff34ac4c","line":107,"updated":"2020-10-23 09:30:56.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"278d9ae9e5c41b4036fce00b910e4ea7ef634e06"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ee555a1b1183c6cb6c29f29d2149358792174cde","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                if VOLUME_IDs:"},{"line_number":415,"context_line":"                    vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d \\"},{"line_number":416,"context_line":"                        {\u0027get_param\u0027: VOLUME_IDs["},{"line_number":417,"context_line":"                        req[\u0027virtualAttachment\u0027][\u0027node\u0027]]}"},{"line_number":418,"context_line":"                else:"},{"line_number":419,"context_line":"                    vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d \\"},{"line_number":420,"context_line":"                          {\u0027get_resource\u0027: req[\u0027virtualAttachment\u0027][\u0027node\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_df39f041","line":417,"updated":"2020-10-23 09:30:56.000000000","message":"pep8: E122 continuation line missing indentation or outdented","commit_id":"278d9ae9e5c41b4036fce00b910e4ea7ef634e06"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ee555a1b1183c6cb6c29f29d2149358792174cde","unresolved":false,"context_lines":[{"line_number":417,"context_line":"                        req[\u0027virtualAttachment\u0027][\u0027node\u0027]]}"},{"line_number":418,"context_line":"                else:"},{"line_number":419,"context_line":"                    vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d \\"},{"line_number":420,"context_line":"                          {\u0027get_resource\u0027: req[\u0027virtualAttachment\u0027][\u0027node\u0027]}"},{"line_number":421,"context_line":"        del node_tpl[node_name]"},{"line_number":422,"context_line":"    return vol_attach_dict"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_3f3e2429","line":420,"updated":"2020-10-23 09:30:56.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"278d9ae9e5c41b4036fce00b910e4ea7ef634e06"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"042f142df13304802a638ba7b75799fe4161b81a","unresolved":true,"context_lines":[{"line_number":412,"context_line":"                vol_attach_dict[node_name][\u0027instance_uuid\u0027] \u003d \\"},{"line_number":413,"context_line":"                    {\u0027get_resource\u0027: req[\u0027virtualBinding\u0027][\u0027node\u0027]}"},{"line_number":414,"context_line":"            elif \u0027virtualAttachment\u0027 in req:"},{"line_number":415,"context_line":"                if VOLUME_IDs:"},{"line_number":416,"context_line":"                    vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d \\"},{"line_number":417,"context_line":"                        {\u0027get_param\u0027:"},{"line_number":418,"context_line":"                            VOLUME_IDs[req[\u0027virtualAttachment\u0027][\u0027node\u0027]]}"}],"source_content_type":"text/x-python","patch_set":3,"id":"8464f51a_2e5fb82a","line":415,"updated":"2020-11-25 00:01:38.000000000","message":"Let think the following case. There are two BlockStorages and BlockStorageAttachments, one of BlockStorage is defined by size and other is defined by volume_id.\nThis code is broken because both BlockStorageAttachments pass this route.\n\nThis should be\nif req[\u0027virtualAttachment\u0027][\u0027node\u0027] in VOLUME_IDs:\n\nBy the way, global value should not be used. I think it is better to call get_volumes again in this method, or pass volume dict to this method (i.e. get_vol_attachments(templete, volume_dict)).","commit_id":"540a5ec0d0431b1f3715324dc587ee99219f092d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9d0353d0de14a64d7ed91644e25fefc2ca3c2f6e","unresolved":true,"context_lines":[{"line_number":416,"context_line":"                            [\u0027volume_id\u0027]}"},{"line_number":417,"context_line":"                else:"},{"line_number":418,"context_line":"                    vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d \\"},{"line_number":419,"context_line":"                        {\u0027get_resource\u0027: req[\u0027virtualAttachment\u0027][\u0027node\u0027]}"},{"line_number":420,"context_line":"        del node_tpl[node_name]"},{"line_number":421,"context_line":"    return vol_attach_dict"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fca6b5bb_362fc18d","line":419,"updated":"2021-01-04 23:47:33.000000000","message":"It\u0027s OK logically but let me make more simple.\n--- L.411 to L.419---\nnode \u003d req[\u0027virtualAttachment\u0027][\u0027node\u0027]\nif \u0027volume_id\u0027 in volume_dict[node]:\n    value \u003d {\u0027get_param\u0027: volume_dict[node][\u0027volume_id\u0027]}\nelse:\n    value \u003d {\u0027get_resource\u0027: node}\nvol_attach_dict[node_name][\u0027volume_id\u0027] \u003d value\n---","commit_id":"16c7ae020660867b65fa9fe62c1afbbff61dabaa"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ae9431ae6d7a9b0f501897d576d74a0134a07bfd","unresolved":true,"context_lines":[{"line_number":416,"context_line":"                            [\u0027volume_id\u0027]}"},{"line_number":417,"context_line":"                else:"},{"line_number":418,"context_line":"                    vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d \\"},{"line_number":419,"context_line":"                        {\u0027get_resource\u0027: req[\u0027virtualAttachment\u0027][\u0027node\u0027]}"},{"line_number":420,"context_line":"        del node_tpl[node_name]"},{"line_number":421,"context_line":"    return vol_attach_dict"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9352b7a8_47581c46","line":419,"in_reply_to":"fca6b5bb_362fc18d","updated":"2021-01-04 23:57:20.000000000","message":"Oh, it\u0027s not equivalent.\n\u003e It\u0027s OK logically but let me make more simple.\n\u003e --- L.411 to L.419---\n\u003e node \u003d req[\u0027virtualAttachment\u0027][\u0027node\u0027]\n\u003e if \u0027volume_id\u0027 in volume_dict[node]:\n\nif \u0027volume_id\u0027 in volume_dict.get(node, {}):\n\n\u003e     value \u003d {\u0027get_param\u0027: volume_dict[node][\u0027volume_id\u0027]}\n\u003e else:\n\u003e     value \u003d {\u0027get_resource\u0027: node}\n\u003e vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d value\n\u003e ---","commit_id":"16c7ae020660867b65fa9fe62c1afbbff61dabaa"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d48a772c69c06c966244b30ed5dc9ce2075a8a31","unresolved":true,"context_lines":[{"line_number":408,"context_line":"                vol_attach_dict[node_name][\u0027instance_uuid\u0027] \u003d \\"},{"line_number":409,"context_line":"                    {\u0027get_resource\u0027: req[\u0027virtualBinding\u0027][\u0027node\u0027]}"},{"line_number":410,"context_line":"            elif \u0027virtualAttachment\u0027 in req:"},{"line_number":411,"context_line":"                node \u003d req[\u0027virtualAttachment\u0027][\u0027node\u0027]"},{"line_number":412,"context_line":"                if \u0027volume_id\u0027 in volume_dict.get(node, {}):"},{"line_number":413,"context_line":"                    value \u003d {\u0027get_param\u0027: volume_dict[node][\u0027volume_id\u0027]}"},{"line_number":414,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"007c661a_179e2cea","line":411,"updated":"2021-01-05 23:33:36.000000000","message":"note: \"node\" is to not replicate \"req[\u0027virtualAttachment\u0027][\u0027node\u0027]\".","commit_id":"266da696b8cf08ab486af3aa8d865363273ed114"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"972a3d23fd6bd87e3bfc0156eb209effb2b64e3c","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                vol_attach_dict[node_name][\u0027instance_uuid\u0027] \u003d \\"},{"line_number":409,"context_line":"                    {\u0027get_resource\u0027: req[\u0027virtualBinding\u0027][\u0027node\u0027]}"},{"line_number":410,"context_line":"            elif \u0027virtualAttachment\u0027 in req:"},{"line_number":411,"context_line":"                node \u003d req[\u0027virtualAttachment\u0027][\u0027node\u0027]"},{"line_number":412,"context_line":"                if \u0027volume_id\u0027 in volume_dict.get(node, {}):"},{"line_number":413,"context_line":"                    value \u003d {\u0027get_param\u0027: volume_dict[node][\u0027volume_id\u0027]}"},{"line_number":414,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"801ac9e5_fe228ef8","line":411,"in_reply_to":"007c661a_179e2cea","updated":"2021-01-06 17:02:13.000000000","message":"Ack","commit_id":"266da696b8cf08ab486af3aa8d865363273ed114"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d48a772c69c06c966244b30ed5dc9ce2075a8a31","unresolved":true,"context_lines":[{"line_number":412,"context_line":"                if \u0027volume_id\u0027 in volume_dict.get(node, {}):"},{"line_number":413,"context_line":"                    value \u003d {\u0027get_param\u0027: volume_dict[node][\u0027volume_id\u0027]}"},{"line_number":414,"context_line":"                else:"},{"line_number":415,"context_line":"                    value \u003d {\u0027get_resource\u0027: req[\u0027virtualAttachment\u0027][\u0027node\u0027]}"},{"line_number":416,"context_line":"                vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d value"},{"line_number":417,"context_line":"        del node_tpl[node_name]"},{"line_number":418,"context_line":"    return vol_attach_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"98a8c088_6263be30","line":415,"updated":"2021-01-05 23:33:36.000000000","message":"value \u003d {\u0027get_resource\u0027: node}","commit_id":"266da696b8cf08ab486af3aa8d865363273ed114"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"972a3d23fd6bd87e3bfc0156eb209effb2b64e3c","unresolved":false,"context_lines":[{"line_number":412,"context_line":"                if \u0027volume_id\u0027 in volume_dict.get(node, {}):"},{"line_number":413,"context_line":"                    value \u003d {\u0027get_param\u0027: volume_dict[node][\u0027volume_id\u0027]}"},{"line_number":414,"context_line":"                else:"},{"line_number":415,"context_line":"                    value \u003d {\u0027get_resource\u0027: req[\u0027virtualAttachment\u0027][\u0027node\u0027]}"},{"line_number":416,"context_line":"                vol_attach_dict[node_name][\u0027volume_id\u0027] \u003d value"},{"line_number":417,"context_line":"        del node_tpl[node_name]"},{"line_number":418,"context_line":"    return vol_attach_dict"}],"source_content_type":"text/x-python","patch_set":5,"id":"1b95d97d_f1995c19","line":415,"in_reply_to":"98a8c088_6263be30","updated":"2021-01-06 17:02:13.000000000","message":"Done","commit_id":"266da696b8cf08ab486af3aa8d865363273ed114"}]}