)]}'
{"tacker/tests/functional/base.py":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"904a7e36ed0c65b62142a16b7e5cf23777d54d59","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                vnf_result \u003d self.client.show_vnf(vnf_id)"},{"line_number":249,"context_line":"                status \u003d vnf_result[\u0027vnf\u0027][\u0027status\u0027]"},{"line_number":250,"context_line":"                if status !\u003d \u0027PENDING_DELETE\u0027:"},{"line_number":251,"context_line":"                    raise Exception(\"Failed with status: %s\" % status)"},{"line_number":252,"context_line":"            except exceptions.NotFound:"},{"line_number":253,"context_line":"                return"},{"line_number":254,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_3023a307","line":251,"updated":"2020-11-05 22:26:58.000000000","message":"This exception will be catched by line 254. Is this your intention ?","commit_id":"9c74b8f2382d6335aa7ce651f5ca1e97d4ac819b"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"e368ec3180b0f53d37faef22435fab5fd26b9f4a","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                vnf_result \u003d self.client.show_vnf(vnf_id)"},{"line_number":249,"context_line":"                status \u003d vnf_result[\u0027vnf\u0027][\u0027status\u0027]"},{"line_number":250,"context_line":"                if status !\u003d \u0027PENDING_DELETE\u0027:"},{"line_number":251,"context_line":"                    raise Exception(\"Failed with status: %s\" % status)"},{"line_number":252,"context_line":"            except exceptions.NotFound:"},{"line_number":253,"context_line":"                return"},{"line_number":254,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_135b11f7","line":251,"in_reply_to":"1f621f24_3023a307","updated":"2020-11-05 23:23:38.000000000","message":"Thanks, I\u0027ll fix it later.","commit_id":"9c74b8f2382d6335aa7ce651f5ca1e97d4ac819b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e153912f853ce8c10d68744ff7fcd57397277b55","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def wait_until_vnf_status(self, vnf_id, target_status, timeout,"},{"line_number":208,"context_line":"                              sleep_interval):"},{"line_number":209,"context_line":"        start_time \u003d int(time.time())"},{"line_number":210,"context_line":"        while True:"},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                vnf_result \u003d self.client.show_vnf(vnf_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_76ba210a","line":209,"updated":"2020-11-08 23:04:42.000000000","message":"add the following code after this line.\n\nstatus \u003d None\n\nBecause if all show_vnf in the while loop faied, status referenced by line 223 is undefined.","commit_id":"684acb93ad89f6cb428d355509c27cff3db0ae16"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"1bdf45460e77456dfac192f94ecc91ca0fddbe90","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def wait_until_vnf_status(self, vnf_id, target_status, timeout,"},{"line_number":208,"context_line":"                              sleep_interval):"},{"line_number":209,"context_line":"        start_time \u003d int(time.time())"},{"line_number":210,"context_line":"        while True:"},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                vnf_result \u003d self.client.show_vnf(vnf_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_56fa85bc","line":209,"in_reply_to":"1f621f24_76ba210a","updated":"2020-11-09 00:03:44.000000000","message":"Done","commit_id":"684acb93ad89f6cb428d355509c27cff3db0ae16"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e153912f853ce8c10d68744ff7fcd57397277b55","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            if status is not None and status !\u003d \u0027PENDING_DELETE\u0027:"},{"line_number":257,"context_line":"                raise Exception(\"Failed with status: %s\" % status)"},{"line_number":258,"context_line":"            elif int(time.time()) - start_time \u003e timeout:"},{"line_number":259,"context_line":"                raise Exception(\"Timeout waiting unil vnf %s deleted.\","},{"line_number":260,"context_line":"                                vnf_id)"},{"line_number":261,"context_line":"            time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_d63855a1","line":258,"updated":"2020-11-08 23:04:42.000000000","message":"nit: \u0027if\u0027 is OK instead of \u0027elif\u0027.","commit_id":"684acb93ad89f6cb428d355509c27cff3db0ae16"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"1bdf45460e77456dfac192f94ecc91ca0fddbe90","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"            if status is not None and status !\u003d \u0027PENDING_DELETE\u0027:"},{"line_number":257,"context_line":"                raise Exception(\"Failed with status: %s\" % status)"},{"line_number":258,"context_line":"            elif int(time.time()) - start_time \u003e timeout:"},{"line_number":259,"context_line":"                raise Exception(\"Timeout waiting unil vnf %s deleted.\","},{"line_number":260,"context_line":"                                vnf_id)"},{"line_number":261,"context_line":"            time.sleep(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f621f24_36f709d6","line":258,"in_reply_to":"1f621f24_d63855a1","updated":"2020-11-09 00:03:44.000000000","message":"Done","commit_id":"684acb93ad89f6cb428d355509c27cff3db0ae16"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b8bee538ee6b10bc31247a71c5978e7d470d3e2c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            if status is not None and status !\u003d \u0027PENDING_DELETE\u0027:"},{"line_number":258,"context_line":"                raise Exception(\"Failed with status: %s\" % status)"},{"line_number":259,"context_line":"            if int(time.time()) - start_time \u003e timeout:"},{"line_number":260,"context_line":"                raise Exception(\"Timeout waiting unil vnf %s deleted.\","},{"line_number":261,"context_line":"                                vnf_id)"},{"line_number":262,"context_line":"            time.sleep(1)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f621f24_7505f645","line":260,"range":{"start_line":260,"start_character":49,"end_line":260,"end_character":53},"updated":"2020-11-09 10:13:10.000000000","message":"Correct typo, or it might be better to make it simple, such as \"Timeout for deleting vnf %s\".","commit_id":"9db07add2d3f68a3e9d9aa578d9c0745e58905f8"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"c959c9640fdb6948e5124402d4003424d2f1057f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            if status is not None and status !\u003d \u0027PENDING_DELETE\u0027:"},{"line_number":258,"context_line":"                raise Exception(\"Failed with status: %s\" % status)"},{"line_number":259,"context_line":"            if int(time.time()) - start_time \u003e timeout:"},{"line_number":260,"context_line":"                raise Exception(\"Timeout waiting unil vnf %s deleted.\","},{"line_number":261,"context_line":"                                vnf_id)"},{"line_number":262,"context_line":"            time.sleep(1)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f621f24_5820ef48","line":260,"range":{"start_line":260,"start_character":49,"end_line":260,"end_character":53},"in_reply_to":"1f621f24_7505f645","updated":"2020-11-09 10:59:16.000000000","message":"Thanks! I\u0027ve just pushed Patch Set 6. PTAL.","commit_id":"9db07add2d3f68a3e9d9aa578d9c0745e58905f8"},{"author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"change_message_id":"71147379b3190f5c40e37746a4ae6301d44e89f0","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            if int(time.time()) - start_time \u003e timeout:"},{"line_number":260,"context_line":"                raise Exception(\"Timeout for deleting vnf %s.\","},{"line_number":261,"context_line":"                                vnf_id)"},{"line_number":262,"context_line":"            time.sleep(1)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def wait_until_vnf_dead(self, vnf_id, timeout, sleep_interval):"},{"line_number":265,"context_line":"        self.wait_until_vnf_status(vnf_id, \u0027DEAD\u0027, timeout,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_8429829c","line":262,"range":{"start_line":262,"start_character":12,"end_line":262,"end_character":25},"updated":"2020-11-09 15:42:32.000000000","message":"it\u0027s better to use sleep_interval here","commit_id":"e21e7e653e06ae98d9ed4ded226fd4bbc8dc87f5"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"2ae420898b21436264daca8caab337df842349f9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            if int(time.time()) - start_time \u003e timeout:"},{"line_number":260,"context_line":"                raise Exception(\"Timeout for deleting vnf %s.\","},{"line_number":261,"context_line":"                                vnf_id)"},{"line_number":262,"context_line":"            time.sleep(1)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def wait_until_vnf_dead(self, vnf_id, timeout, sleep_interval):"},{"line_number":265,"context_line":"        self.wait_until_vnf_status(vnf_id, \u0027DEAD\u0027, timeout,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f621f24_9aaf0029","line":262,"range":{"start_line":262,"start_character":12,"end_line":262,"end_character":25},"in_reply_to":"1f621f24_8429829c","updated":"2020-11-11 04:41:38.000000000","message":"Fair enough, I\u0027ll add a default parameter \"sleep_interval\" to `wait_until_vnf_delete`. PTAL at the next patch set. Thanks.","commit_id":"e21e7e653e06ae98d9ed4ded226fd4bbc8dc87f5"}]}