)]}'
{"id":"openstack%2Ftacker~760281","triplet_id":"openstack%2Ftacker~master~I8bd2f7e021476470df6131a7ac8abd402e6e1bd1","project":"openstack/tacker","branch":"master","topic":"fix/ft","hashtags":[],"change_id":"I8bd2f7e021476470df6131a7ac8abd402e6e1bd1","subject":"Fix and avoid an erroneous heat API call","status":"MERGED","created":"2020-10-29 03:52:19.000000000","updated":"2020-11-06 02:45:53.000000000","submitted":"2020-11-06 02:44:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"760281-1604630667717-b61dc1be","meta_rev_id":"73b064dc3e613d6ca054fe74832dadc207325bdc","_number":760281,"virtual_id_number":760281,"owner":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-11-06 02:44:27.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"recommended":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"all":[{"value":1,"date":"2020-11-05 22:37:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"value":2,"date":"2020-11-06 01:10:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":1,"date":"2020-11-06 00:57:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":2,"date":"2020-11-06 02:25:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"all":[{"value":0,"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":1,"date":"2020-11-06 02:25:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-31 15:35:51.000000000","updated_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2020-11-05 22:37:47.000000000","updated_by":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"reviewer":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"state":"REVIEWER"},{"updated":"2020-11-06 00:57:15.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"state":"REVIEWER"},{"updated":"2020-11-06 01:10:36.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2020-11-06 02:25:31.000000000","updated_by":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2020-11-06 02:44:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"728507052f6059d0922990381df06df797b8a86c","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2020-10-29 03:52:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b9169d68f8642d7898e12318f483a33c242b3018","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-29 06:01:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b9a28aa71bbe4209873e3399106b03f8 : SUCCESS in 6m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d4de6542a97b4c5c86ab26409787e2cd : SUCCESS in 14m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b20bfd5b1e7647b5945686ba8826722d : SUCCESS in 4m 49s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b110fc0daa2941b9a8c1d612b141c312 : SUCCESS in 13m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e1bc3d4e3e504bf1ba0ca2d409051025 : SUCCESS in 12m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a31763ce28834090baf4de523f85b074 : SUCCESS in 5m 58s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/8ddc275f0de84aa397f33fc5212a2045 : FAILURE in 1h 45m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5f3b8c70ba92b757cfe2f74cfddf289186a943e3","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2020-10-31 15:35:51.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9d701e707e5fbf1bf77c9b0defaa420999f48516","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-11-04 12:37:58.000000000","message":"Patch Set 1: Code-Review-1\n\nThe source code looks fine. Could you please add a description of the fix in commit message body.","accounts_in_message":[],"_revision_number":1},{"id":"ce24e8df04a7a2a6381482fd2f1f6629e411ffa0","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2020-11-05 12:28:51.000000000","message":"Patch Set 1:\n\nThanks for the comment. I\u0027ll push Patch Set 2 shortly.","accounts_in_message":[],"_revision_number":1},{"id":"7245a1f69ff2fe2a895d63ffea1e8e829350997a","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2020-11-05 12:29:10.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ad1acd1c347f1f4786d1912462ea7c078f25c2e2","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2020-11-05 12:35:55.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"6267e12b56851ed3afc130f58c5630cb0a706dfa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-05 14:44:01.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7eddb047b6534e94a6dd4235502b9079 : SUCCESS in 8m 24s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/183ca06e1b4b472191b577b4f62aad39 : SUCCESS in 13m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c96ac5f2bb824e758134efcc8058f737 : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/470fdab57cb64347b34eaad8902ae848 : SUCCESS in 13m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b3b6772386014cf18ba71c9a3289f94a : SUCCESS in 13m 03s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/578d251cfba649d7b92eb57e3f439898 : FAILURE in 13m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5dcbba59c13b442fab950cc334c33658 : SUCCESS in 7m 56s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/f36bb7995575410895f3c39de8bc7ab4 : FAILURE in 1h 53m 55s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"74f7285e0a05cc9416319878b4eb2b5f54dde4af","author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"date":"2020-11-05 22:37:47.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"dcdd62202c0fb19d4b120752a9fc3c8bb8319b49","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-11-06 00:57:15.000000000","message":"Patch Set 3: Code-Review+1\n\nThank you for detail commit message.","accounts_in_message":[],"_revision_number":3},{"id":"e005be6f2fdabe7c8b6615c2596968e77bca29fd","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2020-11-06 01:10:36.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1aebcf72d03f47e8ff6f2786036521560f5d9df9","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2020-11-06 02:25:31.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"92727e45b1e1b4953ed31e6685e5d00e22333ce8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 02:25:47.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"8b9dc3b04c9b772c8ef1e2739f6bfb5536d5e174","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 02:44:27.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1c0d66d9eeb444a2a75c440a239aa176 : SUCCESS in 13m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4ce57073b2a14cc2b6052c3632b3d851 : SUCCESS in 4m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ccacc9bbc20b49438313e15e3147d4cf : SUCCESS in 13m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2f0bf9cf0168426481dd4de3528dfe16 : SUCCESS in 13m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/329b407030c54879a6c6d77dee68b1b5 : SUCCESS in 7m 37s","accounts_in_message":[],"_revision_number":3},{"id":"0abc8eabd718aaeb986976f6a0d171f580eea1ab","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 02:44:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"bed7651e254f5fefb512bfdaf4f488b431eeb196","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-06 02:45:53.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cf0233bc10234a1d83fcfb5cdb85de21 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3798c9f92558116a1821cc0cd4151aebb127e3cd","revisions":{"71bea01674ab8667ff5c90e958a8457a189c444c":{"kind":"REWORK","_number":1,"created":"2020-10-29 03:52:19.000000000","uploader":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"ref":"refs/changes/81/760281/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/81/760281/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/81/760281/1"}}},"commit":{"parents":[{"commit":"1a98ddf42beadc8cd803485332e03948c92921ee","subject":"Merge \"Fix warnings for deprecated JSON policy file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/1a98ddf42beadc8cd803485332e03948c92921ee"}]}],"author":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2020-10-29 03:48:28.000000000","tz":540},"committer":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2020-10-29 03:48:28.000000000","tz":540},"subject":"Fix and avoid an erroneous heat API call","message":"Fix and avoid an erroneous heat API call\n\nRelated-Bug: #1886213\nChange-Id: I8bd2f7e021476470df6131a7ac8abd402e6e1bd1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/71bea01674ab8667ff5c90e958a8457a189c444c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/71bea01674ab8667ff5c90e958a8457a189c444c"}]},"branch":"refs/heads/master"},"fa9d04ef20b4a4de982c0761615e914594512536":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-11-05 12:29:10.000000000","uploader":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"ref":"refs/changes/81/760281/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/81/760281/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/81/760281/2"}}},"commit":{"parents":[{"commit":"1a98ddf42beadc8cd803485332e03948c92921ee","subject":"Merge \"Fix warnings for deprecated JSON policy file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/1a98ddf42beadc8cd803485332e03948c92921ee"}]}],"author":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2020-10-29 03:48:28.000000000","tz":540},"committer":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2020-11-05 12:26:26.000000000","tz":540},"subject":"Fix and avoid an erroneous heat API call","message":"Fix and avoid an erroneous heat API call\n\nWhen the vnf maintenance plugin\u0027s implementation of\nproject_instance_pre() is called, vnf instance id is likely to be empty\nbecause, for instance, the stack creation itself has not been done for\nsome reason.\n\nThis resolves a FT failue: vnfm.test_vnf_placement_policy.VnfTestCreate\n.test_vnf_with_placement_policy_invalid. _get_instances_with_openstack()\nis called on the cleanup path (delete_vnfd), though the vnf instance id\nis not present because create_vnf must have failed due to the invalid\nplacement policy. And you must have seen the following error message in\nthe tacker-server log: \"heatclient.exc.HTTPNotFound: ERROR:\nThe Stack (None) could not be found.\", which masked the expected\ntacker.extensions.vnfm.HeatClientException: \"[\"invalid\"] is not an\nallowed value [\"anti-affinity\", \"affinity\", \"soft-anti-affinity\",\n\"soft-affinity\"].\n\nRelated-Bug: #1886213\nChange-Id: I8bd2f7e021476470df6131a7ac8abd402e6e1bd1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/fa9d04ef20b4a4de982c0761615e914594512536"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/fa9d04ef20b4a4de982c0761615e914594512536"}]},"branch":"refs/heads/master"},"3798c9f92558116a1821cc0cd4151aebb127e3cd":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2020-11-05 12:35:55.000000000","uploader":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"ref":"refs/changes/81/760281/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/81/760281/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/81/760281/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/81/760281/3"}}},"commit":{"parents":[{"commit":"25f93312c1cd0173420c77372b25bb15be059236","subject":"Merge \"Introduce FT keystone client initialization retry\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/25f93312c1cd0173420c77372b25bb15be059236"}]}],"author":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2020-10-29 03:48:28.000000000","tz":540},"committer":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2020-11-05 12:35:55.000000000","tz":0},"subject":"Fix and avoid an erroneous heat API call","message":"Fix and avoid an erroneous heat API call\n\nWhen the vnf maintenance plugin\u0027s implementation of\nproject_instance_pre() is called, vnf instance id is likely to be empty\nbecause, for instance, the stack creation itself has not been done for\nsome reason.\n\nThis resolves a FT failue: vnfm.test_vnf_placement_policy.VnfTestCreate\n.test_vnf_with_placement_policy_invalid. _get_instances_with_openstack()\nis called on the cleanup path (delete_vnfd), though the vnf instance id\nis not present because create_vnf must have failed due to the invalid\nplacement policy. And you must have seen the following error message in\nthe tacker-server log: \"heatclient.exc.HTTPNotFound: ERROR:\nThe Stack (None) could not be found.\", which masked the expected\ntacker.extensions.vnfm.HeatClientException: \"[\"invalid\"] is not an\nallowed value [\"anti-affinity\", \"affinity\", \"soft-anti-affinity\",\n\"soft-affinity\"].\n\nRelated-Bug: #1886213\nChange-Id: I8bd2f7e021476470df6131a7ac8abd402e6e1bd1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/3798c9f92558116a1821cc0cd4151aebb127e3cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/3798c9f92558116a1821cc0cd4151aebb127e3cd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
