)]}'
{"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"d1293ed7ad2fbd1e333dfe7c329bbe6e99583264","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            return wsgi.ResponseObject(result, headers\u003dheaders)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        except nfvo.VimDefaultNotDefined as exc:"},{"line_number":460,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dsix.text_type(exc))"},{"line_number":461,"context_line":"        except(sqlexc.SQLAlchemyError, Exception) as exc:"},{"line_number":462,"context_line":"            raise webob.exc.HTTPInternalServerError("},{"line_number":463,"context_line":"                explanation\u003dstr(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_5b7cbbea","line":460,"updated":"2020-11-02 13:03:48.000000000","message":"pep8: F821 undefined name \u0027six\u0027","commit_id":"79ae3c48c7b67a2ef680d3c71a716845b0518809"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7da881a9315c3199fa2ab48c32d9a575284ecf8a","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            return wsgi.ResponseObject(result, headers\u003dheaders)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        except nfvo.VimDefaultNotDefined as exc:"},{"line_number":460,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dsix.text_type(exc))"},{"line_number":461,"context_line":"        except(sqlexc.SQLAlchemyError, Exception) as exc:"},{"line_number":462,"context_line":"            raise webob.exc.HTTPInternalServerError("},{"line_number":463,"context_line":"                explanation\u003dstr(exc))"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f621f24_8ab544d0","line":460,"updated":"2020-11-04 03:43:09.000000000","message":"pep8: F821 undefined name \u0027six\u0027","commit_id":"1ad8c7b525eb09052ec6fdf3eff74cb2cd175f6b"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"36dc748ce96793bdfd09291460b4b9b5cab49f4c","unresolved":true,"context_lines":[{"line_number":666,"context_line":"                        vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":667,"context_line":"                    if instance_id:"},{"line_number":668,"context_line":"                        # add instance_id info"},{"line_number":669,"context_line":"                        updated_values.update("},{"line_number":670,"context_line":"                            {"},{"line_number":671,"context_line":"                                \u0027instance_id\u0027: instance_id"},{"line_number":672,"context_line":"                            }"},{"line_number":673,"context_line":"                        )"},{"line_number":674,"context_line":"                vnf_model.update(updated_values)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"                for key, val in vnf_dict[\u0027attributes\u0027].items():"}],"source_content_type":"text/x-python","patch_set":21,"id":"fe8ef726_99b41e89","line":673,"range":{"start_line":669,"start_character":0,"end_line":673,"end_character":25},"updated":"2020-12-16 17:37:54.000000000","message":"Why don\u0027t you make it one line, length is \u003c80?","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"50705feda53407e1b9399099c389c0bf9835bf1b","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                        vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":667,"context_line":"                    if instance_id:"},{"line_number":668,"context_line":"                        # add instance_id info"},{"line_number":669,"context_line":"                        updated_values.update("},{"line_number":670,"context_line":"                            {"},{"line_number":671,"context_line":"                                \u0027instance_id\u0027: instance_id"},{"line_number":672,"context_line":"                            }"},{"line_number":673,"context_line":"                        )"},{"line_number":674,"context_line":"                vnf_model.update(updated_values)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"                for key, val in vnf_dict[\u0027attributes\u0027].items():"}],"source_content_type":"text/x-python","patch_set":21,"id":"66061538_290b4b0b","line":673,"range":{"start_line":669,"start_character":0,"end_line":673,"end_character":25},"in_reply_to":"fe8ef726_99b41e89","updated":"2020-12-18 03:12:15.000000000","message":"Done","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"4a694fd2514c54a09667604693b77ba817d6969a","unresolved":true,"context_lines":[{"line_number":666,"context_line":"                        vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":667,"context_line":"                    if instance_id:"},{"line_number":668,"context_line":"                        # add instance_id info"},{"line_number":669,"context_line":"                        updated_values.update({\u0027instance_id\u0027: instance_id})"},{"line_number":670,"context_line":"                vnf_model.update(updated_values)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"                for key, val in vnf_dict[\u0027attributes\u0027].items():"}],"source_content_type":"text/x-python","patch_set":23,"id":"90eeaf05_c2050579","line":669,"updated":"2020-12-22 23:14:24.000000000","message":"see. https://bugs.launchpad.net/tacker/+bug/1909011","commit_id":"bf51fb25a4e0c9bb293aff87a2df8c2eef23386c"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"97d14733f9e8a1432489c3f7d98cb41d24462a21","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                        vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":667,"context_line":"                    if instance_id:"},{"line_number":668,"context_line":"                        # add instance_id info"},{"line_number":669,"context_line":"                        updated_values.update({\u0027instance_id\u0027: instance_id})"},{"line_number":670,"context_line":"                vnf_model.update(updated_values)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"                for key, val in vnf_dict[\u0027attributes\u0027].items():"}],"source_content_type":"text/x-python","patch_set":23,"id":"93068d83_ad0e9e2b","line":669,"in_reply_to":"02d81a69_48b1ff7b","updated":"2020-12-23 01:04:23.000000000","message":"OK.","commit_id":"bf51fb25a4e0c9bb293aff87a2df8c2eef23386c"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2502d124e07ec3e9c7ab8f3ef87a07cc64f0a051","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                        vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":667,"context_line":"                    if instance_id:"},{"line_number":668,"context_line":"                        # add instance_id info"},{"line_number":669,"context_line":"                        updated_values.update({\u0027instance_id\u0027: instance_id})"},{"line_number":670,"context_line":"                vnf_model.update(updated_values)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"                for key, val in vnf_dict[\u0027attributes\u0027].items():"}],"source_content_type":"text/x-python","patch_set":23,"id":"777f9f43_121fe616","line":669,"in_reply_to":"63fd4946_f0427fee","updated":"2020-12-23 22:02:06.000000000","message":"Thank you for detail explanation, Yoshito. I totally agree with you.","commit_id":"bf51fb25a4e0c9bb293aff87a2df8c2eef23386c"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"2d82805048c3fc8b7f5eb1bb571b18c0468571ea","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                        vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":667,"context_line":"                    if instance_id:"},{"line_number":668,"context_line":"                        # add instance_id info"},{"line_number":669,"context_line":"                        updated_values.update({\u0027instance_id\u0027: instance_id})"},{"line_number":670,"context_line":"                vnf_model.update(updated_values)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"                for key, val in vnf_dict[\u0027attributes\u0027].items():"}],"source_content_type":"text/x-python","patch_set":23,"id":"02d81a69_48b1ff7b","line":669,"in_reply_to":"90eeaf05_c2050579","updated":"2020-12-23 00:49:22.000000000","message":"It has been agreed that this variable should be an uuid by previous spec.\nAt least it works correctly as a VNF, so it is no problem.\nIf there is an impact on DB by CNF implementation, it should be discussed with creating a new spec, I think.\n\ncf. https://specs.openstack.org/openstack/tacker-specs/specs/ussuri/etsi-nfv-sol-rest-api-for-VNF-deployment.html","commit_id":"bf51fb25a4e0c9bb293aff87a2df8c2eef23386c"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"83712c4357fac28d56d6dceb6d98521a8f6776f3","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                        vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":667,"context_line":"                    if instance_id:"},{"line_number":668,"context_line":"                        # add instance_id info"},{"line_number":669,"context_line":"                        updated_values.update({\u0027instance_id\u0027: instance_id})"},{"line_number":670,"context_line":"                vnf_model.update(updated_values)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"                for key, val in vnf_dict[\u0027attributes\u0027].items():"}],"source_content_type":"text/x-python","patch_set":23,"id":"63fd4946_f0427fee","line":669,"in_reply_to":"93068d83_ad0e9e2b","updated":"2020-12-23 07:08:16.000000000","message":"I believe we have no choice other than accepting this change.\n\nBut it\u0027s wrong to say this change is accepted in the spec because this part tries to store \"instance_id\" in \"vnf\" table, which is for Legacy implementation, and it\u0027s not described in the spec. The spec only describes for \"vnf_instantiated_info\" table. On the other hand, the existing implementation is already highly depending on \"vnf\" table. It\u0027s not easy to solve this dependency so we have to accept this logic to quickly fix the Scale operation now.\n\nAlso, let me say that \"instance_id\" in \"vnf_instantiated_info\" is already accepted to be changed to TEXT in the following spec in Victoria release.\n\nhttps://specs.openstack.org/openstack/tacker-specs/specs/victoria/container-network-function.html#data-model-impact","commit_id":"bf51fb25a4e0c9bb293aff87a2df8c2eef23386c"}],"tacker/db/migration/alembic_migrations/versions/df26c5871f3c_change_vnf_filter_column_definition.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b3eeb9fe2b1dfc0924911e9ab0ada2048256847f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # This migration file is to change syntax of \"GENERATED ALWAYS AS\" "},{"line_number":39,"context_line":"    # from \u0027filter\u0027 to `filter`"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    alter_sql_notification_types \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":42,"context_line":"        notification_types notification_types mediumblob GENERATED \\"},{"line_number":43,"context_line":"        ALWAYS AS (json_unquote(json_extract(`filter`,\\"},{"line_number":44,"context_line":"        \u0027$.notificationTypes\u0027))) VIRTUAL;\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    alter_sql_notification_types_len \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":47,"context_line":"        notification_types_len notification_types_len int(11) GENERATED \\"},{"line_number":48,"context_line":"        ALWAYS AS (ifnull(json_length(`notification_types`),0)) VIRTUAL;\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    alter_sql_operation_types \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":51,"context_line":"        operation_types operation_types mediumblob GENERATED ALWAYS AS \\"},{"line_number":52,"context_line":"        (json_unquote(json_extract(`filter`,\u0027$.operationTypes\u0027))) VIRTUAL;\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    alter_sql_operation_types_len \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":55,"context_line":"        operation_types_len operation_types_len int(11) GENERATED ALWAYS \\"},{"line_number":56,"context_line":"        AS (ifnull(json_length(`operation_types`),0)) VIRTUAL;\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    op.execute(alter_sql_notification_types)"},{"line_number":59,"context_line":"    op.execute(alter_sql_notification_types_len)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fffc6b78_6604d67c","line":56,"range":{"start_line":41,"start_character":0,"end_line":56,"end_character":63},"updated":"2020-11-19 01:54:47.000000000","message":"Could you tell me why you use raw sql although we use sqlalchemy?","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d0bb31ff4f694e958e63ef6c4450d3403593701","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    # This migration file is to change syntax of \"GENERATED ALWAYS AS\" "},{"line_number":39,"context_line":"    # from \u0027filter\u0027 to `filter`"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    alter_sql_notification_types \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":42,"context_line":"        notification_types notification_types mediumblob GENERATED \\"},{"line_number":43,"context_line":"        ALWAYS AS (json_unquote(json_extract(`filter`,\\"},{"line_number":44,"context_line":"        \u0027$.notificationTypes\u0027))) VIRTUAL;\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    alter_sql_notification_types_len \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":47,"context_line":"        notification_types_len notification_types_len int(11) GENERATED \\"},{"line_number":48,"context_line":"        ALWAYS AS (ifnull(json_length(`notification_types`),0)) VIRTUAL;\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    alter_sql_operation_types \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":51,"context_line":"        operation_types operation_types mediumblob GENERATED ALWAYS AS \\"},{"line_number":52,"context_line":"        (json_unquote(json_extract(`filter`,\u0027$.operationTypes\u0027))) VIRTUAL;\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    alter_sql_operation_types_len \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":55,"context_line":"        operation_types_len operation_types_len int(11) GENERATED ALWAYS \\"},{"line_number":56,"context_line":"        AS (ifnull(json_length(`operation_types`),0)) VIRTUAL;\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    op.execute(alter_sql_notification_types)"},{"line_number":59,"context_line":"    op.execute(alter_sql_notification_types_len)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aea0abb_19a08708","line":56,"range":{"start_line":41,"start_character":0,"end_line":56,"end_character":63},"in_reply_to":"fffc6b78_6604d67c","updated":"2020-12-07 10:31:34.000000000","message":"In this issue, \"GENERATED ALWAYS AS\" is used as the definition of the column. To avoid the issue, I tried changing code with using op.alter_column, but it didn\u0027t work correctly. Since an addition was supported in alembic 1.3.3, the change has not been supported. Due to this reason, I use raw SQL with op.exec.","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"36dc748ce96793bdfd09291460b4b9b5cab49f4c","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":38,"context_line":"    # This migration file is to change syntax of \"GENERATED ALWAYS AS\" "},{"line_number":39,"context_line":"    # from \u0027filter\u0027 to `filter`"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(esto-aln): (1) Need to fix SQL statement such that \"mediumblob\""}],"source_content_type":"text/x-python","patch_set":21,"id":"e7dd829a_05ed3880","line":38,"updated":"2020-12-16 17:37:54.000000000","message":"trailing whitespace","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"50705feda53407e1b9399099c389c0bf9835bf1b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":38,"context_line":"    # This migration file is to change syntax of \"GENERATED ALWAYS AS\" "},{"line_number":39,"context_line":"    # from \u0027filter\u0027 to `filter`"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(esto-aln): (1) Need to fix SQL statement such that \"mediumblob\""}],"source_content_type":"text/x-python","patch_set":21,"id":"71f83ddd_ebbc948d","line":38,"in_reply_to":"e7dd829a_05ed3880","updated":"2020-12-18 03:12:15.000000000","message":"Done","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"36dc748ce96793bdfd09291460b4b9b5cab49f4c","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    # TODO(esto-aln): (1) Need to fix SQL statement such that \"mediumblob\""},{"line_number":42,"context_line":"    # is used instead of \"text\". Currently, \"text\" is used as a workaround."},{"line_number":43,"context_line":"    # (2) Need to fix SQL statement to utilize sqlalchemy. Currently, we"},{"line_number":44,"context_line":"    # use raw SQL with op.exec as a workaround since op.alter_column does "},{"line_number":45,"context_line":"    # not work correctly."},{"line_number":46,"context_line":"    alter_sql_notification_types \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":47,"context_line":"        notification_types notification_types text GENERATED \\"}],"source_content_type":"text/x-python","patch_set":21,"id":"d3eea64b_6041d1fe","line":44,"updated":"2020-12-16 17:37:54.000000000","message":"ditto","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"50705feda53407e1b9399099c389c0bf9835bf1b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # TODO(esto-aln): (1) Need to fix SQL statement such that \"mediumblob\""},{"line_number":42,"context_line":"    # is used instead of \"text\". Currently, \"text\" is used as a workaround."},{"line_number":43,"context_line":"    # (2) Need to fix SQL statement to utilize sqlalchemy. Currently, we"},{"line_number":44,"context_line":"    # use raw SQL with op.exec as a workaround since op.alter_column does "},{"line_number":45,"context_line":"    # not work correctly."},{"line_number":46,"context_line":"    alter_sql_notification_types \u003d \"ALTER TABLE vnf_lcm_filters CHANGE \\"},{"line_number":47,"context_line":"        notification_types notification_types text GENERATED \\"}],"source_content_type":"text/x-python","patch_set":21,"id":"2efa7deb_1838c349","line":44,"in_reply_to":"d3eea64b_6041d1fe","updated":"2020-12-18 03:12:15.000000000","message":"Done","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"36dc748ce96793bdfd09291460b4b9b5cab49f4c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    op.execute(alter_sql_operation_types)"},{"line_number":66,"context_line":"    op.execute(alter_sql_operation_types_len)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":21,"id":"fc42f6d0_8848284b","line":68,"updated":"2020-12-16 17:37:54.000000000","message":"Should it be removed? If so, you have made same mistake in `d25c7c86..._mod_vnflcm_subscription.py:85`","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"50705feda53407e1b9399099c389c0bf9835bf1b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    op.execute(alter_sql_operation_types)"},{"line_number":66,"context_line":"    op.execute(alter_sql_operation_types_len)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":21,"id":"f6cb4252_422b06cb","line":68,"in_reply_to":"fc42f6d0_8848284b","updated":"2020-12-18 03:12:15.000000000","message":"It is removed. As for d25c7c86..._mod_vnflcm_subscription.py, also fixed in this patch since the change is so small.","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"}],"tacker/db/vnfm/vnfm_db.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"af5f9d9f365713334baf929409333be657dc131b","unresolved":true,"context_lines":[{"line_number":446,"context_line":"    # intsance_id \u003d None means error on creation"},{"line_number":447,"context_line":"    def _create_vnf_post(self, context, vnf_id, instance_id,"},{"line_number":448,"context_line":"                         mgmt_ip_address, vnf_dict):"},{"line_number":449,"context_line":"        LOG.debug(\u0027vnf_dict %s\u0027 % vnf_dict)"},{"line_number":450,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":451,"context_line":"            query \u003d (self._model_query(context, VNF)."},{"line_number":452,"context_line":"                     filter(VNF.id \u003d\u003d vnf_id)."}],"source_content_type":"text/x-python","patch_set":19,"id":"a7b40694_a2fd5d8a","line":449,"updated":"2020-12-15 02:36:58.000000000","message":"I think it\u0027s a fix for improving log output, but it doesn\u0027t seem to be included in the commit message, so please add it.","commit_id":"744710740d26e386e6c10d06f12e59041d75e21a"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"36e72e4f439ba8ad58961580b3f225a5fee9bc25","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    # intsance_id \u003d None means error on creation"},{"line_number":447,"context_line":"    def _create_vnf_post(self, context, vnf_id, instance_id,"},{"line_number":448,"context_line":"                         mgmt_ip_address, vnf_dict):"},{"line_number":449,"context_line":"        LOG.debug(\u0027vnf_dict %s\u0027 % vnf_dict)"},{"line_number":450,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":451,"context_line":"            query \u003d (self._model_query(context, VNF)."},{"line_number":452,"context_line":"                     filter(VNF.id \u003d\u003d vnf_id)."}],"source_content_type":"text/x-python","patch_set":19,"id":"23a5e720_b64a92ef","line":449,"in_reply_to":"a7b40694_a2fd5d8a","updated":"2020-12-15 06:06:51.000000000","message":"The commit message is updated.","commit_id":"744710740d26e386e6c10d06f12e59041d75e21a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"36dc748ce96793bdfd09291460b4b9b5cab49f4c","unresolved":true,"context_lines":[{"line_number":446,"context_line":"    # intsance_id \u003d None means error on creation"},{"line_number":447,"context_line":"    def _create_vnf_post(self, context, vnf_id, instance_id,"},{"line_number":448,"context_line":"                         mgmt_ip_address, vnf_dict):"},{"line_number":449,"context_line":"        LOG.debug(\u0027vnf_dict %s\u0027 % vnf_dict)"},{"line_number":450,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":451,"context_line":"            query \u003d (self._model_query(context, VNF)."},{"line_number":452,"context_line":"                     filter(VNF.id \u003d\u003d vnf_id)."}],"source_content_type":"text/x-python","patch_set":21,"id":"0e9d57a8_c0ed5e36","line":449,"updated":"2020-12-16 17:37:54.000000000","message":"Why you change this one? It should be styled as `\u0027%s\u0027, msg` as before one?","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"50705feda53407e1b9399099c389c0bf9835bf1b","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    # intsance_id \u003d None means error on creation"},{"line_number":447,"context_line":"    def _create_vnf_post(self, context, vnf_id, instance_id,"},{"line_number":448,"context_line":"                         mgmt_ip_address, vnf_dict):"},{"line_number":449,"context_line":"        LOG.debug(\u0027vnf_dict %s\u0027 % vnf_dict)"},{"line_number":450,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":451,"context_line":"            query \u003d (self._model_query(context, VNF)."},{"line_number":452,"context_line":"                     filter(VNF.id \u003d\u003d vnf_id)."}],"source_content_type":"text/x-python","patch_set":21,"id":"9a357a20_5e4b9e8a","line":449,"in_reply_to":"0e9d57a8_c0ed5e36","updated":"2020-12-18 03:12:15.000000000","message":"Your understanding is correct. The change is reverted.\nAlso, the commit message is modified.","commit_id":"7b663a5496afcaa6c6804e7b013724e0b095966d"}],"tacker/tosca/utils.py":[{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"023a4943dc3df2e5af87f49c1f13f4e18b0f28f4","unresolved":false,"context_lines":[{"line_number":1321,"context_line":"            vdu \u003d policy_dict[\u0027targets\u0027]"},{"line_number":1322,"context_line":"            deltas \u003d policy_dict[\u0027properties\u0027][\u0027deltas\u0027]"},{"line_number":1323,"context_line":"            for delta_key, delta_dict in deltas.items():"},{"line_number":1324,"context_line":"                num \u003d delta_dict[\u0027number_of_instances\u0027]"},{"line_number":1325,"context_line":"            data_dict.update({"},{"line_number":1326,"context_line":"                aspect: {"},{"line_number":1327,"context_line":"                    \u0027vdu\u0027: vdu,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fffc6b78_06806a8b","line":1324,"updated":"2020-11-19 02:34:20.000000000","message":"Looks like non-uniform deltas are not covered. Is that your intention?","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"9912f6a8fc46f55dba74b387b8dba276a6607832","unresolved":false,"context_lines":[{"line_number":1321,"context_line":"            vdu \u003d policy_dict[\u0027targets\u0027]"},{"line_number":1322,"context_line":"            deltas \u003d policy_dict[\u0027properties\u0027][\u0027deltas\u0027]"},{"line_number":1323,"context_line":"            for delta_key, delta_dict in deltas.items():"},{"line_number":1324,"context_line":"                num \u003d delta_dict[\u0027number_of_instances\u0027]"},{"line_number":1325,"context_line":"            data_dict.update({"},{"line_number":1326,"context_line":"                aspect: {"},{"line_number":1327,"context_line":"                    \u0027vdu\u0027: vdu,"}],"source_content_type":"text/x-python","patch_set":14,"id":"8d54b937_933a8746","line":1324,"in_reply_to":"8cd5405e_64eb4acc","updated":"2020-12-07 13:11:08.000000000","message":"I understand (as per the relevant victoria spec), thanks.","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d0bb31ff4f694e958e63ef6c4450d3403593701","unresolved":false,"context_lines":[{"line_number":1321,"context_line":"            vdu \u003d policy_dict[\u0027targets\u0027]"},{"line_number":1322,"context_line":"            deltas \u003d policy_dict[\u0027properties\u0027][\u0027deltas\u0027]"},{"line_number":1323,"context_line":"            for delta_key, delta_dict in deltas.items():"},{"line_number":1324,"context_line":"                num \u003d delta_dict[\u0027number_of_instances\u0027]"},{"line_number":1325,"context_line":"            data_dict.update({"},{"line_number":1326,"context_line":"                aspect: {"},{"line_number":1327,"context_line":"                    \u0027vdu\u0027: vdu,"}],"source_content_type":"text/x-python","patch_set":14,"id":"8cd5405e_64eb4acc","line":1324,"in_reply_to":"fffc6b78_06806a8b","updated":"2020-12-07 10:31:34.000000000","message":"This is intentional coding since Scale should work sequentially with the same AspectId.","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"023a4943dc3df2e5af87f49c1f13f4e18b0f28f4","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"                levels \u003d policy_dict[\u0027properties\u0027][\u0027levels\u0027]"},{"line_number":1364,"context_line":"                scale_info \u003d levels[instantiation_level_id][\u0027scale_info\u0027]"},{"line_number":1365,"context_line":"                initial_level \u003d scale_info[aspect_name][\u0027scale_level\u0027]"},{"line_number":1366,"context_line":"                increase \u003d aspect_dict[\u0027num\u0027] * initial_level"},{"line_number":1367,"context_line":"                default \u003d aspect_dict[\u0027initialNum\u0027] + increase"},{"line_number":1368,"context_line":"                data_dict[aspect_name].update({\u0027initialLevel\u0027: initial_level,"},{"line_number":1369,"context_line":"                                               \u0027default\u0027: default})"}],"source_content_type":"text/x-python","patch_set":14,"id":"fffc6b78_c675c2ce","line":1366,"updated":"2020-11-19 02:34:20.000000000","message":"ditto","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"9912f6a8fc46f55dba74b387b8dba276a6607832","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"                levels \u003d policy_dict[\u0027properties\u0027][\u0027levels\u0027]"},{"line_number":1364,"context_line":"                scale_info \u003d levels[instantiation_level_id][\u0027scale_info\u0027]"},{"line_number":1365,"context_line":"                initial_level \u003d scale_info[aspect_name][\u0027scale_level\u0027]"},{"line_number":1366,"context_line":"                increase \u003d aspect_dict[\u0027num\u0027] * initial_level"},{"line_number":1367,"context_line":"                default \u003d aspect_dict[\u0027initialNum\u0027] + increase"},{"line_number":1368,"context_line":"                data_dict[aspect_name].update({\u0027initialLevel\u0027: initial_level,"},{"line_number":1369,"context_line":"                                               \u0027default\u0027: default})"}],"source_content_type":"text/x-python","patch_set":14,"id":"645c4fc8_21576780","line":1366,"in_reply_to":"da1bc2ee_2b16aab9","updated":"2020-12-07 13:11:08.000000000","message":"I understand (as per the relevant victoria spec), thanks.","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"},{"author":{"_account_id":31813,"name":"Koichi Edagawa","email":"edagawa.kc@nec.com","username":"k-edagawa"},"change_message_id":"7d0bb31ff4f694e958e63ef6c4450d3403593701","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"                levels \u003d policy_dict[\u0027properties\u0027][\u0027levels\u0027]"},{"line_number":1364,"context_line":"                scale_info \u003d levels[instantiation_level_id][\u0027scale_info\u0027]"},{"line_number":1365,"context_line":"                initial_level \u003d scale_info[aspect_name][\u0027scale_level\u0027]"},{"line_number":1366,"context_line":"                increase \u003d aspect_dict[\u0027num\u0027] * initial_level"},{"line_number":1367,"context_line":"                default \u003d aspect_dict[\u0027initialNum\u0027] + increase"},{"line_number":1368,"context_line":"                data_dict[aspect_name].update({\u0027initialLevel\u0027: initial_level,"},{"line_number":1369,"context_line":"                                               \u0027default\u0027: default})"}],"source_content_type":"text/x-python","patch_set":14,"id":"da1bc2ee_2b16aab9","line":1366,"in_reply_to":"fffc6b78_c675c2ce","updated":"2020-12-07 10:31:34.000000000","message":"This is intentional coding since Scale should work sequentially with the same AspectId.","commit_id":"f505a20857742865d9b564c8405219ef2c25c970"}]}