)]}'
{".zuul.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2b8a2105a630c1ec9ad2a56790122afdf85a7512","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    nodes:"},{"line_number":4,"context_line":"      - name: controller"},{"line_number":5,"context_line":"        label: ubuntu-focal"},{"line_number":6,"context_line":"      - name: sub-controller"},{"line_number":7,"context_line":"        label: ubuntu-focal"},{"line_number":8,"context_line":"      - name: compute1"},{"line_number":9,"context_line":"        label: ubuntu-focal"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"c0dcda60_093f8f71","line":6,"updated":"2020-12-15 05:08:46.000000000","message":"Could you suggest more specific name intuitive if possible for better understanding? I think it\u0027s better to use \u0027tacker\u0027 as a part of the name such as \u0027controller-tacker\u0027, \u0027tacker-node\u0027 or so for considering the role.","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"cc93a58102085dbfede3e301081e7f84a069b275","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    nodes:"},{"line_number":4,"context_line":"      - name: controller"},{"line_number":5,"context_line":"        label: ubuntu-focal"},{"line_number":6,"context_line":"      - name: sub-controller"},{"line_number":7,"context_line":"        label: ubuntu-focal"},{"line_number":8,"context_line":"      - name: compute1"},{"line_number":9,"context_line":"        label: ubuntu-focal"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"31c7705e_1b426db8","line":6,"in_reply_to":"c0dcda60_093f8f71","updated":"2020-12-15 05:44:32.000000000","message":"As noted in the commit message, tacker is not the only component which I think should be moved out of the main controller, which is why I named it like that. Yet it sounds fine so long as we don\u0027t forget to rename it when re-locating some other components.","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"}],"devstack/lib/tacker":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2b8a2105a630c1ec9ad2a56790122afdf85a7512","unresolved":true,"context_lines":[{"line_number":92,"context_line":"# ---------"},{"line_number":93,"context_line":"# Test if any Tacker services are enabled"},{"line_number":94,"context_line":"# is_tacker_enabled"},{"line_number":95,"context_line":"function is_tacker_enabled {"},{"line_number":96,"context_line":"    [[ ,${ENABLED_SERVICES} \u003d~ ,\"tacker\" ]] \u0026\u0026 return 0"},{"line_number":97,"context_line":"    return 1"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# create_tacker_cache_dir() - Part of the _tacker_setup_keystone() process"},{"line_number":101,"context_line":"function create_tacker_cache_dir {"}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"5969446c_7b178ab2","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":1},"updated":"2020-12-15 05:08:46.000000000","message":"I think this function should be remove because it\u0027s called from anywhere, and you\u0027ve removed `ENABLED_SERVICE` in `devstack/settings` in this update.","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"cc93a58102085dbfede3e301081e7f84a069b275","unresolved":true,"context_lines":[{"line_number":92,"context_line":"# ---------"},{"line_number":93,"context_line":"# Test if any Tacker services are enabled"},{"line_number":94,"context_line":"# is_tacker_enabled"},{"line_number":95,"context_line":"function is_tacker_enabled {"},{"line_number":96,"context_line":"    [[ ,${ENABLED_SERVICES} \u003d~ ,\"tacker\" ]] \u0026\u0026 return 0"},{"line_number":97,"context_line":"    return 1"},{"line_number":98,"context_line":"}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# create_tacker_cache_dir() - Part of the _tacker_setup_keystone() process"},{"line_number":101,"context_line":"function create_tacker_cache_dir {"}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"44050160_90d32e59","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":1},"in_reply_to":"5969446c_7b178ab2","updated":"2020-12-15 05:44:32.000000000","message":"Indeed. Thanks for spotting that!","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2b8a2105a630c1ec9ad2a56790122afdf85a7512","unresolved":true,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"function tacker_setup_default_vim_resources {"},{"line_number":445,"context_line":"    # Note: These must be the same as in tacker/tests/etc/samples/local-vim.yaml"},{"line_number":446,"context_line":"    # and devstack/lib/tacker/vim_config.yaml"},{"line_number":447,"context_line":"    DEFAULT_VIM_PROJECT_NAME\u003d\"nfv\""},{"line_number":448,"context_line":"    DEFAULT_VIM_USER\u003d\"nfv_user\""},{"line_number":449,"context_line":"    DEFAULT_VIM_PASSWORD\u003d\"devstack\""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"36326264_3c197ebd","line":446,"range":{"start_line":446,"start_character":10,"end_line":446,"end_character":45},"updated":"2020-12-15 05:08:46.000000000","message":"Could you fix here, `devstack/vim_config.yaml` correctly, although it\u0027s not your fault :)","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"cc93a58102085dbfede3e301081e7f84a069b275","unresolved":true,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"function tacker_setup_default_vim_resources {"},{"line_number":445,"context_line":"    # Note: These must be the same as in tacker/tests/etc/samples/local-vim.yaml"},{"line_number":446,"context_line":"    # and devstack/lib/tacker/vim_config.yaml"},{"line_number":447,"context_line":"    DEFAULT_VIM_PROJECT_NAME\u003d\"nfv\""},{"line_number":448,"context_line":"    DEFAULT_VIM_USER\u003d\"nfv_user\""},{"line_number":449,"context_line":"    DEFAULT_VIM_PASSWORD\u003d\"devstack\""}],"source_content_type":"application/x-shellscript","patch_set":32,"id":"74f95e39_4af67c2f","line":446,"range":{"start_line":446,"start_character":10,"end_line":446,"end_character":45},"in_reply_to":"36326264_3c197ebd","updated":"2020-12-15 05:44:32.000000000","message":"Sure!","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"}],"devstack/plugin.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2b8a2105a630c1ec9ad2a56790122afdf85a7512","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            echo_summary \"Check and download images for tacker initial\""},{"line_number":39,"context_line":"            tacker_check_and_download_images"},{"line_number":40,"context_line":"            echo_summary \"Setup default VIM resources\""},{"line_number":41,"context_line":"            tacker_setup_default_vim_resources"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            if is_service_enabled ceilometer; then"},{"line_number":44,"context_line":"                echo_summary \"Configure maintenance event types\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"3233c503_b0c42222","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":46},"updated":"2020-12-15 05:08:46.000000000","message":"Could I confirm the term \"_resources\" is necessary and why?","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"cc93a58102085dbfede3e301081e7f84a069b275","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            echo_summary \"Check and download images for tacker initial\""},{"line_number":39,"context_line":"            tacker_check_and_download_images"},{"line_number":40,"context_line":"            echo_summary \"Setup default VIM resources\""},{"line_number":41,"context_line":"            tacker_setup_default_vim_resources"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"            if is_service_enabled ceilometer; then"},{"line_number":44,"context_line":"                echo_summary \"Configure maintenance event types\""}],"source_content_type":"text/x-sh","patch_set":32,"id":"abd0e866_1de629e7","line":41,"range":{"start_line":41,"start_character":36,"end_line":41,"end_character":46},"in_reply_to":"3233c503_b0c42222","updated":"2020-12-15 05:44:32.000000000","message":"Cause otherwise it would sound like setting up a default VIM itself.","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"}],"roles/setup-default-vim/tasks/main.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2b8a2105a630c1ec9ad2a56790122afdf85a7512","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- block:"},{"line_number":2,"context_line":"  - name: Copy files test setup default vim sh"},{"line_number":3,"context_line":"    copy:"},{"line_number":4,"context_line":"       remote_src\u003dTrue"},{"line_number":5,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tools/test-setup-default-vim.sh"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"5c28d7b7_c7fbb5d8","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":46},"updated":"2020-12-15 05:08:46.000000000","message":"It\u0027s better to use the file name itself as third entry at line 15 because it looks wrong in grammar.","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"cc93a58102085dbfede3e301081e7f84a069b275","unresolved":true,"context_lines":[{"line_number":1,"context_line":"- block:"},{"line_number":2,"context_line":"  - name: Copy files test setup default vim sh"},{"line_number":3,"context_line":"    copy:"},{"line_number":4,"context_line":"       remote_src\u003dTrue"},{"line_number":5,"context_line":"       src\u003d{{ devstack_base_dir }}/tacker/tools/test-setup-default-vim.sh"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"521dcc97_6434c707","line":2,"range":{"start_line":2,"start_character":21,"end_line":2,"end_character":46},"in_reply_to":"5c28d7b7_c7fbb5d8","updated":"2020-12-15 05:44:32.000000000","message":"You\u0027re right, thanks!","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2b8a2105a630c1ec9ad2a56790122afdf85a7512","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    when:"},{"line_number":39,"context_line":"      - p.stat.exists"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - name: Replace the keystone authentication uri in the test-setup-default-vim.sh and local-vim.yaml"},{"line_number":42,"context_line":"    replace:"},{"line_number":43,"context_line":"       path: \"{{ item }}\""},{"line_number":44,"context_line":"       regexp: \"http://127.0.0.1/identity\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"933126cd_bec70281","line":41,"updated":"2020-12-15 05:08:46.000000000","message":"Could you make it a little bit shorter? For example, \"Replace auth uri in test-setup-default-vim.sh and local-vim.yaml\" is enough for me.","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"},{"author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"change_message_id":"cc93a58102085dbfede3e301081e7f84a069b275","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    when:"},{"line_number":39,"context_line":"      - p.stat.exists"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  - name: Replace the keystone authentication uri in the test-setup-default-vim.sh and local-vim.yaml"},{"line_number":42,"context_line":"    replace:"},{"line_number":43,"context_line":"       path: \"{{ item }}\""},{"line_number":44,"context_line":"       regexp: \"http://127.0.0.1/identity\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"61b92240_feadf4d7","line":41,"in_reply_to":"933126cd_bec70281","updated":"2020-12-15 05:44:32.000000000","message":"Sounds fine, thank you for your suggestion!","commit_id":"c2857afe9c83fae284f2876652466665c5e21627"}]}