)]}'
{"id":"openstack%2Ftacker~765227","triplet_id":"openstack%2Ftacker~master~Iee059c00df1be212ae69fbc77cb783748da206b1","project":"openstack/tacker","branch":"master","topic":"hacking","hashtags":[],"change_id":"Iee059c00df1be212ae69fbc77cb783748da206b1","subject":"Move tacker to new hacking 4.0.0","status":"MERGED","created":"2020-12-03 01:37:07.000000000","updated":"2020-12-07 05:32:06.000000000","submitted":"2020-12-07 05:30:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"765227-hacking","meta_rev_id":"5730f74d090438af462b4b9f714d92ca21318327","_number":765227,"virtual_id_number":765227,"owner":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-12-07 05:30:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"all":[{"value":2,"date":"2020-12-04 17:27:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":1,"date":"2020-12-04 16:15:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-12-07 05:02:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},{"value":1,"date":"2020-12-07 05:18:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":2,"date":"2020-12-07 05:12:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":1,"date":"2020-12-07 05:12:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"}],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-03 02:11:01.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2020-12-03 03:42:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-04 03:59:42.000000000","updated_by":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"reviewer":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"state":"REVIEWER"},{"updated":"2020-12-04 16:02:35.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2020-12-04 16:02:35.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2020-12-07 02:37:19.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2020-12-07 02:37:19.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2020-12-07 05:18:37.000000000","updated_by":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"reviewer":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"state":"REVIEWER"}],"messages":[{"id":"283806dab3cb0e93e53187737b70f0916a614148","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-12-03 01:37:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"74b4b29ff8fb7d6f3bb8d7155ca343273cec4505","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-12-03 02:16:37.000000000","message":"Patch Set 1: Code-Review-1\n\nthanks. also can you bump hacking version to 4.0.0 and see if any more thing to updates\n\nhacking\u003e\u003d4.0.0,\u003c4.0.1 # Apache-2.0 in \nhttps://github.com/openstack/tacker/blob/9e08ffb31cad3804a274443ac7659b5ca22cbe51/test-requirements.txt#L11","accounts_in_message":[],"_revision_number":1},{"id":"75e839aebeee1c18254967db91c001ea9de56d27","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-12-03 02:24:06.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e thanks. also can you bump hacking version to 4.0.0 and see if any more thing to updates\n\u003e \n\u003e hacking\u003e\u003d4.0.0,\u003c4.0.1 # Apache-2.0 in \n\u003e https://github.com/openstack/tacker/blob/9e08ffb31cad3804a274443ac7659b5ca22cbe51/test-requirements.txt#L11\n\nThanks will take care and do the needful.","accounts_in_message":[],"_revision_number":1},{"id":"116c8f3bf5d3fe640fea0efb72c170753b512aff","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-12-03 02:28:12.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e \u003e Patch Set 1: Code-Review-1\n\u003e \u003e \n\u003e \u003e thanks. also can you bump hacking version to 4.0.0 and see if any more thing to updates\n\u003e \u003e \n\u003e \u003e hacking\u003e\u003d4.0.0,\u003c4.0.1 # Apache-2.0 in \n\u003e \u003e https://github.com/openstack/tacker/blob/9e08ffb31cad3804a274443ac7659b5ca22cbe51/test-requirements.txt#L11\n\u003e \n\u003e Thanks will take care and do the needful.\n\ncool, basically with that, pep8 job will install hacking 4.0.0 and find if all checks are green in tacker code or not otherwise it keep testing with old hacking 3.0.1 and you do not find if new updates are ok or not.","accounts_in_message":[],"_revision_number":1},{"id":"0076fabf05c172078c891aba344d04f7335c74f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-03 03:42:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/eee7f1f63ce846bcac3ea0d9e5cbf200 : SUCCESS in 8m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8f3f9691a9fb405b90e0b064904317f2 : SUCCESS in 14m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/606541a636e643c0b09b19cc391b60f1 : SUCCESS in 5m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a4a8438847ea43ca8c386626f3a8cc14 : SUCCESS in 13m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d1c16fa69dff44699343e885973f83c8 : SUCCESS in 12m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/87bd1cf244e741eeb1eca56e1cf5780d : SUCCESS in 13m 50s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/beb7d348a779429f94f20911aa0e614d : SUCCESS in 6m 19s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/b6351c254db7402787bd8c69e35a33e0 : SUCCESS in 1h 47m 33s","accounts_in_message":[],"_revision_number":1},{"id":"0d32aa781d0af7f20e2be7644243cd1e4161ee73","author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"date":"2020-12-04 03:59:42.000000000","message":"Patch Set 1: Code-Review-1\n\nLgtm, thanks for contribute!\nbut some files seem still contains old assert checks?\n$ grep -r isinstance *\nobjects/test_vim_connection.py:        self.assertEqual(True, isinstance(result, objects.VimConnectionInfo))\nobjects/test_vim_connection.py:        self.assertEqual(True, isinstance(vim_connection_dict, dict))\ntosca/test_tosca_templates_under_samples.py:            if isinstance(tosca_files, list):\nvnfm/test_nfvo_client.py:            if isinstance(obj, datetime.datetime)","accounts_in_message":[],"_revision_number":1},{"id":"158ac588d0bd5dc425bc92e775342b598832a339","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-12-04 05:41:16.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e Lgtm, thanks for contribute!\n\u003e but some files seem still contains old assert checks?\n\u003e $ grep -r isinstance *\n\u003e objects/test_vim_connection.py:        self.assertEqual(True, isinstance(result, objects.VimConnectionInfo))\n\u003e objects/test_vim_connection.py:        self.assertEqual(True, isinstance(vim_connection_dict, dict))\n\u003e tosca/test_tosca_templates_under_samples.py:            if isinstance(tosca_files, list):\n\u003e vnfm/test_nfvo_client.py:            if isinstance(obj, datetime.datetime)\n\nThanks for your valuable feedback, would incorporate the changes in next patch.","accounts_in_message":[],"_revision_number":1},{"id":"b7b858ff0809878e4632e70583da5709e1a997c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-12-04 09:50:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3e8d856e2ca40c99672d3e516c58fadc94fdae03","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-04 11:53:57.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/9ecc87aff38a41c7b3678ea040749815 : SUCCESS in 5m 11s\n- requirements-check https://zuul.opendev.org/t/openstack/build/bb170bc5e68a4d29ba15db1686bc33fa : SUCCESS in 2m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3798026c05dc4b41b08af2f8f7e4f198 : SUCCESS in 8m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1605efcc73c34ad78e32276ba389363a : SUCCESS in 13m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3d15808a894e446ea8abc7567ce64cff : SUCCESS in 4m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4512059e5ec14d528d672faaa56fcbb3 : SUCCESS in 14m 06s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7ce97f2a269c488f966d00b93b531a07 : SUCCESS in 13m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9bc1b7884a544852a06a72dffa6c6196 : SUCCESS in 14m 28s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c8941a05d365453188362662b6cbfbbc : SUCCESS in 7m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3ae807ee81034fa89ffd5f384f9cd64c : SUCCESS in 5m 11s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/fb05f1a287de4e05a9f242a48c03c85c : FAILURE in 1h 45m 02s","accounts_in_message":[],"_revision_number":2},{"id":"09362b4e16e645e3af8c174c843426c5a67bb7d1","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-12-04 12:26:46.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"7a8778f2d9eceb9363cacc78a585b07bebb93bcf","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-12-04 12:28:19.000000000","message":"Topic remove-old-hack-chks removed","accounts_in_message":[],"_revision_number":2},{"id":"feb6cdcd94f80aea015aeda244c4e4edb517eeda","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2020-12-04 12:28:26.000000000","message":"Topic set to hacking","accounts_in_message":[],"_revision_number":2},{"id":"02018ad4197ee1a400de8b5d1f12c107d8964024","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-04 14:23:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/80698ee4dcee4f4887f2477a49103dd4 : SUCCESS in 4m 27s\n- requirements-check https://zuul.opendev.org/t/openstack/build/6c0c24fb1ed44b47bd42b5f03e53eee4 : SUCCESS in 3m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7ba9c94c63144ab59efdfc7c516ba876 : SUCCESS in 6m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f6d5f3cb65f24471b3107bd720610b75 : SUCCESS in 12m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/648faf48e64a4f22aad4a3674b5b56a8 : SUCCESS in 4m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5ca19a32cc2f45159ae02e14e8578ea0 : SUCCESS in 13m 25s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/199f267ff0d64dfc98d64007e98c396d : SUCCESS in 12m 38s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d06c52495c0240a9acb0f635018a5bdb : SUCCESS in 12m 34s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/39ff655224224d93835f1f431cfb8e33 : SUCCESS in 5m 54s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/82854ea3b20e43938574a785a3f14b41 : SUCCESS in 3m 57s\n- tacker-functional-devstack-multinode-python3 https://zuul.opendev.org/t/openstack/build/95a55005ef1b4b1286c739e7bdf615ff : SUCCESS in 1h 44m 24s","accounts_in_message":[],"_revision_number":2},{"id":"c67718c8c25625e166931f670f18deb1ff394135","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-12-04 16:15:09.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nthanks, lgtm I think tacker is first one to move towards hacking 4.0.0","accounts_in_message":[],"_revision_number":2},{"id":"e373cabce75b90cdd1bf98aef70beadc84c47bc3","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2020-12-04 17:27:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ffb46b5fcbfa88163f1daf53bfb904df7dbaf2cc","author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"date":"2020-12-07 05:02:36.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"459945a5a09b1d48166b9f9bf98a51c56d03eb70","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2020-12-07 05:12:48.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c1dbaee46f7067ba429a4c1d69a8226339aa6eba","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-07 05:13:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0b16e1df8719a98bd9f2c03022ef1aad0f82fd77","author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"date":"2020-12-07 05:18:37.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"cacf8506ee5d1bc66dc2f3275aa91dd4ddc61396","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-07 05:30:49.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/145231173e26499bad555e90f216afd8 : SUCCESS in 5m 09s\n- requirements-check https://zuul.opendev.org/t/openstack/build/0b134d86435a4d29a90e425b6eeaccf0 : SUCCESS in 2m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2f16a685bd884c4788af01bf33330b2a : SUCCESS in 13m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1aa1c019e48d4cf0bd62890046463197 : SUCCESS in 4m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b4ed51eede8e41d1abfb88672ea000ca : SUCCESS in 13m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/580a33c7bf674d7db149ba34972a9dda : SUCCESS in 12m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/30a24fa9cdcc4f26be2ba721c5cbc656 : SUCCESS in 6m 25s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ab41116f04224454accfbd6379fcdea0 : SUCCESS in 3m 40s","accounts_in_message":[],"_revision_number":2},{"id":"6d0f49cc706164f801534c889d8830009e5a4051","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-07 05:30:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5730f74d090438af462b4b9f714d92ca21318327","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-07 05:32:06.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-api-ref https://zuul.opendev.org/t/openstack/build/6774f0fb903d4fd1b58173986f2ca0ac : SUCCESS in 50s\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e260fa6ed8a24aa093e4f3282cd8b264 : SUCCESS in 50s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d383e65e75604bf988d0425ed8d61d12 : SUCCESS in 42s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2f3dc0a99136f8faf66b66a66f2b7149a14c0ef2","revisions":{"56fbb526488c48c75bcb76f033a68b493aa1fcb0":{"kind":"REWORK","_number":1,"created":"2020-12-03 01:37:07.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/27/765227/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/27/765227/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/27/765227/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/27/765227/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/27/765227/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/27/765227/1"}}},"commit":{"parents":[{"commit":"9e08ffb31cad3804a274443ac7659b5ca22cbe51","subject":"Merge \"Fix miscellaneous bugs found in VNF scaling guide\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9e08ffb31cad3804a274443ac7659b5ca22cbe51"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2020-12-03 01:30:59.000000000","tz":0},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2020-12-03 01:37:00.000000000","tz":0},"subject":"Add new optimal assert checks in tacker unit test","message":"Add new optimal assert checks in tacker unit test\n\nThis patch changes old assert checks in tacker unit test cases to new\noptimal assert checks provided by hacking plugin in release 4.0.0.\nPlease refer [1] for optimal assert checks details.\n\nThe patch modifies following,\n * Changes assertTrue(isinstance(A, B)) to assertIsInstance(A, B).\n * Changes assertEqual(type(A), B) to assertIsInstance(A, B).\n * Changes assertTrue(A not in B, message) to the more specific\n   assertNotIn(A, B, message).\n\n[1] https://docs.openstack.org/releasenotes/hacking/unreleased.html#relnotes-4-0-0\n\nChange-Id: Iee059c00df1be212ae69fbc77cb783748da206b1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/56fbb526488c48c75bcb76f033a68b493aa1fcb0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/56fbb526488c48c75bcb76f033a68b493aa1fcb0"}]},"branch":"refs/heads/master"},"2f3dc0a99136f8faf66b66a66f2b7149a14c0ef2":{"kind":"REWORK","_number":2,"created":"2020-12-04 09:50:37.000000000","uploader":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"ref":"refs/changes/27/765227/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/27/765227/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/27/765227/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/27/765227/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/27/765227/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/27/765227/2"}}},"commit":{"parents":[{"commit":"9e08ffb31cad3804a274443ac7659b5ca22cbe51","subject":"Merge \"Fix miscellaneous bugs found in VNF scaling guide\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9e08ffb31cad3804a274443ac7659b5ca22cbe51"}]}],"author":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2020-12-03 01:30:59.000000000","tz":0},"committer":{"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","date":"2020-12-04 09:44:47.000000000","tz":0},"subject":"Move tacker to new hacking 4.0.0","message":"Move tacker to new hacking 4.0.0\n\nHacking 4.0.0 has introduce new optimal assert checks.\nPlease refer [1] for more details.\n\nAdditionally Hacking has enabled some new checks by default,\nand the next update to the new release will introduce failures\nin tacker pep8 jobs.\nThe main impact is from I122d250cab90964c346e9d53046a97c25054bc00.\n\nThis patch addresses following -\n\n* Adopt new optimal assert checks.\n * [H211] Change assertTrue(isinstance(A, B)) to assertIsInstance(A, B).\n * [H212] Change assertEqual(type(A), B) to assertIsInstance(A, B).\n * [H214] Change assertTrue(A not in B, message) to the more specific\n   assertNotIn(A, B, message)\n\n* On bumping up the hacking version, below mention pep8 jobs failed.\n  This patch address these issues now, when the new hacking release\n  starts being used it will not cause a disruption.\n\n    ./tacker/tests/unit/vnflcm/test_controller.py:343:33:\n     F522 \u0027...\u0027.format(...) has unused named argument(s): expected_type\n            expected_message \u003d (\"Invalid input for field/attribute \"\n                                ^\n    ./tacker/tests/unit/common/test_csar_utils.py:194:16:\n    F504 \u0027...\u0027 % ... has unused named argument(s): csar\n        msg \u003d ((\u0027The filename \"%(manifest)s\" is an invalid name.\u0027\n               ^\n    ./tacker/vnfm/nfvo_client.py:191:21:\n     F523 \u0027...\u0027.format(...) has unused arguments at position(s): 0\n                 \"not supported.\".format(pipeline_type))\n                 ^\n[1] https://docs.openstack.org/releasenotes/hacking/unreleased.html#relnotes-4-0-0\n\nChange-Id: Iee059c00df1be212ae69fbc77cb783748da206b1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/2f3dc0a99136f8faf66b66a66f2b7149a14c0ef2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/2f3dc0a99136f8faf66b66a66f2b7149a14c0ef2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}