)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1ca42239085efb946f6267822647b020b3117f2f","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Reason of changing string size to 12800:"},{"line_number":15,"context_line":"Resize to 12800 so that it can store approximately 100 resources when"},{"line_number":16,"context_line":"it requires 128 characters per resource."},{"line_number":17,"context_line":"This fits in the rest of the vnf table, even with utf8mb4 in the mysql"},{"line_number":18,"context_line":"default character set (latest version: 8.0.x)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: 1909011"},{"line_number":21,"context_line":"Change-Id: I50db6f86cd8c164efeab2f0ebbe8ec0258a5ef1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"4b3086b2_474ed5d8","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":46},"updated":"2021-01-20 07:15:16.000000000","message":"I told you that the charset is utf8mb4 in my env, but I\u0027m not sure it\u0027s from ver 8.0.x. utf8mb4 itself was already introduced in ver 5.6, or before. The point is that we don\u0027t need to the version exactly, but simply need to consider the case of 4 bytes.\n\nMy suggestion is to remove the version, and add explanation that length of 128000 is under the limit of 65535 bytes per entry.","commit_id":"e9181b6a81cb8cd7a6f045c332a1089bf5ea2f12"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"56206f501c8e859d3a6a1177fc002bf369ddf49b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Reason of changing string size to 12800:"},{"line_number":15,"context_line":"Resize to 12800 so that it can store approximately 100 resources when"},{"line_number":16,"context_line":"it requires 128 characters per resource."},{"line_number":17,"context_line":"This fits in the rest of the vnf table, even with utf8mb4 in the mysql"},{"line_number":18,"context_line":"default character set (latest version: 8.0.x)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: 1909011"},{"line_number":21,"context_line":"Change-Id: I50db6f86cd8c164efeab2f0ebbe8ec0258a5ef1d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"f0972a78_c19e3394","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":46},"in_reply_to":"4b3086b2_474ed5d8","updated":"2021-01-20 08:42:20.000000000","message":"Thanks for suggestion.\nI fixed commit message. Could you check it?","commit_id":"e9181b6a81cb8cd7a6f045c332a1089bf5ea2f12"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cac6373864f2d96749a044650c831b6d41b8aa8c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-25 00:01:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change data type of instance_id in VNF table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to change data type of `instance_id` in the VNF table to"},{"line_number":10,"context_line":"String(12800) from String(64)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9e0e8f98_7a51439e","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":17},"updated":"2021-01-26 01:19:58.000000000","message":"You don\u0027t change data type, but the size actually.","commit_id":"4474618a8a62573b167b937932508a36220264ed"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"eb2f3c0795e6ad3c5a4001582387bd999bc27ab1","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ayumu Ueha \u003cueha.ayumu@fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-01-25 00:01:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change data type of instance_id in VNF table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to change data type of `instance_id` in the VNF table to"},{"line_number":10,"context_line":"String(12800) from String(64)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"91c241c0_097aa801","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":17},"in_reply_to":"9e0e8f98_7a51439e","updated":"2021-01-26 04:22:36.000000000","message":"I changed to `data size` from `data type`.","commit_id":"4474618a8a62573b167b937932508a36220264ed"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cac6373864f2d96749a044650c831b6d41b8aa8c","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change data type of instance_id in VNF table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to change data type of `instance_id` in the VNF table to"},{"line_number":10,"context_line":"String(12800) from String(64)."},{"line_number":11,"context_line":"If it leave the definition of String(64) as it is, a \"Data too long for"},{"line_number":12,"context_line":"column\" error will occur during CNF operation, because instance_id"},{"line_number":13,"context_line":"store kubernetes object information such as following:"},{"line_number":14,"context_line":"----"},{"line_number":15,"context_line":"\u0027instance_id\u0027: \""},{"line_number":16,"context_line":"  {\u0027namespace\u0027: \u0027default\u0027, \u0027name\u0027: \u0027vdu1\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"2b92ba41_0c7da9e8","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":53},"updated":"2021-01-26 01:19:58.000000000","message":"It\u0027s not clear for me why the size should be expanded from your description. I think the point is we don\u0027t have an appropriate ID for instance_id for CNF case, so use the object info instead as a workaround.","commit_id":"4474618a8a62573b167b937932508a36220264ed"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"eb2f3c0795e6ad3c5a4001582387bd999bc27ab1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change data type of instance_id in VNF table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to change data type of `instance_id` in the VNF table to"},{"line_number":10,"context_line":"String(12800) from String(64)."},{"line_number":11,"context_line":"If it leave the definition of String(64) as it is, a \"Data too long for"},{"line_number":12,"context_line":"column\" error will occur during CNF operation, because instance_id"},{"line_number":13,"context_line":"store kubernetes object information such as following:"},{"line_number":14,"context_line":"----"},{"line_number":15,"context_line":"\u0027instance_id\u0027: \""},{"line_number":16,"context_line":"  {\u0027namespace\u0027: \u0027default\u0027, \u0027name\u0027: \u0027vdu1\u0027,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"837d3080_465ee68f","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":53},"in_reply_to":"2b92ba41_0c7da9e8","updated":"2021-01-26 04:22:36.000000000","message":"Thanks you, I added the contents of the suggestion to commit message.","commit_id":"4474618a8a62573b167b937932508a36220264ed"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cac6373864f2d96749a044650c831b6d41b8aa8c","unresolved":true,"context_lines":[{"line_number":22,"context_line":"----"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Reason of changing string size to 12800:"},{"line_number":25,"context_line":"Resize to 12800 so that it can store approximately 100 resources when"},{"line_number":26,"context_line":"it requires 128 characters per resource."},{"line_number":27,"context_line":"This 12800 characters is under the limit of 65535 bytes per entry,"},{"line_number":28,"context_line":"even for the maximum length character set (4 bytes) [1]."},{"line_number":29,"context_line":"(instance_id\u0027s size (12800 * 4) + other total size(3044) \u003c 65535)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"26dfc663_0fe37d0e","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":40},"updated":"2021-01-26 01:19:58.000000000","message":"I don\u0027t know the reason of 128 chars and 100 resources. Is it from your estimation, or any reference defining some limitation?","commit_id":"4474618a8a62573b167b937932508a36220264ed"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"eb2f3c0795e6ad3c5a4001582387bd999bc27ab1","unresolved":true,"context_lines":[{"line_number":22,"context_line":"----"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Reason of changing string size to 12800:"},{"line_number":25,"context_line":"Resize to 12800 so that it can store approximately 100 resources when"},{"line_number":26,"context_line":"it requires 128 characters per resource."},{"line_number":27,"context_line":"This 12800 characters is under the limit of 65535 bytes per entry,"},{"line_number":28,"context_line":"even for the maximum length character set (4 bytes) [1]."},{"line_number":29,"context_line":"(instance_id\u0027s size (12800 * 4) + other total size(3044) \u003c 65535)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"5ca3d6c8_dba10738","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":40},"in_reply_to":"26dfc663_0fe37d0e","updated":"2021-01-26 04:22:36.000000000","message":"It is my estimation.\n* Estimating around 128 characters per resource should be fine, because at least about 40 characters can be used in the name and namespace in the commonly used resource kind.\n* Will not exceed 100 resources  in one VNF instance.","commit_id":"4474618a8a62573b167b937932508a36220264ed"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"cac6373864f2d96749a044650c831b6d41b8aa8c","unresolved":true,"context_lines":[{"line_number":26,"context_line":"it requires 128 characters per resource."},{"line_number":27,"context_line":"This 12800 characters is under the limit of 65535 bytes per entry,"},{"line_number":28,"context_line":"even for the maximum length character set (4 bytes) [1]."},{"line_number":29,"context_line":"(instance_id\u0027s size (12800 * 4) + other total size(3044) \u003c 65535)"},{"line_number":30,"context_line":"[1] https://dev.mysql.com/doc/refman/8.0/en/charset-charsets.html"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: 1909011"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"c55a892c_7c108b5a","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":56},"updated":"2021-01-26 01:19:58.000000000","message":"What\u0027s this?","commit_id":"4474618a8a62573b167b937932508a36220264ed"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"eb2f3c0795e6ad3c5a4001582387bd999bc27ab1","unresolved":true,"context_lines":[{"line_number":26,"context_line":"it requires 128 characters per resource."},{"line_number":27,"context_line":"This 12800 characters is under the limit of 65535 bytes per entry,"},{"line_number":28,"context_line":"even for the maximum length character set (4 bytes) [1]."},{"line_number":29,"context_line":"(instance_id\u0027s size (12800 * 4) + other total size(3044) \u003c 65535)"},{"line_number":30,"context_line":"[1] https://dev.mysql.com/doc/refman/8.0/en/charset-charsets.html"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: 1909011"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3d747274_7b6151a9","line":29,"range":{"start_line":29,"start_character":34,"end_line":29,"end_character":56},"in_reply_to":"c55a892c_7c108b5a","updated":"2021-01-26 04:22:36.000000000","message":"`other total size` means the capacity used other than instance_id in the VNF table. I added explanation to commit message.","commit_id":"4474618a8a62573b167b937932508a36220264ed"}],"tacker/db/migration/alembic_migrations/versions/7186440a306b_change_type_for_instance_id_of_vnf_table.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e93211d53dd3e7ab437d60f7c04fbef36498480c","unresolved":true,"context_lines":[{"line_number":32,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":33,"context_line":"    op.alter_column(\u0027vnf\u0027,"},{"line_number":34,"context_line":"                    \u0027instance_id\u0027,"},{"line_number":35,"context_line":"                    type_\u003dsa.Text(),"},{"line_number":36,"context_line":"                    nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"71429139_0d955a7e","line":35,"updated":"2020-12-23 03:28:55.000000000","message":"I\u0027m not sure this change is exact for the purpose. Could you tell me how much bytes of string is required for the instance ID of CNF usecase?","commit_id":"771e995646991d631411868021380deb9b477444"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b95140127737ec4d7d8a776ecfe2a321ade7ace1","unresolved":true,"context_lines":[{"line_number":32,"context_line":"def upgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":33,"context_line":"    op.alter_column(\u0027vnf\u0027,"},{"line_number":34,"context_line":"                    \u0027instance_id\u0027,"},{"line_number":35,"context_line":"                    type_\u003dsa.Text(),"},{"line_number":36,"context_line":"                    nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e4f6b6a_198aa06c","line":35,"in_reply_to":"71429139_0d955a7e","updated":"2020-12-23 04:13:21.000000000","message":"Thanks for your comment.\nIn CNF usecase, instanceId has kubernetes object information in current implementation such as following:\n----\n\u0027instance_id\u0027: \"\n  {\u0027namespace\u0027: \u0027default\u0027, \u0027name\u0027: \u0027vdu1\u0027, \u0027apiVersion\u0027: \u0027apps/v1\u0027, \u0027kind\u0027: \u0027Deployment\u0027},\n  {\u0027namespace\u0027: \u0027default\u0027, \u0027name\u0027: \u0027pv1\u0027, \u0027apiVersion\u0027: \u0027core/v1\u0027, \u0027kind\u0027: \u0027PersistentVolume\u0027},\n  ... (**Contains the deployed kubernetes resources)\n  {...}\n\"\n----\nSo, It will be the number of bytes according to the k8s resource to be deployed.","commit_id":"771e995646991d631411868021380deb9b477444"}]}