)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"d6de7d6ed8e4c14f36b6a69c485dd786bdcf26fd","unresolved":true,"context_lines":[{"line_number":16,"context_line":"tacker/common/container"},{"line_number":17,"context_line":"|-kubernetes_utils.py(73%-\u003e73%)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"tacker/vnflcm/"},{"line_number":20,"context_line":"|-vnflcm_driver.py(in progress)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Implements: blueprint improve-conductor-vnflcm-driver-related-files"},{"line_number":23,"context_line":"Change-Id: I3a4f9afe0ffa4a79fbec59d7e267db8a99df0b3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c695035d_059f106b","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":31},"updated":"2021-03-08 12:35:10.000000000","message":"Is this included in this patch?","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"015681689a30c0635656a2a1ffcf2d377f7e7405","unresolved":true,"context_lines":[{"line_number":16,"context_line":"tacker/common/container"},{"line_number":17,"context_line":"|-kubernetes_utils.py(73%-\u003e73%)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"tacker/vnflcm/"},{"line_number":20,"context_line":"|-vnflcm_driver.py(in progress)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Implements: blueprint improve-conductor-vnflcm-driver-related-files"},{"line_number":23,"context_line":"Change-Id: I3a4f9afe0ffa4a79fbec59d7e267db8a99df0b3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2c1c3999_97df6c59","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":31},"in_reply_to":"c695035d_059f106b","updated":"2021-03-11 08:55:15.000000000","message":"It is not included currently.. I will delete this line anyway.","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"d6de7d6ed8e4c14f36b6a69c485dd786bdcf26fd","unresolved":true,"context_lines":[{"line_number":19,"context_line":"tacker/vnflcm/"},{"line_number":20,"context_line":"|-vnflcm_driver.py(in progress)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Implements: blueprint improve-conductor-vnflcm-driver-related-files"},{"line_number":23,"context_line":"Change-Id: I3a4f9afe0ffa4a79fbec59d7e267db8a99df0b3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfe743a2_7e6e8d7b","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"updated":"2021-03-08 12:35:10.000000000","message":"This link doesn\u0027t work. Please check.","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"015681689a30c0635656a2a1ffcf2d377f7e7405","unresolved":true,"context_lines":[{"line_number":19,"context_line":"tacker/vnflcm/"},{"line_number":20,"context_line":"|-vnflcm_driver.py(in progress)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Implements: blueprint improve-conductor-vnflcm-driver-related-files"},{"line_number":23,"context_line":"Change-Id: I3a4f9afe0ffa4a79fbec59d7e267db8a99df0b3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5578bdfc_c597bb73","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":67},"in_reply_to":"dfe743a2_7e6e8d7b","updated":"2021-03-11 08:55:15.000000000","message":"Fixed","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"}],"tacker/tests/unit/common/container/test_kubernetes_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2c2caaa1ac9aa8dbcdde172e46e6c243f7fb1713","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from tacker.tests import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class testKubernetesHTTPAPI(base.BaseTestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(testKubernetesHTTPAPI, self).setUp()"}],"source_content_type":"text/x-python","patch_set":11,"id":"75ed2dd9_01d62b59","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":7},"updated":"2021-03-25 09:50:48.000000000","message":"It should be capitalized.","commit_id":"aa0ea64a52f3040286cfd97529d50b96d12b6fb7"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"daa9679a4af78de1902652514a42c25ec3b0b2dd","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from tacker.tests import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class testKubernetesHTTPAPI(base.BaseTestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def setUp(self):"},{"line_number":25,"context_line":"        super(testKubernetesHTTPAPI, self).setUp()"}],"source_content_type":"text/x-python","patch_set":11,"id":"52a43d7e_8ebee9bc","line":22,"range":{"start_line":22,"start_character":6,"end_line":22,"end_character":7},"in_reply_to":"75ed2dd9_01d62b59","updated":"2021-03-25 16:29:19.000000000","message":"Sorry for a basic miss..  I have fixed in the latest patch, please kindly have a check","commit_id":"aa0ea64a52f3040286cfd97529d50b96d12b6fb7"}],"tacker/tests/unit/conductor/conductorrpc/test_vim_monitor_rpc.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"e83c6274723d7fea164484f8900a11bfec0a9586","unresolved":true,"context_lines":[{"line_number":1,"context_line":"from tacker.conductor.conductorrpc import vim_monitor_rpc"},{"line_number":2,"context_line":"from tacker.tests.unit import base as unit_base"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1f39324d_c3246684","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"updated":"2021-03-19 09:14:28.000000000","message":"Could you please add license to the file.","commit_id":"0c970ca8ded737b060d2e0c4fb486b24ec17d89e"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"6bae3db577627513f8fb5f950930e545ae48d598","unresolved":true,"context_lines":[{"line_number":1,"context_line":"from tacker.conductor.conductorrpc import vim_monitor_rpc"},{"line_number":2,"context_line":"from tacker.tests.unit import base as unit_base"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"beaf847f_b061fd96","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"in_reply_to":"1f39324d_c3246684","updated":"2021-03-23 09:18:22.000000000","message":"Thanks for comment! I have added license to this file, please kindly have a check 😊","commit_id":"0c970ca8ded737b060d2e0c4fb486b24ec17d89e"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"ecc6951fe0618fbb327a25d1e120eeb1b95abd52","unresolved":true,"context_lines":[{"line_number":1,"context_line":"from tacker.conductor.conductorrpc import vim_monitor_rpc"},{"line_number":2,"context_line":"from tacker.tests.unit import base as unit_base"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ee339e9a_343b36d9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"in_reply_to":"beaf847f_b061fd96","updated":"2021-03-23 12:51:01.000000000","message":"I have verified changes.","commit_id":"0c970ca8ded737b060d2e0c4fb486b24ec17d89e"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"d6de7d6ed8e4c14f36b6a69c485dd786bdcf26fd","unresolved":true,"context_lines":[{"line_number":2519,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2520,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2521,"context_line":"    @mock.patch.object(glance_store, \u0027delete_csar\u0027)"},{"line_number":2522,"context_line":"    def test_upload_vnf_package_raises_decorater_error(self,"},{"line_number":2523,"context_line":"                                        mock_load_csar,"},{"line_number":2524,"context_line":"                                        mock_load_csar_data,"},{"line_number":2525,"context_line":"                                        mock_delete_csar):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa182bd1_77db3be1","line":2522,"range":{"start_line":2522,"start_character":8,"end_line":2522,"end_character":54},"updated":"2021-03-08 12:35:10.000000000","message":"What this test case intends to check? I couldn\u0027t catch what \"raises_decorater_error\" means.","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"66a30ab4138011d14699e2171f09dca6c5956d33","unresolved":true,"context_lines":[{"line_number":2519,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2520,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2521,"context_line":"    @mock.patch.object(glance_store, \u0027delete_csar\u0027)"},{"line_number":2522,"context_line":"    def test_upload_vnf_package_raises_decorater_error(self,"},{"line_number":2523,"context_line":"                                        mock_load_csar,"},{"line_number":2524,"context_line":"                                        mock_load_csar_data,"},{"line_number":2525,"context_line":"                                        mock_delete_csar):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a7e3b63f_f36b8d20","line":2522,"range":{"start_line":2522,"start_character":8,"end_line":2522,"end_character":54},"in_reply_to":"a4ff0341_dccc154a","updated":"2021-03-15 08:54:55.000000000","message":"Thanks for comment, I have changed method name in latest patch, please kindly have a look","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"cd1c6eca57f6660321f35f24b1b1b98a7b6b3bc1","unresolved":true,"context_lines":[{"line_number":2519,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2520,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2521,"context_line":"    @mock.patch.object(glance_store, \u0027delete_csar\u0027)"},{"line_number":2522,"context_line":"    def test_upload_vnf_package_raises_decorater_error(self,"},{"line_number":2523,"context_line":"                                        mock_load_csar,"},{"line_number":2524,"context_line":"                                        mock_load_csar_data,"},{"line_number":2525,"context_line":"                                        mock_delete_csar):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a4ff0341_dccc154a","line":2522,"range":{"start_line":2522,"start_character":8,"end_line":2522,"end_character":54},"in_reply_to":"f6928f86_79eda41c","updated":"2021-03-12 13:20:14.000000000","message":"Thanks. How about naming this method to be \"test_revert_upload_vnf_package_in_upload_vnf_package_content()\"? The current name misleads that this test assume to fail in decorator.","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b25a0022a9a2498835e5651c8a2a08116f9148f7","unresolved":true,"context_lines":[{"line_number":2519,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2520,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2521,"context_line":"    @mock.patch.object(glance_store, \u0027delete_csar\u0027)"},{"line_number":2522,"context_line":"    def test_upload_vnf_package_raises_decorater_error(self,"},{"line_number":2523,"context_line":"                                        mock_load_csar,"},{"line_number":2524,"context_line":"                                        mock_load_csar_data,"},{"line_number":2525,"context_line":"                                        mock_delete_csar):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f6928f86_79eda41c","line":2522,"range":{"start_line":2522,"start_character":8,"end_line":2522,"end_character":54},"in_reply_to":"fa182bd1_77db3be1","updated":"2021-03-11 08:54:26.000000000","message":"This case intends to check decorator function revert_upload_vnf_package() of conductor.upload_vnf_package_content()","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"d6de7d6ed8e4c14f36b6a69c485dd786bdcf26fd","unresolved":true,"context_lines":[{"line_number":2535,"context_line":"    @mock.patch.object(conductor_server, \u0027revert_upload_vnf_package\u0027)"},{"line_number":2536,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2537,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2538,"context_line":"    def test_upload_vnf_package_content_using_internal_methods(self,"},{"line_number":2539,"context_line":"                                        mock_load_csar,"},{"line_number":2540,"context_line":"                                        mock_load_csar_data,"},{"line_number":2541,"context_line":"                                        mock_revert):"}],"source_content_type":"text/x-python","patch_set":5,"id":"2b0b87f7_1c60416c","line":2538,"range":{"start_line":2538,"start_character":8,"end_line":2538,"end_character":62},"updated":"2021-03-08 12:35:10.000000000","message":"What this test case intends to check? I couldn\u0027t catch what \"using_internal_methods\" means.","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b25a0022a9a2498835e5651c8a2a08116f9148f7","unresolved":true,"context_lines":[{"line_number":2535,"context_line":"    @mock.patch.object(conductor_server, \u0027revert_upload_vnf_package\u0027)"},{"line_number":2536,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2537,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2538,"context_line":"    def test_upload_vnf_package_content_using_internal_methods(self,"},{"line_number":2539,"context_line":"                                        mock_load_csar,"},{"line_number":2540,"context_line":"                                        mock_load_csar_data,"},{"line_number":2541,"context_line":"                                        mock_revert):"}],"source_content_type":"text/x-python","patch_set":5,"id":"f6344d0e_07c0a44e","line":2538,"range":{"start_line":2538,"start_character":8,"end_line":2538,"end_character":62},"in_reply_to":"2b0b87f7_1c60416c","updated":"2021-03-11 08:54:26.000000000","message":"This case intends to check upload_vnf_package_content() while actually calling internal method _onboard_vnf_package(), I feel is it better to check _onboard_vnf_package() directly?","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"66a30ab4138011d14699e2171f09dca6c5956d33","unresolved":true,"context_lines":[{"line_number":2535,"context_line":"    @mock.patch.object(conductor_server, \u0027revert_upload_vnf_package\u0027)"},{"line_number":2536,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2537,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2538,"context_line":"    def test_upload_vnf_package_content_using_internal_methods(self,"},{"line_number":2539,"context_line":"                                        mock_load_csar,"},{"line_number":2540,"context_line":"                                        mock_load_csar_data,"},{"line_number":2541,"context_line":"                                        mock_revert):"}],"source_content_type":"text/x-python","patch_set":5,"id":"a9497ce0_1cf2aa92","line":2538,"range":{"start_line":2538,"start_character":8,"end_line":2538,"end_character":62},"in_reply_to":"9598e20a_2a7a3343","updated":"2021-03-15 08:54:55.000000000","message":"Thanks for comment, I have changed method name to test_onboard_vnf_package_through_upload_vnf_package_content()","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"cd1c6eca57f6660321f35f24b1b1b98a7b6b3bc1","unresolved":true,"context_lines":[{"line_number":2535,"context_line":"    @mock.patch.object(conductor_server, \u0027revert_upload_vnf_package\u0027)"},{"line_number":2536,"context_line":"    @mock.patch.object(csar_utils, \u0027load_csar_data\u0027)"},{"line_number":2537,"context_line":"    @mock.patch.object(glance_store, \u0027load_csar\u0027)"},{"line_number":2538,"context_line":"    def test_upload_vnf_package_content_using_internal_methods(self,"},{"line_number":2539,"context_line":"                                        mock_load_csar,"},{"line_number":2540,"context_line":"                                        mock_load_csar_data,"},{"line_number":2541,"context_line":"                                        mock_revert):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9598e20a_2a7a3343","line":2538,"range":{"start_line":2538,"start_character":8,"end_line":2538,"end_character":62},"in_reply_to":"f6344d0e_07c0a44e","updated":"2021-03-12 13:20:14.000000000","message":"+1\nIt\u0027s hard to catch the point of this test with the current implementation.","commit_id":"b36a42b5ecc226c86c0ecbcdc4ac2af65a5a6a61"}]}