)]}' {"api-ref/source/v1/samples/vnflcm/fail-vnf-instance-response.json":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"97afcffa2e4ddcf25036e86d0e89da379cf2b71b","unresolved":true,"context_lines":[{"line_number":13,"context_line":" \"detail\":\"MANUAL ERROR\""},{"line_number":14,"context_line":" },"},{"line_number":15,"context_line":" \"_links\":{"},{"line_number":16,"context_line":" \"self\":{"},{"line_number":17,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633\""},{"line_number":18,"context_line":" },"},{"line_number":19,"context_line":" \"vnfInstance\":{"},{"line_number":20,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_instances/a9d0fe86-a3d0-4cbf-a117-578ff182fd7e\""},{"line_number":21,"context_line":" },"},{"line_number":22,"context_line":" \"retry\":{"},{"line_number":23,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/retry\""},{"line_number":24,"context_line":" },"},{"line_number":25,"context_line":" \"rollback\":{"},{"line_number":26,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/rollback\""},{"line_number":27,"context_line":" },"},{"line_number":28,"context_line":" \"fail\":{"},{"line_number":29,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/fail\""},{"line_number":30,"context_line":" }"},{"line_number":31,"context_line":" }"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"e0e66e54_81dc62f4","line":30,"range":{"start_line":16,"start_character":8,"end_line":30,"end_character":9},"updated":"2021-01-25 09:23:18.000000000","message":"As with \u0027create-subscription-response.json\u0027, I think it\u0027s better to use a domain name instead of an IP address.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":false,"context_lines":[{"line_number":13,"context_line":" \"detail\":\"MANUAL ERROR\""},{"line_number":14,"context_line":" },"},{"line_number":15,"context_line":" \"_links\":{"},{"line_number":16,"context_line":" \"self\":{"},{"line_number":17,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633\""},{"line_number":18,"context_line":" },"},{"line_number":19,"context_line":" \"vnfInstance\":{"},{"line_number":20,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_instances/a9d0fe86-a3d0-4cbf-a117-578ff182fd7e\""},{"line_number":21,"context_line":" },"},{"line_number":22,"context_line":" \"retry\":{"},{"line_number":23,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/retry\""},{"line_number":24,"context_line":" },"},{"line_number":25,"context_line":" \"rollback\":{"},{"line_number":26,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/rollback\""},{"line_number":27,"context_line":" },"},{"line_number":28,"context_line":" \"fail\":{"},{"line_number":29,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/fail\""},{"line_number":30,"context_line":" }"},{"line_number":31,"context_line":" }"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"57567c9c_1ffbfa8c","line":30,"range":{"start_line":16,"start_character":8,"end_line":30,"end_character":9},"in_reply_to":"b17496b9_12a07358","updated":"2021-02-05 06:18:32.000000000","message":"I\u0027ve confirmed.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8937ec287b1fba312817a6ca95d6341aee9fd15f","unresolved":true,"context_lines":[{"line_number":13,"context_line":" \"detail\":\"MANUAL ERROR\""},{"line_number":14,"context_line":" },"},{"line_number":15,"context_line":" \"_links\":{"},{"line_number":16,"context_line":" \"self\":{"},{"line_number":17,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633\""},{"line_number":18,"context_line":" },"},{"line_number":19,"context_line":" \"vnfInstance\":{"},{"line_number":20,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_instances/a9d0fe86-a3d0-4cbf-a117-578ff182fd7e\""},{"line_number":21,"context_line":" },"},{"line_number":22,"context_line":" \"retry\":{"},{"line_number":23,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/retry\""},{"line_number":24,"context_line":" },"},{"line_number":25,"context_line":" \"rollback\":{"},{"line_number":26,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/rollback\""},{"line_number":27,"context_line":" },"},{"line_number":28,"context_line":" \"fail\":{"},{"line_number":29,"context_line":" \"href\":\"https://10.51.0.172/vnflcm/v1/vnf_lcm_op_occs/22962087-0494-484f-85e9-ef855e702633/fail\""},{"line_number":30,"context_line":" }"},{"line_number":31,"context_line":" }"},{"line_number":32,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"b17496b9_12a07358","line":30,"range":{"start_line":16,"start_character":8,"end_line":30,"end_character":9},"in_reply_to":"e0e66e54_81dc62f4","updated":"2021-02-01 17:52:05.000000000","message":"sample domain name is used","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"}],"api-ref/source/v1/vnflcm.inc":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"97afcffa2e4ddcf25036e86d0e89da379cf2b71b","unresolved":true,"context_lines":[{"line_number":819,"context_line":"occurrence is in \"FAILED_TEMP\" state"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"In case of success, the \"operationState\" attribute in the representation of the parent resource shall be changed to"},{"line_number":822,"context_line":"\"FAILED\" and the applicable \"result\" notification shall be emitted to indicate that the execution of the underlying "},{"line_number":823,"context_line":"VNF LCM operation occurrence has finally and unrecoverably failed. "},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"Response Codes"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"b4cf621c_0e6eb012","line":822,"range":{"start_line":822,"start_character":115,"end_line":822,"end_character":116},"updated":"2021-01-25 09:23:18.000000000","message":"There is an unnecessary space at the end.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8937ec287b1fba312817a6ca95d6341aee9fd15f","unresolved":true,"context_lines":[{"line_number":819,"context_line":"occurrence is in \"FAILED_TEMP\" state"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"In case of success, the \"operationState\" attribute in the representation of the parent resource shall be changed to"},{"line_number":822,"context_line":"\"FAILED\" and the applicable \"result\" notification shall be emitted to indicate that the execution of the underlying "},{"line_number":823,"context_line":"VNF LCM operation occurrence has finally and unrecoverably failed. "},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"Response Codes"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"d97f0f9f_7cfbab50","line":822,"range":{"start_line":822,"start_character":115,"end_line":822,"end_character":116},"in_reply_to":"b4cf621c_0e6eb012","updated":"2021-02-01 17:52:05.000000000","message":"it is removed.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":false,"context_lines":[{"line_number":819,"context_line":"occurrence is in \"FAILED_TEMP\" state"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"In case of success, the \"operationState\" attribute in the representation of the parent resource shall be changed to"},{"line_number":822,"context_line":"\"FAILED\" and the applicable \"result\" notification shall be emitted to indicate that the execution of the underlying "},{"line_number":823,"context_line":"VNF LCM operation occurrence has finally and unrecoverably failed. "},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"Response Codes"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"bd1a7218_000ec7f3","line":822,"range":{"start_line":822,"start_character":115,"end_line":822,"end_character":116},"in_reply_to":"d97f0f9f_7cfbab50","updated":"2021-02-05 06:18:32.000000000","message":"I\u0027ve confirmed.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"97afcffa2e4ddcf25036e86d0e89da379cf2b71b","unresolved":true,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"In case of success, the \"operationState\" attribute in the representation of the parent resource shall be changed to"},{"line_number":822,"context_line":"\"FAILED\" and the applicable \"result\" notification shall be emitted to indicate that the execution of the underlying "},{"line_number":823,"context_line":"VNF LCM operation occurrence has finally and unrecoverably failed. "},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"Response Codes"},{"line_number":826,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"9bb2f8a3_fd403384","line":823,"range":{"start_line":823,"start_character":66,"end_line":823,"end_character":67},"updated":"2021-01-25 09:23:18.000000000","message":"ditto","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8937ec287b1fba312817a6ca95d6341aee9fd15f","unresolved":true,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"In case of success, the \"operationState\" attribute in the representation of the parent resource shall be changed to"},{"line_number":822,"context_line":"\"FAILED\" and the applicable \"result\" notification shall be emitted to indicate that the execution of the underlying "},{"line_number":823,"context_line":"VNF LCM operation occurrence has finally and unrecoverably failed. "},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"Response Codes"},{"line_number":826,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ebff60d5_d57fd089","line":823,"range":{"start_line":823,"start_character":66,"end_line":823,"end_character":67},"in_reply_to":"9bb2f8a3_fd403384","updated":"2021-02-01 17:52:05.000000000","message":"it is removed.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"In case of success, the \"operationState\" attribute in the representation of the parent resource shall be changed to"},{"line_number":822,"context_line":"\"FAILED\" and the applicable \"result\" notification shall be emitted to indicate that the execution of the underlying "},{"line_number":823,"context_line":"VNF LCM operation occurrence has finally and unrecoverably failed. "},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"Response Codes"},{"line_number":826,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"34d45cb4_c8b2ca53","line":823,"range":{"start_line":823,"start_character":66,"end_line":823,"end_character":67},"in_reply_to":"ebff60d5_d57fd089","updated":"2021-02-05 06:18:32.000000000","message":"I\u0027ve confirmed.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"97afcffa2e4ddcf25036e86d0e89da379cf2b71b","unresolved":true,"context_lines":[{"line_number":842,"context_line":".. rest_parameters:: parameters_vnflcm.yaml"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":" - vnfLcmOpOccId: vnf_lcm_op_occ_id"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"Create a new subscription"},{"line_number":847,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":848,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"36af7d7c_92b3fed4","line":845,"updated":"2021-01-25 09:23:18.000000000","message":"I thought that you uploaded \u0027samples/vnflcm/fail-vnf-instance-response.json\u0027 to put as \u0027Request Example\u0027, but it seems that the description here is missing.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8937ec287b1fba312817a6ca95d6341aee9fd15f","unresolved":true,"context_lines":[{"line_number":842,"context_line":".. rest_parameters:: parameters_vnflcm.yaml"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":" - vnfLcmOpOccId: vnf_lcm_op_occ_id"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"Create a new subscription"},{"line_number":847,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":848,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"690d592f_f2f79e86","line":845,"in_reply_to":"36af7d7c_92b3fed4","updated":"2021-02-01 17:52:05.000000000","message":"request/response params description added","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":false,"context_lines":[{"line_number":842,"context_line":".. rest_parameters:: parameters_vnflcm.yaml"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":" - vnfLcmOpOccId: vnf_lcm_op_occ_id"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"Create a new subscription"},{"line_number":847,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":848,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"fd587f15_c7e73ff0","line":845,"in_reply_to":"690d592f_f2f79e86","updated":"2021-02-05 06:18:32.000000000","message":"I\u0027ve confirmed.","commit_id":"c84567bd1798651fc629b9fc5f8054460be0a7f1"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":true,"context_lines":[{"line_number":264,"context_line":" LOG.debug(\u0027START NOTIFICATION PROCESS\u0027)"},{"line_number":265,"context_line":" vnf_url \u003d self._get_vnf_instance_href(vnf_instance)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":" if operation_state is fields.LcmOccsOperationState.FAILED:"},{"line_number":268,"context_line":" vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs.id)"},{"line_number":269,"context_line":" notification \u003d {"},{"line_number":270,"context_line":" \u0027notificationType\u0027:"},{"line_number":271,"context_line":" fields.LcmOccsNotificationType.VNF_OP_OCC_NOTIFICATION,"},{"line_number":272,"context_line":" \u0027notificationStatus\u0027: fields.LcmOccsNotificationStatus.RESULT,"},{"line_number":273,"context_line":" \u0027operationState\u0027: operation_state,"},{"line_number":274,"context_line":" \u0027vnfInstanceId\u0027: vnf_instance.id,"},{"line_number":275,"context_line":" \u0027operation\u0027: lcm_operation,"},{"line_number":276,"context_line":" \u0027isAutomaticInvocation\u0027: is_auto,"},{"line_number":277,"context_line":" \u0027vnfLcmOpOccId\u0027: vnf_lcm_op_occs.id,"},{"line_number":278,"context_line":" \u0027_links\u0027: {"},{"line_number":279,"context_line":" \u0027vnfInstance\u0027: {"},{"line_number":280,"context_line":" \u0027href\u0027: vnf_url},"},{"line_number":281,"context_line":" \u0027vnfLcmOpOcc\u0027: {"},{"line_number":282,"context_line":" \u0027href\u0027: vnf_lcm_url}}}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":" notification[\u0027affectedVnfcs\u0027] \u003d \\"},{"line_number":285,"context_line":" affected_resources.get(\u0027affectedVnfcs\u0027, [])"},{"line_number":286,"context_line":" notification[\u0027affectedVirtualLinks\u0027] \u003d \\"},{"line_number":287,"context_line":" affected_resources.get(\u0027affectedVirtualLinks\u0027, [])"},{"line_number":288,"context_line":" notification[\u0027affectedVirtualStorages\u0027] \u003d \\"},{"line_number":289,"context_line":" affected_resources.get(\u0027affectedVirtualStorages\u0027, [])"},{"line_number":290,"context_line":" notification[\u0027error\u0027] \u003d str(vnf_lcm_op_occs.error)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":" # call send notification"},{"line_number":293,"context_line":" try:"},{"line_number":294,"context_line":" self.rpc_api.send_notification(context, notification)"},{"line_number":295,"context_line":" except Exception as ex:"},{"line_number":296,"context_line":" LOG.error("},{"line_number":297,"context_line":" \"Encoutered problem sending notification {}\".format("},{"line_number":298,"context_line":" encodeutils.exception_to_unicode(ex)))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":" return vnf_lcm_op_occs.id"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":303,"context_line":" error_point \u003d 0"}],"source_content_type":"text/x-python","patch_set":7,"id":"6c5cf083_34643c86","line":300,"range":{"start_line":267,"start_character":0,"end_line":300,"end_character":37},"updated":"2021-02-05 06:18:32.000000000","message":"Is it possible to commonize the added code because there are many similar processes to the existing code of _notification_process?\nThe process of \"call send notification\" is exactly the same.\nAlso, the processing of \"notification \u003d {\" can be easily commonized by changing the default value of the newly added argument to \"operation_state \u003d fields.LcmOccsOperationState.STARTING\".\nIn that case, I recommend adding \"notification_status \u003d fields.LcmOccsNotificationStatus.START\" as an argument as well.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e2928652bf74573819e97b9929eb2369117c2cbd","unresolved":false,"context_lines":[{"line_number":264,"context_line":" LOG.debug(\u0027START NOTIFICATION PROCESS\u0027)"},{"line_number":265,"context_line":" vnf_url \u003d self._get_vnf_instance_href(vnf_instance)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":" if operation_state is fields.LcmOccsOperationState.FAILED:"},{"line_number":268,"context_line":" vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs.id)"},{"line_number":269,"context_line":" notification \u003d {"},{"line_number":270,"context_line":" \u0027notificationType\u0027:"},{"line_number":271,"context_line":" fields.LcmOccsNotificationType.VNF_OP_OCC_NOTIFICATION,"},{"line_number":272,"context_line":" \u0027notificationStatus\u0027: fields.LcmOccsNotificationStatus.RESULT,"},{"line_number":273,"context_line":" \u0027operationState\u0027: operation_state,"},{"line_number":274,"context_line":" \u0027vnfInstanceId\u0027: vnf_instance.id,"},{"line_number":275,"context_line":" \u0027operation\u0027: lcm_operation,"},{"line_number":276,"context_line":" \u0027isAutomaticInvocation\u0027: is_auto,"},{"line_number":277,"context_line":" \u0027vnfLcmOpOccId\u0027: vnf_lcm_op_occs.id,"},{"line_number":278,"context_line":" \u0027_links\u0027: {"},{"line_number":279,"context_line":" \u0027vnfInstance\u0027: {"},{"line_number":280,"context_line":" \u0027href\u0027: vnf_url},"},{"line_number":281,"context_line":" \u0027vnfLcmOpOcc\u0027: {"},{"line_number":282,"context_line":" \u0027href\u0027: vnf_lcm_url}}}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":" notification[\u0027affectedVnfcs\u0027] \u003d \\"},{"line_number":285,"context_line":" affected_resources.get(\u0027affectedVnfcs\u0027, [])"},{"line_number":286,"context_line":" notification[\u0027affectedVirtualLinks\u0027] \u003d \\"},{"line_number":287,"context_line":" affected_resources.get(\u0027affectedVirtualLinks\u0027, [])"},{"line_number":288,"context_line":" notification[\u0027affectedVirtualStorages\u0027] \u003d \\"},{"line_number":289,"context_line":" affected_resources.get(\u0027affectedVirtualStorages\u0027, [])"},{"line_number":290,"context_line":" notification[\u0027error\u0027] \u003d str(vnf_lcm_op_occs.error)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":" # call send notification"},{"line_number":293,"context_line":" try:"},{"line_number":294,"context_line":" self.rpc_api.send_notification(context, notification)"},{"line_number":295,"context_line":" except Exception as ex:"},{"line_number":296,"context_line":" LOG.error("},{"line_number":297,"context_line":" \"Encoutered problem sending notification {}\".format("},{"line_number":298,"context_line":" encodeutils.exception_to_unicode(ex)))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":" return vnf_lcm_op_occs.id"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":303,"context_line":" error_point \u003d 0"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ab06bb2_5cc842f8","line":300,"range":{"start_line":267,"start_character":0,"end_line":300,"end_character":37},"in_reply_to":"52a42c89_00475bad","updated":"2021-03-05 06:16:12.000000000","message":"I\u0027ve confirmed.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0f3de020665f40eea39ef908e41ba7c4a14c0e8f","unresolved":true,"context_lines":[{"line_number":264,"context_line":" LOG.debug(\u0027START NOTIFICATION PROCESS\u0027)"},{"line_number":265,"context_line":" vnf_url \u003d self._get_vnf_instance_href(vnf_instance)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":" if operation_state is fields.LcmOccsOperationState.FAILED:"},{"line_number":268,"context_line":" vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs.id)"},{"line_number":269,"context_line":" notification \u003d {"},{"line_number":270,"context_line":" \u0027notificationType\u0027:"},{"line_number":271,"context_line":" fields.LcmOccsNotificationType.VNF_OP_OCC_NOTIFICATION,"},{"line_number":272,"context_line":" \u0027notificationStatus\u0027: fields.LcmOccsNotificationStatus.RESULT,"},{"line_number":273,"context_line":" \u0027operationState\u0027: operation_state,"},{"line_number":274,"context_line":" \u0027vnfInstanceId\u0027: vnf_instance.id,"},{"line_number":275,"context_line":" \u0027operation\u0027: lcm_operation,"},{"line_number":276,"context_line":" \u0027isAutomaticInvocation\u0027: is_auto,"},{"line_number":277,"context_line":" \u0027vnfLcmOpOccId\u0027: vnf_lcm_op_occs.id,"},{"line_number":278,"context_line":" \u0027_links\u0027: {"},{"line_number":279,"context_line":" \u0027vnfInstance\u0027: {"},{"line_number":280,"context_line":" \u0027href\u0027: vnf_url},"},{"line_number":281,"context_line":" \u0027vnfLcmOpOcc\u0027: {"},{"line_number":282,"context_line":" \u0027href\u0027: vnf_lcm_url}}}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":" notification[\u0027affectedVnfcs\u0027] \u003d \\"},{"line_number":285,"context_line":" affected_resources.get(\u0027affectedVnfcs\u0027, [])"},{"line_number":286,"context_line":" notification[\u0027affectedVirtualLinks\u0027] \u003d \\"},{"line_number":287,"context_line":" affected_resources.get(\u0027affectedVirtualLinks\u0027, [])"},{"line_number":288,"context_line":" notification[\u0027affectedVirtualStorages\u0027] \u003d \\"},{"line_number":289,"context_line":" affected_resources.get(\u0027affectedVirtualStorages\u0027, [])"},{"line_number":290,"context_line":" notification[\u0027error\u0027] \u003d str(vnf_lcm_op_occs.error)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":" # call send notification"},{"line_number":293,"context_line":" try:"},{"line_number":294,"context_line":" self.rpc_api.send_notification(context, notification)"},{"line_number":295,"context_line":" except Exception as ex:"},{"line_number":296,"context_line":" LOG.error("},{"line_number":297,"context_line":" \"Encoutered problem sending notification {}\".format("},{"line_number":298,"context_line":" encodeutils.exception_to_unicode(ex)))"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":" return vnf_lcm_op_occs.id"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":303,"context_line":" error_point \u003d 0"}],"source_content_type":"text/x-python","patch_set":7,"id":"52a42c89_00475bad","line":300,"range":{"start_line":267,"start_character":0,"end_line":300,"end_character":37},"in_reply_to":"6c5cf083_34643c86","updated":"2021-02-19 13:52:47.000000000","message":"Created common process and added notification_status as a parameter to _notification_process method.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":true,"context_lines":[{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":" try:"},{"line_number":1257,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":1258,"context_line":" operation_params \u003d jsonutils.loads("},{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_params)"},{"line_number":1260,"context_line":" error_point \u003d vnf_lcm_op_occs.error_point"},{"line_number":1261,"context_line":" operation \u003d vnf_lcm_op_occs.operation"},{"line_number":1262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2d83c672_cb8ed147","line":1259,"range":{"start_line":1258,"start_character":12,"end_line":1259,"end_character":49},"updated":"2021-02-05 06:18:32.000000000","message":"This variable \"operation_params\" doesn\u0027t seem to be used, is it unnecessary?","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0f3de020665f40eea39ef908e41ba7c4a14c0e8f","unresolved":true,"context_lines":[{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":" try:"},{"line_number":1257,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":1258,"context_line":" operation_params \u003d jsonutils.loads("},{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_params)"},{"line_number":1260,"context_line":" error_point \u003d vnf_lcm_op_occs.error_point"},{"line_number":1261,"context_line":" operation \u003d vnf_lcm_op_occs.operation"},{"line_number":1262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"f896c705_73d8e8c8","line":1259,"range":{"start_line":1258,"start_character":12,"end_line":1259,"end_character":49},"in_reply_to":"2d83c672_cb8ed147","updated":"2021-02-19 13:52:47.000000000","message":"It is removed.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"20f5d04acdd13ead12be1d4b63a7a5d9926a68bb","unresolved":false,"context_lines":[{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":" try:"},{"line_number":1257,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":1258,"context_line":" operation_params \u003d jsonutils.loads("},{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_params)"},{"line_number":1260,"context_line":" error_point \u003d vnf_lcm_op_occs.error_point"},{"line_number":1261,"context_line":" operation \u003d vnf_lcm_op_occs.operation"},{"line_number":1262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9e2edb86_39bdd20f","line":1259,"range":{"start_line":1258,"start_character":12,"end_line":1259,"end_character":49},"in_reply_to":"f896c705_73d8e8c8","updated":"2021-02-22 05:56:10.000000000","message":"I\u0027ve confirmed.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":true,"context_lines":[{"line_number":1257,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":1258,"context_line":" operation_params \u003d jsonutils.loads("},{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_params)"},{"line_number":1260,"context_line":" error_point \u003d vnf_lcm_op_occs.error_point"},{"line_number":1261,"context_line":" operation \u003d vnf_lcm_op_occs.operation"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":" if vnf_lcm_op_occs.operation_state !\u003d \u0027FAILED_TEMP\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3374ebf8_ee4cc4ab","line":1260,"range":{"start_line":1260,"start_character":12,"end_line":1260,"end_character":53},"updated":"2021-02-05 06:18:32.000000000","message":"It seems that the value obtained from \"vnf_lcm_op_occs.error_point\" is substituted as it is.\nDoes this process make sense?","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0f3de020665f40eea39ef908e41ba7c4a14c0e8f","unresolved":true,"context_lines":[{"line_number":1257,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":1258,"context_line":" operation_params \u003d jsonutils.loads("},{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_params)"},{"line_number":1260,"context_line":" error_point \u003d vnf_lcm_op_occs.error_point"},{"line_number":1261,"context_line":" operation \u003d vnf_lcm_op_occs.operation"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":" if vnf_lcm_op_occs.operation_state !\u003d \u0027FAILED_TEMP\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7d4d4509_18756ed8","line":1260,"range":{"start_line":1260,"start_character":12,"end_line":1260,"end_character":53},"in_reply_to":"3374ebf8_ee4cc4ab","updated":"2021-02-19 13:52:47.000000000","message":"It is removed.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"20f5d04acdd13ead12be1d4b63a7a5d9926a68bb","unresolved":false,"context_lines":[{"line_number":1257,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc.get_by_id(context, id)"},{"line_number":1258,"context_line":" operation_params \u003d jsonutils.loads("},{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_params)"},{"line_number":1260,"context_line":" error_point \u003d vnf_lcm_op_occs.error_point"},{"line_number":1261,"context_line":" operation \u003d vnf_lcm_op_occs.operation"},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":" if vnf_lcm_op_occs.operation_state !\u003d \u0027FAILED_TEMP\u0027:"}],"source_content_type":"text/x-python","patch_set":7,"id":"6efdb176_9a9683f4","line":1260,"range":{"start_line":1260,"start_character":12,"end_line":1260,"end_character":53},"in_reply_to":"7d4d4509_18756ed8","updated":"2021-02-22 05:56:10.000000000","message":"I\u0027ve confirmed.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"20f5d04acdd13ead12be1d4b63a7a5d9926a68bb","unresolved":true,"context_lines":[{"line_number":266,"context_line":" LOG.debug(\u0027START NOTIFICATION PROCESS\u0027)"},{"line_number":267,"context_line":" vnf_url \u003d self._get_vnf_instance_href(vnf_instance)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":270,"context_line":" vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":" notification \u003d {"},{"line_number":273,"context_line":" \u0027notificationType\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1654bf02_fcd4aabc","line":270,"range":{"start_line":269,"start_character":8,"end_line":270,"end_character":72},"updated":"2021-02-22 05:56:10.000000000","message":"By doing the following, I think that you can remove unnecessary processing a little more and make it common for \u0027vnf_lcm_op_occs_id\u0027 and \u0027vnf_lcm_url\u0027.\nPlease consider it.\n\n```\n@@ -266,9 +266,6 @@ class VnfLcmController(wsgi.Controller):\n vnf_url \u003d self._get_vnf_instance_href(vnf_instance)\n\n- vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()\n- vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)\n-\n notification \u003d {\n@@ -277,19 +274,13 @@ class VnfLcmController(wsgi.Controller):\n \u0027isAutomaticInvocation\u0027: is_auto,\n- \u0027vnfLcmOpOccId\u0027: vnf_lcm_op_occs_id,\n \u0027_links\u0027: {\n \u0027vnfInstance\u0027: {\n \u0027href\u0027: vnf_url},\n- \u0027vnfLcmOpOcc\u0027: {\n- \u0027href\u0027: vnf_lcm_url}}}\n+ \u0027vnfLcmOpOcc\u0027: {}}}\n\n if operation_state is fields.LcmOccsOperationState.FAILED:\n vnf_lcm_op_occs_id \u003d vnf_lcm_op_occs.id\n- vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)\n-\n- notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_op_occs_id\n- notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnf_lcm_url\n notification[\u0027affectedVnfcs\u0027] \u003d \\\n@@ -299,6 +290,7 @@ class VnfLcmController(wsgi.Controller):\n else:\n+ vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()\n error_point \u003d 0\n@@ -321,6 +313,10 @@ class VnfLcmController(wsgi.Controller):\n raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)\n\n+ vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)\n+ notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_op_occs_id\n+ notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnf_lcm_url\n```","commit_id":"34385708ff2de8c5cc9bfa575dbb43bf6a715b11"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b7048152fb5cf6df2d5faa8c534dfd044fd21d35","unresolved":true,"context_lines":[{"line_number":266,"context_line":" LOG.debug(\u0027START NOTIFICATION PROCESS\u0027)"},{"line_number":267,"context_line":" vnf_url \u003d self._get_vnf_instance_href(vnf_instance)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":270,"context_line":" vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":" notification \u003d {"},{"line_number":273,"context_line":" \u0027notificationType\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"8f5f6987_e1fc870a","line":270,"range":{"start_line":269,"start_character":8,"end_line":270,"end_character":72},"in_reply_to":"1654bf02_fcd4aabc","updated":"2021-03-04 13:40:35.000000000","message":"\u003e By doing the following, I think that you can remove unnecessary processing a little more and make it common for \u0027vnf_lcm_op_occs_id\u0027 and \u0027vnf_lcm_url\u0027.\n\u003e Please consider it.\n\u003e \n\u003e ```\n\u003e @@ -266,9 +266,6 @@ class VnfLcmController(wsgi.Controller):\n\u003e vnf_url \u003d self._get_vnf_instance_href(vnf_instance)\n\u003e \n\u003e - vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()\n\u003e - vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)\n\u003e -\n\u003e notification \u003d {\n\u003e @@ -277,19 +274,13 @@ class VnfLcmController(wsgi.Controller):\n\u003e \u0027isAutomaticInvocation\u0027: is_auto,\n\u003e - \u0027vnfLcmOpOccId\u0027: vnf_lcm_op_occs_id,\n\u003e \u0027_links\u0027: {\n\u003e \u0027vnfInstance\u0027: {\n\u003e \u0027href\u0027: vnf_url},\n\u003e - \u0027vnfLcmOpOcc\u0027: {\n\u003e - \u0027href\u0027: vnf_lcm_url}}}\n\u003e + \u0027vnfLcmOpOcc\u0027: {}}}\n\u003e \n\u003e if operation_state is fields.LcmOccsOperationState.FAILED:\n\u003e vnf_lcm_op_occs_id \u003d vnf_lcm_op_occs.id\n\u003e - vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)\n\u003e -\n\u003e - notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_op_occs_id\n\u003e - notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnf_lcm_url\n\u003e notification[\u0027affectedVnfcs\u0027] \u003d \\\n\u003e @@ -299,6 +290,7 @@ class VnfLcmController(wsgi.Controller):\n\u003e else:\n\u003e + vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()\n\u003e error_point \u003d 0\n\u003e @@ -321,6 +313,10 @@ class VnfLcmController(wsgi.Controller):\n\u003e raise webob.exc.HTTPInternalServerError(explanation\u003dmsg)\n\u003e \n\u003e + vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)\n\u003e + notification[\u0027vnfLcmOpOccId\u0027] \u003d vnf_lcm_op_occs_id\n\u003e + notification[\u0027_links\u0027][\u0027vnfLcmOpOcc\u0027][\u0027href\u0027] \u003d vnf_lcm_url\n\u003e ```\n\nRefactored the source code to allow vnf_lcm_op_occs_id and vnf_lcm_url to be set without unnecessary processing.","commit_id":"34385708ff2de8c5cc9bfa575dbb43bf6a715b11"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e2928652bf74573819e97b9929eb2369117c2cbd","unresolved":false,"context_lines":[{"line_number":266,"context_line":" LOG.debug(\u0027START NOTIFICATION PROCESS\u0027)"},{"line_number":267,"context_line":" vnf_url \u003d self._get_vnf_instance_href(vnf_instance)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"},{"line_number":270,"context_line":" vnf_lcm_url \u003d self._get_vnf_lcm_op_occs_href(vnf_lcm_op_occs_id)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":" notification \u003d {"},{"line_number":273,"context_line":" \u0027notificationType\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"c3e18621_f45468d3","line":270,"range":{"start_line":269,"start_character":8,"end_line":270,"end_character":72},"in_reply_to":"8f5f6987_e1fc870a","updated":"2021-03-05 06:16:12.000000000","message":"I\u0027ve confirmed.","commit_id":"34385708ff2de8c5cc9bfa575dbb43bf6a715b11"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"20f5d04acdd13ead12be1d4b63a7a5d9926a68bb","unresolved":true,"context_lines":[{"line_number":307,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc("},{"line_number":308,"context_line":" context\u003dcontext,"},{"line_number":309,"context_line":" id\u003dvnf_lcm_op_occs_id,"},{"line_number":310,"context_line":" operation_state\u003dfields.LcmOccsOperationState.STARTING,"},{"line_number":311,"context_line":" start_time\u003dtimeutils.utcnow(),"},{"line_number":312,"context_line":" state_entered_time\u003dtimeutils.utcnow(),"},{"line_number":313,"context_line":" vnf_instance_id\u003dvnf_instance.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"d6a314f8_c9352ad5","line":310,"range":{"start_line":310,"start_character":36,"end_line":310,"end_character":73},"updated":"2021-02-22 05:56:10.000000000","message":"I think it\u0027s better to set operation_state.","commit_id":"34385708ff2de8c5cc9bfa575dbb43bf6a715b11"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b7048152fb5cf6df2d5faa8c534dfd044fd21d35","unresolved":true,"context_lines":[{"line_number":307,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc("},{"line_number":308,"context_line":" context\u003dcontext,"},{"line_number":309,"context_line":" id\u003dvnf_lcm_op_occs_id,"},{"line_number":310,"context_line":" operation_state\u003dfields.LcmOccsOperationState.STARTING,"},{"line_number":311,"context_line":" start_time\u003dtimeutils.utcnow(),"},{"line_number":312,"context_line":" state_entered_time\u003dtimeutils.utcnow(),"},{"line_number":313,"context_line":" vnf_instance_id\u003dvnf_instance.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"f805cc4c_83789f42","line":310,"range":{"start_line":310,"start_character":36,"end_line":310,"end_character":73},"in_reply_to":"d6a314f8_c9352ad5","updated":"2021-03-04 13:40:35.000000000","message":"\u003e I think it\u0027s better to set operation_state.\n\noperation_state is set.","commit_id":"34385708ff2de8c5cc9bfa575dbb43bf6a715b11"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e2928652bf74573819e97b9929eb2369117c2cbd","unresolved":false,"context_lines":[{"line_number":307,"context_line":" vnf_lcm_op_occs \u003d objects.VnfLcmOpOcc("},{"line_number":308,"context_line":" context\u003dcontext,"},{"line_number":309,"context_line":" id\u003dvnf_lcm_op_occs_id,"},{"line_number":310,"context_line":" operation_state\u003dfields.LcmOccsOperationState.STARTING,"},{"line_number":311,"context_line":" start_time\u003dtimeutils.utcnow(),"},{"line_number":312,"context_line":" state_entered_time\u003dtimeutils.utcnow(),"},{"line_number":313,"context_line":" vnf_instance_id\u003dvnf_instance.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"304b62f6_197f2724","line":310,"range":{"start_line":310,"start_character":36,"end_line":310,"end_character":73},"in_reply_to":"f805cc4c_83789f42","updated":"2021-03-05 06:16:12.000000000","message":"I\u0027ve confirmed.","commit_id":"34385708ff2de8c5cc9bfa575dbb43bf6a715b11"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":282,"context_line":" if operation_state is fields.LcmOccsOperationState.FAILED:"},{"line_number":283,"context_line":" vnf_lcm_op_occs_id \u003d vnf_lcm_op_occs.id"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":" notification[\u0027affectedVnfcs\u0027] \u003d \\"},{"line_number":286,"context_line":" affected_resources.get(\u0027affectedVnfcs\u0027, [])"},{"line_number":287,"context_line":" notification[\u0027affectedVirtualLinks\u0027] \u003d \\"},{"line_number":288,"context_line":" affected_resources.get(\u0027affectedVirtualLinks\u0027, [])"},{"line_number":289,"context_line":" notification[\u0027affectedVirtualStorages\u0027] \u003d \\"},{"line_number":290,"context_line":" affected_resources.get(\u0027affectedVirtualStorages\u0027, [])"},{"line_number":291,"context_line":" notification[\u0027error\u0027] \u003d str(vnf_lcm_op_occs.error)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":" else:"},{"line_number":294,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9123d1b1_b2869895","line":291,"range":{"start_line":285,"start_character":0,"end_line":291,"end_character":62},"updated":"2021-03-13 17:31:05.000000000","message":"You can avoid to use backslash.","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":282,"context_line":" if operation_state is fields.LcmOccsOperationState.FAILED:"},{"line_number":283,"context_line":" vnf_lcm_op_occs_id \u003d vnf_lcm_op_occs.id"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":" notification[\u0027affectedVnfcs\u0027] \u003d \\"},{"line_number":286,"context_line":" affected_resources.get(\u0027affectedVnfcs\u0027, [])"},{"line_number":287,"context_line":" notification[\u0027affectedVirtualLinks\u0027] \u003d \\"},{"line_number":288,"context_line":" affected_resources.get(\u0027affectedVirtualLinks\u0027, [])"},{"line_number":289,"context_line":" notification[\u0027affectedVirtualStorages\u0027] \u003d \\"},{"line_number":290,"context_line":" affected_resources.get(\u0027affectedVirtualStorages\u0027, [])"},{"line_number":291,"context_line":" notification[\u0027error\u0027] \u003d str(vnf_lcm_op_occs.error)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":" else:"},{"line_number":294,"context_line":" vnf_lcm_op_occs_id \u003d uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":12,"id":"bb474696_2f938a63","line":291,"range":{"start_line":285,"start_character":0,"end_line":291,"end_character":62},"in_reply_to":"9123d1b1_b2869895","updated":"2021-03-17 01:26:41.000000000","message":"\u003e You can avoid to use backslash.\n\nupdated the lines to not use backslash","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_state \u003d \"FAILED\""},{"line_number":1260,"context_line":" vnf_lcm_op_occs.state_entered_time \u003d \\"},{"line_number":1261,"context_line":" datetime.datetime.utcnow().isoformat()"},{"line_number":1262,"context_line":" vnf_lcm_op_occs.updated_at \u003d \\"},{"line_number":1263,"context_line":" datetime.datetime.utcnow().isoformat()"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":" error_details \u003d objects.ProblemDetails("},{"line_number":1266,"context_line":" context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":12,"id":"94d5d210_72fc5274","line":1263,"range":{"start_line":1262,"start_character":0,"end_line":1263,"end_character":54},"updated":"2021-03-13 17:31:05.000000000","message":"nit. It\u0027s more reasonable.\n\n```\nvnf_lcm_op_occs.updated_at \u003d vnf_lcm_op_occs.state_entered_time\n```","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":1259,"context_line":" vnf_lcm_op_occs.operation_state \u003d \"FAILED\""},{"line_number":1260,"context_line":" vnf_lcm_op_occs.state_entered_time \u003d \\"},{"line_number":1261,"context_line":" datetime.datetime.utcnow().isoformat()"},{"line_number":1262,"context_line":" vnf_lcm_op_occs.updated_at \u003d \\"},{"line_number":1263,"context_line":" datetime.datetime.utcnow().isoformat()"},{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":" error_details \u003d objects.ProblemDetails("},{"line_number":1266,"context_line":" context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":12,"id":"b14c66ac_f1bdac5c","line":1263,"range":{"start_line":1262,"start_character":0,"end_line":1263,"end_character":54},"in_reply_to":"94d5d210_72fc5274","updated":"2021-03-17 01:26:41.000000000","message":"\u003e nit. It\u0027s more reasonable.\n\u003e \n\u003e ```\n\u003e vnf_lcm_op_occs.updated_at \u003d vnf_lcm_op_occs.state_entered_time\n\u003e ```\n\nFixed as suggested.","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":1286,"context_line":" affected_resources \u003d vnflcm_utils._get_affected_resources("},{"line_number":1287,"context_line":" old_vnf_instance\u003dold_vnf_instance,"},{"line_number":1288,"context_line":" new_vnf_instance\u003dvnf_instance)"},{"line_number":1289,"context_line":" affected_resources_snake_case \u003d \\"},{"line_number":1290,"context_line":" utils.convert_camelcase_to_snakecase(affected_resources)"},{"line_number":1291,"context_line":" resource_change_obj \u003d \\"},{"line_number":1292,"context_line":" jsonutils.dumps(affected_resources_snake_case)"},{"line_number":1293,"context_line":" changed_resource \u003d objects.ResourceChanges.obj_from_primitive("},{"line_number":1294,"context_line":" resource_change_obj, context)"},{"line_number":1295,"context_line":" vnf_lcm_op_occs.resource_changes \u003d changed_resource"}],"source_content_type":"text/x-python","patch_set":12,"id":"a5656dcd_26ae71a2","line":1292,"range":{"start_line":1289,"start_character":0,"end_line":1292,"end_character":62},"updated":"2021-03-13 17:31:05.000000000","message":"It can be simplified. No need to use such a long name and backslashes.\n\n```\nresource_change_obj \u003d jsonutils.dumps(\n utils.convert_camelcase_to_snakecase(affected_resources))\n```","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":1286,"context_line":" affected_resources \u003d vnflcm_utils._get_affected_resources("},{"line_number":1287,"context_line":" old_vnf_instance\u003dold_vnf_instance,"},{"line_number":1288,"context_line":" new_vnf_instance\u003dvnf_instance)"},{"line_number":1289,"context_line":" affected_resources_snake_case \u003d \\"},{"line_number":1290,"context_line":" utils.convert_camelcase_to_snakecase(affected_resources)"},{"line_number":1291,"context_line":" resource_change_obj \u003d \\"},{"line_number":1292,"context_line":" jsonutils.dumps(affected_resources_snake_case)"},{"line_number":1293,"context_line":" changed_resource \u003d objects.ResourceChanges.obj_from_primitive("},{"line_number":1294,"context_line":" resource_change_obj, context)"},{"line_number":1295,"context_line":" vnf_lcm_op_occs.resource_changes \u003d changed_resource"}],"source_content_type":"text/x-python","patch_set":12,"id":"d2e7b220_637dc4a2","line":1292,"range":{"start_line":1289,"start_character":0,"end_line":1292,"end_character":62},"in_reply_to":"a5656dcd_26ae71a2","updated":"2021-03-17 01:26:41.000000000","message":"\u003e It can be simplified. No need to use such a long name and backslashes.\n\u003e \n\u003e ```\n\u003e resource_change_obj \u003d jsonutils.dumps(\n\u003e utils.convert_camelcase_to_snakecase(affected_resources))\n\u003e ```\n\nmerged lines into one as suggested.","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":1295,"context_line":" vnf_lcm_op_occs.resource_changes \u003d changed_resource"},{"line_number":1296,"context_line":" vnf_lcm_op_occs.save()"},{"line_number":1297,"context_line":" except Exception as ex:"},{"line_number":1298,"context_line":" error_msg \u003d \"Error in VNF Fail for vnf {}\" \\"},{"line_number":1299,"context_line":" \"because {}\".format("},{"line_number":1300,"context_line":" vnf_instance.id,"},{"line_number":1301,"context_line":" encodeutils."},{"line_number":1302,"context_line":" exception_to_unicode(ex))"},{"line_number":1303,"context_line":" LOG.error(\"VNF Fail Error {}\".format(error_msg))"},{"line_number":1304,"context_line":" raise exceptions.TackerException(message\u003derror_msg)"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":" return self._fail(context, vnf_instance, vnf_lcm_op_occs,"}],"source_content_type":"text/x-python","patch_set":12,"id":"99f6f2a7_9b738ab0","line":1303,"range":{"start_line":1298,"start_character":0,"end_line":1303,"end_character":60},"updated":"2021-03-13 17:31:05.000000000","message":"This error msg feels strange for me.\n\"VNF Fail Error Error in VNF Fail for vnf VID because REASON\"\n\nI think it\u0027s enough as following.\n\n```\nerror_msg \u003d \"Error in VNF Fail for vnf {} because {}\".format(\n vnf_instance.id,encodeutils.exception_to_unicode(ex))\nLOG.error(error_msg)\n```","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":1295,"context_line":" vnf_lcm_op_occs.resource_changes \u003d changed_resource"},{"line_number":1296,"context_line":" vnf_lcm_op_occs.save()"},{"line_number":1297,"context_line":" except Exception as ex:"},{"line_number":1298,"context_line":" error_msg \u003d \"Error in VNF Fail for vnf {}\" \\"},{"line_number":1299,"context_line":" \"because {}\".format("},{"line_number":1300,"context_line":" vnf_instance.id,"},{"line_number":1301,"context_line":" encodeutils."},{"line_number":1302,"context_line":" exception_to_unicode(ex))"},{"line_number":1303,"context_line":" LOG.error(\"VNF Fail Error {}\".format(error_msg))"},{"line_number":1304,"context_line":" raise exceptions.TackerException(message\u003derror_msg)"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":" return self._fail(context, vnf_instance, vnf_lcm_op_occs,"}],"source_content_type":"text/x-python","patch_set":12,"id":"a23fe833_696918ea","line":1303,"range":{"start_line":1298,"start_character":0,"end_line":1303,"end_character":60},"in_reply_to":"99f6f2a7_9b738ab0","updated":"2021-03-17 01:26:41.000000000","message":"\u003e This error msg feels strange for me.\n\u003e \"VNF Fail Error Error in VNF Fail for vnf VID because REASON\"\n\u003e \n\u003e I think it\u0027s enough as following.\n\u003e \n\u003e ```\n\u003e error_msg \u003d \"Error in VNF Fail for vnf {} because {}\".format(\n\u003e vnf_instance.id,encodeutils.exception_to_unicode(ex))\n\u003e LOG.error(error_msg)\n\u003e ```\n\nupdated LOG.error as suggested.","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"}],"tacker/tests/functional/sol/vnflcm/base.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":518,"context_line":" self.h_client.stacks.delete(stack_id)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":" def _wait_until_stack_ready(self, stack_id, expected_status):"},{"line_number":521,"context_line":" start_time \u003d int(time.time())"},{"line_number":522,"context_line":" callback_url \u003d os.path.join("},{"line_number":523,"context_line":" MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":524,"context_line":" self._testMethodName)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7eb5decb_cf1d90aa","line":521,"range":{"start_line":521,"start_character":21,"end_line":521,"end_character":37},"updated":"2021-03-13 17:31:05.000000000","message":"No need to be int.","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":518,"context_line":" self.h_client.stacks.delete(stack_id)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":" def _wait_until_stack_ready(self, stack_id, expected_status):"},{"line_number":521,"context_line":" start_time \u003d int(time.time())"},{"line_number":522,"context_line":" callback_url \u003d os.path.join("},{"line_number":523,"context_line":" MOCK_NOTIFY_CALLBACK_URL,"},{"line_number":524,"context_line":" self._testMethodName)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7efa9094_19b2a33b","line":521,"range":{"start_line":521,"start_character":21,"end_line":521,"end_character":37},"in_reply_to":"7eb5decb_cf1d90aa","updated":"2021-03-17 01:26:41.000000000","message":"\u003e No need to be int.\n\nremoved casting to int","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":533,"context_line":" flush\u003dTrue)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":" if actual_status \u003d\u003d expected_status:"},{"line_number":536,"context_line":" return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":" if ((int(time.time()) - start_time) \u003e"},{"line_number":539,"context_line":" VNF_LCM_DONE_TIMEOUT):"}],"source_content_type":"text/x-python","patch_set":12,"id":"e36b9cdc_bd498b05","line":536,"updated":"2021-03-13 17:31:05.000000000","message":"Please make it appear the returned value.","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":533,"context_line":" flush\u003dTrue)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":" if actual_status \u003d\u003d expected_status:"},{"line_number":536,"context_line":" return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":" if ((int(time.time()) - start_time) \u003e"},{"line_number":539,"context_line":" VNF_LCM_DONE_TIMEOUT):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bace3c92_11c6ec74","line":536,"in_reply_to":"e36b9cdc_bd498b05","updated":"2021-03-17 01:26:41.000000000","message":"\u003e Please make it appear the returned value.\n\nadded NONE to the return value","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":535,"context_line":" if actual_status \u003d\u003d expected_status:"},{"line_number":536,"context_line":" return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":" if ((int(time.time()) - start_time) \u003e"},{"line_number":539,"context_line":" VNF_LCM_DONE_TIMEOUT):"},{"line_number":540,"context_line":" if actual_status:"},{"line_number":541,"context_line":" error \u003d ("},{"line_number":542,"context_line":" \"LCM incomplete timeout, \" +"}],"source_content_type":"text/x-python","patch_set":12,"id":"7595e643_d7d3e280","line":539,"range":{"start_line":538,"start_character":0,"end_line":539,"end_character":42},"updated":"2021-03-13 17:31:05.000000000","message":"It\u0027s redundant for the purpose. It\u0027s enough if you don\u0027t use int() above.\n\n```\nif time.time() - start_time \u003e VNF_LCM_DONE_TIMEOUT:\n```","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":535,"context_line":" if actual_status \u003d\u003d expected_status:"},{"line_number":536,"context_line":" return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":" if ((int(time.time()) - start_time) \u003e"},{"line_number":539,"context_line":" VNF_LCM_DONE_TIMEOUT):"},{"line_number":540,"context_line":" if actual_status:"},{"line_number":541,"context_line":" error \u003d ("},{"line_number":542,"context_line":" \"LCM incomplete timeout, \" +"}],"source_content_type":"text/x-python","patch_set":12,"id":"6b560ae7_c5516330","line":539,"range":{"start_line":538,"start_character":0,"end_line":539,"end_character":42},"in_reply_to":"7595e643_d7d3e280","updated":"2021-03-17 01:26:41.000000000","message":"\u003e It\u0027s redundant for the purpose. It\u0027s enough if you don\u0027t use int() above.\n\u003e \n\u003e ```\n\u003e if time.time() - start_time \u003e VNF_LCM_DONE_TIMEOUT:\n\u003e ```\n\nremove int casting","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"}],"tacker/tests/unit/vnflcm/fakes.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":882,"context_line":" return objects.VnfLcmOpOcc("},{"line_number":883,"context_line":" state_entered_time\u003ddatetime.datetime(2000, 1, 1, 1, 1, 1,"},{"line_number":884,"context_line":" tzinfo\u003diso8601.UTC),"},{"line_number":885,"context_line":" start_time\u003ddatetime.datetime(2000, 1, 1, 1, 1, 1,"},{"line_number":886,"context_line":" tzinfo\u003diso8601.UTC),"},{"line_number":887,"context_line":" vnf_instance_id\u003duuidsentinel.vnf_instance_id,"},{"line_number":888,"context_line":" operation\u003d\u0027INSTANTIATE\u0027,"},{"line_number":889,"context_line":" operation_state\u003d\u0027FAILED_TEMP\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"481244fe_1c704098","line":886,"range":{"start_line":885,"start_character":19,"end_line":886,"end_character":56},"updated":"2021-03-13 17:31:05.000000000","message":"It\u0027s redundant to call datetime here and l.894 again and again. Why don\u0027t you assign a variable before return and use it instead?\n\n```\ndef vnflcm_fail_insta(error_point\u003d7):\n dt \u003d datetime.datetime(2000, 1, 1, 1, 1, 1, tzinfo\u003diso8601.UTC)\n return objects.VnfLcmOpOcc(\n state_entered_time\u003ddt, start_time\u003ddt,\n vnf_instance_id\u003duuidsentinel.vnf_instance_id,\n ...,\n created_at\u003ddt)\n```","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":882,"context_line":" return objects.VnfLcmOpOcc("},{"line_number":883,"context_line":" state_entered_time\u003ddatetime.datetime(2000, 1, 1, 1, 1, 1,"},{"line_number":884,"context_line":" tzinfo\u003diso8601.UTC),"},{"line_number":885,"context_line":" start_time\u003ddatetime.datetime(2000, 1, 1, 1, 1, 1,"},{"line_number":886,"context_line":" tzinfo\u003diso8601.UTC),"},{"line_number":887,"context_line":" vnf_instance_id\u003duuidsentinel.vnf_instance_id,"},{"line_number":888,"context_line":" operation\u003d\u0027INSTANTIATE\u0027,"},{"line_number":889,"context_line":" operation_state\u003d\u0027FAILED_TEMP\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"dbc5f411_605e92c3","line":886,"range":{"start_line":885,"start_character":19,"end_line":886,"end_character":56},"in_reply_to":"481244fe_1c704098","updated":"2021-03-17 01:26:41.000000000","message":"\u003e It\u0027s redundant to call datetime here and l.894 again and again. Why don\u0027t you assign a variable before return and use it instead?\n\u003e \n\u003e ```\n\u003e def vnflcm_fail_insta(error_point\u003d7):\n\u003e dt \u003d datetime.datetime(2000, 1, 1, 1, 1, 1, tzinfo\u003diso8601.UTC)\n\u003e return objects.VnfLcmOpOcc(\n\u003e state_entered_time\u003ddt, start_time\u003ddt,\n\u003e vnf_instance_id\u003duuidsentinel.vnf_instance_id,\n\u003e ...,\n\u003e created_at\u003ddt)\n\u003e ```\n\ncreated a variable and assigned to parameters","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"27ff905d15dfacc4ea8194082fd9c9522de88851","unresolved":true,"context_lines":[{"line_number":2831,"context_line":" mock_view.return_value \u003d fakes.VNFLCMOPOCC_RESPONSE"},{"line_number":2832,"context_line":" res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":2833,"context_line":" self.assertEqual(fakes.VNFLCMOPOCC_RESPONSE, res_dict)"},{"line_number":2834,"context_line":""},{"line_number":2835,"context_line":" @mock.patch.object(objects.VnfInstance, \"get_by_id\")"},{"line_number":2836,"context_line":" @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":2837,"context_line":" def test_fail_lcm_op_occs_not_found(self, mock_lcm_get_by_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ddafec9c_5d0c8f5e","line":2834,"updated":"2021-02-05 06:18:32.000000000","message":"I think you should add a unittests for \"State is not FAILED_TEMP(409)\" and \"VNF NOT FOUND(404)\".","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e2928652bf74573819e97b9929eb2369117c2cbd","unresolved":false,"context_lines":[{"line_number":2831,"context_line":" mock_view.return_value \u003d fakes.VNFLCMOPOCC_RESPONSE"},{"line_number":2832,"context_line":" res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":2833,"context_line":" self.assertEqual(fakes.VNFLCMOPOCC_RESPONSE, res_dict)"},{"line_number":2834,"context_line":""},{"line_number":2835,"context_line":" @mock.patch.object(objects.VnfInstance, \"get_by_id\")"},{"line_number":2836,"context_line":" @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":2837,"context_line":" def test_fail_lcm_op_occs_not_found(self, mock_lcm_get_by_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"43c5347d_bd4f3e7a","line":2834,"in_reply_to":"272aa2c2_a716b734","updated":"2021-03-05 06:16:12.000000000","message":"I\u0027ve confirmed.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b7048152fb5cf6df2d5faa8c534dfd044fd21d35","unresolved":true,"context_lines":[{"line_number":2831,"context_line":" mock_view.return_value \u003d fakes.VNFLCMOPOCC_RESPONSE"},{"line_number":2832,"context_line":" res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":2833,"context_line":" self.assertEqual(fakes.VNFLCMOPOCC_RESPONSE, res_dict)"},{"line_number":2834,"context_line":""},{"line_number":2835,"context_line":" @mock.patch.object(objects.VnfInstance, \"get_by_id\")"},{"line_number":2836,"context_line":" @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":2837,"context_line":" def test_fail_lcm_op_occs_not_found(self, mock_lcm_get_by_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"272aa2c2_a716b734","line":2834,"in_reply_to":"545f27ca_8d15408f","updated":"2021-03-04 13:40:35.000000000","message":"\u003e As you can see from the report below, I don\u0027t think \u0027test_fail_lcm_op_occs_vnf_not_found\u0027 is what you expected.\n\u003e Please check it.\n\u003e \n\u003e https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_330/772090/10/check/openstack-tox-cover/3308aef/cover/tacker_api_vnflcm_v1_controller_py.html#t1250\n\nUpdated exception clause and use correct side_effect for test_controller. Also added additional assertEqual to show that change is successful.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"20f5d04acdd13ead12be1d4b63a7a5d9926a68bb","unresolved":true,"context_lines":[{"line_number":2831,"context_line":" mock_view.return_value \u003d fakes.VNFLCMOPOCC_RESPONSE"},{"line_number":2832,"context_line":" res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":2833,"context_line":" self.assertEqual(fakes.VNFLCMOPOCC_RESPONSE, res_dict)"},{"line_number":2834,"context_line":""},{"line_number":2835,"context_line":" @mock.patch.object(objects.VnfInstance, \"get_by_id\")"},{"line_number":2836,"context_line":" @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":2837,"context_line":" def test_fail_lcm_op_occs_not_found(self, mock_lcm_get_by_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"545f27ca_8d15408f","line":2834,"in_reply_to":"bbe15125_12f7e4a4","updated":"2021-02-22 05:56:10.000000000","message":"As you can see from the report below, I don\u0027t think \u0027test_fail_lcm_op_occs_vnf_not_found\u0027 is what you expected.\nPlease check it.\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_330/772090/10/check/openstack-tox-cover/3308aef/cover/tacker_api_vnflcm_v1_controller_py.html#t1250","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0f3de020665f40eea39ef908e41ba7c4a14c0e8f","unresolved":true,"context_lines":[{"line_number":2831,"context_line":" mock_view.return_value \u003d fakes.VNFLCMOPOCC_RESPONSE"},{"line_number":2832,"context_line":" res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":2833,"context_line":" self.assertEqual(fakes.VNFLCMOPOCC_RESPONSE, res_dict)"},{"line_number":2834,"context_line":""},{"line_number":2835,"context_line":" @mock.patch.object(objects.VnfInstance, \"get_by_id\")"},{"line_number":2836,"context_line":" @mock.patch.object(objects.VnfLcmOpOcc, \"get_by_id\")"},{"line_number":2837,"context_line":" def test_fail_lcm_op_occs_not_found(self, mock_lcm_get_by_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bbe15125_12f7e4a4","line":2834,"in_reply_to":"ddafec9c_5d0c8f5e","updated":"2021-02-19 13:52:47.000000000","message":"Added 2 new unit test codes as requested.","commit_id":"0f3ef353c54f4fb0044c939aade5f5710a1fb42a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"721a735323f187c11676adaa3d9b246a21bc3799","unresolved":true,"context_lines":[{"line_number":2826,"context_line":" mock_update):"},{"line_number":2827,"context_line":" req \u003d fake_request.HTTPRequest.blank("},{"line_number":2828,"context_line":" \u0027/vnf_lcm_op_occs/%s/fail\u0027 % constants.UUID)"},{"line_number":2829,"context_line":" mock_lcm_get_by_id.return_value \u003d \\"},{"line_number":2830,"context_line":" fakes.vnflcm_fail_insta()"},{"line_number":2831,"context_line":" mock_view.return_value \u003d fakes.VNFLCMOPOCC_RESPONSE"},{"line_number":2832,"context_line":" res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":2833,"context_line":" self.assertEqual(fakes.VNFLCMOPOCC_RESPONSE, res_dict)"}],"source_content_type":"text/x-python","patch_set":12,"id":"54575dcc_23290472","line":2830,"range":{"start_line":2829,"start_character":0,"end_line":2830,"end_character":37},"updated":"2021-03-13 17:31:05.000000000","message":"No need to be two lines with backslash. It\u0027s 67 chars totally.","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b49cd9686f2f94b25244e2b74052938a675e3e6","unresolved":true,"context_lines":[{"line_number":2826,"context_line":" mock_update):"},{"line_number":2827,"context_line":" req \u003d fake_request.HTTPRequest.blank("},{"line_number":2828,"context_line":" \u0027/vnf_lcm_op_occs/%s/fail\u0027 % constants.UUID)"},{"line_number":2829,"context_line":" mock_lcm_get_by_id.return_value \u003d \\"},{"line_number":2830,"context_line":" fakes.vnflcm_fail_insta()"},{"line_number":2831,"context_line":" mock_view.return_value \u003d fakes.VNFLCMOPOCC_RESPONSE"},{"line_number":2832,"context_line":" res_dict \u003d self.controller.fail(req, constants.UUID)"},{"line_number":2833,"context_line":" self.assertEqual(fakes.VNFLCMOPOCC_RESPONSE, res_dict)"}],"source_content_type":"text/x-python","patch_set":12,"id":"e36a9bea_1e99d8e2","line":2830,"range":{"start_line":2829,"start_character":0,"end_line":2830,"end_character":37},"in_reply_to":"54575dcc_23290472","updated":"2021-03-17 01:26:41.000000000","message":"\u003e No need to be two lines with backslash. It\u0027s 67 chars totally.\n\nremoved line break and backslash","commit_id":"bce8a895bb1a7f327a3136dcd65fdca2943991ba"}]}