)]}'
{"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":861,"context_line":"        if CONF.vnf_lcm.test_callbackUri:"},{"line_number":862,"context_line":"            resp \u003d self._get_notification(request.context,"},{"line_number":863,"context_line":"                vnf_lcm_subscription)"},{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Cannot Get Notification\u0027, 400,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8184afd_a6d66106","line":864,"range":{"start_line":864,"start_character":12,"end_line":864,"end_character":28},"updated":"2021-01-26 02:36:34.000000000","message":"This never happen because `_get_notification()` use cast() method in RPC and it doesn\u0027t return the result. `call()` has to be used instead.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":861,"context_line":"        if CONF.vnf_lcm.test_callbackUri:"},{"line_number":862,"context_line":"            resp \u003d self._get_notification(request.context,"},{"line_number":863,"context_line":"                vnf_lcm_subscription)"},{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Cannot Get Notification\u0027, 400,"}],"source_content_type":"text/x-python","patch_set":3,"id":"64ae3baf_d665c49c","line":864,"range":{"start_line":864,"start_character":12,"end_line":864,"end_character":28},"in_reply_to":"f8184afd_a6d66106","updated":"2021-02-01 17:16:21.000000000","message":"we used cast\u003dFalse in the call so that return is obtained.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    def _get_notification(self, context, vnf_lcm_subscription):"},{"line_number":1232,"context_line":"        notification \u003d {}"},{"line_number":1233,"context_line":"        resp \u003d self.rpc_api.send_notification(context, notification,"},{"line_number":1234,"context_line":"            vnf_lcm_subscription)"},{"line_number":1235,"context_line":"        return resp"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a8f10615_ed198160","line":1234,"range":{"start_line":1233,"start_character":8,"end_line":1234,"end_character":33},"updated":"2021-01-26 02:36:34.000000000","message":"`cast\u003dFalse` is required in the arguments to get the response from RPC method.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    def _get_notification(self, context, vnf_lcm_subscription):"},{"line_number":1232,"context_line":"        notification \u003d {}"},{"line_number":1233,"context_line":"        resp \u003d self.rpc_api.send_notification(context, notification,"},{"line_number":1234,"context_line":"            vnf_lcm_subscription)"},{"line_number":1235,"context_line":"        return resp"},{"line_number":1236,"context_line":""},{"line_number":1237,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"f528cac4_1a484693","line":1234,"range":{"start_line":1233,"start_character":8,"end_line":1234,"end_character":33},"in_reply_to":"a8f10615_ed198160","updated":"2021-02-01 17:16:21.000000000","message":"fixed as suggested.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Cannot Get Notification\u0027, 400,"},{"line_number":868,"context_line":"                    title\u003d\u0027Bad Request\u0027)"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"b907652d_ded6f5e9","line":867,"range":{"start_line":867,"start_character":21,"end_line":867,"end_character":44},"updated":"2021-02-26 06:02:26.000000000","message":"I think \u0027Failed to test notification\u0027 is better to describe this situation.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":false,"context_lines":[{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Cannot Get Notification\u0027, 400,"},{"line_number":868,"context_line":"                    title\u003d\u0027Bad Request\u0027)"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bedb3cbd_7eede5bf","line":867,"range":{"start_line":867,"start_character":21,"end_line":867,"end_character":44},"in_reply_to":"841ba3fa_5be78ce2","updated":"2021-03-11 09:38:56.000000000","message":"I\u0027ve confirmed.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Cannot Get Notification\u0027, 400,"},{"line_number":868,"context_line":"                    title\u003d\u0027Bad Request\u0027)"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"841ba3fa_5be78ce2","line":867,"range":{"start_line":867,"start_character":21,"end_line":867,"end_character":44},"in_reply_to":"b907652d_ded6f5e9","updated":"2021-03-04 20:00:19.000000000","message":"\u003e I think \u0027Failed to test notification\u0027 is better to describe this situation.\n\nMessage \u0027Cannot Get Notification\u0027 is changed to \u0027Failed to Test Notification\u0027","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"        res.status_int \u003d status"},{"line_number":1229,"context_line":"        return res"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    def _get_notification(self, context, vnf_lcm_subscription):"},{"line_number":1232,"context_line":"        resp \u003d self.rpc_api.get_notification(context,"},{"line_number":1233,"context_line":"            vnf_lcm_subscription, cast\u003dFalse)"},{"line_number":1234,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":8,"id":"2a95631f_cc9777c5","line":1231,"range":{"start_line":1231,"start_character":8,"end_line":1231,"end_character":25},"updated":"2021-02-26 06:02:26.000000000","message":"The method of this request is \u0027GET\u0027, but I think \u0027_test_notification\u0027 is more appropriate because the operation here is testing notification endpoint.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"        res.status_int \u003d status"},{"line_number":1229,"context_line":"        return res"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    def _get_notification(self, context, vnf_lcm_subscription):"},{"line_number":1232,"context_line":"        resp \u003d self.rpc_api.get_notification(context,"},{"line_number":1233,"context_line":"            vnf_lcm_subscription, cast\u003dFalse)"},{"line_number":1234,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":8,"id":"60a8564a_565bc44b","line":1231,"range":{"start_line":1231,"start_character":8,"end_line":1231,"end_character":25},"in_reply_to":"2a95631f_cc9777c5","updated":"2021-03-04 20:00:19.000000000","message":"\u003e The method of this request is \u0027GET\u0027, but I think \u0027_test_notification\u0027 is more appropriate because the operation here is testing notification endpoint.\n\nMethod name \u0027_get_notification\u0027 is changed to \u0027_test_notification\u0027","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"        res.status_int \u003d status"},{"line_number":1229,"context_line":"        return res"},{"line_number":1230,"context_line":""},{"line_number":1231,"context_line":"    def _get_notification(self, context, vnf_lcm_subscription):"},{"line_number":1232,"context_line":"        resp \u003d self.rpc_api.get_notification(context,"},{"line_number":1233,"context_line":"            vnf_lcm_subscription, cast\u003dFalse)"},{"line_number":1234,"context_line":"        return resp"}],"source_content_type":"text/x-python","patch_set":8,"id":"ce005093_2fdafb9b","line":1231,"range":{"start_line":1231,"start_character":8,"end_line":1231,"end_character":25},"in_reply_to":"60a8564a_565bc44b","updated":"2021-03-11 09:38:56.000000000","message":"I\u0027ve confirmed.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"21a31c0807bb528d4b9732725d58d7f86995a55a","unresolved":true,"context_lines":[{"line_number":861,"context_line":"        if CONF.vnf_lcm.test_callback_uri:"},{"line_number":862,"context_line":"            resp \u003d self._test_notification(request.context,"},{"line_number":863,"context_line":"                vnf_lcm_subscription)"},{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Failed to Test Notification\u0027, 400,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ad42ba19_1e151168","line":864,"updated":"2021-03-18 01:18:54.000000000","message":"parenthesis is not necessary.","commit_id":"9c856b1580fe19e970ddd4918ab0b8d8df7b0204"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ba78c6e32a3666f8429565ee82b9c0936a700bdc","unresolved":true,"context_lines":[{"line_number":861,"context_line":"        if CONF.vnf_lcm.test_callback_uri:"},{"line_number":862,"context_line":"            resp \u003d self._test_notification(request.context,"},{"line_number":863,"context_line":"                vnf_lcm_subscription)"},{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Failed to Test Notification\u0027, 400,"}],"source_content_type":"text/x-python","patch_set":12,"id":"052d5536_d270f5a0","line":864,"in_reply_to":"ad42ba19_1e151168","updated":"2021-03-23 03:14:14.000000000","message":"\u003e parenthesis is not necessary.\n\nremoved parenthesis","commit_id":"9c856b1580fe19e970ddd4918ab0b8d8df7b0204"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"21a31c0807bb528d4b9732725d58d7f86995a55a","unresolved":true,"context_lines":[{"line_number":862,"context_line":"            resp \u003d self._test_notification(request.context,"},{"line_number":863,"context_line":"                vnf_lcm_subscription)"},{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Failed to Test Notification\u0027, 400,"},{"line_number":868,"context_line":"                    title\u003d\u0027Bad Request\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"df253276_2904fe0b","line":865,"updated":"2021-03-18 01:18:54.000000000","message":"use LOG.exception","commit_id":"9c856b1580fe19e970ddd4918ab0b8d8df7b0204"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ba78c6e32a3666f8429565ee82b9c0936a700bdc","unresolved":true,"context_lines":[{"line_number":862,"context_line":"            resp \u003d self._test_notification(request.context,"},{"line_number":863,"context_line":"                vnf_lcm_subscription)"},{"line_number":864,"context_line":"            if (resp \u003d\u003d -1):"},{"line_number":865,"context_line":"                LOG.error(traceback.format_exc())"},{"line_number":866,"context_line":"                return self._make_problem_detail("},{"line_number":867,"context_line":"                    \u0027Failed to Test Notification\u0027, 400,"},{"line_number":868,"context_line":"                    title\u003d\u0027Bad Request\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"916e17b4_348fb453","line":865,"in_reply_to":"df253276_2904fe0b","updated":"2021-03-23 03:14:14.000000000","message":"\u003e use LOG.exception\n\nLOG.error replaced with LOG.exception","commit_id":"9c856b1580fe19e970ddd4918ab0b8d8df7b0204"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":1464,"context_line":"        try:"},{"line_number":1465,"context_line":"            LOG.debug(\"send_notification start notification[%s]\""},{"line_number":1466,"context_line":"                      % notification)"},{"line_number":1467,"context_line":"            if ((CONF.vnf_lcm.test_callbackUri is True) and"},{"line_number":1468,"context_line":"                    (notification \u003d\u003d {})):"},{"line_number":1469,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1470,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"}],"source_content_type":"text/x-python","patch_set":3,"id":"6d5c27f0_c4f4ba96","line":1467,"range":{"start_line":1467,"start_character":30,"end_line":1467,"end_character":46},"updated":"2021-01-26 02:36:34.000000000","message":"Why don’t you use \"snake_case\"?","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":1464,"context_line":"        try:"},{"line_number":1465,"context_line":"            LOG.debug(\"send_notification start notification[%s]\""},{"line_number":1466,"context_line":"                      % notification)"},{"line_number":1467,"context_line":"            if ((CONF.vnf_lcm.test_callbackUri is True) and"},{"line_number":1468,"context_line":"                    (notification \u003d\u003d {})):"},{"line_number":1469,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1470,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4b6ac551_bb4c8a0e","line":1467,"range":{"start_line":1467,"start_character":30,"end_line":1467,"end_character":46},"in_reply_to":"6d5c27f0_c4f4ba96","updated":"2021-02-01 17:16:21.000000000","message":"changed to snake_case.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":1525,"context_line":"                        LOG.warn(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":1526,"context_line":"                        auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1527,"context_line":"                            line.id)"},{"line_number":1528,"context_line":"                        if ((CONF.vnf_lcm.test_callbackUri is True) and"},{"line_number":1529,"context_line":"                                (notification \u003d\u003d {})):"},{"line_number":1530,"context_line":"                            response \u003d auth_client.get("},{"line_number":1531,"context_line":"                                line.callback_uri,"}],"source_content_type":"text/x-python","patch_set":3,"id":"76bf2d7b_7d568fde","line":1528,"range":{"start_line":1528,"start_character":47,"end_line":1528,"end_character":58},"updated":"2021-01-26 02:36:34.000000000","message":"ditto","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":1525,"context_line":"                        LOG.warn(\"send notify[%s]\" % json.dumps(notification))"},{"line_number":1526,"context_line":"                        auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1527,"context_line":"                            line.id)"},{"line_number":1528,"context_line":"                        if ((CONF.vnf_lcm.test_callbackUri is True) and"},{"line_number":1529,"context_line":"                                (notification \u003d\u003d {})):"},{"line_number":1530,"context_line":"                            response \u003d auth_client.get("},{"line_number":1531,"context_line":"                                line.callback_uri,"}],"source_content_type":"text/x-python","patch_set":3,"id":"911aeb4a_75d6292d","line":1528,"range":{"start_line":1528,"start_character":47,"end_line":1528,"end_character":58},"in_reply_to":"76bf2d7b_7d568fde","updated":"2021-02-01 17:16:21.000000000","message":"changed to snake_case.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"change_message_id":"c6d2403c5dc9f64535d793be84c00496463d963c","unresolved":true,"context_lines":[{"line_number":1470,"context_line":"                      % notification)"},{"line_number":1471,"context_line":"            if ((CONF.vnf_lcm.test_callback_uri is True) and"},{"line_number":1472,"context_line":"                    (notification \u003d\u003d {})):"},{"line_number":1473,"context_line":"                method_used \u003d \"GET\""},{"line_number":1474,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1475,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"},{"line_number":1476,"context_line":"                notification_id \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"5475454f_c9aa57c3","line":1473,"updated":"2021-02-05 03:52:02.000000000","message":"Should GET method case be included in this one function? I think it\u0027s better to separate it.","commit_id":"ff1a372394a83545fb542595606880c031e70d23"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"312a26aa2954f57f8d09a585a2141c293d529f38","unresolved":true,"context_lines":[{"line_number":1470,"context_line":"                      % notification)"},{"line_number":1471,"context_line":"            if ((CONF.vnf_lcm.test_callback_uri is True) and"},{"line_number":1472,"context_line":"                    (notification \u003d\u003d {})):"},{"line_number":1473,"context_line":"                method_used \u003d \"GET\""},{"line_number":1474,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1475,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"},{"line_number":1476,"context_line":"                notification_id \u003d \"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7b50cc57_1d85c530","line":1473,"in_reply_to":"5475454f_c9aa57c3","updated":"2021-02-19 13:47:30.000000000","message":"GET method is separated from send_notification function. We created get_notification() function.","commit_id":"ff1a372394a83545fb542595606880c031e70d23"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":1546,"context_line":"            return -2"},{"line_number":1547,"context_line":"        return 0"},{"line_number":1548,"context_line":""},{"line_number":1549,"context_line":"    def get_notification(self, context,"},{"line_number":1550,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"dac1aef0_f3327ad3","line":1549,"range":{"start_line":1549,"start_character":8,"end_line":1549,"end_character":24},"updated":"2021-02-26 06:02:26.000000000","message":"I think \u0027test_notification\u0027 is better.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":false,"context_lines":[{"line_number":1546,"context_line":"            return -2"},{"line_number":1547,"context_line":"        return 0"},{"line_number":1548,"context_line":""},{"line_number":1549,"context_line":"    def get_notification(self, context,"},{"line_number":1550,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab42d0d_1df2a927","line":1549,"range":{"start_line":1549,"start_character":8,"end_line":1549,"end_character":24},"in_reply_to":"3ae25513_6d9c8601","updated":"2021-03-11 09:38:56.000000000","message":"I\u0027ve confirmed.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":1546,"context_line":"            return -2"},{"line_number":1547,"context_line":"        return 0"},{"line_number":1548,"context_line":""},{"line_number":1549,"context_line":"    def get_notification(self, context,"},{"line_number":1550,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"3ae25513_6d9c8601","line":1549,"range":{"start_line":1549,"start_character":8,"end_line":1549,"end_character":24},"in_reply_to":"dac1aef0_f3327ad3","updated":"2021-03-04 20:00:19.000000000","message":"\u003e I think \u0027test_notification\u0027 is better.\n\nMethod name \u0027get_notification\u0027 is changed to \u0027test_notification\u0027","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"},{"line_number":1553,"context_line":"            ret \u003d 0"},{"line_number":1554,"context_line":"            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1555,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1556,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"            # Notification shipping"},{"line_number":1559,"context_line":"            for line in vnf_lcm_subscriptions:"},{"line_number":1560,"context_line":"                try:"},{"line_number":1561,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1562,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"eb961fec_0bbf1e21","line":1559,"range":{"start_line":1554,"start_character":12,"end_line":1559,"end_character":46},"updated":"2021-02-26 06:02:26.000000000","message":"Why are you re-storing \u0027vnf_lcm_subscriptions\u0027 in the list \u0027vnf_lcm_subscriptions\u0027 instead of just using them?","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7f41259ec42060e07e44a25d8a56efb11a8a365a","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"},{"line_number":1553,"context_line":"            ret \u003d 0"},{"line_number":1554,"context_line":"            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1555,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1556,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"            # Notification shipping"},{"line_number":1559,"context_line":"            for line in vnf_lcm_subscriptions:"},{"line_number":1560,"context_line":"                try:"},{"line_number":1561,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1562,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"d5c99e0b_bd68de2b","line":1559,"range":{"start_line":1554,"start_character":12,"end_line":1559,"end_character":46},"in_reply_to":"2e7c740e_85d47d21","updated":"2021-03-12 08:00:30.000000000","message":"OK, I understood.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e424605e6d4f6f81b74af2e513c49b84b51b0c09","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"},{"line_number":1553,"context_line":"            ret \u003d 0"},{"line_number":1554,"context_line":"            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1555,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1556,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"            # Notification shipping"},{"line_number":1559,"context_line":"            for line in vnf_lcm_subscriptions:"},{"line_number":1560,"context_line":"                try:"},{"line_number":1561,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1562,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"2e7c740e_85d47d21","line":1559,"range":{"start_line":1554,"start_character":12,"end_line":1559,"end_character":46},"in_reply_to":"ddd88fcc_b3327eaa","updated":"2021-03-11 10:42:30.000000000","message":"\u003e I checked your answers, but I couldn\u0027t understand the reason for restoring to list \u0027vnf_lcm_subscriptions\u0027.\n\u003e \u0027vnf_lcm_subscriptions\u0027 has been removed in Patchset 11, does that mean it wasn\u0027t needed?\n\nBasically, we just explained why we restored the list but basically, we realized that it was not necessary, so we removed it. Sorry to have not explained what we did completely.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"},{"line_number":1553,"context_line":"            ret \u003d 0"},{"line_number":1554,"context_line":"            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1555,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1556,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"            # Notification shipping"},{"line_number":1559,"context_line":"            for line in vnf_lcm_subscriptions:"},{"line_number":1560,"context_line":"                try:"},{"line_number":1561,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1562,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fadae62e_260417c1","line":1559,"range":{"start_line":1554,"start_character":12,"end_line":1559,"end_character":46},"in_reply_to":"eb961fec_0bbf1e21","updated":"2021-03-04 20:00:19.000000000","message":"\u003e Why are you re-storing \u0027vnf_lcm_subscriptions\u0027 in the list \u0027vnf_lcm_subscriptions\u0027 instead of just using them?\n\nRestoring the list vnf_lcm_subscription is used to check if the parameter have value or none.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        try:"},{"line_number":1552,"context_line":"            response_ret \u003d False"},{"line_number":1553,"context_line":"            ret \u003d 0"},{"line_number":1554,"context_line":"            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1555,"context_line":"                vnf_lcm_subscriptions \u003d []"},{"line_number":1556,"context_line":"                vnf_lcm_subscriptions.append(vnf_lcm_subscription)"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"            # Notification shipping"},{"line_number":1559,"context_line":"            for line in vnf_lcm_subscriptions:"},{"line_number":1560,"context_line":"                try:"},{"line_number":1561,"context_line":"                    for num in range(CONF.vnf_lcm.retry_num):"},{"line_number":1562,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ddd88fcc_b3327eaa","line":1559,"range":{"start_line":1554,"start_character":12,"end_line":1559,"end_character":46},"in_reply_to":"fadae62e_260417c1","updated":"2021-03-11 09:38:56.000000000","message":"I checked your answers, but I couldn\u0027t understand the reason for restoring to list \u0027vnf_lcm_subscriptions\u0027.\n\u0027vnf_lcm_subscriptions\u0027 has been removed in Patchset 11, does that mean it wasn\u0027t needed?","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":1562,"context_line":"                        try:"},{"line_number":1563,"context_line":"                            auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1564,"context_line":"                                line.id)"},{"line_number":1565,"context_line":"                            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1566,"context_line":"                                notification \u003d {}"},{"line_number":1567,"context_line":"                                response \u003d auth_client.get("},{"line_number":1568,"context_line":"                                    line.callback_uri,"}],"source_content_type":"text/x-python","patch_set":8,"id":"d4a84490_81058b07","line":1565,"range":{"start_line":1565,"start_character":28,"end_line":1565,"end_character":72},"updated":"2021-02-26 06:02:26.000000000","message":"I think you can describe like \u0027if CONF.vnf_lcm.test_callback_uri\u0027.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"                        try:"},{"line_number":1563,"context_line":"                            auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1564,"context_line":"                                line.id)"},{"line_number":1565,"context_line":"                            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1566,"context_line":"                                notification \u003d {}"},{"line_number":1567,"context_line":"                                response \u003d auth_client.get("},{"line_number":1568,"context_line":"                                    line.callback_uri,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3d603eb7_355bc6f0","line":1565,"range":{"start_line":1565,"start_character":28,"end_line":1565,"end_character":72},"in_reply_to":"c96b3488_21f3c330","updated":"2021-03-11 09:38:56.000000000","message":"I\u0027ve confirmed.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":1562,"context_line":"                        try:"},{"line_number":1563,"context_line":"                            auth_client \u003d auth.auth_manager.get_auth_client("},{"line_number":1564,"context_line":"                                line.id)"},{"line_number":1565,"context_line":"                            if (CONF.vnf_lcm.test_callback_uri is True):"},{"line_number":1566,"context_line":"                                notification \u003d {}"},{"line_number":1567,"context_line":"                                response \u003d auth_client.get("},{"line_number":1568,"context_line":"                                    line.callback_uri,"}],"source_content_type":"text/x-python","patch_set":8,"id":"c96b3488_21f3c330","line":1565,"range":{"start_line":1565,"start_character":28,"end_line":1565,"end_character":72},"in_reply_to":"d4a84490_81058b07","updated":"2021-03-04 20:00:19.000000000","message":"\u003e I think you can describe like \u0027if CONF.vnf_lcm.test_callback_uri\u0027.\n\nChanged the condition description \u0027if (CONF.vnf_lcm.test_callback_uri is True):\u0027 to  \u0027if CONF.vnf_lcm.test_callback_uri:\u0027","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"                                        callback_uri[%s]\" %"},{"line_number":1579,"context_line":"                                    (response.status_code,"},{"line_number":1580,"context_line":"                                    line.callback_uri))"},{"line_number":1581,"context_line":"                                LOG.debug("},{"line_number":1582,"context_line":"                                    \"retry_wait %s\" %"},{"line_number":1583,"context_line":"                                    CONF.vnf_lcm.retry_wait)"},{"line_number":1584,"context_line":"                                time.sleep(CONF.vnf_lcm.retry_wait)"},{"line_number":1585,"context_line":"                                if num \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1586,"context_line":"                                    LOG.warn(\"Number of retries \\"},{"line_number":1587,"context_line":"                                        exceeded retry count\")"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"                                continue"},{"line_number":1590,"context_line":"                        except requests.Timeout as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"f2b93bc7_3a40ba8b","line":1587,"range":{"start_line":1581,"start_character":32,"end_line":1587,"end_character":62},"updated":"2021-02-26 06:02:26.000000000","message":"The same logic exists in L1596.\nIs it possible to cut out to a sub-method as a common logic?","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"                                        callback_uri[%s]\" %"},{"line_number":1579,"context_line":"                                    (response.status_code,"},{"line_number":1580,"context_line":"                                    line.callback_uri))"},{"line_number":1581,"context_line":"                                LOG.debug("},{"line_number":1582,"context_line":"                                    \"retry_wait %s\" %"},{"line_number":1583,"context_line":"                                    CONF.vnf_lcm.retry_wait)"},{"line_number":1584,"context_line":"                                time.sleep(CONF.vnf_lcm.retry_wait)"},{"line_number":1585,"context_line":"                                if num \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1586,"context_line":"                                    LOG.warn(\"Number of retries \\"},{"line_number":1587,"context_line":"                                        exceeded retry count\")"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"                                continue"},{"line_number":1590,"context_line":"                        except requests.Timeout as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"d4fd45ea_eb1d1792","line":1587,"range":{"start_line":1581,"start_character":32,"end_line":1587,"end_character":62},"in_reply_to":"e5cdf786_73cd2985","updated":"2021-03-11 09:38:56.000000000","message":"I\u0027ve confirmed.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"                                        callback_uri[%s]\" %"},{"line_number":1579,"context_line":"                                    (response.status_code,"},{"line_number":1580,"context_line":"                                    line.callback_uri))"},{"line_number":1581,"context_line":"                                LOG.debug("},{"line_number":1582,"context_line":"                                    \"retry_wait %s\" %"},{"line_number":1583,"context_line":"                                    CONF.vnf_lcm.retry_wait)"},{"line_number":1584,"context_line":"                                time.sleep(CONF.vnf_lcm.retry_wait)"},{"line_number":1585,"context_line":"                                if num \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1586,"context_line":"                                    LOG.warn(\"Number of retries \\"},{"line_number":1587,"context_line":"                                        exceeded retry count\")"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"                                continue"},{"line_number":1590,"context_line":"                        except requests.Timeout as e:"}],"source_content_type":"text/x-python","patch_set":8,"id":"e5cdf786_73cd2985","line":1587,"range":{"start_line":1581,"start_character":32,"end_line":1587,"end_character":62},"in_reply_to":"f2b93bc7_3a40ba8b","updated":"2021-03-04 20:00:19.000000000","message":"\u003e The same logic exists in L1596.\n\u003e Is it possible to cut out to a sub-method as a common logic?\n\nMade sub-method name \u0027retry_check(self, retry_count)\u0027","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bfab3b50eab2a923d51f25a28adfc1feb8f5634f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import inspect"},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import oslo_messaging"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import shutil"},{"line_number":24,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":11,"id":"eab6f8c4_c97bd4ae","line":21,"updated":"2021-03-15 17:23:40.000000000","message":"Why don\u0027t you move this line to L.31 as one of the `oslo` packages.","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"0864238fdb6d12bee65893d618040cb42fa4c2c2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import inspect"},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import oslo_messaging"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import shutil"},{"line_number":24,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":11,"id":"e5fb460a_a48e784d","line":21,"in_reply_to":"dbb4db09_a283d92d","updated":"2021-03-26 05:04:11.000000000","message":"Done","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"3fa6e854f74b9124b4a9ac242515b81669a54a99","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import inspect"},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import oslo_messaging"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":"import shutil"},{"line_number":24,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":11,"id":"dbb4db09_a283d92d","line":21,"in_reply_to":"eab6f8c4_c97bd4ae","updated":"2021-03-17 04:47:45.000000000","message":"\u003e Why don\u0027t you move this line to L.31 as one of the `oslo` packages.\n\nmoved Line21 to Line31","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bfab3b50eab2a923d51f25a28adfc1feb8f5634f","unresolved":true,"context_lines":[{"line_number":1549,"context_line":"    def _retry_check(self, retry_count):"},{"line_number":1550,"context_line":"        time.sleep(CONF.vnf_lcm.retry_wait)"},{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9e544665_d7abe163","line":1552,"updated":"2021-03-15 17:23:40.000000000","message":"It\u0027s better to show `CONF.vnf_lcm.retry_num` as the retry count in the log message.","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"0864238fdb6d12bee65893d618040cb42fa4c2c2","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"    def _retry_check(self, retry_count):"},{"line_number":1550,"context_line":"        time.sleep(CONF.vnf_lcm.retry_wait)"},{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"5aa0d592_7c8a8aac","line":1552,"in_reply_to":"40d80a79_5b43887f","updated":"2021-03-26 05:04:11.000000000","message":"Done","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"3fa6e854f74b9124b4a9ac242515b81669a54a99","unresolved":true,"context_lines":[{"line_number":1549,"context_line":"    def _retry_check(self, retry_count):"},{"line_number":1550,"context_line":"        time.sleep(CONF.vnf_lcm.retry_wait)"},{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"40d80a79_5b43887f","line":1552,"in_reply_to":"9e544665_d7abe163","updated":"2021-03-17 04:47:45.000000000","message":"\u003e It\u0027s better to show `CONF.vnf_lcm.retry_num` as the retry count in the log message.\n\nadded \u0027CONF.vnf_lcm.retry_num\u0027 as retry count in the log message","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bfab3b50eab2a923d51f25a28adfc1feb8f5634f","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1556,"context_line":"        response_ret \u003d False"},{"line_number":1557,"context_line":"        ret \u003d 0"}],"source_content_type":"text/x-python","patch_set":11,"id":"0a7dcf59_ea674da1","line":1554,"updated":"2021-03-15 17:23:40.000000000","message":"Could you add a description for the function, especially for the returned value because it is something tricky for the returned value. What is returned, boolean or int? or what is the condition for decision for the returned value?","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"3fa6e854f74b9124b4a9ac242515b81669a54a99","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1556,"context_line":"        response_ret \u003d False"},{"line_number":1557,"context_line":"        ret \u003d 0"}],"source_content_type":"text/x-python","patch_set":11,"id":"4342ad01_a260de63","line":1554,"in_reply_to":"0a7dcf59_ea674da1","updated":"2021-03-17 04:47:45.000000000","message":"\u003e Could you add a description for the function, especially for the returned value because it is something tricky for the returned value. What is returned, boolean or int? or what is the condition for decision for the returned value?\n\nadded description about the functionality and its returned value","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"0864238fdb6d12bee65893d618040cb42fa4c2c2","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1556,"context_line":"        response_ret \u003d False"},{"line_number":1557,"context_line":"        ret \u003d 0"}],"source_content_type":"text/x-python","patch_set":11,"id":"e957ea16_c998c89a","line":1554,"in_reply_to":"4342ad01_a260de63","updated":"2021-03-26 05:04:11.000000000","message":"Done","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bfab3b50eab2a923d51f25a28adfc1feb8f5634f","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1556,"context_line":"        response_ret \u003d False"},{"line_number":1557,"context_line":"        ret \u003d 0"},{"line_number":1558,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"e0688d0a_c6d759c4","line":1555,"range":{"start_line":1554,"start_character":0,"end_line":1555,"end_character":39},"updated":"2021-03-15 17:23:40.000000000","message":"No need to separate into two lines.","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"0864238fdb6d12bee65893d618040cb42fa4c2c2","unresolved":false,"context_lines":[{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1556,"context_line":"        response_ret \u003d False"},{"line_number":1557,"context_line":"        ret \u003d 0"},{"line_number":1558,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"c2f49d45_24a20f54","line":1555,"range":{"start_line":1554,"start_character":0,"end_line":1555,"end_character":39},"in_reply_to":"a6eb708d_9da5c22a","updated":"2021-03-26 05:04:11.000000000","message":"Done","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"3fa6e854f74b9124b4a9ac242515b81669a54a99","unresolved":true,"context_lines":[{"line_number":1551,"context_line":"        if retry_count \u003d\u003d CONF.vnf_lcm.retry_num:"},{"line_number":1552,"context_line":"            LOG.warn(\"Number of retries exceeded retry count\")"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    def test_notification(self, context,"},{"line_number":1555,"context_line":"            vnf_lcm_subscription\u003dNone):"},{"line_number":1556,"context_line":"        response_ret \u003d False"},{"line_number":1557,"context_line":"        ret \u003d 0"},{"line_number":1558,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"a6eb708d_9da5c22a","line":1555,"range":{"start_line":1554,"start_character":0,"end_line":1555,"end_character":39},"in_reply_to":"e0688d0a_c6d759c4","updated":"2021-03-17 04:47:45.000000000","message":"\u003e No need to separate into two lines.\n\nchanged into one line","commit_id":"143b44ad6f8511789c935e2b1ba49d132c537edc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"21a31c0807bb528d4b9732725d58d7f86995a55a","unresolved":true,"context_lines":[{"line_number":1577,"context_line":"                        vnf_lcm_subscription.callback_uri,"},{"line_number":1578,"context_line":"                        data\u003djson.dumps(notification),"},{"line_number":1579,"context_line":"                        timeout\u003dCONF.vnf_lcm.retry_timeout)"},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"                if response.status_code \u003d\u003d 204:"},{"line_number":1582,"context_line":"                    response_ret \u003d True"},{"line_number":1583,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":12,"id":"e4bd5339_ac4d642d","line":1580,"updated":"2021-03-18 01:18:54.000000000","message":"This code raises exception if CONF.vnf_lcm.test_callback_uri is False. (at L.1581 because response does not exist.)\nCONF.vnf_lcm.test_callback_uri shoud be checked at the top of this method.","commit_id":"9c856b1580fe19e970ddd4918ab0b8d8df7b0204"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ba78c6e32a3666f8429565ee82b9c0936a700bdc","unresolved":true,"context_lines":[{"line_number":1577,"context_line":"                        vnf_lcm_subscription.callback_uri,"},{"line_number":1578,"context_line":"                        data\u003djson.dumps(notification),"},{"line_number":1579,"context_line":"                        timeout\u003dCONF.vnf_lcm.retry_timeout)"},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"                if response.status_code \u003d\u003d 204:"},{"line_number":1582,"context_line":"                    response_ret \u003d True"},{"line_number":1583,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":12,"id":"11f19f3b_678aa0b9","line":1580,"in_reply_to":"e4bd5339_ac4d642d","updated":"2021-03-23 03:14:14.000000000","message":"\u003e This code raises exception if CONF.vnf_lcm.test_callback_uri is False. (at L.1581 because response does not exist.)\n\u003e CONF.vnf_lcm.test_callback_uri shoud be checked at the top of this method.\n\nIf condition is transferred outside of loop. Added corresponding else statement.","commit_id":"9c856b1580fe19e970ddd4918ab0b8d8df7b0204"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fddf45aab3c92a0cf968dba529943075565cb55c","unresolved":true,"context_lines":[{"line_number":1566,"context_line":"           :returns: 0 if status code of the response is 204,"},{"line_number":1567,"context_line":"                    -1 if status code of the response is not 204"},{"line_number":1568,"context_line":"        \"\"\""},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        response_ret \u003d False"},{"line_number":1571,"context_line":"        ret \u003d 0"},{"line_number":1572,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9c03e30a_e8c44f6c","line":1569,"updated":"2021-03-23 04:22:59.000000000","message":"It is better to return soon if CONF... does not exist. as follows.\n---\nif not CONF.vnf_lcm.test_callback_uri:\n    LOG.warning(...)\n    retuen 0\n---\nShould not deepen the indent of the main route.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5971acca77c8dbea0cb5ddba4228416827ae8264","unresolved":true,"context_lines":[{"line_number":1566,"context_line":"           :returns: 0 if status code of the response is 204,"},{"line_number":1567,"context_line":"                    -1 if status code of the response is not 204"},{"line_number":1568,"context_line":"        \"\"\""},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        response_ret \u003d False"},{"line_number":1571,"context_line":"        ret \u003d 0"},{"line_number":1572,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5e4ffd28_24a1c178","line":1569,"in_reply_to":"9c03e30a_e8c44f6c","updated":"2021-03-24 04:08:49.000000000","message":"\u003e It is better to return soon if CONF... does not exist. as follows.\n\u003e ---\n\u003e if not CONF.vnf_lcm.test_callback_uri:\n\u003e     LOG.warning(...)\n\u003e     retuen 0\n\u003e ---\n\u003e Should not deepen the indent of the main route.\n\nChanged the condition to \"if not CONF.vnf_lcm.test_callback_uri\" and adjusted the indention.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fddf45aab3c92a0cf968dba529943075565cb55c","unresolved":true,"context_lines":[{"line_number":1568,"context_line":"        \"\"\""},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        response_ret \u003d False"},{"line_number":1571,"context_line":"        ret \u003d 0"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"        # Notification shipping"},{"line_number":1574,"context_line":"        if CONF.vnf_lcm.test_callback_uri:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7d8243b4_eb330eb5","line":1571,"updated":"2021-03-23 04:22:59.000000000","message":"response_ret and ret are not necessary. See L.1589 and L.1616.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5971acca77c8dbea0cb5ddba4228416827ae8264","unresolved":true,"context_lines":[{"line_number":1568,"context_line":"        \"\"\""},{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        response_ret \u003d False"},{"line_number":1571,"context_line":"        ret \u003d 0"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"        # Notification shipping"},{"line_number":1574,"context_line":"        if CONF.vnf_lcm.test_callback_uri:"}],"source_content_type":"text/x-python","patch_set":14,"id":"b4bf8380_6d3b45ff","line":1571,"in_reply_to":"7d8243b4_eb330eb5","updated":"2021-03-24 04:08:49.000000000","message":"\u003e response_ret and ret are not necessary. See L.1589 and L.1616.\n\nRemoved response_ret and ret.  Code will return 0 or -1 instead of assigning value to response_ret","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fddf45aab3c92a0cf968dba529943075565cb55c","unresolved":true,"context_lines":[{"line_number":1586,"context_line":""},{"line_number":1587,"context_line":"                    if response.status_code \u003d\u003d 204:"},{"line_number":1588,"context_line":"                        response_ret \u003d True"},{"line_number":1589,"context_line":"                        break"},{"line_number":1590,"context_line":"                    else:"},{"line_number":1591,"context_line":"                        LOG.warning("},{"line_number":1592,"context_line":"                            \"Notification failed status[%s] \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"f33f2ea2_5174f06c","line":1589,"updated":"2021-03-23 04:22:59.000000000","message":"L.1588-1589:\nreturn -1","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5971acca77c8dbea0cb5ddba4228416827ae8264","unresolved":true,"context_lines":[{"line_number":1586,"context_line":""},{"line_number":1587,"context_line":"                    if response.status_code \u003d\u003d 204:"},{"line_number":1588,"context_line":"                        response_ret \u003d True"},{"line_number":1589,"context_line":"                        break"},{"line_number":1590,"context_line":"                    else:"},{"line_number":1591,"context_line":"                        LOG.warning("},{"line_number":1592,"context_line":"                            \"Notification failed status[%s] \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"b6d0e9fc_94cd3558","line":1589,"in_reply_to":"4804cfbd_141c34bc","updated":"2021-03-24 04:08:49.000000000","message":"\u003e Sorry,\n\u003e ---\n\u003e return 0\n\u003e ---\n\u003e is correct.\n\nNo modification done.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2dc1afb3422c82cfc5acaf2c4e06d8361530b6b8","unresolved":true,"context_lines":[{"line_number":1586,"context_line":""},{"line_number":1587,"context_line":"                    if response.status_code \u003d\u003d 204:"},{"line_number":1588,"context_line":"                        response_ret \u003d True"},{"line_number":1589,"context_line":"                        break"},{"line_number":1590,"context_line":"                    else:"},{"line_number":1591,"context_line":"                        LOG.warning("},{"line_number":1592,"context_line":"                            \"Notification failed status[%s] \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"4804cfbd_141c34bc","line":1589,"in_reply_to":"f33f2ea2_5174f06c","updated":"2021-03-23 04:30:46.000000000","message":"Sorry,\n---\nreturn 0\n---\nis correct.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fddf45aab3c92a0cf968dba529943075565cb55c","unresolved":true,"context_lines":[{"line_number":1606,"context_line":"                            \"uri\": vnf_lcm_subscription.callback_uri,"},{"line_number":1607,"context_line":"                            \"reason\": str(e)})"},{"line_number":1608,"context_line":"                    self._retry_check(num)"},{"line_number":1609,"context_line":"        else:"},{"line_number":1610,"context_line":"            LOG.warning(\"Callback URI is %s\", CONF.vnf_lcm.test_callback_uri)"},{"line_number":1611,"context_line":"            response_ret \u003d True"},{"line_number":1612,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bd850740_d84de55c","line":1609,"updated":"2021-03-23 04:22:59.000000000","message":"See L.1569 comment.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5971acca77c8dbea0cb5ddba4228416827ae8264","unresolved":true,"context_lines":[{"line_number":1606,"context_line":"                            \"uri\": vnf_lcm_subscription.callback_uri,"},{"line_number":1607,"context_line":"                            \"reason\": str(e)})"},{"line_number":1608,"context_line":"                    self._retry_check(num)"},{"line_number":1609,"context_line":"        else:"},{"line_number":1610,"context_line":"            LOG.warning(\"Callback URI is %s\", CONF.vnf_lcm.test_callback_uri)"},{"line_number":1611,"context_line":"            response_ret \u003d True"},{"line_number":1612,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"4c00d853_a62f50b2","line":1609,"in_reply_to":"bd850740_d84de55c","updated":"2021-03-24 04:08:49.000000000","message":"\u003e See L.1569 comment.\n\nChanged the condition to \"if not CONF.vnf_lcm.test_callback_uri\" and adjusted the indention.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"fddf45aab3c92a0cf968dba529943075565cb55c","unresolved":true,"context_lines":[{"line_number":1613,"context_line":"        # checks if the response returns 204"},{"line_number":1614,"context_line":"        if response_ret is False:"},{"line_number":1615,"context_line":"            ret \u003d -1"},{"line_number":1616,"context_line":"        return ret"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"    @coordination.synchronized(\u0027{vnf_instance[id]}\u0027)"},{"line_number":1619,"context_line":"    def instantiate("}],"source_content_type":"text/x-python","patch_set":14,"id":"8c7c2d87_4da5433a","line":1616,"updated":"2021-03-23 04:22:59.000000000","message":"L.1614-1616\nreturn 0","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2dc1afb3422c82cfc5acaf2c4e06d8361530b6b8","unresolved":true,"context_lines":[{"line_number":1613,"context_line":"        # checks if the response returns 204"},{"line_number":1614,"context_line":"        if response_ret is False:"},{"line_number":1615,"context_line":"            ret \u003d -1"},{"line_number":1616,"context_line":"        return ret"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"    @coordination.synchronized(\u0027{vnf_instance[id]}\u0027)"},{"line_number":1619,"context_line":"    def instantiate("}],"source_content_type":"text/x-python","patch_set":14,"id":"eb910c29_d18807d5","line":1616,"in_reply_to":"8c7c2d87_4da5433a","updated":"2021-03-23 04:30:46.000000000","message":"Sorry,\n---\nreturn -1\n---\nis correct.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5971acca77c8dbea0cb5ddba4228416827ae8264","unresolved":true,"context_lines":[{"line_number":1613,"context_line":"        # checks if the response returns 204"},{"line_number":1614,"context_line":"        if response_ret is False:"},{"line_number":1615,"context_line":"            ret \u003d -1"},{"line_number":1616,"context_line":"        return ret"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"    @coordination.synchronized(\u0027{vnf_instance[id]}\u0027)"},{"line_number":1619,"context_line":"    def instantiate("}],"source_content_type":"text/x-python","patch_set":14,"id":"a93f31dd_d6e58b5b","line":1616,"in_reply_to":"eb910c29_d18807d5","updated":"2021-03-24 04:08:49.000000000","message":"\u003e Sorry,\n\u003e ---\n\u003e return -1\n\u003e ---\n\u003e is correct.\n\nNo modification done.","commit_id":"70bf3b9b28c69f1bb8062379bb1f25d7425a1c97"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d0cfd6ac4a09695f4bdd1f13ae2ac9d279940851","unresolved":true,"context_lines":[{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        if not CONF.vnf_lcm.test_callback_uri:"},{"line_number":1571,"context_line":"            LOG.warning(\"Callback URI is %s\", CONF.vnf_lcm.test_callback_uri)"},{"line_number":1572,"context_line":"            return 0"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"        # Notification shipping"},{"line_number":1575,"context_line":"        for num in range(CONF.vnf_lcm.retry_num):"}],"source_content_type":"text/x-python","patch_set":16,"id":"89f87fe0_89fe19a6","line":1572,"updated":"2021-03-25 08:45:10.000000000","message":"It is important that return 0 is obtained even in this pattern, so please add it to the docstring.","commit_id":"664742a8bf5f861529ae737b91b99f1e746eaf90"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d0e2034f4c6b3ba1eec055422418d7d1348818a8","unresolved":false,"context_lines":[{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        if not CONF.vnf_lcm.test_callback_uri:"},{"line_number":1571,"context_line":"            LOG.warning(\"Callback URI is %s\", CONF.vnf_lcm.test_callback_uri)"},{"line_number":1572,"context_line":"            return 0"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"        # Notification shipping"},{"line_number":1575,"context_line":"        for num in range(CONF.vnf_lcm.retry_num):"}],"source_content_type":"text/x-python","patch_set":16,"id":"46c0dae5_d03df09c","line":1572,"in_reply_to":"6590e869_2cfc9382","updated":"2021-03-26 01:58:52.000000000","message":"Done","commit_id":"664742a8bf5f861529ae737b91b99f1e746eaf90"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7f866a05c21e3a43a8b27d37bb1b4b47d102d2e7","unresolved":true,"context_lines":[{"line_number":1569,"context_line":""},{"line_number":1570,"context_line":"        if not CONF.vnf_lcm.test_callback_uri:"},{"line_number":1571,"context_line":"            LOG.warning(\"Callback URI is %s\", CONF.vnf_lcm.test_callback_uri)"},{"line_number":1572,"context_line":"            return 0"},{"line_number":1573,"context_line":""},{"line_number":1574,"context_line":"        # Notification shipping"},{"line_number":1575,"context_line":"        for num in range(CONF.vnf_lcm.retry_num):"}],"source_content_type":"text/x-python","patch_set":16,"id":"6590e869_2cfc9382","line":1572,"in_reply_to":"89f87fe0_89fe19a6","updated":"2021-03-25 11:35:10.000000000","message":"\u003e It is important that return 0 is obtained even in this pattern, so please add it to the docstring.\n\nadded to docstring.","commit_id":"664742a8bf5f861529ae737b91b99f1e746eaf90"}],"tacker/conductor/conductorrpc/vnf_lcm_rpc.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        return rpc_method(context, \u0027send_notification\u0027,"},{"line_number":114,"context_line":"                          notification\u003dnotification)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def get_notification(self, context,"},{"line_number":117,"context_line":"            vnf_lcm_subscription\u003dNone, cast\u003dFalse):"},{"line_number":118,"context_line":"        serializer \u003d objects_base.TackerObjectSerializer()"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"18bb5fea_54c248a8","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":24},"updated":"2021-02-26 06:02:26.000000000","message":"I think \u0027test_notification\u0027 is better.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":113,"context_line":"        return rpc_method(context, \u0027send_notification\u0027,"},{"line_number":114,"context_line":"                          notification\u003dnotification)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def get_notification(self, context,"},{"line_number":117,"context_line":"            vnf_lcm_subscription\u003dNone, cast\u003dFalse):"},{"line_number":118,"context_line":"        serializer \u003d objects_base.TackerObjectSerializer()"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"a14c7d47_145d3b8b","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":24},"in_reply_to":"18bb5fea_54c248a8","updated":"2021-03-04 20:00:19.000000000","message":"\u003e I think \u0027test_notification\u0027 is better.\n\nMethod name \u0027get_notification\u0027 is changed to \u0027test_notification\u0027","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        return rpc_method(context, \u0027send_notification\u0027,"},{"line_number":114,"context_line":"                          notification\u003dnotification)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def get_notification(self, context,"},{"line_number":117,"context_line":"            vnf_lcm_subscription\u003dNone, cast\u003dFalse):"},{"line_number":118,"context_line":"        serializer \u003d objects_base.TackerObjectSerializer()"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"769afead_13e81b40","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":24},"in_reply_to":"a14c7d47_145d3b8b","updated":"2021-03-11 09:38:56.000000000","message":"I\u0027ve confirmed.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"}],"tacker/conf/vnf_lcm.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        default\u003d10,"},{"line_number":34,"context_line":"        help\u003d\"Retry interval(sec)\"),"},{"line_number":35,"context_line":"    cfg.BoolOpt("},{"line_number":36,"context_line":"        \u0027test_callbackUri\u0027,"},{"line_number":37,"context_line":"        default\u003dTrue,"},{"line_number":38,"context_line":"        help\u003d\"Test callbackUri\")]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"484f5165_4f64a0b0","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":25},"updated":"2021-01-26 02:36:34.000000000","message":"Why don’t you use \"snake_case\"?","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        default\u003d10,"},{"line_number":34,"context_line":"        help\u003d\"Retry interval(sec)\"),"},{"line_number":35,"context_line":"    cfg.BoolOpt("},{"line_number":36,"context_line":"        \u0027test_callbackUri\u0027,"},{"line_number":37,"context_line":"        default\u003dTrue,"},{"line_number":38,"context_line":"        help\u003d\"Test callbackUri\")]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"45bf318e_b0a5c9ca","line":36,"range":{"start_line":36,"start_character":14,"end_line":36,"end_character":25},"in_reply_to":"484f5165_4f64a0b0","updated":"2021-02-01 17:16:21.000000000","message":"changed to snake_case.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"2eeeedd1c9a6b9a72e77a6478fcc2645275af01a","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        help\u003d\"Retry interval(sec)\"),"},{"line_number":35,"context_line":"    cfg.IntOpt("},{"line_number":36,"context_line":"        \u0027retry_timeout\u0027,"},{"line_number":37,"context_line":"        default\u003d60,"},{"line_number":38,"context_line":"        help\u003d\"Retry Timeout(sec)\"),"},{"line_number":39,"context_line":"    cfg.BoolOpt("},{"line_number":40,"context_line":"        \u0027test_callback_uri\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"8de00bca_cbf369de","line":37,"updated":"2021-03-04 05:41:40.000000000","message":"I think the default value of retry_timeout should be shorter (e.g. 10 seconds), because retry_timeout is a timer for detecting unreachable API, but it cannot expect an endpoint to recover even if the Tacker waits for 60 seconds.","commit_id":"fad679578d60eb484d3718340173c8ce6628b0ee"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"1c834029fa5c8990992e8a30c6c76e06e7e9d718","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        help\u003d\"Retry interval(sec)\"),"},{"line_number":35,"context_line":"    cfg.IntOpt("},{"line_number":36,"context_line":"        \u0027retry_timeout\u0027,"},{"line_number":37,"context_line":"        default\u003d60,"},{"line_number":38,"context_line":"        help\u003d\"Retry Timeout(sec)\"),"},{"line_number":39,"context_line":"    cfg.BoolOpt("},{"line_number":40,"context_line":"        \u0027test_callback_uri\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"c162b9c2_b68c5e4e","line":37,"in_reply_to":"8de00bca_cbf369de","updated":"2021-03-09 06:59:47.000000000","message":"\u003e I think the default value of retry_timeout should be shorter (e.g. 10 seconds), because retry_timeout is a timer for detecting unreachable API, but it cannot expect an endpoint to recover even if the Tacker waits for 60 seconds.\n\nchanged the default value of retry_timeout to 10","commit_id":"fad679578d60eb484d3718340173c8ce6628b0ee"},{"author":{"_account_id":32826,"name":"Yuichi Ishihara","email":"yuichi.ishihara.dx@hco.ntt.co.jp","username":"yishihara"},"change_message_id":"58dd5fb10bcf3fa645ebd71fd447c7ebf3f71a64","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        help\u003d\"Retry interval(sec)\"),"},{"line_number":35,"context_line":"    cfg.IntOpt("},{"line_number":36,"context_line":"        \u0027retry_timeout\u0027,"},{"line_number":37,"context_line":"        default\u003d60,"},{"line_number":38,"context_line":"        help\u003d\"Retry Timeout(sec)\"),"},{"line_number":39,"context_line":"    cfg.BoolOpt("},{"line_number":40,"context_line":"        \u0027test_callback_uri\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"45283229_5ced8ef8","line":37,"in_reply_to":"c162b9c2_b68c5e4e","updated":"2021-03-09 12:35:46.000000000","message":"I\u0027ve confirmed.","commit_id":"fad679578d60eb484d3718340173c8ce6628b0ee"}],"tacker/tests/functional/sol/vnflcm/base.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0ead02e87ccf290983eb47d585569149d20819f1","unresolved":true,"context_lines":[{"line_number":1006,"context_line":"            callback_url)"},{"line_number":1007,"context_line":"        FAKE_SERVER_MANAGER.clear_history("},{"line_number":1008,"context_line":"            callback_url)"},{"line_number":1009,"context_line":"        self.assertEqual(1, len(notify_mock_responses))"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"    def assert_notification_mock_response("},{"line_number":1012,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":8,"id":"788011ad_3d17171b","line":1009,"updated":"2021-02-26 06:02:26.000000000","message":"I think it\u0027s better to assert that status_code is 204.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b51208688e68d29523c53e9d67a02e82ed50efe7","unresolved":false,"context_lines":[{"line_number":1006,"context_line":"            callback_url)"},{"line_number":1007,"context_line":"        FAKE_SERVER_MANAGER.clear_history("},{"line_number":1008,"context_line":"            callback_url)"},{"line_number":1009,"context_line":"        self.assertEqual(1, len(notify_mock_responses))"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"    def assert_notification_mock_response("},{"line_number":1012,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":8,"id":"653a0209_39c87862","line":1009,"in_reply_to":"5cde7923_f66ca1f2","updated":"2021-03-11 09:38:56.000000000","message":"I\u0027ve confirmed.","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"28fd3f6698f0dbd6eb5912f071e2ca4b3db53321","unresolved":true,"context_lines":[{"line_number":1006,"context_line":"            callback_url)"},{"line_number":1007,"context_line":"        FAKE_SERVER_MANAGER.clear_history("},{"line_number":1008,"context_line":"            callback_url)"},{"line_number":1009,"context_line":"        self.assertEqual(1, len(notify_mock_responses))"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"    def assert_notification_mock_response("},{"line_number":1012,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5cde7923_f66ca1f2","line":1009,"in_reply_to":"788011ad_3d17171b","updated":"2021-03-04 20:00:19.000000000","message":"\u003e I think it\u0027s better to assert that status_code is 204.\n\nAsserted the status code \u003d 204","commit_id":"ce9f07a7b7d93b2ec9de965dd8cd26f4db22e0b4"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":2467,"context_line":"        self.assertEqual(result, -2)"},{"line_number":2468,"context_line":"        mock_subscriptions_get.assert_called()"},{"line_number":2469,"context_line":""},{"line_number":2470,"context_line":"    def test_send_notification_notifyGet(self):"},{"line_number":2471,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, True,"},{"line_number":2472,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2473,"context_line":"        self.requests_mock.register_uri(\u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"798d5d0b_3c73ad7b","line":2470,"range":{"start_line":2470,"start_character":31,"end_line":2470,"end_character":40},"updated":"2021-01-26 02:36:34.000000000","message":"Why don’t you use \"snake_case\"?","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":2467,"context_line":"        self.assertEqual(result, -2)"},{"line_number":2468,"context_line":"        mock_subscriptions_get.assert_called()"},{"line_number":2469,"context_line":""},{"line_number":2470,"context_line":"    def test_send_notification_notifyGet(self):"},{"line_number":2471,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, True,"},{"line_number":2472,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2473,"context_line":"        self.requests_mock.register_uri(\u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"36587612_ff8ddaa6","line":2470,"range":{"start_line":2470,"start_character":31,"end_line":2470,"end_character":40},"in_reply_to":"798d5d0b_3c73ad7b","updated":"2021-02-01 17:16:21.000000000","message":"changed to snake_case.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":2497,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, False,"},{"line_number":2498,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2499,"context_line":""},{"line_number":2500,"context_line":"    def test_send_notification_notifyGet_retry(self):"},{"line_number":2501,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, True,"},{"line_number":2502,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2503,"context_line":"        self.requests_mock.register_uri(\u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5374b093_adff0bde","line":2500,"range":{"start_line":2500,"start_character":31,"end_line":2500,"end_character":40},"updated":"2021-01-26 02:36:34.000000000","message":"ditto","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":2497,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, False,"},{"line_number":2498,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2499,"context_line":""},{"line_number":2500,"context_line":"    def test_send_notification_notifyGet_retry(self):"},{"line_number":2501,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, True,"},{"line_number":2502,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2503,"context_line":"        self.requests_mock.register_uri(\u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"761433f2_35c1643a","line":2500,"range":{"start_line":2500,"start_character":31,"end_line":2500,"end_character":40},"in_reply_to":"5374b093_adff0bde","updated":"2021-02-01 17:16:21.000000000","message":"changed to snake_case.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"85ca5b37654b315979495b0d06d965d0ebe16916","unresolved":true,"context_lines":[{"line_number":2527,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, False,"},{"line_number":2528,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2529,"context_line":""},{"line_number":2530,"context_line":"    def test_sendNotification_notifyGet_sendError(self):"},{"line_number":2531,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, True,"},{"line_number":2532,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2533,"context_line":"        self.requests_mock.register_uri("}],"source_content_type":"text/x-python","patch_set":3,"id":"6d7182b8_c6dee377","line":2530,"range":{"start_line":2530,"start_character":13,"end_line":2530,"end_character":49},"updated":"2021-01-26 02:36:34.000000000","message":"ditto","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"99fa2349113c9a317765621a38259c130636b027","unresolved":true,"context_lines":[{"line_number":2527,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, False,"},{"line_number":2528,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2529,"context_line":""},{"line_number":2530,"context_line":"    def test_sendNotification_notifyGet_sendError(self):"},{"line_number":2531,"context_line":"        cfg.CONF.set_override(\u0027test_callbackUri\u0027, True,"},{"line_number":2532,"context_line":"                              group\u003d\u0027vnf_lcm\u0027)"},{"line_number":2533,"context_line":"        self.requests_mock.register_uri("}],"source_content_type":"text/x-python","patch_set":3,"id":"ae291c8e_a2ee24eb","line":2530,"range":{"start_line":2530,"start_character":13,"end_line":2530,"end_character":49},"in_reply_to":"6d7182b8_c6dee377","updated":"2021-02-01 17:16:21.000000000","message":"changed to snake_case.","commit_id":"dd8f9d0fb599847514ae588ee693b2f567e4619d"}]}