)]}'
{"api-ref/source/v1/parameters_vnflcm.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c74eb67fcfee375c3090ed9aa15107931599ed3a","unresolved":true,"context_lines":[{"line_number":650,"context_line":"    Select one of the following,"},{"line_number":651,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":652,"context_line":"  in: body"},{"line_number":653,"context_line":"  required: true"},{"line_number":654,"context_line":"  type: array"},{"line_number":655,"context_line":"flavour_id:"},{"line_number":656,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"cdc98fd0_74a06ef9","line":653,"range":{"start_line":653,"start_character":2,"end_line":653,"end_character":16},"updated":"2021-03-23 02:53:03.000000000","message":"By definition of SOL003 v2.6.1, I think \u0027required: false\u0027 is correct.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f703765f6365c8b3d8b949776b77fd2065c7aaa9","unresolved":true,"context_lines":[{"line_number":650,"context_line":"    Select one of the following,"},{"line_number":651,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":652,"context_line":"  in: body"},{"line_number":653,"context_line":"  required: true"},{"line_number":654,"context_line":"  type: array"},{"line_number":655,"context_line":"flavour_id:"},{"line_number":656,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a8dcd8f_d76e3f75","line":653,"range":{"start_line":653,"start_character":2,"end_line":653,"end_character":16},"in_reply_to":"01453904_78593638","updated":"2021-03-23 07:31:35.000000000","message":"I thought it would be better to change it to \u0027required: false\u0027and add the following to the description that you explained.\nWhat do you think?\n---\nExactly one of \"fixedAddresses\", \"numDynamicAddresses\" or \"ipAddressRange\" shall be present.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e12861e52b279f44e015e6d6bc4f651f28b69062","unresolved":false,"context_lines":[{"line_number":650,"context_line":"    Select one of the following,"},{"line_number":651,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":652,"context_line":"  in: body"},{"line_number":653,"context_line":"  required: true"},{"line_number":654,"context_line":"  type: array"},{"line_number":655,"context_line":"flavour_id:"},{"line_number":656,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0c2ad5d0_be653071","line":653,"range":{"start_line":653,"start_character":2,"end_line":653,"end_character":16},"in_reply_to":"37026816_0ccafff8","updated":"2021-03-24 08:06:36.000000000","message":"I\u0027ve confirmed.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"cd742d03ce9fa5ab172bf662f8cedaaf8db5a106","unresolved":true,"context_lines":[{"line_number":650,"context_line":"    Select one of the following,"},{"line_number":651,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":652,"context_line":"  in: body"},{"line_number":653,"context_line":"  required: true"},{"line_number":654,"context_line":"  type: array"},{"line_number":655,"context_line":"flavour_id:"},{"line_number":656,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"f57919ce_759171ea","line":653,"range":{"start_line":653,"start_character":2,"end_line":653,"end_character":16},"in_reply_to":"3a8dcd8f_d76e3f75","updated":"2021-03-24 03:30:36.000000000","message":"Thanks for the suggestion.\nI agree with your suggestion and fixed document.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"5b3760f1f33e4209cb67ca5a372bf2aea7b45896","unresolved":true,"context_lines":[{"line_number":650,"context_line":"    Select one of the following,"},{"line_number":651,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":652,"context_line":"  in: body"},{"line_number":653,"context_line":"  required: true"},{"line_number":654,"context_line":"  type: array"},{"line_number":655,"context_line":"flavour_id:"},{"line_number":656,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"37026816_0ccafff8","line":653,"range":{"start_line":653,"start_character":2,"end_line":653,"end_character":16},"in_reply_to":"3b80049a_b12d57d5","updated":"2021-03-24 07:42:20.000000000","message":"thanks, I fixed it.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"c416061aec484cb466502f4285bec8a64cdedb51","unresolved":true,"context_lines":[{"line_number":650,"context_line":"    Select one of the following,"},{"line_number":651,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":652,"context_line":"  in: body"},{"line_number":653,"context_line":"  required: true"},{"line_number":654,"context_line":"  type: array"},{"line_number":655,"context_line":"flavour_id:"},{"line_number":656,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"01453904_78593638","line":653,"range":{"start_line":653,"start_character":2,"end_line":653,"end_character":16},"in_reply_to":"cdc98fd0_74a06ef9","updated":"2021-03-23 05:13:33.000000000","message":"In SOL, these parameters are annotated as follows.\n\nExactly one of \"fixedAddresses\", \"numDynamicAddresses\" or \"ipAddressRange\" shall be present.\n\nI set required to true because the API parameters can only be expressed as true/false.\nWould it be better to set it to false?\nI think that the previous required also follows the above.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"849996f9a77a340458279b6ae65f459a49f0fbdc","unresolved":true,"context_lines":[{"line_number":650,"context_line":"    Select one of the following,"},{"line_number":651,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":652,"context_line":"  in: body"},{"line_number":653,"context_line":"  required: true"},{"line_number":654,"context_line":"  type: array"},{"line_number":655,"context_line":"flavour_id:"},{"line_number":656,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3b80049a_b12d57d5","line":653,"range":{"start_line":653,"start_character":2,"end_line":653,"end_character":16},"in_reply_to":"f57919ce_759171ea","updated":"2021-03-24 06:46:04.000000000","message":"To express that \u0027ipAddressRange\u0027 is not supported, I think it would be simpler to write as follows.\n---\nExactly one of \"fixedAddresses\" or \"numDynamicAddresses\" shall be present.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c74eb67fcfee375c3090ed9aa15107931599ed3a","unresolved":true,"context_lines":[{"line_number":813,"context_line":"    Select one of the following,"},{"line_number":814,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":815,"context_line":"  in: body"},{"line_number":816,"context_line":"  required: true"},{"line_number":817,"context_line":"  type: int"},{"line_number":818,"context_line":"number_of_steps:"},{"line_number":819,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"239313cc_27616908","line":816,"updated":"2021-03-23 02:53:03.000000000","message":"Same as L653.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e12861e52b279f44e015e6d6bc4f651f28b69062","unresolved":false,"context_lines":[{"line_number":813,"context_line":"    Select one of the following,"},{"line_number":814,"context_line":"    fixed_addresses / num_dynamic_addresses."},{"line_number":815,"context_line":"  in: body"},{"line_number":816,"context_line":"  required: true"},{"line_number":817,"context_line":"  type: int"},{"line_number":818,"context_line":"number_of_steps:"},{"line_number":819,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"febacbbf_6622ffbe","line":816,"in_reply_to":"239313cc_27616908","updated":"2021-03-24 08:06:36.000000000","message":"I\u0027ve confirmed.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"}],"tacker/objects/instantiate_vnf_req.py":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"3a3871f409afb989feeb946a9846a0b1a6ad1a14","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    cp_protocol_data_list \u003d []"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _get_ip_addresses(ip_addresses):"},{"line_number":102,"context_line":"        ip_addresses \u003d []"},{"line_number":103,"context_line":"        for ip_address in ip_addresses:"},{"line_number":104,"context_line":"            ip_address_data \u003d IpAddressReq("},{"line_number":105,"context_line":"                type\u003dip_address.type,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7902db54_1ce6be1c","line":102,"updated":"2021-03-17 05:15:30.000000000","message":"In the first place this method is meaningless, though this comment is for the original code.\nThis method always returns [].\nL.102 variable name \u0027ip_addresses\u0027 should not be \u0027ip_addresses\u0027 which is argument name.","commit_id":"8b1f2625987a6543dba7076274b5711198a84d99"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"70db776003bd61e5ed84e45c9f0d84dea861f39a","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    cp_protocol_data_list \u003d []"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _get_ip_addresses(ip_addresses):"},{"line_number":102,"context_line":"        ip_addresses \u003d []"},{"line_number":103,"context_line":"        for ip_address in ip_addresses:"},{"line_number":104,"context_line":"            ip_address_data \u003d IpAddressReq("},{"line_number":105,"context_line":"                type\u003dip_address.type,"}],"source_content_type":"text/x-python","patch_set":15,"id":"514338f2_acbc8466","line":102,"in_reply_to":"7902db54_1ce6be1c","updated":"2021-03-22 14:59:54.000000000","message":"Thank you pointed out.\nI modified as new variable definition.","commit_id":"8b1f2625987a6543dba7076274b5711198a84d99"}],"tacker/objects/vnf_instantiated_info.py":[{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"e15441a5d9a5d25b5a1ac6c58066f6459558a58f","unresolved":true,"context_lines":[{"line_number":645,"context_line":"        return {\u0027type\u0027: self.type,"},{"line_number":646,"context_line":"            \u0027subnet_id\u0027: self.subnet_id,"},{"line_number":647,"context_line":"            \u0027is_dynamic\u0027: self.is_dynamic,"},{"line_number":648,"context_line":"            \u0027addresses\u0027: self.addresses,"},{"line_number":649,"context_line":"            \u0027address_range\u0027: self.address_range}"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":2,"id":"e22a51c0_c899fc5f","line":649,"range":{"start_line":648,"start_character":2,"end_line":649,"end_character":48},"updated":"2021-01-26 00:43:43.000000000","message":"I have several concerns, it helps if you tell me your consideration:)\n\n1. Correctness check of inputed address_range, it seems not checking ip range input, so developers who using this parameter will check it by themselves?(like min_address\u003emax_address, or missing min address)\n\n2. should address_range coexist with fixed addresses? if fixed ip is coverd by range?\n\n3. multiple address_range like [10.0.0.1..10.0.0.24, 10.0.0.120...10.0.0.164]","commit_id":"1ab99860271e28aed679f3570018b68701e4ddf2"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"328e3c880c8c085730c9bcdeeb731cd40b1504b5","unresolved":true,"context_lines":[{"line_number":645,"context_line":"        return {\u0027type\u0027: self.type,"},{"line_number":646,"context_line":"            \u0027subnet_id\u0027: self.subnet_id,"},{"line_number":647,"context_line":"            \u0027is_dynamic\u0027: self.is_dynamic,"},{"line_number":648,"context_line":"            \u0027addresses\u0027: self.addresses,"},{"line_number":649,"context_line":"            \u0027address_range\u0027: self.address_range}"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":2,"id":"f7223aba_832bf1ca","line":649,"range":{"start_line":648,"start_character":2,"end_line":649,"end_character":48},"in_reply_to":"e22a51c0_c899fc5f","updated":"2021-01-29 12:42:10.000000000","message":"Thanks your comments.\n\n1. This Request parameters will be listed in the HOT. I\u0027m thinking about Heat verify this parameter in finally.\n\n2. Tacker will cover both, has not the function to decide which one to use. I think it is better for the user to decide which parameter to choose. The above will be complemented in the documentation. We are still working on how to describe it in HOT.\n\n3. ETSI SOL003 defines the cardinality of addressrange as [0...1]. Therefore, I think that there is only one addressrange pair.","commit_id":"1ab99860271e28aed679f3570018b68701e4ddf2"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fb927fbd48893df79ad3e0316909ce17e845b250","unresolved":true,"context_lines":[{"line_number":645,"context_line":"        return {\u0027type\u0027: self.type,"},{"line_number":646,"context_line":"            \u0027subnet_id\u0027: self.subnet_id,"},{"line_number":647,"context_line":"            \u0027is_dynamic\u0027: self.is_dynamic,"},{"line_number":648,"context_line":"            \u0027addresses\u0027: self.addresses,"},{"line_number":649,"context_line":"            \u0027address_range\u0027: self.address_range}"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"@base.TackerObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":2,"id":"974d7ef2_f7778066","line":649,"range":{"start_line":648,"start_character":2,"end_line":649,"end_character":48},"in_reply_to":"f7223aba_832bf1ca","updated":"2021-02-17 08:45:36.000000000","message":"Thanks for reply! got it","commit_id":"1ab99860271e28aed679f3570018b68701e4ddf2"}],"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c74eb67fcfee375c3090ed9aa15107931599ed3a","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            subscription_id)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Pre Setting: Create vnf package."},{"line_number":250,"context_line":"        sample_name \u003d \u0027functional7\u0027"},{"line_number":251,"context_line":"        csar_package_path \u003d os.path.abspath("},{"line_number":252,"context_line":"            os.path.join("},{"line_number":253,"context_line":"                os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":18,"id":"5acfadcb_3b20db68","line":250,"updated":"2021-03-23 02:53:03.000000000","message":"I prefer to avoid preparing new functional-test PKGs if possible, as it can be cumbersome to manage.\nIs there a clear reason to have a new \u0027functional7\u0027 that cannot be extended from the existing \u0027functional\u0027 to \u0027functional6\u0027?","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f703765f6365c8b3d8b949776b77fd2065c7aaa9","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            subscription_id)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Pre Setting: Create vnf package."},{"line_number":250,"context_line":"        sample_name \u003d \u0027functional7\u0027"},{"line_number":251,"context_line":"        csar_package_path \u003d os.path.abspath("},{"line_number":252,"context_line":"            os.path.join("},{"line_number":253,"context_line":"                os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":18,"id":"efa733bc_ccf281a8","line":250,"in_reply_to":"01deb4b0_70ffb46a","updated":"2021-03-23 07:31:35.000000000","message":"Thank you for your answer.\nI think the existing test using \u0027functional5\u0027 is \u0027test_inst_scaling_term\u0027.\nIs it possible to modify what you explained about \u0027functional5\u0027 and add the test checkpoints you tried to check with \u0027test_inst_scaling_term_for_input_ip_over_combination_param\u0027 to \u0027test_inst_scaling_term\u0027?\nIf that\u0027s possible, I think you won\u0027t have to define new \u0027functional7\u0027 and \u0027test_inst_scaling_term_for_input_ip_over_combination_param\u0027.\nIf it is essential to add a new test, it should be added, but due to the limited test execution time, it is better to avoid adding a new test if possible.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"c416061aec484cb466502f4285bec8a64cdedb51","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            subscription_id)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Pre Setting: Create vnf package."},{"line_number":250,"context_line":"        sample_name \u003d \u0027functional7\u0027"},{"line_number":251,"context_line":"        csar_package_path \u003d os.path.abspath("},{"line_number":252,"context_line":"            os.path.join("},{"line_number":253,"context_line":"                os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":18,"id":"01deb4b0_70ffb46a","line":250,"in_reply_to":"5acfadcb_3b20db68","updated":"2021-03-23 05:13:33.000000000","message":"Because I needed to modify an existing package \u0027functional5\u0027, I thought that could not use the existing package and added a new package.\nIf you want to use an existing package, you will need to make the following modifications.\n- Fix BaseHOT\n  * Change parameters and parameter acquisition method\n- VNFD configuration changes\n  * Change the initial number of VDU instances\n- Modify Instantiation request parameters","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"849996f9a77a340458279b6ae65f459a49f0fbdc","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            subscription_id)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Pre Setting: Create vnf package."},{"line_number":250,"context_line":"        sample_name \u003d \u0027functional7\u0027"},{"line_number":251,"context_line":"        csar_package_path \u003d os.path.abspath("},{"line_number":252,"context_line":"            os.path.join("},{"line_number":253,"context_line":"                os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":18,"id":"be34634e_7945e23d","line":250,"in_reply_to":"834f077b_fb0eb1b9","updated":"2021-03-24 06:46:04.000000000","message":"I\u0027ve confirmed.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"cd742d03ce9fa5ab172bf662f8cedaaf8db5a106","unresolved":true,"context_lines":[{"line_number":247,"context_line":"            subscription_id)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        # Pre Setting: Create vnf package."},{"line_number":250,"context_line":"        sample_name \u003d \u0027functional7\u0027"},{"line_number":251,"context_line":"        csar_package_path \u003d os.path.abspath("},{"line_number":252,"context_line":"            os.path.join("},{"line_number":253,"context_line":"                os.path.dirname(__file__),"}],"source_content_type":"text/x-python","patch_set":18,"id":"834f077b_fb0eb1b9","line":250,"in_reply_to":"efa733bc_ccf281a8","updated":"2021-03-24 03:30:36.000000000","message":"I deleted new test, improved the existing test.\nIncluded items that I want to check using \u0027test_inst_scaling_term\u0027 and \u0027functional5\u0027.","commit_id":"cc8dd3074255d018f2ffb2689ea6725ccfe23046"}],"tacker/vnfm/lcm_user_data/utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9ca363a2a71ecf5a9f92626e7bb9dca03ec3af41","unresolved":true,"context_lines":[{"line_number":202,"context_line":"    if cpd_vl_dict:"},{"line_number":203,"context_line":"        for target_cp in cps:"},{"line_number":204,"context_line":"            if \u0027network\u0027 in cpd_vl_dict.get(target_cp):"},{"line_number":205,"context_line":"                cps[target_cp][\u0027network\u0027] \u003d\\"},{"line_number":206,"context_line":"                    cpd_vl_dict.get(target_cp).get(\u0027network\u0027)"},{"line_number":207,"context_line":"            if \u0027fixed_ips\u0027 in cpd_vl_dict.get(target_cp):"},{"line_number":208,"context_line":"                cps[target_cp][\u0027fixed_ips\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"9e4444b2_beedd138","line":205,"range":{"start_line":205,"start_character":43,"end_line":205,"end_character":44},"updated":"2021-02-22 02:24:15.000000000","message":"nit. Why don\u0027t you remove this one like as below?\n\n```\ncps[target_cp][\u0027network\u0027] \u003d cpd_vl_dict.get(\n                                target_cp).get(\u0027network\u0027)\n```","commit_id":"e39ff61a31b5692c725a2ed13d09fd711ff34d6a"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"08df43999a42acfdb1a94d6b150138d52dd45c29","unresolved":true,"context_lines":[{"line_number":202,"context_line":"    if cpd_vl_dict:"},{"line_number":203,"context_line":"        for target_cp in cps:"},{"line_number":204,"context_line":"            if \u0027network\u0027 in cpd_vl_dict.get(target_cp):"},{"line_number":205,"context_line":"                cps[target_cp][\u0027network\u0027] \u003d\\"},{"line_number":206,"context_line":"                    cpd_vl_dict.get(target_cp).get(\u0027network\u0027)"},{"line_number":207,"context_line":"            if \u0027fixed_ips\u0027 in cpd_vl_dict.get(target_cp):"},{"line_number":208,"context_line":"                cps[target_cp][\u0027fixed_ips\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"46af5ff5_5f5984fb","line":205,"range":{"start_line":205,"start_character":43,"end_line":205,"end_character":44},"in_reply_to":"9e4444b2_beedd138","updated":"2021-02-22 11:16:37.000000000","message":"Thank you suggestion.\nI will be fixed it.","commit_id":"e39ff61a31b5692c725a2ed13d09fd711ff34d6a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"9ca363a2a71ecf5a9f92626e7bb9dca03ec3af41","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d1494953_2c3aaade","line":409,"range":{"start_line":407,"start_character":0,"end_line":409,"end_character":0},"updated":"2021-02-22 02:24:15.000000000","message":"Is it required?","commit_id":"e39ff61a31b5692c725a2ed13d09fd711ff34d6a"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"08df43999a42acfdb1a94d6b150138d52dd45c29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"19c3f3d6_483830f3","line":409,"range":{"start_line":407,"start_character":0,"end_line":409,"end_character":0},"in_reply_to":"d1494953_2c3aaade","updated":"2021-02-22 11:16:37.000000000","message":"there is no return value, so delete it.","commit_id":"e39ff61a31b5692c725a2ed13d09fd711ff34d6a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b409e2ee902f57550c55b45103e7f4dd332c66ea","unresolved":true,"context_lines":[{"line_number":378,"context_line":"            if ext_cp.cpd_id in cp_param.keys():"},{"line_number":379,"context_line":"                cp_data[ext_cp.cpd_id] \u003d {}"},{"line_number":380,"context_line":"                cp_data[ext_cp.cpd_id][\"network\"] \u003d ext_vl.resource_id"},{"line_number":381,"context_line":"                _create_fixed_ips_dict(cp_data, ext_cp)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    LOG.info(\u0027cp_data: %s\u0027, cp_data)"},{"line_number":384,"context_line":"    return cp_data"}],"source_content_type":"text/x-python","patch_set":7,"id":"da750e0a_5686013b","line":381,"updated":"2021-03-03 06:39:12.000000000","message":"Why don\u0027t you make it simpler as follows? \n\n```\ncp_data[ext_cp.cpd_id][\"fixed_ips\"] \u003d _create_fixed_ips_dict(ext_cp)\n```","commit_id":"cdd0a7f30971f225ae118fc5b8b666a857aa69a0"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"e86d262e473cceef0b0685065b20563b03345cd6","unresolved":true,"context_lines":[{"line_number":378,"context_line":"            if ext_cp.cpd_id in cp_param.keys():"},{"line_number":379,"context_line":"                cp_data[ext_cp.cpd_id] \u003d {}"},{"line_number":380,"context_line":"                cp_data[ext_cp.cpd_id][\"network\"] \u003d ext_vl.resource_id"},{"line_number":381,"context_line":"                _create_fixed_ips_dict(cp_data, ext_cp)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    LOG.info(\u0027cp_data: %s\u0027, cp_data)"},{"line_number":384,"context_line":"    return cp_data"}],"source_content_type":"text/x-python","patch_set":7,"id":"8b9ab9d2_3eb26e34","line":381,"in_reply_to":"07cc22cb_9f1db36b","updated":"2021-03-16 07:56:15.000000000","message":"Fixed here.","commit_id":"cdd0a7f30971f225ae118fc5b8b666a857aa69a0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f7a29fa62e59c48b2ea339a8f99cf96eed4d7875","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if ext_cp.cpd_id in cp_param.keys():"},{"line_number":379,"context_line":"                cp_data[ext_cp.cpd_id] \u003d {}"},{"line_number":380,"context_line":"                cp_data[ext_cp.cpd_id][\"network\"] \u003d ext_vl.resource_id"},{"line_number":381,"context_line":"                _create_fixed_ips_dict(cp_data, ext_cp)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    LOG.info(\u0027cp_data: %s\u0027, cp_data)"},{"line_number":384,"context_line":"    return cp_data"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3042f9_5b60d492","line":381,"in_reply_to":"8b9ab9d2_3eb26e34","updated":"2021-03-25 09:29:50.000000000","message":"Done","commit_id":"cdd0a7f30971f225ae118fc5b8b666a857aa69a0"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"9d8fbb32387ac343b0ce0e3cf39cc5369cfe68ed","unresolved":true,"context_lines":[{"line_number":378,"context_line":"            if ext_cp.cpd_id in cp_param.keys():"},{"line_number":379,"context_line":"                cp_data[ext_cp.cpd_id] \u003d {}"},{"line_number":380,"context_line":"                cp_data[ext_cp.cpd_id][\"network\"] \u003d ext_vl.resource_id"},{"line_number":381,"context_line":"                _create_fixed_ips_dict(cp_data, ext_cp)"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    LOG.info(\u0027cp_data: %s\u0027, cp_data)"},{"line_number":384,"context_line":"    return cp_data"}],"source_content_type":"text/x-python","patch_set":7,"id":"07cc22cb_9f1db36b","line":381,"in_reply_to":"da750e0a_5686013b","updated":"2021-03-10 14:56:58.000000000","message":"I agree with your suggestion.\nI will fix it to return a list.","commit_id":"cdd0a7f30971f225ae118fc5b8b666a857aa69a0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"b409e2ee902f57550c55b45103e7f4dd332c66ea","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    return cp_data"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"def _create_fixed_ips_dict(cp_data, ext_cp):"},{"line_number":388,"context_line":"    \"\"\"Create a dict containing information about IP information."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    :param cp_data: dict(\u0027nfv\u0027:\u0027CP\u0027, HOT resource dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"6de9912a_8114cd16","line":387,"range":{"start_line":387,"start_character":0,"end_line":387,"end_character":43},"updated":"2021-03-03 06:39:12.000000000","message":"No need to give `cp_data` if make a list as local var and return it.","commit_id":"cdd0a7f30971f225ae118fc5b8b666a857aa69a0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f7a29fa62e59c48b2ea339a8f99cf96eed4d7875","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    return cp_data"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"def _create_fixed_ips_dict(cp_data, ext_cp):"},{"line_number":388,"context_line":"    \"\"\"Create a dict containing information about IP information."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    :param cp_data: dict(\u0027nfv\u0027:\u0027CP\u0027, HOT resource dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"283ba80f_8b8906d4","line":387,"range":{"start_line":387,"start_character":0,"end_line":387,"end_character":43},"in_reply_to":"3dea88b6_75b3e44a","updated":"2021-03-25 09:29:50.000000000","message":"Done","commit_id":"cdd0a7f30971f225ae118fc5b8b666a857aa69a0"},{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"e86d262e473cceef0b0685065b20563b03345cd6","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    return cp_data"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"def _create_fixed_ips_dict(cp_data, ext_cp):"},{"line_number":388,"context_line":"    \"\"\"Create a dict containing information about IP information."},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    :param cp_data: dict(\u0027nfv\u0027:\u0027CP\u0027, HOT resource dict)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3dea88b6_75b3e44a","line":387,"range":{"start_line":387,"start_character":0,"end_line":387,"end_character":43},"in_reply_to":"6de9912a_8114cd16","updated":"2021-03-16 07:56:15.000000000","message":"Build a list and return it.","commit_id":"cdd0a7f30971f225ae118fc5b8b666a857aa69a0"}]}