)]}'
{"tacker/tests/unit/objects/test_vnf_lcm_op_occs.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2a1e4c33217642000e7ca6332db2cd052862d97d","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(TestVnfLcmOpOcc, self).setUp()"},{"line_number":31,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":32,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":33,"context_line":"        self.engine \u003d get_engine()"},{"line_number":34,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":35,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":36,"context_line":"        self.vnf_package \u003d self._create_vnf_package()"},{"line_number":37,"context_line":"        self.vnf_package_vnfd \u003d self._create_and_upload_vnf_package_vnfd()"},{"line_number":38,"context_line":"        self.vnf_instance \u003d self._create_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":6,"id":"2c146c53_0cafb42d","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":32},"updated":"2021-03-08 13:02:36.000000000","message":"Why are these legacy NFVO objects used here?","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"d4517e83f28f395134013a521e4679b6e296423c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(TestVnfLcmOpOcc, self).setUp()"},{"line_number":31,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":32,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":33,"context_line":"        self.engine \u003d get_engine()"},{"line_number":34,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":35,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":36,"context_line":"        self.vnf_package \u003d self._create_vnf_package()"},{"line_number":37,"context_line":"        self.vnf_package_vnfd \u003d self._create_and_upload_vnf_package_vnfd()"},{"line_number":38,"context_line":"        self.vnf_instance \u003d self._create_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":6,"id":"6b3060bc_c6abb438","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":32},"in_reply_to":"2c146c53_0cafb42d","updated":"2021-03-22 04:02:49.000000000","message":"Thanks for comment, they are wrongly used here, deleted in the latest patch","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2e2f7c6c04377d9932ba58e3d1d23d2f55bf4c89","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(TestVnfLcmOpOcc, self).setUp()"},{"line_number":31,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":32,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":33,"context_line":"        self.engine \u003d get_engine()"},{"line_number":34,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":35,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":36,"context_line":"        self.vnf_package \u003d self._create_vnf_package()"},{"line_number":37,"context_line":"        self.vnf_package_vnfd \u003d self._create_and_upload_vnf_package_vnfd()"},{"line_number":38,"context_line":"        self.vnf_instance \u003d self._create_vnf_instance()"}],"source_content_type":"text/x-python","patch_set":6,"id":"0e82290a_19bc299a","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":32},"in_reply_to":"6b3060bc_c6abb438","updated":"2021-03-22 09:03:52.000000000","message":"Done","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b9588214a863c5732748714cd6b0da4cf4c72d59","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":21,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestVnfLcmOpOcc(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"70ca6cf6_3e49099e","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":38},"updated":"2021-03-25 04:22:31.000000000","message":"It seems that `get_engine` is not used in this file, why do you need this definition?\nIf it is not needed, I think this files change is also unnecessary.","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"1f18f003ab986be2eab6cde9d76fc0a2eeb5902d","unresolved":true,"context_lines":[{"line_number":20,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":21,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestVnfLcmOpOcc(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf01d3d8_5563d13d","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":38},"in_reply_to":"70ca6cf6_3e49099e","updated":"2021-03-25 08:29:30.000000000","message":"Thanks for comment ! this is an undeleted code from last patch, used for running unittest by python3 -m unittest command, fixed in lateset patch","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"25e145b643e671eb9315c22fe52557bafc5075b1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":21,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TestVnfLcmOpOcc(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3871ac41_df783d9f","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":38},"in_reply_to":"bf01d3d8_5563d13d","updated":"2021-03-25 11:34:28.000000000","message":"Done","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"}],"tacker/tests/unit/objects/test_vnf_lcm_subscriptions.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2a1e4c33217642000e7ca6332db2cd052862d97d","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestVnfLcmSubScriptions, self).setUp()"},{"line_number":30,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":31,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":32,"context_line":"        self.engine \u003d get_engine()"},{"line_number":33,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":34,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":35,"context_line":"        self.vnf_package \u003d self._create_vnf_package()"},{"line_number":36,"context_line":"        self.vnf_package_vnfd \u003d self._create_and_upload_vnf_package_vnfd()"},{"line_number":37,"context_line":"        self.subscription \u003d self._create_subscription()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3bf52fd2_10bcfe06","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":32},"updated":"2021-03-08 13:02:36.000000000","message":"Why are these legacy NFVO objects used here?","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"d4517e83f28f395134013a521e4679b6e296423c","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestVnfLcmSubScriptions, self).setUp()"},{"line_number":30,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":31,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":32,"context_line":"        self.engine \u003d get_engine()"},{"line_number":33,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":34,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":35,"context_line":"        self.vnf_package \u003d self._create_vnf_package()"},{"line_number":36,"context_line":"        self.vnf_package_vnfd \u003d self._create_and_upload_vnf_package_vnfd()"},{"line_number":37,"context_line":"        self.subscription \u003d self._create_subscription()"}],"source_content_type":"text/x-python","patch_set":6,"id":"7673971e_5b4b3cf9","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":32},"in_reply_to":"3bf52fd2_10bcfe06","updated":"2021-03-22 04:02:49.000000000","message":"Thanks for comment, they are wrongly used here, deleted in the latest patch","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2e2f7c6c04377d9932ba58e3d1d23d2f55bf4c89","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestVnfLcmSubScriptions, self).setUp()"},{"line_number":30,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":31,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":32,"context_line":"        self.engine \u003d get_engine()"},{"line_number":33,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":34,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":35,"context_line":"        self.vnf_package \u003d self._create_vnf_package()"},{"line_number":36,"context_line":"        self.vnf_package_vnfd \u003d self._create_and_upload_vnf_package_vnfd()"},{"line_number":37,"context_line":"        self.subscription \u003d self._create_subscription()"}],"source_content_type":"text/x-python","patch_set":6,"id":"b7d28199_29acf136","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":32},"in_reply_to":"7673971e_5b4b3cf9","updated":"2021-03-22 09:03:52.000000000","message":"Done","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b9588214a863c5732748714cd6b0da4cf4c72d59","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":20,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestVnfLcmSubScriptions(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"084be0d2_ae52ea6a","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":38},"updated":"2021-03-25 04:22:31.000000000","message":"It seems that `get_engine` is not used in this file, why do you need this definition?","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"1f18f003ab986be2eab6cde9d76fc0a2eeb5902d","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":20,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestVnfLcmSubScriptions(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e6d5a093_b4469638","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":38},"in_reply_to":"084be0d2_ae52ea6a","updated":"2021-03-25 08:29:30.000000000","message":"Thanks for comment ! this is an undeleted code from last patch, used for running unittest by python3 -m unittest command, fixed in lateset patch","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"25e145b643e671eb9315c22fe52557bafc5075b1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":20,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestVnfLcmSubScriptions(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"496e7883_a1a21166","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":38},"in_reply_to":"e6d5a093_b4469638","updated":"2021-03-25 11:34:28.000000000","message":"Done","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"}],"tacker/tests/unit/objects/test_vnf_package_vnfd.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2a1e4c33217642000e7ca6332db2cd052862d97d","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestVnfPackageVnfd, self).setUp()"},{"line_number":32,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":33,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":34,"context_line":"        self.engine \u003d get_engine()"},{"line_number":35,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":36,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_create(self):"},{"line_number":39,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"070149bd_efcf1716","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":32},"updated":"2021-03-08 13:02:36.000000000","message":"Why are these legacy NFVO objects used here?","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"d4517e83f28f395134013a521e4679b6e296423c","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestVnfPackageVnfd, self).setUp()"},{"line_number":32,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":33,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":34,"context_line":"        self.engine \u003d get_engine()"},{"line_number":35,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":36,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_create(self):"},{"line_number":39,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"cc30ccca_63e40c2d","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":32},"in_reply_to":"070149bd_efcf1716","updated":"2021-03-22 04:02:49.000000000","message":"Thanks for comment, they are wrongly used here, deleted in the latest patch","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2e2f7c6c04377d9932ba58e3d1d23d2f55bf4c89","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestVnfPackageVnfd, self).setUp()"},{"line_number":32,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":33,"context_line":"        self.vims \u003d nfvo_db.Vim(**fakes.vim_data)"},{"line_number":34,"context_line":"        self.engine \u003d get_engine()"},{"line_number":35,"context_line":"        self.conn \u003d self.engine.connect()"},{"line_number":36,"context_line":"        self.vim \u003d nfvo_db.Vim()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_create(self):"},{"line_number":39,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"db2b1257_82d61a95","line":36,"range":{"start_line":33,"start_character":0,"end_line":36,"end_character":32},"in_reply_to":"cc30ccca_63e40c2d","updated":"2021-03-22 09:03:52.000000000","message":"Done","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2a1e4c33217642000e7ca6332db2cd052862d97d","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        vnf_pack_vnfd_obj.create()"},{"line_number":79,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_vnf_package_vnfd("},{"line_number":80,"context_line":"            vnf_pack_vnfd_obj.id)"},{"line_number":81,"context_line":"        self.assertEqual(result, None)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_get_vnf_package_vnfd_by_vnfid(self):"},{"line_number":84,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5820a90e_59d12b1e","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":38},"updated":"2021-03-08 13:02:36.000000000","message":"What is the purpose of this test? Is it correct to get \"None\" as result?","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"d4517e83f28f395134013a521e4679b6e296423c","unresolved":true,"context_lines":[{"line_number":78,"context_line":"        vnf_pack_vnfd_obj.create()"},{"line_number":79,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_vnf_package_vnfd("},{"line_number":80,"context_line":"            vnf_pack_vnfd_obj.id)"},{"line_number":81,"context_line":"        self.assertEqual(result, None)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_get_vnf_package_vnfd_by_vnfid(self):"},{"line_number":84,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"930d36de_42035c06","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":38},"in_reply_to":"5820a90e_59d12b1e","updated":"2021-03-22 04:02:49.000000000","message":"actually vnf_pack_vnfd_obj.get_vnf_package_vnfd is accessing DB however in unittest it cannot access to db thus here it return a None, I have added a variable and comment to make it easier to understand for other reviewers","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2e2f7c6c04377d9932ba58e3d1d23d2f55bf4c89","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        vnf_pack_vnfd_obj.create()"},{"line_number":79,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_vnf_package_vnfd("},{"line_number":80,"context_line":"            vnf_pack_vnfd_obj.id)"},{"line_number":81,"context_line":"        self.assertEqual(result, None)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_get_vnf_package_vnfd_by_vnfid(self):"},{"line_number":84,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"451bf67b_01fd6df4","line":81,"range":{"start_line":81,"start_character":8,"end_line":81,"end_character":38},"in_reply_to":"930d36de_42035c06","updated":"2021-03-22 09:03:52.000000000","message":"Done","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2a1e4c33217642000e7ca6332db2cd052862d97d","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        vnf_pack_vnfd_obj.create()"},{"line_number":90,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_vnf_package_vnfd_by_vnfid("},{"line_number":91,"context_line":"            self.context, vnf_pack_vnfd_obj.id)"},{"line_number":92,"context_line":"        self.assertEqual(result, None)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_get_by_vnfd_id(self):"},{"line_number":95,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"211ad76a_6e1b055a","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":38},"updated":"2021-03-08 13:02:36.000000000","message":"ditto","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"d4517e83f28f395134013a521e4679b6e296423c","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        vnf_pack_vnfd_obj.create()"},{"line_number":90,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_vnf_package_vnfd_by_vnfid("},{"line_number":91,"context_line":"            self.context, vnf_pack_vnfd_obj.id)"},{"line_number":92,"context_line":"        self.assertEqual(result, None)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_get_by_vnfd_id(self):"},{"line_number":95,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8bd8aa2c_8c01f320","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":38},"in_reply_to":"211ad76a_6e1b055a","updated":"2021-03-22 04:02:49.000000000","message":"ditto","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2e2f7c6c04377d9932ba58e3d1d23d2f55bf4c89","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        vnf_pack_vnfd_obj.create()"},{"line_number":90,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_vnf_package_vnfd_by_vnfid("},{"line_number":91,"context_line":"            self.context, vnf_pack_vnfd_obj.id)"},{"line_number":92,"context_line":"        self.assertEqual(result, None)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_get_by_vnfd_id(self):"},{"line_number":95,"context_line":"        vnf_pack \u003d vnf_package.VnfPackage(context\u003dself.context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"26dbdf1b_e91f588a","line":92,"range":{"start_line":92,"start_character":8,"end_line":92,"end_character":38},"in_reply_to":"8bd8aa2c_8c01f320","updated":"2021-03-22 09:03:52.000000000","message":"Done","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2a1e4c33217642000e7ca6332db2cd052862d97d","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_by_vnfdId("},{"line_number":112,"context_line":"            self.context, vnf_pack_vnfd_obj.package_uuid)"},{"line_number":113,"context_line":"        vnf_pack_vnfd_obj.deleted \u003d True"},{"line_number":114,"context_line":"        self.assertEqual(result, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"17f511ce_62d672e3","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":38},"updated":"2021-03-08 13:02:36.000000000","message":"ditto","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"d4517e83f28f395134013a521e4679b6e296423c","unresolved":true,"context_lines":[{"line_number":111,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_by_vnfdId("},{"line_number":112,"context_line":"            self.context, vnf_pack_vnfd_obj.package_uuid)"},{"line_number":113,"context_line":"        vnf_pack_vnfd_obj.deleted \u003d True"},{"line_number":114,"context_line":"        self.assertEqual(result, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a203ff04_aea7dfd3","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":38},"in_reply_to":"17f511ce_62d672e3","updated":"2021-03-22 04:02:49.000000000","message":"ditto","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"2e2f7c6c04377d9932ba58e3d1d23d2f55bf4c89","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        result \u003d vnf_pack_vnfd_obj.get_by_vnfdId("},{"line_number":112,"context_line":"            self.context, vnf_pack_vnfd_obj.package_uuid)"},{"line_number":113,"context_line":"        vnf_pack_vnfd_obj.deleted \u003d True"},{"line_number":114,"context_line":"        self.assertEqual(result, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7b813acf_8db358a9","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":38},"in_reply_to":"a203ff04_aea7dfd3","updated":"2021-03-22 09:03:52.000000000","message":"Done","commit_id":"4a884d3c7f709e21e574401d028053ed6fd135b0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b9588214a863c5732748714cd6b0da4cf4c72d59","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":22,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestVnfPackageVnfd(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f6f8f59_945cbda9","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":38},"updated":"2021-03-25 04:22:31.000000000","message":"It seems that `get_engine` is not used in this file, why do you need this definition?","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"1f18f003ab986be2eab6cde9d76fc0a2eeb5902d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":22,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestVnfPackageVnfd(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e4dabb67_af5dbda7","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":38},"in_reply_to":"3f6f8f59_945cbda9","updated":"2021-03-25 08:29:30.000000000","message":"Thanks for comment ! this is an undeleted code from last patch, used for running unittest by python3 -m unittest command, fixed in lateset patch","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"25e145b643e671eb9315c22fe52557bafc5075b1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from tacker.tests.unit.objects import fakes"},{"line_number":22,"context_line":"from tacker.tests import uuidsentinel"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"get_engine \u003d sqlalchemy_api.get_engine"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestVnfPackageVnfd(SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"d9492c08_849d5386","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":38},"in_reply_to":"e4dabb67_af5dbda7","updated":"2021-03-25 11:34:28.000000000","message":"Done","commit_id":"c3c7f0270daf449bd29f7abf9cc8b648bbc09f53"}]}