)]}'
{"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b930fc70a06541841adff842081aa1fda1e230d7","unresolved":true,"context_lines":[{"line_number":2859,"context_line":""},{"line_number":2860,"context_line":"        self.assertEqual(500, resp.status_code)"},{"line_number":2861,"context_line":""},{"line_number":2862,"context_line":"        updates \u003d {\"vnfInstanceName\": \"SampleVnf\","},{"line_number":2863,"context_line":"                   \"vnfInstanceDescription\": \"SampleVnf Description\"}"},{"line_number":2864,"context_line":"        expected_vnf \u003d {\u0027tackerFault\u0027: {\u0027code\u0027: 500,"},{"line_number":2865,"context_line":"                 \u0027message\u0027: \u0027Unexpected API Error. Please report this at \u0027"},{"line_number":2866,"context_line":"                            \u0027http://bugs.launchpad.net/tacker/ and attach the \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"107d04f7_ee500a5b","line":2863,"range":{"start_line":2862,"start_character":8,"end_line":2863,"end_character":69},"updated":"2021-03-01 08:01:16.000000000","message":"This seems unused code.","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"97f3be9062dc2f1e9b605c567b5dd5f9be005782","unresolved":true,"context_lines":[{"line_number":2859,"context_line":""},{"line_number":2860,"context_line":"        self.assertEqual(500, resp.status_code)"},{"line_number":2861,"context_line":""},{"line_number":2862,"context_line":"        updates \u003d {\"vnfInstanceName\": \"SampleVnf\","},{"line_number":2863,"context_line":"                   \"vnfInstanceDescription\": \"SampleVnf Description\"}"},{"line_number":2864,"context_line":"        expected_vnf \u003d {\u0027tackerFault\u0027: {\u0027code\u0027: 500,"},{"line_number":2865,"context_line":"                 \u0027message\u0027: \u0027Unexpected API Error. Please report this at \u0027"},{"line_number":2866,"context_line":"                            \u0027http://bugs.launchpad.net/tacker/ and attach the \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"a316b530_ec276edb","line":2863,"range":{"start_line":2862,"start_character":8,"end_line":2863,"end_character":69},"in_reply_to":"107d04f7_ee500a5b","updated":"2021-03-11 08:43:06.000000000","message":"Thanks for comment! these codes have been deleted","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":2859,"context_line":""},{"line_number":2860,"context_line":"        self.assertEqual(500, resp.status_code)"},{"line_number":2861,"context_line":""},{"line_number":2862,"context_line":"        updates \u003d {\"vnfInstanceName\": \"SampleVnf\","},{"line_number":2863,"context_line":"                   \"vnfInstanceDescription\": \"SampleVnf Description\"}"},{"line_number":2864,"context_line":"        expected_vnf \u003d {\u0027tackerFault\u0027: {\u0027code\u0027: 500,"},{"line_number":2865,"context_line":"                 \u0027message\u0027: \u0027Unexpected API Error. Please report this at \u0027"},{"line_number":2866,"context_line":"                            \u0027http://bugs.launchpad.net/tacker/ and attach the \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"d1eaac17_dca91436","line":2863,"range":{"start_line":2862,"start_character":8,"end_line":2863,"end_character":69},"in_reply_to":"a316b530_ec276edb","updated":"2021-03-12 06:39:21.000000000","message":"I have validate the fix.","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"}],"tacker/tests/unit/vnfpkgm/test_controller.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b930fc70a06541841adff842081aa1fda1e230d7","unresolved":true,"context_lines":[{"line_number":1018,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \"_get_range_from_request\")"},{"line_number":1019,"context_line":"    @mock.patch.object(glance_store, \u0027get_csar_size\u0027)"},{"line_number":1020,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1021,"context_line":"    @mock.patch.object(objects.vnf_package.VnfPackage, \u0027save\u0027)"},{"line_number":1022,"context_line":"    def test_fetch_vnf_package_content("},{"line_number":1023,"context_line":"            self,"},{"line_number":1024,"context_line":"            mock_save,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a563bf60_9b4e245d","line":1021,"range":{"start_line":1021,"start_character":23,"end_line":1021,"end_character":31},"updated":"2021-03-01 08:01:16.000000000","message":"Is this required, IMO this could be call as \"vnf_package.VnfPackage, \"save\".","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":1018,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \"_get_range_from_request\")"},{"line_number":1019,"context_line":"    @mock.patch.object(glance_store, \u0027get_csar_size\u0027)"},{"line_number":1020,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1021,"context_line":"    @mock.patch.object(objects.vnf_package.VnfPackage, \u0027save\u0027)"},{"line_number":1022,"context_line":"    def test_fetch_vnf_package_content("},{"line_number":1023,"context_line":"            self,"},{"line_number":1024,"context_line":"            mock_save,"}],"source_content_type":"text/x-python","patch_set":4,"id":"34ac384c_4dbd1856","line":1021,"range":{"start_line":1021,"start_character":23,"end_line":1021,"end_character":31},"in_reply_to":"759c70fe_7fbac84f","updated":"2021-03-12 06:39:21.000000000","message":"I have verified the fix.","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"97f3be9062dc2f1e9b605c567b5dd5f9be005782","unresolved":true,"context_lines":[{"line_number":1018,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \"_get_range_from_request\")"},{"line_number":1019,"context_line":"    @mock.patch.object(glance_store, \u0027get_csar_size\u0027)"},{"line_number":1020,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1021,"context_line":"    @mock.patch.object(objects.vnf_package.VnfPackage, \u0027save\u0027)"},{"line_number":1022,"context_line":"    def test_fetch_vnf_package_content("},{"line_number":1023,"context_line":"            self,"},{"line_number":1024,"context_line":"            mock_save,"}],"source_content_type":"text/x-python","patch_set":4,"id":"759c70fe_7fbac84f","line":1021,"range":{"start_line":1021,"start_character":23,"end_line":1021,"end_character":31},"in_reply_to":"a563bf60_9b4e245d","updated":"2021-03-11 08:43:06.000000000","message":"fixed","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b930fc70a06541841adff842081aa1fda1e230d7","unresolved":true,"context_lines":[{"line_number":1035,"context_line":"        mock_get_range.return_value \u003d \"10-20, 21-30\""},{"line_number":1036,"context_line":"        mock_download.return_value \u003d \"Response\""},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        result \u003d self.controller.fetch_vnf_package_content(request, id)"},{"line_number":1039,"context_line":"        self.assertEqual(result, \"Response\")"},{"line_number":1040,"context_line":"        mock_get_csar_size.assert_called_once_with("},{"line_number":1041,"context_line":"            id, fakes.return_vnfpkg_obj().location_glance_store)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2f99f9c_2f0b4273","line":1038,"range":{"start_line":1038,"start_character":68,"end_line":1038,"end_character":71},"updated":"2021-03-01 08:01:16.000000000","message":"Just a doubt, this is VNF package \"id\" that we are passing in the function. Should we initialize the same.","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":1035,"context_line":"        mock_get_range.return_value \u003d \"10-20, 21-30\""},{"line_number":1036,"context_line":"        mock_download.return_value \u003d \"Response\""},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        result \u003d self.controller.fetch_vnf_package_content(request, id)"},{"line_number":1039,"context_line":"        self.assertEqual(result, \"Response\")"},{"line_number":1040,"context_line":"        mock_get_csar_size.assert_called_once_with("},{"line_number":1041,"context_line":"            id, fakes.return_vnfpkg_obj().location_glance_store)"}],"source_content_type":"text/x-python","patch_set":4,"id":"031ee6b5_73ee85b8","line":1038,"range":{"start_line":1038,"start_character":68,"end_line":1038,"end_character":71},"in_reply_to":"d79c2700_ffdcff74","updated":"2021-03-12 06:39:21.000000000","message":"Thanks, I have verified the fix.","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"97f3be9062dc2f1e9b605c567b5dd5f9be005782","unresolved":true,"context_lines":[{"line_number":1035,"context_line":"        mock_get_range.return_value \u003d \"10-20, 21-30\""},{"line_number":1036,"context_line":"        mock_download.return_value \u003d \"Response\""},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        result \u003d self.controller.fetch_vnf_package_content(request, id)"},{"line_number":1039,"context_line":"        self.assertEqual(result, \"Response\")"},{"line_number":1040,"context_line":"        mock_get_csar_size.assert_called_once_with("},{"line_number":1041,"context_line":"            id, fakes.return_vnfpkg_obj().location_glance_store)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d79c2700_ffdcff74","line":1038,"range":{"start_line":1038,"start_character":68,"end_line":1038,"end_character":71},"in_reply_to":"f2f99f9c_2f0b4273","updated":"2021-03-11 08:43:06.000000000","message":"Thanks for comment! I have added an initiate for this variable, please kindly have a check","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"b930fc70a06541841adff842081aa1fda1e230d7","unresolved":true,"context_lines":[{"line_number":1045,"context_line":"            request, 1000)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1048,"context_line":"    def test_fetch_vnf_package_content_uncorrect_onboarding("},{"line_number":1049,"context_line":"            self, mock_get):"},{"line_number":1050,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1051,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"44e17f1d_2565c940","line":1048,"range":{"start_line":1048,"start_character":39,"end_line":1048,"end_character":48},"updated":"2021-03-01 08:01:16.000000000","message":"Should this be \"incorrect\"/\"invalid\" onboarding state.","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":1045,"context_line":"            request, 1000)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1048,"context_line":"    def test_fetch_vnf_package_content_uncorrect_onboarding("},{"line_number":1049,"context_line":"            self, mock_get):"},{"line_number":1050,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1051,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"82598cbe_f5c746f6","line":1048,"range":{"start_line":1048,"start_character":39,"end_line":1048,"end_character":48},"in_reply_to":"2a7020bb_896b1b91","updated":"2021-03-12 06:39:21.000000000","message":"I have verified the fix.","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"97f3be9062dc2f1e9b605c567b5dd5f9be005782","unresolved":true,"context_lines":[{"line_number":1045,"context_line":"            request, 1000)"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1048,"context_line":"    def test_fetch_vnf_package_content_uncorrect_onboarding("},{"line_number":1049,"context_line":"            self, mock_get):"},{"line_number":1050,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1051,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a7020bb_896b1b91","line":1048,"range":{"start_line":1048,"start_character":39,"end_line":1048,"end_character":48},"in_reply_to":"44e17f1d_2565c940","updated":"2021-03-11 08:43:06.000000000","message":"Fixed ,thx for comment!","commit_id":"41cf884fa0205d8e3f55375b74e77482a035a9d6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":1026,"context_line":"            mock_get_csar_size,"},{"line_number":1027,"context_line":"            mock_get_range,"},{"line_number":1028,"context_line":"            mock_download):"},{"line_number":1029,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1030,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"},{"line_number":1031,"context_line":"        request.headers[\"Range\"] \u003d \u0027bytes\u003d10-20,21-30\u0027"},{"line_number":1032,"context_line":"        request.response \u003d \"\""},{"line_number":1033,"context_line":"        mock_get_vnf_package.return_value \u003d fakes.return_vnfpkg_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"169e55e1_8a1e725c","line":1030,"range":{"start_line":1029,"start_character":8,"end_line":1030,"end_character":48},"updated":"2021-03-12 06:39:21.000000000","message":"Could you please help me in understanding this request creation, this looks incomplete as the call expects a parameter \"id\". Such as,\nreq \u003d fake_request.HTTPRequest.blank(\n            \u0027/vnfpkgm/v1/vnf_packages/%s\u0027 % constants.UUID)","commit_id":"2ac74d38570229840cc5a3b13fae2f82a01d4036"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2e68e0f59b07a258e2405ddb883b3198d8952816","unresolved":true,"context_lines":[{"line_number":1026,"context_line":"            mock_get_csar_size,"},{"line_number":1027,"context_line":"            mock_get_range,"},{"line_number":1028,"context_line":"            mock_download):"},{"line_number":1029,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1030,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"},{"line_number":1031,"context_line":"        request.headers[\"Range\"] \u003d \u0027bytes\u003d10-20,21-30\u0027"},{"line_number":1032,"context_line":"        request.response \u003d \"\""},{"line_number":1033,"context_line":"        mock_get_vnf_package.return_value \u003d fakes.return_vnfpkg_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"42dfef4e_39fdf5c6","line":1030,"range":{"start_line":1029,"start_character":8,"end_line":1030,"end_character":48},"in_reply_to":"0fc3dab4_4b3cbefd","updated":"2021-03-18 03:15:30.000000000","message":"Thanks Liang san for updating file with desired code changes. I have verified fake_request method changes throughout file.","commit_id":"2ac74d38570229840cc5a3b13fae2f82a01d4036"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"044677b66177d2732d573f6eeb99a713bbe06012","unresolved":true,"context_lines":[{"line_number":1026,"context_line":"            mock_get_csar_size,"},{"line_number":1027,"context_line":"            mock_get_range,"},{"line_number":1028,"context_line":"            mock_download):"},{"line_number":1029,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1030,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"},{"line_number":1031,"context_line":"        request.headers[\"Range\"] \u003d \u0027bytes\u003d10-20,21-30\u0027"},{"line_number":1032,"context_line":"        request.response \u003d \"\""},{"line_number":1033,"context_line":"        mock_get_vnf_package.return_value \u003d fakes.return_vnfpkg_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"0fc3dab4_4b3cbefd","line":1030,"range":{"start_line":1029,"start_character":8,"end_line":1030,"end_character":48},"in_reply_to":"169e55e1_8a1e725c","updated":"2021-03-15 09:24:01.000000000","message":"Sorry actually I also copied this part of code from method above.\nIt seems just generating a fake request to \"localhost://vnfpkgm/v1/vnf_packages/%s/package_content\" and actually in fetch_vnf_package_content(), the method using request is mocked (like _get_vnf_package()).\n\nSo, the URL is actually not affect result or, not used.\n\nBut I think this is an obvious strange code and will cause misunderstanding for reviewers,\nI will fix it to a reasonable one, thanks for comment!","commit_id":"2ac74d38570229840cc5a3b13fae2f82a01d4036"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1048,"context_line":"    def test_fetch_vnf_package_content_invalid_onboarding("},{"line_number":1049,"context_line":"            self, mock_get):"},{"line_number":1050,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1051,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"},{"line_number":1052,"context_line":"        request.headers[\"Range\"] \u003d \u0027bytes\u003d10-20,21-30\u0027"},{"line_number":1053,"context_line":"        request.response \u003d \"\""},{"line_number":1054,"context_line":"        pkgobj \u003d fakes.return_vnfpkg_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"d62cadbb_ebb2219a","line":1051,"range":{"start_line":1050,"start_character":8,"end_line":1051,"end_character":48},"updated":"2021-03-12 06:39:21.000000000","message":"ditto","commit_id":"2ac74d38570229840cc5a3b13fae2f82a01d4036"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    @mock.patch.object(controller.VnfPkgmController, \u0027_get_vnf_package\u0027)"},{"line_number":1063,"context_line":"    def test_fetch_vnf_package_content_not_present(self, mock_get):"},{"line_number":1064,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1065,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"},{"line_number":1066,"context_line":"        request.headers[\"Range\"] \u003d \u0027bytes\u003d10-20,21-30\u0027"},{"line_number":1067,"context_line":"        request.response \u003d \"\""},{"line_number":1068,"context_line":"        pkgobj \u003d fakes.return_vnfpkg_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9b3a4f39_e622cff4","line":1065,"range":{"start_line":1064,"start_character":8,"end_line":1065,"end_character":48},"updated":"2021-03-12 06:39:21.000000000","message":"ditto","commit_id":"2ac74d38570229840cc5a3b13fae2f82a01d4036"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"6d8906544556d921975ff66c9bc5d691147261a7","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"            mock_get,"},{"line_number":1081,"context_line":"            mock_get_range,"},{"line_number":1082,"context_line":"            mock_download):"},{"line_number":1083,"context_line":"        request \u003d fake_request.HTTPRequest.blank("},{"line_number":1084,"context_line":"            \u0027/vnf_packages/%s/package_content/\u0027)"},{"line_number":1085,"context_line":"        request.headers[\"Range\"] \u003d \u0027bytes\u003d10-20,21-30\u0027"},{"line_number":1086,"context_line":"        request.response \u003d \"\""},{"line_number":1087,"context_line":"        pkgobj \u003d fakes.return_vnfpkg_obj()"}],"source_content_type":"text/x-python","patch_set":5,"id":"a6f26634_9521a480","line":1084,"range":{"start_line":1083,"start_character":8,"end_line":1084,"end_character":48},"updated":"2021-03-12 06:39:21.000000000","message":"ditto","commit_id":"2ac74d38570229840cc5a3b13fae2f82a01d4036"}]}