)]}'
{"id":"openstack%2Ftacker~773820","triplet_id":"openstack%2Ftacker~master~I94fc914f58747ae75651480ec11b177140fa849a","project":"openstack/tacker","branch":"master","topic":"cleanup","hashtags":[],"change_id":"I94fc914f58747ae75651480ec11b177140fa849a","subject":"Remove duplication of getting HOT templates","status":"MERGED","created":"2021-02-02 23:46:09.000000000","updated":"2021-02-09 02:14:11.000000000","submitted":"2021-02-09 02:11:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"773820-cleanup","meta_rev_id":"1d1449ede1d4deaabae01f9d77834882d0c502ba","_number":773820,"virtual_id_number":773820,"owner":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-02-09 02:11:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"all":[{"value":2,"date":"2021-02-04 11:12:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":1,"date":"2021-02-04 04:09:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-02-09 01:52:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-02-09 01:52:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"}],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-03 01:52:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-03 21:57:47.000000000","updated_by":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"reviewer":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"state":"REVIEWER"},{"updated":"2021-02-03 21:57:47.000000000","updated_by":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"reviewer":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"state":"REVIEWER"},{"updated":"2021-02-03 21:57:47.000000000","updated_by":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2021-02-04 04:09:19.000000000","updated_by":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"reviewer":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"state":"REVIEWER"},{"updated":"2021-02-09 01:52:36.000000000","updated_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"}],"messages":[{"id":"c6df841cd3bf593c18993c0558527b8289dfaa80","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"date":"2021-02-02 23:46:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff0113af2b6ee9d2fdc667b7ece3ebeffd8a1fa0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 01:52:47.000000000","message":"Patch Set 1: Verified-1\n\n(20 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/caeccaa4d55e4b3582ac66ad12d5750d : SUCCESS in 7m 20s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/684b5ea564784150bcf4b485af723cc8 : SUCCESS in 13m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1768c7307bb947dcaf7190510c40e1d1 : FAILURE in 4m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4b1e25c96a0c4bd0b36fccc1353765d9 : SUCCESS in 14m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0c905ad855d140a980c38cec86973255 : SUCCESS in 13m 28s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cf79f7b544bc49b89fb25a150918e20a : SUCCESS in 12m 41s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/238465dc75834647912087fc47806f65 : SUCCESS in 7m 26s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/6c75295655d5413c944bd008b670d869 : SUCCESS in 1h 44m 03s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/d44f09237e9e45fb9aa03e98c3d039ae : SUCCESS in 2h 00m 16s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/7cdae08fe204469ea423738c0885d222 : FAILURE in 1h 04m 01s","accounts_in_message":[],"_revision_number":1},{"id":"7eb3fc4115a2e6d2ca9e90981aa4edbfc1ef5230","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"date":"2021-02-03 04:58:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ca56945ae9faf88276e2cbe32f7e0c1a0aff7fdd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-03 06:54:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/725972e8939545e8bbc4c3f7b7d09227 : SUCCESS in 7m 44s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f0bd48420b214a528a8bed7dda11f149 : SUCCESS in 13m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/966bc378b286477a800cde1d3195e861 : SUCCESS in 4m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8a45f9711410440bac5bcf92803b42a4 : SUCCESS in 13m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/aaf66490fc2a42888c7e8f5017b06e66 : SUCCESS in 13m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9447ebb2e3164290a20dcc9358bce5ea : SUCCESS in 14m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d0d9fb24ec2946d983042c9412e8d16d : SUCCESS in 6m 51s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/23d764dedff647d18716ac209dcf17fa : SUCCESS in 1h 47m 42s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/8deecb4d46774bd781cb9a972842790e : SUCCESS in 1h 48m 49s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/bd6b68d2d2794b8dbf9bdcc0ae4c4775 : SUCCESS in 1h 04m 30s","accounts_in_message":[],"_revision_number":2},{"id":"10a77b023df552f6371dab60d59f743780e323f1","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-02-04 04:09:19.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM.","accounts_in_message":[],"_revision_number":2},{"id":"0553f6a244fae67520c1830445f901c7197b4083","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-02-04 11:12:57.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3dd436bc113003551f9c33acdcbdb9e4c91d0722","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2021-02-09 01:52:36.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"aa284eec870514f2b00a02f73724ddb806be68d4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 01:52:53.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"564d825379ffeba000827cd138ea7229aff08608","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 02:11:51.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a5ae3910d36d411ab8c2ef6ec6af4dfc : SUCCESS in 13m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/29816e7e61074f1f9aa29440548ddc0e : SUCCESS in 4m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1ac017c79ece4ed59076b2e0cd3ceaa9 : SUCCESS in 13m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4e9c9e008b384f0b858a67ed838b3134 : SUCCESS in 13m 46s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/58e48af1745d4cba817c7283afd13847 : SUCCESS in 6m 02s","accounts_in_message":[],"_revision_number":2},{"id":"0a5c0bd4bc3349a0bdd9ba9404c5e03bfca25f84","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 02:11:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"1d1449ede1d4deaabae01f9d77834882d0c502ba","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 02:14:11.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a85b231f0884c6983350eda3d47132b : SUCCESS in 1m 07s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9204d07e5cc632fda52aee5fc3b9b5885d20d64f","revisions":{"5d3393ec54d3033b98a255f71e75d5e646b84751":{"kind":"REWORK","_number":1,"created":"2021-02-02 23:46:09.000000000","uploader":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"ref":"refs/changes/20/773820/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/20/773820/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/20/773820/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/20/773820/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/20/773820/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/20/773820/1"}}},"commit":{"parents":[{"commit":"0e16ab16fcf881efb6c30cca28a3d267b6a17953","subject":"Merge \"Add parameter `plugin` to kubernetes_driver.instantiate_vnf()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/0e16ab16fcf881efb6c30cca28a3d267b6a17953"}]}],"author":{"name":"Itsuro Oda","email":"oda@valinux.co.jp","date":"2021-02-02 23:30:52.000000000","tz":540},"committer":{"name":"Itsuro Oda","email":"oda@valinux.co.jp","date":"2021-02-02 23:45:21.000000000","tz":540},"subject":"Remove duplication of getting HOT templates","message":"Remove duplication of getting HOT templates\n\nPreviously get_base_nest_hot_dict() was called by vnflcm_driver\nand openstack infra_driver redundantly.\n\nThis patch remove calling get_base_nest_hot_dict() from\nvnflcm_driver because HOT is openstack specific.\nbase_hot_dict parameter of infra_driver interface is removed\nat the same time.\nNote that vnf_package_path parameter is passed to infra_driver\nalways since it is used by both openstack and kubernetes.\n\nChange-Id: I94fc914f58747ae75651480ec11b177140fa849a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/5d3393ec54d3033b98a255f71e75d5e646b84751"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/5d3393ec54d3033b98a255f71e75d5e646b84751"}]},"branch":"refs/heads/master"},"9204d07e5cc632fda52aee5fc3b9b5885d20d64f":{"kind":"REWORK","_number":2,"created":"2021-02-03 04:58:31.000000000","uploader":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"ref":"refs/changes/20/773820/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/20/773820/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/20/773820/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/20/773820/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/20/773820/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/20/773820/2"}}},"commit":{"parents":[{"commit":"0e16ab16fcf881efb6c30cca28a3d267b6a17953","subject":"Merge \"Add parameter `plugin` to kubernetes_driver.instantiate_vnf()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/0e16ab16fcf881efb6c30cca28a3d267b6a17953"}]}],"author":{"name":"Itsuro Oda","email":"oda@valinux.co.jp","date":"2021-02-02 23:30:52.000000000","tz":540},"committer":{"name":"Itsuro Oda","email":"oda@valinux.co.jp","date":"2021-02-03 04:58:14.000000000","tz":540},"subject":"Remove duplication of getting HOT templates","message":"Remove duplication of getting HOT templates\n\nPreviously get_base_nest_hot_dict() was called by vnflcm_driver\nand openstack infra_driver redundantly.\n\nThis patch remove calling get_base_nest_hot_dict() from\nvnflcm_driver because HOT is openstack specific.\nbase_hot_dict parameter of infra_driver interface is removed\nat the same time.\nNote that vnf_package_path parameter is passed to infra_driver\nalways since it is used by both openstack and kubernetes.\n\nChange-Id: I94fc914f58747ae75651480ec11b177140fa849a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9204d07e5cc632fda52aee5fc3b9b5885d20d64f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/9204d07e5cc632fda52aee5fc3b9b5885d20d64f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}