)]}'
{"api-ref/source/v1/vnflcm.inc":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4e03367818645aff872e2d76073a0c071a17f5a1","unresolved":true,"context_lines":[{"line_number":982,"context_line":"  - 400"},{"line_number":983,"context_line":"  - 401"},{"line_number":984,"context_line":"  - 403"},{"line_number":985,"context_line":"  - 500"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"Response Parameters"},{"line_number":988,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"c6a663f1_0c8d36ab","line":985,"updated":"2021-02-22 09:43:02.000000000","message":"Other APIs don\u0027t specify \u0027500\u0027 error code, do you need to add it only here in this patch?","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18706b1bf3db844066a466f4327f640a41f589e2","unresolved":true,"context_lines":[{"line_number":982,"context_line":"  - 400"},{"line_number":983,"context_line":"  - 401"},{"line_number":984,"context_line":"  - 403"},{"line_number":985,"context_line":"  - 500"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"Response Parameters"},{"line_number":988,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"c237969c_e9cb780f","line":985,"in_reply_to":"6077af60_3cc0258c","updated":"2021-03-09 07:54:01.000000000","message":"\u003e I understand that it may return a 500 error.\n\u003e But I could\u0027t understand why you added that to API-DQ.\n\u003e I don\u0027t think API-DQ describes other APIs that may return 500 errors.\n\u003e Does this API need to be specifically marked with a 500 error?\n\nRemoved error code 500 from vnflcm.inc since it is not necessary to specify.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"191d3f639729ee23d6ab7e9eb5a9a39643f00834","unresolved":true,"context_lines":[{"line_number":982,"context_line":"  - 400"},{"line_number":983,"context_line":"  - 401"},{"line_number":984,"context_line":"  - 403"},{"line_number":985,"context_line":"  - 500"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"Response Parameters"},{"line_number":988,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"6077af60_3cc0258c","line":985,"in_reply_to":"ab0c35d4_8bb8a98e","updated":"2021-03-04 03:17:55.000000000","message":"I understand that it may return a 500 error.\nBut I could\u0027t understand why you added that to API-DQ.\nI don\u0027t think API-DQ describes other APIs that may return 500 errors.\nDoes this API need to be specifically marked with a 500 error?","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3bd71d1d7dbbc583f4f62279b7ad29e554f98a8b","unresolved":false,"context_lines":[{"line_number":982,"context_line":"  - 400"},{"line_number":983,"context_line":"  - 401"},{"line_number":984,"context_line":"  - 403"},{"line_number":985,"context_line":"  - 500"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"Response Parameters"},{"line_number":988,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"a1f5ef4b_3a20a8cf","line":985,"in_reply_to":"c237969c_e9cb780f","updated":"2021-03-12 08:19:47.000000000","message":"I\u0027ve confirmed.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b9899f2bf2be23af531b37e631cafb9ff787b0c1","unresolved":true,"context_lines":[{"line_number":982,"context_line":"  - 400"},{"line_number":983,"context_line":"  - 401"},{"line_number":984,"context_line":"  - 403"},{"line_number":985,"context_line":"  - 500"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"Response Parameters"},{"line_number":988,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ab0c35d4_8bb8a98e","line":985,"in_reply_to":"c6a663f1_0c8d36ab","updated":"2021-03-03 13:31:46.000000000","message":"\u003e Other APIs don\u0027t specify \u0027500\u0027 error code, do you need to add it only here in this patch?\n\nIn order to satisfy error handling based on design. When internal server occurs, we need to issue error code 500 for this API.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"}],"tacker/api/views/vnf_lcm.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3bd71d1d7dbbc583f4f62279b7ad29e554f98a8b","unresolved":true,"context_lines":[{"line_number":260,"context_line":"        return self._subscription_filter("},{"line_number":261,"context_line":"            vnf_lcm_subscriptions, nextpage_opaque_marker, paging)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def subscription_show(self, vnf_lcm_subscriptions):"},{"line_number":264,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscriptions)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def show_lcm_op_occs(self, vnf_lcm_op_occs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"2efb1ca0_4132e3b0","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":25},"updated":"2021-03-12 08:19:47.000000000","message":"I think TODO should be included here as well.\nBecause I think this function should also be included in vnf_subscriptions.py.","commit_id":"e86585da51391ed4461a0886481c6b8613deab97"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77bb788dd51cdd9a7ad7a675fd259c28fc5ddae4","unresolved":true,"context_lines":[{"line_number":260,"context_line":"        return self._subscription_filter("},{"line_number":261,"context_line":"            vnf_lcm_subscriptions, nextpage_opaque_marker, paging)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def subscription_show(self, vnf_lcm_subscriptions):"},{"line_number":264,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscriptions)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def show_lcm_op_occs(self, vnf_lcm_op_occs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"6abdb1dd_8268f31e","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":25},"in_reply_to":"2efb1ca0_4132e3b0","updated":"2021-03-17 03:47:22.000000000","message":"\u003e I think TODO should be included here as well.\n\u003e Because I think this function should also be included in vnf_subscriptions.py.\n\nWe will add the TODO in Individual Subscription patch since this patch is for Get Subscription List.","commit_id":"e86585da51391ed4461a0886481c6b8613deab97"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e1d4233b688f1c90f5e6799da9a3129ad611ff74","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        return self._subscription_filter("},{"line_number":261,"context_line":"            vnf_lcm_subscriptions, nextpage_opaque_marker, paging)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def subscription_show(self, vnf_lcm_subscriptions):"},{"line_number":264,"context_line":"        return self._get_vnf_lcm_subscription(vnf_lcm_subscriptions)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def show_lcm_op_occs(self, vnf_lcm_op_occs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a836276_430f00f4","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":25},"in_reply_to":"6abdb1dd_8268f31e","updated":"2021-03-19 09:19:11.000000000","message":"I\u0027ve confirmed.","commit_id":"e86585da51391ed4461a0886481c6b8613deab97"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d2a5dfcefc7a0aab1a691a55ce2e1ee0a0567b22","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                \u0027callbackUri\u0027: vnf_lcm_subscription.callback_uri,"},{"line_number":184,"context_line":"            }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # TODO(esto.aln): To remove list subscription related processing"},{"line_number":187,"context_line":"    # in vnf_lcm.py. Current processing for list subscription is in"},{"line_number":188,"context_line":"    # vnf_subscriptions.py."},{"line_number":189,"context_line":"    def _subscription_filter("},{"line_number":190,"context_line":"            self,"},{"line_number":191,"context_line":"            subscription_data,"}],"source_content_type":"text/x-python","patch_set":11,"id":"977b90fd_7a6f60ec","line":188,"range":{"start_line":186,"start_character":0,"end_line":188,"end_character":27},"updated":"2021-03-23 18:05:32.000000000","message":"I don\u0027t understand what is the TODO from the statement. Could you explain simply what should be done as TODO?","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bac48719a0b16d1f0986b9337915cf30d97081df","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                \u0027callbackUri\u0027: vnf_lcm_subscription.callback_uri,"},{"line_number":184,"context_line":"            }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # TODO(esto.aln): To remove list subscription related processing"},{"line_number":187,"context_line":"    # in vnf_lcm.py. Current processing for list subscription is in"},{"line_number":188,"context_line":"    # vnf_subscriptions.py."},{"line_number":189,"context_line":"    def _subscription_filter("},{"line_number":190,"context_line":"            self,"},{"line_number":191,"context_line":"            subscription_data,"}],"source_content_type":"text/x-python","patch_set":11,"id":"76c51bf2_b58c4f36","line":188,"range":{"start_line":186,"start_character":0,"end_line":188,"end_character":27},"in_reply_to":"476fd541_3cf0b155","updated":"2021-03-26 05:01:00.000000000","message":"Done","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"29900d86fec19b28d49be3d184acfdc567d31ede","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                \u0027callbackUri\u0027: vnf_lcm_subscription.callback_uri,"},{"line_number":184,"context_line":"            }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # TODO(esto.aln): To remove list subscription related processing"},{"line_number":187,"context_line":"    # in vnf_lcm.py. Current processing for list subscription is in"},{"line_number":188,"context_line":"    # vnf_subscriptions.py."},{"line_number":189,"context_line":"    def _subscription_filter("},{"line_number":190,"context_line":"            self,"},{"line_number":191,"context_line":"            subscription_data,"}],"source_content_type":"text/x-python","patch_set":11,"id":"476fd541_3cf0b155","line":188,"range":{"start_line":186,"start_character":0,"end_line":188,"end_character":27},"in_reply_to":"977b90fd_7a6f60ec","updated":"2021-03-24 12:53:35.000000000","message":"\u003e I don\u0027t understand what is the TODO from the statement. Could you explain simply what should be done as TODO?\n\nModified TODO comment.","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"}],"tacker/api/views/vnf_subscriptions.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4e03367818645aff872e2d76073a0c071a17f5a1","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return subscription_response"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def subscription_list("},{"line_number":77,"context_line":"            self,"},{"line_number":78,"context_line":"            vnf_lcm_subscriptions):"},{"line_number":79,"context_line":"        return [self._get_subscription(subscription)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3b4e5f_4b87b123","line":76,"updated":"2021-02-22 09:43:02.000000000","message":"Why are you implementing this new \u0027api/views/vnf_subscriptions.py\u0027 instead of modifying the existing implementation of \u0027api/views/vnf_lcm.py\u0027?\nI think you should fix \u0027api/views/vnf_lcm.py\u0027.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18706b1bf3db844066a466f4327f640a41f589e2","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return subscription_response"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def subscription_list("},{"line_number":77,"context_line":"            self,"},{"line_number":78,"context_line":"            vnf_lcm_subscriptions):"},{"line_number":79,"context_line":"        return [self._get_subscription(subscription)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab1a54b_81ea89ee","line":76,"in_reply_to":"27a241b0_51fcf25a","updated":"2021-03-09 07:54:01.000000000","message":"\u003e I understand.\n\u003e I agree to separate it into \u0027vnf_subscriptions.py\u0027.\n\u003e However, I think there is already subscription related processing in\u0027vnf_lcm.py\u0027.\n\u003e I think it\u0027s not appropriate to fix it in this patch, so can you add a TODO description to \u0027vnf_lcm.py\u0027 in this patch?\n\nAdded TODO comment since this will not be fixed during this patch.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b9899f2bf2be23af531b37e631cafb9ff787b0c1","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return subscription_response"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def subscription_list("},{"line_number":77,"context_line":"            self,"},{"line_number":78,"context_line":"            vnf_lcm_subscriptions):"},{"line_number":79,"context_line":"        return [self._get_subscription(subscription)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfd28601_e8d3bcc4","line":76,"in_reply_to":"5a3b4e5f_4b87b123","updated":"2021-03-03 13:31:46.000000000","message":"\u003e Why are you implementing this new \u0027api/views/vnf_subscriptions.py\u0027 instead of modifying the existing implementation of \u0027api/views/vnf_lcm.py\u0027?\n\u003e I think you should fix \u0027api/views/vnf_lcm.py\u0027.\n\nIt is because in tacker/api/views/__init__.py, it uses cls.FLATTENED_ATTRIBUTES.\nThis is the basis to validate for filtering.\nThe way to set the variable is in tacker/api/views/vnf_lcm.py.\nHowever, in tacker/api/views/vnf_lcm.py, it is already set to VnfInstance,\nso if we use tacker/api/views/vnf_lcm.py in attribute_filtering.py,\nthe basis for validation becomes VnfInstance.\n\nThat\u0027s why it needs to separate Subscription so that validation will be for Subscription.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e1d4233b688f1c90f5e6799da9a3129ad611ff74","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return subscription_response"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def subscription_list("},{"line_number":77,"context_line":"            self,"},{"line_number":78,"context_line":"            vnf_lcm_subscriptions):"},{"line_number":79,"context_line":"        return [self._get_subscription(subscription)"}],"source_content_type":"text/x-python","patch_set":4,"id":"66fc7c9d_1a5e8954","line":76,"in_reply_to":"bab1a54b_81ea89ee","updated":"2021-03-19 09:19:11.000000000","message":"I\u0027ve confirmed.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"191d3f639729ee23d6ab7e9eb5a9a39643f00834","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        return subscription_response"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def subscription_list("},{"line_number":77,"context_line":"            self,"},{"line_number":78,"context_line":"            vnf_lcm_subscriptions):"},{"line_number":79,"context_line":"        return [self._get_subscription(subscription)"}],"source_content_type":"text/x-python","patch_set":4,"id":"27a241b0_51fcf25a","line":76,"in_reply_to":"dfd28601_e8d3bcc4","updated":"2021-03-04 03:17:55.000000000","message":"I understand.\nI agree to separate it into \u0027vnf_subscriptions.py\u0027.\nHowever, I think there is already subscription related processing in\u0027vnf_lcm.py\u0027.\nI think it\u0027s not appropriate to fix it in this patch, so can you add a TODO description to \u0027vnf_lcm.py\u0027 in this patch?","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d2a5dfcefc7a0aab1a691a55ce2e1ee0a0567b22","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tacker.api import views as base"},{"line_number":18,"context_line":"import tacker.conf"},{"line_number":19,"context_line":"from tacker.objects import vnf_lcm_subscriptions as _vnf_subscription"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d tacker.conf.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"96e5c174_10ffbdd5","line":19,"range":{"start_line":19,"start_character":52,"end_line":19,"end_character":53},"updated":"2021-03-23 18:05:32.000000000","message":"Could I confirm why it starts with `_`? You might define a variable starts with `_` as a local one, but it\u0027s not the case.","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bac48719a0b16d1f0986b9337915cf30d97081df","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tacker.api import views as base"},{"line_number":18,"context_line":"import tacker.conf"},{"line_number":19,"context_line":"from tacker.objects import vnf_lcm_subscriptions as _vnf_subscription"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d tacker.conf.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"207a9a92_ae3c23b9","line":19,"range":{"start_line":19,"start_character":52,"end_line":19,"end_character":53},"in_reply_to":"2b0eba24_3c346e1f","updated":"2021-03-26 05:01:00.000000000","message":"Done","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"29900d86fec19b28d49be3d184acfdc567d31ede","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tacker.api import views as base"},{"line_number":18,"context_line":"import tacker.conf"},{"line_number":19,"context_line":"from tacker.objects import vnf_lcm_subscriptions as _vnf_subscription"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"CONF \u003d tacker.conf.CONF"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"2b0eba24_3c346e1f","line":19,"range":{"start_line":19,"start_character":52,"end_line":19,"end_character":53},"in_reply_to":"96e5c174_10ffbdd5","updated":"2021-03-24 12:53:35.000000000","message":"\u003e Could I confirm why it starts with `_`? You might define a variable starts with `_` as a local one, but it\u0027s not the case.\n\nRemoved \"_\".","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d2a5dfcefc7a0aab1a691a55ce2e1ee0a0567b22","unresolved":true,"context_lines":[{"line_number":42,"context_line":"                        \"id\": decode_id}}}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _basic_subscription_info(self, vnf_lcm_subscription, filter\u003dNone):"},{"line_number":45,"context_line":"        if not filter:"},{"line_number":46,"context_line":"            if \u0027filter\u0027 in vnf_lcm_subscription:"},{"line_number":47,"context_line":"                filter_dict \u003d {}"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"d2f08c37_430a8446","line":45,"range":{"start_line":45,"start_character":11,"end_line":45,"end_character":21},"updated":"2021-03-23 18:05:32.000000000","message":"You should use `is None` if you check the value is None. Or, is there possibility that it can be False or so?","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bac48719a0b16d1f0986b9337915cf30d97081df","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                        \"id\": decode_id}}}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _basic_subscription_info(self, vnf_lcm_subscription, filter\u003dNone):"},{"line_number":45,"context_line":"        if not filter:"},{"line_number":46,"context_line":"            if \u0027filter\u0027 in vnf_lcm_subscription:"},{"line_number":47,"context_line":"                filter_dict \u003d {}"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"e1b8cca4_66b51527","line":45,"range":{"start_line":45,"start_character":11,"end_line":45,"end_character":21},"in_reply_to":"c1ac3755_486ae28d","updated":"2021-03-26 05:01:00.000000000","message":"Done","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"29900d86fec19b28d49be3d184acfdc567d31ede","unresolved":true,"context_lines":[{"line_number":42,"context_line":"                        \"id\": decode_id}}}}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def _basic_subscription_info(self, vnf_lcm_subscription, filter\u003dNone):"},{"line_number":45,"context_line":"        if not filter:"},{"line_number":46,"context_line":"            if \u0027filter\u0027 in vnf_lcm_subscription:"},{"line_number":47,"context_line":"                filter_dict \u003d {}"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"c1ac3755_486ae28d","line":45,"range":{"start_line":45,"start_character":11,"end_line":45,"end_character":21},"in_reply_to":"d2f08c37_430a8446","updated":"2021-03-24 12:53:35.000000000","message":"\u003e You should use `is None` if you check the value is None. Or, is there possibility that it can be False or so?\n\nChanged condition to \"if filter is None:\"","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0966ff8b18cb3a7df0ed979b676da48aa548c884","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class VnfLcmController(wsgi.Controller):"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    notification_type_list \u003d [\u0027VnfLcmOperationOccurrenceNotification\u0027,"},{"line_number":130,"context_line":"                          \u0027VnfIdentifierCreationNotification\u0027,"},{"line_number":131,"context_line":"                          \u0027VnfIdentifierDeletionNotification\u0027]"},{"line_number":132,"context_line":"    operation_type_list \u003d [\u0027INSTANTIATE\u0027,"},{"line_number":133,"context_line":"                       \u0027SCALE\u0027,"},{"line_number":134,"context_line":"                       \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":135,"context_line":"                       \u0027CHANGE_FLAVOUR\u0027,"},{"line_number":136,"context_line":"                       \u0027TERMINATE\u0027,"},{"line_number":137,"context_line":"                       \u0027HEAL\u0027,"},{"line_number":138,"context_line":"                       \u0027OPERATE\u0027,"},{"line_number":139,"context_line":"                       \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":140,"context_line":"                       \u0027MODIFY_INFO\u0027]"},{"line_number":141,"context_line":"    operation_state_list \u003d [\u0027STARTING\u0027,"},{"line_number":142,"context_line":"                        \u0027PROCESSING\u0027,"},{"line_number":143,"context_line":"                        \u0027COMPLETED\u0027,"},{"line_number":144,"context_line":"                        \u0027FAILED_TEMP\u0027,"},{"line_number":145,"context_line":"                        \u0027FAILED\u0027,"},{"line_number":146,"context_line":"                        \u0027ROLLING_BACK\u0027,"},{"line_number":147,"context_line":"                        \u0027ROLLED_BACK\u0027]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    _view_builder_class \u003d vnf_lcm_view.ViewBuilder"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"cffcf42c_25eb8798","line":147,"range":{"start_line":129,"start_character":4,"end_line":147,"end_character":38},"updated":"2021-03-12 08:33:58.000000000","message":"https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b19/774733/7/check/openstack-tox-cover/b19d3b6/cover/tacker_api_vnflcm_v1_controller_py.html#t916\n\nRegarding the modification contents from patchset6 to patchset7, I think that the reason why this problem could not be detected by unittest is that the test of L916 ~ 933 does not exist.\nCan you add unittest?","commit_id":"e86585da51391ed4461a0886481c6b8613deab97"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e1d4233b688f1c90f5e6799da9a3129ad611ff74","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class VnfLcmController(wsgi.Controller):"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    notification_type_list \u003d [\u0027VnfLcmOperationOccurrenceNotification\u0027,"},{"line_number":130,"context_line":"                          \u0027VnfIdentifierCreationNotification\u0027,"},{"line_number":131,"context_line":"                          \u0027VnfIdentifierDeletionNotification\u0027]"},{"line_number":132,"context_line":"    operation_type_list \u003d [\u0027INSTANTIATE\u0027,"},{"line_number":133,"context_line":"                       \u0027SCALE\u0027,"},{"line_number":134,"context_line":"                       \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":135,"context_line":"                       \u0027CHANGE_FLAVOUR\u0027,"},{"line_number":136,"context_line":"                       \u0027TERMINATE\u0027,"},{"line_number":137,"context_line":"                       \u0027HEAL\u0027,"},{"line_number":138,"context_line":"                       \u0027OPERATE\u0027,"},{"line_number":139,"context_line":"                       \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":140,"context_line":"                       \u0027MODIFY_INFO\u0027]"},{"line_number":141,"context_line":"    operation_state_list \u003d [\u0027STARTING\u0027,"},{"line_number":142,"context_line":"                        \u0027PROCESSING\u0027,"},{"line_number":143,"context_line":"                        \u0027COMPLETED\u0027,"},{"line_number":144,"context_line":"                        \u0027FAILED_TEMP\u0027,"},{"line_number":145,"context_line":"                        \u0027FAILED\u0027,"},{"line_number":146,"context_line":"                        \u0027ROLLING_BACK\u0027,"},{"line_number":147,"context_line":"                        \u0027ROLLED_BACK\u0027]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    _view_builder_class \u003d vnf_lcm_view.ViewBuilder"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e92fa2c2_e9a9336e","line":147,"range":{"start_line":129,"start_character":4,"end_line":147,"end_character":38},"in_reply_to":"6ca4ee8a_feb051f7","updated":"2021-03-19 09:19:11.000000000","message":"I\u0027ve confirmed.","commit_id":"e86585da51391ed4461a0886481c6b8613deab97"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"77bb788dd51cdd9a7ad7a675fd259c28fc5ddae4","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class VnfLcmController(wsgi.Controller):"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    notification_type_list \u003d [\u0027VnfLcmOperationOccurrenceNotification\u0027,"},{"line_number":130,"context_line":"                          \u0027VnfIdentifierCreationNotification\u0027,"},{"line_number":131,"context_line":"                          \u0027VnfIdentifierDeletionNotification\u0027]"},{"line_number":132,"context_line":"    operation_type_list \u003d [\u0027INSTANTIATE\u0027,"},{"line_number":133,"context_line":"                       \u0027SCALE\u0027,"},{"line_number":134,"context_line":"                       \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":135,"context_line":"                       \u0027CHANGE_FLAVOUR\u0027,"},{"line_number":136,"context_line":"                       \u0027TERMINATE\u0027,"},{"line_number":137,"context_line":"                       \u0027HEAL\u0027,"},{"line_number":138,"context_line":"                       \u0027OPERATE\u0027,"},{"line_number":139,"context_line":"                       \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":140,"context_line":"                       \u0027MODIFY_INFO\u0027]"},{"line_number":141,"context_line":"    operation_state_list \u003d [\u0027STARTING\u0027,"},{"line_number":142,"context_line":"                        \u0027PROCESSING\u0027,"},{"line_number":143,"context_line":"                        \u0027COMPLETED\u0027,"},{"line_number":144,"context_line":"                        \u0027FAILED_TEMP\u0027,"},{"line_number":145,"context_line":"                        \u0027FAILED\u0027,"},{"line_number":146,"context_line":"                        \u0027ROLLING_BACK\u0027,"},{"line_number":147,"context_line":"                        \u0027ROLLED_BACK\u0027]"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    _view_builder_class \u003d vnf_lcm_view.ViewBuilder"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6ca4ee8a_feb051f7","line":147,"range":{"start_line":129,"start_character":4,"end_line":147,"end_character":38},"in_reply_to":"cffcf42c_25eb8798","updated":"2021-03-17 03:47:22.000000000","message":"\u003e https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b19/774733/7/check/openstack-tox-cover/b19d3b6/cover/tacker_api_vnflcm_v1_controller_py.html#t916\n\u003e \n\u003e Regarding the modification contents from patchset6 to patchset7, I think that the reason why this problem could not be detected by unittest is that the test of L916 ~ 933 does not exist.\n\u003e Can you add unittest?\n\nAdded the test codes","commit_id":"e86585da51391ed4461a0886481c6b8613deab97"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d2a5dfcefc7a0aab1a691a55ce2e1ee0a0567b22","unresolved":true,"context_lines":[{"line_number":942,"context_line":"                                % filter_value)"},{"line_number":943,"context_line":"                            return self._make_problem_detail(msg, 400,"},{"line_number":944,"context_line":"                                title\u003d\u0027Bad Request\u0027)"},{"line_number":945,"context_line":"                    if filter_name \u003d\u003d \u0027operationTypes\u0027:"},{"line_number":946,"context_line":"                        if filter_value not in self.operation_type_list:"},{"line_number":947,"context_line":"                            msg \u003d (_(\"operationTypes value mismatch: %s\")"},{"line_number":948,"context_line":"                                % filter_value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9d76b19f_5d6671bd","line":945,"range":{"start_line":945,"start_character":20,"end_line":945,"end_character":22},"updated":"2021-03-23 18:05:32.000000000","message":"`elif` correctly?","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bac48719a0b16d1f0986b9337915cf30d97081df","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                % filter_value)"},{"line_number":943,"context_line":"                            return self._make_problem_detail(msg, 400,"},{"line_number":944,"context_line":"                                title\u003d\u0027Bad Request\u0027)"},{"line_number":945,"context_line":"                    if filter_name \u003d\u003d \u0027operationTypes\u0027:"},{"line_number":946,"context_line":"                        if filter_value not in self.operation_type_list:"},{"line_number":947,"context_line":"                            msg \u003d (_(\"operationTypes value mismatch: %s\")"},{"line_number":948,"context_line":"                                % filter_value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"070f4418_2c6f91b9","line":945,"range":{"start_line":945,"start_character":20,"end_line":945,"end_character":22},"in_reply_to":"2ddde4c3_022f8293","updated":"2021-03-26 05:01:00.000000000","message":"Done","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"29900d86fec19b28d49be3d184acfdc567d31ede","unresolved":true,"context_lines":[{"line_number":942,"context_line":"                                % filter_value)"},{"line_number":943,"context_line":"                            return self._make_problem_detail(msg, 400,"},{"line_number":944,"context_line":"                                title\u003d\u0027Bad Request\u0027)"},{"line_number":945,"context_line":"                    if filter_name \u003d\u003d \u0027operationTypes\u0027:"},{"line_number":946,"context_line":"                        if filter_value not in self.operation_type_list:"},{"line_number":947,"context_line":"                            msg \u003d (_(\"operationTypes value mismatch: %s\")"},{"line_number":948,"context_line":"                                % filter_value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"2ddde4c3_022f8293","line":945,"range":{"start_line":945,"start_character":20,"end_line":945,"end_character":22},"in_reply_to":"9d76b19f_5d6671bd","updated":"2021-03-24 12:53:35.000000000","message":"\u003e `elif` correctly?\n\nChanged \"if\" to \"elif\".","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d2a5dfcefc7a0aab1a691a55ce2e1ee0a0567b22","unresolved":true,"context_lines":[{"line_number":948,"context_line":"                                % filter_value)"},{"line_number":949,"context_line":"                            return self._make_problem_detail(msg, 400,"},{"line_number":950,"context_line":"                                title\u003d\u0027Bad Request\u0027)"},{"line_number":951,"context_line":"                    if filter_name \u003d\u003d \u0027operationStates\u0027:"},{"line_number":952,"context_line":"                        if filter_value not in self.operation_state_list:"},{"line_number":953,"context_line":"                            msg \u003d (_(\"operationStates value mismatch: %s\")"},{"line_number":954,"context_line":"                                % filter_value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"313e3480_f1680d86","line":951,"range":{"start_line":951,"start_character":20,"end_line":951,"end_character":22},"updated":"2021-03-23 18:05:32.000000000","message":"ditto","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"29900d86fec19b28d49be3d184acfdc567d31ede","unresolved":true,"context_lines":[{"line_number":948,"context_line":"                                % filter_value)"},{"line_number":949,"context_line":"                            return self._make_problem_detail(msg, 400,"},{"line_number":950,"context_line":"                                title\u003d\u0027Bad Request\u0027)"},{"line_number":951,"context_line":"                    if filter_name \u003d\u003d \u0027operationStates\u0027:"},{"line_number":952,"context_line":"                        if filter_value not in self.operation_state_list:"},{"line_number":953,"context_line":"                            msg \u003d (_(\"operationStates value mismatch: %s\")"},{"line_number":954,"context_line":"                                % filter_value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"53cd7858_2fe5b2bf","line":951,"range":{"start_line":951,"start_character":20,"end_line":951,"end_character":22},"in_reply_to":"313e3480_f1680d86","updated":"2021-03-24 12:53:35.000000000","message":"\u003e ditto\n\nChanged \"if\" to \"elif\".","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bac48719a0b16d1f0986b9337915cf30d97081df","unresolved":false,"context_lines":[{"line_number":948,"context_line":"                                % filter_value)"},{"line_number":949,"context_line":"                            return self._make_problem_detail(msg, 400,"},{"line_number":950,"context_line":"                                title\u003d\u0027Bad Request\u0027)"},{"line_number":951,"context_line":"                    if filter_name \u003d\u003d \u0027operationStates\u0027:"},{"line_number":952,"context_line":"                        if filter_value not in self.operation_state_list:"},{"line_number":953,"context_line":"                            msg \u003d (_(\"operationStates value mismatch: %s\")"},{"line_number":954,"context_line":"                                % filter_value)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1bd523c4_573f1022","line":951,"range":{"start_line":951,"start_character":20,"end_line":951,"end_character":22},"in_reply_to":"53cd7858_2fe5b2bf","updated":"2021-03-26 05:01:00.000000000","message":"Done","commit_id":"4d2242375ef980b9fe5d89948d7829c15a4f75a3"}],"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4e03367818645aff872e2d76073a0c071a17f5a1","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # Subscription list filter 1"},{"line_number":260,"context_line":"        filter_expr \u003d {"},{"line_number":261,"context_line":"            \u0027filter\u0027: \"filter\u003d(eq,id,{})\".format(body.get(\u0027id\u0027))}"},{"line_number":262,"context_line":"        resp, subscription_body \u003d self._list_subscription_filter("},{"line_number":263,"context_line":"            params\u003dfilter_expr)"},{"line_number":264,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec0cc985_facf5e88","line":261,"range":{"start_line":261,"start_character":31,"end_line":261,"end_character":33},"updated":"2021-02-22 09:43:02.000000000","message":"I thought it would be better to be able to test with other operators as well as \u0027eq/neq/in\u0027, is that possible?\nFor example, \u0027gt\u0027, \u0027lt\u0027, \u0027gte\u0027, \u0027lte\u0027, \u0027nin\u0027, \u0027cont\u0027, \u0027ncont\u0027.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"191d3f639729ee23d6ab7e9eb5a9a39643f00834","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # Subscription list filter 1"},{"line_number":260,"context_line":"        filter_expr \u003d {"},{"line_number":261,"context_line":"            \u0027filter\u0027: \"filter\u003d(eq,id,{})\".format(body.get(\u0027id\u0027))}"},{"line_number":262,"context_line":"        resp, subscription_body \u003d self._list_subscription_filter("},{"line_number":263,"context_line":"            params\u003dfilter_expr)"},{"line_number":264,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6fce3c4c_174c874c","line":261,"range":{"start_line":261,"start_character":31,"end_line":261,"end_character":33},"in_reply_to":"0773d824_fc68a2c1","updated":"2021-03-04 03:17:55.000000000","message":"I\u0027ve confirmed your opinion.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"b9899f2bf2be23af531b37e631cafb9ff787b0c1","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        # Subscription list filter 1"},{"line_number":260,"context_line":"        filter_expr \u003d {"},{"line_number":261,"context_line":"            \u0027filter\u0027: \"filter\u003d(eq,id,{})\".format(body.get(\u0027id\u0027))}"},{"line_number":262,"context_line":"        resp, subscription_body \u003d self._list_subscription_filter("},{"line_number":263,"context_line":"            params\u003dfilter_expr)"},{"line_number":264,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0773d824_fc68a2c1","line":261,"range":{"start_line":261,"start_character":31,"end_line":261,"end_character":33},"in_reply_to":"ec0cc985_facf5e88","updated":"2021-03-03 13:31:46.000000000","message":"\u003e I thought it would be better to be able to test with other operators as well as \u0027eq/neq/in\u0027, is that possible?\n\u003e For example, \u0027gt\u0027, \u0027lt\u0027, \u0027gte\u0027, \u0027lte\u0027, \u0027nin\u0027, \u0027cont\u0027, \u0027ncont\u0027.\n\nSince we are diverting existing functions, we think that there is no point in increasing the number of patterns, so I think it is not necessary to change.","commit_id":"22fd6e0e59b04086653ccd4cfe5b6e01ffc15ae8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"7b47c83952e9a81d5e15c0f3bcc5a5371dec5c8a","unresolved":true,"context_lines":[{"line_number":301,"context_line":"            \u0027filter\u0027: \"filter\u003d(in,operationTypes,{})\".format(\"sample\")}"},{"line_number":302,"context_line":"        resp, subscription_body \u003d self._list_subscription_filter("},{"line_number":303,"context_line":"            params\u003dfilter_expr)"},{"line_number":304,"context_line":"        self.assertEqual(400, resp.status_code)"},{"line_number":305,"context_line":"        self.assertEqual(3, len(subscription_body))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        # Subscription list filter 6"}],"source_content_type":"text/x-python","patch_set":6,"id":"18ec9386_4a874390","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":47},"updated":"2021-03-11 10:27:57.000000000","message":"You have been rechecking several times, but this assert seems to have high error reproducibility.\nI think It\u0027s better to check your code for problems just in case.","commit_id":"e248418cb5486f650971ee0699c1dfe581fb66f8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"700486a0f27e18e20ffa84db15d746eda5ced80e","unresolved":true,"context_lines":[{"line_number":301,"context_line":"            \u0027filter\u0027: \"filter\u003d(in,operationTypes,{})\".format(\"sample\")}"},{"line_number":302,"context_line":"        resp, subscription_body \u003d self._list_subscription_filter("},{"line_number":303,"context_line":"            params\u003dfilter_expr)"},{"line_number":304,"context_line":"        self.assertEqual(400, resp.status_code)"},{"line_number":305,"context_line":"        self.assertEqual(3, len(subscription_body))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        # Subscription list filter 6"}],"source_content_type":"text/x-python","patch_set":6,"id":"3330eb09_76cd4ed7","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":47},"in_reply_to":"18ec9386_4a874390","updated":"2021-03-11 13:37:29.000000000","message":"\u003e You have been rechecking several times, but this assert seems to have high error reproducibility.\n\u003e I think It\u0027s better to check your code for problems just in case.\n\nYes, you are correct. We have already found the issue and fixed it in the patch recently uploaded.","commit_id":"e248418cb5486f650971ee0699c1dfe581fb66f8"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"3bd71d1d7dbbc583f4f62279b7ad29e554f98a8b","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            \u0027filter\u0027: \"filter\u003d(in,operationTypes,{})\".format(\"sample\")}"},{"line_number":302,"context_line":"        resp, subscription_body \u003d self._list_subscription_filter("},{"line_number":303,"context_line":"            params\u003dfilter_expr)"},{"line_number":304,"context_line":"        self.assertEqual(400, resp.status_code)"},{"line_number":305,"context_line":"        self.assertEqual(3, len(subscription_body))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        # Subscription list filter 6"}],"source_content_type":"text/x-python","patch_set":6,"id":"58b63c13_940a86e9","line":304,"range":{"start_line":304,"start_character":8,"end_line":304,"end_character":47},"in_reply_to":"3330eb09_76cd4ed7","updated":"2021-03-12 08:19:47.000000000","message":"I\u0027ve confirmed.","commit_id":"e248418cb5486f650971ee0699c1dfe581fb66f8"}]}