)]}'
{"tacker/tests/functional/sol_kubernetes/vnflcm/test_kubernetes_heal.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            \"PUT\", body\u003dfile_object, content_type\u003d\u0027application/zip\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # wait for onboard"},{"line_number":65,"context_line":"    timeout \u003d VNF_PACKAGE_UPLOAD_TIMEOUT"},{"line_number":66,"context_line":"    start_time \u003d int(time.time())"},{"line_number":67,"context_line":"    show_url \u003d os.path.join(\u0027/vnfpkgm/v1/vnf_packages\u0027, vnf_package[\u0027id\u0027])"},{"line_number":68,"context_line":"    vnfd_id \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"18ffcdb7_e6e9dc98","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":11},"updated":"2021-03-20 08:22:18.000000000","message":"It looks need to define it.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1d842eb51aef1433be0bdd69fdbce72d59af978a","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            \"PUT\", body\u003dfile_object, content_type\u003d\u0027application/zip\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # wait for onboard"},{"line_number":65,"context_line":"    timeout \u003d VNF_PACKAGE_UPLOAD_TIMEOUT"},{"line_number":66,"context_line":"    start_time \u003d int(time.time())"},{"line_number":67,"context_line":"    show_url \u003d os.path.join(\u0027/vnfpkgm/v1/vnf_packages\u0027, vnf_package[\u0027id\u0027])"},{"line_number":68,"context_line":"    vnfd_id \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"d64ef9e0_f0318731","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":11},"in_reply_to":"18ffcdb7_e6e9dc98","updated":"2021-03-22 06:06:48.000000000","message":"Sorry, may I check the details of this comment?\n\nIsn\u0027t it mistaken for \"no need to define\"?\nIf yes, I will delete this line and change to VNF_PACKAGE_UPLOAD_TIMEOUT from timeout at L.75.\nIf no, could you tell me how to fix it.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            \"PUT\", body\u003dfile_object, content_type\u003d\u0027application/zip\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # wait for onboard"},{"line_number":65,"context_line":"    timeout \u003d VNF_PACKAGE_UPLOAD_TIMEOUT"},{"line_number":66,"context_line":"    start_time \u003d int(time.time())"},{"line_number":67,"context_line":"    show_url \u003d os.path.join(\u0027/vnfpkgm/v1/vnf_packages\u0027, vnf_package[\u0027id\u0027])"},{"line_number":68,"context_line":"    vnfd_id \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"ccb78d8d_bafd7aa0","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":11},"in_reply_to":"bc8606f0_5705f27e","updated":"2021-03-23 04:04:58.000000000","message":"Thanks for reply,\nI deleted definition of timeout and replaced the variables below.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"06a89cb13c0a65baf3b6863b839e97a7abb4f50b","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            \"PUT\", body\u003dfile_object, content_type\u003d\u0027application/zip\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    # wait for onboard"},{"line_number":65,"context_line":"    timeout \u003d VNF_PACKAGE_UPLOAD_TIMEOUT"},{"line_number":66,"context_line":"    start_time \u003d int(time.time())"},{"line_number":67,"context_line":"    show_url \u003d os.path.join(\u0027/vnfpkgm/v1/vnf_packages\u0027, vnf_package[\u0027id\u0027])"},{"line_number":68,"context_line":"    vnfd_id \u003d None"}],"source_content_type":"text/x-python","patch_set":10,"id":"bc8606f0_5705f27e","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":11},"in_reply_to":"d64ef9e0_f0318731","updated":"2021-03-22 07:25:10.000000000","message":"Yes.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            break"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if ((int(time.time()) - start_time) \u003e timeout):"},{"line_number":76,"context_line":"            raise Exception(\"Failed to onboard vnf package\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        time.sleep(1)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"e6351de8_45c12770","line":76,"range":{"start_line":76,"start_character":29,"end_line":76,"end_character":58},"updated":"2021-03-20 08:22:18.000000000","message":"You should explain the situation more correctly. It\u0027s not clear just saying \u0027failed\u0027, but it cannot complete the procedure in VNF_PACKAGE_UPLOAD_TIMEOUT sec actually.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":73,"context_line":"            break"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if ((int(time.time()) - start_time) \u003e timeout):"},{"line_number":76,"context_line":"            raise Exception(\"Failed to onboard vnf package\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        time.sleep(1)"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"56aad57c_073ea900","line":76,"range":{"start_line":76,"start_character":29,"end_line":76,"end_character":58},"in_reply_to":"e6351de8_45c12770","updated":"2021-03-23 04:04:58.000000000","message":"Done.\nI\u0027ve also fixed other similar parts.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        if ((int(time.time()) - start_time) \u003e timeout):"},{"line_number":76,"context_line":"            raise Exception(\"Failed to onboard vnf package\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        time.sleep(1)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # remove temporarily created CSAR file"},{"line_number":81,"context_line":"    os.remove(file_path)"}],"source_content_type":"text/x-python","patch_set":10,"id":"aa10a3ca_4c2f84b2","line":78,"range":{"start_line":78,"start_character":19,"end_line":78,"end_character":20},"updated":"2021-03-20 08:22:18.000000000","message":"Why it\u0027s not RETRY_WAIT_TIME?","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        if ((int(time.time()) - start_time) \u003e timeout):"},{"line_number":76,"context_line":"            raise Exception(\"Failed to onboard vnf package\")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        time.sleep(1)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # remove temporarily created CSAR file"},{"line_number":81,"context_line":"    os.remove(file_path)"}],"source_content_type":"text/x-python","patch_set":10,"id":"76decd77_3db90629","line":78,"range":{"start_line":78,"start_character":19,"end_line":78,"end_character":20},"in_reply_to":"aa10a3ca_4c2f84b2","updated":"2021-03-23 04:04:58.000000000","message":"I revised to `RETRY_WAIT_TIME`.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _delete_wait_vnf_instance(tacker_client, id):"},{"line_number":86,"context_line":"    timeout \u003d VNF_TERMINATE_TIMEOUT"},{"line_number":87,"context_line":"    url \u003d os.path.join(\"/vnflcm/v1/vnf_instances\", id)"},{"line_number":88,"context_line":"    start_time \u003d int(time.time())"},{"line_number":89,"context_line":"    while True:"}],"source_content_type":"text/x-python","patch_set":10,"id":"e02082ea_eaea1c8a","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":11},"updated":"2021-03-20 08:22:18.000000000","message":"ditto","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _delete_wait_vnf_instance(tacker_client, id):"},{"line_number":86,"context_line":"    timeout \u003d VNF_TERMINATE_TIMEOUT"},{"line_number":87,"context_line":"    url \u003d os.path.join(\"/vnflcm/v1/vnf_instances\", id)"},{"line_number":88,"context_line":"    start_time \u003d int(time.time())"},{"line_number":89,"context_line":"    while True:"}],"source_content_type":"text/x-python","patch_set":10,"id":"2efc0122_bd727bc2","line":86,"range":{"start_line":86,"start_character":4,"end_line":86,"end_character":11},"in_reply_to":"e02082ea_eaea1c8a","updated":"2021-03-23 04:04:58.000000000","message":"Done","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":281,"context_line":"    def _wait_vnflcm_op_occs("},{"line_number":282,"context_line":"            self, context, vnf_instance_id,"},{"line_number":283,"context_line":"            operation_state\u003d\u0027COMPLETED\u0027):"},{"line_number":284,"context_line":"        timeout \u003d VNF_HEAL_TIMEOUT"},{"line_number":285,"context_line":"        start_time \u003d int(time.time())"},{"line_number":286,"context_line":"        while True:"},{"line_number":287,"context_line":"            vnflcm_op_occ \u003d self._vnf_notify_get_by_id("}],"source_content_type":"text/x-python","patch_set":10,"id":"4dfd281b_e9782cd0","line":284,"range":{"start_line":284,"start_character":8,"end_line":284,"end_character":15},"updated":"2021-03-20 08:22:18.000000000","message":"ditto","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":281,"context_line":"    def _wait_vnflcm_op_occs("},{"line_number":282,"context_line":"            self, context, vnf_instance_id,"},{"line_number":283,"context_line":"            operation_state\u003d\u0027COMPLETED\u0027):"},{"line_number":284,"context_line":"        timeout \u003d VNF_HEAL_TIMEOUT"},{"line_number":285,"context_line":"        start_time \u003d int(time.time())"},{"line_number":286,"context_line":"        while True:"},{"line_number":287,"context_line":"            vnflcm_op_occ \u003d self._vnf_notify_get_by_id("}],"source_content_type":"text/x-python","patch_set":10,"id":"4841a800_5e81a4bc","line":284,"range":{"start_line":284,"start_character":8,"end_line":284,"end_character":15},"in_reply_to":"4dfd281b_e9782cd0","updated":"2021-03-23 04:04:58.000000000","message":"Done","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":300,"context_line":"        vnfc_resource_info \u003d inst_vnf_info[\u0027vnfcResourceInfo\u0027]"},{"line_number":301,"context_line":"        return vnfc_resource_info"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def test_heal_cnf_with_sol002(self):"},{"line_number":304,"context_line":"        # use def-files of singleton Pod and Deployment (replicas\u003d2)"},{"line_number":305,"context_line":"        inst_additional_param \u003d {"},{"line_number":306,"context_line":"            \"lcm-kubernetes-def-files\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"86bc3939_a7fdf056","line":303,"updated":"2021-03-20 08:22:18.000000000","message":"Why don\u0027t you add your test scenario here? What is tested, or how it goes.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":300,"context_line":"        vnfc_resource_info \u003d inst_vnf_info[\u0027vnfcResourceInfo\u0027]"},{"line_number":301,"context_line":"        return vnfc_resource_info"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def test_heal_cnf_with_sol002(self):"},{"line_number":304,"context_line":"        # use def-files of singleton Pod and Deployment (replicas\u003d2)"},{"line_number":305,"context_line":"        inst_additional_param \u003d {"},{"line_number":306,"context_line":"            \"lcm-kubernetes-def-files\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"cd2fe4c0_f63314b5","line":303,"in_reply_to":"86bc3939_a7fdf056","updated":"2021-03-23 04:04:58.000000000","message":"I added overview of test scenario.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":359,"context_line":"        self._terminate_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":360,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def test_heal_cnf_with_sol003(self):"},{"line_number":363,"context_line":"        # use def-files of Deployment (replicas\u003d2)"},{"line_number":364,"context_line":"        inst_additional_param \u003d {"},{"line_number":365,"context_line":"            \"lcm-kubernetes-def-files\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"669caee6_3fb512b7","line":362,"updated":"2021-03-20 08:22:18.000000000","message":"Why don\u0027t you add your test scenario here?","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":359,"context_line":"        self._terminate_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":360,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def test_heal_cnf_with_sol003(self):"},{"line_number":363,"context_line":"        # use def-files of Deployment (replicas\u003d2)"},{"line_number":364,"context_line":"        inst_additional_param \u003d {"},{"line_number":365,"context_line":"            \"lcm-kubernetes-def-files\": ["}],"source_content_type":"text/x-python","patch_set":10,"id":"0f9bbaf7_710e92e2","line":362,"in_reply_to":"669caee6_3fb512b7","updated":"2021-03-23 04:04:58.000000000","message":"I added overview of test scenario.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        # get vnfc_instance_id of heal target"},{"line_number":372,"context_line":"        before_vnfc_ids \u003d []"},{"line_number":373,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":374,"context_line":"            # compute_resource \u003d vnfc_rsc[\u0027computeResource\u0027]"},{"line_number":375,"context_line":"            # rsc_kind \u003d compute_resource[\u0027vimLevelResourceType\u0027]"},{"line_number":376,"context_line":"            before_vnfc_ids.append(vnfc_rsc[\u0027id\u0027])"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        # test heal SOL-003 (entire heal)"}],"source_content_type":"text/x-python","patch_set":10,"id":"a9554d60_a0066a90","line":375,"range":{"start_line":374,"start_character":0,"end_line":375,"end_character":65},"updated":"2021-03-20 08:22:18.000000000","message":"Why you don\u0027t remove it?","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        # get vnfc_instance_id of heal target"},{"line_number":372,"context_line":"        before_vnfc_ids \u003d []"},{"line_number":373,"context_line":"        for vnfc_rsc in before_vnfc_rscs:"},{"line_number":374,"context_line":"            # compute_resource \u003d vnfc_rsc[\u0027computeResource\u0027]"},{"line_number":375,"context_line":"            # rsc_kind \u003d compute_resource[\u0027vimLevelResourceType\u0027]"},{"line_number":376,"context_line":"            before_vnfc_ids.append(vnfc_rsc[\u0027id\u0027])"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        # test heal SOL-003 (entire heal)"}],"source_content_type":"text/x-python","patch_set":10,"id":"0fa73e8b_68055e45","line":375,"range":{"start_line":374,"start_character":0,"end_line":375,"end_character":65},"in_reply_to":"a9554d60_a0066a90","updated":"2021-03-23 04:04:58.000000000","message":"I\u0027m sorry, I left the implementation of this part unfinished.\nAdded new assert processing below.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"}],"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6e1558afd892195c8e86a14d9eb79812756ebe4e","unresolved":true,"context_lines":[{"line_number":1678,"context_line":"            core_v1_api_client \u003d self.kubernetes.get_core_v1_api_client("},{"line_number":1679,"context_line":"                auth\u003dauth_cred)"},{"line_number":1680,"context_line":"            # get vnfc_resource_info list for healing"},{"line_number":1681,"context_line":"            vnfc_resources \u003d self._get_vnfc_resources_from_heal_request("},{"line_number":1682,"context_line":"                inst_vnf_info\u003dinst_vnf_info,"},{"line_number":1683,"context_line":"                heal_vnf_request\u003dheal_vnf_request"},{"line_number":1684,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":8,"id":"83a3551f_555662da","line":1681,"range":{"start_line":1681,"start_character":34,"end_line":1681,"end_character":71},"updated":"2021-03-06 12:02:35.000000000","message":"It seems better to name this method to be ``_get_vnfc_resources_with_vnfc_instance_id`` because vnfc_resources are stored not in heal_request but in instantiated_vnf_info and it\u0027s gotten with vnfc_instance_id.","commit_id":"ea5cffd0ab5f885bddbe5e299ca86f860d3dddf3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ec4cd9056223127f88785b7b9cf697d1252d4518","unresolved":true,"context_lines":[{"line_number":1678,"context_line":"            core_v1_api_client \u003d self.kubernetes.get_core_v1_api_client("},{"line_number":1679,"context_line":"                auth\u003dauth_cred)"},{"line_number":1680,"context_line":"            # get vnfc_resource_info list for healing"},{"line_number":1681,"context_line":"            vnfc_resources \u003d self._get_vnfc_resources_from_heal_request("},{"line_number":1682,"context_line":"                inst_vnf_info\u003dinst_vnf_info,"},{"line_number":1683,"context_line":"                heal_vnf_request\u003dheal_vnf_request"},{"line_number":1684,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":8,"id":"028e61db_61c8f585","line":1681,"range":{"start_line":1681,"start_character":34,"end_line":1681,"end_character":71},"in_reply_to":"83a3551f_555662da","updated":"2021-03-08 06:21:27.000000000","message":"Thanks for the suggestion!\nThis method name was imported from the openstack driver [1].\nI changed the method name to your suggested name.\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/openstack/openstack.py#L1114-L1124","commit_id":"ea5cffd0ab5f885bddbe5e299ca86f860d3dddf3"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6e1558afd892195c8e86a14d9eb79812756ebe4e","unresolved":true,"context_lines":[{"line_number":1682,"context_line":"                inst_vnf_info\u003dinst_vnf_info,"},{"line_number":1683,"context_line":"                heal_vnf_request\u003dheal_vnf_request"},{"line_number":1684,"context_line":"            )"},{"line_number":1685,"context_line":"            # Update vnfcResourceInfo before heal operation"},{"line_number":1686,"context_line":"            updated_vdu_ids \u003d []"},{"line_number":1687,"context_line":"            pod_list_dict \u003d {}"},{"line_number":1688,"context_line":"            for vnfc_resource in vnfc_resources:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1e456275_ca94ba7a","line":1685,"range":{"start_line":1685,"start_character":12,"end_line":1685,"end_character":59},"updated":"2021-03-06 12:02:35.000000000","message":"I understand this block updates resource_id in vnfc_resource_info which are not the target of healing because they may have been re-created by kubelet of Kubernetes automatically and their resource_id have been already changed.\n\nCan you add a note to explain why this logic is needed? It seems to be hard to follow.","commit_id":"ea5cffd0ab5f885bddbe5e299ca86f860d3dddf3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ec4cd9056223127f88785b7b9cf697d1252d4518","unresolved":true,"context_lines":[{"line_number":1682,"context_line":"                inst_vnf_info\u003dinst_vnf_info,"},{"line_number":1683,"context_line":"                heal_vnf_request\u003dheal_vnf_request"},{"line_number":1684,"context_line":"            )"},{"line_number":1685,"context_line":"            # Update vnfcResourceInfo before heal operation"},{"line_number":1686,"context_line":"            updated_vdu_ids \u003d []"},{"line_number":1687,"context_line":"            pod_list_dict \u003d {}"},{"line_number":1688,"context_line":"            for vnfc_resource in vnfc_resources:"}],"source_content_type":"text/x-python","patch_set":8,"id":"115e90bb_79e23abd","line":1685,"range":{"start_line":1685,"start_character":12,"end_line":1685,"end_character":59},"in_reply_to":"1e456275_ca94ba7a","updated":"2021-03-08 06:21:27.000000000","message":"Done","commit_id":"ea5cffd0ab5f885bddbe5e299ca86f860d3dddf3"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6e1558afd892195c8e86a14d9eb79812756ebe4e","unresolved":true,"context_lines":[{"line_number":2034,"context_line":"                    vdu_properties \u003d vdu_def.get(\u0027properties\u0027)"},{"line_number":2035,"context_line":"                    if rsc_name \u003d\u003d vdu_properties.get(\u0027name\u0027):"},{"line_number":2036,"context_line":"                        is_found \u003d True"},{"line_number":2037,"context_line":"                        namespace \u003d vnf_resource.resource_name.split(\u0027,\u0027)[0]"},{"line_number":2038,"context_line":"                        rsc_kind \u003d vnf_resource.resource_type.split(\u0027,\u0027)[1]"},{"line_number":2039,"context_line":"                        target_vdu_id \u003d vdu_id"},{"line_number":2040,"context_line":"                        break"},{"line_number":2041,"context_line":"                if is_found:"}],"source_content_type":"text/x-python","patch_set":8,"id":"b5638650_53dc3ce7","line":2038,"range":{"start_line":2037,"start_character":24,"end_line":2038,"end_character":75},"updated":"2021-03-06 12:02:35.000000000","message":"Is it possible to add a note to explain the naming rule of ``vnf_resource.resource_name`` and ``vnf_resource.resource_type``?","commit_id":"ea5cffd0ab5f885bddbe5e299ca86f860d3dddf3"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ec4cd9056223127f88785b7b9cf697d1252d4518","unresolved":true,"context_lines":[{"line_number":2034,"context_line":"                    vdu_properties \u003d vdu_def.get(\u0027properties\u0027)"},{"line_number":2035,"context_line":"                    if rsc_name \u003d\u003d vdu_properties.get(\u0027name\u0027):"},{"line_number":2036,"context_line":"                        is_found \u003d True"},{"line_number":2037,"context_line":"                        namespace \u003d vnf_resource.resource_name.split(\u0027,\u0027)[0]"},{"line_number":2038,"context_line":"                        rsc_kind \u003d vnf_resource.resource_type.split(\u0027,\u0027)[1]"},{"line_number":2039,"context_line":"                        target_vdu_id \u003d vdu_id"},{"line_number":2040,"context_line":"                        break"},{"line_number":2041,"context_line":"                if is_found:"}],"source_content_type":"text/x-python","patch_set":8,"id":"c24b205a_1e822207","line":2038,"range":{"start_line":2037,"start_character":24,"end_line":2038,"end_character":75},"in_reply_to":"b5638650_53dc3ce7","updated":"2021-03-08 06:21:27.000000000","message":"Done","commit_id":"ea5cffd0ab5f885bddbe5e299ca86f860d3dddf3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":1529,"context_line":"            return resource_info_str"},{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"    def post_vnf_instantiation(self, context, vnf_instance,"},{"line_number":1532,"context_line":"                               vim_connection_info, instantiate_vnf_req):"},{"line_number":1533,"context_line":"        auth_attr \u003d vim_connection_info.access_info"},{"line_number":1534,"context_line":"        auth_cred, file_descriptor \u003d self._get_auth_creds(auth_attr)"},{"line_number":1535,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"f496d9f2_13e5b11c","line":1532,"updated":"2021-03-20 08:22:18.000000000","message":"Why don\u0027t you add a description SHORTLY as docstring for what is done in the post operation?","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":1529,"context_line":"            return resource_info_str"},{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"    def post_vnf_instantiation(self, context, vnf_instance,"},{"line_number":1532,"context_line":"                               vim_connection_info, instantiate_vnf_req):"},{"line_number":1533,"context_line":"        auth_attr \u003d vim_connection_info.access_info"},{"line_number":1534,"context_line":"        auth_cred, file_descriptor \u003d self._get_auth_creds(auth_attr)"},{"line_number":1535,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9b66f03d_c5243a54","line":1532,"in_reply_to":"f496d9f2_13e5b11c","updated":"2021-03-23 04:04:58.000000000","message":"Done. I added description.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":1541,"context_line":"            transformer \u003d translate_outputs.Transformer("},{"line_number":1542,"context_line":"                None, None, None, None)"},{"line_number":1543,"context_line":"            # get Kubernetes object"},{"line_number":1544,"context_line":"            k8s_objs \u003d transformer.\\"},{"line_number":1545,"context_line":"                get_k8s_objs_from_yaml(target_k8s_files, vnf_package_path)"},{"line_number":1546,"context_line":"            # get TOSCA node templates"},{"line_number":1547,"context_line":"            vnfd_dict \u003d vnflcm_utils._get_vnfd_dict("}],"source_content_type":"text/x-python","patch_set":10,"id":"8cc19ad8_1e815e8d","line":1544,"range":{"start_line":1544,"start_character":35,"end_line":1544,"end_character":36},"updated":"2021-03-20 08:22:18.000000000","message":"There are many backslashes you don\u0027t need to use actually. We don\u0027t need to be so serious, but should follow style guides as possible.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":1541,"context_line":"            transformer \u003d translate_outputs.Transformer("},{"line_number":1542,"context_line":"                None, None, None, None)"},{"line_number":1543,"context_line":"            # get Kubernetes object"},{"line_number":1544,"context_line":"            k8s_objs \u003d transformer.\\"},{"line_number":1545,"context_line":"                get_k8s_objs_from_yaml(target_k8s_files, vnf_package_path)"},{"line_number":1546,"context_line":"            # get TOSCA node templates"},{"line_number":1547,"context_line":"            vnfd_dict \u003d vnflcm_utils._get_vnfd_dict("}],"source_content_type":"text/x-python","patch_set":10,"id":"98a23a32_7f063bf7","line":1544,"range":{"start_line":1544,"start_character":35,"end_line":1544,"end_character":36},"in_reply_to":"8cc19ad8_1e815e8d","updated":"2021-03-23 04:04:58.000000000","message":"Done.\nI also fixed other parts that use backslash.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":1615,"context_line":"        finally:"},{"line_number":1616,"context_line":"            self.clean_authenticate_vim(auth_cred, file_descriptor)"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"    def _get_vnfc_resources_with_vnfc_instance_id(self, inst_vnf_info,"},{"line_number":1619,"context_line":"                                                  heal_vnf_request):"},{"line_number":1620,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1621,"context_line":"            # include all vnfc resources"}],"source_content_type":"text/x-python","patch_set":10,"id":"4e15b6ac_5f7205c3","line":1618,"updated":"2021-03-20 08:22:18.000000000","message":"Can you make it shorter? It\u0027s just a private function, so doesn\u0027t need to have such a strict name.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":1615,"context_line":"        finally:"},{"line_number":1616,"context_line":"            self.clean_authenticate_vim(auth_cred, file_descriptor)"},{"line_number":1617,"context_line":""},{"line_number":1618,"context_line":"    def _get_vnfc_resources_with_vnfc_instance_id(self, inst_vnf_info,"},{"line_number":1619,"context_line":"                                                  heal_vnf_request):"},{"line_number":1620,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1621,"context_line":"            # include all vnfc resources"}],"source_content_type":"text/x-python","patch_set":10,"id":"0e93fe1b_6baa3cae","line":1618,"in_reply_to":"4e15b6ac_5f7205c3","updated":"2021-03-23 04:04:58.000000000","message":"Done. I changed　the method name to `_get_vnfc_rscs_with_vnfc_id` to make it shorter.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":1704,"context_line":"                        # Updated vnfcResourceInfo of the same vdu_id other"},{"line_number":1705,"context_line":"                        # than heal target"},{"line_number":1706,"context_line":"                        if (vnfc_rsc.id not in heal_target_ids) and\\"},{"line_number":1707,"context_line":"                           (vdu_id \u003d\u003d vnfc_rsc.vdu_id) and\\"},{"line_number":1708,"context_line":"                           (stored_pod_name not in actual_pod_names):"},{"line_number":1709,"context_line":"                            pod_name \u003d added_pod_names.pop()"},{"line_number":1710,"context_line":"                            vnfc_rsc.compute_resource.resource_id \u003d pod_name"},{"line_number":1711,"context_line":"                            LOG.warning(\"Update resource_id before healing,\""}],"source_content_type":"text/x-python","patch_set":10,"id":"84c4b428_1f5bbbcd","line":1708,"range":{"start_line":1707,"start_character":0,"end_line":1708,"end_character":69},"updated":"2021-03-20 08:22:18.000000000","message":"It\u0027s not a mistake, but better to indent one more level for easy to understand.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":1704,"context_line":"                        # Updated vnfcResourceInfo of the same vdu_id other"},{"line_number":1705,"context_line":"                        # than heal target"},{"line_number":1706,"context_line":"                        if (vnfc_rsc.id not in heal_target_ids) and\\"},{"line_number":1707,"context_line":"                           (vdu_id \u003d\u003d vnfc_rsc.vdu_id) and\\"},{"line_number":1708,"context_line":"                           (stored_pod_name not in actual_pod_names):"},{"line_number":1709,"context_line":"                            pod_name \u003d added_pod_names.pop()"},{"line_number":1710,"context_line":"                            vnfc_rsc.compute_resource.resource_id \u003d pod_name"},{"line_number":1711,"context_line":"                            LOG.warning(\"Update resource_id before healing,\""}],"source_content_type":"text/x-python","patch_set":10,"id":"a79b2c89_a96fde37","line":1708,"range":{"start_line":1707,"start_character":0,"end_line":1708,"end_character":69},"in_reply_to":"84c4b428_1f5bbbcd","updated":"2021-03-23 04:04:58.000000000","message":"Done.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":1742,"context_line":"                        body\u003dbody"},{"line_number":1743,"context_line":"                    )"},{"line_number":1744,"context_line":"                    # Check and wait that the Pod is deleted"},{"line_number":1745,"context_line":"                    stack_retries \u003d self.STACK_RETRIES"},{"line_number":1746,"context_line":"                    while stack_retries \u003e 0:"},{"line_number":1747,"context_line":"                        try:"},{"line_number":1748,"context_line":"                            core_v1_api_client.read_namespaced_pod("},{"line_number":1749,"context_line":"                                namespace\u003dnamespace,"}],"source_content_type":"text/x-python","patch_set":10,"id":"932930bd_2f697c65","line":1746,"range":{"start_line":1745,"start_character":0,"end_line":1746,"end_character":44},"updated":"2021-03-20 08:22:18.000000000","message":"It may look smarter, but it\u0027s better to use `for cnt in range(self.STACK_RETRIES)` to avoid infinite loop because of removing `stack_retries \u003d stack_retries - 1` mistakenly. It sometimes happens unexpectedly.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":1742,"context_line":"                        body\u003dbody"},{"line_number":1743,"context_line":"                    )"},{"line_number":1744,"context_line":"                    # Check and wait that the Pod is deleted"},{"line_number":1745,"context_line":"                    stack_retries \u003d self.STACK_RETRIES"},{"line_number":1746,"context_line":"                    while stack_retries \u003e 0:"},{"line_number":1747,"context_line":"                        try:"},{"line_number":1748,"context_line":"                            core_v1_api_client.read_namespaced_pod("},{"line_number":1749,"context_line":"                                namespace\u003dnamespace,"}],"source_content_type":"text/x-python","patch_set":10,"id":"adc96ab0_4263dd5c","line":1746,"range":{"start_line":1745,"start_character":0,"end_line":1746,"end_character":44},"in_reply_to":"932930bd_2f697c65","updated":"2021-03-23 04:04:58.000000000","message":"Thanks for suggestion, I changed to use `for cnt in range(self.STACK_RETRIES)`.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"                    # Number of retries exceeded retry count"},{"line_number":1767,"context_line":"                    if stack_retries \u003d\u003d 0:"},{"line_number":1768,"context_line":"                        error_reason \u003d _(\"Resource healing is not\""},{"line_number":1769,"context_line":"                                         \" completed within\""},{"line_number":1770,"context_line":"                                         \" {wait} seconds\").format("},{"line_number":1771,"context_line":"                            wait\u003d(self.STACK_RETRIES *"},{"line_number":1772,"context_line":"                                  self.STACK_RETRY_WAIT)"},{"line_number":1773,"context_line":"                        )"},{"line_number":1774,"context_line":"                        LOG.error(\"CNF Healing failed: %(reason)s\","},{"line_number":1775,"context_line":"                                  {\u0027reason\u0027: error_reason})"},{"line_number":1776,"context_line":"                        raise vnfm.CNFHealFailed(reason\u003derror_reason)"}],"source_content_type":"text/x-python","patch_set":10,"id":"375818f7_806bbe20","line":1773,"range":{"start_line":1768,"start_character":0,"end_line":1773,"end_character":25},"updated":"2021-03-20 08:22:18.000000000","message":"It looks no need to be six lines, possible to be shorter.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"                    # Number of retries exceeded retry count"},{"line_number":1767,"context_line":"                    if stack_retries \u003d\u003d 0:"},{"line_number":1768,"context_line":"                        error_reason \u003d _(\"Resource healing is not\""},{"line_number":1769,"context_line":"                                         \" completed within\""},{"line_number":1770,"context_line":"                                         \" {wait} seconds\").format("},{"line_number":1771,"context_line":"                            wait\u003d(self.STACK_RETRIES *"},{"line_number":1772,"context_line":"                                  self.STACK_RETRY_WAIT)"},{"line_number":1773,"context_line":"                        )"},{"line_number":1774,"context_line":"                        LOG.error(\"CNF Healing failed: %(reason)s\","},{"line_number":1775,"context_line":"                                  {\u0027reason\u0027: error_reason})"},{"line_number":1776,"context_line":"                        raise vnfm.CNFHealFailed(reason\u003derror_reason)"}],"source_content_type":"text/x-python","patch_set":10,"id":"53aacf30_776fc44c","line":1773,"range":{"start_line":1768,"start_character":0,"end_line":1773,"end_character":25},"in_reply_to":"375818f7_806bbe20","updated":"2021-03-23 04:04:58.000000000","message":"Done.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":1784,"context_line":"                        namespace\u003dnamespace,"},{"line_number":1785,"context_line":"                        body\u003dbody"},{"line_number":1786,"context_line":"                    )"},{"line_number":1787,"context_line":"                elif (rsc_kind \u003d\u003d \u0027Deployment\u0027) or\\"},{"line_number":1788,"context_line":"                     (rsc_kind \u003d\u003d \u0027DaemonSet\u0027) or\\"},{"line_number":1789,"context_line":"                     (rsc_kind \u003d\u003d \u0027StatefulSet\u0027) or\\"},{"line_number":1790,"context_line":"                     (rsc_kind \u003d\u003d \u0027ReplicaSet\u0027):"},{"line_number":1791,"context_line":"                    try:"},{"line_number":1792,"context_line":"                        # Delete Pod (Pod is automatically re-created)"},{"line_number":1793,"context_line":"                        core_v1_api_client.delete_namespaced_pod("}],"source_content_type":"text/x-python","patch_set":10,"id":"cefbbf1a_ccf2eb39","line":1790,"range":{"start_line":1787,"start_character":0,"end_line":1790,"end_character":48},"updated":"2021-03-20 08:22:18.000000000","message":"It is better for me.\n\n`elif rsc_kind in [\u0027Deployment\u0027, \u0027DaemonSet\u0027, \u0027StatefulSet\u0027, \u0027ReplicaSet\u0027]:`","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":1784,"context_line":"                        namespace\u003dnamespace,"},{"line_number":1785,"context_line":"                        body\u003dbody"},{"line_number":1786,"context_line":"                    )"},{"line_number":1787,"context_line":"                elif (rsc_kind \u003d\u003d \u0027Deployment\u0027) or\\"},{"line_number":1788,"context_line":"                     (rsc_kind \u003d\u003d \u0027DaemonSet\u0027) or\\"},{"line_number":1789,"context_line":"                     (rsc_kind \u003d\u003d \u0027StatefulSet\u0027) or\\"},{"line_number":1790,"context_line":"                     (rsc_kind \u003d\u003d \u0027ReplicaSet\u0027):"},{"line_number":1791,"context_line":"                    try:"},{"line_number":1792,"context_line":"                        # Delete Pod (Pod is automatically re-created)"},{"line_number":1793,"context_line":"                        core_v1_api_client.delete_namespaced_pod("}],"source_content_type":"text/x-python","patch_set":10,"id":"7ed712b4_2f72c604","line":1790,"range":{"start_line":1787,"start_character":0,"end_line":1790,"end_character":48},"in_reply_to":"cefbbf1a_ccf2eb39","updated":"2021-03-23 04:04:58.000000000","message":"Done.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":2098,"context_line":"                    rsc_kind, rsc_name, pod.metadata.name)"},{"line_number":2099,"context_line":"                if match_result:"},{"line_number":2100,"context_line":"                    actual_pod_list.append(pod.metadata.name)"},{"line_number":2101,"context_line":"            # Remove the reduced pod from VnfcResourceInfo"},{"line_number":2102,"context_line":"            del_index \u003d []"},{"line_number":2103,"context_line":"            for index, vnfc in enumerate(inst_vnf_info.vnfc_resource_info):"},{"line_number":2104,"context_line":"                if vnfc.compute_resource.resource_id not in actual_pod_list \\"}],"source_content_type":"text/x-python","patch_set":10,"id":"a21a8e6d_3a351a20","line":2101,"range":{"start_line":2101,"start_character":33,"end_line":2101,"end_character":36},"updated":"2021-03-20 08:22:18.000000000","message":"pods?","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":2098,"context_line":"                    rsc_kind, rsc_name, pod.metadata.name)"},{"line_number":2099,"context_line":"                if match_result:"},{"line_number":2100,"context_line":"                    actual_pod_list.append(pod.metadata.name)"},{"line_number":2101,"context_line":"            # Remove the reduced pod from VnfcResourceInfo"},{"line_number":2102,"context_line":"            del_index \u003d []"},{"line_number":2103,"context_line":"            for index, vnfc in enumerate(inst_vnf_info.vnfc_resource_info):"},{"line_number":2104,"context_line":"                if vnfc.compute_resource.resource_id not in actual_pod_list \\"}],"source_content_type":"text/x-python","patch_set":10,"id":"de4913e7_2c8e6c42","line":2101,"range":{"start_line":2101,"start_character":33,"end_line":2101,"end_character":36},"in_reply_to":"a21a8e6d_3a351a20","updated":"2021-03-23 04:04:58.000000000","message":"Thanks for pointing out.\nYes, I fixed it because multiple are correct.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"05795073de1e94bd3a49872b2b026b1dff5c6fb9","unresolved":true,"context_lines":[{"line_number":2104,"context_line":"                if vnfc.compute_resource.resource_id not in actual_pod_list \\"},{"line_number":2105,"context_line":"                   and vnfc.vdu_id \u003d\u003d target_vdu_id:"},{"line_number":2106,"context_line":"                    del_index.append(index)"},{"line_number":2107,"context_line":"            for ind in del_index[::-1]:"},{"line_number":2108,"context_line":"                inst_vnf_info.vnfc_resource_info.pop(ind)"},{"line_number":2109,"context_line":"            # Add the increased pod to VnfcResourceInfo"},{"line_number":2110,"context_line":"            for actual_pod_name in actual_pod_list:"}],"source_content_type":"text/x-python","patch_set":10,"id":"ee67d3b9_feeb0405","line":2107,"range":{"start_line":2107,"start_character":23,"end_line":2107,"end_character":38},"updated":"2021-03-20 08:22:18.000000000","message":"Please write it in more general and easy way. `reversed(del_index)`","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7af1514eb9373248990677f4d384f52d657bbd32","unresolved":true,"context_lines":[{"line_number":2104,"context_line":"                if vnfc.compute_resource.resource_id not in actual_pod_list \\"},{"line_number":2105,"context_line":"                   and vnfc.vdu_id \u003d\u003d target_vdu_id:"},{"line_number":2106,"context_line":"                    del_index.append(index)"},{"line_number":2107,"context_line":"            for ind in del_index[::-1]:"},{"line_number":2108,"context_line":"                inst_vnf_info.vnfc_resource_info.pop(ind)"},{"line_number":2109,"context_line":"            # Add the increased pod to VnfcResourceInfo"},{"line_number":2110,"context_line":"            for actual_pod_name in actual_pod_list:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bb7e7bac_a02fa122","line":2107,"range":{"start_line":2107,"start_character":23,"end_line":2107,"end_character":38},"in_reply_to":"ee67d3b9_feeb0405","updated":"2021-03-23 04:04:58.000000000","message":"Done.","commit_id":"a1c0911cdcd78d8b82da15fcad3121f942147b09"}]}