)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"02bcdad1f33cb016eb6dcdb7630642d1dd0c8a18","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     LiangLu \u003clu.liang@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-09 12:57:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add and unite required parameters for MgmtDriver SOL interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As implement SOL interfaces for MgmtDriver, \"vnf_instante\" and \"addtional_params\""},{"line_number":10,"context_line":"are used as required parameters due to ETSI NFV-SOL001 v2.6.1 definition."},{"line_number":11,"context_line":"However, for various usage and functions in tacker, these 2 parameters are not enough."},{"line_number":12,"context_line":"Here the patch is aim to add required paramters for basic use of mgmtdriver interfaces."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Here is the final parameters to be used in mgmtdriver interface calling:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* vnf_instance"},{"line_number":17,"context_line":"* request(due to interface to be called)"},{"line_number":18,"context_line":"* grant"},{"line_number":19,"context_line":"* grant_request"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note: Currently, grant_request is not passed to VnfLcmDriver, we are passing a Null"},{"line_number":22,"context_line":"      grant_request in temporary. This will be fixed in X-release."},{"line_number":23,"context_line":"      (grant for terminate interface is the same)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I253d72ae09bd246ab3f1552185ce0a701a1f4b41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"408fe287_307764b8","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":49},"updated":"2021-03-13 18:45:04.000000000","message":"Thanks for contribution, but you should follow the guidelines for commit messages.","commit_id":"de9ad1ab3df8a4301955c09b94cfd29faba310d6"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"dfc16f40e6b067f7b4d613dd7fac81f0ec41b8e4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     LiangLu \u003clu.liang@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-03-09 12:57:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add and unite required parameters for MgmtDriver SOL interfaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As implement SOL interfaces for MgmtDriver, \"vnf_instante\" and \"addtional_params\""},{"line_number":10,"context_line":"are used as required parameters due to ETSI NFV-SOL001 v2.6.1 definition."},{"line_number":11,"context_line":"However, for various usage and functions in tacker, these 2 parameters are not enough."},{"line_number":12,"context_line":"Here the patch is aim to add required paramters for basic use of mgmtdriver interfaces."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Here is the final parameters to be used in mgmtdriver interface calling:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* vnf_instance"},{"line_number":17,"context_line":"* request(due to interface to be called)"},{"line_number":18,"context_line":"* grant"},{"line_number":19,"context_line":"* grant_request"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Note: Currently, grant_request is not passed to VnfLcmDriver, we are passing a Null"},{"line_number":22,"context_line":"      grant_request in temporary. This will be fixed in X-release."},{"line_number":23,"context_line":"      (grant for terminate interface is the same)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I253d72ae09bd246ab3f1552185ce0a701a1f4b41"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b1abccc2_99fd1e3f","line":23,"range":{"start_line":7,"start_character":0,"end_line":23,"end_character":49},"in_reply_to":"408fe287_307764b8","updated":"2021-03-15 00:56:41.000000000","message":"Thanks for comment! I tired to fix commit message to make it more specific?\n(removed Note: part and add what interface will be changed)\nCould you please kindly have a look on it?:)","commit_id":"de9ad1ab3df8a4301955c09b94cfd29faba310d6"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"1e96021b3a15b26ec29f7b8e754ed0ed0f30dca5","unresolved":true,"context_lines":[{"line_number":480,"context_line":"        # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":481,"context_line":"        # as a parameter, however due to grant_request is not"},{"line_number":482,"context_line":"        # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":483,"context_line":"        # value to grant_reqeust temprory."},{"line_number":484,"context_line":"        # This part will be updated in next release."},{"line_number":485,"context_line":"        self._mgmt_manager.invoke("},{"line_number":486,"context_line":"            self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":5,"id":"9bd4cd7d_31d69639","line":483,"range":{"start_line":483,"start_character":33,"end_line":483,"end_character":41},"updated":"2021-03-12 13:09:23.000000000","message":"typo \"temporary\"\nIt\u0027s the same for all other parts.","commit_id":"de9ad1ab3df8a4301955c09b94cfd29faba310d6"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"698b50ad8200e1f25a8526c59916fe1ba765301a","unresolved":true,"context_lines":[{"line_number":480,"context_line":"        # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":481,"context_line":"        # as a parameter, however due to grant_request is not"},{"line_number":482,"context_line":"        # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":483,"context_line":"        # value to grant_reqeust temprory."},{"line_number":484,"context_line":"        # This part will be updated in next release."},{"line_number":485,"context_line":"        self._mgmt_manager.invoke("},{"line_number":486,"context_line":"            self._load_vnf_interface("}],"source_content_type":"text/x-python","patch_set":5,"id":"7d3bf436_617c32f2","line":483,"range":{"start_line":483,"start_character":33,"end_line":483,"end_character":41},"in_reply_to":"9bd4cd7d_31d69639","updated":"2021-03-15 00:42:04.000000000","message":"Sorry for typo miss.. I\u0027ve just fixed all parts here! please kindly have a check","commit_id":"de9ad1ab3df8a4301955c09b94cfd29faba310d6"}]}
