)]}'
{"doc/source/user/mgmt_driver_deploy_k8s_usage_guide.rst":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"--------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"1. Mgmt Driver introduction"},{"line_number":9,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":10,"context_line":"Mgmt Driver enables Users to configure their VNF before and/or after"},{"line_number":11,"context_line":"its VNF Lifecycle Management operation. Users can customize the logic"}],"source_content_type":"text/x-rst","patch_set":5,"id":"53baf6e1_2db98c00","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":16},"updated":"2021-03-17 17:52:59.000000000","message":"It should be capitalized for titles for consistency.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":5,"context_line":"Overview"},{"line_number":6,"context_line":"--------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"1. Mgmt Driver introduction"},{"line_number":9,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":10,"context_line":"Mgmt Driver enables Users to configure their VNF before and/or after"},{"line_number":11,"context_line":"its VNF Lifecycle Management operation. Users can customize the logic"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b86896f0_f7ea1075","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":16},"in_reply_to":"53baf6e1_2db98c00","updated":"2021-03-22 12:15:23.000000000","message":"I have fixed it in the latest patch.Please kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":12,"context_line":"of Mgmt Driver by implementing their own Mgmt Driver and these"},{"line_number":13,"context_line":"customizations are specified by \"interface\" definition in"},{"line_number":14,"context_line":"`NFV-SOL001 v2.6.1`_."},{"line_number":15,"context_line":"This user guide is aim to deploy Kubernetes cluster via"},{"line_number":16,"context_line":"Mgmt Driver which is customized by user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. Use cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f5fac722_2878f086","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":22},"updated":"2021-03-15 17:57:36.000000000","message":"Could you please change the verb form to \"aims\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":12,"context_line":"of Mgmt Driver by implementing their own Mgmt Driver and these"},{"line_number":13,"context_line":"customizations are specified by \"interface\" definition in"},{"line_number":14,"context_line":"`NFV-SOL001 v2.6.1`_."},{"line_number":15,"context_line":"This user guide is aim to deploy Kubernetes cluster via"},{"line_number":16,"context_line":"Mgmt Driver which is customized by user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. Use cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fea413a3_65bd7965","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":22},"in_reply_to":"f5fac722_2878f086","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":12,"context_line":"of Mgmt Driver by implementing their own Mgmt Driver and these"},{"line_number":13,"context_line":"customizations are specified by \"interface\" definition in"},{"line_number":14,"context_line":"`NFV-SOL001 v2.6.1`_."},{"line_number":15,"context_line":"This user guide is aim to deploy Kubernetes cluster via"},{"line_number":16,"context_line":"Mgmt Driver which is customized by user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. Use cases"}],"source_content_type":"text/x-rst","patch_set":5,"id":"06b2794b_788a5791","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":22},"in_reply_to":"fea413a3_65bd7965","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":15,"context_line":"This user guide is aim to deploy Kubernetes cluster via"},{"line_number":16,"context_line":"Mgmt Driver which is customized by user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. Use cases"},{"line_number":19,"context_line":"^^^^^^^^^^^^"},{"line_number":20,"context_line":"In the present user guide, two cases are supported with the sample Mgmt Driver"},{"line_number":21,"context_line":"and VNF Package providing two deployment flavours in VNFD:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"acac7922_432a5bbc","line":18,"range":{"start_line":18,"start_character":7,"end_line":18,"end_character":8},"updated":"2021-03-17 17:52:59.000000000","message":"ditto here, and also other titles.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":15,"context_line":"This user guide is aim to deploy Kubernetes cluster via"},{"line_number":16,"context_line":"Mgmt Driver which is customized by user."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2. Use cases"},{"line_number":19,"context_line":"^^^^^^^^^^^^"},{"line_number":20,"context_line":"In the present user guide, two cases are supported with the sample Mgmt Driver"},{"line_number":21,"context_line":"and VNF Package providing two deployment flavours in VNFD:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba450649_80c8a697","line":18,"range":{"start_line":18,"start_character":7,"end_line":18,"end_character":8},"in_reply_to":"acac7922_432a5bbc","updated":"2021-03-22 12:15:23.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":20,"context_line":"In the present user guide, two cases are supported with the sample Mgmt Driver"},{"line_number":21,"context_line":"and VNF Package providing two deployment flavours in VNFD:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* simple: Deploy one master node with worker nodes. Under this"},{"line_number":24,"context_line":"  case, it supports to scale worker node and heal worker node."},{"line_number":25,"context_line":"* complex: Deploy three(or more) master nodes with worker nodes. Under"},{"line_number":26,"context_line":"  this case, it supports to scale worker node and heal worker"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5dcc0271_2c63c30d","line":23,"updated":"2021-03-15 17:57:36.000000000","message":"Please change the preposition \"Under\" to \"In\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":20,"context_line":"In the present user guide, two cases are supported with the sample Mgmt Driver"},{"line_number":21,"context_line":"and VNF Package providing two deployment flavours in VNFD:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* simple: Deploy one master node with worker nodes. Under this"},{"line_number":24,"context_line":"  case, it supports to scale worker node and heal worker node."},{"line_number":25,"context_line":"* complex: Deploy three(or more) master nodes with worker nodes. Under"},{"line_number":26,"context_line":"  this case, it supports to scale worker node and heal worker"}],"source_content_type":"text/x-rst","patch_set":5,"id":"b390fd48_6323471f","line":23,"in_reply_to":"5dcc0271_2c63c30d","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":20,"context_line":"In the present user guide, two cases are supported with the sample Mgmt Driver"},{"line_number":21,"context_line":"and VNF Package providing two deployment flavours in VNFD:"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* simple: Deploy one master node with worker nodes. Under this"},{"line_number":24,"context_line":"  case, it supports to scale worker node and heal worker node."},{"line_number":25,"context_line":"* complex: Deploy three(or more) master nodes with worker nodes. Under"},{"line_number":26,"context_line":"  this case, it supports to scale worker node and heal worker"}],"source_content_type":"text/x-rst","patch_set":5,"id":"05378e3c_172206ec","line":23,"in_reply_to":"b390fd48_6323471f","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* simple: Deploy one master node with worker nodes. Under this"},{"line_number":24,"context_line":"  case, it supports to scale worker node and heal worker node."},{"line_number":25,"context_line":"* complex: Deploy three(or more) master nodes with worker nodes. Under"},{"line_number":26,"context_line":"  this case, it supports to scale worker node and heal worker"},{"line_number":27,"context_line":"  node and master node."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1f2972d0_bc65afad","line":25,"range":{"start_line":25,"start_character":65,"end_line":25,"end_character":70},"updated":"2021-03-15 17:57:36.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* simple: Deploy one master node with worker nodes. Under this"},{"line_number":24,"context_line":"  case, it supports to scale worker node and heal worker node."},{"line_number":25,"context_line":"* complex: Deploy three(or more) master nodes with worker nodes. Under"},{"line_number":26,"context_line":"  this case, it supports to scale worker node and heal worker"},{"line_number":27,"context_line":"  node and master node."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"a2f5963e_42f425f5","line":25,"range":{"start_line":25,"start_character":65,"end_line":25,"end_character":70},"in_reply_to":"1f2972d0_bc65afad","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"* simple: Deploy one master node with worker nodes. Under this"},{"line_number":24,"context_line":"  case, it supports to scale worker node and heal worker node."},{"line_number":25,"context_line":"* complex: Deploy three(or more) master nodes with worker nodes. Under"},{"line_number":26,"context_line":"  this case, it supports to scale worker node and heal worker"},{"line_number":27,"context_line":"  node and master node."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"64aa4a0d_0728cf14","line":25,"range":{"start_line":25,"start_character":65,"end_line":25,"end_character":70},"in_reply_to":"a2f5963e_42f425f5","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":32,"context_line":"1. Simple : Single master node"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The simple kubernetes cluster contains one master node as controller node."},{"line_number":36,"context_line":"You can deploy it use the sample script we provided. The diagram below shows"},{"line_number":37,"context_line":"simple Kubernetes cluster architecture:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"a8ffa141_c569cfa1","line":35,"range":{"start_line":35,"start_character":11,"end_line":35,"end_character":21},"updated":"2021-03-15 17:57:36.000000000","message":"Could you please change \"kubernetes\" to \"Kubernetes\" and make it uniform across the document, as there are different conventions used in doc.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"27794ba937f16cf5bb159afd98d99cc3d61d2d2f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"1. Simple : Single master node"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The simple kubernetes cluster contains one master node as controller node."},{"line_number":36,"context_line":"You can deploy it use the sample script we provided. The diagram below shows"},{"line_number":37,"context_line":"simple Kubernetes cluster architecture:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7aefef4c_73b72840","line":35,"range":{"start_line":35,"start_character":11,"end_line":35,"end_character":21},"in_reply_to":"27a72962_008ee3c3","updated":"2021-03-23 13:12:30.000000000","message":"Thanks, I have verified.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":32,"context_line":"1. Simple : Single master node"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The simple kubernetes cluster contains one master node as controller node."},{"line_number":36,"context_line":"You can deploy it use the sample script we provided. The diagram below shows"},{"line_number":37,"context_line":"simple Kubernetes cluster architecture:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"a99dffff_cba21c3e","line":35,"range":{"start_line":35,"start_character":11,"end_line":35,"end_character":21},"in_reply_to":"a8ffa141_c569cfa1","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":32,"context_line":"1. Simple : Single master node"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The simple kubernetes cluster contains one master node as controller node."},{"line_number":36,"context_line":"You can deploy it use the sample script we provided. The diagram below shows"},{"line_number":37,"context_line":"simple Kubernetes cluster architecture:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bcb04db5_9ce3c33b","line":35,"range":{"start_line":35,"start_character":11,"end_line":35,"end_character":21},"in_reply_to":"a99dffff_cba21c3e","updated":"2021-03-19 13:00:37.000000000","message":"Thanks, but still found few appearance in the document which need to be change.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":32,"context_line":"1. Simple : Single master node"},{"line_number":33,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The simple kubernetes cluster contains one master node as controller node."},{"line_number":36,"context_line":"You can deploy it use the sample script we provided. The diagram below shows"},{"line_number":37,"context_line":"simple Kubernetes cluster architecture:"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"27a72962_008ee3c3","line":35,"range":{"start_line":35,"start_character":11,"end_line":35,"end_character":21},"in_reply_to":"bcb04db5_9ce3c33b","updated":"2021-03-22 12:15:23.000000000","message":"I changed all \"kubernetes\" in the main text to \"Kubernetes\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"1. Create an OpenStack router"},{"line_number":152,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":153,"context_line":"To ensure your VMs can access to the external network, a router between"},{"line_number":154,"context_line":"public network and internal network may be required. It can be created"},{"line_number":155,"context_line":"by OpenStack dashboard or cli command. The following steps will"},{"line_number":156,"context_line":"create a router between the ``public`` network and the internal ``net0``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7f0150f9_2238518f","line":153,"range":{"start_line":153,"start_character":30,"end_line":153,"end_character":32},"updated":"2021-03-15 17:57:36.000000000","message":"Please remove \"to\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"1. Create an OpenStack router"},{"line_number":152,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":153,"context_line":"To ensure your VMs can access to the external network, a router between"},{"line_number":154,"context_line":"public network and internal network may be required. It can be created"},{"line_number":155,"context_line":"by OpenStack dashboard or cli command. The following steps will"},{"line_number":156,"context_line":"create a router between the ``public`` network and the internal ``net0``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"f34bfc75_f99e2e13","line":153,"range":{"start_line":153,"start_character":30,"end_line":153,"end_character":32},"in_reply_to":"15eda0ff_80a8531a","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"1. Create an OpenStack router"},{"line_number":152,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":153,"context_line":"To ensure your VMs can access to the external network, a router between"},{"line_number":154,"context_line":"public network and internal network may be required. It can be created"},{"line_number":155,"context_line":"by OpenStack dashboard or cli command. The following steps will"},{"line_number":156,"context_line":"create a router between the ``public`` network and the internal ``net0``"}],"source_content_type":"text/x-rst","patch_set":5,"id":"15eda0ff_80a8531a","line":153,"range":{"start_line":153,"start_character":30,"end_line":153,"end_character":32},"in_reply_to":"7f0150f9_2238518f","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":249,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"In order to access the k8s cluster, you need to set the security group rules."},{"line_number":252,"context_line":"You can create a new security group or add the rules into"},{"line_number":253,"context_line":"the ``default`` security group. The minimum settings are shown below using"},{"line_number":254,"context_line":"cli command:"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"03bc69f5_c2cf6767","line":252,"range":{"start_line":252,"start_character":53,"end_line":252,"end_character":57},"updated":"2021-03-15 17:57:36.000000000","message":"Please change this is \"to\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":249,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"In order to access the k8s cluster, you need to set the security group rules."},{"line_number":252,"context_line":"You can create a new security group or add the rules into"},{"line_number":253,"context_line":"the ``default`` security group. The minimum settings are shown below using"},{"line_number":254,"context_line":"cli command:"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"d47c6960_f059d9f4","line":252,"range":{"start_line":252,"start_character":53,"end_line":252,"end_character":57},"in_reply_to":"03bc69f5_c2cf6767","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":249,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"In order to access the k8s cluster, you need to set the security group rules."},{"line_number":252,"context_line":"You can create a new security group or add the rules into"},{"line_number":253,"context_line":"the ``default`` security group. The minimum settings are shown below using"},{"line_number":254,"context_line":"cli command:"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1b6d01dd_fed71e61","line":252,"range":{"start_line":252,"start_character":53,"end_line":252,"end_character":57},"in_reply_to":"d47c6960_f059d9f4","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":289,"context_line":"To ensure that Mgmt Driver can access to VMs via SSH,"},{"line_number":290,"context_line":"some configurations are required."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"1. Download an ubuntu image"},{"line_number":293,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"You can download the ubuntu image(version 20.04) from the official website."}],"source_content_type":"text/x-rst","patch_set":5,"id":"6ab315f3_f74d55f2","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":14},"updated":"2021-03-15 17:57:36.000000000","message":"Please remove article \"an\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":289,"context_line":"To ensure that Mgmt Driver can access to VMs via SSH,"},{"line_number":290,"context_line":"some configurations are required."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"1. Download an ubuntu image"},{"line_number":293,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"You can download the ubuntu image(version 20.04) from the official website."}],"source_content_type":"text/x-rst","patch_set":5,"id":"e6eae5c9_daacee08","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":14},"in_reply_to":"6ab315f3_f74d55f2","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":289,"context_line":"To ensure that Mgmt Driver can access to VMs via SSH,"},{"line_number":290,"context_line":"some configurations are required."},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"1. Download an ubuntu image"},{"line_number":293,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"You can download the ubuntu image(version 20.04) from the official website."}],"source_content_type":"text/x-rst","patch_set":5,"id":"371caed5_9f65dcbd","line":292,"range":{"start_line":292,"start_character":12,"end_line":292,"end_character":14},"in_reply_to":"e6eae5c9_daacee08","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":303,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"If you use the sample script to deploy the Kubernetes cluster, you need"},{"line_number":306,"context_line":"to ensure the VM created by your image to allow you to login using username"},{"line_number":307,"context_line":"and password via SSH. However, the VM created by the ubuntu image downloaded"},{"line_number":308,"context_line":"from official website does not allow you to login using username and"},{"line_number":309,"context_line":"password via SSH. So you need to modify the ubuntu image. The following"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3745635e_1d5618f9","line":306,"range":{"start_line":306,"start_character":39,"end_line":306,"end_character":47},"updated":"2021-03-15 17:57:36.000000000","message":"Please rephrase this as \"allows\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":303,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"If you use the sample script to deploy the Kubernetes cluster, you need"},{"line_number":306,"context_line":"to ensure the VM created by your image to allow you to login using username"},{"line_number":307,"context_line":"and password via SSH. However, the VM created by the ubuntu image downloaded"},{"line_number":308,"context_line":"from official website does not allow you to login using username and"},{"line_number":309,"context_line":"password via SSH. So you need to modify the ubuntu image. The following"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6a1dbb1c_a8b44012","line":306,"range":{"start_line":306,"start_character":39,"end_line":306,"end_character":47},"in_reply_to":"3745635e_1d5618f9","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":303,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"If you use the sample script to deploy the Kubernetes cluster, you need"},{"line_number":306,"context_line":"to ensure the VM created by your image to allow you to login using username"},{"line_number":307,"context_line":"and password via SSH. However, the VM created by the ubuntu image downloaded"},{"line_number":308,"context_line":"from official website does not allow you to login using username and"},{"line_number":309,"context_line":"password via SSH. So you need to modify the ubuntu image. The following"}],"source_content_type":"text/x-rst","patch_set":5,"id":"e42bd435_3dd60319","line":306,"range":{"start_line":306,"start_character":39,"end_line":306,"end_character":47},"in_reply_to":"6a1dbb1c_a8b44012","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":503,"context_line":"of definition files, ETSI NFV types definition file and User defined types"},{"line_number":504,"context_line":"definition file."},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"ETSI NFV provides two types definition files [#f1]_ which contain all defined"},{"line_number":507,"context_line":"type definitions in `NFV-SOL001 v2.6.1`_. You can download them from official"},{"line_number":508,"context_line":"website."},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1424a87f_40856c5d","line":506,"range":{"start_line":506,"start_character":28,"end_line":506,"end_character":38},"updated":"2021-03-15 17:57:36.000000000","message":"Please add \"of definition\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":503,"context_line":"of definition files, ETSI NFV types definition file and User defined types"},{"line_number":504,"context_line":"definition file."},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"ETSI NFV provides two types definition files [#f1]_ which contain all defined"},{"line_number":507,"context_line":"type definitions in `NFV-SOL001 v2.6.1`_. You can download them from official"},{"line_number":508,"context_line":"website."},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"19728461_0b1f4386","line":506,"range":{"start_line":506,"start_character":28,"end_line":506,"end_character":38},"in_reply_to":"1424a87f_40856c5d","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":503,"context_line":"of definition files, ETSI NFV types definition file and User defined types"},{"line_number":504,"context_line":"definition file."},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"ETSI NFV provides two types definition files [#f1]_ which contain all defined"},{"line_number":507,"context_line":"type definitions in `NFV-SOL001 v2.6.1`_. You can download them from official"},{"line_number":508,"context_line":"website."},{"line_number":509,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"a88a44be_9dd51393","line":506,"range":{"start_line":506,"start_character":28,"end_line":506,"end_character":38},"in_reply_to":"19728461_0b1f4386","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"VNF Software Images are located here. These files are also described in"},{"line_number":532,"context_line":"``TOSCA.meta``. The image used for deploying Kubernetes cluster is"},{"line_number":533,"context_line":"``ubuntu-20.04-server-cloudimg-amd64.img`` which downloaded in"},{"line_number":534,"context_line":"``Download Image``."},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Scripts/"}],"source_content_type":"text/x-rst","patch_set":5,"id":"6dda678c_08c19cc7","line":533,"range":{"start_line":533,"start_character":43,"end_line":533,"end_character":48},"updated":"2021-03-15 17:57:36.000000000","message":"Please remove \"which\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"VNF Software Images are located here. These files are also described in"},{"line_number":532,"context_line":"``TOSCA.meta``. The image used for deploying Kubernetes cluster is"},{"line_number":533,"context_line":"``ubuntu-20.04-server-cloudimg-amd64.img`` which downloaded in"},{"line_number":534,"context_line":"``Download Image``."},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Scripts/"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5b20fa8c_b0c8878e","line":533,"range":{"start_line":533,"start_character":43,"end_line":533,"end_character":48},"in_reply_to":"22f474ad_eb920f9f","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":530,"context_line":""},{"line_number":531,"context_line":"VNF Software Images are located here. These files are also described in"},{"line_number":532,"context_line":"``TOSCA.meta``. The image used for deploying Kubernetes cluster is"},{"line_number":533,"context_line":"``ubuntu-20.04-server-cloudimg-amd64.img`` which downloaded in"},{"line_number":534,"context_line":"``Download Image``."},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"Scripts/"}],"source_content_type":"text/x-rst","patch_set":5,"id":"22f474ad_eb920f9f","line":533,"range":{"start_line":533,"start_character":43,"end_line":533,"end_character":48},"in_reply_to":"6dda678c_08c19cc7","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":1857,"context_line":"before and after scaling."},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"2. Login to master node of kubernetes cluster and check the number of"},{"line_number":1860,"context_line":"worker node before and after scaling."},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"To confirm the number of worker nodes after scaling, you can find the"},{"line_number":1863,"context_line":"increased or decreased number of stack resource with Heat CLI. Also"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5fe62642_78d67b8e","line":1860,"range":{"start_line":1860,"start_character":7,"end_line":1860,"end_character":11},"updated":"2021-03-15 17:57:36.000000000","message":"Please change this to \"nodes\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":1857,"context_line":"before and after scaling."},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"2. Login to master node of kubernetes cluster and check the number of"},{"line_number":1860,"context_line":"worker node before and after scaling."},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"To confirm the number of worker nodes after scaling, you can find the"},{"line_number":1863,"context_line":"increased or decreased number of stack resource with Heat CLI. Also"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fb3f6a55_bb40d736","line":1860,"range":{"start_line":1860,"start_character":7,"end_line":1860,"end_character":11},"in_reply_to":"5fe62642_78d67b8e","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":1857,"context_line":"before and after scaling."},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"2. Login to master node of kubernetes cluster and check the number of"},{"line_number":1860,"context_line":"worker node before and after scaling."},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"To confirm the number of worker nodes after scaling, you can find the"},{"line_number":1863,"context_line":"increased or decreased number of stack resource with Heat CLI. Also"}],"source_content_type":"text/x-rst","patch_set":5,"id":"77bcea0f_3feb1b1f","line":1860,"range":{"start_line":1860,"start_character":7,"end_line":1860,"end_character":11},"in_reply_to":"fb3f6a55_bb40d736","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":2214,"context_line":"* stack delete"},{"line_number":2215,"context_line":"* stack create"},{"line_number":2216,"context_line":""},{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"624aa25d_c4b4c61f","line":2217,"range":{"start_line":2217,"start_character":0,"end_line":2217,"end_character":4},"updated":"2021-03-15 17:57:36.000000000","message":"Please add space for better readability.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":2214,"context_line":"* stack delete"},{"line_number":2215,"context_line":"* stack create"},{"line_number":2216,"context_line":""},{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"e7845a72_8a339bb4","line":2217,"range":{"start_line":2217,"start_character":0,"end_line":2217,"end_character":4},"in_reply_to":"3d5cd9fc_6a67b7d3","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":2214,"context_line":"* stack delete"},{"line_number":2215,"context_line":"* stack create"},{"line_number":2216,"context_line":""},{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3d5cd9fc_6a67b7d3","line":2217,"range":{"start_line":2217,"start_character":0,"end_line":2217,"end_character":4},"in_reply_to":"624aa25d_c4b4c61f","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."},{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"This is to confirm that stack \u0027ID\u0027 has changed"},{"line_number":2223,"context_line":"before and after healing."}],"source_content_type":"text/x-rst","patch_set":5,"id":"00faec4f_92985613","line":2220,"range":{"start_line":2220,"start_character":0,"end_line":2220,"end_character":5},"updated":"2021-03-15 17:57:36.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."},{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"This is to confirm that stack \u0027ID\u0027 has changed"},{"line_number":2223,"context_line":"before and after healing."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bfd74b98_f9fce33d","line":2220,"range":{"start_line":2220,"start_character":0,"end_line":2220,"end_character":5},"in_reply_to":"00faec4f_92985613","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."},{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"This is to confirm that stack \u0027ID\u0027 has changed"},{"line_number":2223,"context_line":"before and after healing."}],"source_content_type":"text/x-rst","patch_set":5,"id":"d105266f_bc7d480b","line":2220,"range":{"start_line":2220,"start_character":0,"end_line":2220,"end_character":5},"in_reply_to":"bc7bb1e7_4d0d2de7","updated":"2021-03-22 12:15:23.000000000","message":"Okay, I checked again carefully.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."},{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"This is to confirm that stack \u0027ID\u0027 has changed"},{"line_number":2223,"context_line":"before and after healing."}],"source_content_type":"text/x-rst","patch_set":5,"id":"bc7bb1e7_4d0d2de7","line":2220,"range":{"start_line":2220,"start_character":0,"end_line":2220,"end_character":5},"in_reply_to":"bfd74b98_f9fce33d","updated":"2021-03-19 13:00:37.000000000","message":"Thanks for change, but found some kind of formatting issue in html view of document, there are some extra spaces before the statement. Kindly check","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"27794ba937f16cf5bb159afd98d99cc3d61d2d2f","unresolved":false,"context_lines":[{"line_number":2217,"context_line":"1.Execute Heat CLI command and check \u0027ID\u0027 and \u0027Stack Status\u0027 of the stack"},{"line_number":2218,"context_line":"before and after healing."},{"line_number":2219,"context_line":""},{"line_number":2220,"context_line":"2.All the information of Kubernetes cluster will be changed."},{"line_number":2221,"context_line":""},{"line_number":2222,"context_line":"This is to confirm that stack \u0027ID\u0027 has changed"},{"line_number":2223,"context_line":"before and after healing."}],"source_content_type":"text/x-rst","patch_set":5,"id":"b0bd0784_f2770c9a","line":2220,"range":{"start_line":2220,"start_character":0,"end_line":2220,"end_character":5},"in_reply_to":"d105266f_bc7d480b","updated":"2021-03-23 13:12:30.000000000","message":"I have verified, extra space issue resolve.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":1856,"context_line":"\u0027worker_instance\u0027 of the stack"},{"line_number":1857,"context_line":"before and after scaling."},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"2. Login to master node of kubernetes cluster and check the number of"},{"line_number":1860,"context_line":"worker nodes before and after scaling."},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"To confirm the number of worker nodes after scaling, you can find the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"6b05eeb4_92007e2c","line":1859,"range":{"start_line":1859,"start_character":27,"end_line":1859,"end_character":37},"updated":"2021-03-19 13:00:37.000000000","message":"This is needs to be uppercase, \"Kubernetes\".","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"27794ba937f16cf5bb159afd98d99cc3d61d2d2f","unresolved":false,"context_lines":[{"line_number":1856,"context_line":"\u0027worker_instance\u0027 of the stack"},{"line_number":1857,"context_line":"before and after scaling."},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"2. Login to master node of kubernetes cluster and check the number of"},{"line_number":1860,"context_line":"worker nodes before and after scaling."},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"To confirm the number of worker nodes after scaling, you can find the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"643fde2f_6903a871","line":1859,"range":{"start_line":1859,"start_character":27,"end_line":1859,"end_character":37},"in_reply_to":"3186fde9_6728cc03","updated":"2021-03-23 13:12:30.000000000","message":"I have verified.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":1856,"context_line":"\u0027worker_instance\u0027 of the stack"},{"line_number":1857,"context_line":"before and after scaling."},{"line_number":1858,"context_line":""},{"line_number":1859,"context_line":"2. Login to master node of kubernetes cluster and check the number of"},{"line_number":1860,"context_line":"worker nodes before and after scaling."},{"line_number":1861,"context_line":""},{"line_number":1862,"context_line":"To confirm the number of worker nodes after scaling, you can find the"}],"source_content_type":"text/x-rst","patch_set":9,"id":"3186fde9_6728cc03","line":1859,"range":{"start_line":1859,"start_character":27,"end_line":1859,"end_character":37},"in_reply_to":"6b05eeb4_92007e2c","updated":"2021-03-22 12:15:23.000000000","message":"I have changed it to \"Kubernetes\".","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":1877,"context_line":"    | n6nnjta4f4rv  | 56c9ec6f-5e52-44db-9d0d-57e3484e763f | base_hot_nested_worker.yaml | CREATE_COMPLETE |"},{"line_number":1878,"context_line":"    +---------------+--------------------------------------+-----------------------------+-----------------+"},{"line_number":1879,"context_line":""},{"line_number":1880,"context_line":"worker node in kubernetes cluster before scaling:"},{"line_number":1881,"context_line":""},{"line_number":1882,"context_line":".. code-block:: console"},{"line_number":1883,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"27cc54a4_45c9ed54","line":1880,"range":{"start_line":1880,"start_character":15,"end_line":1880,"end_character":25},"updated":"2021-03-19 13:00:37.000000000","message":"ditto.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":1910,"context_line":"    | z5nky6qcodlq  | f9ab73ff-3ad7-40d2-830a-87bd0c45af32 | base_hot_nested_worker.yaml | CREATE_COMPLETE |"},{"line_number":1911,"context_line":"    +---------------+--------------------------------------+-----------------------------+-----------------+"},{"line_number":1912,"context_line":""},{"line_number":1913,"context_line":"worker node in kubernetes cluster after scaling out:"},{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":".. code-block:: console"},{"line_number":1916,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"d70a025c_02d5eade","line":1913,"range":{"start_line":1913,"start_character":15,"end_line":1913,"end_character":25},"updated":"2021-03-19 13:00:37.000000000","message":"ditto","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":1946,"context_line":"    | z5nky6qcodlq  | f9ab73ff-3ad7-40d2-830a-87bd0c45af32 | base_hot_nested_worker.yaml | UPDATE_COMPLETE |"},{"line_number":1947,"context_line":"    +---------------+--------------------------------------+-----------------------------+-----------------+"},{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"worker node in kubernetes cluster after scaling in:"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":".. code-block:: console"},{"line_number":1952,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"7ab17fa1_d60e078c","line":1949,"range":{"start_line":1949,"start_character":15,"end_line":1949,"end_character":25},"updated":"2021-03-19 13:00:37.000000000","message":"ditto","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":2053,"context_line":"1. Execute Heat CLI command and check physical_resource_id and"},{"line_number":2054,"context_line":"resource_status of master node before and after healing."},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"2. Login to master node of kubernetes cluster and check the age"},{"line_number":2057,"context_line":"of master node before and after healing."},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"To confirm that healing the master node is successful, you can find"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fcc6f71c_3d987685","line":2056,"range":{"start_line":2056,"start_character":27,"end_line":2056,"end_character":37},"updated":"2021-03-19 13:00:37.000000000","message":"ditto","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"}],"releasenotes/notes/mgmt-driver-for-deploying-kubernetes-cluster-9ce82cc550b50065.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    MgmtDriver function configures applications provided by VNF vendors."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"92d5c1e0_e4d160b1","line":1,"updated":"2021-03-17 17:52:59.000000000","message":"Thanks for explaining the features, but it\u0027s a bit detailed for release note. I think it\u0027s OK to include several topics in a note. Please consider to make it shorter for each topic. It\u0027s enough to show short summary.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    MgmtDriver function configures applications provided by VNF vendors."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"53d83918_c54f7ee8","line":1,"in_reply_to":"92d5c1e0_e4d160b1","updated":"2021-03-22 12:15:23.000000000","message":"I abbreviate the content of each topic.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    node and to heal worker node and master node. In all the above cases,"},{"line_number":15,"context_line":"    kubeadm is used for deploying Kubernetes in the sample script. We also"},{"line_number":16,"context_line":"    provide a user guide to help users understand how to use this feature."},{"line_number":17,"context_line":"    "},{"line_number":18,"context_line":"    Instantiate single master node kubernetes cluster:"},{"line_number":19,"context_line":"    The Kubernetes cluster can be instantiated with VNF Lifecycle"},{"line_number":20,"context_line":"    Management Interface in ETSI NFV-SOL 003 v2.6.1. According to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"051e0b07_13018e43","line":17,"updated":"2021-03-17 17:52:59.000000000","message":"It includes no need spaces.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    node and to heal worker node and master node. In all the above cases,"},{"line_number":15,"context_line":"    kubeadm is used for deploying Kubernetes in the sample script. We also"},{"line_number":16,"context_line":"    provide a user guide to help users understand how to use this feature."},{"line_number":17,"context_line":"    "},{"line_number":18,"context_line":"    Instantiate single master node kubernetes cluster:"},{"line_number":19,"context_line":"    The Kubernetes cluster can be instantiated with VNF Lifecycle"},{"line_number":20,"context_line":"    Management Interface in ETSI NFV-SOL 003 v2.6.1. According to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d3bb4991_c4aae404","line":17,"in_reply_to":"051e0b07_13018e43","updated":"2021-03-22 12:15:23.000000000","message":"I deleted the extra spaces.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"}],"samples/mgmt_driver/install_k8s_cluster.sh":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"###############################################################################"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# This script will install and setting for the Kubernetes Cluster on Ubuntu."},{"line_number":5,"context_line":"# It\u0027s confirmed operation on Ubuntu of below."}],"source_content_type":"text/x-sh","patch_set":5,"id":"6b0eae56_e088c02b","line":2,"updated":"2021-03-17 17:52:59.000000000","message":"You should learn conventions of coding style from existing scripts. Why don\u0027t you use bashate[1] for checking your code. It can be installed from apt if you use Ubuntu.\n\nThere are many inconsistencies of tab size and too long lines.\n\n[1] https://opendev.org/openstack/bashate","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"###############################################################################"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# This script will install and setting for the Kubernetes Cluster on Ubuntu."},{"line_number":5,"context_line":"# It\u0027s confirmed operation on Ubuntu of below."}],"source_content_type":"text/x-sh","patch_set":5,"id":"8751c122_44b6ccb6","line":2,"in_reply_to":"6b0eae56_e088c02b","updated":"2021-03-22 12:15:23.000000000","message":"Thank you for your advice, I have changed the coding style using bashate in the latest patch.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# This script will install and setting for the Kubernetes Cluster on Ubuntu."},{"line_number":5,"context_line":"# It\u0027s confirmed operation on Ubuntu of below."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# * OS type             : Ubuntu(64 bit)"},{"line_number":8,"context_line":"# * OS version          : 20.04 LTS"},{"line_number":9,"context_line":"# * OS architecture     : amd64 (x86_64)"},{"line_number":10,"context_line":"# * Disk/Ram size       : 15GB/2GB"},{"line_number":11,"context_line":"# * Pre setup user      : ubuntu"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"###############################################################################"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"6e5901bd_3588a8a1","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":32},"updated":"2021-03-17 17:52:59.000000000","message":"Can you make it be found out automatically from the script? I mean you can check these conditions from `/etc/os-release`, `uname` or so.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":4,"context_line":"# This script will install and setting for the Kubernetes Cluster on Ubuntu."},{"line_number":5,"context_line":"# It\u0027s confirmed operation on Ubuntu of below."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# * OS type             : Ubuntu(64 bit)"},{"line_number":8,"context_line":"# * OS version          : 20.04 LTS"},{"line_number":9,"context_line":"# * OS architecture     : amd64 (x86_64)"},{"line_number":10,"context_line":"# * Disk/Ram size       : 15GB/2GB"},{"line_number":11,"context_line":"# * Pre setup user      : ubuntu"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"###############################################################################"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"25e84982_b6fa3515","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":32},"in_reply_to":"6e5901bd_3588a8a1","updated":"2021-03-22 12:15:23.000000000","message":"I have added a new function to check OS in the latest patch.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":13,"context_line":"###############################################################################"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":"# Initialization"},{"line_number":17,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"function usage {"},{"line_number":19,"context_line":"    sudo cat \u003c\u003c_EOT_"}],"source_content_type":"text/x-sh","patch_set":5,"id":"85c98838_ab857d0f","line":16,"updated":"2021-03-17 17:52:59.000000000","message":"`Initialization` is not appropriate comment for following lines. Defining `usage` function is not an initialization at least.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"###############################################################################"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":"# Initialization"},{"line_number":17,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":"function usage {"},{"line_number":19,"context_line":"    sudo cat \u003c\u003c_EOT_"}],"source_content_type":"text/x-sh","patch_set":5,"id":"6da4578e_9ddaea92","line":16,"in_reply_to":"85c98838_ab857d0f","updated":"2021-03-22 12:15:23.000000000","message":"I have fixed it in the latest patch. Please kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"if [ \"$OUTPUT_LOGFILE\" \u003d\u003d \"True\" ]; then"},{"line_number":123,"context_line":"    echo \"*** OUTPUT LOGFILE MODE ***\""},{"line_number":124,"context_line":"    exec \u003e /var/tmp/k8s_install_`date +%Y%m%d%H%M%S`.log 2\u003e\u00261"},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":5,"id":"b61da60e_555e88ed","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":56},"updated":"2021-03-15 17:57:36.000000000","message":"Log file has been created in /var/tmp and not in /tmp to have persistent logs or any other reason?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"if [ \"$OUTPUT_LOGFILE\" \u003d\u003d \"True\" ]; then"},{"line_number":123,"context_line":"    echo \"*** OUTPUT LOGFILE MODE ***\""},{"line_number":124,"context_line":"    exec \u003e /var/tmp/k8s_install_`date +%Y%m%d%H%M%S`.log 2\u003e\u00261"},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":5,"id":"e5c71ba6_4795752f","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":56},"in_reply_to":"227aed2b_824883b7","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9b9a9e6236445d3514ad79db9fe995773e1a4759","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"if [ \"$OUTPUT_LOGFILE\" \u003d\u003d \"True\" ]; then"},{"line_number":123,"context_line":"    echo \"*** OUTPUT LOGFILE MODE ***\""},{"line_number":124,"context_line":"    exec \u003e /var/tmp/k8s_install_`date +%Y%m%d%H%M%S`.log 2\u003e\u00261"},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":5,"id":"227aed2b_824883b7","line":124,"range":{"start_line":124,"start_character":11,"end_line":124,"end_character":56},"in_reply_to":"b61da60e_555e88ed","updated":"2021-03-19 07:21:29.000000000","message":"Thanks for comment, I think it just place log to somewhere, not have reasons like persistent logs, so I fixed it to /tmp","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    exec \u003e /var/tmp/k8s_install_`date +%Y%m%d%H%M%S`.log 2\u003e\u00261"},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":128,"context_line":"# Variables"},{"line_number":129,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"025a3697_0d4bde1d","line":127,"updated":"2021-03-17 17:52:59.000000000","message":"I don\u0027t like such a decoration line because it has no means and just a wast of num of lines actually. Is it required actually?\n\n\"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\" or \"#------------------------\" :)","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    exec \u003e /var/tmp/k8s_install_`date +%Y%m%d%H%M%S`.log 2\u003e\u00261"},{"line_number":125,"context_line":"fi"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":128,"context_line":"# Variables"},{"line_number":129,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"79951422_afd81363","line":127,"in_reply_to":"025a3697_0d4bde1d","updated":"2021-03-22 12:15:23.000000000","message":"I have fixed it in the latest patch. Please kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":131,"context_line":"#------------------------------------------------------------------------------"},{"line_number":132,"context_line":"# Common Variables"},{"line_number":133,"context_line":"#------------------------------------------------------------------------------"},{"line_number":134,"context_line":"# For system and network"},{"line_number":135,"context_line":"declare -g STACK_USER\u003d${STACK_USER:-}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"#------------------------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":5,"id":"53fd0b91_38e04a2e","line":134,"updated":"2021-03-17 17:52:59.000000000","message":"I don\u0027t understand what do you mean by this comment.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":131,"context_line":"#------------------------------------------------------------------------------"},{"line_number":132,"context_line":"# Common Variables"},{"line_number":133,"context_line":"#------------------------------------------------------------------------------"},{"line_number":134,"context_line":"# For system and network"},{"line_number":135,"context_line":"declare -g STACK_USER\u003d${STACK_USER:-}"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"#------------------------------------------------------------------------------"}],"source_content_type":"text/x-sh","patch_set":5,"id":"28270f05_bdd353ee","line":134,"in_reply_to":"53fd0b91_38e04a2e","updated":"2021-03-22 12:15:23.000000000","message":"This script does not need to use the variable, it has been deleted.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":151,"context_line":"#------------------------------------------------------------------------------"},{"line_number":152,"context_line":"# Set public DNS"},{"line_number":153,"context_line":"function set_public_dns {"},{"line_number":154,"context_line":"    echo \"set public dns\""},{"line_number":155,"context_line":"    sudo sed -i -e \u0027s/^#DNS\u003d/DNS\u003d8.8.8.8 8.8.4.4/g\u0027 /etc/systemd/resolved.conf"},{"line_number":156,"context_line":"    sudo systemctl restart systemd-resolved.service"},{"line_number":157,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bbc2a7af_ea801066","line":154,"updated":"2021-03-17 17:52:59.000000000","message":"I think it\u0027s no need to echo such a useless message. Using `set +o xtrace` is more preferable for the purpose at the top of this script.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":151,"context_line":"#------------------------------------------------------------------------------"},{"line_number":152,"context_line":"# Set public DNS"},{"line_number":153,"context_line":"function set_public_dns {"},{"line_number":154,"context_line":"    echo \"set public dns\""},{"line_number":155,"context_line":"    sudo sed -i -e \u0027s/^#DNS\u003d/DNS\u003d8.8.8.8 8.8.4.4/g\u0027 /etc/systemd/resolved.conf"},{"line_number":156,"context_line":"    sudo systemctl restart systemd-resolved.service"},{"line_number":157,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"044b66b5_6d26be8d","line":154,"in_reply_to":"bbc2a7af_ea801066","updated":"2021-03-22 12:15:23.000000000","message":"Thank you for your advice. I have fixed it in the latest patch. \nThe same content as here has also been fixed.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        tmp_result\u003d`echo $CURRENT_HOST_IP|cut -d\".\" -f4`"},{"line_number":177,"context_line":"        sudo /usr/bin/hostnamectl set-hostname worker$tmp_result"},{"line_number":178,"context_line":"    else"},{"line_number":179,"context_line":"        echo \"error. please execute sh sh_name -h.\""},{"line_number":180,"context_line":"        exit 0"},{"line_number":181,"context_line":"    fi"},{"line_number":182,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"8e1db1cc_6aad1361","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":46},"updated":"2021-03-15 17:57:36.000000000","message":"IMO this error message expects user to run \"install_k8s_cluster.sh\" with \"-h\" option. If my assumption is correct then please add shell script name in message.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9b9a9e6236445d3514ad79db9fe995773e1a4759","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        tmp_result\u003d`echo $CURRENT_HOST_IP|cut -d\".\" -f4`"},{"line_number":177,"context_line":"        sudo /usr/bin/hostnamectl set-hostname worker$tmp_result"},{"line_number":178,"context_line":"    else"},{"line_number":179,"context_line":"        echo \"error. please execute sh sh_name -h.\""},{"line_number":180,"context_line":"        exit 0"},{"line_number":181,"context_line":"    fi"},{"line_number":182,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"c8a0d981_18f6addd","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":46},"in_reply_to":"8e1db1cc_6aad1361","updated":"2021-03-19 07:21:29.000000000","message":"Thanks for comment, fixed","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        tmp_result\u003d`echo $CURRENT_HOST_IP|cut -d\".\" -f4`"},{"line_number":177,"context_line":"        sudo /usr/bin/hostnamectl set-hostname worker$tmp_result"},{"line_number":178,"context_line":"    else"},{"line_number":179,"context_line":"        echo \"error. please execute sh sh_name -h.\""},{"line_number":180,"context_line":"        exit 0"},{"line_number":181,"context_line":"    fi"},{"line_number":182,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":5,"id":"01d015e6_32359c55","line":179,"range":{"start_line":179,"start_character":39,"end_line":179,"end_character":46},"in_reply_to":"c8a0d981_18f6addd","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":189,"context_line":"function set_hosts {"},{"line_number":190,"context_line":"    echo \"set hosts\""},{"line_number":191,"context_line":"    sudo sed -i -e \u0027s/127.0.0.1 localhost/127.0.0.1 localhost master/g\u0027 /etc/hosts"},{"line_number":192,"context_line":"    sudo sed -i -e \u0027s/127.0.1.1 ubuntu/127.0.1.1 ubuntu master/g\u0027 /etc/hosts"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"function invalidate_swap {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"f1fdf189_714c9e4f","line":192,"range":{"start_line":192,"start_character":32,"end_line":192,"end_character":38},"updated":"2021-03-15 17:57:36.000000000","message":"This entry in /etc/hosts is the hostname of machine. Should this be replace by machine\u0027s hostname?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":189,"context_line":"function set_hosts {"},{"line_number":190,"context_line":"    echo \"set hosts\""},{"line_number":191,"context_line":"    sudo sed -i -e \u0027s/127.0.0.1 localhost/127.0.0.1 localhost master/g\u0027 /etc/hosts"},{"line_number":192,"context_line":"    sudo sed -i -e \u0027s/127.0.1.1 ubuntu/127.0.1.1 ubuntu master/g\u0027 /etc/hosts"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"function invalidate_swap {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"50415993_bc34f40c","line":192,"range":{"start_line":192,"start_character":32,"end_line":192,"end_character":38},"in_reply_to":"8b1a3a1a_31ff09fd","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9b9a9e6236445d3514ad79db9fe995773e1a4759","unresolved":true,"context_lines":[{"line_number":189,"context_line":"function set_hosts {"},{"line_number":190,"context_line":"    echo \"set hosts\""},{"line_number":191,"context_line":"    sudo sed -i -e \u0027s/127.0.0.1 localhost/127.0.0.1 localhost master/g\u0027 /etc/hosts"},{"line_number":192,"context_line":"    sudo sed -i -e \u0027s/127.0.1.1 ubuntu/127.0.1.1 ubuntu master/g\u0027 /etc/hosts"},{"line_number":193,"context_line":"}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"function invalidate_swap {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"8b1a3a1a_31ff09fd","line":192,"range":{"start_line":192,"start_character":32,"end_line":192,"end_character":38},"in_reply_to":"f1fdf189_714c9e4f","updated":"2021-03-19 07:21:29.000000000","message":"Thanks for comment, fixed to replace hostname","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":377,"context_line":"EOF"},{"line_number":378,"context_line":"    sudo systemctl daemon-reload"},{"line_number":379,"context_line":"    sudo systemctl restart docker"},{"line_number":380,"context_line":"    sleep 3"},{"line_number":381,"context_line":"    result\u003d$(sudo systemctl status docker | grep Active | grep \"running\")"},{"line_number":382,"context_line":"    if [[ -z \"$result\" ]]; then"},{"line_number":383,"context_line":"        exit 0"}],"source_content_type":"text/x-sh","patch_set":5,"id":"429763cd_1f0c8436","line":380,"updated":"2021-03-17 17:52:59.000000000","message":"There are many variations of `sleep x`, but I don\u0027t understand how did you decide the value of the value `x` given to `sleep`. Could you make it clear that?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":377,"context_line":"EOF"},{"line_number":378,"context_line":"    sudo systemctl daemon-reload"},{"line_number":379,"context_line":"    sudo systemctl restart docker"},{"line_number":380,"context_line":"    sleep 3"},{"line_number":381,"context_line":"    result\u003d$(sudo systemctl status docker | grep Active | grep \"running\")"},{"line_number":382,"context_line":"    if [[ -z \"$result\" ]]; then"},{"line_number":383,"context_line":"        exit 0"}],"source_content_type":"text/x-sh","patch_set":5,"id":"bc4fa7ec_f13bc436","line":380,"in_reply_to":"429763cd_1f0c8436","updated":"2021-03-22 12:15:23.000000000","message":"In fact, the time x is the minimum time tested in the actual test to ensure that the next command can run normally.\nSo I have not modified this part of the code, please let me know if it is necessary to modify it, and I will fix it in the next patch","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":517,"context_line":"EOF"},{"line_number":518,"context_line":"    kubectl apply -f test-nginx-deployment.yaml"},{"line_number":519,"context_line":"    kubectl apply -f test-nginx-service.yaml"},{"line_number":520,"context_line":"    echo \"pleace wait 1m to create resources...\""},{"line_number":521,"context_line":"    sleep 60"},{"line_number":522,"context_line":"    kubectl get pod,deployment,service -o wide"},{"line_number":523,"context_line":"    pod_name\u003d`kubectl get pod | grep nginx-deployment | head -1 | awk \u0027{print $1}\u0027`"}],"source_content_type":"text/x-sh","patch_set":5,"id":"abd0b33e_96e1b640","line":520,"range":{"start_line":520,"start_character":10,"end_line":520,"end_character":16},"updated":"2021-03-15 17:57:36.000000000","message":"Misspell word, change \"pleace\" to \"please\".","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9b9a9e6236445d3514ad79db9fe995773e1a4759","unresolved":true,"context_lines":[{"line_number":517,"context_line":"EOF"},{"line_number":518,"context_line":"    kubectl apply -f test-nginx-deployment.yaml"},{"line_number":519,"context_line":"    kubectl apply -f test-nginx-service.yaml"},{"line_number":520,"context_line":"    echo \"pleace wait 1m to create resources...\""},{"line_number":521,"context_line":"    sleep 60"},{"line_number":522,"context_line":"    kubectl get pod,deployment,service -o wide"},{"line_number":523,"context_line":"    pod_name\u003d`kubectl get pod | grep nginx-deployment | head -1 | awk \u0027{print $1}\u0027`"}],"source_content_type":"text/x-sh","patch_set":5,"id":"c062b4ba_93c2163d","line":520,"range":{"start_line":520,"start_character":10,"end_line":520,"end_character":16},"in_reply_to":"abd0b33e_96e1b640","updated":"2021-03-19 07:21:29.000000000","message":"Thanks for comment ,fixed","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":517,"context_line":"EOF"},{"line_number":518,"context_line":"    kubectl apply -f test-nginx-deployment.yaml"},{"line_number":519,"context_line":"    kubectl apply -f test-nginx-service.yaml"},{"line_number":520,"context_line":"    echo \"pleace wait 1m to create resources...\""},{"line_number":521,"context_line":"    sleep 60"},{"line_number":522,"context_line":"    kubectl get pod,deployment,service -o wide"},{"line_number":523,"context_line":"    pod_name\u003d`kubectl get pod | grep nginx-deployment | head -1 | awk \u0027{print $1}\u0027`"}],"source_content_type":"text/x-sh","patch_set":5,"id":"0e807416_76fac18d","line":520,"range":{"start_line":520,"start_character":10,"end_line":520,"end_character":16},"in_reply_to":"c062b4ba_93c2163d","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":534,"context_line":"        done"},{"line_number":535,"context_line":"        split_ips\u003d(${CURRENT_HOST_IP//./ })"},{"line_number":536,"context_line":"        kubectl taint node master${split_ips[3]} $node_role:NoSchedule-"},{"line_number":537,"context_line":"        echo \"pleace wait 500s to create resources successfully...\""},{"line_number":538,"context_line":"        sleep 500"},{"line_number":539,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":540,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7f29a21e_cc682586","line":537,"range":{"start_line":537,"start_character":14,"end_line":537,"end_character":20},"updated":"2021-03-15 17:57:36.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":534,"context_line":"        done"},{"line_number":535,"context_line":"        split_ips\u003d(${CURRENT_HOST_IP//./ })"},{"line_number":536,"context_line":"        kubectl taint node master${split_ips[3]} $node_role:NoSchedule-"},{"line_number":537,"context_line":"        echo \"pleace wait 500s to create resources successfully...\""},{"line_number":538,"context_line":"        sleep 500"},{"line_number":539,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":540,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":5,"id":"0510553d_236070a6","line":537,"range":{"start_line":537,"start_character":14,"end_line":537,"end_character":20},"in_reply_to":"7a9e6b60_a483d2fe","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9b9a9e6236445d3514ad79db9fe995773e1a4759","unresolved":true,"context_lines":[{"line_number":534,"context_line":"        done"},{"line_number":535,"context_line":"        split_ips\u003d(${CURRENT_HOST_IP//./ })"},{"line_number":536,"context_line":"        kubectl taint node master${split_ips[3]} $node_role:NoSchedule-"},{"line_number":537,"context_line":"        echo \"pleace wait 500s to create resources successfully...\""},{"line_number":538,"context_line":"        sleep 500"},{"line_number":539,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":540,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7a9e6b60_a483d2fe","line":537,"range":{"start_line":537,"start_character":14,"end_line":537,"end_character":20},"in_reply_to":"7f29a21e_cc682586","updated":"2021-03-19 07:21:29.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        sleep 500"},{"line_number":539,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":540,"context_line":"    else"},{"line_number":541,"context_line":"        echo \"pleace wait 500s to create resources successfully...\""},{"line_number":542,"context_line":"        sleep 500"},{"line_number":543,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":544,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ccf9bb6e_f58cd779","line":541,"range":{"start_line":541,"start_character":14,"end_line":541,"end_character":20},"updated":"2021-03-15 17:57:36.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9b9a9e6236445d3514ad79db9fe995773e1a4759","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        sleep 500"},{"line_number":539,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":540,"context_line":"    else"},{"line_number":541,"context_line":"        echo \"pleace wait 500s to create resources successfully...\""},{"line_number":542,"context_line":"        sleep 500"},{"line_number":543,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":544,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ed4a21f5_c3db81c0","line":541,"range":{"start_line":541,"start_character":14,"end_line":541,"end_character":20},"in_reply_to":"ccf9bb6e_f58cd779","updated":"2021-03-19 07:21:29.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        sleep 500"},{"line_number":539,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":540,"context_line":"    else"},{"line_number":541,"context_line":"        echo \"pleace wait 500s to create resources successfully...\""},{"line_number":542,"context_line":"        sleep 500"},{"line_number":543,"context_line":"        kubectl get pod,deployment,service -o wide"},{"line_number":544,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"911536c7_9d8707ca","line":541,"range":{"start_line":541,"start_character":14,"end_line":541,"end_character":20},"in_reply_to":"ed4a21f5_c3db81c0","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":571,"context_line":"    time_stop \"apt-get-update\""},{"line_number":572,"context_line":"}"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# time_start $name"},{"line_number":575,"context_line":"#"},{"line_number":576,"context_line":"# starts the clock for a timer by name. Errors if that clock is"},{"line_number":577,"context_line":"# already started."},{"line_number":578,"context_line":"function time_start {"},{"line_number":579,"context_line":"    echo \"time_start\""},{"line_number":580,"context_line":"    local name\u003d$1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"d73a27d3_e82aa78d","line":577,"range":{"start_line":574,"start_character":0,"end_line":577,"end_character":18},"updated":"2021-03-17 17:52:59.000000000","message":"Why don\u0027t you start comment messages with capital letter because it is hard to find out just a comment out of a function or comment message?\n\n`time_start $name` is a comment, or just commenting out?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":571,"context_line":"    time_stop \"apt-get-update\""},{"line_number":572,"context_line":"}"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"# time_start $name"},{"line_number":575,"context_line":"#"},{"line_number":576,"context_line":"# starts the clock for a timer by name. Errors if that clock is"},{"line_number":577,"context_line":"# already started."},{"line_number":578,"context_line":"function time_start {"},{"line_number":579,"context_line":"    echo \"time_start\""},{"line_number":580,"context_line":"    local name\u003d$1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"0ef3109d_e535ad5e","line":577,"range":{"start_line":574,"start_character":0,"end_line":577,"end_character":18},"in_reply_to":"d73a27d3_e82aa78d","updated":"2021-03-22 12:15:23.000000000","message":"It is just commenting out. I have fixed comment message in the latest patch.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":640,"context_line":"}"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":643,"context_line":"# Main functions"},{"line_number":644,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":645,"context_line":"function main_master {"},{"line_number":646,"context_line":"    echo \"main_master\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"34643a50_7bedcb65","line":643,"range":{"start_line":643,"start_character":2,"end_line":643,"end_character":16},"updated":"2021-03-17 17:52:59.000000000","message":"I don\u0027t understand what do you mean by `Main functions` and following `Main` part.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":640,"context_line":"}"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":643,"context_line":"# Main functions"},{"line_number":644,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":645,"context_line":"function main_master {"},{"line_number":646,"context_line":"    echo \"main_master\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"eef4d397_f8cb6e6f","line":643,"range":{"start_line":643,"start_character":2,"end_line":643,"end_character":16},"in_reply_to":"34643a50_7bedcb65","updated":"2021-03-22 12:15:23.000000000","message":"I have fixed it in the latest patch.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2f2d93dc682b88f26a9aa1ece6e7d52a3ddb93d2","unresolved":true,"context_lines":[{"line_number":712,"context_line":"    set_k8s_components"},{"line_number":713,"context_line":"    add_master_node"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"#   check_k8s_resource"},{"line_number":716,"context_line":"}"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"function main_worker {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"63168040_1c769a51","line":715,"range":{"start_line":715,"start_character":0,"end_line":715,"end_character":22},"updated":"2021-03-15 17:57:36.000000000","message":"In normal master we are not checking k8s resources, could we remove this.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"3dc7de784f2a7be6b7882af6867054a8cd836105","unresolved":true,"context_lines":[{"line_number":712,"context_line":"    set_k8s_components"},{"line_number":713,"context_line":"    add_master_node"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"#   check_k8s_resource"},{"line_number":716,"context_line":"}"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"function main_worker {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dce5edbf_08c31e47","line":715,"range":{"start_line":715,"start_character":0,"end_line":715,"end_character":22},"in_reply_to":"0c40ce29_c085499d","updated":"2021-03-19 13:00:37.000000000","message":"I have confirmed.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9b9a9e6236445d3514ad79db9fe995773e1a4759","unresolved":true,"context_lines":[{"line_number":712,"context_line":"    set_k8s_components"},{"line_number":713,"context_line":"    add_master_node"},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"#   check_k8s_resource"},{"line_number":716,"context_line":"}"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"function main_worker {"}],"source_content_type":"text/x-sh","patch_set":5,"id":"0c40ce29_c085499d","line":715,"range":{"start_line":715,"start_character":0,"end_line":715,"end_character":22},"in_reply_to":"63168040_1c769a51","updated":"2021-03-19 07:21:29.000000000","message":"Thanks for comment, in master we are doing nothing here so I deleted this comment out","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":768,"context_line":"    echo \"Start install to worker node\""},{"line_number":769,"context_line":"    main_worker"},{"line_number":770,"context_line":"else"},{"line_number":771,"context_line":"    echo \"Install Failed!\""},{"line_number":772,"context_line":"    exit 255"},{"line_number":773,"context_line":"fi"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"19bab16c_d2d92136","line":771,"range":{"start_line":771,"start_character":9,"end_line":771,"end_character":26},"updated":"2021-03-17 17:52:59.000000000","message":"Messages \"Install Failed!\" or \"Install Success!\" seem not enough for explaining the reason for me actually. Can you describe more specific reasons for the messages?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":768,"context_line":"    echo \"Start install to worker node\""},{"line_number":769,"context_line":"    main_worker"},{"line_number":770,"context_line":"else"},{"line_number":771,"context_line":"    echo \"Install Failed!\""},{"line_number":772,"context_line":"    exit 255"},{"line_number":773,"context_line":"fi"},{"line_number":774,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"c3ba379e_3e289029","line":771,"range":{"start_line":771,"start_character":9,"end_line":771,"end_character":26},"in_reply_to":"19bab16c_d2d92136","updated":"2021-03-22 12:15:23.000000000","message":"I have fixed it in the latest patch.Please kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":769,"context_line":"    main_worker"},{"line_number":770,"context_line":"else"},{"line_number":771,"context_line":"    echo \"Install Failed!\""},{"line_number":772,"context_line":"    exit 255"},{"line_number":773,"context_line":"fi"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"if [[ \"$INSTALL_MODE\" \u003d~ \"master\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"c4ab2097_0b8d48f5","line":772,"range":{"start_line":772,"start_character":9,"end_line":772,"end_character":12},"updated":"2021-03-17 17:52:59.000000000","message":"Just a question. Why do you use exit code 255 at here and followings?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":769,"context_line":"    main_worker"},{"line_number":770,"context_line":"else"},{"line_number":771,"context_line":"    echo \"Install Failed!\""},{"line_number":772,"context_line":"    exit 255"},{"line_number":773,"context_line":"fi"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"if [[ \"$INSTALL_MODE\" \u003d~ \"master\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":5,"id":"db987973_4cd55b13","line":772,"range":{"start_line":772,"start_character":9,"end_line":772,"end_character":12},"in_reply_to":"c4ab2097_0b8d48f5","updated":"2021-03-22 12:15:23.000000000","message":"IMO, code 0 means that the script ends normally and the installation is successful. Other numbers means installation failure, and 255 is a more general failure exit code.\nI don\u0027t have much experience in shell scripts. If you have a better solution, please let me know, and I will fix it in next patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"}],"samples/mgmt_driver/kubernetes_mgmt.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"            # set k8s_cluster\u0027s values"},{"line_number":371,"context_line":"            for vm_dict in vm_dict_list:"},{"line_number":372,"context_line":"                vm_dict[\"k8s_cluster\"] \u003d {}"},{"line_number":373,"context_line":"                vm_dict[\"k8s_cluster\"][\"pod_cidr\"] \u003d \\"},{"line_number":374,"context_line":"                    node.get(\u0027pod_cidr\u0027)"},{"line_number":375,"context_line":"                vm_dict[\"k8s_cluster\"][\"cluster_cidr\"] \u003d \\"},{"line_number":376,"context_line":"                    node.get(\u0027cluster_cidr\u0027)"},{"line_number":377,"context_line":"                vm_dict[\"k8s_cluster\"][\"ipaddr\"] \u003d cluster_ip"},{"line_number":378,"context_line":"                vm_dict[\"k8s_cluster\"][\"cluster_fip\"] \u003d cluster_fip"},{"line_number":379,"context_line":"        return vm_dict_list"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _get_hosts(self, master_vm_dict_list, worker_vm_dict_list):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae0c11c_8c9fea7e","line":378,"range":{"start_line":372,"start_character":16,"end_line":378,"end_character":67},"updated":"2021-03-07 02:19:22.000000000","message":"Why don\u0027t you use the same manner of creating dict above?\n\n--\n\nvm_dict[\"k8s_cluster\"] \u003d {\n    \"pod_cidr\": node.get(\u0027pod_cidr\u0027),\n    \"cluster_cidr\": node.get(\u0027cluster_cidr\u0027),\n    \"ipaddr\": cluster_ip,\n    \"cluster_fip\": cluster_fip\n}","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"            # set k8s_cluster\u0027s values"},{"line_number":371,"context_line":"            for vm_dict in vm_dict_list:"},{"line_number":372,"context_line":"                vm_dict[\"k8s_cluster\"] \u003d {}"},{"line_number":373,"context_line":"                vm_dict[\"k8s_cluster\"][\"pod_cidr\"] \u003d \\"},{"line_number":374,"context_line":"                    node.get(\u0027pod_cidr\u0027)"},{"line_number":375,"context_line":"                vm_dict[\"k8s_cluster\"][\"cluster_cidr\"] \u003d \\"},{"line_number":376,"context_line":"                    node.get(\u0027cluster_cidr\u0027)"},{"line_number":377,"context_line":"                vm_dict[\"k8s_cluster\"][\"ipaddr\"] \u003d cluster_ip"},{"line_number":378,"context_line":"                vm_dict[\"k8s_cluster\"][\"cluster_fip\"] \u003d cluster_fip"},{"line_number":379,"context_line":"        return vm_dict_list"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _get_hosts(self, master_vm_dict_list, worker_vm_dict_list):"}],"source_content_type":"text/x-python","patch_set":3,"id":"87f80222_b1df9884","line":378,"range":{"start_line":372,"start_character":16,"end_line":378,"end_character":67},"in_reply_to":"9cc915ab_7958f386","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"            # set k8s_cluster\u0027s values"},{"line_number":371,"context_line":"            for vm_dict in vm_dict_list:"},{"line_number":372,"context_line":"                vm_dict[\"k8s_cluster\"] \u003d {}"},{"line_number":373,"context_line":"                vm_dict[\"k8s_cluster\"][\"pod_cidr\"] \u003d \\"},{"line_number":374,"context_line":"                    node.get(\u0027pod_cidr\u0027)"},{"line_number":375,"context_line":"                vm_dict[\"k8s_cluster\"][\"cluster_cidr\"] \u003d \\"},{"line_number":376,"context_line":"                    node.get(\u0027cluster_cidr\u0027)"},{"line_number":377,"context_line":"                vm_dict[\"k8s_cluster\"][\"ipaddr\"] \u003d cluster_ip"},{"line_number":378,"context_line":"                vm_dict[\"k8s_cluster\"][\"cluster_fip\"] \u003d cluster_fip"},{"line_number":379,"context_line":"        return vm_dict_list"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _get_hosts(self, master_vm_dict_list, worker_vm_dict_list):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9cc915ab_7958f386","line":378,"range":{"start_line":372,"start_character":16,"end_line":378,"end_character":67},"in_reply_to":"dae0c11c_8c9fea7e","updated":"2021-03-11 05:04:08.000000000","message":"I modified the way of creating this dict in new patch.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        hosts_str \u003d \u0027\\\\n\u0027.join(hosts)"},{"line_number":393,"context_line":"        return hosts_str"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def _connect_ssh_ha(self, user, password, host,"},{"line_number":396,"context_line":"                        vnf_package_path\u003dNone, script_path\u003dNone):"},{"line_number":397,"context_line":"        # ha and scale: connect ssh"},{"line_number":398,"context_line":"        retry \u003d 4"}],"source_content_type":"text/x-python","patch_set":3,"id":"87f7400e_8505474b","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":23},"updated":"2021-03-07 02:19:22.000000000","message":"This method name is misleading. This returns RemoteCommandExector, and sends scripts and token to the target. Also not sure why this is named to have \"ha\".","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        hosts_str \u003d \u0027\\\\n\u0027.join(hosts)"},{"line_number":393,"context_line":"        return hosts_str"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def _connect_ssh_ha(self, user, password, host,"},{"line_number":396,"context_line":"                        vnf_package_path\u003dNone, script_path\u003dNone):"},{"line_number":397,"context_line":"        # ha and scale: connect ssh"},{"line_number":398,"context_line":"        retry \u003d 4"}],"source_content_type":"text/x-python","patch_set":3,"id":"dc9fe1cb_8729c314","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":23},"in_reply_to":"87787798_d1292510","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":392,"context_line":"        hosts_str \u003d \u0027\\\\n\u0027.join(hosts)"},{"line_number":393,"context_line":"        return hosts_str"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def _connect_ssh_ha(self, user, password, host,"},{"line_number":396,"context_line":"                        vnf_package_path\u003dNone, script_path\u003dNone):"},{"line_number":397,"context_line":"        # ha and scale: connect ssh"},{"line_number":398,"context_line":"        retry \u003d 4"}],"source_content_type":"text/x-python","patch_set":3,"id":"87787798_d1292510","line":395,"range":{"start_line":395,"start_character":8,"end_line":395,"end_character":23},"in_reply_to":"87f7400e_8505474b","updated":"2021-03-11 05:04:08.000000000","message":"I changed the name of the method.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":678,"context_line":"                cluster_ip, kubeadm_token, ssl_ca_cert_hash)"},{"line_number":679,"context_line":"            commander.close_session()"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        self._create_vim(context, vnf_instance, server,"},{"line_number":682,"context_line":"                         bearer_token, ssl_ca_cert, vim_name, project_name,"},{"line_number":683,"context_line":"                         master_vm_dict_list)"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def _check_values(self, additional_param):"},{"line_number":686,"context_line":"        for key, value in additional_param.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"799d612e_76113827","line":683,"range":{"start_line":681,"start_character":8,"end_line":683,"end_character":45},"updated":"2021-03-07 02:19:22.000000000","message":"It\u0027s better to locate this logic in ``instantiate_end()`` method.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":678,"context_line":"                cluster_ip, kubeadm_token, ssl_ca_cert_hash)"},{"line_number":679,"context_line":"            commander.close_session()"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        self._create_vim(context, vnf_instance, server,"},{"line_number":682,"context_line":"                         bearer_token, ssl_ca_cert, vim_name, project_name,"},{"line_number":683,"context_line":"                         master_vm_dict_list)"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def _check_values(self, additional_param):"},{"line_number":686,"context_line":"        for key, value in additional_param.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"976bfc68_d46f625e","line":683,"range":{"start_line":681,"start_character":8,"end_line":683,"end_character":45},"in_reply_to":"799d612e_76113827","updated":"2021-03-11 05:04:08.000000000","message":"I have put the logic in the ``instantiate_end()\u0027\u0027 method.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                cluster_ip, kubeadm_token, ssl_ca_cert_hash)"},{"line_number":679,"context_line":"            commander.close_session()"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        self._create_vim(context, vnf_instance, server,"},{"line_number":682,"context_line":"                         bearer_token, ssl_ca_cert, vim_name, project_name,"},{"line_number":683,"context_line":"                         master_vm_dict_list)"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def _check_values(self, additional_param):"},{"line_number":686,"context_line":"        for key, value in additional_param.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"2a034a46_318d7e89","line":683,"range":{"start_line":681,"start_character":8,"end_line":683,"end_character":45},"in_reply_to":"976bfc68_d46f625e","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":762,"context_line":"        # get vm list"},{"line_number":763,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":764,"context_line":"        master_vm_dict_list \u003d \\"},{"line_number":765,"context_line":"            self._get_k8s_ssh_ips("},{"line_number":766,"context_line":"                nest_stack_id, master_node,"},{"line_number":767,"context_line":"                instantiate_vnf_request.additional_params,"},{"line_number":768,"context_line":"                \u0027master\u0027, access_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4bda7dba_62d0a117","line":765,"range":{"start_line":765,"start_character":17,"end_line":765,"end_character":33},"updated":"2021-03-07 02:19:22.000000000","message":"Is this method name correct? This method generates not only ssh_ips but also options for kubernetes clusters.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":762,"context_line":"        # get vm list"},{"line_number":763,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":764,"context_line":"        master_vm_dict_list \u003d \\"},{"line_number":765,"context_line":"            self._get_k8s_ssh_ips("},{"line_number":766,"context_line":"                nest_stack_id, master_node,"},{"line_number":767,"context_line":"                instantiate_vnf_request.additional_params,"},{"line_number":768,"context_line":"                \u0027master\u0027, access_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8ebd5779_9bb02996","line":765,"range":{"start_line":765,"start_character":17,"end_line":765,"end_character":33},"in_reply_to":"4bda7dba_62d0a117","updated":"2021-03-11 05:04:08.000000000","message":"I modified the method name.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        # get vm list"},{"line_number":763,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":764,"context_line":"        master_vm_dict_list \u003d \\"},{"line_number":765,"context_line":"            self._get_k8s_ssh_ips("},{"line_number":766,"context_line":"                nest_stack_id, master_node,"},{"line_number":767,"context_line":"                instantiate_vnf_request.additional_params,"},{"line_number":768,"context_line":"                \u0027master\u0027, access_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb7a88a4_72c330d6","line":765,"range":{"start_line":765,"start_character":17,"end_line":765,"end_character":33},"in_reply_to":"8ebd5779_9bb02996","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":766,"context_line":"                nest_stack_id, master_node,"},{"line_number":767,"context_line":"                instantiate_vnf_request.additional_params,"},{"line_number":768,"context_line":"                \u0027master\u0027, access_info)"},{"line_number":769,"context_line":"        worker_vm_dict_list \u003d self._get_k8s_ssh_ips("},{"line_number":770,"context_line":"            nest_stack_id, worker_node,"},{"line_number":771,"context_line":"            instantiate_vnf_request.additional_params, \u0027worker\u0027, access_info)"},{"line_number":772,"context_line":"        self._install_k8s_cluster(context, vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ebb35f8_9047139f","line":769,"range":{"start_line":769,"start_character":35,"end_line":769,"end_character":51},"updated":"2021-03-07 02:19:22.000000000","message":"ditto","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                nest_stack_id, master_node,"},{"line_number":767,"context_line":"                instantiate_vnf_request.additional_params,"},{"line_number":768,"context_line":"                \u0027master\u0027, access_info)"},{"line_number":769,"context_line":"        worker_vm_dict_list \u003d self._get_k8s_ssh_ips("},{"line_number":770,"context_line":"            nest_stack_id, worker_node,"},{"line_number":771,"context_line":"            instantiate_vnf_request.additional_params, \u0027worker\u0027, access_info)"},{"line_number":772,"context_line":"        self._install_k8s_cluster(context, vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0e583620_3d8abffb","line":769,"range":{"start_line":769,"start_character":35,"end_line":769,"end_character":51},"in_reply_to":"0a84a75e_3c71b549","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":766,"context_line":"                nest_stack_id, master_node,"},{"line_number":767,"context_line":"                instantiate_vnf_request.additional_params,"},{"line_number":768,"context_line":"                \u0027master\u0027, access_info)"},{"line_number":769,"context_line":"        worker_vm_dict_list \u003d self._get_k8s_ssh_ips("},{"line_number":770,"context_line":"            nest_stack_id, worker_node,"},{"line_number":771,"context_line":"            instantiate_vnf_request.additional_params, \u0027worker\u0027, access_info)"},{"line_number":772,"context_line":"        self._install_k8s_cluster(context, vnf_instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0a84a75e_3c71b549","line":769,"range":{"start_line":769,"start_character":35,"end_line":769,"end_character":51},"in_reply_to":"6ebb35f8_9047139f","updated":"2021-03-11 05:04:08.000000000","message":"I modified the method name.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":799,"context_line":"                              \" vim with name: {}\".format(k8s_vim_name))"},{"line_number":800,"context_line":"        return result.id"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    def terminate_end(self, context, vnf_instance,"},{"line_number":803,"context_line":"                      terminate_vnf_request, grant,"},{"line_number":804,"context_line":"                      grant_request, **kwargs):"},{"line_number":805,"context_line":"        k8s_params \u003d vnf_instance.instantiated_vnf_info.additional_params.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"e3c0cc94_8a3eca82","line":802,"range":{"start_line":802,"start_character":8,"end_line":802,"end_character":21},"updated":"2021-03-07 02:19:22.000000000","message":"Why don\u0027t you delete the Kubernetes cluster info in VnfInstance.vimConnectionInfo?","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":799,"context_line":"                              \" vim with name: {}\".format(k8s_vim_name))"},{"line_number":800,"context_line":"        return result.id"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    def terminate_end(self, context, vnf_instance,"},{"line_number":803,"context_line":"                      terminate_vnf_request, grant,"},{"line_number":804,"context_line":"                      grant_request, **kwargs):"},{"line_number":805,"context_line":"        k8s_params \u003d vnf_instance.instantiated_vnf_info.additional_params.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"f72b18ae_9e9a77cd","line":802,"range":{"start_line":802,"start_character":8,"end_line":802,"end_character":21},"in_reply_to":"591b407d_2db11d7a","updated":"2021-03-15 09:26:59.000000000","message":"Thank you. Understood.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"bccc318e6636e259407e1f205496575c96338ad3","unresolved":true,"context_lines":[{"line_number":799,"context_line":"                              \" vim with name: {}\".format(k8s_vim_name))"},{"line_number":800,"context_line":"        return result.id"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    def terminate_end(self, context, vnf_instance,"},{"line_number":803,"context_line":"                      terminate_vnf_request, grant,"},{"line_number":804,"context_line":"                      grant_request, **kwargs):"},{"line_number":805,"context_line":"        k8s_params \u003d vnf_instance.instantiated_vnf_info.additional_params.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"591b407d_2db11d7a","line":802,"range":{"start_line":802,"start_character":8,"end_line":802,"end_character":21},"in_reply_to":"e3c0cc94_8a3eca82","updated":"2021-03-09 06:56:29.000000000","message":"The vimConnectionInfo has been deleted after \u0027terminate\u0027 operation by vnflcm_driver.\nIn tacker/vnflcm/vnflcm_driver.py\n```\n            vnf_instance.instantiated_vnf_info.reinitialize()\n            self._vnf_instance_update(context, vnf_instance,\n                vim_connection_info\u003d[], task_state\u003dNone)\n```","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1119,"context_line":"            master_nic_ip_list.append(master_nic_ip)"},{"line_number":1120,"context_line":"        return master_ssh_ip_list, master_nic_ip_list"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def scale_end(self, context, vnf_instance,"},{"line_number":1123,"context_line":"                  scale_vnf_request, grant,"},{"line_number":1124,"context_line":"                  grant_request, **kwargs):"},{"line_number":1125,"context_line":"        k8s_cluster_installation_param \u003d vnf_instance.instantiated_vnf_info. \\"},{"line_number":1126,"context_line":"            additional_params.get(\u0027k8s_cluster_installation_param\u0027)"},{"line_number":1127,"context_line":"        vnf_package_path \u003d vnflcm_utils._get_vnf_package_path("}],"source_content_type":"text/x-python","patch_set":3,"id":"f513c778_9a8e4b62","line":1124,"range":{"start_line":1122,"start_character":8,"end_line":1124,"end_character":43},"updated":"2021-03-07 02:19:22.000000000","message":"Why don\u0027t you support scale-in case? It seems that this method only assume to be executed in scale-out case.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":1119,"context_line":"            master_nic_ip_list.append(master_nic_ip)"},{"line_number":1120,"context_line":"        return master_ssh_ip_list, master_nic_ip_list"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def scale_end(self, context, vnf_instance,"},{"line_number":1123,"context_line":"                  scale_vnf_request, grant,"},{"line_number":1124,"context_line":"                  grant_request, **kwargs):"},{"line_number":1125,"context_line":"        k8s_cluster_installation_param \u003d vnf_instance.instantiated_vnf_info. \\"},{"line_number":1126,"context_line":"            additional_params.get(\u0027k8s_cluster_installation_param\u0027)"},{"line_number":1127,"context_line":"        vnf_package_path \u003d vnflcm_utils._get_vnf_package_path("}],"source_content_type":"text/x-python","patch_set":3,"id":"cea3ec9f_60d4afb7","line":1124,"range":{"start_line":1122,"start_character":8,"end_line":1124,"end_character":43},"in_reply_to":"10f06bc2_d5ed0231","updated":"2021-03-18 06:12:52.000000000","message":"The method has been modified. Does the modification of vnflcm_driver.py use a new patch?","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":true,"context_lines":[{"line_number":1119,"context_line":"            master_nic_ip_list.append(master_nic_ip)"},{"line_number":1120,"context_line":"        return master_ssh_ip_list, master_nic_ip_list"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def scale_end(self, context, vnf_instance,"},{"line_number":1123,"context_line":"                  scale_vnf_request, grant,"},{"line_number":1124,"context_line":"                  grant_request, **kwargs):"},{"line_number":1125,"context_line":"        k8s_cluster_installation_param \u003d vnf_instance.instantiated_vnf_info. \\"},{"line_number":1126,"context_line":"            additional_params.get(\u0027k8s_cluster_installation_param\u0027)"},{"line_number":1127,"context_line":"        vnf_package_path \u003d vnflcm_utils._get_vnf_package_path("}],"source_content_type":"text/x-python","patch_set":3,"id":"10f06bc2_d5ed0231","line":1124,"range":{"start_line":1122,"start_character":8,"end_line":1124,"end_character":43},"in_reply_to":"636c90bb_56cc0d70","updated":"2021-03-15 09:26:59.000000000","message":"OK, I understood that it\u0027s wrong to only support scale_end for scale-out in the existing implementation. It should be also supported for scale-in case according to ESTI NFV-SOL001 v2.6.1.\n\nSo I think it\u0027s better to check the scale_vnf_request.type in the beginning of this method.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"bccc318e6636e259407e1f205496575c96338ad3","unresolved":true,"context_lines":[{"line_number":1119,"context_line":"            master_nic_ip_list.append(master_nic_ip)"},{"line_number":1120,"context_line":"        return master_ssh_ip_list, master_nic_ip_list"},{"line_number":1121,"context_line":""},{"line_number":1122,"context_line":"    def scale_end(self, context, vnf_instance,"},{"line_number":1123,"context_line":"                  scale_vnf_request, grant,"},{"line_number":1124,"context_line":"                  grant_request, **kwargs):"},{"line_number":1125,"context_line":"        k8s_cluster_installation_param \u003d vnf_instance.instantiated_vnf_info. \\"},{"line_number":1126,"context_line":"            additional_params.get(\u0027k8s_cluster_installation_param\u0027)"},{"line_number":1127,"context_line":"        vnf_package_path \u003d vnflcm_utils._get_vnf_package_path("}],"source_content_type":"text/x-python","patch_set":3,"id":"636c90bb_56cc0d70","line":1124,"range":{"start_line":1122,"start_character":8,"end_line":1124,"end_character":43},"in_reply_to":"f513c778_9a8e4b62","updated":"2021-03-09 06:56:29.000000000","message":"In vnflcm_drvier.py, only \u0027scale-out\u0027 case support \u0027scale_end\u0027. At the same time, only \u0027scale-in\u0027 case support \u0027scale_start\u0027. So this method only to be executed in scale-out case.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1137,"context_line":"        master_ssh_ip_list \u003d []"},{"line_number":1138,"context_line":"        master_nic_ip_list \u003d []"},{"line_number":1139,"context_line":"        master_node \u003d k8s_cluster_installation_param.get(\u0027master_node\u0027)"},{"line_number":1140,"context_line":"        if not master_node.get(\u0027aspect_id\u0027):"},{"line_number":1141,"context_line":"            master_ssh_ip_list.append(heatclient.resources.get("},{"line_number":1142,"context_line":"                stack_id\u003dnest_stack_id,"},{"line_number":1143,"context_line":"                resource_name\u003dmaster_node.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba023bbd_0519d933","line":1140,"range":{"start_line":1140,"start_character":8,"end_line":1140,"end_character":44},"updated":"2021-03-07 02:19:22.000000000","message":"Is this for single master case with \"simple\" deployment flavour? If yes, please add note.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1137,"context_line":"        master_ssh_ip_list \u003d []"},{"line_number":1138,"context_line":"        master_nic_ip_list \u003d []"},{"line_number":1139,"context_line":"        master_node \u003d k8s_cluster_installation_param.get(\u0027master_node\u0027)"},{"line_number":1140,"context_line":"        if not master_node.get(\u0027aspect_id\u0027):"},{"line_number":1141,"context_line":"            master_ssh_ip_list.append(heatclient.resources.get("},{"line_number":1142,"context_line":"                stack_id\u003dnest_stack_id,"},{"line_number":1143,"context_line":"                resource_name\u003dmaster_node.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"c0ca2801_f9fda3c7","line":1140,"range":{"start_line":1140,"start_character":8,"end_line":1140,"end_character":44},"in_reply_to":"ba023bbd_0519d933","updated":"2021-03-11 05:04:08.000000000","message":"I added a note in the new patch.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"        master_ssh_ip_list \u003d []"},{"line_number":1138,"context_line":"        master_nic_ip_list \u003d []"},{"line_number":1139,"context_line":"        master_node \u003d k8s_cluster_installation_param.get(\u0027master_node\u0027)"},{"line_number":1140,"context_line":"        if not master_node.get(\u0027aspect_id\u0027):"},{"line_number":1141,"context_line":"            master_ssh_ip_list.append(heatclient.resources.get("},{"line_number":1142,"context_line":"                stack_id\u003dnest_stack_id,"},{"line_number":1143,"context_line":"                resource_name\u003dmaster_node.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"14cc5b6f_3d4ff18c","line":1140,"range":{"start_line":1140,"start_character":8,"end_line":1140,"end_character":44},"in_reply_to":"c0ca2801_f9fda3c7","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1150,"context_line":"                \u0027fixed_ips\u0027)[0].get(\u0027ip_address\u0027))"},{"line_number":1151,"context_line":"            cluster_ip \u003d self._get_cluster_ip("},{"line_number":1152,"context_line":"                heatclient, 1, master_node, None, nest_stack_id)"},{"line_number":1153,"context_line":"        else:"},{"line_number":1154,"context_line":"            master_resource_list \u003d self._get_resources_list("},{"line_number":1155,"context_line":"                heatclient, nest_stack_id, master_node.get("},{"line_number":1156,"context_line":"                    \u0027aspect_id\u0027) + \u0027_group\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bd2eca10_0a36f3ed","line":1153,"range":{"start_line":1153,"start_character":8,"end_line":1153,"end_character":13},"updated":"2021-03-07 02:19:22.000000000","message":"Is this for HA master case with \"complex\" deployment flavour? If yes, please add note.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"                \u0027fixed_ips\u0027)[0].get(\u0027ip_address\u0027))"},{"line_number":1151,"context_line":"            cluster_ip \u003d self._get_cluster_ip("},{"line_number":1152,"context_line":"                heatclient, 1, master_node, None, nest_stack_id)"},{"line_number":1153,"context_line":"        else:"},{"line_number":1154,"context_line":"            master_resource_list \u003d self._get_resources_list("},{"line_number":1155,"context_line":"                heatclient, nest_stack_id, master_node.get("},{"line_number":1156,"context_line":"                    \u0027aspect_id\u0027) + \u0027_group\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9cafd765_713a3265","line":1153,"range":{"start_line":1153,"start_character":8,"end_line":1153,"end_character":13},"in_reply_to":"5e7bd285_400dbd0e","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1150,"context_line":"                \u0027fixed_ips\u0027)[0].get(\u0027ip_address\u0027))"},{"line_number":1151,"context_line":"            cluster_ip \u003d self._get_cluster_ip("},{"line_number":1152,"context_line":"                heatclient, 1, master_node, None, nest_stack_id)"},{"line_number":1153,"context_line":"        else:"},{"line_number":1154,"context_line":"            master_resource_list \u003d self._get_resources_list("},{"line_number":1155,"context_line":"                heatclient, nest_stack_id, master_node.get("},{"line_number":1156,"context_line":"                    \u0027aspect_id\u0027) + \u0027_group\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5e7bd285_400dbd0e","line":1153,"range":{"start_line":1153,"start_character":8,"end_line":1153,"end_character":13},"in_reply_to":"bd2eca10_0a36f3ed","updated":"2021-03-11 05:04:08.000000000","message":"I added a note in the new patch.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    def _get_node_resource_name(self, vnf_additional_params, node):"},{"line_number":1605,"context_line":"        if node.get(\u0027aspect_id\u0027):"},{"line_number":1606,"context_line":"            if \u0027lcm-operation-user-data\u0027 in vnf_additional_params.keys() and \\"},{"line_number":1607,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1608,"context_line":"                    vnf_additional_params.keys():"},{"line_number":1609,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1610,"context_line":"            else:"},{"line_number":1611,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ecc5ee32_4d2ef34e","line":1608,"range":{"start_line":1606,"start_character":12,"end_line":1608,"end_character":49},"updated":"2021-03-07 02:19:22.000000000","message":"Pleas add note to say \"in case of SOL001 TOSCA-based VNFD\".","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"    def _get_node_resource_name(self, vnf_additional_params, node):"},{"line_number":1605,"context_line":"        if node.get(\u0027aspect_id\u0027):"},{"line_number":1606,"context_line":"            if \u0027lcm-operation-user-data\u0027 in vnf_additional_params.keys() and \\"},{"line_number":1607,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1608,"context_line":"                    vnf_additional_params.keys():"},{"line_number":1609,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1610,"context_line":"            else:"},{"line_number":1611,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f4bb2f02_fbe6455a","line":1608,"range":{"start_line":1606,"start_character":12,"end_line":1608,"end_character":49},"in_reply_to":"ecc5ee32_4d2ef34e","updated":"2021-03-11 05:04:08.000000000","message":"I added a note in the new patch.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1608,"context_line":"                    vnf_additional_params.keys():"},{"line_number":1609,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1610,"context_line":"            else:"},{"line_number":1611,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1612,"context_line":"        else:"},{"line_number":1613,"context_line":"            resource_name \u003d node.get(\u0027nic_cp_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"8dda0e85_3ee8afdd","line":1610,"range":{"start_line":1610,"start_character":12,"end_line":1610,"end_character":17},"updated":"2021-03-07 02:19:22.000000000","message":"Please add note to say \"in case of UserData VNFD\".","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1607,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1608,"context_line":"                    vnf_additional_params.keys():"},{"line_number":1609,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1610,"context_line":"            else:"},{"line_number":1611,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1612,"context_line":"        else:"},{"line_number":1613,"context_line":"            resource_name \u003d node.get(\u0027nic_cp_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e9b32333_71fe6a9a","line":1610,"range":{"start_line":1610,"start_character":12,"end_line":1610,"end_character":17},"in_reply_to":"8dda0e85_3ee8afdd","updated":"2021-03-11 05:04:08.000000000","message":"I added a note in the new patch.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1609,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1610,"context_line":"            else:"},{"line_number":1611,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1612,"context_line":"        else:"},{"line_number":1613,"context_line":"            resource_name \u003d node.get(\u0027nic_cp_name\u0027)"},{"line_number":1614,"context_line":"        return resource_name"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c669df8a_7b85a6e1","line":1612,"range":{"start_line":1612,"start_character":8,"end_line":1612,"end_character":13},"updated":"2021-03-07 02:19:22.000000000","message":"Which case is this ``resource_name`` required?","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"bccc318e6636e259407e1f205496575c96338ad3","unresolved":true,"context_lines":[{"line_number":1609,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1610,"context_line":"            else:"},{"line_number":1611,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1612,"context_line":"        else:"},{"line_number":1613,"context_line":"            resource_name \u003d node.get(\u0027nic_cp_name\u0027)"},{"line_number":1614,"context_line":"        return resource_name"},{"line_number":1615,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0716ffa2_8b918e5d","line":1612,"range":{"start_line":1612,"start_character":8,"end_line":1612,"end_character":13},"in_reply_to":"c669df8a_7b85a6e1","updated":"2021-03-09 06:56:29.000000000","message":"If we instantiate single master node with one worker node. We can use SOL001 TOSCA-based VNFD without policies definition. (Like VDU1\u003dmasterNode,VDU2\u003dworkerNode). In this case, it does not need \u0027aspect_id\u0027.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1625,"context_line":"        worker_node \u003d vnf_additional_params.get("},{"line_number":1626,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {}).get("},{"line_number":1627,"context_line":"            \u0027worker_node\u0027, {})"},{"line_number":1628,"context_line":"        master_resource_name \u003d self._get_node_resource_name("},{"line_number":1629,"context_line":"            vnf_additional_params, master_node)"},{"line_number":1630,"context_line":"        worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1631,"context_line":"            vnf_additional_params, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1d2e59df_7b6df569","line":1628,"range":{"start_line":1628,"start_character":36,"end_line":1628,"end_character":59},"updated":"2021-03-07 02:19:22.000000000","message":"How about renaming this method to be \"_get_node_aspect_id\"?","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1625,"context_line":"        worker_node \u003d vnf_additional_params.get("},{"line_number":1626,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {}).get("},{"line_number":1627,"context_line":"            \u0027worker_node\u0027, {})"},{"line_number":1628,"context_line":"        master_resource_name \u003d self._get_node_resource_name("},{"line_number":1629,"context_line":"            vnf_additional_params, master_node)"},{"line_number":1630,"context_line":"        worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1631,"context_line":"            vnf_additional_params, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"93532cb5_6f1d284d","line":1628,"range":{"start_line":1628,"start_character":36,"end_line":1628,"end_character":59},"in_reply_to":"08a28670_264d5e88","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"bccc318e6636e259407e1f205496575c96338ad3","unresolved":true,"context_lines":[{"line_number":1625,"context_line":"        worker_node \u003d vnf_additional_params.get("},{"line_number":1626,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {}).get("},{"line_number":1627,"context_line":"            \u0027worker_node\u0027, {})"},{"line_number":1628,"context_line":"        master_resource_name \u003d self._get_node_resource_name("},{"line_number":1629,"context_line":"            vnf_additional_params, master_node)"},{"line_number":1630,"context_line":"        worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1631,"context_line":"            vnf_additional_params, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"08a28670_264d5e88","line":1628,"range":{"start_line":1628,"start_character":36,"end_line":1628,"end_character":59},"in_reply_to":"1d2e59df_7b6df569","updated":"2021-03-09 06:56:29.000000000","message":"As mentioned above, there is a case without \u0027aspect_id\u0027, so I think it is better to use resource_name.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1627,"context_line":"            \u0027worker_node\u0027, {})"},{"line_number":1628,"context_line":"        master_resource_name \u003d self._get_node_resource_name("},{"line_number":1629,"context_line":"            vnf_additional_params, master_node)"},{"line_number":1630,"context_line":"        worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1631,"context_line":"            vnf_additional_params, worker_node)"},{"line_number":1632,"context_line":"        master_username, master_password \u003d self._get_username_pwd("},{"line_number":1633,"context_line":"            heal_vnf_request, vnf_instance, \u0027master\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f90f8e7f_2666eb99","line":1630,"range":{"start_line":1630,"start_character":36,"end_line":1630,"end_character":59},"updated":"2021-03-07 02:19:22.000000000","message":"ditto","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"            \u0027worker_node\u0027, {})"},{"line_number":1628,"context_line":"        master_resource_name \u003d self._get_node_resource_name("},{"line_number":1629,"context_line":"            vnf_additional_params, master_node)"},{"line_number":1630,"context_line":"        worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1631,"context_line":"            vnf_additional_params, worker_node)"},{"line_number":1632,"context_line":"        master_username, master_password \u003d self._get_username_pwd("},{"line_number":1633,"context_line":"            heal_vnf_request, vnf_instance, \u0027master\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"94e166b8_c9fd2947","line":1630,"range":{"start_line":1630,"start_character":36,"end_line":1630,"end_character":59},"in_reply_to":"08d7b4a5_9c6888ca","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"bccc318e6636e259407e1f205496575c96338ad3","unresolved":true,"context_lines":[{"line_number":1627,"context_line":"            \u0027worker_node\u0027, {})"},{"line_number":1628,"context_line":"        master_resource_name \u003d self._get_node_resource_name("},{"line_number":1629,"context_line":"            vnf_additional_params, master_node)"},{"line_number":1630,"context_line":"        worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1631,"context_line":"            vnf_additional_params, worker_node)"},{"line_number":1632,"context_line":"        master_username, master_password \u003d self._get_username_pwd("},{"line_number":1633,"context_line":"            heal_vnf_request, vnf_instance, \u0027master\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"08d7b4a5_9c6888ca","line":1630,"range":{"start_line":1630,"start_character":36,"end_line":1630,"end_character":59},"in_reply_to":"f90f8e7f_2666eb99","updated":"2021-03-09 06:56:29.000000000","message":"ditto","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1635,"context_line":"            context, vnf_instance)"},{"line_number":1636,"context_line":"        heatclient \u003d hc.HeatClient(vim_connection_info.access_info)"},{"line_number":1637,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1638,"context_line":"            vim_id \u003d vnf_instance.vim_connection_info[1].vim_id"},{"line_number":1639,"context_line":"            nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1640,"context_line":"            nfvo_plugin.delete_vim(context, vim_id)"},{"line_number":1641,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea42107d_f1ca2277","line":1638,"range":{"start_line":1638,"start_character":12,"end_line":1638,"end_character":63},"updated":"2021-03-07 02:19:22.000000000","message":"Why don\u0027t you validate the 2nd vim_connection_info to be the Kubernetes VIM?","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1635,"context_line":"            context, vnf_instance)"},{"line_number":1636,"context_line":"        heatclient \u003d hc.HeatClient(vim_connection_info.access_info)"},{"line_number":1637,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1638,"context_line":"            vim_id \u003d vnf_instance.vim_connection_info[1].vim_id"},{"line_number":1639,"context_line":"            nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1640,"context_line":"            nfvo_plugin.delete_vim(context, vim_id)"},{"line_number":1641,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d1d1167e_8895d81b","line":1638,"range":{"start_line":1638,"start_character":12,"end_line":1638,"end_character":63},"in_reply_to":"ea42107d_f1ca2277","updated":"2021-03-11 05:04:08.000000000","message":"In the new patch I validated the type of vim.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"            nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1640,"context_line":"            nfvo_plugin.delete_vim(context, vim_id)"},{"line_number":1641,"context_line":"        else:"},{"line_number":1642,"context_line":"            target_physical_resource_ids \u003d []"},{"line_number":1643,"context_line":"            for vnfc_instance_id in heal_vnf_request.vnfc_instance_id:"},{"line_number":1644,"context_line":"                instantiated_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":1645,"context_line":"                vnfc_resource_info \u003d instantiated_vnf_info.vnfc_resource_info"},{"line_number":1646,"context_line":"                vnfc_resource \u003d self._get_vnfc_resource_id("},{"line_number":1647,"context_line":"                    vnfc_resource_info, vnfc_instance_id)"},{"line_number":1648,"context_line":"                if vnfc_resource:"},{"line_number":1649,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1650,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1651,"context_line":"            self._delete_fixed_node("},{"line_number":1652,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1653,"context_line":"                master_username, master_password, worker_resource_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4eff7527_7485edf6","line":1650,"range":{"start_line":1642,"start_character":12,"end_line":1650,"end_character":67},"updated":"2021-03-07 02:19:22.000000000","message":"How about making a private method to create target_physical_resource_ids? The exactly same logic is in ``heal_end()`` and it\u0027s weird to make only ``_get_vnfc_resource_id`` to be private method.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"            nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1640,"context_line":"            nfvo_plugin.delete_vim(context, vim_id)"},{"line_number":1641,"context_line":"        else:"},{"line_number":1642,"context_line":"            target_physical_resource_ids \u003d []"},{"line_number":1643,"context_line":"            for vnfc_instance_id in heal_vnf_request.vnfc_instance_id:"},{"line_number":1644,"context_line":"                instantiated_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":1645,"context_line":"                vnfc_resource_info \u003d instantiated_vnf_info.vnfc_resource_info"},{"line_number":1646,"context_line":"                vnfc_resource \u003d self._get_vnfc_resource_id("},{"line_number":1647,"context_line":"                    vnfc_resource_info, vnfc_instance_id)"},{"line_number":1648,"context_line":"                if vnfc_resource:"},{"line_number":1649,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1650,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1651,"context_line":"            self._delete_fixed_node("},{"line_number":1652,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1653,"context_line":"                master_username, master_password, worker_resource_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"6dd0074a_20aea08b","line":1650,"range":{"start_line":1642,"start_character":12,"end_line":1650,"end_character":67},"in_reply_to":"4eff7527_7485edf6","updated":"2021-03-11 05:04:08.000000000","message":"I created a private method in the new patch.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1639,"context_line":"            nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1640,"context_line":"            nfvo_plugin.delete_vim(context, vim_id)"},{"line_number":1641,"context_line":"        else:"},{"line_number":1642,"context_line":"            target_physical_resource_ids \u003d []"},{"line_number":1643,"context_line":"            for vnfc_instance_id in heal_vnf_request.vnfc_instance_id:"},{"line_number":1644,"context_line":"                instantiated_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":1645,"context_line":"                vnfc_resource_info \u003d instantiated_vnf_info.vnfc_resource_info"},{"line_number":1646,"context_line":"                vnfc_resource \u003d self._get_vnfc_resource_id("},{"line_number":1647,"context_line":"                    vnfc_resource_info, vnfc_instance_id)"},{"line_number":1648,"context_line":"                if vnfc_resource:"},{"line_number":1649,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1650,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1651,"context_line":"            self._delete_fixed_node("},{"line_number":1652,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1653,"context_line":"                master_username, master_password, worker_resource_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"486a4306_7ffe781d","line":1650,"range":{"start_line":1642,"start_character":12,"end_line":1650,"end_character":67},"in_reply_to":"6dd0074a_20aea08b","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1648,"context_line":"                if vnfc_resource:"},{"line_number":1649,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1650,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1651,"context_line":"            self._delete_fixed_node("},{"line_number":1652,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1653,"context_line":"                master_username, master_password, worker_resource_name,"},{"line_number":1654,"context_line":"                master_resource_name, master_node, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"d3adba0e_c375d679","line":1651,"range":{"start_line":1651,"start_character":17,"end_line":1651,"end_character":35},"updated":"2021-03-07 02:19:22.000000000","message":"Is this method name appropriate? I understand this method delete the target master/worker node from the existing Kuberntes cluster, and the node is not \"fixed\".","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1648,"context_line":"                if vnfc_resource:"},{"line_number":1649,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1650,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1651,"context_line":"            self._delete_fixed_node("},{"line_number":1652,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1653,"context_line":"                master_username, master_password, worker_resource_name,"},{"line_number":1654,"context_line":"                master_resource_name, master_node, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"beeb1536_b6cf2997","line":1651,"range":{"start_line":1651,"start_character":17,"end_line":1651,"end_character":35},"in_reply_to":"bcd7f780_3e174d3b","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1648,"context_line":"                if vnfc_resource:"},{"line_number":1649,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1650,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1651,"context_line":"            self._delete_fixed_node("},{"line_number":1652,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1653,"context_line":"                master_username, master_password, worker_resource_name,"},{"line_number":1654,"context_line":"                master_resource_name, master_node, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bcd7f780_3e174d3b","line":1651,"range":{"start_line":1651,"start_character":17,"end_line":1651,"end_character":35},"in_reply_to":"d3adba0e_c375d679","updated":"2021-03-11 05:04:08.000000000","message":"I modified the method name.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1931,"context_line":"                                 vnf_instance.instantiated_vnf_info, **kwargs)"},{"line_number":1932,"context_line":"        else:"},{"line_number":1933,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1934,"context_line":"            master_resource_name \u003d self._get_node_resource_name("},{"line_number":1935,"context_line":"                vnf_additional_params, master_node)"},{"line_number":1936,"context_line":"            worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1937,"context_line":"                vnf_additional_params, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7e2c999f_2ff6c297","line":1934,"range":{"start_line":1934,"start_character":40,"end_line":1934,"end_character":63},"updated":"2021-03-07 02:19:22.000000000","message":"ditto","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"bccc318e6636e259407e1f205496575c96338ad3","unresolved":true,"context_lines":[{"line_number":1931,"context_line":"                                 vnf_instance.instantiated_vnf_info, **kwargs)"},{"line_number":1932,"context_line":"        else:"},{"line_number":1933,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1934,"context_line":"            master_resource_name \u003d self._get_node_resource_name("},{"line_number":1935,"context_line":"                vnf_additional_params, master_node)"},{"line_number":1936,"context_line":"            worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1937,"context_line":"                vnf_additional_params, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3136fe2_d2afa092","line":1934,"range":{"start_line":1934,"start_character":40,"end_line":1934,"end_character":63},"in_reply_to":"7e2c999f_2ff6c297","updated":"2021-03-09 06:56:29.000000000","message":"ditto","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1931,"context_line":"                                 vnf_instance.instantiated_vnf_info, **kwargs)"},{"line_number":1932,"context_line":"        else:"},{"line_number":1933,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1934,"context_line":"            master_resource_name \u003d self._get_node_resource_name("},{"line_number":1935,"context_line":"                vnf_additional_params, master_node)"},{"line_number":1936,"context_line":"            worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1937,"context_line":"                vnf_additional_params, worker_node)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b0dbe32_12431b51","line":1934,"range":{"start_line":1934,"start_character":40,"end_line":1934,"end_character":63},"in_reply_to":"f3136fe2_d2afa092","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1933,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1934,"context_line":"            master_resource_name \u003d self._get_node_resource_name("},{"line_number":1935,"context_line":"                vnf_additional_params, master_node)"},{"line_number":1936,"context_line":"            worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1937,"context_line":"                vnf_additional_params, worker_node)"},{"line_number":1938,"context_line":"            cluster_resource_name \u003d master_node.get(\u0027cluster_cp_name\u0027)"},{"line_number":1939,"context_line":"            master_username, master_password \u003d self._get_username_pwd("}],"source_content_type":"text/x-python","patch_set":3,"id":"a33dc390_3a98471b","line":1936,"range":{"start_line":1936,"start_character":40,"end_line":1936,"end_character":63},"updated":"2021-03-07 02:19:22.000000000","message":"ditto","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1934,"context_line":"            master_resource_name \u003d self._get_node_resource_name("},{"line_number":1935,"context_line":"                vnf_additional_params, master_node)"},{"line_number":1936,"context_line":"            worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1937,"context_line":"                vnf_additional_params, worker_node)"},{"line_number":1938,"context_line":"            cluster_resource_name \u003d master_node.get(\u0027cluster_cp_name\u0027)"},{"line_number":1939,"context_line":"            master_username, master_password \u003d self._get_username_pwd("}],"source_content_type":"text/x-python","patch_set":3,"id":"47ee316e_23a2da87","line":1936,"range":{"start_line":1936,"start_character":40,"end_line":1936,"end_character":63},"in_reply_to":"46cf40f7_71d26137","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"bccc318e6636e259407e1f205496575c96338ad3","unresolved":true,"context_lines":[{"line_number":1933,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1934,"context_line":"            master_resource_name \u003d self._get_node_resource_name("},{"line_number":1935,"context_line":"                vnf_additional_params, master_node)"},{"line_number":1936,"context_line":"            worker_resource_name \u003d self._get_node_resource_name("},{"line_number":1937,"context_line":"                vnf_additional_params, worker_node)"},{"line_number":1938,"context_line":"            cluster_resource_name \u003d master_node.get(\u0027cluster_cp_name\u0027)"},{"line_number":1939,"context_line":"            master_username, master_password \u003d self._get_username_pwd("}],"source_content_type":"text/x-python","patch_set":3,"id":"46cf40f7_71d26137","line":1936,"range":{"start_line":1936,"start_character":40,"end_line":1936,"end_character":63},"in_reply_to":"a33dc390_3a98471b","updated":"2021-03-09 06:56:29.000000000","message":"ditto","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"6dd73f4d2404a4291773a96b075fbf95ecb9c5c6","unresolved":true,"context_lines":[{"line_number":1954,"context_line":"                if vnfc_resource:"},{"line_number":1955,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1956,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1957,"context_line":"            self._fixed_node("},{"line_number":1958,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1959,"context_line":"                vnf_additional_params, master_resource_name,"},{"line_number":1960,"context_line":"                master_username, master_password, vnf_package_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e2eb2c39_03391583","line":1957,"range":{"start_line":1957,"start_character":17,"end_line":1957,"end_character":28},"updated":"2021-03-07 02:19:22.000000000","message":"This method name is not clear. I understand this method re-generate the target master/worker node in heal operation, and add it to the existing Kubernetes cluster.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":false,"context_lines":[{"line_number":1954,"context_line":"                if vnfc_resource:"},{"line_number":1955,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1956,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1957,"context_line":"            self._fixed_node("},{"line_number":1958,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1959,"context_line":"                vnf_additional_params, master_resource_name,"},{"line_number":1960,"context_line":"                master_username, master_password, vnf_package_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7128458e_1b7a7d27","line":1957,"range":{"start_line":1957,"start_character":17,"end_line":1957,"end_character":28},"in_reply_to":"8377a9e7_2ea744b2","updated":"2021-03-15 09:26:59.000000000","message":"Done","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"584c8ed51531311b217e7d61db9f26b6e6519aa1","unresolved":true,"context_lines":[{"line_number":1954,"context_line":"                if vnfc_resource:"},{"line_number":1955,"context_line":"                    target_physical_resource_ids.append("},{"line_number":1956,"context_line":"                        vnfc_resource.compute_resource.resource_id)"},{"line_number":1957,"context_line":"            self._fixed_node("},{"line_number":1958,"context_line":"                heatclient, stack_id, target_physical_resource_ids,"},{"line_number":1959,"context_line":"                vnf_additional_params, master_resource_name,"},{"line_number":1960,"context_line":"                master_username, master_password, vnf_package_path,"}],"source_content_type":"text/x-python","patch_set":3,"id":"8377a9e7_2ea744b2","line":1957,"range":{"start_line":1957,"start_character":17,"end_line":1957,"end_character":28},"in_reply_to":"e2eb2c39_03391583","updated":"2021-03-11 05:04:08.000000000","message":"I changed the method name to ``_heal_and_join_k8s_node``.","commit_id":"973f3e250996964cd5461e2a0d63dc7d1312f56f"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                          grant_request, **kwargs):"},{"line_number":59,"context_line":"        pass"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _check_is_ip(self, ip_str):"},{"line_number":62,"context_line":"        # ha: check ip"},{"line_number":63,"context_line":"        if len(ip_str.split(\u0027.\u0027)) !\u003d 4:"},{"line_number":64,"context_line":"            return False"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            for ip in ip_str.split(\u0027.\u0027):"},{"line_number":67,"context_line":"                if not re.match(r\u0027^\\d{,3}$\u0027, ip):"},{"line_number":68,"context_line":"                    return False"},{"line_number":69,"context_line":"            else:"},{"line_number":70,"context_line":"                return True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _check_is_cidr(self, cidr_str):"},{"line_number":73,"context_line":"        # instantiate: check cidr"}],"source_content_type":"text/x-python","patch_set":5,"id":"7900bc81_6d28c971","line":70,"range":{"start_line":61,"start_character":0,"end_line":70,"end_character":27},"updated":"2021-03-17 17:52:59.000000000","message":"Why don\u0027t you `ipaddress` module simply? It\u0027s not enough for the purpose actually because it can be True for example \u0027300\u0027 or \u0027052\u0027 which must be invalid.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                          grant_request, **kwargs):"},{"line_number":59,"context_line":"        pass"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _check_is_ip(self, ip_str):"},{"line_number":62,"context_line":"        # ha: check ip"},{"line_number":63,"context_line":"        if len(ip_str.split(\u0027.\u0027)) !\u003d 4:"},{"line_number":64,"context_line":"            return False"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            for ip in ip_str.split(\u0027.\u0027):"},{"line_number":67,"context_line":"                if not re.match(r\u0027^\\d{,3}$\u0027, ip):"},{"line_number":68,"context_line":"                    return False"},{"line_number":69,"context_line":"            else:"},{"line_number":70,"context_line":"                return True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _check_is_cidr(self, cidr_str):"},{"line_number":73,"context_line":"        # instantiate: check cidr"}],"source_content_type":"text/x-python","patch_set":5,"id":"4a0b438a_2ca5609f","line":70,"range":{"start_line":61,"start_character":0,"end_line":70,"end_character":27},"in_reply_to":"7900bc81_6d28c971","updated":"2021-03-22 12:15:23.000000000","message":"Thank you for you advice. I have changed this funciton with the `ipaddress` module in the latest patch.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            else:"},{"line_number":70,"context_line":"                return True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _check_is_cidr(self, cidr_str):"},{"line_number":73,"context_line":"        # instantiate: check cidr"},{"line_number":74,"context_line":"        flag \u003d False"},{"line_number":75,"context_line":"        if \u0027/\u0027 not in cidr_str or len(cidr_str.split(\u0027/\u0027)) !\u003d 2:"},{"line_number":76,"context_line":"            return False"},{"line_number":77,"context_line":"        ip_str \u003d cidr_str.split(\u0027/\u0027)[0]"},{"line_number":78,"context_line":"        network_num \u003d cidr_str.split(\u0027/\u0027)[1]"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            network_num \u003d int(network_num)"},{"line_number":81,"context_line":"            if 0 \u003c network_num \u003c 32:"},{"line_number":82,"context_line":"                flag \u003d True"},{"line_number":83,"context_line":"        except ValueError:"},{"line_number":84,"context_line":"            return False"},{"line_number":85,"context_line":"        if flag and self._check_is_ip(ip_str):"},{"line_number":86,"context_line":"            return True"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            return False"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _execute_command(self, commander, ssh_command, timeout):"},{"line_number":91,"context_line":"        # ha and scale: execute command"}],"source_content_type":"text/x-python","patch_set":5,"id":"fe2c6f06_bd1ad3cc","line":88,"range":{"start_line":72,"start_character":0,"end_line":88,"end_character":24},"updated":"2021-03-17 17:52:59.000000000","message":"It\u0027s also enough to use `ipaddress`.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            else:"},{"line_number":70,"context_line":"                return True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _check_is_cidr(self, cidr_str):"},{"line_number":73,"context_line":"        # instantiate: check cidr"},{"line_number":74,"context_line":"        flag \u003d False"},{"line_number":75,"context_line":"        if \u0027/\u0027 not in cidr_str or len(cidr_str.split(\u0027/\u0027)) !\u003d 2:"},{"line_number":76,"context_line":"            return False"},{"line_number":77,"context_line":"        ip_str \u003d cidr_str.split(\u0027/\u0027)[0]"},{"line_number":78,"context_line":"        network_num \u003d cidr_str.split(\u0027/\u0027)[1]"},{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            network_num \u003d int(network_num)"},{"line_number":81,"context_line":"            if 0 \u003c network_num \u003c 32:"},{"line_number":82,"context_line":"                flag \u003d True"},{"line_number":83,"context_line":"        except ValueError:"},{"line_number":84,"context_line":"            return False"},{"line_number":85,"context_line":"        if flag and self._check_is_ip(ip_str):"},{"line_number":86,"context_line":"            return True"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            return False"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _execute_command(self, commander, ssh_command, timeout):"},{"line_number":91,"context_line":"        # ha and scale: execute command"}],"source_content_type":"text/x-python","patch_set":5,"id":"917e8921_fb3a7b4b","line":88,"range":{"start_line":72,"start_character":0,"end_line":88,"end_character":24},"in_reply_to":"fe2c6f06_bd1ad3cc","updated":"2021-03-22 12:15:23.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            return False"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _execute_command(self, commander, ssh_command, timeout):"},{"line_number":91,"context_line":"        # ha and scale: execute command"},{"line_number":92,"context_line":"        eventlet.monkey_patch()"},{"line_number":93,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"99f338c6_313c7f4a","line":90,"updated":"2021-03-17 17:52:59.000000000","message":"Most of functions `_execute_command*` have same logic. I think you can make them one function in which common logic and diversify for unique logics in each functions. What do you think?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            return False"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _execute_command(self, commander, ssh_command, timeout):"},{"line_number":91,"context_line":"        # ha and scale: execute command"},{"line_number":92,"context_line":"        eventlet.monkey_patch()"},{"line_number":93,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"8598518d_9fc5c15e","line":90,"in_reply_to":"99f338c6_313c7f4a","updated":"2021-03-22 12:15:23.000000000","message":"Thank you for you advice. I have made them in one function in the latest patch.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            raise exceptions.MgmtDriverOtherError("},{"line_number":120,"context_line":"                error_message\u003d\u0027It is time out, When execute command: \u0027"},{"line_number":121,"context_line":"                              \u0027{}.\u0027.format(ssh_command))"},{"line_number":122,"context_line":"        normal_err \u003d \u0027kubectl exec [POD] [COMMAND] is DEPRECATED \u0027 \\"},{"line_number":123,"context_line":"                     \u0027and will be removed in a future version. \u0027 \\"},{"line_number":124,"context_line":"                     \u0027Use kubectl exec [POD] -- [COMMAND] instead.\u0027"},{"line_number":125,"context_line":"        errs \u003d result.get_stderr()"},{"line_number":126,"context_line":"        for err in errs:"},{"line_number":127,"context_line":"            if normal_err in err:"}],"source_content_type":"text/x-python","patch_set":5,"id":"12887b6e_b63d8888","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":67},"updated":"2021-03-17 17:52:59.000000000","message":"Is it good way to use such a message which can be changed easily to ignore? I think it must be hard to find if the message is changed. I wonder if this message can be retrieved dynamically by executing kubectl command everytime calling this function. What do you think?\n\nIn addition, `normal_err` is not clear for the purpose.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            raise exceptions.MgmtDriverOtherError("},{"line_number":120,"context_line":"                error_message\u003d\u0027It is time out, When execute command: \u0027"},{"line_number":121,"context_line":"                              \u0027{}.\u0027.format(ssh_command))"},{"line_number":122,"context_line":"        normal_err \u003d \u0027kubectl exec [POD] [COMMAND] is DEPRECATED \u0027 \\"},{"line_number":123,"context_line":"                     \u0027and will be removed in a future version. \u0027 \\"},{"line_number":124,"context_line":"                     \u0027Use kubectl exec [POD] -- [COMMAND] instead.\u0027"},{"line_number":125,"context_line":"        errs \u003d result.get_stderr()"},{"line_number":126,"context_line":"        for err in errs:"},{"line_number":127,"context_line":"            if normal_err in err:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a877749d_fafc044a","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":67},"in_reply_to":"12887b6e_b63d8888","updated":"2021-03-22 12:15:23.000000000","message":"I have changed the command format and the warning message will not appear in the latest patch.\nPlease kindly check it again.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derrs)"},{"line_number":132,"context_line":"        return result.get_stdout()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _execute_command_drain(self, commander, ssh_command, timeout):"},{"line_number":135,"context_line":"        # scale: execute delete pod command"},{"line_number":136,"context_line":"        eventlet.monkey_patch()"},{"line_number":137,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1599e1db_285910bd","line":134,"updated":"2021-03-17 17:52:59.000000000","message":"L.90","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":131,"context_line":"            raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derrs)"},{"line_number":132,"context_line":"        return result.get_stdout()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _execute_command_drain(self, commander, ssh_command, timeout):"},{"line_number":135,"context_line":"        # scale: execute delete pod command"},{"line_number":136,"context_line":"        eventlet.monkey_patch()"},{"line_number":137,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"2745501c_8b5507db","line":134,"in_reply_to":"1599e1db_285910bd","updated":"2021-03-22 12:15:23.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":153,"context_line":"            raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":154,"context_line":"        return result.get_stdout()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _execute_command_get_certificate_key("},{"line_number":157,"context_line":"            self, commander, ssh_command, timeout):"},{"line_number":158,"context_line":"        # ha: get certificate key"},{"line_number":159,"context_line":"        eventlet.monkey_patch()"}],"source_content_type":"text/x-python","patch_set":5,"id":"e1370401_729ac941","line":156,"updated":"2021-03-17 17:52:59.000000000","message":"L.90","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":153,"context_line":"            raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":154,"context_line":"        return result.get_stdout()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _execute_command_get_certificate_key("},{"line_number":157,"context_line":"            self, commander, ssh_command, timeout):"},{"line_number":158,"context_line":"        # ha: get certificate key"},{"line_number":159,"context_line":"        eventlet.monkey_patch()"}],"source_content_type":"text/x-python","patch_set":5,"id":"db82a293_13f6a302","line":156,"in_reply_to":"e1370401_729ac941","updated":"2021-03-22 12:15:23.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e8c3fd49519ff4ba9c2cf4323d003fefc77b7c00","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":175,"context_line":"        return result.get_stdout()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _execute_command_install(self, commander, ssh_command, timeout):"},{"line_number":178,"context_line":"        # instantiate: install k8s"},{"line_number":179,"context_line":"        eventlet.monkey_patch()"},{"line_number":180,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"670b54f0_ed7a51be","line":177,"updated":"2021-03-17 17:52:59.000000000","message":"L.90","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":175,"context_line":"        return result.get_stdout()"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def _execute_command_install(self, commander, ssh_command, timeout):"},{"line_number":178,"context_line":"        # instantiate: install k8s"},{"line_number":179,"context_line":"        eventlet.monkey_patch()"},{"line_number":180,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9738ea25_169ed414","line":177,"in_reply_to":"670b54f0_ed7a51be","updated":"2021-03-22 12:15:23.000000000","message":"ditto","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":true,"context_lines":[{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":"    def _get_node_resource_name(self, vnf_additional_params, node):"},{"line_number":1612,"context_line":"        if node.get(\u0027aspect_id\u0027):"},{"line_number":1613,"context_line":"            # in case of SOL001 TOSCA-based VNFD"},{"line_number":1614,"context_line":"            if \u0027lcm-operation-user-data\u0027 in vnf_additional_params.keys() and \\"},{"line_number":1615,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1616,"context_line":"                    vnf_additional_params.keys():"}],"source_content_type":"text/x-python","patch_set":5,"id":"c7cb481f_63f8f793","line":1613,"range":{"start_line":1613,"start_character":12,"end_line":1613,"end_character":48},"updated":"2021-03-15 09:26:59.000000000","message":"Is this correct? It seems UsesrData format.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":1610,"context_line":""},{"line_number":1611,"context_line":"    def _get_node_resource_name(self, vnf_additional_params, node):"},{"line_number":1612,"context_line":"        if node.get(\u0027aspect_id\u0027):"},{"line_number":1613,"context_line":"            # in case of SOL001 TOSCA-based VNFD"},{"line_number":1614,"context_line":"            if \u0027lcm-operation-user-data\u0027 in vnf_additional_params.keys() and \\"},{"line_number":1615,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1616,"context_line":"                    vnf_additional_params.keys():"}],"source_content_type":"text/x-python","patch_set":5,"id":"51d43af9_1fcc6be5","line":1613,"range":{"start_line":1613,"start_character":12,"end_line":1613,"end_character":48},"in_reply_to":"c7cb481f_63f8f793","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":true,"context_lines":[{"line_number":1615,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1616,"context_line":"                    vnf_additional_params.keys():"},{"line_number":1617,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1618,"context_line":"            # in case of SOL001 TOSCA-based VNFD with policies definition"},{"line_number":1619,"context_line":"            else:"},{"line_number":1620,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1621,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"43d8eff1_eedc1a6d","line":1618,"range":{"start_line":1618,"start_character":49,"end_line":1618,"end_character":73},"updated":"2021-03-15 09:26:59.000000000","message":"Why don\u0027t you use the same word in the document, \"HA master node\"?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":1615,"context_line":"                    \u0027lcm-operation-user-data-class\u0027 in \\"},{"line_number":1616,"context_line":"                    vnf_additional_params.keys():"},{"line_number":1617,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027) + \u0027_group\u0027"},{"line_number":1618,"context_line":"            # in case of SOL001 TOSCA-based VNFD with policies definition"},{"line_number":1619,"context_line":"            else:"},{"line_number":1620,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1621,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"e1dc4af9_285ced2f","line":1618,"range":{"start_line":1618,"start_character":49,"end_line":1618,"end_character":73},"in_reply_to":"43d8eff1_eedc1a6d","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":true,"context_lines":[{"line_number":1619,"context_line":"            else:"},{"line_number":1620,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1621,"context_line":"        else:"},{"line_number":1622,"context_line":"            # in case of SOL001 TOSCA-based VNFD without policies definition"},{"line_number":1623,"context_line":"            resource_name \u003d node.get(\u0027nic_cp_name\u0027)"},{"line_number":1624,"context_line":"        return resource_name"},{"line_number":1625,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"6ff1bf73_bea8d4c1","line":1622,"range":{"start_line":1622,"start_character":49,"end_line":1622,"end_character":76},"updated":"2021-03-15 09:26:59.000000000","message":"Why don\u0027t you use \"single master node\"?","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":1619,"context_line":"            else:"},{"line_number":1620,"context_line":"                resource_name \u003d node.get(\u0027aspect_id\u0027)"},{"line_number":1621,"context_line":"        else:"},{"line_number":1622,"context_line":"            # in case of SOL001 TOSCA-based VNFD without policies definition"},{"line_number":1623,"context_line":"            resource_name \u003d node.get(\u0027nic_cp_name\u0027)"},{"line_number":1624,"context_line":"        return resource_name"},{"line_number":1625,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"91f46b2f_b7c07785","line":1622,"range":{"start_line":1622,"start_character":49,"end_line":1622,"end_character":76},"in_reply_to":"6ff1bf73_bea8d4c1","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"278090766ee2e5eb754a1725648be8193ab44fcd","unresolved":true,"context_lines":[{"line_number":1660,"context_line":"        heatclient \u003d hc.HeatClient(vim_connection_info.access_info)"},{"line_number":1661,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1662,"context_line":"            for vim_info in vnf_instance.vim_connection_info:"},{"line_number":1663,"context_line":"                if vim_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":1664,"context_line":"                    vim_id \u003d vim_info.vim_id"},{"line_number":1665,"context_line":"                    nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1666,"context_line":"                    nfvo_plugin.delete_vim(context, vim_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5409cca3_80d5e9a4","line":1663,"range":{"start_line":1663,"start_character":16,"end_line":1663,"end_character":53},"updated":"2021-03-15 09:26:59.000000000","message":"How about logging if vim_type is not \"kubernetes\" type? The ``vnf_instance.vim_connection_info`` may be updated in previous operations.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"fecccc2e6bf9460e02f2c65a7c2359c24784c421","unresolved":true,"context_lines":[{"line_number":1660,"context_line":"        heatclient \u003d hc.HeatClient(vim_connection_info.access_info)"},{"line_number":1661,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1662,"context_line":"            for vim_info in vnf_instance.vim_connection_info:"},{"line_number":1663,"context_line":"                if vim_info.vim_type \u003d\u003d \u0027kubernetes\u0027:"},{"line_number":1664,"context_line":"                    vim_id \u003d vim_info.vim_id"},{"line_number":1665,"context_line":"                    nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1666,"context_line":"                    nfvo_plugin.delete_vim(context, vim_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fff50293_fdac4259","line":1663,"range":{"start_line":1663,"start_character":16,"end_line":1663,"end_character":53},"in_reply_to":"5409cca3_80d5e9a4","updated":"2021-03-18 06:12:52.000000000","message":"I fixed it in the new patch.","commit_id":"3b4a7a398e658ee4b237623fd0c484e5f7b57bbb"},{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"12b1eee2f00c6443756697a53bc7a21c1c1f9d24","unresolved":true,"context_lines":[{"line_number":1678,"context_line":"            k8s_vim_name \u003d k8s_params.get(\u0027vim_name\u0027)"},{"line_number":1679,"context_line":"            if not k8s_vim_name:"},{"line_number":1680,"context_line":"                k8s_vim_name \u003d \u0027kubernetes_vim_\u0027 + vnf_instance.id"},{"line_number":1681,"context_line":"            vim_id \u003d self._get_vim_by_name("},{"line_number":1682,"context_line":"                context, k8s_vim_name, columns_to_join\u003dNone)"},{"line_number":1683,"context_line":"            nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1684,"context_line":"            nfvo_plugin.delete_vim(context, vim_id)"},{"line_number":1685,"context_line":"            for vim_info in vnf_instance.vim_connection_info:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf7890d2_1eea55e2","line":1682,"range":{"start_line":1681,"start_character":12,"end_line":1682,"end_character":60},"updated":"2021-03-18 13:18:07.000000000","message":"Why did you change the logic to delete VIM record in any cases? The VIM record may be deleted before the Heal operation, and this method fails when the VIM record was not found in _get_vim_by_name() method. I believe it\u0027s better to simply skip the deletion and export log when the VIM record is not found.","commit_id":"a4f1560d365ab74a5c67314fc412d00db853d6cf"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":1678,"context_line":"            k8s_vim_name \u003d k8s_params.get(\u0027vim_name\u0027)"},{"line_number":1679,"context_line":"            if not k8s_vim_name:"},{"line_number":1680,"context_line":"                k8s_vim_name \u003d \u0027kubernetes_vim_\u0027 + vnf_instance.id"},{"line_number":1681,"context_line":"            vim_id \u003d self._get_vim_by_name("},{"line_number":1682,"context_line":"                context, k8s_vim_name, columns_to_join\u003dNone)"},{"line_number":1683,"context_line":"            nfvo_plugin \u003d NfvoPlugin()"},{"line_number":1684,"context_line":"            nfvo_plugin.delete_vim(context, vim_id)"},{"line_number":1685,"context_line":"            for vim_info in vnf_instance.vim_connection_info:"}],"source_content_type":"text/x-python","patch_set":6,"id":"0b6dfa71_201eaa78","line":1682,"range":{"start_line":1681,"start_character":12,"end_line":1682,"end_character":60},"in_reply_to":"bf7890d2_1eea55e2","updated":"2021-03-22 12:15:23.000000000","message":"I originally thought that using vim_type as a judgment condition was not sufficient, so the logic here is to filter the data corresponding to vim_name from database.\nWhat you said is correct, and the delete operation should be skipped when the record does not exist.\nSo I modified the code here and added a judgment. And in `_get_vim_by_name` method, if this record does not exist, log is output and a null value will be return.\nPlease kindy check it again in the latest patch","commit_id":"a4f1560d365ab74a5c67314fc412d00db853d6cf"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"75dee0f782408972566500ef33f6eb142617d5f1","unresolved":true,"context_lines":[{"line_number":715,"context_line":"                        instantiate_vnf_request, grant,"},{"line_number":716,"context_line":"                        grant_request, **kwargs):"},{"line_number":717,"context_line":"        # get vim_connect_info"},{"line_number":718,"context_line":"        vim_connection_info \u003d self._get_vim_connection_info("},{"line_number":719,"context_line":"            context, instantiate_vnf_request)"},{"line_number":720,"context_line":"        additional_param \u003d instantiate_vnf_request.additional_params.get("},{"line_number":721,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {})"},{"line_number":722,"context_line":"        script_path \u003d additional_param.get(\u0027script_path\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"466feda5_87027cc9","line":719,"range":{"start_line":718,"start_character":8,"end_line":719,"end_character":45},"updated":"2021-03-22 09:29:10.000000000","message":"In `_get_vim_connection_info` method, the `vim_connection_info` field is a must value. But the instantiate_vnf_request ` may not have  `vim_connection_info`, so you need to add a judgment here.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":715,"context_line":"                        instantiate_vnf_request, grant,"},{"line_number":716,"context_line":"                        grant_request, **kwargs):"},{"line_number":717,"context_line":"        # get vim_connect_info"},{"line_number":718,"context_line":"        vim_connection_info \u003d self._get_vim_connection_info("},{"line_number":719,"context_line":"            context, instantiate_vnf_request)"},{"line_number":720,"context_line":"        additional_param \u003d instantiate_vnf_request.additional_params.get("},{"line_number":721,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {})"},{"line_number":722,"context_line":"        script_path \u003d additional_param.get(\u0027script_path\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"c59d8ab6_1e5c9a60","line":719,"range":{"start_line":718,"start_character":8,"end_line":719,"end_character":45},"in_reply_to":"466feda5_87027cc9","updated":"2021-03-22 12:15:23.000000000","message":"I fixed it in the latest patch. Please kindly check it again.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"32d2d553394bb9903d570367fb23669860511428","unresolved":true,"context_lines":[{"line_number":715,"context_line":"                        instantiate_vnf_request, grant,"},{"line_number":716,"context_line":"                        grant_request, **kwargs):"},{"line_number":717,"context_line":"        # get vim_connect_info"},{"line_number":718,"context_line":"        vim_connection_info \u003d self._get_vim_connection_info("},{"line_number":719,"context_line":"            context, instantiate_vnf_request)"},{"line_number":720,"context_line":"        additional_param \u003d instantiate_vnf_request.additional_params.get("},{"line_number":721,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {})"},{"line_number":722,"context_line":"        script_path \u003d additional_param.get(\u0027script_path\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4d12f9c6_ffd5a28e","line":719,"range":{"start_line":718,"start_character":8,"end_line":719,"end_character":45},"in_reply_to":"4b2bb657_7464e5d5","updated":"2021-03-23 11:53:55.000000000","message":"Thank you for updating. I have confirmed.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"473eb9b29b4755dd28c9f78d6c875c69414e7a48","unresolved":true,"context_lines":[{"line_number":715,"context_line":"                        instantiate_vnf_request, grant,"},{"line_number":716,"context_line":"                        grant_request, **kwargs):"},{"line_number":717,"context_line":"        # get vim_connect_info"},{"line_number":718,"context_line":"        vim_connection_info \u003d self._get_vim_connection_info("},{"line_number":719,"context_line":"            context, instantiate_vnf_request)"},{"line_number":720,"context_line":"        additional_param \u003d instantiate_vnf_request.additional_params.get("},{"line_number":721,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {})"},{"line_number":722,"context_line":"        script_path \u003d additional_param.get(\u0027script_path\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4b2bb657_7464e5d5","line":719,"range":{"start_line":718,"start_character":8,"end_line":719,"end_character":45},"in_reply_to":"58535a37_201f9312","updated":"2021-03-23 10:10:26.000000000","message":"I have added a comment on else route in the latest patch. Please kindly check it again.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f8a597c8a6570a2daedd3ef0a9f9d4249e34d18e","unresolved":true,"context_lines":[{"line_number":715,"context_line":"                        instantiate_vnf_request, grant,"},{"line_number":716,"context_line":"                        grant_request, **kwargs):"},{"line_number":717,"context_line":"        # get vim_connect_info"},{"line_number":718,"context_line":"        vim_connection_info \u003d self._get_vim_connection_info("},{"line_number":719,"context_line":"            context, instantiate_vnf_request)"},{"line_number":720,"context_line":"        additional_param \u003d instantiate_vnf_request.additional_params.get("},{"line_number":721,"context_line":"            \u0027k8s_cluster_installation_param\u0027, {})"},{"line_number":722,"context_line":"        script_path \u003d additional_param.get(\u0027script_path\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"58535a37_201f9312","line":719,"range":{"start_line":718,"start_character":8,"end_line":719,"end_character":45},"in_reply_to":"c59d8ab6_1e5c9a60","updated":"2021-03-23 01:15:20.000000000","message":"Why don\u0027t you add a note or comment on when to enter the else route so that others can see and understand it?","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"75dee0f782408972566500ef33f6eb142617d5f1","unresolved":true,"context_lines":[{"line_number":1548,"context_line":"        not_fixed_master_ssh_ips \u003d ["},{"line_number":1549,"context_line":"            master_ips.get(\u0027master_ssh_ip\u0027)"},{"line_number":1550,"context_line":"            for master_ips in not_fixed_master_infos.values()]"},{"line_number":1551,"context_line":"        commander, master_ssh_ip \u003d self._connect_ssh_scale("},{"line_number":1552,"context_line":"            not_fixed_master_ssh_ips, master_username,"},{"line_number":1553,"context_line":"            master_password)"},{"line_number":1554,"context_line":"        for fixed_worker_name in fixed_worker_infos.keys():"},{"line_number":1555,"context_line":"            ssh_command \u003d \"kubectl get pods --field-selector\u003d\" \\"},{"line_number":1556,"context_line":"                          \"spec.nodeName\u003d{} -o json\" \\"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a99e9fd_90cfe39f","line":1553,"range":{"start_line":1551,"start_character":0,"end_line":1553,"end_character":28},"updated":"2021-03-22 09:29:10.000000000","message":"If you will heal multiple workerNode, the seceond workerNode will lose the connection with masterNode.\nSo I think these code must be in the `for` loop.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":1548,"context_line":"        not_fixed_master_ssh_ips \u003d ["},{"line_number":1549,"context_line":"            master_ips.get(\u0027master_ssh_ip\u0027)"},{"line_number":1550,"context_line":"            for master_ips in not_fixed_master_infos.values()]"},{"line_number":1551,"context_line":"        commander, master_ssh_ip \u003d self._connect_ssh_scale("},{"line_number":1552,"context_line":"            not_fixed_master_ssh_ips, master_username,"},{"line_number":1553,"context_line":"            master_password)"},{"line_number":1554,"context_line":"        for fixed_worker_name in fixed_worker_infos.keys():"},{"line_number":1555,"context_line":"            ssh_command \u003d \"kubectl get pods --field-selector\u003d\" \\"},{"line_number":1556,"context_line":"                          \"spec.nodeName\u003d{} -o json\" \\"}],"source_content_type":"text/x-python","patch_set":9,"id":"a0e20a8d_9b8a1cb6","line":1553,"range":{"start_line":1551,"start_character":0,"end_line":1553,"end_character":28},"in_reply_to":"3a99e9fd_90cfe39f","updated":"2021-03-22 12:15:23.000000000","message":"I fixed it in the latest patch. Please kindly check it again.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f8a597c8a6570a2daedd3ef0a9f9d4249e34d18e","unresolved":true,"context_lines":[{"line_number":1548,"context_line":"        not_fixed_master_ssh_ips \u003d ["},{"line_number":1549,"context_line":"            master_ips.get(\u0027master_ssh_ip\u0027)"},{"line_number":1550,"context_line":"            for master_ips in not_fixed_master_infos.values()]"},{"line_number":1551,"context_line":"        commander, master_ssh_ip \u003d self._connect_ssh_scale("},{"line_number":1552,"context_line":"            not_fixed_master_ssh_ips, master_username,"},{"line_number":1553,"context_line":"            master_password)"},{"line_number":1554,"context_line":"        for fixed_worker_name in fixed_worker_infos.keys():"},{"line_number":1555,"context_line":"            ssh_command \u003d \"kubectl get pods --field-selector\u003d\" \\"},{"line_number":1556,"context_line":"                          \"spec.nodeName\u003d{} -o json\" \\"}],"source_content_type":"text/x-python","patch_set":9,"id":"58b7a529_b51bf210","line":1553,"range":{"start_line":1551,"start_character":0,"end_line":1553,"end_character":28},"in_reply_to":"a0e20a8d_9b8a1cb6","updated":"2021-03-23 01:15:20.000000000","message":"I have confirmed.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"75dee0f782408972566500ef33f6eb142617d5f1","unresolved":true,"context_lines":[{"line_number":1968,"context_line":"                \u0027k8s_cluster_installation_param\u0027, {}).get("},{"line_number":1969,"context_line":"                \u0027worker_node\u0027, {})"},{"line_number":1970,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1971,"context_line":"            self.instantiate_end(context, vnf_instance,"},{"line_number":1972,"context_line":"                                 vnf_instance.instantiated_vnf_info, **kwargs)"},{"line_number":1973,"context_line":"        else:"},{"line_number":1974,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1975,"context_line":"            master_resource_name \u003d self._get_node_resource_name("}],"source_content_type":"text/x-python","patch_set":9,"id":"8c650bae_0a3c61c9","line":1972,"range":{"start_line":1971,"start_character":12,"end_line":1972,"end_character":78},"updated":"2021-03-22 09:29:10.000000000","message":"It does not match the parameter of the method (instantiate_end) defined in this patch (L714-716). \nYou should change them here.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"ebb736dee61cc0273cd30f2c42d1812774ce6dc0","unresolved":true,"context_lines":[{"line_number":1968,"context_line":"                \u0027k8s_cluster_installation_param\u0027, {}).get("},{"line_number":1969,"context_line":"                \u0027worker_node\u0027, {})"},{"line_number":1970,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1971,"context_line":"            self.instantiate_end(context, vnf_instance,"},{"line_number":1972,"context_line":"                                 vnf_instance.instantiated_vnf_info, **kwargs)"},{"line_number":1973,"context_line":"        else:"},{"line_number":1974,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1975,"context_line":"            master_resource_name \u003d self._get_node_resource_name("}],"source_content_type":"text/x-python","patch_set":9,"id":"c02afdf5_9d512b19","line":1972,"range":{"start_line":1971,"start_character":12,"end_line":1972,"end_character":78},"in_reply_to":"8c650bae_0a3c61c9","updated":"2021-03-22 12:15:23.000000000","message":"I fixed it in the latest patch. Please kindly check it again.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f8a597c8a6570a2daedd3ef0a9f9d4249e34d18e","unresolved":true,"context_lines":[{"line_number":1968,"context_line":"                \u0027k8s_cluster_installation_param\u0027, {}).get("},{"line_number":1969,"context_line":"                \u0027worker_node\u0027, {})"},{"line_number":1970,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1971,"context_line":"            self.instantiate_end(context, vnf_instance,"},{"line_number":1972,"context_line":"                                 vnf_instance.instantiated_vnf_info, **kwargs)"},{"line_number":1973,"context_line":"        else:"},{"line_number":1974,"context_line":"            stack_id \u003d vnf_instance.instantiated_vnf_info.instance_id"},{"line_number":1975,"context_line":"            master_resource_name \u003d self._get_node_resource_name("}],"source_content_type":"text/x-python","patch_set":9,"id":"39544523_e1fe8c7e","line":1972,"range":{"start_line":1971,"start_character":12,"end_line":1972,"end_character":78},"in_reply_to":"c02afdf5_9d512b19","updated":"2021-03-23 01:15:20.000000000","message":"I have confirmed.","commit_id":"84d2b7a8a178f2a03774be9f918a0e758eda0349"}]}