)]}'
{"tacker/objects/vnf_lcm_op_occs.py":[{"author":{"_account_id":31902,"name":"Makoto Hamada","email":"makoto.hamada.xu@hco.ntt.co.jp","username":"makoto-h"},"change_message_id":"2a1ae586dbb8c7ad6bc06b75564a675aa785a69c","unresolved":true,"context_lines":[{"line_number":770,"context_line":"    fields \u003d {"},{"line_number":771,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":772,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":773,"context_line":"        \u0027metadata\u0027: fields.DictOfNullableStringsField(nullable\u003dTrue,"},{"line_number":774,"context_line":"                                                     default\u003d{}),"},{"line_number":775,"context_line":"        \u0027vim_connection_info\u0027: fields.ListOfObjectsField("},{"line_number":776,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue, default\u003d[]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"09b96de4_cd0eda94","line":773,"updated":"2021-03-15 10:24:14.000000000","message":"According to the SPEC of Support ETSI NFV-SOL based error-handling operation, the \"metadata\" support for fail operation is N. Can you tell me why in this patch you need to add \"metadata\" ?","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":770,"context_line":"    fields \u003d {"},{"line_number":771,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":772,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":773,"context_line":"        \u0027metadata\u0027: fields.DictOfNullableStringsField(nullable\u003dTrue,"},{"line_number":774,"context_line":"                                                     default\u003d{}),"},{"line_number":775,"context_line":"        \u0027vim_connection_info\u0027: fields.ListOfObjectsField("},{"line_number":776,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue, default\u003d[]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"b70e9520_e2abd2e9","line":773,"in_reply_to":"09b96de4_cd0eda94","updated":"2021-03-24 07:43:52.000000000","message":"\u003e According to the SPEC of Support ETSI NFV-SOL based error-handling operation, the \"metadata\" support for fail operation is N. Can you tell me why in this patch you need to add \"metadata\" ?\n\nMetadata added in the code is for VNFInfoModification and it is Y based on the specifications.\n\nVNFInfoModification ➞ metadata --\u003e Y\nResourceChanges ➞ AffectedVnfc ➞ metadata --\u003e N\nResourceChanges ➞ AffectedVirtualLink ➞ metadata --\u003e N\nResourceChanges ➞ AffectedVirtualStorage ➞ metadata --\u003e N\n\nSince this was added by another merged patch, we removed our changes and retained the metadata that was added from that patch already merged to master.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31902,"name":"Makoto Hamada","email":"makoto.hamada.xu@hco.ntt.co.jp","username":"makoto-h"},"change_message_id":"f0fd0f3858048c020f32dac73ae4e7052aba96dc","unresolved":false,"context_lines":[{"line_number":770,"context_line":"    fields \u003d {"},{"line_number":771,"context_line":"        \u0027vnf_instance_name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":772,"context_line":"        \u0027vnf_instance_description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":773,"context_line":"        \u0027metadata\u0027: fields.DictOfNullableStringsField(nullable\u003dTrue,"},{"line_number":774,"context_line":"                                                     default\u003d{}),"},{"line_number":775,"context_line":"        \u0027vim_connection_info\u0027: fields.ListOfObjectsField("},{"line_number":776,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue, default\u003d[]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"bc6572eb_d2b1b05d","line":773,"in_reply_to":"b70e9520_e2abd2e9","updated":"2021-03-25 02:57:01.000000000","message":"I understood. I missed Y of VNFInfoModifications.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"}],"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1612,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027stateEnteredTime\u0027))"},{"line_number":1613,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027startTime\u0027))"},{"line_number":1614,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027vnfInstanceId\u0027))"},{"line_number":1615,"context_line":"        if fail_response.get(\u0027grantId\u0027) is not None:"},{"line_number":1616,"context_line":"            self.assertIsNotNone(fail_response.get(\u0027grantId\u0027))"},{"line_number":1617,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027operation\u0027))"},{"line_number":1618,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isAutomaticInvocation\u0027))"},{"line_number":1619,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isCancelPending\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"f353d304_643efde9","line":1616,"range":{"start_line":1615,"start_character":8,"end_line":1616,"end_character":62},"updated":"2021-03-17 01:21:22.000000000","message":"The grantId is cardinallity: 0..1 and I think this assert is not necessary as it will always succeed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027stateEnteredTime\u0027))"},{"line_number":1613,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027startTime\u0027))"},{"line_number":1614,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027vnfInstanceId\u0027))"},{"line_number":1615,"context_line":"        if fail_response.get(\u0027grantId\u0027) is not None:"},{"line_number":1616,"context_line":"            self.assertIsNotNone(fail_response.get(\u0027grantId\u0027))"},{"line_number":1617,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027operation\u0027))"},{"line_number":1618,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isAutomaticInvocation\u0027))"},{"line_number":1619,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isCancelPending\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"b47a8aeb_6c5e2961","line":1616,"range":{"start_line":1615,"start_character":8,"end_line":1616,"end_character":62},"in_reply_to":"89e04183_eb999497","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1612,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027stateEnteredTime\u0027))"},{"line_number":1613,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027startTime\u0027))"},{"line_number":1614,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027vnfInstanceId\u0027))"},{"line_number":1615,"context_line":"        if fail_response.get(\u0027grantId\u0027) is not None:"},{"line_number":1616,"context_line":"            self.assertIsNotNone(fail_response.get(\u0027grantId\u0027))"},{"line_number":1617,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027operation\u0027))"},{"line_number":1618,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isAutomaticInvocation\u0027))"},{"line_number":1619,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isCancelPending\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"89e04183_eb999497","line":1616,"range":{"start_line":1615,"start_character":8,"end_line":1616,"end_character":62},"in_reply_to":"f353d304_643efde9","updated":"2021-03-24 07:43:52.000000000","message":"\u003e The grantId is cardinallity: 0..1 and I think this assert is not necessary as it will always succeed.\n\ndeleted the assertIsNotNone() part of grantId","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1618,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isAutomaticInvocation\u0027))"},{"line_number":1619,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isCancelPending\u0027))"},{"line_number":1620,"context_line":""},{"line_number":1621,"context_line":"        changed_info \u003d fail_response.get(\u0027changedInfo\u0027, None)"},{"line_number":1622,"context_line":"        if changed_info and changed_info.get(\u0027metadata\u0027) is not None:"},{"line_number":1623,"context_line":"            self.assertIsNotNone(changed_info.get(\u0027metadata\u0027))"},{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        changed_ext_connectivity \u003d fail_response.get("},{"line_number":1626,"context_line":"            \u0027changedExtConnectivity\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1435172f_5f38dbd6","line":1623,"range":{"start_line":1621,"start_character":8,"end_line":1623,"end_character":62},"updated":"2021-03-17 01:21:22.000000000","message":"ditto","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1618,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isAutomaticInvocation\u0027))"},{"line_number":1619,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isCancelPending\u0027))"},{"line_number":1620,"context_line":""},{"line_number":1621,"context_line":"        changed_info \u003d fail_response.get(\u0027changedInfo\u0027, None)"},{"line_number":1622,"context_line":"        if changed_info and changed_info.get(\u0027metadata\u0027) is not None:"},{"line_number":1623,"context_line":"            self.assertIsNotNone(changed_info.get(\u0027metadata\u0027))"},{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        changed_ext_connectivity \u003d fail_response.get("},{"line_number":1626,"context_line":"            \u0027changedExtConnectivity\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e734d502_75d22810","line":1623,"range":{"start_line":1621,"start_character":8,"end_line":1623,"end_character":62},"in_reply_to":"1435172f_5f38dbd6","updated":"2021-03-24 07:43:52.000000000","message":"\u003e ditto\n\ndeleted the assertIsNotNone() part of metadata","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isAutomaticInvocation\u0027))"},{"line_number":1619,"context_line":"        self.assertIsNotNone(fail_response.get(\u0027isCancelPending\u0027))"},{"line_number":1620,"context_line":""},{"line_number":1621,"context_line":"        changed_info \u003d fail_response.get(\u0027changedInfo\u0027, None)"},{"line_number":1622,"context_line":"        if changed_info and changed_info.get(\u0027metadata\u0027) is not None:"},{"line_number":1623,"context_line":"            self.assertIsNotNone(changed_info.get(\u0027metadata\u0027))"},{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        changed_ext_connectivity \u003d fail_response.get("},{"line_number":1626,"context_line":"            \u0027changedExtConnectivity\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a28602a0_2afbadbc","line":1623,"range":{"start_line":1621,"start_character":8,"end_line":1623,"end_character":62},"in_reply_to":"e734d502_75d22810","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1627,"context_line":"        if changed_ext_connectivity is not None:"},{"line_number":1628,"context_line":"            self.assertIsNotNone("},{"line_number":1629,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity(\u0027id\u0027))"},{"line_number":1630,"context_line":"            resource_handle \u003d \\"},{"line_number":1631,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1632,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9453a006_5dfadabb","line":1632,"range":{"start_line":1630,"start_character":12,"end_line":1632,"end_character":43},"updated":"2021-03-17 01:21:22.000000000","message":"The resourceHandle is cardinallity:1 and I think it should be self.assertIsNotNone().","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1627,"context_line":"        if changed_ext_connectivity is not None:"},{"line_number":1628,"context_line":"            self.assertIsNotNone("},{"line_number":1629,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity(\u0027id\u0027))"},{"line_number":1630,"context_line":"            resource_handle \u003d \\"},{"line_number":1631,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1632,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"eae3028c_a1d5c506","line":1632,"range":{"start_line":1630,"start_character":12,"end_line":1632,"end_character":43},"in_reply_to":"9453a006_5dfadabb","updated":"2021-03-24 07:43:52.000000000","message":"\u003e The resourceHandle is cardinallity:1 and I think it should be self.assertIsNotNone().\n\nadded self.assertIsNotNone() for \u0027resourceHandle\u0027","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"        if changed_ext_connectivity is not None:"},{"line_number":1628,"context_line":"            self.assertIsNotNone("},{"line_number":1629,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity(\u0027id\u0027))"},{"line_number":1630,"context_line":"            resource_handle \u003d \\"},{"line_number":1631,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1632,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"51d73e3f_0796eba4","line":1632,"range":{"start_line":1630,"start_character":12,"end_line":1632,"end_character":43},"in_reply_to":"eae3028c_a1d5c506","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1631,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1632,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"},{"line_number":1636,"context_line":"                self.assertIsNotNone(resource_handle.get("},{"line_number":1637,"context_line":"                    \u0027vimLevelResourceType\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"d1079b14_d985a6fb","line":1634,"range":{"start_line":1634,"start_character":16,"end_line":1634,"end_character":76},"updated":"2021-03-17 01:21:22.000000000","message":"The vimConnectionId is cardinallity:0..1 and I think this assert should be removed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1631,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1632,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"},{"line_number":1636,"context_line":"                self.assertIsNotNone(resource_handle.get("},{"line_number":1637,"context_line":"                    \u0027vimLevelResourceType\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd32bbc2_2c343a60","line":1634,"range":{"start_line":1634,"start_character":16,"end_line":1634,"end_character":76},"in_reply_to":"d1079b14_d985a6fb","updated":"2021-03-24 07:43:52.000000000","message":"\u003e The vimConnectionId is cardinallity:0..1 and I think this assert should be removed.\n\ndeleted the assertIsNotNone() part of vimConnectionId","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1631,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1632,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"},{"line_number":1636,"context_line":"                self.assertIsNotNone(resource_handle.get("},{"line_number":1637,"context_line":"                    \u0027vimLevelResourceType\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ac860da_10ac08ba","line":1634,"range":{"start_line":1634,"start_character":16,"end_line":1634,"end_character":76},"in_reply_to":"fd32bbc2_2c343a60","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"},{"line_number":1636,"context_line":"                self.assertIsNotNone(resource_handle.get("},{"line_number":1637,"context_line":"                    \u0027vimLevelResourceType\u0027))"},{"line_number":1638,"context_line":"            ext_link_ports \u003d \\"},{"line_number":1639,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1640,"context_line":"                    \u0027extLinkPorts\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"39f882f1_9813afee","line":1637,"range":{"start_line":1636,"start_character":16,"end_line":1637,"end_character":44},"updated":"2021-03-17 01:21:22.000000000","message":"ditto","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"},{"line_number":1636,"context_line":"                self.assertIsNotNone(resource_handle.get("},{"line_number":1637,"context_line":"                    \u0027vimLevelResourceType\u0027))"},{"line_number":1638,"context_line":"            ext_link_ports \u003d \\"},{"line_number":1639,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1640,"context_line":"                    \u0027extLinkPorts\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"93f402f1_1412d991","line":1637,"range":{"start_line":1636,"start_character":16,"end_line":1637,"end_character":44},"in_reply_to":"39f882f1_9813afee","updated":"2021-03-24 07:43:52.000000000","message":"\u003e ditto\n\ndeleted the assertIsNotNone() part of vimLevelResourceType","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1633,"context_line":"            if resource_handle is not None:"},{"line_number":1634,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027vimConnectionId\u0027))"},{"line_number":1635,"context_line":"                self.assertIsNotNone(resource_handle.get(\u0027resourceId\u0027))"},{"line_number":1636,"context_line":"                self.assertIsNotNone(resource_handle.get("},{"line_number":1637,"context_line":"                    \u0027vimLevelResourceType\u0027))"},{"line_number":1638,"context_line":"            ext_link_ports \u003d \\"},{"line_number":1639,"context_line":"                changed_ext_connectivity._get_changed_ext_connectivity("},{"line_number":1640,"context_line":"                    \u0027extLinkPorts\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f367483d_eb50adcb","line":1637,"range":{"start_line":1636,"start_character":16,"end_line":1637,"end_character":44},"in_reply_to":"93f402f1_1412d991","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1640,"context_line":"                    \u0027extLinkPorts\u0027, None)"},{"line_number":1641,"context_line":"            if ext_link_ports is not None:"},{"line_number":1642,"context_line":"                self.assertIsNotNone(ext_link_ports.get(\u0027id\u0027))"},{"line_number":1643,"context_line":"                ext_link_ports_resource_handle \u003d ext_link_ports.get("},{"line_number":1644,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1645,"context_line":"                if ext_link_ports_resource_handle is not None:"},{"line_number":1646,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3961ffa5_c544237b","line":1644,"range":{"start_line":1643,"start_character":16,"end_line":1644,"end_character":43},"updated":"2021-03-17 01:21:22.000000000","message":"The resourceHandle is cardinallity:1 and I think it should be self.assertIsNotNone().","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1640,"context_line":"                    \u0027extLinkPorts\u0027, None)"},{"line_number":1641,"context_line":"            if ext_link_ports is not None:"},{"line_number":1642,"context_line":"                self.assertIsNotNone(ext_link_ports.get(\u0027id\u0027))"},{"line_number":1643,"context_line":"                ext_link_ports_resource_handle \u003d ext_link_ports.get("},{"line_number":1644,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1645,"context_line":"                if ext_link_ports_resource_handle is not None:"},{"line_number":1646,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"81618c07_fdec702e","line":1644,"range":{"start_line":1643,"start_character":16,"end_line":1644,"end_character":43},"in_reply_to":"3961ffa5_c544237b","updated":"2021-03-24 07:43:52.000000000","message":"\u003e The resourceHandle is cardinallity:1 and I think it should be self.assertIsNotNone().\n\nadded self.assertIsNotNone() for \u0027resourceHandle\u0027","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1640,"context_line":"                    \u0027extLinkPorts\u0027, None)"},{"line_number":1641,"context_line":"            if ext_link_ports is not None:"},{"line_number":1642,"context_line":"                self.assertIsNotNone(ext_link_ports.get(\u0027id\u0027))"},{"line_number":1643,"context_line":"                ext_link_ports_resource_handle \u003d ext_link_ports.get("},{"line_number":1644,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1645,"context_line":"                if ext_link_ports_resource_handle is not None:"},{"line_number":1646,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"413aa5e9_2beeaca2","line":1644,"range":{"start_line":1643,"start_character":16,"end_line":1644,"end_character":43},"in_reply_to":"81618c07_fdec702e","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1643,"context_line":"                ext_link_ports_resource_handle \u003d ext_link_ports.get("},{"line_number":1644,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1645,"context_line":"                if ext_link_ports_resource_handle is not None:"},{"line_number":1646,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"},{"line_number":1648,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1649,"context_line":"                        \u0027resourceId\u0027))"},{"line_number":1650,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba6e7a92_da2ffa39","line":1647,"range":{"start_line":1646,"start_character":20,"end_line":1647,"end_character":43},"updated":"2021-03-17 01:21:22.000000000","message":"The vimConnectionId is cardinallity:0..1 and I think this assert should be removed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1643,"context_line":"                ext_link_ports_resource_handle \u003d ext_link_ports.get("},{"line_number":1644,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1645,"context_line":"                if ext_link_ports_resource_handle is not None:"},{"line_number":1646,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"},{"line_number":1648,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1649,"context_line":"                        \u0027resourceId\u0027))"},{"line_number":1650,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"8de69b0a_a22f14e9","line":1647,"range":{"start_line":1646,"start_character":20,"end_line":1647,"end_character":43},"in_reply_to":"493ae5ca_2182dfd2","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1643,"context_line":"                ext_link_ports_resource_handle \u003d ext_link_ports.get("},{"line_number":1644,"context_line":"                    \u0027resourceHandle\u0027, None)"},{"line_number":1645,"context_line":"                if ext_link_ports_resource_handle is not None:"},{"line_number":1646,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"},{"line_number":1648,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1649,"context_line":"                        \u0027resourceId\u0027))"},{"line_number":1650,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"493ae5ca_2182dfd2","line":1647,"range":{"start_line":1646,"start_character":20,"end_line":1647,"end_character":43},"in_reply_to":"ba6e7a92_da2ffa39","updated":"2021-03-24 07:43:52.000000000","message":"\u003e The vimConnectionId is cardinallity:0..1 and I think this assert should be removed.\n\ndeleted the assertIsNotNone() part of vimConnectionId","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"},{"line_number":1648,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1649,"context_line":"                        \u0027resourceId\u0027))"},{"line_number":1650,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1651,"context_line":"                        \u0027vimLevelResourceType\u0027))"},{"line_number":1652,"context_line":"                self.assertIsNotNone(ext_link_ports.get(\u0027cpInstanceId\u0027))"},{"line_number":1653,"context_line":""},{"line_number":1654,"context_line":"        _links \u003d fail_response.get(\u0027_links\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"49f84d2f_61b84257","line":1651,"range":{"start_line":1650,"start_character":20,"end_line":1651,"end_character":48},"updated":"2021-03-17 01:21:22.000000000","message":"ditto","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"},{"line_number":1648,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1649,"context_line":"                        \u0027resourceId\u0027))"},{"line_number":1650,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1651,"context_line":"                        \u0027vimLevelResourceType\u0027))"},{"line_number":1652,"context_line":"                self.assertIsNotNone(ext_link_ports.get(\u0027cpInstanceId\u0027))"},{"line_number":1653,"context_line":""},{"line_number":1654,"context_line":"        _links \u003d fail_response.get(\u0027_links\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"eac4a356_6372b262","line":1651,"range":{"start_line":1650,"start_character":20,"end_line":1651,"end_character":48},"in_reply_to":"49f84d2f_61b84257","updated":"2021-03-24 07:43:52.000000000","message":"\u003e ditto\n\ndeleted the assertIsNotNone() part of vimLevelResourceType","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1647,"context_line":"                        \u0027vimConnectionId\u0027))"},{"line_number":1648,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1649,"context_line":"                        \u0027resourceId\u0027))"},{"line_number":1650,"context_line":"                    self.assertIsNotNone(ext_link_ports_resource_handle.get("},{"line_number":1651,"context_line":"                        \u0027vimLevelResourceType\u0027))"},{"line_number":1652,"context_line":"                self.assertIsNotNone(ext_link_ports.get(\u0027cpInstanceId\u0027))"},{"line_number":1653,"context_line":""},{"line_number":1654,"context_line":"        _links \u003d fail_response.get(\u0027_links\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f65c6405_4c1a1abb","line":1651,"range":{"start_line":1650,"start_character":20,"end_line":1651,"end_character":48},"in_reply_to":"eac4a356_6372b262","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"955c2dbd6b46cf599b3ff22d19bc418cb9b24488","unresolved":true,"context_lines":[{"line_number":1656,"context_line":"        self.assertIsNotNone(_links.get(\u0027self\u0027).get(\u0027href\u0027))"},{"line_number":1657,"context_line":"        self.assertIsNotNone(_links.get(\u0027vnfInstance\u0027))"},{"line_number":1658,"context_line":"        self.assertIsNotNone(_links.get(\u0027vnfInstance\u0027).get(\u0027href\u0027))"},{"line_number":1659,"context_line":"        if _links.get(\u0027retry\u0027) is not None:"},{"line_number":1660,"context_line":"            self.assertIsNotNone(_links.get(\u0027retry\u0027))"},{"line_number":1661,"context_line":"            self.assertIsNotNone(_links.get(\u0027retry\u0027).get(\u0027href\u0027))"},{"line_number":1662,"context_line":"        if _links.get(\u0027fail\u0027) is not None:"},{"line_number":1663,"context_line":"            self.assertIsNotNone(_links.get(\u0027fail\u0027))"},{"line_number":1664,"context_line":"            self.assertIsNotNone(_links.get(\u0027fail\u0027).get(\u0027href\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"c103cf49_15ccb580","line":1664,"range":{"start_line":1659,"start_character":8,"end_line":1664,"end_character":64},"updated":"2021-03-17 01:21:22.000000000","message":"I think it\u0027s better to execute self.assertIsNotNone () for the href of \u0027rollback\u0027 and \u0027grant\u0027 as well.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5be826a26ba448956fed03e563253c9bc5e81339","unresolved":false,"context_lines":[{"line_number":1656,"context_line":"        self.assertIsNotNone(_links.get(\u0027self\u0027).get(\u0027href\u0027))"},{"line_number":1657,"context_line":"        self.assertIsNotNone(_links.get(\u0027vnfInstance\u0027))"},{"line_number":1658,"context_line":"        self.assertIsNotNone(_links.get(\u0027vnfInstance\u0027).get(\u0027href\u0027))"},{"line_number":1659,"context_line":"        if _links.get(\u0027retry\u0027) is not None:"},{"line_number":1660,"context_line":"            self.assertIsNotNone(_links.get(\u0027retry\u0027))"},{"line_number":1661,"context_line":"            self.assertIsNotNone(_links.get(\u0027retry\u0027).get(\u0027href\u0027))"},{"line_number":1662,"context_line":"        if _links.get(\u0027fail\u0027) is not None:"},{"line_number":1663,"context_line":"            self.assertIsNotNone(_links.get(\u0027fail\u0027))"},{"line_number":1664,"context_line":"            self.assertIsNotNone(_links.get(\u0027fail\u0027).get(\u0027href\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ae7f4599_2df5cd57","line":1664,"range":{"start_line":1659,"start_character":8,"end_line":1664,"end_character":64},"in_reply_to":"72fc0adb_7c906b6e","updated":"2021-03-25 00:40:30.000000000","message":"I\u0027ve confirmed.","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"18a47f82908cd25a075424e9440841a6accbd212","unresolved":true,"context_lines":[{"line_number":1656,"context_line":"        self.assertIsNotNone(_links.get(\u0027self\u0027).get(\u0027href\u0027))"},{"line_number":1657,"context_line":"        self.assertIsNotNone(_links.get(\u0027vnfInstance\u0027))"},{"line_number":1658,"context_line":"        self.assertIsNotNone(_links.get(\u0027vnfInstance\u0027).get(\u0027href\u0027))"},{"line_number":1659,"context_line":"        if _links.get(\u0027retry\u0027) is not None:"},{"line_number":1660,"context_line":"            self.assertIsNotNone(_links.get(\u0027retry\u0027))"},{"line_number":1661,"context_line":"            self.assertIsNotNone(_links.get(\u0027retry\u0027).get(\u0027href\u0027))"},{"line_number":1662,"context_line":"        if _links.get(\u0027fail\u0027) is not None:"},{"line_number":1663,"context_line":"            self.assertIsNotNone(_links.get(\u0027fail\u0027))"},{"line_number":1664,"context_line":"            self.assertIsNotNone(_links.get(\u0027fail\u0027).get(\u0027href\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"72fc0adb_7c906b6e","line":1664,"range":{"start_line":1659,"start_character":8,"end_line":1664,"end_character":64},"in_reply_to":"c103cf49_15ccb580","updated":"2021-03-24 07:43:52.000000000","message":"\u003e I think it\u0027s better to execute self.assertIsNotNone () for the href of \u0027rollback\u0027 and \u0027grant\u0027 as well.\n\nadded self.assertIsNotNone() for \u0027rollback\u0027 and \u0027grant\u0027","commit_id":"cf6f8899bb82802083ed14e992411a65c0e02eb5"}]}