)]}'
{"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d85e2d91104a6071039b15d73d5e4a2b9cd354f2","unresolved":true,"context_lines":[{"line_number":947,"context_line":"            for policy_name, policy_dict in policy.items():"},{"line_number":948,"context_line":"                key_type \u003d [\u0027tosca.policies.nfv.AntiAffinityRule\u0027,"},{"line_number":949,"context_line":"                            \u0027tosca.policies.nfv.AffinityRule\u0027]"},{"line_number":950,"context_line":"                if policy_dict[\u0027type\u0027] in key_type:"},{"line_number":951,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint()"},{"line_number":952,"context_line":"                    key \u003d policy_dict[\u0027type\u0027]"},{"line_number":953,"context_line":"                    if affinity_type[key]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e3d55c81_46e2db1d","line":950,"range":{"start_line":950,"start_character":42,"end_line":950,"end_character":50},"updated":"2021-03-22 05:47:46.000000000","message":"I think you can use \u0027affinity_type.keys()\u0027 instead of \u0027key_type\u0027.\nThat way, I think you can also remove the definition of \u0027key_type\u0027.","commit_id":"551022b74a81c8c68fcad12bbe7cd1edcb0f7770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":false,"context_lines":[{"line_number":947,"context_line":"            for policy_name, policy_dict in policy.items():"},{"line_number":948,"context_line":"                key_type \u003d [\u0027tosca.policies.nfv.AntiAffinityRule\u0027,"},{"line_number":949,"context_line":"                            \u0027tosca.policies.nfv.AffinityRule\u0027]"},{"line_number":950,"context_line":"                if policy_dict[\u0027type\u0027] in key_type:"},{"line_number":951,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint()"},{"line_number":952,"context_line":"                    key \u003d policy_dict[\u0027type\u0027]"},{"line_number":953,"context_line":"                    if affinity_type[key]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"30eabc97_1238992e","line":950,"range":{"start_line":950,"start_character":42,"end_line":950,"end_character":50},"in_reply_to":"8384e407_ce3c5074","updated":"2021-03-24 02:17:36.000000000","message":"I\u0027ve confirmed.","commit_id":"551022b74a81c8c68fcad12bbe7cd1edcb0f7770"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ded2aba632190280ef7026ba279e6eb392e3a587","unresolved":true,"context_lines":[{"line_number":947,"context_line":"            for policy_name, policy_dict in policy.items():"},{"line_number":948,"context_line":"                key_type \u003d [\u0027tosca.policies.nfv.AntiAffinityRule\u0027,"},{"line_number":949,"context_line":"                            \u0027tosca.policies.nfv.AffinityRule\u0027]"},{"line_number":950,"context_line":"                if policy_dict[\u0027type\u0027] in key_type:"},{"line_number":951,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint()"},{"line_number":952,"context_line":"                    key \u003d policy_dict[\u0027type\u0027]"},{"line_number":953,"context_line":"                    if affinity_type[key]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"8384e407_ce3c5074","line":950,"range":{"start_line":950,"start_character":42,"end_line":950,"end_character":50},"in_reply_to":"e3d55c81_46e2db1d","updated":"2021-03-23 08:36:53.000000000","message":"\u003e I think you can use \u0027affinity_type.keys()\u0027 instead of \u0027key_type\u0027.\n\u003e That way, I think you can also remove the definition of \u0027key_type\u0027.\n\nmodified as suggested.","commit_id":"551022b74a81c8c68fcad12bbe7cd1edcb0f7770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"d85e2d91104a6071039b15d73d5e4a2b9cd354f2","unresolved":true,"context_lines":[{"line_number":950,"context_line":"                if policy_dict[\u0027type\u0027] in key_type:"},{"line_number":951,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint()"},{"line_number":952,"context_line":"                    key \u003d policy_dict[\u0027type\u0027]"},{"line_number":953,"context_line":"                    if affinity_type[key]:"},{"line_number":954,"context_line":"                        placement_constraint.affinity_or_anti_affinity \u003d ("},{"line_number":955,"context_line":"                            affinity_type[key])"},{"line_number":956,"context_line":"                    placement_constraint.scope \u003d \u0027ZONE\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"4f05660d_77b37610","line":953,"updated":"2021-03-22 05:47:46.000000000","message":"Since there is an if branch of L950, isn\u0027t this if branch unnecessary?","commit_id":"551022b74a81c8c68fcad12bbe7cd1edcb0f7770"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ded2aba632190280ef7026ba279e6eb392e3a587","unresolved":true,"context_lines":[{"line_number":950,"context_line":"                if policy_dict[\u0027type\u0027] in key_type:"},{"line_number":951,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint()"},{"line_number":952,"context_line":"                    key \u003d policy_dict[\u0027type\u0027]"},{"line_number":953,"context_line":"                    if affinity_type[key]:"},{"line_number":954,"context_line":"                        placement_constraint.affinity_or_anti_affinity \u003d ("},{"line_number":955,"context_line":"                            affinity_type[key])"},{"line_number":956,"context_line":"                    placement_constraint.scope \u003d \u0027ZONE\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"f340095f_a53f8960","line":953,"in_reply_to":"4f05660d_77b37610","updated":"2021-03-23 08:36:53.000000000","message":"\u003e Since there is an if branch of L950, isn\u0027t this if branch unnecessary?\n\nremoved the if branch due to L950.","commit_id":"551022b74a81c8c68fcad12bbe7cd1edcb0f7770"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                if policy_dict[\u0027type\u0027] in key_type:"},{"line_number":951,"context_line":"                    placement_constraint \u003d objects.PlacementConstraint()"},{"line_number":952,"context_line":"                    key \u003d policy_dict[\u0027type\u0027]"},{"line_number":953,"context_line":"                    if affinity_type[key]:"},{"line_number":954,"context_line":"                        placement_constraint.affinity_or_anti_affinity \u003d ("},{"line_number":955,"context_line":"                            affinity_type[key])"},{"line_number":956,"context_line":"                    placement_constraint.scope \u003d \u0027ZONE\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"82c8f3ba_fdce546e","line":953,"in_reply_to":"f340095f_a53f8960","updated":"2021-03-24 02:17:36.000000000","message":"I\u0027ve confirmed.","commit_id":"551022b74a81c8c68fcad12bbe7cd1edcb0f7770"}],"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":232,"context_line":"            {\u0027get_param\u0027: [\u0027nfv\u0027, \u0027vdu\u0027, \u0027VDU1\u0027, \u0027zone\u0027]}}})"},{"line_number":233,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":234,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":235,"context_line":"        vimAssets \u003d {\u0027compute_resource_flavours\u0027: ["},{"line_number":236,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":237,"context_line":"             \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":238,"context_line":"             \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"d1424a0d_7a49ed70","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":17},"updated":"2021-03-24 02:17:36.000000000","message":"Please modify camelCase to snake_case.","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":232,"context_line":"            {\u0027get_param\u0027: [\u0027nfv\u0027, \u0027vdu\u0027, \u0027VDU1\u0027, \u0027zone\u0027]}}})"},{"line_number":233,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":234,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":235,"context_line":"        vimAssets \u003d {\u0027compute_resource_flavours\u0027: ["},{"line_number":236,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":237,"context_line":"             \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":238,"context_line":"             \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"f956514a_33a536a6","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":17},"in_reply_to":"d1424a0d_7a49ed70","updated":"2021-03-24 10:45:52.000000000","message":"\u003e Please modify camelCase to snake_case.\n\nchanged to snake_case","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            {\u0027get_param\u0027: [\u0027nfv\u0027, \u0027vdu\u0027, \u0027VDU1\u0027, \u0027zone\u0027]}}})"},{"line_number":233,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":234,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":235,"context_line":"        vimAssets \u003d {\u0027compute_resource_flavours\u0027: ["},{"line_number":236,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":237,"context_line":"             \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":238,"context_line":"             \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"80e76f20_fab372b2","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":17},"in_reply_to":"f956514a_33a536a6","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":241,"context_line":"             \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":242,"context_line":"             \u0027vim_software_image_id\u0027: \u0027cirros\u0027}]}"},{"line_number":243,"context_line":"        resAddResource \u003d []"},{"line_number":244,"context_line":"        resource \u003d {"},{"line_number":245,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":246,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"40347a77_149a9373","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":22},"updated":"2021-03-24 02:17:36.000000000","message":"ditto","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":241,"context_line":"             \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":242,"context_line":"             \u0027vim_software_image_id\u0027: \u0027cirros\u0027}]}"},{"line_number":243,"context_line":"        resAddResource \u003d []"},{"line_number":244,"context_line":"        resource \u003d {"},{"line_number":245,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":246,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"81065bbb_c826e584","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":22},"in_reply_to":"40347a77_149a9373","updated":"2021-03-24 10:45:52.000000000","message":"\u003e ditto\n\nchanged to snake_case","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":241,"context_line":"             \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":242,"context_line":"             \u0027vim_software_image_id\u0027: \u0027cirros\u0027}]}"},{"line_number":243,"context_line":"        resAddResource \u003d []"},{"line_number":244,"context_line":"        resource \u003d {"},{"line_number":245,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":246,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"83bee72f_d8a4102b","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":22},"in_reply_to":"81065bbb_c826e584","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":448,"context_line":"            \u0027resources\u0027: {\u0027VDU1\u0027: {\u0027properties\u0027: {}}}}}"},{"line_number":449,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":450,"context_line":"            self._read_file(), nested_hot_dict"},{"line_number":451,"context_line":"        vimAssets \u003d {\u0027compute_resource_flavours\u0027: ["},{"line_number":452,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":453,"context_line":"             \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":454,"context_line":"             \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"16d79cb3_040a7c7e","line":451,"range":{"start_line":451,"start_character":8,"end_line":451,"end_character":17},"updated":"2021-03-24 02:17:36.000000000","message":"ditto","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":448,"context_line":"            \u0027resources\u0027: {\u0027VDU1\u0027: {\u0027properties\u0027: {}}}}}"},{"line_number":449,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":450,"context_line":"            self._read_file(), nested_hot_dict"},{"line_number":451,"context_line":"        vimAssets \u003d {\u0027compute_resource_flavours\u0027: ["},{"line_number":452,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":453,"context_line":"             \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":454,"context_line":"             \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"9bd6d076_dc905018","line":451,"range":{"start_line":451,"start_character":8,"end_line":451,"end_character":17},"in_reply_to":"16d79cb3_040a7c7e","updated":"2021-03-24 10:45:52.000000000","message":"\u003e ditto\n\nchanged to snake_case","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            \u0027resources\u0027: {\u0027VDU1\u0027: {\u0027properties\u0027: {}}}}}"},{"line_number":449,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":450,"context_line":"            self._read_file(), nested_hot_dict"},{"line_number":451,"context_line":"        vimAssets \u003d {\u0027compute_resource_flavours\u0027: ["},{"line_number":452,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":453,"context_line":"             \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":454,"context_line":"             \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"}],"source_content_type":"text/x-python","patch_set":8,"id":"28f61ac1_f3cfaf8e","line":451,"range":{"start_line":451,"start_character":8,"end_line":451,"end_character":17},"in_reply_to":"9bd6d076_dc905018","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":456,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":457,"context_line":"             \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":458,"context_line":"             \u0027vim_software_image_id\u0027: \u0027cirros\u0027}]}"},{"line_number":459,"context_line":"        resAddResource \u003d []"},{"line_number":460,"context_line":"        resource \u003d {"},{"line_number":461,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":462,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"8537fd5f_db4ce2d1","line":459,"range":{"start_line":459,"start_character":8,"end_line":459,"end_character":22},"updated":"2021-03-24 02:17:36.000000000","message":"ditto","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":456,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":457,"context_line":"             \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":458,"context_line":"             \u0027vim_software_image_id\u0027: \u0027cirros\u0027}]}"},{"line_number":459,"context_line":"        resAddResource \u003d []"},{"line_number":460,"context_line":"        resource \u003d {"},{"line_number":461,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":462,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"87d4539c_9f41e1af","line":459,"range":{"start_line":459,"start_character":8,"end_line":459,"end_character":22},"in_reply_to":"8537fd5f_db4ce2d1","updated":"2021-03-24 10:45:52.000000000","message":"\u003e ditto\n\nchanged to snake_case","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":457,"context_line":"             \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":458,"context_line":"             \u0027vim_software_image_id\u0027: \u0027cirros\u0027}]}"},{"line_number":459,"context_line":"        resAddResource \u003d []"},{"line_number":460,"context_line":"        resource \u003d {"},{"line_number":461,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":462,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"d315d31d_a19e9e2c","line":459,"range":{"start_line":459,"start_character":8,"end_line":459,"end_character":22},"in_reply_to":"87d4539c_9f41e1af","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":2164,"context_line":"                                                   aspect_id\u003d\u0027SP1\u0027,"},{"line_number":2165,"context_line":"                                                   number_of_steps\u003d1)"},{"line_number":2166,"context_line":"        vnf_info \u003d {}"},{"line_number":2167,"context_line":"        addResources \u003d []"},{"line_number":2168,"context_line":"        resource \u003d objects.ResourceDefinition("},{"line_number":2169,"context_line":"            id\u003d\u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":2170,"context_line":"            type\u003d\u0027COMPUTE\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"175f8b16_25e231f1","line":2167,"range":{"start_line":2167,"start_character":8,"end_line":2167,"end_character":20},"updated":"2021-03-24 02:17:36.000000000","message":"ditto","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":2164,"context_line":"                                                   aspect_id\u003d\u0027SP1\u0027,"},{"line_number":2165,"context_line":"                                                   number_of_steps\u003d1)"},{"line_number":2166,"context_line":"        vnf_info \u003d {}"},{"line_number":2167,"context_line":"        addResources \u003d []"},{"line_number":2168,"context_line":"        resource \u003d objects.ResourceDefinition("},{"line_number":2169,"context_line":"            id\u003d\u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":2170,"context_line":"            type\u003d\u0027COMPUTE\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"17bb068f_47614ce8","line":2167,"range":{"start_line":2167,"start_character":8,"end_line":2167,"end_character":20},"in_reply_to":"175f8b16_25e231f1","updated":"2021-03-24 10:45:52.000000000","message":"\u003e ditto\n\nchanged to snake_case","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":2164,"context_line":"                                                   aspect_id\u003d\u0027SP1\u0027,"},{"line_number":2165,"context_line":"                                                   number_of_steps\u003d1)"},{"line_number":2166,"context_line":"        vnf_info \u003d {}"},{"line_number":2167,"context_line":"        addResources \u003d []"},{"line_number":2168,"context_line":"        resource \u003d objects.ResourceDefinition("},{"line_number":2169,"context_line":"            id\u003d\u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":2170,"context_line":"            type\u003d\u0027COMPUTE\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"029e2dbd_855dcca2","line":2167,"range":{"start_line":2167,"start_character":8,"end_line":2167,"end_character":20},"in_reply_to":"17bb068f_47614ce8","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":2257,"context_line":"                                                   aspect_id\u003d\u0027SP1\u0027,"},{"line_number":2258,"context_line":"                                                   number_of_steps\u003d1)"},{"line_number":2259,"context_line":"        vnf_info \u003d {}"},{"line_number":2260,"context_line":"        addResources \u003d []"},{"line_number":2261,"context_line":"        resource \u003d objects.ResourceDefinition("},{"line_number":2262,"context_line":"            id\u003d\u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":2263,"context_line":"            type\u003d\u0027COMPUTE\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"61997276_22237b2f","line":2260,"range":{"start_line":2260,"start_character":8,"end_line":2260,"end_character":20},"updated":"2021-03-24 02:17:36.000000000","message":"ditto","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":2257,"context_line":"                                                   aspect_id\u003d\u0027SP1\u0027,"},{"line_number":2258,"context_line":"                                                   number_of_steps\u003d1)"},{"line_number":2259,"context_line":"        vnf_info \u003d {}"},{"line_number":2260,"context_line":"        addResources \u003d []"},{"line_number":2261,"context_line":"        resource \u003d objects.ResourceDefinition("},{"line_number":2262,"context_line":"            id\u003d\u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":2263,"context_line":"            type\u003d\u0027COMPUTE\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ab5c5fe2_a5451e06","line":2260,"range":{"start_line":2260,"start_character":8,"end_line":2260,"end_character":20},"in_reply_to":"61997276_22237b2f","updated":"2021-03-24 10:45:52.000000000","message":"\u003e ditto\n\nchanged to snake_case","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":2257,"context_line":"                                                   aspect_id\u003d\u0027SP1\u0027,"},{"line_number":2258,"context_line":"                                                   number_of_steps\u003d1)"},{"line_number":2259,"context_line":"        vnf_info \u003d {}"},{"line_number":2260,"context_line":"        addResources \u003d []"},{"line_number":2261,"context_line":"        resource \u003d objects.ResourceDefinition("},{"line_number":2262,"context_line":"            id\u003d\u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":2263,"context_line":"            type\u003d\u0027COMPUTE\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ed1ff88d_c7ebe498","line":2260,"range":{"start_line":2260,"start_character":8,"end_line":2260,"end_character":20},"in_reply_to":"ab5c5fe2_a5451e06","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"0907f59521c6263d00acfe67a937d2ff46755b19"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"756271ab393c915161772e613fd1d610dac1fb04","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            yaml_name \u003d vdu_name + \u0027.yaml\u0027"},{"line_number":298,"context_line":"                            if not (nested_hot_dict[yaml_name]"},{"line_number":299,"context_line":"                                    [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":300,"context_line":"                                (nested_hot_dict[yaml_name][\u0027parameters\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"f197ada1_2fe4a2ae","line":297,"range":{"start_line":297,"start_character":28,"end_line":297,"end_character":58},"updated":"2021-03-11 05:11:36.000000000","message":"This code is implemented on the premise of the child HOT name is VDU_ID.yaml, and it seems that it cannot support cases where the child HOT naming convention is different.\nI think this assumption is not appropriate, so can you support a child HOT with any name?","commit_id":"ecce4bff899922c8127e7638790684b1c62689bf"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            yaml_name \u003d vdu_name + \u0027.yaml\u0027"},{"line_number":298,"context_line":"                            if not (nested_hot_dict[yaml_name]"},{"line_number":299,"context_line":"                                    [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":300,"context_line":"                                (nested_hot_dict[yaml_name][\u0027parameters\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"8cc38832_ad2066d5","line":297,"range":{"start_line":297,"start_character":28,"end_line":297,"end_character":58},"in_reply_to":"0ce5ab76_9cf005f9","updated":"2021-03-24 02:17:36.000000000","message":"I\u0027ve confirmed.","commit_id":"ecce4bff899922c8127e7638790684b1c62689bf"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"f56351aeb38857149f348a8e23623f0a37d719aa","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            yaml_name \u003d vdu_name + \u0027.yaml\u0027"},{"line_number":298,"context_line":"                            if not (nested_hot_dict[yaml_name]"},{"line_number":299,"context_line":"                                    [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":300,"context_line":"                                (nested_hot_dict[yaml_name][\u0027parameters\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"0ce5ab76_9cf005f9","line":297,"range":{"start_line":297,"start_character":28,"end_line":297,"end_character":58},"in_reply_to":"f197ada1_2fe4a2ae","updated":"2021-03-17 02:39:03.000000000","message":"\u003e This code is implemented on the premise of the child HOT name is VDU_ID.yaml, and it seems that it cannot support cases where the child HOT naming convention is different.\n\u003e I think this assumption is not appropriate, so can you support a child HOT with any name?\n\nAdded support for all child HOT names","commit_id":"ecce4bff899922c8127e7638790684b1c62689bf"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"756271ab393c915161772e613fd1d610dac1fb04","unresolved":true,"context_lines":[{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            yaml_name \u003d vdu_name + \u0027.yaml\u0027"},{"line_number":298,"context_line":"                            if not (nested_hot_dict[yaml_name]"},{"line_number":299,"context_line":"                                    [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":300,"context_line":"                                (nested_hot_dict[yaml_name][\u0027parameters\u0027]"},{"line_number":301,"context_line":"                                    [\u0027zone\u0027])\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"75eac28d_0c5df884","line":298,"range":{"start_line":298,"start_character":36,"end_line":298,"end_character":51},"updated":"2021-03-11 05:11:36.000000000","message":"This code is implemented on the premise of nested HOT, and it seems that it cannot support non-nested HOT.\nI think this premise is not appropriate, so can you support non-nested HOT?","commit_id":"ecce4bff899922c8127e7638790684b1c62689bf"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"f56351aeb38857149f348a8e23623f0a37d719aa","unresolved":true,"context_lines":[{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            yaml_name \u003d vdu_name + \u0027.yaml\u0027"},{"line_number":298,"context_line":"                            if not (nested_hot_dict[yaml_name]"},{"line_number":299,"context_line":"                                    [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":300,"context_line":"                                (nested_hot_dict[yaml_name][\u0027parameters\u0027]"},{"line_number":301,"context_line":"                                    [\u0027zone\u0027])\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"aef71b94_40136992","line":298,"range":{"start_line":298,"start_character":36,"end_line":298,"end_character":51},"in_reply_to":"75eac28d_0c5df884","updated":"2021-03-17 02:39:03.000000000","message":"\u003e This code is implemented on the premise of nested HOT, and it seems that it cannot support non-nested HOT.\n\u003e I think this premise is not appropriate, so can you support non-nested HOT?\n\nAdded support for non-nested HOTs","commit_id":"ecce4bff899922c8127e7638790684b1c62689bf"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            yaml_name \u003d vdu_name + \u0027.yaml\u0027"},{"line_number":298,"context_line":"                            if not (nested_hot_dict[yaml_name]"},{"line_number":299,"context_line":"                                    [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":300,"context_line":"                                (nested_hot_dict[yaml_name][\u0027parameters\u0027]"},{"line_number":301,"context_line":"                                    [\u0027zone\u0027])\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a8008b6_57647b21","line":298,"range":{"start_line":298,"start_character":36,"end_line":298,"end_character":51},"in_reply_to":"aef71b94_40136992","updated":"2021-03-24 02:17:36.000000000","message":"I\u0027ve confirmed.","commit_id":"ecce4bff899922c8127e7638790684b1c62689bf"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ef3c58143e70dcec28e1255d4a313fc8e10373fc","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"506c797b_e906aa96","line":280,"updated":"2021-03-18 04:21:18.000000000","message":"Since the base_hot_dict operation looks complicated, is it a little simpler to do the following?\n---\nvdu_prop \u003d base_hot_dict[\u0027resources\u0027][vdu_name][\u0027properties\u0027]\nif not vdu_prop.get(\u0027resource\u0027):\n    vdu_prop[\u0027resource\u0027] \u003d {\u0027properties\u0027: {}}\nvdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]\nif not vdu_rsrc_prop.get(\u0027zone\u0027):\n    vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027: [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ded2aba632190280ef7026ba279e6eb392e3a587","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"6609d9a3_9d09c128","line":280,"in_reply_to":"506c797b_e906aa96","updated":"2021-03-23 08:36:53.000000000","message":"\u003e Since the base_hot_dict operation looks complicated, is it a little simpler to do the following?\n\u003e ---\n\u003e vdu_prop \u003d base_hot_dict[\u0027resources\u0027][vdu_name][\u0027properties\u0027]\n\u003e if not vdu_prop.get(\u0027resource\u0027):\n\u003e     vdu_prop[\u0027resource\u0027] \u003d {\u0027properties\u0027: {}}\n\u003e vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]\n\u003e if not vdu_rsrc_prop.get(\u0027zone\u0027):\n\u003e     vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027: [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}\n\nFixed as suggested.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd20975a_b582a027","line":280,"in_reply_to":"6609d9a3_9d09c128","updated":"2021-03-24 02:17:36.000000000","message":"L284 and L291 haven\u0027t been fixed as commented, but is there any reason why they can\u0027t be fixed?","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1da0280_9f1333a7","line":280,"in_reply_to":"bd20975a_b582a027","updated":"2021-03-24 10:45:52.000000000","message":"\u003e L284 and L291 haven\u0027t been fixed as commented, but is there any reason why they can\u0027t be fixed?\n\nIt was possible to put it in another directory to judge base_hot_dict/nested_hot_dict, however,eventually, the part to update base_hot_dict/nested_hot_dict needs to be in the current state, so it could not be modified.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6f72fe_a24eb8b5","line":280,"in_reply_to":"c1da0280_9f1333a7","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ef3c58143e70dcec28e1255d4a313fc8e10373fc","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa69fa2c_45456b71","line":297,"updated":"2021-03-18 04:21:18.000000000","message":"Same as L280 comment.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dba7987f_9d4d81f6","line":297,"in_reply_to":"48b14456_5a8d90a9","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"48b14456_5a8d90a9","line":297,"in_reply_to":"7cdee013_7b3902fe","updated":"2021-03-24 10:45:52.000000000","message":"\u003e Same as L280.\n\nIt was possible to put it in another directory to judge base_hot_dict/nested_hot_dict, however,eventually, the part to update base_hot_dict/nested_hot_dict needs to be in the current state, so it could not be modified.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7cdee013_7b3902fe","line":297,"in_reply_to":"85ac1a21_c5d68066","updated":"2021-03-24 02:17:36.000000000","message":"Same as L280.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ded2aba632190280ef7026ba279e6eb392e3a587","unresolved":true,"context_lines":[{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"85ac1a21_c5d68066","line":297,"in_reply_to":"aa69fa2c_45456b71","updated":"2021-03-23 08:36:53.000000000","message":"\u003e Same as L280 comment.\n\nFixed as suggested.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ef3c58143e70dcec28e1255d4a313fc8e10373fc","unresolved":true,"context_lines":[{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"8f800eed_1c97be9f","line":315,"updated":"2021-03-18 04:21:18.000000000","message":"Same as L280 comment.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"cf94d67c7d3c8a6be5f60dac9c387440217fe00b","unresolved":true,"context_lines":[{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7e98460_e8c98d42","line":315,"in_reply_to":"373f4cd2_a6c0e6f4","updated":"2021-03-24 10:45:52.000000000","message":"\u003e Same as L280.\n\nIt was possible to put it in another directory to judge base_hot_dict/nested_hot_dict, however,eventually, the part to update base_hot_dict/nested_hot_dict needs to be in the current state, so it could not be modified.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"bf4fc54ecdce73783fe15357936e53c792429868","unresolved":true,"context_lines":[{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8f7a747_7a9cc17b","line":315,"in_reply_to":"8f800eed_1c97be9f","updated":"2021-03-24 01:55:19.000000000","message":"\u003e Same as L280 comment.\n\nFixed as suggested.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"bdb9bce5_08d0600f","line":315,"in_reply_to":"c7e98460_e8c98d42","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f95d9bdb7c185b41e65e063f7e41f4f660f14ddb","unresolved":true,"context_lines":[{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"}],"source_content_type":"text/x-python","patch_set":2,"id":"373f4cd2_a6c0e6f4","line":315,"in_reply_to":"e8f7a747_7a9cc17b","updated":"2021-03-24 02:17:36.000000000","message":"Same as L280.","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ef3c58143e70dcec28e1255d4a313fc8e10373fc","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":284,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027])\\"},{"line_number":285,"context_line":"                                    \u003d {\u0027properties\u0027: {}}"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":288,"context_line":"                                    [vdu_name]"},{"line_number":289,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027]"},{"line_number":290,"context_line":"                                    [\u0027properties\u0027]).get(\u0027zone\u0027):"},{"line_number":291,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":292,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027]"},{"line_number":293,"context_line":"                                    [\u0027properties\u0027][\u0027zone\u0027])\\"},{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":301,"context_line":"                                        (nested_hot_dict[yaml_name]"},{"line_number":302,"context_line":"                                            [\u0027parameters\u0027][\u0027zone\u0027])\\"},{"line_number":303,"context_line":"                                            \u003d {\u0027type\u0027: \u0027string\u0027}"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":306,"context_line":"                                            [\u0027resources\u0027][vdu_name]"},{"line_number":307,"context_line":"                                            [\u0027properties\u0027])\\"},{"line_number":308,"context_line":"                                            .get(\u0027availability_zone\u0027):"},{"line_number":309,"context_line":"                                        (nested_hot_dict[yaml_name]"},{"line_number":310,"context_line":"                                            [\u0027resources\u0027][vdu_name]"},{"line_number":311,"context_line":"                                            [\u0027properties\u0027]"},{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"},{"line_number":319,"context_line":"                                    \u003d zone.zone_id"},{"line_number":320,"context_line":"                            if (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":321,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":322,"context_line":"                                    not zone.zone_id:"},{"line_number":323,"context_line":"                                del (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":324,"context_line":"                                     [vdu_name][\u0027zone\u0027])"},{"line_number":325,"context_line":"                if \u0027vim_assets\u0027 in grant and grant.vim_assets:"},{"line_number":326,"context_line":"                    for flavour in grant.vim_assets.compute_resource_flavours:"},{"line_number":327,"context_line":"                        vdu_name \u003d flavour.vnfd_virtual_compute_desc_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ab9a400_ae9c32ef","line":324,"range":{"start_line":280,"start_character":28,"end_line":324,"end_character":56},"updated":"2021-03-18 04:21:18.000000000","message":"Is it possible to improve unittest coverage to ensure that these codes work properly?\nThis is because these codes have many if branches, but since there is no unittest that does not enter the if branch, it cannot be confirmed by the test whether it works properly.\n---\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dff/779158/2/check/openstack-tox-cover/dffd85a/cover/tacker_vnfm_infra_drivers_openstack_openstack_py.html#t280","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"98d98bc5068155d0e18696bea1f48c6a528aa4e4","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":284,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027])\\"},{"line_number":285,"context_line":"                                    \u003d {\u0027properties\u0027: {}}"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":288,"context_line":"                                    [vdu_name]"},{"line_number":289,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027]"},{"line_number":290,"context_line":"                                    [\u0027properties\u0027]).get(\u0027zone\u0027):"},{"line_number":291,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":292,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027]"},{"line_number":293,"context_line":"                                    [\u0027properties\u0027][\u0027zone\u0027])\\"},{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":301,"context_line":"                                        (nested_hot_dict[yaml_name]"},{"line_number":302,"context_line":"                                            [\u0027parameters\u0027][\u0027zone\u0027])\\"},{"line_number":303,"context_line":"                                            \u003d {\u0027type\u0027: \u0027string\u0027}"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":306,"context_line":"                                            [\u0027resources\u0027][vdu_name]"},{"line_number":307,"context_line":"                                            [\u0027properties\u0027])\\"},{"line_number":308,"context_line":"                                            .get(\u0027availability_zone\u0027):"},{"line_number":309,"context_line":"                                        (nested_hot_dict[yaml_name]"},{"line_number":310,"context_line":"                                            [\u0027resources\u0027][vdu_name]"},{"line_number":311,"context_line":"                                            [\u0027properties\u0027]"},{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"},{"line_number":319,"context_line":"                                    \u003d zone.zone_id"},{"line_number":320,"context_line":"                            if (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":321,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":322,"context_line":"                                    not zone.zone_id:"},{"line_number":323,"context_line":"                                del (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":324,"context_line":"                                     [vdu_name][\u0027zone\u0027])"},{"line_number":325,"context_line":"                if \u0027vim_assets\u0027 in grant and grant.vim_assets:"},{"line_number":326,"context_line":"                    for flavour in grant.vim_assets.compute_resource_flavours:"},{"line_number":327,"context_line":"                        vdu_name \u003d flavour.vnfd_virtual_compute_desc_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"7bb34599_049e789f","line":324,"range":{"start_line":280,"start_character":28,"end_line":324,"end_character":56},"in_reply_to":"39e8844d_96c56325","updated":"2021-03-25 02:55:08.000000000","message":"Done","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ded2aba632190280ef7026ba279e6eb392e3a587","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":281,"context_line":"                                    [vdu_name][\u0027properties\u0027])\\"},{"line_number":282,"context_line":"                                    .get(\u0027resource\u0027):"},{"line_number":283,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":284,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027])\\"},{"line_number":285,"context_line":"                                    \u003d {\u0027properties\u0027: {}}"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"                            if not (base_hot_dict[\u0027resources\u0027]"},{"line_number":288,"context_line":"                                    [vdu_name]"},{"line_number":289,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027]"},{"line_number":290,"context_line":"                                    [\u0027properties\u0027]).get(\u0027zone\u0027):"},{"line_number":291,"context_line":"                                (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":292,"context_line":"                                    [\u0027properties\u0027][\u0027resource\u0027]"},{"line_number":293,"context_line":"                                    [\u0027properties\u0027][\u0027zone\u0027])\\"},{"line_number":294,"context_line":"                                    \u003d {\u0027get_param\u0027:"},{"line_number":295,"context_line":"                                        [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"                            if nested_hot_dict:"},{"line_number":298,"context_line":"                                for yaml_name in nested_hot_dict:"},{"line_number":299,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":300,"context_line":"                                            [\u0027parameters\u0027]).get(\u0027zone\u0027):"},{"line_number":301,"context_line":"                                        (nested_hot_dict[yaml_name]"},{"line_number":302,"context_line":"                                            [\u0027parameters\u0027][\u0027zone\u0027])\\"},{"line_number":303,"context_line":"                                            \u003d {\u0027type\u0027: \u0027string\u0027}"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"                                    if not (nested_hot_dict[yaml_name]"},{"line_number":306,"context_line":"                                            [\u0027resources\u0027][vdu_name]"},{"line_number":307,"context_line":"                                            [\u0027properties\u0027])\\"},{"line_number":308,"context_line":"                                            .get(\u0027availability_zone\u0027):"},{"line_number":309,"context_line":"                                        (nested_hot_dict[yaml_name]"},{"line_number":310,"context_line":"                                            [\u0027resources\u0027][vdu_name]"},{"line_number":311,"context_line":"                                            [\u0027properties\u0027]"},{"line_number":312,"context_line":"                                            [\u0027availability_zone\u0027])\\"},{"line_number":313,"context_line":"                                            \u003d {\u0027get_param\u0027: \u0027zone\u0027}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"                            if not (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":316,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":317,"context_line":"                                    zone.zone_id:"},{"line_number":318,"context_line":"                                hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name][\u0027zone\u0027]\\"},{"line_number":319,"context_line":"                                    \u003d zone.zone_id"},{"line_number":320,"context_line":"                            if (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":321,"context_line":"                                    [vdu_name]).get(\u0027zone\u0027) and\\"},{"line_number":322,"context_line":"                                    not zone.zone_id:"},{"line_number":323,"context_line":"                                del (hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027]"},{"line_number":324,"context_line":"                                     [vdu_name][\u0027zone\u0027])"},{"line_number":325,"context_line":"                if \u0027vim_assets\u0027 in grant and grant.vim_assets:"},{"line_number":326,"context_line":"                    for flavour in grant.vim_assets.compute_resource_flavours:"},{"line_number":327,"context_line":"                        vdu_name \u003d flavour.vnfd_virtual_compute_desc_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"39e8844d_96c56325","line":324,"range":{"start_line":280,"start_character":28,"end_line":324,"end_character":56},"in_reply_to":"7ab9a400_ae9c32ef","updated":"2021-03-23 08:36:53.000000000","message":"\u003e Is it possible to improve unittest coverage to ensure that these codes work properly?\n\u003e This is because these codes have many if branches, but since there is no unittest that does not enter the if branch, it cannot be confirmed by the test whether it works properly.\n\u003e ---\n\u003e https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dff/779158/2/check/openstack-tox-cover/dffd85a/cover/tacker_vnfm_infra_drivers_openstack_openstack_py.html#t280\n\nAdded unit test coverage in tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py in test_create_grant(..) and test_create_grant_zone_add(..)","commit_id":"876afff72cc5b9d41ad57973ea0ad72cfd1bd64b"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"884ec1e1e2ddd82b771dab1ceae7b0fb1c4b497d","unresolved":true,"context_lines":[{"line_number":276,"context_line":"                                    break"},{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            vdu_prop \u003d ("},{"line_number":281,"context_line":"                                base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":282,"context_line":"                                [\u0027properties\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"721d3642_ab8a22be","line":279,"updated":"2021-03-24 23:50:35.000000000","message":"It is too deep indentation and too many continuation lines. It is hard to read, understand and review. I don\u0027t +1 until it is easy to read.","commit_id":"45fd1f3c975f1e244942ac7ed116232a175d3252"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"623428333a5d39dfcf9f56112bb67cdff9fc5522","unresolved":true,"context_lines":[{"line_number":276,"context_line":"                                    break"},{"line_number":277,"context_line":"                            if not vdu_name:"},{"line_number":278,"context_line":"                                continue"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                            vdu_prop \u003d ("},{"line_number":281,"context_line":"                                base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":282,"context_line":"                                [\u0027properties\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"fbce2595_9c586fec","line":279,"in_reply_to":"721d3642_ab8a22be","updated":"2021-03-26 02:56:30.000000000","message":"Oda-san, I agree to your suggestion and have updated (instead of Aldinson). Please give a comment if any problem.","commit_id":"45fd1f3c975f1e244942ac7ed116232a175d3252"}]}