)]}'
{".zuul.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"95c4c69f_b1445141","line":124,"updated":"2021-03-22 10:26:25.000000000","message":"Is this fix required for this patch?\nIf so, it\u0027s an important fix and I think you should include the reason for the fix in your commit message.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d3cc1e5a_b71f4e2b","line":124,"updated":"2021-03-23 02:05:01.000000000","message":"Just a question. Could I confirm what is the purpose of this change?","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba3976d2_7e4f8641","line":124,"in_reply_to":"1d84ec13_6a67027c","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"344d2a8efbf4b975e7f4520e221db40771b3d403","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1705158b_24d6ad1f","line":124,"in_reply_to":"2f1b4b2c_afafa959","updated":"2021-03-25 04:09:21.000000000","message":"Understand, thanks.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"1923fc47e52d9bf72779eb621067fc0493b90a44","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1d84ec13_6a67027c","line":124,"in_reply_to":"7b27dcd4_47578820","updated":"2021-03-24 13:31:15.000000000","message":"\u003e I checked the Commit message.\n\u003e Is the issue of Heat Stack deletion failing that caused this change to be caused by the newly added FT in this patch?\n\u003e Or is it a problem that could have occurred in the first place?\n\nYes, it was caused by the newly added FT in this patch. NFVO separation has only 1 test case so this issue was not detected, however, when we added the new test case, we faced the issue, the Image cache setting affected the test case. The issue always occured.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"10fd3fe9ad9e7d626add95b2a9b98dbea53af3a9","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c1ae8a35_67254da4","line":124,"in_reply_to":"95c4c69f_b1445141","updated":"2021-03-24 04:25:35.000000000","message":"\u003e Is this fix required for this patch?\n\u003e If so, it\u0027s an important fix and I think you should include the reason for the fix in your commit message.\n\nModified the commit message","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f9657d9e2abcaa80a3d06a5b72304b298409f959","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7b27dcd4_47578820","line":124,"in_reply_to":"c1ae8a35_67254da4","updated":"2021-03-24 05:59:30.000000000","message":"I checked the Commit message.\nIs the issue of Heat Stack deletion failing that caused this change to be caused by the newly added FT in this patch?\nOr is it a problem that could have occurred in the first place?","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            $NEUTRON_DHCP_CONF:"},{"line_number":122,"context_line":"              DEFAULT:"},{"line_number":123,"context_line":"                enable_isolated_metadata: True"},{"line_number":124,"context_line":"            $CINDER_CONF:"},{"line_number":125,"context_line":"              lvmdriver-1:"},{"line_number":126,"context_line":"                image_volume_cache_enabled: False"},{"line_number":127,"context_line":"        devstack_plugins:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"2f1b4b2c_afafa959","line":124,"in_reply_to":"d3cc1e5a_b71f4e2b","updated":"2021-03-24 03:57:53.000000000","message":"\u003e Just a question. Could I confirm what is the purpose of this change?\n\nWe disabled image_volume_cache, since cache Volume remains during Terminate implementation and responds to Heat Stack deletion failure without erasing volume type.The cache data affects the next test case(test can not create image)","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":1586,"context_line":"                \u0027VNF is not instantiated\u0027,"},{"line_number":1587,"context_line":"                409,"},{"line_number":1588,"context_line":"                title\u003d\u0027VNF IS NOT INSTANTIATED\u0027)"},{"line_number":1589,"context_line":"        vnf[\u0027before_error_point\u0027] \u003d 0"},{"line_number":1590,"context_line":"        self._change_ext_conn(context, vnf_instance, vnf, body)"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"    def _change_ext_conn(self, context, vnf_instance, vnf, request_body):"}],"source_content_type":"text/x-python","patch_set":7,"id":"91f4aaf2_d190d678","line":1589,"updated":"2021-03-22 10:26:25.000000000","message":"https://review.opendev.org/c/openstack/tacker/+/778948/8/tacker/objects/fields.py\nI think you should use the ErrorPoint in the above patch instead of the magic number.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":1586,"context_line":"                \u0027VNF is not instantiated\u0027,"},{"line_number":1587,"context_line":"                409,"},{"line_number":1588,"context_line":"                title\u003d\u0027VNF IS NOT INSTANTIATED\u0027)"},{"line_number":1589,"context_line":"        vnf[\u0027before_error_point\u0027] \u003d 0"},{"line_number":1590,"context_line":"        self._change_ext_conn(context, vnf_instance, vnf, body)"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"    def _change_ext_conn(self, context, vnf_instance, vnf, request_body):"}],"source_content_type":"text/x-python","patch_set":7,"id":"de4e8010_5910c375","line":1589,"in_reply_to":"91f4aaf2_d190d678","updated":"2021-03-24 03:57:53.000000000","message":"\u003e https://review.opendev.org/c/openstack/tacker/+/778948/8/tacker/objects/fields.py\n\u003e I think you should use the ErrorPoint in the above patch instead of the magic number.\n\nReplaced magic numbers to ErrorPoint constant.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fcf8b7915bb85c196948ea56c5c261681ca93f01","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"                \u0027VNF is not instantiated\u0027,"},{"line_number":1587,"context_line":"                409,"},{"line_number":1588,"context_line":"                title\u003d\u0027VNF IS NOT INSTANTIATED\u0027)"},{"line_number":1589,"context_line":"        vnf[\u0027before_error_point\u0027] \u003d 0"},{"line_number":1590,"context_line":"        self._change_ext_conn(context, vnf_instance, vnf, body)"},{"line_number":1591,"context_line":""},{"line_number":1592,"context_line":"    def _change_ext_conn(self, context, vnf_instance, vnf, request_body):"}],"source_content_type":"text/x-python","patch_set":7,"id":"b49b7af0_6c42da89","line":1589,"in_reply_to":"de4e8010_5910c375","updated":"2021-03-24 04:59:39.000000000","message":"I\u0027ve confirmed.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":2102,"context_line":"            change_ext_conn_req,"},{"line_number":2103,"context_line":"            vnf_lcm_op_occs_id):"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003d\u003d 0:"},{"line_number":2106,"context_line":"            self._change_ext_conn_grant("},{"line_number":2107,"context_line":"                context,"},{"line_number":2108,"context_line":"                vnf_instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"baed92ee_4977e01d","line":2105,"range":{"start_line":2105,"start_character":45,"end_line":2105,"end_character":46},"updated":"2021-03-22 10:26:25.000000000","message":"https://review.opendev.org/c/openstack/tacker/+/778948/8/tacker/objects/fields.py\nI think you should use the ErrorPoint in the above patch instead of the magic number.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":false,"context_lines":[{"line_number":2102,"context_line":"            change_ext_conn_req,"},{"line_number":2103,"context_line":"            vnf_lcm_op_occs_id):"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003d\u003d 0:"},{"line_number":2106,"context_line":"            self._change_ext_conn_grant("},{"line_number":2107,"context_line":"                context,"},{"line_number":2108,"context_line":"                vnf_instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"07f05be6_f5e21d08","line":2105,"range":{"start_line":2105,"start_character":45,"end_line":2105,"end_character":46},"in_reply_to":"11b2b7e8_f4e5fb51","updated":"2021-03-24 10:34:28.000000000","message":"\u003e Modified .zuul.yaml to disable image_volume_cache, since cache\n\u003e Volume remains during Terminate implementation and responds to\n\u003e Heat Stack deletion failure without erasing volume type.\n\nSorry, but this comment does not make any sense to me.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":2102,"context_line":"            change_ext_conn_req,"},{"line_number":2103,"context_line":"            vnf_lcm_op_occs_id):"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003d\u003d 0:"},{"line_number":2106,"context_line":"            self._change_ext_conn_grant("},{"line_number":2107,"context_line":"                context,"},{"line_number":2108,"context_line":"                vnf_instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bde1659b_41351e39","line":2105,"range":{"start_line":2105,"start_character":45,"end_line":2105,"end_character":46},"in_reply_to":"baed92ee_4977e01d","updated":"2021-03-24 03:57:53.000000000","message":"\u003e https://review.opendev.org/c/openstack/tacker/+/778948/8/tacker/objects/fields.py\n\u003e I think you should use the ErrorPoint in the above patch instead of the magic number.\n\nReplaced magic numbers to ErrorPoint constant.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fcf8b7915bb85c196948ea56c5c261681ca93f01","unresolved":false,"context_lines":[{"line_number":2102,"context_line":"            change_ext_conn_req,"},{"line_number":2103,"context_line":"            vnf_lcm_op_occs_id):"},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003d\u003d 0:"},{"line_number":2106,"context_line":"            self._change_ext_conn_grant("},{"line_number":2107,"context_line":"                context,"},{"line_number":2108,"context_line":"                vnf_instance,"}],"source_content_type":"text/x-python","patch_set":7,"id":"11b2b7e8_f4e5fb51","line":2105,"range":{"start_line":2105,"start_character":45,"end_line":2105,"end_character":46},"in_reply_to":"bde1659b_41351e39","updated":"2021-03-24 04:59:39.000000000","message":"Modified .zuul.yaml to disable image_volume_cache, since cache\nVolume remains during Terminate implementation and responds to\nHeat Stack deletion failure without erasing volume type.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e9fd52ceee89de9badba94bf73f74cd67c37bcc1","unresolved":true,"context_lines":[{"line_number":860,"context_line":"        results \u003d []"},{"line_number":861,"context_line":"        vnf_vl_resource_info \u003d vnf_info.vnf_virtual_link_resource_info"},{"line_number":862,"context_line":"        for vnf_vl_res in vnf_vl_resource_info:"},{"line_number":863,"context_line":"            if vnf_vl_res.vnf_virtual_link_desc_id !\u003d ext_vl_id:"},{"line_number":864,"context_line":"                continue"},{"line_number":865,"context_line":"            if (vnf_vl_res.network_resource.resource_id !\u003d"},{"line_number":866,"context_line":"                    resource_id):"},{"line_number":867,"context_line":"                results.extend(vnf_vl_res.vnf_link_ports)"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        return results"},{"line_number":870,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"b8566d50_bbb39d1a","line":867,"range":{"start_line":863,"start_character":12,"end_line":867,"end_character":57},"updated":"2021-03-23 06:02:49.000000000","message":"I think these if branch is the same as below.\n---\nif (vnf_vl_res.vnf_virtual_link_desc_id \u003d\u003d ext_vl_id)  and \\\n        (vnf_vl_res.network_resource.resource_id !\u003d resource_id):\n    results.extend(vnf_vl_res.vnf_link_ports)","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":860,"context_line":"        results \u003d []"},{"line_number":861,"context_line":"        vnf_vl_resource_info \u003d vnf_info.vnf_virtual_link_resource_info"},{"line_number":862,"context_line":"        for vnf_vl_res in vnf_vl_resource_info:"},{"line_number":863,"context_line":"            if vnf_vl_res.vnf_virtual_link_desc_id !\u003d ext_vl_id:"},{"line_number":864,"context_line":"                continue"},{"line_number":865,"context_line":"            if (vnf_vl_res.network_resource.resource_id !\u003d"},{"line_number":866,"context_line":"                    resource_id):"},{"line_number":867,"context_line":"                results.extend(vnf_vl_res.vnf_link_ports)"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        return results"},{"line_number":870,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dff99549_451e37a2","line":867,"range":{"start_line":863,"start_character":12,"end_line":867,"end_character":57},"in_reply_to":"3d9bb2f0_3bfc2393","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":860,"context_line":"        results \u003d []"},{"line_number":861,"context_line":"        vnf_vl_resource_info \u003d vnf_info.vnf_virtual_link_resource_info"},{"line_number":862,"context_line":"        for vnf_vl_res in vnf_vl_resource_info:"},{"line_number":863,"context_line":"            if vnf_vl_res.vnf_virtual_link_desc_id !\u003d ext_vl_id:"},{"line_number":864,"context_line":"                continue"},{"line_number":865,"context_line":"            if (vnf_vl_res.network_resource.resource_id !\u003d"},{"line_number":866,"context_line":"                    resource_id):"},{"line_number":867,"context_line":"                results.extend(vnf_vl_res.vnf_link_ports)"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"        return results"},{"line_number":870,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3d9bb2f0_3bfc2393","line":867,"range":{"start_line":863,"start_character":12,"end_line":867,"end_character":57},"in_reply_to":"b8566d50_bbb39d1a","updated":"2021-03-24 10:34:28.000000000","message":"\u003e I think these if branch is the same as below.\n\u003e ---\n\u003e if (vnf_vl_res.vnf_virtual_link_desc_id \u003d\u003d ext_vl_id)  and \\\n\u003e         (vnf_vl_res.network_resource.resource_id !\u003d resource_id):\n\u003e     results.extend(vnf_vl_res.vnf_link_ports)\n\nIt is modified.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        def _create_resource_definition(resource, cpd_id\u003d\"\"):"},{"line_number":903,"context_line":"            rh \u003d resource.resource_handle"},{"line_number":904,"context_line":"            rd \u003d objects.ResourceDefinition()"},{"line_number":905,"context_line":"            rd.resource \u003d objects.ResourceHandle()"},{"line_number":906,"context_line":"            rd.id \u003d resource.id"},{"line_number":907,"context_line":"            rd.type \u003d constants.TYPE_LINKPORT"},{"line_number":908,"context_line":"            rd.resource_template_id \u003d cpd_id"},{"line_number":909,"context_line":"            rd.resource.vim_connection_id \u003d rh.vim_connection_id"},{"line_number":910,"context_line":"            rd.resource.resource_id \u003d rh.resource_id"},{"line_number":911,"context_line":"            rd.resource.vim_level_resource_type \u003d rh.vim_level_resource_type"},{"line_number":912,"context_line":"            return rd"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        update_resources \u003d dict()"},{"line_number":915,"context_line":"        for ext_vl in change_ext_conn_req.ext_virtual_links:"}],"source_content_type":"text/x-python","patch_set":8,"id":"4ad302fd_fba132c9","line":912,"range":{"start_line":902,"start_character":0,"end_line":912,"end_character":21},"updated":"2021-03-23 02:05:01.000000000","message":"Could you revise names of the function and variables. It is just a inner function, so it can be shorter. There are many `resource` making the function confusing.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"360204d2e7d90d10c7f265c6d8d3af0490aaecf4","unresolved":false,"context_lines":[{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        def _create_resource_definition(resource, cpd_id\u003d\"\"):"},{"line_number":903,"context_line":"            rh \u003d resource.resource_handle"},{"line_number":904,"context_line":"            rd \u003d objects.ResourceDefinition()"},{"line_number":905,"context_line":"            rd.resource \u003d objects.ResourceHandle()"},{"line_number":906,"context_line":"            rd.id \u003d resource.id"},{"line_number":907,"context_line":"            rd.type \u003d constants.TYPE_LINKPORT"},{"line_number":908,"context_line":"            rd.resource_template_id \u003d cpd_id"},{"line_number":909,"context_line":"            rd.resource.vim_connection_id \u003d rh.vim_connection_id"},{"line_number":910,"context_line":"            rd.resource.resource_id \u003d rh.resource_id"},{"line_number":911,"context_line":"            rd.resource.vim_level_resource_type \u003d rh.vim_level_resource_type"},{"line_number":912,"context_line":"            return rd"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        update_resources \u003d dict()"},{"line_number":915,"context_line":"        for ext_vl in change_ext_conn_req.ext_virtual_links:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5c2a2160_6a26ebd5","line":912,"range":{"start_line":902,"start_character":0,"end_line":912,"end_character":21},"in_reply_to":"0e23fb2d_4c48c5a6","updated":"2021-03-25 15:16:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        def _create_resource_definition(resource, cpd_id\u003d\"\"):"},{"line_number":903,"context_line":"            rh \u003d resource.resource_handle"},{"line_number":904,"context_line":"            rd \u003d objects.ResourceDefinition()"},{"line_number":905,"context_line":"            rd.resource \u003d objects.ResourceHandle()"},{"line_number":906,"context_line":"            rd.id \u003d resource.id"},{"line_number":907,"context_line":"            rd.type \u003d constants.TYPE_LINKPORT"},{"line_number":908,"context_line":"            rd.resource_template_id \u003d cpd_id"},{"line_number":909,"context_line":"            rd.resource.vim_connection_id \u003d rh.vim_connection_id"},{"line_number":910,"context_line":"            rd.resource.resource_id \u003d rh.resource_id"},{"line_number":911,"context_line":"            rd.resource.vim_level_resource_type \u003d rh.vim_level_resource_type"},{"line_number":912,"context_line":"            return rd"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        update_resources \u003d dict()"},{"line_number":915,"context_line":"        for ext_vl in change_ext_conn_req.ext_virtual_links:"}],"source_content_type":"text/x-python","patch_set":8,"id":"0e23fb2d_4c48c5a6","line":912,"range":{"start_line":902,"start_character":0,"end_line":912,"end_character":21},"in_reply_to":"4ad302fd_fba132c9","updated":"2021-03-24 03:57:53.000000000","message":"\u003e Could you revise names of the function and variables. It is just a inner function, so it can be shorter. There are many `resource` making the function confusing.\n\nChanged method name and argument name.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e9fd52ceee89de9badba94bf73f74cd67c37bcc1","unresolved":true,"context_lines":[{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        update_resources \u003d dict()"},{"line_number":915,"context_line":"        for ext_vl in change_ext_conn_req.ext_virtual_links:"},{"line_number":916,"context_line":"            nw_changed_resources \u003d self._get_vnf_link_ports_by_vl("},{"line_number":917,"context_line":"                vnf_inf, ext_vl.id, ext_vl.resource_id)"},{"line_number":918,"context_line":"            LOG.debug(\u0027nw_changed_resources {}\u0027.format(nw_changed_resources))"},{"line_number":919,"context_line":"            if nw_changed_resources:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a3cfd55_aef071df","line":916,"updated":"2021-03-23 06:02:49.000000000","message":"From L916 to 923, I think that it is the processing related to Network resources that have changed.\nPlease add a comment so that we can undersatand that.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        update_resources \u003d dict()"},{"line_number":915,"context_line":"        for ext_vl in change_ext_conn_req.ext_virtual_links:"},{"line_number":916,"context_line":"            nw_changed_resources \u003d self._get_vnf_link_ports_by_vl("},{"line_number":917,"context_line":"                vnf_inf, ext_vl.id, ext_vl.resource_id)"},{"line_number":918,"context_line":"            LOG.debug(\u0027nw_changed_resources {}\u0027.format(nw_changed_resources))"},{"line_number":919,"context_line":"            if nw_changed_resources:"}],"source_content_type":"text/x-python","patch_set":8,"id":"c84efdab_bc64f788","line":916,"in_reply_to":"3a3cfd55_aef071df","updated":"2021-03-24 10:34:28.000000000","message":"\u003e From L916 to 923, I think that it is the processing related to Network resources that have changed.\n\u003e Please add a comment so that we can undersatand that.\n\nComment is added.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        update_resources \u003d dict()"},{"line_number":915,"context_line":"        for ext_vl in change_ext_conn_req.ext_virtual_links:"},{"line_number":916,"context_line":"            nw_changed_resources \u003d self._get_vnf_link_ports_by_vl("},{"line_number":917,"context_line":"                vnf_inf, ext_vl.id, ext_vl.resource_id)"},{"line_number":918,"context_line":"            LOG.debug(\u0027nw_changed_resources {}\u0027.format(nw_changed_resources))"},{"line_number":919,"context_line":"            if nw_changed_resources:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f6ac010_1ef1815f","line":916,"in_reply_to":"c84efdab_bc64f788","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":919,"context_line":"            if nw_changed_resources:"},{"line_number":920,"context_line":"                for resource in nw_changed_resources:"},{"line_number":921,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":922,"context_line":"                        _create_resource_definition(resource)"},{"line_number":923,"context_line":"                continue"},{"line_number":924,"context_line":"            for ext_cp in ext_vl.ext_cps:"},{"line_number":925,"context_line":"                cp_changed_resources \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"9d5fafd3_8fc17bab","line":922,"updated":"2021-03-22 10:26:25.000000000","message":"This process will store resource_template_id \u003d \"\".\nBy definition of SOL003 v2.6.1, this attribute is cardinality: 1, but is it OK to store \"\"?","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":919,"context_line":"            if nw_changed_resources:"},{"line_number":920,"context_line":"                for resource in nw_changed_resources:"},{"line_number":921,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":922,"context_line":"                        _create_resource_definition(resource)"},{"line_number":923,"context_line":"                continue"},{"line_number":924,"context_line":"            for ext_cp in ext_vl.ext_cps:"},{"line_number":925,"context_line":"                cp_changed_resources \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"19ad7100_18aec557","line":922,"in_reply_to":"465a832e_ded53697","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":919,"context_line":"            if nw_changed_resources:"},{"line_number":920,"context_line":"                for resource in nw_changed_resources:"},{"line_number":921,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":922,"context_line":"                        _create_resource_definition(resource)"},{"line_number":923,"context_line":"                continue"},{"line_number":924,"context_line":"            for ext_cp in ext_vl.ext_cps:"},{"line_number":925,"context_line":"                cp_changed_resources \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"465a832e_ded53697","line":922,"in_reply_to":"9d5fafd3_8fc17bab","updated":"2021-03-24 03:57:53.000000000","message":"\u003e This process will store resource_template_id \u003d \"\".\n\u003e By definition of SOL003 v2.6.1, this attribute is cardinality: 1, but is it OK to store \"\"?\n\nAdd procedure, to get cpd_id corresponding linkport resource,  and set cpd_id to resource_template_id.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e9fd52ceee89de9badba94bf73f74cd67c37bcc1","unresolved":true,"context_lines":[{"line_number":921,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":922,"context_line":"                        _create_resource_definition(resource)"},{"line_number":923,"context_line":"                continue"},{"line_number":924,"context_line":"            for ext_cp in ext_vl.ext_cps:"},{"line_number":925,"context_line":"                cp_changed_resources \u003d \\"},{"line_number":926,"context_line":"                    self._get_vnf_link_ports_by_cp(vnf_inf, ext_cp.cpd_id)"},{"line_number":927,"context_line":"                LOG.debug(\u0027cp_changed_resources {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":8,"id":"31f66d3e_b102ead2","line":924,"updated":"2021-03-23 06:02:49.000000000","message":"From L924 to 931, I think that it is the processing related to Port resources that have changed.\nPlease add a comment so that we can undersatand that.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":921,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":922,"context_line":"                        _create_resource_definition(resource)"},{"line_number":923,"context_line":"                continue"},{"line_number":924,"context_line":"            for ext_cp in ext_vl.ext_cps:"},{"line_number":925,"context_line":"                cp_changed_resources \u003d \\"},{"line_number":926,"context_line":"                    self._get_vnf_link_ports_by_cp(vnf_inf, ext_cp.cpd_id)"},{"line_number":927,"context_line":"                LOG.debug(\u0027cp_changed_resources {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":8,"id":"6fea19c8_739defbf","line":924,"in_reply_to":"31f66d3e_b102ead2","updated":"2021-03-24 10:34:28.000000000","message":"\u003e From L924 to 931, I think that it is the processing related to Port resources that have changed.\n\u003e Please add a comment so that we can undersatand that.\n\nRegarding this, there is a specification arrangement, and it is supposed to acquire the corresponding LinkPort resource regardless of whether the CP state set in the request has changed.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":921,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":922,"context_line":"                        _create_resource_definition(resource)"},{"line_number":923,"context_line":"                continue"},{"line_number":924,"context_line":"            for ext_cp in ext_vl.ext_cps:"},{"line_number":925,"context_line":"                cp_changed_resources \u003d \\"},{"line_number":926,"context_line":"                    self._get_vnf_link_ports_by_cp(vnf_inf, ext_cp.cpd_id)"},{"line_number":927,"context_line":"                LOG.debug(\u0027cp_changed_resources {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":8,"id":"c6370459_0b24df04","line":924,"in_reply_to":"6fea19c8_739defbf","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e9fd52ceee89de9badba94bf73f74cd67c37bcc1","unresolved":true,"context_lines":[{"line_number":930,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":931,"context_line":"                        _create_resource_definition(resource, ext_cp.cpd_id)"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        update_resources_list \u003d list(update_resources.values())"},{"line_number":934,"context_line":"        LOG.debug(\"Update Resources: %s\", update_resources_list)"},{"line_number":935,"context_line":"        grant_request \u003d self._make_grant_request("},{"line_number":936,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"13a750d2_1b609495","line":933,"updated":"2021-03-23 06:02:49.000000000","message":"I thought that you could append resource information to update_resources_list from the beginning without defining update_resources.\nIs there any reason why you have to define update_resources(dict)?","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":930,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":931,"context_line":"                        _create_resource_definition(resource, ext_cp.cpd_id)"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        update_resources_list \u003d list(update_resources.values())"},{"line_number":934,"context_line":"        LOG.debug(\"Update Resources: %s\", update_resources_list)"},{"line_number":935,"context_line":"        grant_request \u003d self._make_grant_request("},{"line_number":936,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ea919ac6_5ae5ea65","line":933,"in_reply_to":"13a750d2_1b609495","updated":"2021-03-24 10:34:28.000000000","message":"\u003e I thought that you could append resource information to update_resources_list from the beginning without defining update_resources.\n\u003e Is there any reason why you have to define update_resources(dict)?\n\nI\u0027m using dict to eliminate duplicates because the retrieved resources can be duplicated.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":930,"context_line":"                    update_resources[resource.resource_handle.resource_id] \u003d \\"},{"line_number":931,"context_line":"                        _create_resource_definition(resource, ext_cp.cpd_id)"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"        update_resources_list \u003d list(update_resources.values())"},{"line_number":934,"context_line":"        LOG.debug(\"Update Resources: %s\", update_resources_list)"},{"line_number":935,"context_line":"        grant_request \u003d self._make_grant_request("},{"line_number":936,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e6bc7b1e_50944324","line":933,"in_reply_to":"ea919ac6_5ae5ea65","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":2094,"context_line":"            vnf_instance, operation_params)"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    @coordination.synchronized(\u0027{vnf_instance[id]}\u0027)"},{"line_number":2097,"context_line":"    def change_ext_conn("},{"line_number":2098,"context_line":"            self,"},{"line_number":2099,"context_line":"            context,"},{"line_number":2100,"context_line":"            vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"cdf7af75_a10903bb","line":2097,"updated":"2021-03-23 02:05:01.000000000","message":"Please add docstring for the function for describing the behaviour.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"360204d2e7d90d10c7f265c6d8d3af0490aaecf4","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"            vnf_instance, operation_params)"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    @coordination.synchronized(\u0027{vnf_instance[id]}\u0027)"},{"line_number":2097,"context_line":"    def change_ext_conn("},{"line_number":2098,"context_line":"            self,"},{"line_number":2099,"context_line":"            context,"},{"line_number":2100,"context_line":"            vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ea510bda_c9150059","line":2097,"in_reply_to":"571087b1_5dd72a81","updated":"2021-03-25 15:16:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":2094,"context_line":"            vnf_instance, operation_params)"},{"line_number":2095,"context_line":""},{"line_number":2096,"context_line":"    @coordination.synchronized(\u0027{vnf_instance[id]}\u0027)"},{"line_number":2097,"context_line":"    def change_ext_conn("},{"line_number":2098,"context_line":"            self,"},{"line_number":2099,"context_line":"            context,"},{"line_number":2100,"context_line":"            vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"571087b1_5dd72a81","line":2097,"in_reply_to":"cdf7af75_a10903bb","updated":"2021-03-24 10:34:28.000000000","message":"\u003e Please add docstring for the function for describing the behaviour.\n\nAdded docstring to change_ext_conn.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":2157,"context_line":"                        None, constants.ERROR, str(e))"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"            LOG.error(\u0027Failed to execute operation. error\u003d{}\u0027.format(e))"},{"line_number":2160,"context_line":"            if vnf_dict[\u0027current_error_point\u0027] in [3, 4]:"},{"line_number":2161,"context_line":"                self._update_instantiated_vnf_info_change_ext_conn("},{"line_number":2162,"context_line":"                    context, vnf_instance, change_ext_conn_req)"},{"line_number":2163,"context_line":""},{"line_number":2164,"context_line":"            # update vnf_lcm_op_occs and send notification \"FAILED_TEMP\""},{"line_number":2165,"context_line":"            self._send_lcm_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":8,"id":"577bf2e0_1a127b6e","line":2162,"range":{"start_line":2160,"start_character":12,"end_line":2162,"end_character":63},"updated":"2021-03-22 10:26:25.000000000","message":"After being called by L2141, self._update_instantiated_vnf_info_change_ext_conn() is called again in this error processing.\nIs this as expected?","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9d976eabec94624759addd0e0997a73c8407e983","unresolved":true,"context_lines":[{"line_number":2157,"context_line":"                        None, constants.ERROR, str(e))"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"            LOG.error(\u0027Failed to execute operation. error\u003d{}\u0027.format(e))"},{"line_number":2160,"context_line":"            if vnf_dict[\u0027current_error_point\u0027] in [3, 4]:"},{"line_number":2161,"context_line":"                self._update_instantiated_vnf_info_change_ext_conn("},{"line_number":2162,"context_line":"                    context, vnf_instance, change_ext_conn_req)"},{"line_number":2163,"context_line":""},{"line_number":2164,"context_line":"            # update vnf_lcm_op_occs and send notification \"FAILED_TEMP\""},{"line_number":2165,"context_line":"            self._send_lcm_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":8,"id":"b56b897f_59c889c6","line":2162,"range":{"start_line":2160,"start_character":12,"end_line":2162,"end_character":63},"in_reply_to":"41265160_ba07efed","updated":"2021-03-25 13:16:53.000000000","message":"\u003e I understand your answer.\n\u003e However, I thought that the original judgment below was better, but what about?\n\u003e ---\n\u003e if vnf_dict[\u0027current_error_point\u0027] in [EP.INTERNAL_PROCESSING, EP.VNF_CONFIG_END]:\n\nmodified as suggested.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":2157,"context_line":"                        None, constants.ERROR, str(e))"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"            LOG.error(\u0027Failed to execute operation. error\u003d{}\u0027.format(e))"},{"line_number":2160,"context_line":"            if vnf_dict[\u0027current_error_point\u0027] in [3, 4]:"},{"line_number":2161,"context_line":"                self._update_instantiated_vnf_info_change_ext_conn("},{"line_number":2162,"context_line":"                    context, vnf_instance, change_ext_conn_req)"},{"line_number":2163,"context_line":""},{"line_number":2164,"context_line":"            # update vnf_lcm_op_occs and send notification \"FAILED_TEMP\""},{"line_number":2165,"context_line":"            self._send_lcm_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":8,"id":"d891960a_f0e1ebe8","line":2162,"range":{"start_line":2160,"start_character":12,"end_line":2162,"end_character":63},"in_reply_to":"577bf2e0_1a127b6e","updated":"2021-03-24 10:34:28.000000000","message":"\u003e After being called by L2141, self._update_instantiated_vnf_info_change_ext_conn() is called again in this error processing.\n\u003e Is this as expected?\n\nIf an exception occurs after the stack update is completed inside self.vnflcm_driver.change_ext_conn_vnf, it is assumed that this process will be executed in the error process. Since it is different from the current assumption, it has been corrected including the judgment of the error point.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"440ed0fbbebfe131b3e92a080ebba41744adae41","unresolved":false,"context_lines":[{"line_number":2157,"context_line":"                        None, constants.ERROR, str(e))"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"            LOG.error(\u0027Failed to execute operation. error\u003d{}\u0027.format(e))"},{"line_number":2160,"context_line":"            if vnf_dict[\u0027current_error_point\u0027] in [3, 4]:"},{"line_number":2161,"context_line":"                self._update_instantiated_vnf_info_change_ext_conn("},{"line_number":2162,"context_line":"                    context, vnf_instance, change_ext_conn_req)"},{"line_number":2163,"context_line":""},{"line_number":2164,"context_line":"            # update vnf_lcm_op_occs and send notification \"FAILED_TEMP\""},{"line_number":2165,"context_line":"            self._send_lcm_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":8,"id":"d0a3207a_887ec10e","line":2162,"range":{"start_line":2160,"start_character":12,"end_line":2162,"end_character":63},"in_reply_to":"b56b897f_59c889c6","updated":"2021-03-26 02:10:33.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":true,"context_lines":[{"line_number":2157,"context_line":"                        None, constants.ERROR, str(e))"},{"line_number":2158,"context_line":""},{"line_number":2159,"context_line":"            LOG.error(\u0027Failed to execute operation. error\u003d{}\u0027.format(e))"},{"line_number":2160,"context_line":"            if vnf_dict[\u0027current_error_point\u0027] in [3, 4]:"},{"line_number":2161,"context_line":"                self._update_instantiated_vnf_info_change_ext_conn("},{"line_number":2162,"context_line":"                    context, vnf_instance, change_ext_conn_req)"},{"line_number":2163,"context_line":""},{"line_number":2164,"context_line":"            # update vnf_lcm_op_occs and send notification \"FAILED_TEMP\""},{"line_number":2165,"context_line":"            self._send_lcm_op_occ_notification("}],"source_content_type":"text/x-python","patch_set":8,"id":"41265160_ba07efed","line":2162,"range":{"start_line":2160,"start_character":12,"end_line":2162,"end_character":63},"in_reply_to":"d891960a_f0e1ebe8","updated":"2021-03-25 04:58:55.000000000","message":"I understand your answer.\nHowever, I thought that the original judgment below was better, but what about?\n---\nif vnf_dict[\u0027current_error_point\u0027] in [EP.INTERNAL_PROCESSING, EP.VNF_CONFIG_END]:","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f9657d9e2abcaa80a3d06a5b72304b298409f959","unresolved":true,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        def _create_linkport_rd(linkport, cpd_id\u003d\"\"):"},{"line_number":904,"context_line":"            rh \u003d linkport.resource_handle"},{"line_number":905,"context_line":"            rd \u003d objects.ResourceDefinition()"},{"line_number":906,"context_line":"            rd.resource \u003d objects.ResourceHandle()"}],"source_content_type":"text/x-python","patch_set":10,"id":"31ea2db0_aa8f8dcd","line":903,"range":{"start_line":903,"start_character":48,"end_line":903,"end_character":51},"updated":"2021-03-24 05:59:30.000000000","message":"Isn\u0027t the default value unnecessary because it is never omitted?","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        def _create_linkport_rd(linkport, cpd_id\u003d\"\"):"},{"line_number":904,"context_line":"            rh \u003d linkport.resource_handle"},{"line_number":905,"context_line":"            rd \u003d objects.ResourceDefinition()"},{"line_number":906,"context_line":"            rd.resource \u003d objects.ResourceHandle()"}],"source_content_type":"text/x-python","patch_set":10,"id":"38925ce0_4cdff86d","line":903,"range":{"start_line":903,"start_character":48,"end_line":903,"end_character":51},"in_reply_to":"31ea2db0_aa8f8dcd","updated":"2021-03-24 10:34:28.000000000","message":"\u003e Isn\u0027t the default value unnecessary because it is never omitted?\n\nRemoved the default value for the cpd_id argument.","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"        vnf_inf \u003d vnf_instance.instantiated_vnf_info"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        def _create_linkport_rd(linkport, cpd_id\u003d\"\"):"},{"line_number":904,"context_line":"            rh \u003d linkport.resource_handle"},{"line_number":905,"context_line":"            rd \u003d objects.ResourceDefinition()"},{"line_number":906,"context_line":"            rd.resource \u003d objects.ResourceHandle()"}],"source_content_type":"text/x-python","patch_set":10,"id":"b9f7973c_c93ec154","line":903,"range":{"start_line":903,"start_character":48,"end_line":903,"end_character":51},"in_reply_to":"38925ce0_4cdff86d","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"}],"tacker/releasenotes/notes/change_external_vnf_connectivity-444c580a01479f33.yaml":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new RESTful APIs for Change External VNF Connectivity operation based on"},{"line_number":4,"context_line":"    ETSI NFV specifications."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"cb6a319b_3dd1825a","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":12},"updated":"2021-03-23 02:05:01.000000000","message":"No need to use `new` because we can understand that added things are new for the project without saying `new`.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new RESTful APIs for Change External VNF Connectivity operation based on"},{"line_number":4,"context_line":"    ETSI NFV specifications."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"36d909d6_ea0912c5","line":3,"updated":"2021-03-23 02:05:01.000000000","message":"We know that it\u0027s introduced for ETSI NFV. Why don\u0027t you say simply as \"Add REST APIs for Change External VNF Connectivity\" instead?","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new RESTful APIs for Change External VNF Connectivity operation based on"},{"line_number":4,"context_line":"    ETSI NFV specifications."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"b974b3b8_912c8a96","line":3,"in_reply_to":"36d909d6_ea0912c5","updated":"2021-03-24 03:57:53.000000000","message":"\u003e We know that it\u0027s introduced for ETSI NFV. Why don\u0027t you say simply as \"Add REST APIs for Change External VNF Connectivity\" instead?\n\nChanged description","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"344d2a8efbf4b975e7f4520e221db40771b3d403","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new RESTful APIs for Change External VNF Connectivity operation based on"},{"line_number":4,"context_line":"    ETSI NFV specifications."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"405f7809_ae656a04","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":12},"in_reply_to":"854a9216_05c9de01","updated":"2021-03-25 04:09:21.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"344d2a8efbf4b975e7f4520e221db40771b3d403","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new RESTful APIs for Change External VNF Connectivity operation based on"},{"line_number":4,"context_line":"    ETSI NFV specifications."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"984e706f_fc5b65ff","line":3,"in_reply_to":"b974b3b8_912c8a96","updated":"2021-03-25 04:09:21.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add new RESTful APIs for Change External VNF Connectivity operation based on"},{"line_number":4,"context_line":"    ETSI NFV specifications."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"854a9216_05c9de01","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":12},"in_reply_to":"cb6a319b_3dd1825a","updated":"2021-03-24 03:57:53.000000000","message":"\u003e No need to use `new` because we can understand that added things are new for the project without saying `new`.\n\nRemoved \u0027new\u0027","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"}],"tacker/tests/etc/samples/etsi/nfv/test_inst_terminate_vnf_with_vnflcmnoop/TOSCA-Metadata/TOSCA.meta":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Name: Scripts/vnflcm_noop.py"},{"line_number":10,"context_line":"Content-Type: text/x-python"},{"line_number":11,"context_line":"Algorithm: SHA-256"},{"line_number":12,"context_line":"Hash: 5fbd6a1a73143944911e346ecebe12dc9d995d26b2565679f73c22c223a2da39"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"322cd0a0_89bc66de","line":12,"updated":"2021-03-22 10:26:25.000000000","message":"Do you need this fix?","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Name: Scripts/vnflcm_noop.py"},{"line_number":10,"context_line":"Content-Type: text/x-python"},{"line_number":11,"context_line":"Algorithm: SHA-256"},{"line_number":12,"context_line":"Hash: 5fbd6a1a73143944911e346ecebe12dc9d995d26b2565679f73c22c223a2da39"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"eceeae2f_ffcd7dc8","line":12,"in_reply_to":"005f8b44_b4a085ad","updated":"2021-03-24 10:34:28.000000000","message":"\u003e This value appears to be updated every time the patchset is uploaded.\n\u003e I checked the suggested \u0027vnflcm_noop.py\u0027, but I couldn\u0027t understand why this value needed to be updated, can you please tell me why?\n\nWhen creating a VNF package with FT using vnflcm_noop.py, it is collated with the hash value described in the TOSCA.meta file. If there is a mismatch, FT will fail and it is necessary to update.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Name: Scripts/vnflcm_noop.py"},{"line_number":10,"context_line":"Content-Type: text/x-python"},{"line_number":11,"context_line":"Algorithm: SHA-256"},{"line_number":12,"context_line":"Hash: 5fbd6a1a73143944911e346ecebe12dc9d995d26b2565679f73c22c223a2da39"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"864d9356_0a2c8a4a","line":12,"in_reply_to":"322cd0a0_89bc66de","updated":"2021-03-24 03:57:53.000000000","message":"\u003e Do you need this fix?\n\nIf the below file updated, hash value needs to update too.\ntacker/tests/etc/samples/etsi/nfv/test_inst_terminate_vnf_with_vnflcmnoop/Scripts/vnflcm_noop.py","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f9657d9e2abcaa80a3d06a5b72304b298409f959","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Name: Scripts/vnflcm_noop.py"},{"line_number":10,"context_line":"Content-Type: text/x-python"},{"line_number":11,"context_line":"Algorithm: SHA-256"},{"line_number":12,"context_line":"Hash: 5fbd6a1a73143944911e346ecebe12dc9d995d26b2565679f73c22c223a2da39"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"005f8b44_b4a085ad","line":12,"in_reply_to":"864d9356_0a2c8a4a","updated":"2021-03-24 05:59:30.000000000","message":"This value appears to be updated every time the patchset is uploaded.\nI checked the suggested \u0027vnflcm_noop.py\u0027, but I couldn\u0027t understand why this value needed to be updated, can you please tell me why?","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Name: Scripts/vnflcm_noop.py"},{"line_number":10,"context_line":"Content-Type: text/x-python"},{"line_number":11,"context_line":"Algorithm: SHA-256"},{"line_number":12,"context_line":"Hash: 5fbd6a1a73143944911e346ecebe12dc9d995d26b2565679f73c22c223a2da39"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"7a711146_afc47613","line":12,"in_reply_to":"eceeae2f_ffcd7dc8","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"}],"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":1695,"context_line":"                        res_name \u003d list()"},{"line_number":1696,"context_line":"                    res_name.append(extcps[\u0027cpdId\u0027])"},{"line_number":1697,"context_line":"                    break"},{"line_number":1698,"context_line":"        self.assertTrue(res_name)"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"},{"line_number":1701,"context_line":"        stack_id \u003d stack.id"}],"source_content_type":"text/x-python","patch_set":8,"id":"0e42abac_af3e346f","line":1698,"updated":"2021-03-23 02:05:01.000000000","message":"Assertion should not be done in such a util function, but `test_...` or `assert_...` instead. Could you consider to check it separately?","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":1695,"context_line":"                        res_name \u003d list()"},{"line_number":1696,"context_line":"                    res_name.append(extcps[\u0027cpdId\u0027])"},{"line_number":1697,"context_line":"                    break"},{"line_number":1698,"context_line":"        self.assertTrue(res_name)"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"},{"line_number":1701,"context_line":"        stack_id \u003d stack.id"}],"source_content_type":"text/x-python","patch_set":8,"id":"ee414318_1ad536f8","line":1698,"in_reply_to":"0e42abac_af3e346f","updated":"2021-03-24 10:34:28.000000000","message":"\u003e Assertion should not be done in such a util function, but `test_...` or `assert_...` instead. Could you consider to check it separately?\n\nRemoved assertion in the util function.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"360204d2e7d90d10c7f265c6d8d3af0490aaecf4","unresolved":false,"context_lines":[{"line_number":1695,"context_line":"                        res_name \u003d list()"},{"line_number":1696,"context_line":"                    res_name.append(extcps[\u0027cpdId\u0027])"},{"line_number":1697,"context_line":"                    break"},{"line_number":1698,"context_line":"        self.assertTrue(res_name)"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":"        stack \u003d self._get_heat_stack(vnf_instance_id)"},{"line_number":1701,"context_line":"        stack_id \u003d stack.id"}],"source_content_type":"text/x-python","patch_set":8,"id":"ace12af9_6795ce07","line":1698,"in_reply_to":"ee414318_1ad536f8","updated":"2021-03-25 15:16:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":1719,"context_line":"                          encodeutils.exception_to_unicode(exp)})"},{"line_number":1720,"context_line":"                raise exceptions.VnfChangeExtConnFailed(id\u003dvnf_instance.id,"},{"line_number":1721,"context_line":"                    error\u003dencodeutils.exception_to_unicode(exp))"},{"line_number":1722,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 4"},{"line_number":1723,"context_line":"        try:"},{"line_number":1724,"context_line":"            self._vnf_manager.invoke("},{"line_number":1725,"context_line":"                vim_connection_info.vim_type, \u0027change_ext_conn_vnf_wait\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"528d789d_18967ec9","line":1722,"updated":"2021-03-22 10:26:25.000000000","message":"https://review.opendev.org/c/openstack/tacker/+/778948/8/tacker/objects/fields.py\nI think you should use the ErrorPoint in the above patch instead of the magic number.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":1719,"context_line":"                          encodeutils.exception_to_unicode(exp)})"},{"line_number":1720,"context_line":"                raise exceptions.VnfChangeExtConnFailed(id\u003dvnf_instance.id,"},{"line_number":1721,"context_line":"                    error\u003dencodeutils.exception_to_unicode(exp))"},{"line_number":1722,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 4"},{"line_number":1723,"context_line":"        try:"},{"line_number":1724,"context_line":"            self._vnf_manager.invoke("},{"line_number":1725,"context_line":"                vim_connection_info.vim_type, \u0027change_ext_conn_vnf_wait\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffecd67f_531b9f4d","line":1722,"in_reply_to":"528d789d_18967ec9","updated":"2021-03-24 03:57:53.000000000","message":"\u003e https://review.opendev.org/c/openstack/tacker/+/778948/8/tacker/objects/fields.py\n\u003e I think you should use the ErrorPoint in the above patch instead of the magic number.\n\nReplaced magic numbers to ErrorPoint constant.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fcf8b7915bb85c196948ea56c5c261681ca93f01","unresolved":false,"context_lines":[{"line_number":1719,"context_line":"                          encodeutils.exception_to_unicode(exp)})"},{"line_number":1720,"context_line":"                raise exceptions.VnfChangeExtConnFailed(id\u003dvnf_instance.id,"},{"line_number":1721,"context_line":"                    error\u003dencodeutils.exception_to_unicode(exp))"},{"line_number":1722,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 4"},{"line_number":1723,"context_line":"        try:"},{"line_number":1724,"context_line":"            self._vnf_manager.invoke("},{"line_number":1725,"context_line":"                vim_connection_info.vim_type, \u0027change_ext_conn_vnf_wait\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"57f5a0f4_1ba03a73","line":1722,"in_reply_to":"ffecd67f_531b9f4d","updated":"2021-03-24 04:59:39.000000000","message":"I\u0027ve confirmed.","commit_id":"e138a376eeecb155a8f984e285fcebf4416bc154"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":1772,"context_line":"            self._change_ext_conn_vnf(context, vnf_instance, vnf_dict,"},{"line_number":1773,"context_line":"                vim_connection_info, change_ext_conn_req)"},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 5"},{"line_number":1776,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 6"},{"line_number":1777,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d 6:"},{"line_number":1778,"context_line":"            self._mgmt_manager.invoke("}],"source_content_type":"text/x-python","patch_set":8,"id":"17f45290_73e778d8","line":1775,"updated":"2021-03-22 10:26:25.000000000","message":"If the process corresponding to vnf_dict[\u0027current_error_point\u0027] \u003d 5 does not exist, describe it in the comment and delete this process.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":1772,"context_line":"            self._change_ext_conn_vnf(context, vnf_instance, vnf_dict,"},{"line_number":1773,"context_line":"                vim_connection_info, change_ext_conn_req)"},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 5"},{"line_number":1776,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 6"},{"line_number":1777,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d 6:"},{"line_number":1778,"context_line":"            self._mgmt_manager.invoke("}],"source_content_type":"text/x-python","patch_set":8,"id":"b41f5bae_f16617bd","line":1775,"in_reply_to":"17f45290_73e778d8","updated":"2021-03-24 03:57:53.000000000","message":"\u003e If the process corresponding to vnf_dict[\u0027current_error_point\u0027] \u003d 5 does not exist, describe it in the comment and delete this process.\n\nIt is deleted. Added comment.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fcf8b7915bb85c196948ea56c5c261681ca93f01","unresolved":false,"context_lines":[{"line_number":1772,"context_line":"            self._change_ext_conn_vnf(context, vnf_instance, vnf_dict,"},{"line_number":1773,"context_line":"                vim_connection_info, change_ext_conn_req)"},{"line_number":1774,"context_line":""},{"line_number":1775,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 5"},{"line_number":1776,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d 6"},{"line_number":1777,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d 6:"},{"line_number":1778,"context_line":"            self._mgmt_manager.invoke("}],"source_content_type":"text/x-python","patch_set":8,"id":"b19bb8d9_a92ad913","line":1775,"in_reply_to":"b41f5bae_f16617bd","updated":"2021-03-24 04:59:39.000000000","message":"I\u0027ve confirmed.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f9657d9e2abcaa80a3d06a5b72304b298409f959","unresolved":true,"context_lines":[{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d EP.VNF_CONFIG_START"},{"line_number":1794,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.VNF_CONFIG_START:"},{"line_number":1795,"context_line":"            # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":1796,"context_line":"            # as a parameter, however due to grant_request are not"},{"line_number":1797,"context_line":"            # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":1798,"context_line":"            # value to grant and grant_reqeust temporary."}],"source_content_type":"text/x-python","patch_set":10,"id":"16e32274_9dca69e8","line":1795,"range":{"start_line":1795,"start_character":19,"end_line":1795,"end_character":26},"updated":"2021-03-24 05:59:30.000000000","message":"It looks different from your name posting the patch, is it wrong?","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d EP.VNF_CONFIG_START"},{"line_number":1794,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.VNF_CONFIG_START:"},{"line_number":1795,"context_line":"            # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":1796,"context_line":"            # as a parameter, however due to grant_request are not"},{"line_number":1797,"context_line":"            # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":1798,"context_line":"            # value to grant and grant_reqeust temporary."}],"source_content_type":"text/x-python","patch_set":10,"id":"3332744e_b2fd7080","line":1795,"range":{"start_line":1795,"start_character":19,"end_line":1795,"end_character":26},"in_reply_to":"16e32274_9dca69e8","updated":"2021-03-24 10:34:28.000000000","message":"\u003e It looks different from your name posting the patch, is it wrong?\n\nFixed the name in TODO","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":1792,"context_line":""},{"line_number":1793,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d EP.VNF_CONFIG_START"},{"line_number":1794,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.VNF_CONFIG_START:"},{"line_number":1795,"context_line":"            # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":1796,"context_line":"            # as a parameter, however due to grant_request are not"},{"line_number":1797,"context_line":"            # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":1798,"context_line":"            # value to grant and grant_reqeust temporary."}],"source_content_type":"text/x-python","patch_set":10,"id":"872b5428_71779a06","line":1795,"range":{"start_line":1795,"start_character":19,"end_line":1795,"end_character":26},"in_reply_to":"3332744e_b2fd7080","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f9657d9e2abcaa80a3d06a5b72304b298409f959","unresolved":true,"context_lines":[{"line_number":1822,"context_line":"        # EP.INTERNAL_PROCESSING, it transitions to EP.VNF_CONFIG_END."},{"line_number":1823,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d EP.VNF_CONFIG_END"},{"line_number":1824,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.VNF_CONFIG_END:"},{"line_number":1825,"context_line":"            # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":1826,"context_line":"            # as a parameter, however due to grant_request are not"},{"line_number":1827,"context_line":"            # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":1828,"context_line":"            # value to grant and grant_reqeust temporary."}],"source_content_type":"text/x-python","patch_set":10,"id":"9f458f58_34e5e962","line":1825,"range":{"start_line":1825,"start_character":19,"end_line":1825,"end_character":26},"updated":"2021-03-24 05:59:30.000000000","message":"ditto","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":1822,"context_line":"        # EP.INTERNAL_PROCESSING, it transitions to EP.VNF_CONFIG_END."},{"line_number":1823,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d EP.VNF_CONFIG_END"},{"line_number":1824,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.VNF_CONFIG_END:"},{"line_number":1825,"context_line":"            # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":1826,"context_line":"            # as a parameter, however due to grant_request are not"},{"line_number":1827,"context_line":"            # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":1828,"context_line":"            # value to grant and grant_reqeust temporary."}],"source_content_type":"text/x-python","patch_set":10,"id":"d491bd81_53adb892","line":1825,"range":{"start_line":1825,"start_character":19,"end_line":1825,"end_character":26},"in_reply_to":"8be7910c_5a6990e3","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":1822,"context_line":"        # EP.INTERNAL_PROCESSING, it transitions to EP.VNF_CONFIG_END."},{"line_number":1823,"context_line":"        vnf_dict[\u0027current_error_point\u0027] \u003d EP.VNF_CONFIG_END"},{"line_number":1824,"context_line":"        if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.VNF_CONFIG_END:"},{"line_number":1825,"context_line":"            # TODO(LiangLu): grant_request here is planned to pass"},{"line_number":1826,"context_line":"            # as a parameter, however due to grant_request are not"},{"line_number":1827,"context_line":"            # passed from conductor to vnflcm_driver, thus we put Null"},{"line_number":1828,"context_line":"            # value to grant and grant_reqeust temporary."}],"source_content_type":"text/x-python","patch_set":10,"id":"8be7910c_5a6990e3","line":1825,"range":{"start_line":1825,"start_character":19,"end_line":1825,"end_character":26},"in_reply_to":"9f458f58_34e5e962","updated":"2021-03-24 10:34:28.000000000","message":"\u003e ditto\n\nFixed the name in TODO","commit_id":"330f538b3d414c95f2eb616e1d09b1b89d2e6f04"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":2062,"context_line":"                try:"},{"line_number":2063,"context_line":"                    ip_addr \u003d ext_cp.cp_config[0].cp_protocol_data[0].\\"},{"line_number":2064,"context_line":"                        ip_over_ethernet.ip_addresses[0]"},{"line_number":2065,"context_line":"                except IndexError:"},{"line_number":2066,"context_line":"                    continue"},{"line_number":2067,"context_line":""},{"line_number":2068,"context_line":"                fixed_ips \u003d dict()"},{"line_number":2069,"context_line":"                updated_fixed_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"da780296_47a6cc65","line":2066,"range":{"start_line":2065,"start_character":0,"end_line":2066,"end_character":28},"updated":"2021-03-23 02:05:01.000000000","message":"It looks strange without understanding the reason. Could you add a comment why it can be ignored?","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"344d2a8efbf4b975e7f4520e221db40771b3d403","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"                try:"},{"line_number":2063,"context_line":"                    ip_addr \u003d ext_cp.cp_config[0].cp_protocol_data[0].\\"},{"line_number":2064,"context_line":"                        ip_over_ethernet.ip_addresses[0]"},{"line_number":2065,"context_line":"                except IndexError:"},{"line_number":2066,"context_line":"                    continue"},{"line_number":2067,"context_line":""},{"line_number":2068,"context_line":"                fixed_ips \u003d dict()"},{"line_number":2069,"context_line":"                updated_fixed_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"9e006bfb_2e299d32","line":2066,"range":{"start_line":2065,"start_character":0,"end_line":2066,"end_character":28},"in_reply_to":"1646322c_def925c7","updated":"2021-03-25 04:09:21.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":2062,"context_line":"                try:"},{"line_number":2063,"context_line":"                    ip_addr \u003d ext_cp.cp_config[0].cp_protocol_data[0].\\"},{"line_number":2064,"context_line":"                        ip_over_ethernet.ip_addresses[0]"},{"line_number":2065,"context_line":"                except IndexError:"},{"line_number":2066,"context_line":"                    continue"},{"line_number":2067,"context_line":""},{"line_number":2068,"context_line":"                fixed_ips \u003d dict()"},{"line_number":2069,"context_line":"                updated_fixed_ips \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"1646322c_def925c7","line":2066,"range":{"start_line":2065,"start_character":0,"end_line":2066,"end_character":28},"in_reply_to":"da780296_47a6cc65","updated":"2021-03-24 03:57:53.000000000","message":"\u003e It looks strange without understanding the reason. Could you add a comment why it can be ignored?\n\nAdded comment","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"1ac3fedc6dd821e71814b92f5ae1c96d676ad65c","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                    region_name\u003dregion_name)"},{"line_number":2107,"context_line":"        return stack"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @log.log"},{"line_number":2110,"context_line":"    def post_change_ext_conn_vnf(self, context, vnf_instance,"},{"line_number":2111,"context_line":"            vim_connection_info):"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2114,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2117,"context_line":"            region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2118,"context_line":"        stack_resources \u003d self._get_stack_resources("},{"line_number":2119,"context_line":"            inst_vnf_info.instance_id, heatclient)"},{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"        self._update_vnfc_resources(vnf_instance, stack_resources,"},{"line_number":2122,"context_line":"                                    vim_connection_info)"},{"line_number":2123,"context_line":"        self._update_vnfc_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"6cb80960_f82c127e","line":2123,"range":{"start_line":2109,"start_character":4,"end_line":2123,"end_character":44},"updated":"2021-03-22 10:26:25.000000000","message":"I think it\u0027s exactly the same process as \u0027post_vnf_instantiation\u0027.\nIs it possible to standardize the processing by sub-functioning the processing content of \u0027post_vnf_instantiation\u0027 and calling that sub-function from this function as well?","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"9bca077263207925304b3d5c3f4530fa9df7c579","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                    region_name\u003dregion_name)"},{"line_number":2107,"context_line":"        return stack"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @log.log"},{"line_number":2110,"context_line":"    def post_change_ext_conn_vnf(self, context, vnf_instance,"},{"line_number":2111,"context_line":"            vim_connection_info):"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2114,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2117,"context_line":"            region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2118,"context_line":"        stack_resources \u003d self._get_stack_resources("},{"line_number":2119,"context_line":"            inst_vnf_info.instance_id, heatclient)"},{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"        self._update_vnfc_resources(vnf_instance, stack_resources,"},{"line_number":2122,"context_line":"                                    vim_connection_info)"},{"line_number":2123,"context_line":"        self._update_vnfc_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ba6b91b_638d0b2b","line":2123,"range":{"start_line":2109,"start_character":4,"end_line":2123,"end_character":44},"in_reply_to":"043dd047_abb071c8","updated":"2021-03-24 10:34:28.000000000","message":"\u003e I don\u0027t think the intention of the comment has been conveyed to you, so I will supplement it.\n\u003e By doing the following, you can avoid defining the exact same process in multiple places.\n\u003e ---\n\u003e     def _update_vnfc_resources_and_info(self, context, vnf_instance, vim_connection_info):\n\u003e \n\u003e         inst_vnf_info \u003d vnf_instance.instantiated_vnf_info\n\u003e         access_info \u003d vim_connection_info.access_info\n\u003e \n\u003e         heatclient \u003d hc.HeatClient(access_info,\n\u003e             region_name\u003daccess_info.get(\u0027region\u0027))\n\u003e         stack_resources \u003d self._get_stack_resources(\n\u003e             inst_vnf_info.instance_id, heatclient)\n\u003e \n\u003e         self._update_vnfc_resources(vnf_instance, stack_resources,\n\u003e                                     vim_connection_info)\n\u003e         self._update_vnfc_info(vnf_instance)\n\u003e \n\u003e     def post_vnf_instantiation(self, context, vnf_instance, vim_connection_info):\n\u003e         self._update_vnfc_resources_and_info(context, vnf_instance, vim_connection_info)\n\u003e \n\u003e     def post_change_ext_conn_vnf(self, context, vnf_instance, vim_connection_info):\n\u003e         self._update_vnfc_resources_and_info(context, vnf_instance, vim_connection_info)\n\nI created a subfunction that performs common processing, and modified it so that it is called from each of post_vnf_instantiation and post_change_ext_conn_vnf.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"46bba9ad78b66143015f194453489f21bb3925ec","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                    region_name\u003dregion_name)"},{"line_number":2107,"context_line":"        return stack"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @log.log"},{"line_number":2110,"context_line":"    def post_change_ext_conn_vnf(self, context, vnf_instance,"},{"line_number":2111,"context_line":"            vim_connection_info):"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2114,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2117,"context_line":"            region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2118,"context_line":"        stack_resources \u003d self._get_stack_resources("},{"line_number":2119,"context_line":"            inst_vnf_info.instance_id, heatclient)"},{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"        self._update_vnfc_resources(vnf_instance, stack_resources,"},{"line_number":2122,"context_line":"                                    vim_connection_info)"},{"line_number":2123,"context_line":"        self._update_vnfc_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"968fabb6_102b4700","line":2123,"range":{"start_line":2109,"start_character":4,"end_line":2123,"end_character":44},"in_reply_to":"6cb80960_f82c127e","updated":"2021-03-23 02:05:01.000000000","message":"I think so too","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"c1d9a0f794db2113088e626cec2a14a80b71fb5f","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                    region_name\u003dregion_name)"},{"line_number":2107,"context_line":"        return stack"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @log.log"},{"line_number":2110,"context_line":"    def post_change_ext_conn_vnf(self, context, vnf_instance,"},{"line_number":2111,"context_line":"            vim_connection_info):"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2114,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2117,"context_line":"            region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2118,"context_line":"        stack_resources \u003d self._get_stack_resources("},{"line_number":2119,"context_line":"            inst_vnf_info.instance_id, heatclient)"},{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"        self._update_vnfc_resources(vnf_instance, stack_resources,"},{"line_number":2122,"context_line":"                                    vim_connection_info)"},{"line_number":2123,"context_line":"        self._update_vnfc_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b4ddee9e_c3059954","line":2123,"range":{"start_line":2109,"start_character":4,"end_line":2123,"end_character":44},"in_reply_to":"968fabb6_102b4700","updated":"2021-03-24 03:57:53.000000000","message":"\u003e I think so too\n\nThese methods already use only common sub-functions,  I think that any further sub-functioning is excessive.","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a62219772f497695ae7375a88281b1bf539a9c76","unresolved":false,"context_lines":[{"line_number":2106,"context_line":"                    region_name\u003dregion_name)"},{"line_number":2107,"context_line":"        return stack"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @log.log"},{"line_number":2110,"context_line":"    def post_change_ext_conn_vnf(self, context, vnf_instance,"},{"line_number":2111,"context_line":"            vim_connection_info):"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2114,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2117,"context_line":"            region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2118,"context_line":"        stack_resources \u003d self._get_stack_resources("},{"line_number":2119,"context_line":"            inst_vnf_info.instance_id, heatclient)"},{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"        self._update_vnfc_resources(vnf_instance, stack_resources,"},{"line_number":2122,"context_line":"                                    vim_connection_info)"},{"line_number":2123,"context_line":"        self._update_vnfc_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9c2f962a_32cd8f50","line":2123,"range":{"start_line":2109,"start_character":4,"end_line":2123,"end_character":44},"in_reply_to":"9ba6b91b_638d0b2b","updated":"2021-03-25 04:58:55.000000000","message":"Done","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"fcf8b7915bb85c196948ea56c5c261681ca93f01","unresolved":true,"context_lines":[{"line_number":2106,"context_line":"                    region_name\u003dregion_name)"},{"line_number":2107,"context_line":"        return stack"},{"line_number":2108,"context_line":""},{"line_number":2109,"context_line":"    @log.log"},{"line_number":2110,"context_line":"    def post_change_ext_conn_vnf(self, context, vnf_instance,"},{"line_number":2111,"context_line":"            vim_connection_info):"},{"line_number":2112,"context_line":""},{"line_number":2113,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"},{"line_number":2114,"context_line":"        access_info \u003d vim_connection_info.access_info"},{"line_number":2115,"context_line":""},{"line_number":2116,"context_line":"        heatclient \u003d hc.HeatClient(access_info,"},{"line_number":2117,"context_line":"            region_name\u003daccess_info.get(\u0027region\u0027))"},{"line_number":2118,"context_line":"        stack_resources \u003d self._get_stack_resources("},{"line_number":2119,"context_line":"            inst_vnf_info.instance_id, heatclient)"},{"line_number":2120,"context_line":""},{"line_number":2121,"context_line":"        self._update_vnfc_resources(vnf_instance, stack_resources,"},{"line_number":2122,"context_line":"                                    vim_connection_info)"},{"line_number":2123,"context_line":"        self._update_vnfc_info(vnf_instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"043dd047_abb071c8","line":2123,"range":{"start_line":2109,"start_character":4,"end_line":2123,"end_character":44},"in_reply_to":"b4ddee9e_c3059954","updated":"2021-03-24 04:59:39.000000000","message":"I don\u0027t think the intention of the comment has been conveyed to you, so I will supplement it.\nBy doing the following, you can avoid defining the exact same process in multiple places.\n---\n    def _update_vnfc_resources_and_info(self, context, vnf_instance, vim_connection_info):\n\n        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info\n        access_info \u003d vim_connection_info.access_info\n\n        heatclient \u003d hc.HeatClient(access_info,\n            region_name\u003daccess_info.get(\u0027region\u0027))\n        stack_resources \u003d self._get_stack_resources(\n            inst_vnf_info.instance_id, heatclient)\n\n        self._update_vnfc_resources(vnf_instance, stack_resources,\n                                    vim_connection_info)\n        self._update_vnfc_info(vnf_instance)\n\n    def post_vnf_instantiation(self, context, vnf_instance, vim_connection_info):\n        self._update_vnfc_resources_and_info(context, vnf_instance, vim_connection_info)\n\n    def post_change_ext_conn_vnf(self, context, vnf_instance, vim_connection_info):\n        self._update_vnfc_resources_and_info(context, vnf_instance, vim_connection_info)","commit_id":"635c5124dd18d9e125902dd3679a1d363d836bbd"}]}