)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7105d1e6ef2f0eb6b41e487765e514d7944ad047","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a47ec25e_53ec7318","updated":"2021-10-11 06:21:39.000000000","message":"recheck","commit_id":"3446f2a1f0519bd53df36d31a9d3a107b09b1ad8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d1201fdad525226769e6c01f80be0fe388b4cce1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"aa5f5647_1f1047e7","updated":"2021-11-02 10:48:28.000000000","message":"recheck","commit_id":"338cdbe015faab9627aab432e97b5ccac44a5039"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"17e95fa8a8726748ff3c549fd505823bb641788d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"58f37bba_dd602246","updated":"2021-11-05 04:46:45.000000000","message":"recheck","commit_id":"256ec8fb17d83c28c36cf09608ec738561a335c1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"70ad538160a9398d7a168d1157367fa22351b587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"8f357585_0a9e746f","updated":"2021-11-08 02:23:20.000000000","message":"recheck","commit_id":"256ec8fb17d83c28c36cf09608ec738561a335c1"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"48258c60a93d10d1e52bffe27060078c0a580e3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"7e82f425_40f76614","updated":"2021-11-09 03:08:12.000000000","message":"recheck","commit_id":"7d997f2681f451ca626eb5b83b0fef9a7c930043"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"e1fb7f67aad202cfcabe8d4d0cf9bcf64ac95920","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"ef1b5b68_b491f125","updated":"2021-11-10 05:09:53.000000000","message":"recheck","commit_id":"7d997f2681f451ca626eb5b83b0fef9a7c930043"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a60641b3e0c84f137e4ddbf2201dfdc1da81fa3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"536f5ad3_0db49fb2","updated":"2021-11-17 07:37:17.000000000","message":"recheck","commit_id":"680cb82b7e30b3933e49a028c4456e742add523c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"34e432dcbd32ee256bde8d3b3d1df5fa1fc345ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"135cf99e_ed70671c","updated":"2021-12-13 09:53:00.000000000","message":"recheck","commit_id":"bde96857602987a91f0020319178ea19e178096a"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"d5d20ed23ede726075f556c0ec3d8f927b58cedb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"23dd7b20_450d332c","updated":"2022-01-03 23:49:25.000000000","message":"recheck","commit_id":"f6ad049e71527b4592dd18b14784aded6148aff8"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"49b5928fa7084a58d1552fd5c6b5c5ab4fb30c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"be421b4b_65b54969","updated":"2022-01-21 08:29:42.000000000","message":"recheck","commit_id":"264086c0d2b29247356dab1bfbf1c9308b5cf014"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a85926f42f7bf9f17a2c74eb18eb0e8e65d9969b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"67c0325a_1f99714d","updated":"2022-01-26 11:16:33.000000000","message":"recheck","commit_id":"c2291bd6203ff2f994c67cb1cd4a9901aec047e7"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0f27e5efa63a76132e6ec6db659f9740aae8403e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"3220782b_68824dbb","updated":"2022-02-03 02:05:10.000000000","message":"recheck","commit_id":"9c34239d18c30039dc3961d1275fd47c80209708"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"1592516ad4a35defea62609b00f74592ff0cc70b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":65,"id":"31a2bd85_be73d760","updated":"2022-02-04 09:42:23.000000000","message":"recheck","commit_id":"e0a01599f26c10420cb6e0e6092f59167faccd45"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":71,"id":"6d7bad80_0dc1f5b1","updated":"2022-03-01 14:42:31.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":72,"id":"82f064db_55ac1886","updated":"2022-03-04 03:25:30.000000000","message":"We have updated the patch and answered the comments.\nPlease confirm.","commit_id":"00ba287540487d04ef306a4256b1dca9416cd9af"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":73,"id":"1e55e89e_a045310a","updated":"2022-03-04 14:53:47.000000000","message":"Thanks for your rework, I have a tiny comment, please kindly find it.","commit_id":"f25d913a4a1603207f86379ece4014db23852d35"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5243f96274c3280b7c2bac092124e00627569eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":73,"id":"116586d1_e2e4ae8a","in_reply_to":"1e55e89e_a045310a","updated":"2022-03-07 00:47:39.000000000","message":"\u003e Thanks for your rework, I have a tiny comment, please kindly find it.\n\n\"Vrtual\" was actually done on purpose since there are some images not removed in DB. We were avoiding same name images (Error: Duplicate Image name occur sometimes).\nAnyway, we modified to the correct spelling. We will check the results if the same error (Duplicate Image name) occurs.","commit_id":"f25d913a4a1603207f86379ece4014db23852d35"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5243f96274c3280b7c2bac092124e00627569eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":74,"id":"bb69d992_a77714ae","updated":"2022-03-07 00:47:39.000000000","message":"Thank you for the comments. We have updated the patch. \n","commit_id":"1daa7f33d7cee5886a053ed05df290e34613d5c2"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"93ffa27c9bd847e5dc453e889b0fe8c5653993e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":74,"id":"16e13f21_4126aceb","updated":"2022-03-09 05:47:07.000000000","message":"recheck","commit_id":"1daa7f33d7cee5886a053ed05df290e34613d5c2"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d7e1ebbc68af7884166c13489d89f3e494485c61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":76,"id":"586a28b9_3718d386","updated":"2022-03-14 10:28:38.000000000","message":"Please find my comments.\n\nBy the way, could I confirm terminologies in this patch are defined in ETSI robot framework, for example \"compliance\" or \"rootbase\"? Or did we made any agreement for the terminologies? Sorry for my poor memory 😞","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a4cdd71b9239d2ccaefc0d7aae22abe59420e99c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":77,"id":"68985793_aab4e4f7","updated":"2022-03-15 11:42:01.000000000","message":"Thank you for the comments. Please see my answers.","commit_id":"3eba8a4feb97711af581b645fc93e49d8552d65d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"33ce155cee72a49076330780f4982ca0a6030cd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":78,"id":"1bcde439_9d641a47","updated":"2022-03-16 10:30:36.000000000","message":"Thank you for your comments. Please refer to the latest patch and my answers to your comments.","commit_id":"1c050ef3ff124c9b3097d44e7b3325334871b6fc"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5da31fa4658998e63aee96b573d1bbe2ac7ee4de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":79,"id":"a4b0caf2_025ba9d3","updated":"2022-03-18 08:26:00.000000000","message":"Thank you for the comment. Please refer to my latest response.","commit_id":"e71fd7667cfc1ca93f40ad3cfeadc5026d6fdf7d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"88d67fa24d5c3408a7062c30ed644e992ca8339d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":79,"id":"3f2d2d63_11e07fa1","updated":"2022-03-18 09:09:51.000000000","message":"Thanks for your rework, LGTM.","commit_id":"e71fd7667cfc1ca93f40ad3cfeadc5026d6fdf7d"}],"releasenotes/notes/apply-robot-framework-for-testing-d04256887fd9bee7.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"98d9efb426e0425fa91669a6438850055403d083","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    test codes to test tacker for ETSI NFV compliance in a Black Box testing"},{"line_number":9,"context_line":"    level. This is an additional quality test measure to ensure that the added"},{"line_number":10,"context_line":"    tacker features comply to the ETSI NFV standards."},{"line_number":11,"context_line":"issues:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Currently, some of the tests are failing due to bugs (1) Tacker Bug and "},{"line_number":14,"context_line":"    (2) Issues in the ETSI NFV-TST API test codes."}],"source_content_type":"text/x-yaml","patch_set":77,"id":"9503c131_58b24f28","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2022-03-15 12:29:19.000000000","message":"For release note, features and other items (issue in this case) appear separately in docs.\n\nfor example (xena release\u0027s release note):\nhttps://docs.openstack.org/releasenotes/tacker/xena.html\n\nCould you clearly state to that this is an issue for ETSI NFV compliant automated testing?","commit_id":"3eba8a4feb97711af581b645fc93e49d8552d65d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"88d67fa24d5c3408a7062c30ed644e992ca8339d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    test codes to test tacker for ETSI NFV compliance in a Black Box testing"},{"line_number":9,"context_line":"    level. This is an additional quality test measure to ensure that the added"},{"line_number":10,"context_line":"    tacker features comply to the ETSI NFV standards."},{"line_number":11,"context_line":"issues:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Currently, some of the tests are failing due to bugs (1) Tacker Bug and "},{"line_number":14,"context_line":"    (2) Issues in the ETSI NFV-TST API test codes."}],"source_content_type":"text/x-yaml","patch_set":77,"id":"f7cfedce_ab23d957","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"in_reply_to":"8300f4df_2bef5fd3","updated":"2022-03-18 09:09:51.000000000","message":"Ack","commit_id":"3eba8a4feb97711af581b645fc93e49d8552d65d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"33ce155cee72a49076330780f4982ca0a6030cd0","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    test codes to test tacker for ETSI NFV compliance in a Black Box testing"},{"line_number":9,"context_line":"    level. This is an additional quality test measure to ensure that the added"},{"line_number":10,"context_line":"    tacker features comply to the ETSI NFV standards."},{"line_number":11,"context_line":"issues:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Currently, some of the tests are failing due to bugs (1) Tacker Bug and "},{"line_number":14,"context_line":"    (2) Issues in the ETSI NFV-TST API test codes."}],"source_content_type":"text/x-yaml","patch_set":77,"id":"8300f4df_2bef5fd3","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"in_reply_to":"9503c131_58b24f28","updated":"2022-03-16 10:30:36.000000000","message":"\u003e For release note, features and other items (issue in this case) appear separately in docs.\n\u003e \n\u003e for example (xena release\u0027s release note):\n\u003e https://docs.openstack.org/releasenotes/tacker/xena.html\n\u003e \n\u003e Could you clearly state to that this is an issue for ETSI NFV compliant automated testing?\n\nFixed the statement so that it is clearly stated that the issue is for ETSI NFV compliant automated testing.","commit_id":"3eba8a4feb97711af581b645fc93e49d8552d65d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"98d9efb426e0425fa91669a6438850055403d083","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    bug is fixed."},{"line_number":19,"context_line":"    (2) Issues in the ETSI NFV-TST API test codes such as schema and mock"},{"line_number":20,"context_line":"    server location issues also caused some tests to fail. Tests will pass once"},{"line_number":21,"context_line":"    the issues are resolved. "},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Due to these existing failed items, this test is currently non-voting."}],"source_content_type":"text/x-yaml","patch_set":77,"id":"252d2dfd_26c833d4","line":21,"range":{"start_line":21,"start_character":28,"end_line":21,"end_character":29},"updated":"2022-03-15 12:29:19.000000000","message":"unnecessary space character.","commit_id":"3eba8a4feb97711af581b645fc93e49d8552d65d"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"33ce155cee72a49076330780f4982ca0a6030cd0","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    bug is fixed."},{"line_number":19,"context_line":"    (2) Issues in the ETSI NFV-TST API test codes such as schema and mock"},{"line_number":20,"context_line":"    server location issues also caused some tests to fail. Tests will pass once"},{"line_number":21,"context_line":"    the issues are resolved. "},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Due to these existing failed items, this test is currently non-voting."}],"source_content_type":"text/x-yaml","patch_set":77,"id":"be7b829e_266484b8","line":21,"range":{"start_line":21,"start_character":28,"end_line":21,"end_character":29},"in_reply_to":"252d2dfd_26c833d4","updated":"2022-03-16 10:30:36.000000000","message":"\u003e unnecessary space character.\n\nit is removed.","commit_id":"3eba8a4feb97711af581b645fc93e49d8552d65d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"88d67fa24d5c3408a7062c30ed644e992ca8339d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    bug is fixed."},{"line_number":19,"context_line":"    (2) Issues in the ETSI NFV-TST API test codes such as schema and mock"},{"line_number":20,"context_line":"    server location issues also caused some tests to fail. Tests will pass once"},{"line_number":21,"context_line":"    the issues are resolved. "},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    Due to these existing failed items, this test is currently non-voting."}],"source_content_type":"text/x-yaml","patch_set":77,"id":"eb038440_b6c483c0","line":21,"range":{"start_line":21,"start_character":28,"end_line":21,"end_character":29},"in_reply_to":"be7b829e_266484b8","updated":"2022-03-18 09:09:51.000000000","message":"Ack","commit_id":"3eba8a4feb97711af581b645fc93e49d8552d65d"}],"tacker/tests/compliance/base.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"34483b57_6de119b5","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-01 14:42:31.000000000","message":"How about changing it to this year\u0027s?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"58ff36f2_c8ee35e4","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"34483b57_6de119b5","updated":"2022-03-04 03:25:30.000000000","message":"\u003e How about changing it to this year\u0027s?\n\nIt is changed to this year.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"57b995ee_0ef6158f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"58ff36f2_c8ee35e4","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d7e1ebbc68af7884166c13489d89f3e494485c61","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import robot"},{"line_number":20,"context_line":"import tacker.tests.functional.sol.vnflcm.test_vnf_instance as vnflcmtest"},{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":"import xml.etree.ElementTree as et"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"from oslo_utils import uuidutils"},{"line_number":26,"context_line":"from tacker.tests.functional import base"},{"line_number":27,"context_line":"from urllib.parse import urlparse"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"VNFPKG_PATH \u003d \u0027/vnfpkgm/v1/vnf_packages/%s\u0027"},{"line_number":30,"context_line":"VNFINSS_PATH \u003d \u0027/vnflcm/v1/vnf_instances\u0027"}],"source_content_type":"text/x-python","patch_set":76,"id":"6510e07c_9571bdf7","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":33},"updated":"2022-03-14 10:28:38.000000000","message":"There are many disordered importing here and other files.","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d441544590e3336ccd03c592a095d53390fa0d76","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import robot"},{"line_number":20,"context_line":"import tacker.tests.functional.sol.vnflcm.test_vnf_instance as vnflcmtest"},{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":"import xml.etree.ElementTree as et"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"from oslo_utils import uuidutils"},{"line_number":26,"context_line":"from tacker.tests.functional import base"},{"line_number":27,"context_line":"from urllib.parse import urlparse"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"VNFPKG_PATH \u003d \u0027/vnfpkgm/v1/vnf_packages/%s\u0027"},{"line_number":30,"context_line":"VNFINSS_PATH \u003d \u0027/vnflcm/v1/vnf_instances\u0027"}],"source_content_type":"text/x-python","patch_set":76,"id":"f2745793_00a121d7","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":33},"in_reply_to":"3fe75653_db773f3c","updated":"2022-03-15 15:12:23.000000000","message":"No. I commented about the importing guidelines.\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"2c5fdcce396c49803fb3a12f465d3032c52fe657","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import robot"},{"line_number":20,"context_line":"import tacker.tests.functional.sol.vnflcm.test_vnf_instance as vnflcmtest"},{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":"import xml.etree.ElementTree as et"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"from oslo_utils import uuidutils"},{"line_number":26,"context_line":"from tacker.tests.functional import base"},{"line_number":27,"context_line":"from urllib.parse import urlparse"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"VNFPKG_PATH \u003d \u0027/vnfpkgm/v1/vnf_packages/%s\u0027"},{"line_number":30,"context_line":"VNFINSS_PATH \u003d \u0027/vnflcm/v1/vnf_instances\u0027"}],"source_content_type":"text/x-python","patch_set":76,"id":"d92d6316_1e74df1f","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":33},"in_reply_to":"6510e07c_9571bdf7","updated":"2022-03-14 10:32:03.000000000","message":"Sorry, it\u0027s my mistake. Only in this file.","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a4cdd71b9239d2ccaefc0d7aae22abe59420e99c","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import robot"},{"line_number":20,"context_line":"import tacker.tests.functional.sol.vnflcm.test_vnf_instance as vnflcmtest"},{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":"import xml.etree.ElementTree as et"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"from oslo_utils import uuidutils"},{"line_number":26,"context_line":"from tacker.tests.functional import base"},{"line_number":27,"context_line":"from urllib.parse import urlparse"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"VNFPKG_PATH \u003d \u0027/vnfpkgm/v1/vnf_packages/%s\u0027"},{"line_number":30,"context_line":"VNFINSS_PATH \u003d \u0027/vnflcm/v1/vnf_instances\u0027"}],"source_content_type":"text/x-python","patch_set":76,"id":"3fe75653_db773f3c","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":33},"in_reply_to":"d92d6316_1e74df1f","updated":"2022-03-15 11:42:01.000000000","message":"\u003e Sorry, it\u0027s my mistake. Only in this file.\n\nI\u0027m sorry but we don\u0027t seem to understand what you mean. Currently, the order is correct based on the pep8 results. Is there a specific order you would want to have? Can you please specify it in your comment?","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"33ce155cee72a49076330780f4982ca0a6030cd0","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import robot"},{"line_number":20,"context_line":"import tacker.tests.functional.sol.vnflcm.test_vnf_instance as vnflcmtest"},{"line_number":21,"context_line":"import time"},{"line_number":22,"context_line":"import xml.etree.ElementTree as et"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"from oslo_utils import uuidutils"},{"line_number":26,"context_line":"from tacker.tests.functional import base"},{"line_number":27,"context_line":"from urllib.parse import urlparse"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"VNFPKG_PATH \u003d \u0027/vnfpkgm/v1/vnf_packages/%s\u0027"},{"line_number":30,"context_line":"VNFINSS_PATH \u003d \u0027/vnflcm/v1/vnf_instances\u0027"}],"source_content_type":"text/x-python","patch_set":76,"id":"092bf141_91f95b91","line":27,"range":{"start_line":16,"start_character":0,"end_line":27,"end_character":33},"in_reply_to":"f2745793_00a121d7","updated":"2022-03-16 10:30:36.000000000","message":"\u003e No. I commented about the importing guidelines.\n\u003e https://docs.openstack.org/hacking/latest/user/hacking.html#imports\n\nWe updated the order of imports based on our understanding of the guidelines.","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d7e1ebbc68af7884166c13489d89f3e494485c61","unresolved":true,"context_lines":[{"line_number":37,"context_line":"VNFINS_DEL_SUBSC_PATH \u003d \u0027/vnflcm/v1/subscriptions/%s\u0027"},{"line_number":38,"context_line":"VNFINS_SCALE_PATH \u003d \u0027/vnflcm/v1/vnf_instances/%s/scale\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"INSTANTIATION_BODY \u003d {"},{"line_number":41,"context_line":"    \u0027flavourId\u0027: \u0027simple\u0027,"},{"line_number":42,"context_line":"    \u0027extVirtualLinks\u0027: ["},{"line_number":43,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":76,"id":"a03ceded_789bcf10","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"updated":"2022-03-14 10:28:38.000000000","message":"I\u0027m not sure why it\u0027s defined as a const and used with `copy.deepcopy`, and not so for other siblings. I think it\u0027s simple to define them as functions which return the contents. What do you think?","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"d441544590e3336ccd03c592a095d53390fa0d76","unresolved":true,"context_lines":[{"line_number":37,"context_line":"VNFINS_DEL_SUBSC_PATH \u003d \u0027/vnflcm/v1/subscriptions/%s\u0027"},{"line_number":38,"context_line":"VNFINS_SCALE_PATH \u003d \u0027/vnflcm/v1/vnf_instances/%s/scale\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"INSTANTIATION_BODY \u003d {"},{"line_number":41,"context_line":"    \u0027flavourId\u0027: \u0027simple\u0027,"},{"line_number":42,"context_line":"    \u0027extVirtualLinks\u0027: ["},{"line_number":43,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":76,"id":"927a2abd_b97fbb2b","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"in_reply_to":"061a332b_43061a08","updated":"2022-03-15 15:12:23.000000000","message":"I understand you need to use deepcopy because you reuse this variable. However, you should define a capitalized name for constant in general. In addition, it can be happened to change the variable without deepcopy as careless miss by someone else possibly. I also concern no one can understand only INSTANTIATION_BODY requires to use deepcopy and others don\u0027t require.\n\nI\u0027ve suggested to define it as a function to avoid such problems. What do you think?","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5da31fa4658998e63aee96b573d1bbe2ac7ee4de","unresolved":true,"context_lines":[{"line_number":37,"context_line":"VNFINS_DEL_SUBSC_PATH \u003d \u0027/vnflcm/v1/subscriptions/%s\u0027"},{"line_number":38,"context_line":"VNFINS_SCALE_PATH \u003d \u0027/vnflcm/v1/vnf_instances/%s/scale\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"INSTANTIATION_BODY \u003d {"},{"line_number":41,"context_line":"    \u0027flavourId\u0027: \u0027simple\u0027,"},{"line_number":42,"context_line":"    \u0027extVirtualLinks\u0027: ["},{"line_number":43,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":76,"id":"bff5bf2d_c0360ef2","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"in_reply_to":"1bffd4e7_a7722da1","updated":"2022-03-18 08:26:00.000000000","message":"\u003e I didn\u0027t suggest to drop `deepcopy`, but I agree to your change if it\u0027s harmless. Could I confirm that your previous comment \"`copy.deepcopy` is necessary\" was not true actually?\n\nWe used `copy.deepcopy` as a safety measure like when parameter structure gets too deep. However, when we tested not using `copy.deepcopy` with the current parameter structure and it seems to be okay.. so we proceed with your suggestion.","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"33ce155cee72a49076330780f4982ca0a6030cd0","unresolved":true,"context_lines":[{"line_number":37,"context_line":"VNFINS_DEL_SUBSC_PATH \u003d \u0027/vnflcm/v1/subscriptions/%s\u0027"},{"line_number":38,"context_line":"VNFINS_SCALE_PATH \u003d \u0027/vnflcm/v1/vnf_instances/%s/scale\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"INSTANTIATION_BODY \u003d {"},{"line_number":41,"context_line":"    \u0027flavourId\u0027: \u0027simple\u0027,"},{"line_number":42,"context_line":"    \u0027extVirtualLinks\u0027: ["},{"line_number":43,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":76,"id":"a23740a5_c76f74fd","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"in_reply_to":"927a2abd_b97fbb2b","updated":"2022-03-16 10:30:36.000000000","message":"\u003e I understand you need to use deepcopy because you reuse this variable. However, you should define a capitalized name for constant in general. In addition, it can be happened to change the variable without deepcopy as careless miss by someone else possibly. I also concern no one can understand only INSTANTIATION_BODY requires to use deepcopy and others don\u0027t require.\n\u003e \n\u003e I\u0027ve suggested to define it as a function to avoid such problems. What do you think?\n\nThank you for your suggestion. We removed deepcopy as you suggested and tested it.","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"a4cdd71b9239d2ccaefc0d7aae22abe59420e99c","unresolved":true,"context_lines":[{"line_number":37,"context_line":"VNFINS_DEL_SUBSC_PATH \u003d \u0027/vnflcm/v1/subscriptions/%s\u0027"},{"line_number":38,"context_line":"VNFINS_SCALE_PATH \u003d \u0027/vnflcm/v1/vnf_instances/%s/scale\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"INSTANTIATION_BODY \u003d {"},{"line_number":41,"context_line":"    \u0027flavourId\u0027: \u0027simple\u0027,"},{"line_number":42,"context_line":"    \u0027extVirtualLinks\u0027: ["},{"line_number":43,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":76,"id":"061a332b_43061a08","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"in_reply_to":"a03ceded_789bcf10","updated":"2022-03-15 11:42:01.000000000","message":"\u003e I\u0027m not sure why it\u0027s defined as a const and used with `copy.deepcopy`, and not so for other siblings. I think it\u0027s simple to define them as functions which return the contents. What do you think?\n\nFor us, `copy.deepcopy` is necessary in order to get all the needed parameters of INSTANTIATE_BODY.","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ac8b9f7f68aac8f5df3c7319eb2a2249822d201d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"VNFINS_DEL_SUBSC_PATH \u003d \u0027/vnflcm/v1/subscriptions/%s\u0027"},{"line_number":38,"context_line":"VNFINS_SCALE_PATH \u003d \u0027/vnflcm/v1/vnf_instances/%s/scale\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"INSTANTIATION_BODY \u003d {"},{"line_number":41,"context_line":"    \u0027flavourId\u0027: \u0027simple\u0027,"},{"line_number":42,"context_line":"    \u0027extVirtualLinks\u0027: ["},{"line_number":43,"context_line":"        {"}],"source_content_type":"text/x-python","patch_set":76,"id":"1bffd4e7_a7722da1","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":19},"in_reply_to":"a23740a5_c76f74fd","updated":"2022-03-18 08:13:21.000000000","message":"I didn\u0027t suggest to drop `deepcopy`, but I agree to your change if it\u0027s harmless. Could I confirm that your previous comment \"`copy.deepcopy` is necessary\" was not true actually?","commit_id":"9723bff961a3eb550f549b1c5a2a117b5d2f6071"}],"tacker/tests/compliance/sol002/base.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"46b5c045_bde4766d","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-01 14:42:31.000000000","message":"How about changing it to this year\u0027s?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"ab12a1ee_a93b5ad4","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"46b5c045_bde4766d","updated":"2022-03-04 03:25:30.000000000","message":"\u003e How about changing it to this year\u0027s?\n\nIt is changed to this year.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"7005ded6_abb74bbc","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"ab12a1ee_a93b5ad4","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"}],"tacker/tests/compliance/sol002/test_vnflcm.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"8988cb40_7140fb66","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-01 14:42:31.000000000","message":"How about changing it to this year\u0027s?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"b4b263f1_7be8c4d8","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"8988cb40_7140fb66","updated":"2022-03-04 03:25:30.000000000","message":"\u003e How about changing it to this year\u0027s?\n\nIt is changed to this year.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"8cc8cfa8_66e00baf","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"b4b263f1_7be8c4d8","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"}],"tacker/tests/compliance/sol003/base.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"b7d28c73_c99f5922","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-01 14:42:31.000000000","message":"How about changing it to this year\u0027s?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"e289fb7d_c92370b1","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"9af88299_3dd06a99","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"9af88299_3dd06a99","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"b7d28c73_c99f5922","updated":"2022-03-04 03:25:30.000000000","message":"\u003e How about changing it to this year\u0027s?\n\nIt is changed to this year.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"}],"tacker/tests/compliance/sol003/test_vnflcm.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"f1a8a49a_2f6efe34","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-01 14:42:31.000000000","message":"How about changing it to this year\u0027s?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"09921b58_cad86e93","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"cc892020_2fe9e98f","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"cc892020_2fe9e98f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"f1a8a49a_2f6efe34","updated":"2022-03-04 03:25:30.000000000","message":"\u003e How about changing it to this year\u0027s?\n\nIt is changed to this year.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"}],"tacker/tests/compliance/sol005/base.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"de74bc99_866fe328","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-01 14:42:31.000000000","message":"How about changing it to this year\u0027s?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"28175202_23bcf978","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"11aabdf0_c71716f6","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"11aabdf0_c71716f6","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"de74bc99_866fe328","updated":"2022-03-04 03:25:30.000000000","message":"\u003e How about changing it to this year\u0027s?\n\nIt is changed to this year.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"}],"tacker/tests/compliance/sol005/test_vnfpkgm.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"28ff089d_e0e36a01","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2022-03-01 14:42:31.000000000","message":"How about changing it to this year\u0027s?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"5c8fba6f_fa423404","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"28ff089d_e0e36a01","updated":"2022-03-04 03:25:30.000000000","message":"\u003e How about changing it to this year\u0027s?\n\nIt is changed to this year.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020 NEC, Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":71,"id":"c5d7c57f_f532469d","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"5c8fba6f_fa423404","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"}],"tacker/tests/etc/samples/etsi/nfv/sample_compliance_test/Definitions/helloworld3_df_default.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":true,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: DemoVrtualStorage"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"34f27baa_2cd09f8b","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":26},"updated":"2022-03-04 14:53:47.000000000","message":"typo: Virtual","commit_id":"f25d913a4a1603207f86379ece4014db23852d35"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"5243f96274c3280b7c2bac092124e00627569eea","unresolved":true,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: DemoVrtualStorage"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"f9807ec8_a07bd88d","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":26},"in_reply_to":"34f27baa_2cd09f8b","updated":"2022-03-07 00:47:39.000000000","message":"\u003e typo: Virtual\n\n\"Vrtual\" was actually done on purpose since there are some images not removed in DB. We were avoiding same name images (Error: Duplicate Image name occurs).\nAnyway, we modified to the correct spelling. We will check the results if the same error (Duplicate Image name) occurs.","commit_id":"f25d913a4a1603207f86379ece4014db23852d35"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"693d9d67bfd112583ed9db70951048524e709538","unresolved":true,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: DemoVrtualStorage"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"cc96e7e9_e8cd8a1b","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":26},"in_reply_to":"9e4761ef_31c91fcf","updated":"2022-03-11 00:37:48.000000000","message":"\u003e \u003e We will check the results if the same error (Duplicate Image name) occurs.\n\u003e \n\u003e Could you confirm if this error is not occurring in latest PatchSet?\n\nThis error did not occur in Patch 73, but I could not confirm in the latest patch set. There seems to be a problem with Zuul, link to the results of the test does not show anything. In our local environment, we have confirmed that this error no longer occurs.","commit_id":"f25d913a4a1603207f86379ece4014db23852d35"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"766098e7cb8d4b2c6c0abcef55ad5cdbb4c432de","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: DemoVrtualStorage"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"948aa0da_be36d638","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":26},"in_reply_to":"cc96e7e9_e8cd8a1b","updated":"2022-03-11 15:59:46.000000000","message":"Thanks for your answer, I got it.","commit_id":"f25d913a4a1603207f86379ece4014db23852d35"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"874c93c60535178a76f1e6c59be0265f7d41413c","unresolved":true,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: DemoVrtualStorage"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":73,"id":"9e4761ef_31c91fcf","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":26},"in_reply_to":"f9807ec8_a07bd88d","updated":"2022-03-10 05:49:53.000000000","message":"\u003e We will check the results if the same error (Duplicate Image name) occurs.\n\nCould you confirm if this error is not occurring in latest PatchSet?","commit_id":"f25d913a4a1603207f86379ece4014db23852d35"}],"tacker/tests/etc/samples/etsi/nfv/sample_vnfd_1/Definitions/helloworld3_df_default.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"cdf38fca8a90e7d2d31137e1661fbc80beaac8af","unresolved":true,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: cirros-sample-disk-1"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"2ab2e91a_a657b21a","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":36},"updated":"2022-03-01 14:42:31.000000000","message":"The only differences in `sample_vnfd_X` added by this patch appear to be `descriptor_id` and `VDU1.properties.sw_image_data.name`.\nIs it possible to change to use a single package?\nIdeally, you should add as few packages as possible.\n\nAnd, if possible, why don\u0027t you clarify the use, for example, `sample_compliant _test` instead of naming it like `sample_vnfd _ X`?","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4425c28c54b17009aa601d7b6a97c42f52f1d8bc","unresolved":true,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: cirros-sample-disk-1"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"d0ab5afe_46cd8bef","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":36},"in_reply_to":"2ab2e91a_a657b21a","updated":"2022-03-04 03:25:30.000000000","message":"\u003e The only differences in `sample_vnfd_X` added by this patch appear to be `descriptor_id` and `VDU1.properties.sw_image_data.name`.\n\u003e Is it possible to change to use a single package?\n\u003e Ideally, you should add as few packages as possible.\n\u003e \n\u003e And, if possible, why don\u0027t you clarify the use, for example, `sample_compliant _test` instead of naming it like `sample_vnfd _ X`?\n\nWe updated the codes for scaling to use only 1 package. Image name and directory name is also updated. Please refer to the patch uploaded.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9022ec87b7226d343c5a0e04170d3661f9c2afe9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          min_number_of_instances: 1"},{"line_number":70,"context_line":"          max_number_of_instances: 50"},{"line_number":71,"context_line":"        sw_image_data:"},{"line_number":72,"context_line":"          name: cirros-sample-disk-1"},{"line_number":73,"context_line":"          version: \u00270.5.2\u0027"},{"line_number":74,"context_line":"          checksum:"},{"line_number":75,"context_line":"            algorithm: sha-512"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"4236c9ce_093adde2","line":72,"range":{"start_line":72,"start_character":16,"end_line":72,"end_character":36},"in_reply_to":"d0ab5afe_46cd8bef","updated":"2022-03-04 14:53:47.000000000","message":"I\u0027ve confirmed.","commit_id":"fd9e62cbb470d6f6c9fac56f9767cf3c3f4d0720"}]}