)]}'
{"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"0df8a52cca14bdae1291c29849c01f1d31a48b3a","unresolved":true,"context_lines":[{"line_number":1254,"context_line":"            # The \"pod template hash\" string is generated from 32 bit hash."},{"line_number":1255,"context_line":"            # This may be from 1 to 10 caracters but not sure the lower limit"},{"line_number":1256,"context_line":"            # from the source code of Kubernetes."},{"line_number":1257,"context_line":"            # Temporarily, this is set to be \"{1,10}\" but may need to be fixed."},{"line_number":1258,"context_line":"            match_result \u003d re.match("},{"line_number":1259,"context_line":"                rsc_name + \u0027-([0-9a-f]{1,10})-([0-9a-z]{5})+$\u0027,"},{"line_number":1260,"context_line":"                pod_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"26687f6d_f6e1c86f","line":1257,"updated":"2021-03-24 03:50:07.000000000","message":"Should it be a TODO? Anyway, I\u0027m not sure what may be needed to be fixed.\n\nMy suggestion is to remove this line simply because your fix is enough for the purpose regardless of teh lower limit. What do you think?","commit_id":"f48b092a771b700f5409d07ad19f313dd9728f12"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"d43068e098f8f7aeb9c68b5d01c16c6ca0711b1a","unresolved":true,"context_lines":[{"line_number":1254,"context_line":"            # The \"pod template hash\" string is generated from 32 bit hash."},{"line_number":1255,"context_line":"            # This may be from 1 to 10 caracters but not sure the lower limit"},{"line_number":1256,"context_line":"            # from the source code of Kubernetes."},{"line_number":1257,"context_line":"            # Temporarily, this is set to be \"{1,10}\" but may need to be fixed."},{"line_number":1258,"context_line":"            match_result \u003d re.match("},{"line_number":1259,"context_line":"                rsc_name + \u0027-([0-9a-f]{1,10})-([0-9a-z]{5})+$\u0027,"},{"line_number":1260,"context_line":"                pod_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"81aad2dd_6b463a08","line":1257,"in_reply_to":"26687f6d_f6e1c86f","updated":"2021-03-24 05:28:42.000000000","message":"Thank you for your comment. There is no TODO because this fix does not cause any new issues. So I will remove this line according to your suggestion.","commit_id":"f48b092a771b700f5409d07ad19f313dd9728f12"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a23533a6a089b2d7a6972647c3585cef44ad3629","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"            # The \"pod template hash\" string is generated from 32 bit hash."},{"line_number":1255,"context_line":"            # This may be from 1 to 10 caracters but not sure the lower limit"},{"line_number":1256,"context_line":"            # from the source code of Kubernetes."},{"line_number":1257,"context_line":"            # Temporarily, this is set to be \"{1,10}\" but may need to be fixed."},{"line_number":1258,"context_line":"            match_result \u003d re.match("},{"line_number":1259,"context_line":"                rsc_name + \u0027-([0-9a-f]{1,10})-([0-9a-z]{5})+$\u0027,"},{"line_number":1260,"context_line":"                pod_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"64283ed2_345206e9","line":1257,"in_reply_to":"81aad2dd_6b463a08","updated":"2021-03-24 05:35:11.000000000","message":"Ack","commit_id":"f48b092a771b700f5409d07ad19f313dd9728f12"}]}
