)]}'
{"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ca55ac31141beac21af1433162345d4bc416a562","unresolved":true,"context_lines":[{"line_number":193,"context_line":"        self._view_builder_subscription \u003d vnf_subscription_view.ViewBuilder()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_vnf_instance_href(self, vnf_instance):"},{"line_number":196,"context_line":"        return \u0027%svnflcm/v1/vnf_instances/%s\u0027 % ("},{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"52ce8628_0701a157","line":196,"range":{"start_line":196,"start_character":16,"end_line":196,"end_character":24},"updated":"2021-04-01 16:57:54.000000000","message":"It must be confusing for maintainers. You should use `format()` in this case.\n\n```\n\u0027{}vnflcm/v1/vnf_lcm_op_occs/{}\u0027.format(\n            CONF.vnf_lcm.endpoint_url, vnf_lcm_op_occs_id)\n```","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":33295,"name":"Shanu Pandit","email":"shanu.pandit@india.nec.com","username":"spandit1511"},"change_message_id":"233e4147704072b7188d5728f34bf6052b27d1b5","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self._view_builder_subscription \u003d vnf_subscription_view.ViewBuilder()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_vnf_instance_href(self, vnf_instance):"},{"line_number":196,"context_line":"        return \u0027%svnflcm/v1/vnf_instances/%s\u0027 % ("},{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f49d4bf_1d956e99","line":196,"range":{"start_line":196,"start_character":16,"end_line":196,"end_character":24},"in_reply_to":"52ce8628_0701a157","updated":"2021-04-05 13:26:45.000000000","message":"Comment is incorporated","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"688901ab9cb614649b8c9deee11322c42ae52032","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        self._view_builder_subscription \u003d vnf_subscription_view.ViewBuilder()"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_vnf_instance_href(self, vnf_instance):"},{"line_number":196,"context_line":"        return \u0027%svnflcm/v1/vnf_instances/%s\u0027 % ("},{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba022554_fcbd740e","line":196,"range":{"start_line":196,"start_character":16,"end_line":196,"end_character":24},"in_reply_to":"52ce8628_0701a157","updated":"2021-04-06 15:36:48.000000000","message":"Done","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2f039a9952405c8e49bed31ba0403c8b91a0e131","unresolved":true,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_vnf_instance_href(self, vnf_instance):"},{"line_number":196,"context_line":"        return \u0027%svnflcm/v1/vnf_instances/%s\u0027 % ("},{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("}],"source_content_type":"text/x-python","patch_set":5,"id":"acef780f_eeee4f7c","line":197,"updated":"2021-04-02 01:32:17.000000000","message":"This change affects the codes that originally use this method. ex. L.307 (L.319)\nIs it OK (Is it your intention) ?\nEven if so, you should explain somewhere that the notification data is changed.","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":33295,"name":"Shanu Pandit","email":"shanu.pandit@india.nec.com","username":"spandit1511"},"change_message_id":"233e4147704072b7188d5728f34bf6052b27d1b5","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_vnf_instance_href(self, vnf_instance):"},{"line_number":196,"context_line":"        return \u0027%svnflcm/v1/vnf_instances/%s\u0027 % ("},{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("}],"source_content_type":"text/x-python","patch_set":5,"id":"40fa42cd_1290732c","line":197,"in_reply_to":"acef780f_eeee4f7c","updated":"2021-04-05 13:26:45.000000000","message":"Details are added in commit message.","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"688901ab9cb614649b8c9deee11322c42ae52032","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_vnf_instance_href(self, vnf_instance):"},{"line_number":196,"context_line":"        return \u0027%svnflcm/v1/vnf_instances/%s\u0027 % ("},{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("}],"source_content_type":"text/x-python","patch_set":5,"id":"505da7cc_fb023fb9","line":197,"in_reply_to":"acef780f_eeee4f7c","updated":"2021-04-06 15:36:48.000000000","message":"Done","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ca55ac31141beac21af1433162345d4bc416a562","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("},{"line_number":201,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_lcm_op_occs_id)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_vnf_instance(self, context, id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"93f4e791_ca21725c","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":24},"updated":"2021-04-01 16:57:54.000000000","message":"ditto","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"688901ab9cb614649b8c9deee11322c42ae52032","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("},{"line_number":201,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_lcm_op_occs_id)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_vnf_instance(self, context, id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"4388eb68_63dc6ac4","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":24},"in_reply_to":"93f4e791_ca21725c","updated":"2021-04-06 15:36:48.000000000","message":"Done","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":33295,"name":"Shanu Pandit","email":"shanu.pandit@india.nec.com","username":"spandit1511"},"change_message_id":"233e4147704072b7188d5728f34bf6052b27d1b5","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_instance.id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("},{"line_number":201,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_lcm_op_occs_id)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_vnf_instance(self, context, id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"72b25d60_d750875e","line":200,"range":{"start_line":200,"start_character":16,"end_line":200,"end_character":24},"in_reply_to":"93f4e791_ca21725c","updated":"2021-04-05 13:26:45.000000000","message":"Done","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2f039a9952405c8e49bed31ba0403c8b91a0e131","unresolved":true,"context_lines":[{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("},{"line_number":201,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_lcm_op_occs_id)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_vnf_instance(self, context, id):"},{"line_number":204,"context_line":"        # check if id is of type uuid format"},{"line_number":205,"context_line":"        if not uuidutils.is_uuid_like(id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a235b6a_30587db1","line":202,"updated":"2021-04-02 01:32:17.000000000","message":"ditto (same as L.197 comment)","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":33295,"name":"Shanu Pandit","email":"shanu.pandit@india.nec.com","username":"spandit1511"},"change_message_id":"233e4147704072b7188d5728f34bf6052b27d1b5","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("},{"line_number":201,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_lcm_op_occs_id)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_vnf_instance(self, context, id):"},{"line_number":204,"context_line":"        # check if id is of type uuid format"},{"line_number":205,"context_line":"        if not uuidutils.is_uuid_like(id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"e01f6d5d_e85528bb","line":202,"in_reply_to":"5a235b6a_30587db1","updated":"2021-04-05 13:26:45.000000000","message":"Details are added in commit message.","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"688901ab9cb614649b8c9deee11322c42ae52032","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def _get_vnf_lcm_op_occs_href(self, vnf_lcm_op_occs_id):"},{"line_number":200,"context_line":"        return \u0027%svnflcm/v1/vnf_lcm_op_occs/%s\u0027 % ("},{"line_number":201,"context_line":"            CONF.vnf_lcm.endpoint_url, vnf_lcm_op_occs_id)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_vnf_instance(self, context, id):"},{"line_number":204,"context_line":"        # check if id is of type uuid format"},{"line_number":205,"context_line":"        if not uuidutils.is_uuid_like(id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"36ef70e5_0872d078","line":202,"in_reply_to":"5a235b6a_30587db1","updated":"2021-04-06 15:36:48.000000000","message":"Done","commit_id":"63153ba41d48171c771fba76bd3dafb64dd5f89f"}],"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4d37d48336a2712e4c079b82fd34d7de44e34803","unresolved":true,"context_lines":[{"line_number":600,"context_line":"        # Call Instantiate API"},{"line_number":601,"context_line":"        resp \u003d req.get_response(self.app)"},{"line_number":602,"context_line":"        self.assertTrue(\u0027Location\u0027 in resp.headers.keys())"},{"line_number":603,"context_line":"        expected_location_prefix \u003d (\u0027http://localhost:9890/\u0027"},{"line_number":604,"context_line":"            \u0027vnflcm/v1/vnf_lcm_op_occs/\u0027)"},{"line_number":605,"context_line":"        expected_location \u003d (expected_location_prefix +"},{"line_number":606,"context_line":"                    str(mock_insta_notfi_process.return_value))"},{"line_number":607,"context_line":"        self.assertEqual(expected_location, resp.headers[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"dae213b2_10a87ea9","line":604,"range":{"start_line":603,"start_character":8,"end_line":604,"end_character":41},"updated":"2021-04-05 18:47:42.000000000","message":"Why don\u0027t you define it as a member variable in the class because it\u0027s defined several times.","commit_id":"1a168509c3ad494850d538312d3745ce17c331c7"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"688901ab9cb614649b8c9deee11322c42ae52032","unresolved":false,"context_lines":[{"line_number":600,"context_line":"        # Call Instantiate API"},{"line_number":601,"context_line":"        resp \u003d req.get_response(self.app)"},{"line_number":602,"context_line":"        self.assertTrue(\u0027Location\u0027 in resp.headers.keys())"},{"line_number":603,"context_line":"        expected_location_prefix \u003d (\u0027http://localhost:9890/\u0027"},{"line_number":604,"context_line":"            \u0027vnflcm/v1/vnf_lcm_op_occs/\u0027)"},{"line_number":605,"context_line":"        expected_location \u003d (expected_location_prefix +"},{"line_number":606,"context_line":"                    str(mock_insta_notfi_process.return_value))"},{"line_number":607,"context_line":"        self.assertEqual(expected_location, resp.headers[\u0027location\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f68b9cf_43845d91","line":604,"range":{"start_line":603,"start_character":8,"end_line":604,"end_character":41},"in_reply_to":"dae213b2_10a87ea9","updated":"2021-04-06 15:36:48.000000000","message":"Done","commit_id":"1a168509c3ad494850d538312d3745ce17c331c7"}]}
