)]}'
{"samples/mgmt_driver/kubernetes_mgmt.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f7f3c7aefd174c7e062e4286d6e3b230c4e04542","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":106,"context_line":"        elif type \u003d\u003d \u0027install\u0027:"},{"line_number":107,"context_line":"            err \u003d result.get_stderr()"},{"line_number":108,"context_line":"            if \u0027Install Failed! The node does not in Kubernetes cluster.\\n\u0027 \\"},{"line_number":109,"context_line":"                    in result.get_stdout():"},{"line_number":110,"context_line":"                LOG.error(err)"},{"line_number":111,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a24b96f4_74580bd1","line":108,"range":{"start_line":108,"start_character":32,"end_line":108,"end_character":72},"updated":"2021-04-05 05:55:51.000000000","message":"The error message seems incomplete, could we re-phrase it as \"The node does not exist in Kubernetes cluster\" or whatever is more suitable. Please share your opinion.","commit_id":"57f242bcc8b613af4b025292057c3073812d637a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"95e73af86421ba2f7ae5e3519307030b98e94fb9","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":106,"context_line":"        elif type \u003d\u003d \u0027install\u0027:"},{"line_number":107,"context_line":"            err \u003d result.get_stderr()"},{"line_number":108,"context_line":"            if \u0027Install Failed! The node does not in Kubernetes cluster.\\n\u0027 \\"},{"line_number":109,"context_line":"                    in result.get_stdout():"},{"line_number":110,"context_line":"                LOG.error(err)"},{"line_number":111,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4863a03_ec93ab29","line":108,"range":{"start_line":108,"start_character":32,"end_line":108,"end_character":72},"in_reply_to":"a24b96f4_74580bd1","updated":"2021-04-05 09:27:07.000000000","message":"Thanks for comment, I agree with you opinion, I have fixed here and script, please kindly have a check","commit_id":"57f242bcc8b613af4b025292057c3073812d637a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1064ff4ba3a2b07edd67cf26cfa9d8f6f22f273a","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                LOG.debug(stdout)"},{"line_number":99,"context_line":"                LOG.debug(err)"},{"line_number":100,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027:"},{"line_number":101,"context_line":"            if \u0027[upload-certs] Using certificate key:\\n\u0027 not \\"},{"line_number":102,"context_line":"                    in result.get_stdout():"},{"line_number":103,"context_line":"                err \u003d result.get_stderr()"},{"line_number":104,"context_line":"                LOG.error(err)"},{"line_number":105,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd0d5575_613fa6d3","line":102,"range":{"start_line":101,"start_character":0,"end_line":102,"end_character":43},"updated":"2021-04-07 02:02:43.000000000","message":"Same as L.108","commit_id":"26f19883e86295fe0b49cf1a66562dd6ee262285"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"1064ff4ba3a2b07edd67cf26cfa9d8f6f22f273a","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":106,"context_line":"        elif type \u003d\u003d \u0027install\u0027:"},{"line_number":107,"context_line":"            err \u003d result.get_stderr()"},{"line_number":108,"context_line":"            if \u0027Install Failed! The node does \\"},{"line_number":109,"context_line":"                    not exist in Kubernetes cluster.\\n\u0027 in result.get_stdout():"},{"line_number":110,"context_line":"                LOG.error(err)"},{"line_number":111,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":112,"context_line":"        return result.get_stdout()"}],"source_content_type":"text/x-python","patch_set":2,"id":"d0535794_811abd10","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":79},"updated":"2021-04-07 02:02:43.000000000","message":"You should avoid to find an error by matching with output message. It can be a bug easily for a careless mistake. You can find a failure from returned code when it is non-zero if you use several codes in `install_k8s_cluster.sh`.","commit_id":"26f19883e86295fe0b49cf1a66562dd6ee262285"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"c7b4fbaa3d88c0a542232bb829249b0add52da84","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":106,"context_line":"        elif type \u003d\u003d \u0027install\u0027:"},{"line_number":107,"context_line":"            err \u003d result.get_stderr()"},{"line_number":108,"context_line":"            if \u0027Install Failed! The node does \\"},{"line_number":109,"context_line":"                    not exist in Kubernetes cluster.\\n\u0027 in result.get_stdout():"},{"line_number":110,"context_line":"                LOG.error(err)"},{"line_number":111,"context_line":"                raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":112,"context_line":"        return result.get_stdout()"}],"source_content_type":"text/x-python","patch_set":2,"id":"053ab31d_365eee60","line":109,"range":{"start_line":108,"start_character":0,"end_line":109,"end_character":79},"in_reply_to":"d0535794_811abd10","updated":"2021-04-07 10:36:20.000000000","message":"I combine the certificate_key and install conditions, and then determine whether the script return value is non-zero.","commit_id":"26f19883e86295fe0b49cf1a66562dd6ee262285"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"85ca5fba15b9f783e3162a413eb96f38b20ef495","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                LOG.debug(stdout)"},{"line_number":99,"context_line":"                LOG.debug(err)"},{"line_number":100,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027 or type \u003d\u003d \u0027install\u0027:"},{"line_number":101,"context_line":"            if result.get_return_code() !\u003d \u00270\u0027 and \\"},{"line_number":102,"context_line":"                    result.get_return_code() !\u003d 0:"},{"line_number":103,"context_line":"                err \u003d result.get_stderr()"},{"line_number":104,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"72dccaca_124ee54f","line":101,"range":{"start_line":101,"start_character":43,"end_line":101,"end_character":46},"updated":"2021-04-07 11:12:13.000000000","message":"Please confirm if checking character zero is required?\nI mean exit/return codes are generally numeric (integer to be specific).","commit_id":"cbc0809791d11ba2dc07addf1d30aa0ae817d7c3"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"e7a44ba516bf8965cffd685cb7549cecdce6803a","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                LOG.debug(stdout)"},{"line_number":99,"context_line":"                LOG.debug(err)"},{"line_number":100,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027 or type \u003d\u003d \u0027install\u0027:"},{"line_number":101,"context_line":"            if result.get_return_code() !\u003d \u00270\u0027 and \\"},{"line_number":102,"context_line":"                    result.get_return_code() !\u003d 0:"},{"line_number":103,"context_line":"                err \u003d result.get_stderr()"},{"line_number":104,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a2917def_8c69e380","line":101,"range":{"start_line":101,"start_character":43,"end_line":101,"end_character":46},"in_reply_to":"48159618_db53655a","updated":"2021-04-08 11:26:35.000000000","message":"Thank you for further confirmation!","commit_id":"cbc0809791d11ba2dc07addf1d30aa0ae817d7c3"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"d12d46ea8766230904a7d7740bc5369cf0548797","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                LOG.debug(stdout)"},{"line_number":99,"context_line":"                LOG.debug(err)"},{"line_number":100,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027 or type \u003d\u003d \u0027install\u0027:"},{"line_number":101,"context_line":"            if result.get_return_code() !\u003d \u00270\u0027 and \\"},{"line_number":102,"context_line":"                    result.get_return_code() !\u003d 0:"},{"line_number":103,"context_line":"                err \u003d result.get_stderr()"},{"line_number":104,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c0c790de_322e08f4","line":101,"range":{"start_line":101,"start_character":43,"end_line":101,"end_character":46},"in_reply_to":"72dccaca_124ee54f","updated":"2021-04-08 07:28:29.000000000","message":"Thanks for your comment! I agree with you and I have deleted the situation of String \u00270\u0027,\nPlease kindly have a check!","commit_id":"cbc0809791d11ba2dc07addf1d30aa0ae817d7c3"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"7ab9763c6e05d3e6ff7c7e31d83af19803b26187","unresolved":true,"context_lines":[{"line_number":98,"context_line":"                LOG.debug(stdout)"},{"line_number":99,"context_line":"                LOG.debug(err)"},{"line_number":100,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027 or type \u003d\u003d \u0027install\u0027:"},{"line_number":101,"context_line":"            if result.get_return_code() !\u003d \u00270\u0027 and \\"},{"line_number":102,"context_line":"                    result.get_return_code() !\u003d 0:"},{"line_number":103,"context_line":"                err \u003d result.get_stderr()"},{"line_number":104,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"48159618_db53655a","line":101,"range":{"start_line":101,"start_character":43,"end_line":101,"end_character":46},"in_reply_to":"c0c790de_322e08f4","updated":"2021-04-08 10:27:22.000000000","message":"As a memo, I\u0027ve confirmed `result.get_return_code()` is assigned from `recv_exit_status()` defined in `paramiko.channel.Channel`[1], and it returns a code as `int`.\n\nThanks for both for revising.\n\n[1] http://docs.paramiko.org/en/stable/api/channel.html#paramiko.channel.Channel.recv_exit_status","commit_id":"cbc0809791d11ba2dc07addf1d30aa0ae817d7c3"}]}