)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ba4644295351276a0d8f87e653093861f2e83654","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     LiangLu \u003clu.liang@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-05 16:58:48 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new abstract_driver methods for kubernetes_mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"86bca251_4a0e7f13","line":7,"updated":"2021-04-05 19:09:23.000000000","message":"I\u0027d like to ask you to comply with the basic guidelines of commit message again. Limitation of characters per lines, make it simple as possible and clear references or history if you mention previous changes.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b6e29d89ecfb6ffc925dfe827f865902afca785a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     LiangLu \u003clu.liang@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-05 16:58:48 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new abstract_driver methods for kubernetes_mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1910b904_6862f335","line":7,"in_reply_to":"86bca251_4a0e7f13","updated":"2021-04-06 08:00:18.000000000","message":"Thanks for comment and sorry for over characters limitation again...\nI have fixed it, also I will check other patches again.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ba4644295351276a0d8f87e653093861f2e83654","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new abstract_driver methods for kubernetes_mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"840de245_32fac055","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"updated":"2021-04-05 19:09:23.000000000","message":"Which methods? You\u0027d better to tell us them because it\u0027s just two.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b6e29d89ecfb6ffc925dfe827f865902afca785a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new abstract_driver methods for kubernetes_mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"107d9390_780bcbae","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"840de245_32fac055","updated":"2021-04-06 08:00:18.000000000","message":"Thanks for comment, I have updated to show actual method names, please kindly have a check:)","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ba4644295351276a0d8f87e653093861f2e83654","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add new abstract_driver methods for kubernetes_mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"},{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8dc19668_e5cfec93","line":10,"updated":"2021-04-05 19:09:23.000000000","message":"nit, but you should add a period to the end of the sentence.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b6e29d89ecfb6ffc925dfe827f865902afca785a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add new abstract_driver methods for kubernetes_mgmt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"},{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"af42eec6_7dafdf74","line":10,"in_reply_to":"8dc19668_e5cfec93","updated":"2021-04-06 08:00:18.000000000","message":"Thanks for comment, fixed.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ba4644295351276a0d8f87e653093861f2e83654","unresolved":true,"context_lines":[{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"},{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"},{"line_number":14,"context_line":"these 2 methods here."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cc68fd30_7902a0b5","line":12,"range":{"start_line":12,"start_character":46,"end_line":12,"end_character":58},"updated":"2021-04-05 19:09:23.000000000","message":"Is it a correct in grammer?","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ba4644295351276a0d8f87e653093861f2e83654","unresolved":true,"context_lines":[{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"},{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"},{"line_number":14,"context_line":"these 2 methods here."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"db80a25b_5811b91d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"updated":"2021-04-05 19:09:23.000000000","message":"It should be capitalized.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b6e29d89ecfb6ffc925dfe827f865902afca785a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"},{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"},{"line_number":14,"context_line":"these 2 methods here."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d36bf605_b35465a2","line":12,"range":{"start_line":12,"start_character":46,"end_line":12,"end_character":58},"in_reply_to":"cc68fd30_7902a0b5","updated":"2021-04-06 08:00:18.000000000","message":"Thanks for comment, changed to verb.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b6e29d89ecfb6ffc925dfe827f865902afca785a","unresolved":true,"context_lines":[{"line_number":9,"context_line":"2 new methods are added at last time merge of Wallaby"},{"line_number":10,"context_line":"in tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"in sample/mgmt_drivers/kubernetes_mgmt.py, we inheritanced"},{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"},{"line_number":14,"context_line":"these 2 methods here."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6bb9c0a0_3893ad10","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":1},"in_reply_to":"db80a25b_5811b91d","updated":"2021-04-06 08:00:18.000000000","message":"fixed.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ba4644295351276a0d8f87e653093861f2e83654","unresolved":true,"context_lines":[{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"},{"line_number":14,"context_line":"these 2 methods here."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Due to we dont have these interfaces here, I will"},{"line_number":17,"context_line":"implement empty methods for clear runtime error."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also, as it is commited as sample codes, this lack of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8efe7898_d4bfdabb","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":14},"updated":"2021-04-05 19:09:23.000000000","message":"don\u0027t","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b6e29d89ecfb6ffc925dfe827f865902afca785a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"VnflcmAbstractDriver thus we also needed to implements"},{"line_number":14,"context_line":"these 2 methods here."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Due to we dont have these interfaces here, I will"},{"line_number":17,"context_line":"implement empty methods for clear runtime error."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also, as it is commited as sample codes, this lack of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"de6e3e18_15a6a951","line":16,"range":{"start_line":16,"start_character":10,"end_line":16,"end_character":14},"in_reply_to":"8efe7898_d4bfdabb","updated":"2021-04-06 08:00:18.000000000","message":"fixed.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ba4644295351276a0d8f87e653093861f2e83654","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Due to we dont have these interfaces here, I will"},{"line_number":17,"context_line":"implement empty methods for clear runtime error."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also, as it is commited as sample codes, this lack of"},{"line_number":20,"context_line":"method will not affect other codes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9f918ceff9882da1bff4b1cc953602a3b84aec0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"606b77d9_8924edc1","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":35},"updated":"2021-04-05 19:09:23.000000000","message":"No need to say such that. It must be run correctly even if introduced as a sample.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b4a2c27ee2cc234abc36df24fa00b6d23109e775","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Due to we dont have these interfaces here, I will"},{"line_number":17,"context_line":"implement empty methods for clear runtime error."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also, as it is commited as sample codes, this lack of"},{"line_number":20,"context_line":"method will not affect other codes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9f918ceff9882da1bff4b1cc953602a3b84aec0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ab8fff1e_295b6714","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"3c11030e_b8e0cb4b","updated":"2021-04-07 07:57:40.000000000","message":"I deleted the description here.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"b6e29d89ecfb6ffc925dfe827f865902afca785a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Due to we dont have these interfaces here, I will"},{"line_number":17,"context_line":"implement empty methods for clear runtime error."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also, as it is commited as sample codes, this lack of"},{"line_number":20,"context_line":"method will not affect other codes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9f918ceff9882da1bff4b1cc953602a3b84aec0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bb21378f_967d1bc0","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"606b77d9_8924edc1","updated":"2021-04-06 08:00:18.000000000","message":"Thanks for comment, here I want to explain even though this missing implementation of methods happened here(also this patch fix), it won\u0027t affect other methods, thus also this patch is not a #bugfix.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"24f91cd489a15343b2976f54555a5a385bd588fb","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Due to we dont have these interfaces here, I will"},{"line_number":17,"context_line":"implement empty methods for clear runtime error."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also, as it is commited as sample codes, this lack of"},{"line_number":20,"context_line":"method will not affect other codes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I9f918ceff9882da1bff4b1cc953602a3b84aec0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3c11030e_b8e0cb4b","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"bb21378f_967d1bc0","updated":"2021-04-06 18:01:34.000000000","message":"I don\u0027t understand why you want to say that here. We should not include wrong codes even if it\u0027s a sample. So, such an excuse has no meaning.\n\nI\u0027d like to say again that I agreed to merge your codes as a sample because it should be included into tacker but cannot pass some tests. It\u0027s just a next best option.","commit_id":"a73b209c65971e163f81d0131f98bf1331296f9a"}]}