)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4f68dfbf846bcc767de255c04e6cde355d9fb227","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     LiangLu \u003clu.liang@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-06 08:03:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix visual bugs of vnflcm show command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e0adb50e_0e25faed","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"updated":"2021-04-07 08:11:14.000000000","message":"What do you mean? Without you mean GUI, it\u0027s just a bit strange for me.","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"738fc65b621c7bfa14fb71bf2df3b975da9d5645","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     LiangLu \u003clu.liang@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-06 08:03:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix visual bugs of vnflcm show command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"79c590dc_0f5e00ad","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"in_reply_to":"54a9f5ba_c975d8e9","updated":"2021-04-08 18:46:40.000000000","message":"Ack","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"aeffdba41d6a0e505883fbec1ea1fd8c0301418d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     LiangLu \u003clu.liang@jp.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-04-06 08:03:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix visual bugs of vnflcm show command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"54a9f5ba_c975d8e9","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":15},"in_reply_to":"e0adb50e_0e25faed","updated":"2021-04-08 08:09:34.000000000","message":"Sorry for incorrect word use, here I want to explain this bug are something visually like intends, extra blanks.. I this display bugs will be better to describe.","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4f68dfbf846bcc767de255c04e6cde355d9fb227","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix visual bugs of vnflcm show command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* See details in bug#1922544."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9931f4fa_9e790b20","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2021-04-07 08:11:14.000000000","message":"W","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"738fc65b621c7bfa14fb71bf2df3b975da9d5645","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix visual bugs of vnflcm show command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* See details in bug#1922544."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"82095dc6_ad28bb2b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"in_reply_to":"7a97d44f_bc6f3a5e","updated":"2021-04-08 18:46:40.000000000","message":"Done","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"aeffdba41d6a0e505883fbec1ea1fd8c0301418d","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix visual bugs of vnflcm show command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* See details in bug#1922544."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a97d44f_bc6f3a5e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"in_reply_to":"9931f4fa_9e790b20","updated":"2021-04-08 08:09:34.000000000","message":"fixed","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4f68dfbf846bcc767de255c04e6cde355d9fb227","unresolved":true,"context_lines":[{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* See details in bug#1922544."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes vnfm/infra_driver/openstack.py"},{"line_number":15,"context_line":"in order to fix these bugs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"85ab9933_45f8e577","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":29},"updated":"2021-04-07 08:11:14.000000000","message":"`Closes-Bug` is enough, so it\u0027s meaningless.","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"738fc65b621c7bfa14fb71bf2df3b975da9d5645","unresolved":false,"context_lines":[{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* See details in bug#1922544."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes vnfm/infra_driver/openstack.py"},{"line_number":15,"context_line":"in order to fix these bugs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"05ccc101_96e4e54c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":29},"in_reply_to":"61098785_85dc4f03","updated":"2021-04-08 18:46:40.000000000","message":"Done","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"aeffdba41d6a0e505883fbec1ea1fd8c0301418d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"when running openstack vnflcm show command in CLI,"},{"line_number":10,"context_line":"some over intended bugs and ip version error will happen."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* See details in bug#1922544."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes vnfm/infra_driver/openstack.py"},{"line_number":15,"context_line":"in order to fix these bugs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"61098785_85dc4f03","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":29},"in_reply_to":"85ab9933_45f8e577","updated":"2021-04-08 08:09:34.000000000","message":"fixed","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"}],"tacker/common/exceptions.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ed01e806f1f0ab5f02eb693fc200a2e6bdeccdfe","unresolved":true,"context_lines":[{"line_number":425,"context_line":"                \"with this error point.\")"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"class InvalidIPaddrValue(TackerException):"},{"line_number":429,"context_line":"    message \u003d _(\u0027Invalid ip address value in resource %(id)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f3dbe31_ae65bbae","line":428,"range":{"start_line":428,"start_character":6,"end_line":428,"end_character":24},"updated":"2021-04-09 01:44:25.000000000","message":"It responds to https://review.opendev.org/c/openstack/tacker/+/784756/7/tacker/vnfm/infra_drivers/openstack/openstack.py#1588","commit_id":"98ddf9e914625a37c005023a2a145196282c708a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5138e24ebcb5c38efdf7eea43a10fa466fd01b56","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                \"with this error point.\")"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"class InvalidIPaddrValue(TackerException):"},{"line_number":429,"context_line":"    message \u003d _(\u0027Invalid ip address value in resource %(id)s.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"608cf118_a3d6ad65","line":428,"range":{"start_line":428,"start_character":6,"end_line":428,"end_character":24},"in_reply_to":"7f3dbe31_ae65bbae","updated":"2021-04-09 05:04:42.000000000","message":"Thanks for advise, changed to InvalidIpAddr.","commit_id":"98ddf9e914625a37c005023a2a145196282c708a"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"93eb67f2ee09c84dbb8c3d24b009c186ad8baad4","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1575,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1576,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1577,"context_line":"                                        if ipaddress.ip_address("},{"line_number":1578,"context_line":"                                                ip_addr).version \u003d\u003d 4:"},{"line_number":1579,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1580,"context_line":"                                        else:"},{"line_number":1581,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7d1b4cc9_276fafc2","line":1578,"range":{"start_line":1577,"start_character":39,"end_line":1578,"end_character":70},"updated":"2021-04-07 12:03:03.000000000","message":"As per https://docs.python.org/3/library/ipaddress.html#ipaddress.ip_address\n\"\n  ipaddress.ip_address(address)\n  Return an IPv4Address or IPv6Address object depending on the IP address passed as argument. \n  ... \n  A ValueError is raised if address does not represent a valid IPv4 or IPv6 address.\n\"\n\nShould we catch this ValueError here?\nI think same is conveyed by Mr. Yasufumi Ogawa.","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"aeffdba41d6a0e505883fbec1ea1fd8c0301418d","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1575,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1576,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1577,"context_line":"                                        if ipaddress.ip_address("},{"line_number":1578,"context_line":"                                                ip_addr).version \u003d\u003d 4:"},{"line_number":1579,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1580,"context_line":"                                        else:"},{"line_number":1581,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"f915a9af_21b4b9e2","line":1578,"range":{"start_line":1577,"start_character":39,"end_line":1578,"end_character":70},"in_reply_to":"7d1b4cc9_276fafc2","updated":"2021-04-08 08:09:34.000000000","message":"Thanks for your comment and reference, I have added code to catch ValueError and raise another exception to vnflcm_driver, could you kindly please have a check?","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"46e0bee19474ed742a7cc6a37586b0d0d01bcbb5","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1575,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1576,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1577,"context_line":"                                        if ipaddress.ip_address("},{"line_number":1578,"context_line":"                                                ip_addr).version \u003d\u003d 4:"},{"line_number":1579,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1580,"context_line":"                                        else:"},{"line_number":1581,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1b88f58e_d6431564","line":1578,"range":{"start_line":1577,"start_character":39,"end_line":1578,"end_character":70},"in_reply_to":"f915a9af_21b4b9e2","updated":"2021-04-08 11:40:34.000000000","message":"Thank you!","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"4f68dfbf846bcc767de255c04e6cde355d9fb227","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1575,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1576,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1577,"context_line":"                                        if ipaddress.ip_address("},{"line_number":1578,"context_line":"                                                ip_addr).version \u003d\u003d 4:"},{"line_number":1579,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1580,"context_line":"                                        else:"},{"line_number":1581,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1582,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1583,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("},{"line_number":1584,"context_line":"                                            \u0027subnet_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"234e1dca_7360ab22","line":1581,"range":{"start_line":1577,"start_character":0,"end_line":1581,"end_character":70},"updated":"2021-04-07 08:11:14.000000000","message":"If `ip_addr` is ensured to be a valid address, it\u0027s just a bit redundant. On the other hand, you need to add `try` to catch an invalid address.\n\n```\nip_address.type \u003d \u0027IPV{}\u0027.format(\n    ipaddress.ip_address(\n        ip_addr).version)\n```","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"aeffdba41d6a0e505883fbec1ea1fd8c0301418d","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1575,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1576,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1577,"context_line":"                                        if ipaddress.ip_address("},{"line_number":1578,"context_line":"                                                ip_addr).version \u003d\u003d 4:"},{"line_number":1579,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1580,"context_line":"                                        else:"},{"line_number":1581,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1582,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1583,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("},{"line_number":1584,"context_line":"                                            \u0027subnet_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9b34d317_bb7d87e4","line":1581,"range":{"start_line":1577,"start_character":0,"end_line":1581,"end_character":70},"in_reply_to":"234e1dca_7360ab22","updated":"2021-04-08 08:09:34.000000000","message":"Actually this ipaddr here was get from heat_client, using for scale, thus I think it should be a valid address since the VNF has already been instantiated.\n\nHowever, I think we can also ensure the value should be valid here, for a further check, thus I added try/catch to catch ValueError raised from ipaddress, and raise another new exception to vnflcm_driver.\n\nAlso, in vnflcm_driver, after catch exception from here, it will not logging error message here, (https://opendev.org/openstack/tacker/src/branch/master/tacker/vnflcm/vnflcm_driver.py#L83)\nthus I added LOG.error to show the reason(invalid ipaddr value)\n\nCould you kindly check it again?","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"3a8281bc69d642a91661840bdad60a19c45514b2","unresolved":true,"context_lines":[{"line_number":1574,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1575,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1576,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1577,"context_line":"                                        if ipaddress.ip_address("},{"line_number":1578,"context_line":"                                                ip_addr).version \u003d\u003d 4:"},{"line_number":1579,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1580,"context_line":"                                        else:"},{"line_number":1581,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1582,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1583,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("},{"line_number":1584,"context_line":"                                            \u0027subnet_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dc41b6f4_f1413ad5","line":1581,"range":{"start_line":1577,"start_character":0,"end_line":1581,"end_character":70},"in_reply_to":"9b34d317_bb7d87e4","updated":"2021-04-08 10:38:22.000000000","message":"Sorry for lack of explanation of my suggestion for `redundant`. I\u0027ve suggested to validation and also your code is just a bit redundant. I mean you don\u0027t need to find the address is IPv4 or IPv6 by using `if` condition, but below code is enough.\n\n```\nip_address.type \u003d \u0027IPV{}\u0027.format(\n    ipaddress.ip_address(\n        ip_addr).version)\n```","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"738fc65b621c7bfa14fb71bf2df3b975da9d5645","unresolved":false,"context_lines":[{"line_number":1574,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1575,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1576,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1577,"context_line":"                                        if ipaddress.ip_address("},{"line_number":1578,"context_line":"                                                ip_addr).version \u003d\u003d 4:"},{"line_number":1579,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1580,"context_line":"                                        else:"},{"line_number":1581,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1582,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1583,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("},{"line_number":1584,"context_line":"                                            \u0027subnet_id\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1660dd21_58153ff1","line":1581,"range":{"start_line":1577,"start_character":0,"end_line":1581,"end_character":70},"in_reply_to":"dc41b6f4_f1413ad5","updated":"2021-04-08 18:46:40.000000000","message":"Thanks for your explanation... It is much more clear and simple, I have fixed codes, please kindly have a check","commit_id":"af7b7ce45c910020034711bb4f841b64f451b9c0"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"46e0bee19474ed742a7cc6a37586b0d0d01bcbb5","unresolved":true,"context_lines":[{"line_number":1576,"context_line":"                                        try:"},{"line_number":1577,"context_line":"                                            ip_addr \u003d fixed_ip.get("},{"line_number":1578,"context_line":"                                                \u0027ip_address\u0027)"},{"line_number":1579,"context_line":"                                            if ipaddress.ip_address("},{"line_number":1580,"context_line":"                                                    ip_addr).version \u003d\u003d 4:"},{"line_number":1581,"context_line":"                                                ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1582,"context_line":"                                            else:"},{"line_number":1583,"context_line":"                                                ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1584,"context_line":"                                        except ValueError:"},{"line_number":1585,"context_line":"                                            LOG.error(\"Invalid ip address \\"},{"line_number":1586,"context_line":"                                                value in resource %(id)s.\","}],"source_content_type":"text/x-python","patch_set":6,"id":"2df5fe31_0fafcee9","line":1583,"range":{"start_line":1579,"start_character":44,"end_line":1583,"end_character":74},"updated":"2021-04-08 11:40:34.000000000","message":"Could you please check comment from Mr Yasufumi Ogawa?\nI agree that \u0027if else\u0027 code inside try-catch can be simplified as below:\ntry:\n    ip_addr \u003d fixed_ip.get(\n        \u0027ip_address\u0027)\n    ip_address.type \u003d \u0027IPV{}\u0027.format(\n        ipaddress.ip_address(\n            ip_addr).version)\nexcept ValueError:\n------","commit_id":"79218ae4d64a4c06e0d5c4b3f71203724a754040"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"0cf84955131cbdd812a19e3f0e787c5c3e02d8c3","unresolved":false,"context_lines":[{"line_number":1576,"context_line":"                                        try:"},{"line_number":1577,"context_line":"                                            ip_addr \u003d fixed_ip.get("},{"line_number":1578,"context_line":"                                                \u0027ip_address\u0027)"},{"line_number":1579,"context_line":"                                            if ipaddress.ip_address("},{"line_number":1580,"context_line":"                                                    ip_addr).version \u003d\u003d 4:"},{"line_number":1581,"context_line":"                                                ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1582,"context_line":"                                            else:"},{"line_number":1583,"context_line":"                                                ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1584,"context_line":"                                        except ValueError:"},{"line_number":1585,"context_line":"                                            LOG.error(\"Invalid ip address \\"},{"line_number":1586,"context_line":"                                                value in resource %(id)s.\","}],"source_content_type":"text/x-python","patch_set":6,"id":"d01eb41d_8b1b074c","line":1583,"range":{"start_line":1579,"start_character":44,"end_line":1583,"end_character":74},"in_reply_to":"2df5fe31_0fafcee9","updated":"2021-04-08 18:47:43.000000000","message":"Thanks for comment, I agree with that, I\u0027ve uploaded a new patch, please kindly have a  check","commit_id":"79218ae4d64a4c06e0d5c4b3f71203724a754040"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"45e6de8d36524f3fb546858cafaf57d1a58adcf1","unresolved":true,"context_lines":[{"line_number":1581,"context_line":"                                                    ipaddress.ip_address("},{"line_number":1582,"context_line":"                                                        ip_addr).version)"},{"line_number":1583,"context_line":"                                        except ValueError:"},{"line_number":1584,"context_line":"                                            LOG.error(\"Invalid ip address \\"},{"line_number":1585,"context_line":"                                                value in resource %(id)s.\","},{"line_number":1586,"context_line":"                                                    vnfc_rsc.id)"},{"line_number":1587,"context_line":"                                            raise \\"},{"line_number":1588,"context_line":"                                                exceptions.InvalidIPaddrValue("},{"line_number":1589,"context_line":"                                                    id\u003dvnfc_rsc.id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"c75b54bc_b47f358a","line":1586,"range":{"start_line":1584,"start_character":0,"end_line":1586,"end_character":64},"updated":"2021-04-09 01:37:17.000000000","message":"I\u0027d like to ask you to revise:\n\n* It must be failed because `vnfc_rsc.id` doesn\u0027t match `%(id)s`, causing `Logging error` as a result. It should be a pair of `%s` and `vnfc_rsc.id`, or `%(id)s\u0027 and `{\u0027id\u0027: vnfc_rsc.id}`.\n\n* You shouldn\u0027t use `\\` here, or log message will include many spaces like as \"Invalid ip address              value ...\". You should separate into two strings instead.\n\n* Why don\u0027t you show `ip_addr` instead of `vnfc_rsc.id`, or show both? It\u0027s because we\u0027re interested in IP address itself, but cannot see in your log message.\n\nMy suggestion is here.\n\n```\nLOG.error(\"Invalid IP address %s\"\n    \" in resource %s.\",\n    ip_addr, vnfc_rcs.id)\n```","commit_id":"98ddf9e914625a37c005023a2a145196282c708a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5138e24ebcb5c38efdf7eea43a10fa466fd01b56","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"                                                    ipaddress.ip_address("},{"line_number":1582,"context_line":"                                                        ip_addr).version)"},{"line_number":1583,"context_line":"                                        except ValueError:"},{"line_number":1584,"context_line":"                                            LOG.error(\"Invalid ip address \\"},{"line_number":1585,"context_line":"                                                value in resource %(id)s.\","},{"line_number":1586,"context_line":"                                                    vnfc_rsc.id)"},{"line_number":1587,"context_line":"                                            raise \\"},{"line_number":1588,"context_line":"                                                exceptions.InvalidIPaddrValue("},{"line_number":1589,"context_line":"                                                    id\u003dvnfc_rsc.id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7fa5445e_2db08f1b","line":1586,"range":{"start_line":1584,"start_character":0,"end_line":1586,"end_character":64},"in_reply_to":"c75b54bc_b47f358a","updated":"2021-04-09 05:04:42.000000000","message":"Thanks for you advise.. and sorry for my mistake..\nI have fixed this part, could you please kindly check it again?","commit_id":"98ddf9e914625a37c005023a2a145196282c708a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ed01e806f1f0ab5f02eb693fc200a2e6bdeccdfe","unresolved":true,"context_lines":[{"line_number":1585,"context_line":"                                                value in resource %(id)s.\","},{"line_number":1586,"context_line":"                                                    vnfc_rsc.id)"},{"line_number":1587,"context_line":"                                            raise \\"},{"line_number":1588,"context_line":"                                                exceptions.InvalidIPaddrValue("},{"line_number":1589,"context_line":"                                                    id\u003dvnfc_rsc.id)"},{"line_number":1590,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1591,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("}],"source_content_type":"text/x-python","patch_set":7,"id":"97f095a2_b50d94e5","line":1588,"range":{"start_line":1588,"start_character":59,"end_line":1588,"end_character":77},"updated":"2021-04-09 01:44:25.000000000","message":"I think it\u0027s enough `InvalidIpAddr` so that we don\u0027t need to use such a long name at here so deep indented and can remove backspace before.","commit_id":"98ddf9e914625a37c005023a2a145196282c708a"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"5138e24ebcb5c38efdf7eea43a10fa466fd01b56","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"                                                value in resource %(id)s.\","},{"line_number":1586,"context_line":"                                                    vnfc_rsc.id)"},{"line_number":1587,"context_line":"                                            raise \\"},{"line_number":1588,"context_line":"                                                exceptions.InvalidIPaddrValue("},{"line_number":1589,"context_line":"                                                    id\u003dvnfc_rsc.id)"},{"line_number":1590,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1591,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("}],"source_content_type":"text/x-python","patch_set":7,"id":"6c97ea19_962df3e9","line":1588,"range":{"start_line":1588,"start_character":59,"end_line":1588,"end_character":77},"in_reply_to":"97f095a2_b50d94e5","updated":"2021-04-09 05:04:42.000000000","message":"Thanks for advise, changed to InvalidIpAddr.","commit_id":"98ddf9e914625a37c005023a2a145196282c708a"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"3780b1e3b74dcc2a1a9c6a2cc88960c966bfdfbd","unresolved":true,"context_lines":[{"line_number":1582,"context_line":"                                                        ip_addr).version)"},{"line_number":1583,"context_line":"                                        except ValueError:"},{"line_number":1584,"context_line":"                                            LOG.error(\"Invalid ip address %s\""},{"line_number":1585,"context_line":"                                                \"in resource %s.\","},{"line_number":1586,"context_line":"                                                ip_addr, vnfc_rsc.id)"},{"line_number":1587,"context_line":"                                            raise exceptions.InvalidIpAddr("},{"line_number":1588,"context_line":"                                                id\u003dvnfc_rsc.id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"45255bf8_79f0be36","line":1585,"range":{"start_line":1585,"start_character":49,"end_line":1585,"end_character":51},"updated":"2021-04-09 05:04:33.000000000","message":"White space is required before `in` as my suggestion.","commit_id":"32d31a233a4e29d9dba8b85c254ecd7ad5d0cef9"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"302ff99fd4efc9d149ed85bbf685752eb42ce49b","unresolved":false,"context_lines":[{"line_number":1582,"context_line":"                                                        ip_addr).version)"},{"line_number":1583,"context_line":"                                        except ValueError:"},{"line_number":1584,"context_line":"                                            LOG.error(\"Invalid ip address %s\""},{"line_number":1585,"context_line":"                                                \"in resource %s.\","},{"line_number":1586,"context_line":"                                                ip_addr, vnfc_rsc.id)"},{"line_number":1587,"context_line":"                                            raise exceptions.InvalidIpAddr("},{"line_number":1588,"context_line":"                                                id\u003dvnfc_rsc.id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3bed101c_7d1d7a5c","line":1585,"range":{"start_line":1585,"start_character":49,"end_line":1585,"end_character":51},"in_reply_to":"45255bf8_79f0be36","updated":"2021-04-09 05:32:38.000000000","message":"Sorry for the careless..","commit_id":"32d31a233a4e29d9dba8b85c254ecd7ad5d0cef9"}]}