)]}'
{"id":"openstack%2Ftacker~785530","triplet_id":"openstack%2Ftacker~stable%2Fwallaby~I9f918ceff9882da1bff4b1cc953602a3b84aec0c","project":"openstack/tacker","branch":"stable/wallaby","topic":"bp/cnf-support-with-etsi-nfv-specs","hashtags":[],"change_id":"I9f918ceff9882da1bff4b1cc953602a3b84aec0c","subject":"Fix methods of kubernetes_mgmt by change of abstract driver","status":"MERGED","created":"2021-04-08 23:03:45.000000000","updated":"2021-04-09 06:44:58.000000000","submitted":"2021-04-09 06:42:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"785530-bp/cnf-support-with-etsi-nfv-specs","meta_rev_id":"6f8949077952e32bd0524b3d680aeb39edf02e0f","_number":785530,"virtual_id_number":785530,"owner":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-09 06:41:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"all":[{"value":2,"date":"2021-04-09 05:34:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":2,"date":"2021-04-09 06:07:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"all":[{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":1,"date":"2021-04-09 06:07:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"reviewers":{"REVIEWER":[{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-08 23:03:45.000000000","updated_by":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"reviewer":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"state":"REVIEWER"},{"updated":"2021-04-08 23:14:21.000000000","updated_by":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2021-04-08 23:14:21.000000000","updated_by":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2021-04-08 23:14:21.000000000","updated_by":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2021-04-08 23:14:21.000000000","updated_by":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2021-04-09 01:27:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cb789c5db5001cfdd07e30d98d32cfdd3ec3ba8e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"date":"2021-04-08 23:03:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a28640ddbbcc9baf9330628c4f3c94a13347fa90","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 01:27:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/10ba706e5e5243ac92ce9f3bb0176aa3 : SUCCESS in 7m 18s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/02ad3314c13f42128dd3b17f3fd48ace : SUCCESS in 17m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c489e0639f7f41e096dbce83968b2f0c : SUCCESS in 5m 54s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/06056bf1414046f6aea3d20ae4b8e985 : SUCCESS in 14m 00s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/df27a6b9984f41e7b601e065b9752223 : SUCCESS in 13m 38s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2715d3984a6842f2a28e363fc682b1f7 : SUCCESS in 15m 05s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ef94e4a3066243eda72b24017713094f : SUCCESS in 7m 14s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/43f4073f427c456faead6a180f827d39 : SUCCESS in 2h 12m 11s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/4a0f7cf956a44ab0886fc314fdb14adb : SUCCESS in 2h 08m 04s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/f1d05bde25de476aade83324fba16721 : SUCCESS in 1h 00m 37s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/238927b381ed444e951781d3b7d93787 : SUCCESS in 1h 21m 15s","accounts_in_message":[],"_revision_number":1},{"id":"fff50eb01b33f8d26956993d737d622dd6017c7b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"date":"2021-04-09 02:23:23.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"4dc40bb949c3e483eb2047df5916ebb83a771473","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 05:26:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/446b615aa6e747169cd44024bf5458f5 : SUCCESS in 8m 43s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dea8cea953c54115ba4750b8f353d6b3 : SUCCESS in 16m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2e1ecac484094d33804505f023210575 : SUCCESS in 5m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fbb2ebb729364cf898a405b260c842fb : SUCCESS in 15m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/658d0f31c11948bfb0e715d4178ad196 : SUCCESS in 14m 01s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5b74a52bc2da4bc98c63bc7993dcbfa2 : SUCCESS in 13m 35s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ded3fad1fdd0499eaf121696af8c2228 : SUCCESS in 8m 57s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/33d6a37b8e134af58e6424d99ef35e16 : SUCCESS in 1h 40m 35s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/41e0782712fb43aabcb85e41d71d7f50 : SUCCESS in 1h 56m 06s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/506baec8031644d59621c4d336ce4fdb : SUCCESS in 1h 28m 14s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/40f695377c614e6eb07223cf1ef542fa : SUCCESS in 1h 21m 43s","accounts_in_message":[],"_revision_number":2},{"id":"176b56604f2409891df40c99f8ae1bed0cbeefcc","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-04-09 05:34:06.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4e051f8c488be601f1cd1f27d54222e8541a396c","author":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"date":"2021-04-09 06:07:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bcac4ccea3dce75981cf96b572596bd36d9ca06b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 06:08:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"5df98160221916d18b21b5f7b6cb9dc323bc2c2a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 06:41:57.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6e4c78787290464dba5a9954c55e9aa2 : SUCCESS in 21m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/002c5c4bc8344933960a7ba59c457c2a : SUCCESS in 9m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ed1d08b18e634e39ad68756aee556512 : SUCCESS in 17m 12s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0febb82fb8af4d02b1abb616301d74b8 : SUCCESS in 16m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/269330ae5f394e25b520a21db020982e : SUCCESS in 8m 56s","accounts_in_message":[],"_revision_number":2},{"id":"cc639493b518485487c0f3611eaf796a23b9d3d8","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 06:42:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"6f8949077952e32bd0524b3d680aeb39edf02e0f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-09 06:44:58.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f7146182a0e4ff0b256c288ca58f71b : SUCCESS in 2m 15s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cfa7725b8bdc9ffe011ea5fc4e8acc8df92caa4b","revisions":{"4ba14c1c7bef3ebd374c23c611b9121635b2d97c":{"kind":"REWORK","_number":1,"created":"2021-04-08 23:03:45.000000000","uploader":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"ref":"refs/changes/30/785530/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/30/785530/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/30/785530/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/30/785530/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/30/785530/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/30/785530/1"}}},"commit":{"parents":[{"commit":"74543ee080b8ab47536ce9b046b919f3c17a36a7","subject":"Merge \"Support Placement Constraints for Grant\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/74543ee080b8ab47536ce9b046b919f3c17a36a7"}]}],"author":{"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","date":"2021-04-05 08:32:00.000000000","tz":480},"committer":{"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","date":"2021-04-08 23:03:23.000000000","tz":540},"subject":"Add new inherited methods for kubernetes_mgmt","message":"Add new inherited methods for kubernetes_mgmt\n\n2 new methods are added at last time merge of\nWallaby release in vnflcm_abstract_driver.py.\n  * change_external_connectivity_start()\n  * change_external_connectivity_end()\n(tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py#L88)\n\nIn kubernetes_mgmt.py,\n(sample/mgmt_drivers/kubernetes_mgmt.py)\nwe inherited VnflcmAbstractDriver thus we also\nneeded to implements these 2 methods here.\n\nDue to we don\u0027t have these interfaces here, I updated\nempty methods for clear runtime error.\n\nChange-Id: I9f918ceff9882da1bff4b1cc953602a3b84aec0c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4ba14c1c7bef3ebd374c23c611b9121635b2d97c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/4ba14c1c7bef3ebd374c23c611b9121635b2d97c"}]},"branch":"refs/heads/stable/wallaby"},"cfa7725b8bdc9ffe011ea5fc4e8acc8df92caa4b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-04-09 02:23:23.000000000","uploader":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"ref":"refs/changes/30/785530/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/30/785530/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/30/785530/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/30/785530/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/30/785530/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/30/785530/2"}}},"commit":{"parents":[{"commit":"74543ee080b8ab47536ce9b046b919f3c17a36a7","subject":"Merge \"Support Placement Constraints for Grant\" into stable/wallaby","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/74543ee080b8ab47536ce9b046b919f3c17a36a7"}]}],"author":{"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","date":"2021-04-05 08:32:00.000000000","tz":480},"committer":{"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","date":"2021-04-09 02:23:01.000000000","tz":0},"subject":"Fix methods of kubernetes_mgmt by change of abstract driver","message":"Fix methods of kubernetes_mgmt by change of abstract driver\n\n2 methods were added in vnflcm_abstract_driver.py\nin the patch [1].\n  * change_external_connectivity_start()\n  * change_external_connectivity_end()\n(tacker/vnfm/mgmt_drivers/vnflcm_abstract_driver.py#L88)\n\nIn kubernetes_mgmt.py,\n(sample/mgmt_drivers/kubernetes_mgmt.py)\nprovided as sample in Tacker, is broken\ndue to the lack of two abstract methods.\nThis patch fix this issue.\n\n[1] https://review.opendev.org/c/openstack/tacker/+/780213\n\nChange-Id: I9f918ceff9882da1bff4b1cc953602a3b84aec0c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/cfa7725b8bdc9ffe011ea5fc4e8acc8df92caa4b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/cfa7725b8bdc9ffe011ea5fc4e8acc8df92caa4b"}]},"branch":"refs/heads/stable/wallaby","description":"Edit commit message"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}