)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"8ab03f240a3b60d2fdb198f599faf5cf4a1b4ada","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroo Kitamura \u003chiroo.kitamura@ntt-at.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-10 10:24:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Provide fix for Anti Affinity verification Exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will fix the exception that occurs when editing Grant transmission"},{"line_number":10,"context_line":"data during Anti Affinity verification."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"8dce3764_19a3dd21","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2021-09-07 14:00:35.000000000","message":"The first line seems a little long. Could you make it shorter than 50 characters?\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"ce418327c018c654403d53bebf238526d28b842e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"604bd9fe4944cde789fb734cb330fd85ea6a5b54","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroo Kitamura \u003chiroo.kitamura@ntt-at.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-10 10:24:32 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Provide fix for Anti Affinity verification Exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will fix the exception that occurs when editing Grant transmission"},{"line_number":10,"context_line":"data during Anti Affinity verification."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5760dee1_7ea72fbd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"8dce3764_19a3dd21","updated":"2021-09-13 09:53:18.000000000","message":"I\u0027m sorry for the late corresponding.\nAs you pointed out, I fixed it.","commit_id":"ce418327c018c654403d53bebf238526d28b842e"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"62a4063941a5a363048c59605608fec5c63e7c8e","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"                    placement_constraint.fallback_best_effort \u003d True"},{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in topo_temp[\u0027groups\u0027][\u0027members\u0027]:"},{"line_number":1106,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1107,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1108,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"921d73c0_3abc003d","side":"PARENT","line":1105,"updated":"2021-04-28 01:39:56.000000000","message":"Looking at the tox-cover results below, it looks like this branch hasn\u0027t been tested, is that as expected?\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_53a/785592/2/check/openstack-tox-cover/53a3c3a/cover/tacker_conductor_conductor_server_py.html#t1105","commit_id":"2c68a0a84d2a62598b9379529008c2ae1c849ca6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6430567d07dcc7af9d28be1a309e0b327bc8457a","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"                    placement_constraint.fallback_best_effort \u003d True"},{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in topo_temp[\u0027groups\u0027][\u0027members\u0027]:"},{"line_number":1106,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1107,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1108,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f452d5f_41ff28b5","side":"PARENT","line":1105,"in_reply_to":"04a4a9ca_96bf0c5c","updated":"2021-06-24 04:44:07.000000000","message":"Please confirm this comment.","commit_id":"2c68a0a84d2a62598b9379529008c2ae1c849ca6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"5c0ae88b88239f8e1649856b525ebbbcdf039e78","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"                    placement_constraint.fallback_best_effort \u003d True"},{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in topo_temp[\u0027groups\u0027][\u0027members\u0027]:"},{"line_number":1106,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1107,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1108,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"04a4a9ca_96bf0c5c","side":"PARENT","line":1105,"in_reply_to":"4ba5a1d7_099e9820","updated":"2021-05-10 02:57:15.000000000","message":"Patchset-3 doesn\u0027t seem to improve either.\n\nhttps://6411f27413aeaeed863a-624a66b127421bb56fbada761a704171.ssl.cf5.rackcdn.com/785592/3/check/openstack-tox-cover/39b10d6/cover/tacker_conductor_conductor_server_py.html#t1105","commit_id":"2c68a0a84d2a62598b9379529008c2ae1c849ca6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"de0d50596b7cfafa5f83a659d1c60c1202087729","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"                    placement_constraint.fallback_best_effort \u003d True"},{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in topo_temp[\u0027groups\u0027][\u0027members\u0027]:"},{"line_number":1106,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1107,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1108,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe11a13c_7fa2705a","side":"PARENT","line":1105,"in_reply_to":"7f452d5f_41ff28b5","updated":"2021-06-30 07:00:31.000000000","message":"I fixed \"test_instantiate_grant\" in patchset-4.\nI\u0027ve confirmed that the \"test_instantiate_grant\" test passes, but I can\u0027t see the coverage information, either because of a problem with Zuul.\nI would like to close this comment as soon as I can confirm it.","commit_id":"2c68a0a84d2a62598b9379529008c2ae1c849ca6"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"8b25222e0e88893b9042d6b4e27cdaf757bb0e69","unresolved":true,"context_lines":[{"line_number":1102,"context_line":"                    placement_constraint.fallback_best_effort \u003d True"},{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in topo_temp[\u0027groups\u0027][\u0027members\u0027]:"},{"line_number":1106,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1107,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1108,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"4ba5a1d7_099e9820","side":"PARENT","line":1105,"in_reply_to":"921d73c0_3abc003d","updated":"2021-05-07 02:24:15.000000000","message":"\u003e Looking at the tox-cover results below, it looks like this branch hasn\u0027t been tested, is that as expected?\n\u003e \n\u003e https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_53a/785592/2/check/openstack-tox-cover/53a3c3a/cover/tacker_conductor_conductor_server_py.html#t1105\n\nUpdated tacker/tests/unit/db/utils.py (from line 229) for this comment.","commit_id":"2c68a0a84d2a62598b9379529008c2ae1c849ca6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6aea619af72cc8dd21ce4e69b184664459d9c658","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"                    placement_constraint.fallback_best_effort \u003d True"},{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in topo_temp[\u0027groups\u0027][\u0027members\u0027]:"},{"line_number":1106,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1107,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1108,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"3cfe3089_4225c453","side":"PARENT","line":1105,"in_reply_to":"fe11a13c_7fa2705a","updated":"2021-07-14 05:10:32.000000000","message":"https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_74e/785592/6/check/openstack-tox-cover/74e4133/cover/tacker_conductor_conductor_server_py.html#t1105\nI\u0027ve confirmed on the above result.","commit_id":"2c68a0a84d2a62598b9379529008c2ae1c849ca6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"9067eb26ec3febe6cf90799f8aba3490c9b633e1","unresolved":true,"context_lines":[{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in (topo_temp[\u0027groups\u0027][target]"},{"line_number":1106,"context_line":"                                    [\u0027members\u0027]):"},{"line_number":1107,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1108,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1109,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"89774475_58986e8b","line":1106,"updated":"2021-05-13 07:17:35.000000000","message":"Is it possible to update the VNF Package of an existing FT to see the perspective of this bug?","commit_id":"0cd17282ab91c30b924549310283db06bb59a8c6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"8f3153b3ff4ebc2a0a0ed0a04a3c28133503a875","unresolved":true,"context_lines":[{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in (topo_temp[\u0027groups\u0027][target]"},{"line_number":1106,"context_line":"                                    [\u0027members\u0027]):"},{"line_number":1107,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1108,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1109,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"beeebd4e_172610be","line":1106,"in_reply_to":"7bf9e173_bdc0d2f7","updated":"2021-06-28 04:28:50.000000000","message":"https://review.opendev.org/c/openstack/tacker/+/785592/2/tacker/conductor/conductor_server.py#b1105\nAs I commented above, there seems to be a flaw in \"test_instantiate_grant\" and I don\u0027t think the expected test has been run.\nPlease confirm it.","commit_id":"0cd17282ab91c30b924549310283db06bb59a8c6"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"86ba7ed9e9d7dfd1eebc8061db2f9d98d55ad036","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in (topo_temp[\u0027groups\u0027][target]"},{"line_number":1106,"context_line":"                                    [\u0027members\u0027]):"},{"line_number":1107,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1108,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1109,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"8d72abea_01715855","line":1106,"in_reply_to":"89774475_58986e8b","updated":"2021-06-22 10:11:50.000000000","message":"As per the current FT code the perspective of this bug is not covered even after update in VNF package.","commit_id":"0cd17282ab91c30b924549310283db06bb59a8c6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"6430567d07dcc7af9d28be1a309e0b327bc8457a","unresolved":true,"context_lines":[{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in (topo_temp[\u0027groups\u0027][target]"},{"line_number":1106,"context_line":"                                    [\u0027members\u0027]):"},{"line_number":1107,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1108,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1109,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"ae10c728_715dfe2b","line":1106,"in_reply_to":"8d72abea_01715855","updated":"2021-06-24 04:44:07.000000000","message":"If it\u0027s not covered by an existing FT, I think you should fix the FT code in addition to updating the VNF Package.\nIf it\u0027s difficult, I think you should test that can detect this bug in UT instead of FT.","commit_id":"0cd17282ab91c30b924549310283db06bb59a8c6"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"cfbed94b6d2046fc0a05bbfb1e8040543de970c9","unresolved":true,"context_lines":[{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in (topo_temp[\u0027groups\u0027][target]"},{"line_number":1106,"context_line":"                                    [\u0027members\u0027]):"},{"line_number":1107,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1108,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1109,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"7bf9e173_bdc0d2f7","line":1106,"in_reply_to":"ae10c728_715dfe2b","updated":"2021-06-25 11:17:43.000000000","message":"This is covered in new UT function \"test_instantiate_grant\"\nin tacker/tests/unit/conductor/test_conductor_server.py\"\"","commit_id":"0cd17282ab91c30b924549310283db06bb59a8c6"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"de0d50596b7cfafa5f83a659d1c60c1202087729","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"                    for target in policy_dict.get(\u0027targets\u0027, []):"},{"line_number":1104,"context_line":"                        if target in topo_temp.get(\u0027groups\u0027, []):"},{"line_number":1105,"context_line":"                            for member in (topo_temp[\u0027groups\u0027][target]"},{"line_number":1106,"context_line":"                                    [\u0027members\u0027]):"},{"line_number":1107,"context_line":"                                for vnfc_rsc in vnf_inf.vnfc_resource_info:"},{"line_number":1108,"context_line":"                                    if member \u003d\u003d vnfc_rsc.vdu_id:"},{"line_number":1109,"context_line":"                                        resource \u003d \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd789aec_2d8d34cc","line":1106,"in_reply_to":"beeebd4e_172610be","updated":"2021-06-30 07:00:31.000000000","message":"Supported by L1105.","commit_id":"0cd17282ab91c30b924549310283db06bb59a8c6"}],"tacker/tests/unit/db/utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"3a28b7d7cc75c7479a8c8082434c58bc913b5eff","unresolved":true,"context_lines":[{"line_number":225,"context_line":"def get_dummy_vnf_etsi(status\u003d\u0027PENDING_CREATE\u0027, scaling_group\u003dFalse,"},{"line_number":226,"context_line":"                       instance_id\u003dNone, flavour\u003d\u0027Simple\u0027, vnfd_name\u003dNone):"},{"line_number":227,"context_line":"    vnfd_key \u003d \u0027vnfd_\u0027 + flavour"},{"line_number":228,"context_line":"    if not vnfd_name:"},{"line_number":229,"context_line":"        dummy_vnf \u003d {\u0027status\u0027: status, \u0027instance_id\u0027: instance_id, \u0027name\u0027:"},{"line_number":230,"context_line":"            \u0027test_openwrt\u0027, \u0027tenant_id\u0027: \u0027ad7ebc56538745a08ef7c5e97f8bd437\u0027,"},{"line_number":231,"context_line":"            \u0027vnfd_id\u0027: \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"49e813a6_1070dc51","line":228,"updated":"2021-07-27 16:03:18.000000000","message":"Could you give a comment describing the difference between this `if` and `else` because it\u0027s a waste of time to understand by reading each of raw `dummy_vnf`s. It\u0027s helpful if you give the short note for the difference.","commit_id":"0dce27d76162ba8632d5391b5602468f3719829f"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dfd598b48c83b870bea110074d0ebe8761b0048e","unresolved":true,"context_lines":[{"line_number":225,"context_line":"def get_dummy_vnf_etsi(status\u003d\u0027PENDING_CREATE\u0027, scaling_group\u003dFalse,"},{"line_number":226,"context_line":"                       instance_id\u003dNone, flavour\u003d\u0027Simple\u0027, vnfd_name\u003dNone):"},{"line_number":227,"context_line":"    vnfd_key \u003d \u0027vnfd_\u0027 + flavour"},{"line_number":228,"context_line":"    if not vnfd_name:"},{"line_number":229,"context_line":"        dummy_vnf \u003d {\u0027status\u0027: status, \u0027instance_id\u0027: instance_id, \u0027name\u0027:"},{"line_number":230,"context_line":"            \u0027test_openwrt\u0027, \u0027tenant_id\u0027: \u0027ad7ebc56538745a08ef7c5e97f8bd437\u0027,"},{"line_number":231,"context_line":"            \u0027vnfd_id\u0027: \u0027eb094833-995e-49f0-a047-dfb56aaf7c4e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c16e7f76_45c197ba","line":228,"in_reply_to":"49e813a6_1070dc51","updated":"2021-08-10 01:24:13.000000000","message":"I added comments.\nIn addition, I commonized the setting of `dummy_vnf` to clarify the difference.","commit_id":"0dce27d76162ba8632d5391b5602468f3719829f"}],"tacker/tests/unit/vnfm/infra_drivers/openstack/data/etsi_nfv/tosca_vnfd_group_member.yaml":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"925bf6b1048b4d2c333bac52b5eea419993487a3","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      artifacts:"},{"line_number":32,"context_line":"        sw_image:"},{"line_number":33,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":34,"context_line":"          file: Files/images/cirros-0.4.0-x86_64-disk.img"},{"line_number":35,"context_line":"      capabilities:"},{"line_number":36,"context_line":"        virtual_compute:"},{"line_number":37,"context_line":"          properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1d855164_30d1ce8a","line":34,"range":{"start_line":34,"start_character":36,"end_line":34,"end_character":41},"updated":"2021-08-19 07:00:14.000000000","message":"With reference to https://review.opendev.org/c/openstack/tacker/+/798781, could we update version of cirros image to 0.5.2.","commit_id":"ce418327c018c654403d53bebf238526d28b842e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"f9510f97175441c85d2ffe001593d041c1d6ff92","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      artifacts:"},{"line_number":32,"context_line":"        sw_image:"},{"line_number":33,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":34,"context_line":"          file: Files/images/cirros-0.4.0-x86_64-disk.img"},{"line_number":35,"context_line":"      capabilities:"},{"line_number":36,"context_line":"        virtual_compute:"},{"line_number":37,"context_line":"          properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"acb70572_6120523b","line":34,"range":{"start_line":34,"start_character":36,"end_line":34,"end_character":41},"in_reply_to":"1d855164_30d1ce8a","updated":"2021-08-20 10:16:09.000000000","message":"Thank you for your comment, I agree with your suggestion.\nBut all of other unittest uses 0.4.0, so I think it\u0027s better to use 0.4.0 to be consistent.\nAnd I think it\u0027s better to fix it all at once with another new patch.\nWhat do you think?","commit_id":"ce418327c018c654403d53bebf238526d28b842e"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"0016a13f1fa1917464c4d44e34ebaae735d4161b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      artifacts:"},{"line_number":32,"context_line":"        sw_image:"},{"line_number":33,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":34,"context_line":"          file: Files/images/cirros-0.4.0-x86_64-disk.img"},{"line_number":35,"context_line":"      capabilities:"},{"line_number":36,"context_line":"        virtual_compute:"},{"line_number":37,"context_line":"          properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"eee8818d_71bd764e","line":34,"range":{"start_line":34,"start_character":36,"end_line":34,"end_character":41},"in_reply_to":"2defab44_0fe3d6c9","updated":"2021-09-14 02:21:15.000000000","message":"Unfortunately, update for cirros-0.5.2 was merged before this patch unfortunately. So, It also should be updated as Manpreet suggested.","commit_id":"ce418327c018c654403d53bebf238526d28b842e"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"cc121e923948383d7f4245b0477c2a67322d824f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      artifacts:"},{"line_number":32,"context_line":"        sw_image:"},{"line_number":33,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":34,"context_line":"          file: Files/images/cirros-0.4.0-x86_64-disk.img"},{"line_number":35,"context_line":"      capabilities:"},{"line_number":36,"context_line":"        virtual_compute:"},{"line_number":37,"context_line":"          properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"2defab44_0fe3d6c9","line":34,"range":{"start_line":34,"start_character":36,"end_line":34,"end_character":41},"in_reply_to":"acb70572_6120523b","updated":"2021-08-20 13:40:11.000000000","message":"Totally agree with your point, yes we could incorporate suggested changes in separate patch.","commit_id":"ce418327c018c654403d53bebf238526d28b842e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c68916dc46349d9b965c0c8226fc567611a64f3e","unresolved":true,"context_lines":[{"line_number":31,"context_line":"      artifacts:"},{"line_number":32,"context_line":"        sw_image:"},{"line_number":33,"context_line":"          type: tosca.artifacts.nfv.SwImage"},{"line_number":34,"context_line":"          file: Files/images/cirros-0.4.0-x86_64-disk.img"},{"line_number":35,"context_line":"      capabilities:"},{"line_number":36,"context_line":"        virtual_compute:"},{"line_number":37,"context_line":"          properties:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8b3f5e13_6a70db47","line":34,"range":{"start_line":34,"start_character":36,"end_line":34,"end_character":41},"in_reply_to":"eee8818d_71bd764e","updated":"2021-09-14 09:06:23.000000000","message":"I see. I fixed as suggested.","commit_id":"ce418327c018c654403d53bebf238526d28b842e"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1eb188a1d757fef4836a7ec8864486d905eb5964","unresolved":true,"context_lines":[{"line_number":20,"context_line":"          max_number_of_instances: 1"},{"line_number":21,"context_line":"        sw_image_data:"},{"line_number":22,"context_line":"          name: Software of VDU1"},{"line_number":23,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":24,"context_line":"          checksum:"},{"line_number":25,"context_line":"            algorithm: sha-256"},{"line_number":26,"context_line":"            hash: b9c3036539fd7a5f87a1bf38eb05fdde8b556a1a7e664dbeda90ed3cd74b4f9d"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3e3bb95a_189c0274","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":26},"updated":"2021-09-14 13:29:06.000000000","message":"Could you change version to 0.5.2?","commit_id":"59c80b5afb30bd43faaeefb7d347223da4c8bc95"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7aee3ad1e2c9518ee82a9285548c20623c29ca93","unresolved":false,"context_lines":[{"line_number":20,"context_line":"          max_number_of_instances: 1"},{"line_number":21,"context_line":"        sw_image_data:"},{"line_number":22,"context_line":"          name: Software of VDU1"},{"line_number":23,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":24,"context_line":"          checksum:"},{"line_number":25,"context_line":"            algorithm: sha-256"},{"line_number":26,"context_line":"            hash: b9c3036539fd7a5f87a1bf38eb05fdde8b556a1a7e664dbeda90ed3cd74b4f9d"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"18b168a3_0384c261","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":26},"in_reply_to":"03ddd19c_8260ddaf","updated":"2021-09-15 09:44:24.000000000","message":"I\u0027ve confirmed.","commit_id":"59c80b5afb30bd43faaeefb7d347223da4c8bc95"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"230bfef826b99af7bcfcd935b23e39711f9daef0","unresolved":true,"context_lines":[{"line_number":20,"context_line":"          max_number_of_instances: 1"},{"line_number":21,"context_line":"        sw_image_data:"},{"line_number":22,"context_line":"          name: Software of VDU1"},{"line_number":23,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":24,"context_line":"          checksum:"},{"line_number":25,"context_line":"            algorithm: sha-256"},{"line_number":26,"context_line":"            hash: b9c3036539fd7a5f87a1bf38eb05fdde8b556a1a7e664dbeda90ed3cd74b4f9d"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"03ddd19c_8260ddaf","line":23,"range":{"start_line":23,"start_character":19,"end_line":23,"end_character":26},"in_reply_to":"3e3bb95a_189c0274","updated":"2021-09-15 04:35:40.000000000","message":"I fixed as suggested.","commit_id":"59c80b5afb30bd43faaeefb7d347223da4c8bc95"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1eb188a1d757fef4836a7ec8864486d905eb5964","unresolved":true,"context_lines":[{"line_number":23,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":24,"context_line":"          checksum:"},{"line_number":25,"context_line":"            algorithm: sha-256"},{"line_number":26,"context_line":"            hash: b9c3036539fd7a5f87a1bf38eb05fdde8b556a1a7e664dbeda90ed3cd74b4f9d"},{"line_number":27,"context_line":"          container_format: bare"},{"line_number":28,"context_line":"          disk_format: qcow2"},{"line_number":29,"context_line":"          min_disk: 1 GiB"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"24717af3_63d7c6ea","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":82},"updated":"2021-09-14 13:29:06.000000000","message":"I think you should change hash value too like merged patch.\n\nhttps://review.opendev.org/c/openstack/tacker/+/798781/16/tacker/tests/etc/samples/etsi/nfv/common_artifact/Definitions/helloworld3_df_simple.yaml#141","commit_id":"59c80b5afb30bd43faaeefb7d347223da4c8bc95"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7aee3ad1e2c9518ee82a9285548c20623c29ca93","unresolved":false,"context_lines":[{"line_number":23,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":24,"context_line":"          checksum:"},{"line_number":25,"context_line":"            algorithm: sha-256"},{"line_number":26,"context_line":"            hash: b9c3036539fd7a5f87a1bf38eb05fdde8b556a1a7e664dbeda90ed3cd74b4f9d"},{"line_number":27,"context_line":"          container_format: bare"},{"line_number":28,"context_line":"          disk_format: qcow2"},{"line_number":29,"context_line":"          min_disk: 1 GiB"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"511720b3_b9a49364","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":82},"in_reply_to":"16f6d389_0478228e","updated":"2021-09-15 09:44:24.000000000","message":"I\u0027ve confirmed.","commit_id":"59c80b5afb30bd43faaeefb7d347223da4c8bc95"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"230bfef826b99af7bcfcd935b23e39711f9daef0","unresolved":true,"context_lines":[{"line_number":23,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":24,"context_line":"          checksum:"},{"line_number":25,"context_line":"            algorithm: sha-256"},{"line_number":26,"context_line":"            hash: b9c3036539fd7a5f87a1bf38eb05fdde8b556a1a7e664dbeda90ed3cd74b4f9d"},{"line_number":27,"context_line":"          container_format: bare"},{"line_number":28,"context_line":"          disk_format: qcow2"},{"line_number":29,"context_line":"          min_disk: 1 GiB"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"16f6d389_0478228e","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":82},"in_reply_to":"24717af3_63d7c6ea","updated":"2021-09-15 04:35:40.000000000","message":"I fixed as suggested.","commit_id":"59c80b5afb30bd43faaeefb7d347223da4c8bc95"}]}