)]}'
{"id":"openstack%2Ftacker~785999","triplet_id":"openstack%2Ftacker~master~I2bf567a0367659c170af0b618374a51d0f13eece","project":"openstack/tacker","branch":"master","topic":"bug/1923528","hashtags":[],"change_id":"I2bf567a0367659c170af0b618374a51d0f13eece","subject":"Fix two-stage process launcher in tacker-server","status":"MERGED","created":"2021-04-13 01:45:13.000000000","updated":"2021-05-06 07:07:04.000000000","submitted":"2021-05-06 07:05:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"785999-bug/1923528","meta_rev_id":"e7e2c4edc9fef4fe29dc10d184a497b57e137942","_number":785999,"virtual_id_number":785999,"owner":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-06 07:05:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"recommended":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"all":[{"value":1,"date":"2021-05-06 01:35:30.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"value":2,"date":"2021-04-24 18:58:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-04-25 05:38:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":2,"date":"2021-05-06 06:46:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"all":[{"value":0,"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":1,"date":"2021-05-06 06:46:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"}],"reviewers":{"REVIEWER":[{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}],"CC":[{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-13 01:51:04.000000000","updated_by":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"reviewer":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"state":"REVIEWER"},{"updated":"2021-04-13 01:51:04.000000000","updated_by":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2021-04-13 03:58:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-15 01:42:55.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":26588,"name":"Hiroyuki Jo","email":"joxyuki@gmail.com","username":"joxyuki"},"state":"REVIEWER"},{"updated":"2021-04-15 01:42:55.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2021-04-15 01:42:55.000000000","updated_by":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2021-04-21 06:49:16.000000000","updated_by":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"reviewer":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"state":"CC"},{"updated":"2021-04-25 05:38:46.000000000","updated_by":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"reviewer":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"state":"REVIEWER"},{"updated":"2021-05-06 01:35:30.000000000","updated_by":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"reviewer":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"state":"REVIEWER"}],"messages":[{"id":"ef7ef00e06c5a765ba47eb1d30058fe84b8b6797","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2021-04-13 01:45:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69ca7ffdab581be429164681656116a002159236","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-13 03:58:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/971698a3801a474390fda9bc951df546 : SUCCESS in 8m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ee931bdd1ac048a8b4707c2c5d34cd2f : SUCCESS in 16m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/137b4c2eafaf496cbc4eb335bc56613a : SUCCESS in 5m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/655b637b90554bd6942840c68cb61a9f : SUCCESS in 14m 26s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/49be3b3554d645c281071c8575406488 : SUCCESS in 14m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/720048ac64fe44d087ae677c3b5f962f : SUCCESS in 14m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/624d720a03784210a4c6b7a5f5fa7fe7 : SUCCESS in 7m 59s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/cc727671b1e04718a7ebc711cdf73a79 : SUCCESS in 1h 49m 37s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/56c794335bae4a2a86da5cd56867ce5b : SUCCESS in 2h 03m 38s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/250ced480a6f4053a6128e467e5baab6 : SUCCESS in 1h 15m 24s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/d6dd025925564344913b611729438841 : SUCCESS in 1h 22m 27s","accounts_in_message":[],"_revision_number":1},{"id":"7bec2fe9ba7053eb1e7148635713c12ab76b52ff","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-04-14 14:39:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"926b9078ec364bd789491bc77b788923a93d7806","author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"date":"2021-04-21 06:49:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ce0e84c10e1e768e8df4a1625ffb2c37fb527fcc","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2021-04-21 11:20:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1be074ea6ca440fc4323fae4817999ee18c1bc1d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2021-04-23 00:34:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a627e78aa1ac7cec68903051c270c6666881f389","author":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"date":"2021-04-23 00:35:17.000000000","message":"Patch Set 2:\n\nRebased + comments updated.","accounts_in_message":[],"_revision_number":2},{"id":"4eb5f213a8edb8f0545086ce051d8de9d4fb189b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-23 02:39:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/babc9e84399a4d5e8ce83cec34df0d54 : SUCCESS in 10m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5c88fefd09d54007a02758e20f95ad7a : SUCCESS in 18m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a927eb6f194546ebaa6fb0dee486bbc5 : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2c05baa5353345a4973e9fb1d2fbcf89 : SUCCESS in 13m 45s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9d3486f3d14f4f179d5c756c2a209bbe : SUCCESS in 12m 59s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d2c1f1b42e144e09a07b6cd3c2f00d0e : SUCCESS in 13m 24s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7e65344969be481caf69b0167217927c : SUCCESS in 6m 28s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/934e14804d1846169916b1d8f60ffcc0 : SUCCESS in 1h 31m 03s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/6dbb6de73e1749bc8daf283db052889c : SUCCESS in 1h 59m 56s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/b12d5584108e45c5a3f4e90a0b27cea2 : SUCCESS in 1h 00m 06s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/8bd5e26efd9d4a348870a34f2d68260a : SUCCESS in 1h 09m 34s","accounts_in_message":[],"_revision_number":2},{"id":"eab310b4ae65849a677bfae54517231410d102b2","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-04-24 18:58:11.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"410bb21eca995d6698abd2d2db8242c379e35e39","author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"date":"2021-04-25 05:38:46.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b3b92f7da338323658f8fd22ed8ba2e03feabb86","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2021-05-06 01:35:30.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"eb8e96458a8541e1845c3d3c0bda26f8b4d978e6","author":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"date":"2021-05-06 06:46:52.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bac4bcfc7fcf42f3300f7aee18b2c57479ee250a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-06 06:47:07.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"3701bfffdc39bf3aae1217478a7854b43ab22d52","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-06 07:05:47.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ae0327e7396a48c79645283e63d85134 : SUCCESS in 17m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e5cde540d4624a1c9f2c0f6236b3b3a6 : SUCCESS in 7m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dbc2f9c6515e40faa586cfee79d16baf : SUCCESS in 16m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6f8fcb85ceab44e0aa1824ec349b0851 : SUCCESS in 15m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cbf71f59fe1740e481ee7061d5827416 : SUCCESS in 8m 18s","accounts_in_message":[],"_revision_number":2},{"id":"83e3a45076f26a6101a324a39b40c46c3a561ac0","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-06 07:05:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"e7e2c4edc9fef4fe29dc10d184a497b57e137942","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-06 07:07:04.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7667eb971ec648b195c9b11e590e8ad8 : SUCCESS in 55s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c1b2c362f085be5f16bd6567d408892fa0205396","revisions":{"6b5d1e6de18c771e33e0da9e2be32c831d1eddde":{"kind":"REWORK","_number":1,"created":"2021-04-13 01:45:13.000000000","uploader":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"ref":"refs/changes/99/785999/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/99/785999/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/99/785999/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/99/785999/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/99/785999/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/99/785999/1"}}},"commit":{"parents":[{"commit":"aabe8981c4690129c7d8f7a96644beff03c39b03","subject":"Merge \"Fix display bugs of vnflcm show command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/aabe8981c4690129c7d8f7a96644beff03c39b03"}]}],"author":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2021-04-13 01:38:10.000000000","tz":540},"committer":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2021-04-13 01:38:10.000000000","tz":540},"subject":"Fix two-stage process launcher in tacker-server","message":"Fix two-stage process launcher in tacker-server\n\ntacker-server has got two-stage process launcher since long time ago.\nWhile it doesn\u0027t matter if {api_workers} is set to one or unset,\nwhich is the case by default on installation via devstack, it should\nhave resulted in an odd situation in other cases as follows:\n\n1). surprisingly the num of workers is not {api_workers} but\n    {api_workers}*{api_workers}. Notice that the launcher process\n    should be present so the resulting number of tacker-server\n    processes is 1+{api_workers}*({api_workers}+1).\n\n2). GreenPool is per the second stage launcher. That means {api_workers}\n    number of workers, each of which is a green thread on a seperate\n    process (spawned by ProcessLauncher), share the same pool. There are\n    no pros of having {api_workers} such groups.\n\nThis patch fixes it.\n\nCloses-Bug: #1923528\nChange-Id: I2bf567a0367659c170af0b618374a51d0f13eece\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/6b5d1e6de18c771e33e0da9e2be32c831d1eddde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/6b5d1e6de18c771e33e0da9e2be32c831d1eddde"}]},"branch":"refs/heads/master"},"c1b2c362f085be5f16bd6567d408892fa0205396":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2021-04-23 00:34:14.000000000","uploader":{"_account_id":32395,"name":"Koichiro Den","email":"koichiro.den@gmail.com","username":"kden"},"ref":"refs/changes/99/785999/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/99/785999/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/99/785999/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/99/785999/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/99/785999/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/99/785999/2"}}},"commit":{"parents":[{"commit":"c137b0ddfe10bd7b9ace0b94460e091d0d7f5ec6","subject":"Add endpoint information in interfaceInfo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c137b0ddfe10bd7b9ace0b94460e091d0d7f5ec6"}]}],"author":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2021-04-13 01:38:10.000000000","tz":540},"committer":{"name":"Koichiro Den","email":"den@valinux.co.jp","date":"2021-04-23 00:33:49.000000000","tz":540},"subject":"Fix two-stage process launcher in tacker-server","message":"Fix two-stage process launcher in tacker-server\n\ntacker-server has got two-stage process launcher since a long time ago.\nWhile it doesn\u0027t matter if {api_workers} is set to one or unset, which\nis the case by default on installation via devstack, it should have\nresulted in an odd situation in other cases as follows:\n\n1). surprisingly the number of workers was not {api_workers} but\n    {api_workers}*{api_workers}. Notice that the launcher processes are\n    also present so the resulting number of tacker-server processes was\n    1+{api_workers}*({api_workers}+1).\n\n    E.g., when {api_workers}\u003d100, the number of tacker-server processes\n    is 10101.\n\n2). GreenPool is per the second stage launcher. That means {api_workers}\n    number of workers, each of which is a green thread on a seperate\n    process (spawned by ProcessLauncher), share the same pool. It means\n    that the second stage launcher does not only fail to provide\n    performance scaling, but also more likely to unnecessarily keep some\n    workers starved due to a process which starts sleeping before\n    yielding.\n\nThis patch fixes it so that there is just a one-stage launcher.\n\n    [Before this patch]\n        master\n          ├── worker#0 # second-stage launcher\n          │   ├── worker#0-0 (*1)\n          │   ├── worker#0-1 (*1)\n          │   :\n          │   └── worker#0-{api_workers-1} (*1)\n          ├── worker#1 # second-stage launcher\n          :\n          └── worker#{api_workers-1}\n              :\n              └── worker#{api_workers-1}-{api_workers-1} (*1)\n\n    [After this patch]\n        master\n          ├── worker#0 (*1)\n          ├── worker#1 (*1)\n          :\n          └── worker#{api_workers-1} (*1)\n\n    (*1) spawns one green thread at the start.\n\nCloses-Bug: #1923528\nChange-Id: I2bf567a0367659c170af0b618374a51d0f13eece\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c1b2c362f085be5f16bd6567d408892fa0205396"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c1b2c362f085be5f16bd6567d408892fa0205396"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
