)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f3767c6d21b79bc9c345775bcbd16e958b2b9ed7","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will change the proccessing of Placement Constraints"},{"line_number":10,"context_line":"from VDU name to Aspect Definition. There is also an error in the"},{"line_number":11,"context_line":"judgment logic when setting Availavility_zone information from"},{"line_number":12,"context_line":"the Zone information of GrantRes, so the judgment logic is also"},{"line_number":13,"context_line":"fixed."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b38f9268_498a738e","line":11,"range":{"start_line":11,"start_character":34,"end_line":11,"end_character":35},"updated":"2021-05-06 06:30:11.000000000","message":"typo. `Availability_zone` is correct.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"425c9793fcdfd394432f05601ca37a81ccef647d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will change the proccessing of Placement Constraints"},{"line_number":10,"context_line":"from VDU name to Aspect Definition. There is also an error in the"},{"line_number":11,"context_line":"judgment logic when setting Availavility_zone information from"},{"line_number":12,"context_line":"the Zone information of GrantRes, so the judgment logic is also"},{"line_number":13,"context_line":"fixed."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b7a9f9bd_4db107d1","line":11,"range":{"start_line":11,"start_character":34,"end_line":11,"end_character":35},"in_reply_to":"0198ddb9_ca700bf8","updated":"2021-05-06 08:50:34.000000000","message":"Thanks! I have confirmed.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b32e7264d693875c393556288df9d5de56321db","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will change the proccessing of Placement Constraints"},{"line_number":10,"context_line":"from VDU name to Aspect Definition. There is also an error in the"},{"line_number":11,"context_line":"judgment logic when setting Availavility_zone information from"},{"line_number":12,"context_line":"the Zone information of GrantRes, so the judgment logic is also"},{"line_number":13,"context_line":"fixed."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0198ddb9_ca700bf8","line":11,"range":{"start_line":11,"start_character":34,"end_line":11,"end_character":35},"in_reply_to":"b38f9268_498a738e","updated":"2021-05-06 08:35:42.000000000","message":"\u003e typo. `Availability_zone` is correct.\n\nIt is corrected.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"}],"tacker/tests/etc/samples/etsi/nfv/functional6/BaseHOT/simple/helloworld3.yaml":[{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    type: json"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  VDU1_scale_group:"},{"line_number":10,"context_line":"    type: OS::Heat::AutoScalingGroup"},{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a0245fce_4fd22f44","line":9,"updated":"2021-09-13 08:15:56.000000000","message":"The \u0027_group\u0027 rule has removed in this patch https://review.opendev.org/c/openstack/tacker/+/787779.\nSo I think you should removed \u0027_group\u0027.\nIt should be \u0027VDU1_scale\u0027.","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    type: json"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"resources:"},{"line_number":9,"context_line":"  VDU1_scale_group:"},{"line_number":10,"context_line":"    type: OS::Heat::AutoScalingGroup"},{"line_number":11,"context_line":"    properties:"},{"line_number":12,"context_line":"      min_size: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a67475ff_d17d4f13","line":9,"in_reply_to":"a0245fce_4fd22f44","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    properties:"},{"line_number":30,"context_line":"      scaling_adjustment: 1"},{"line_number":31,"context_line":"      auto_scaling_group_id:"},{"line_number":32,"context_line":"        get_resource: VDU1_scale_group"},{"line_number":33,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":34,"context_line":"  VDU1_scale_scale_in:"},{"line_number":35,"context_line":"    type: OS::Heat::ScalingPolicy"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"56ec6727_01a17351","line":32,"updated":"2021-09-13 08:15:56.000000000","message":"ditto.","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    properties:"},{"line_number":30,"context_line":"      scaling_adjustment: 1"},{"line_number":31,"context_line":"      auto_scaling_group_id:"},{"line_number":32,"context_line":"        get_resource: VDU1_scale_group"},{"line_number":33,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":34,"context_line":"  VDU1_scale_scale_in:"},{"line_number":35,"context_line":"    type: OS::Heat::ScalingPolicy"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8b855fcb_0de90bbd","line":32,"in_reply_to":"56ec6727_01a17351","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      scaling_adjustment: -1"},{"line_number":38,"context_line":"      auto_scaling_group_id:"},{"line_number":39,"context_line":"        get_resource: VDU1_scale_group"},{"line_number":40,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":41,"context_line":"  VDU2_scale_group:"},{"line_number":42,"context_line":"    type: OS::Heat::AutoScalingGroup"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"43533ca2_19368976","line":39,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    properties:"},{"line_number":37,"context_line":"      scaling_adjustment: -1"},{"line_number":38,"context_line":"      auto_scaling_group_id:"},{"line_number":39,"context_line":"        get_resource: VDU1_scale_group"},{"line_number":40,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":41,"context_line":"  VDU2_scale_group:"},{"line_number":42,"context_line":"    type: OS::Heat::AutoScalingGroup"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"05a9e682_0a5cd929","line":39,"in_reply_to":"43533ca2_19368976","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"      auto_scaling_group_id:"},{"line_number":39,"context_line":"        get_resource: VDU1_scale_group"},{"line_number":40,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":41,"context_line":"  VDU2_scale_group:"},{"line_number":42,"context_line":"    type: OS::Heat::AutoScalingGroup"},{"line_number":43,"context_line":"    properties:"},{"line_number":44,"context_line":"      min_size: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f767383e_af1a372a","line":41,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      auto_scaling_group_id:"},{"line_number":39,"context_line":"        get_resource: VDU1_scale_group"},{"line_number":40,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":41,"context_line":"  VDU2_scale_group:"},{"line_number":42,"context_line":"    type: OS::Heat::AutoScalingGroup"},{"line_number":43,"context_line":"    properties:"},{"line_number":44,"context_line":"      min_size: 1"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"15611314_4097ff75","line":41,"in_reply_to":"f767383e_af1a372a","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":61,"context_line":"    properties:"},{"line_number":62,"context_line":"      scaling_adjustment: 1"},{"line_number":63,"context_line":"      auto_scaling_group_id:"},{"line_number":64,"context_line":"        get_resource: VDU2_scale_group"},{"line_number":65,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":66,"context_line":"  VDU2_scale_scale_in:"},{"line_number":67,"context_line":"    type: OS::Heat::ScalingPolicy"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1d57ad60_9baa86f5","line":64,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    properties:"},{"line_number":62,"context_line":"      scaling_adjustment: 1"},{"line_number":63,"context_line":"      auto_scaling_group_id:"},{"line_number":64,"context_line":"        get_resource: VDU2_scale_group"},{"line_number":65,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":66,"context_line":"  VDU2_scale_scale_in:"},{"line_number":67,"context_line":"    type: OS::Heat::ScalingPolicy"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"6c28eecc_a4d234a8","line":64,"in_reply_to":"1d57ad60_9baa86f5","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":68,"context_line":"    properties:"},{"line_number":69,"context_line":"      scaling_adjustment: -1"},{"line_number":70,"context_line":"      auto_scaling_group_id:"},{"line_number":71,"context_line":"        get_resource: VDU2_scale_group"},{"line_number":72,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":73,"context_line":"  extmanageNW_1:"},{"line_number":74,"context_line":"    type: OS::Neutron::Net"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"79f78878_329ecbf0","line":71,"updated":"2021-09-13 08:15:56.000000000","message":"ditto.","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    properties:"},{"line_number":69,"context_line":"      scaling_adjustment: -1"},{"line_number":70,"context_line":"      auto_scaling_group_id:"},{"line_number":71,"context_line":"        get_resource: VDU2_scale_group"},{"line_number":72,"context_line":"      adjustment_type: change_in_capacity"},{"line_number":73,"context_line":"  extmanageNW_1:"},{"line_number":74,"context_line":"    type: OS::Neutron::Net"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"561c8eb6_9f04e09f","line":71,"in_reply_to":"79f78878_329ecbf0","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"}],"tacker/tests/etc/samples/etsi/nfv/functional6/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ed601b9e71df11857f971c6a99954b8f89c38d0c","unresolved":true,"context_lines":[{"line_number":301,"context_line":"          deltas:"},{"line_number":302,"context_line":"            delta_1:"},{"line_number":303,"context_line":"              number_of_instances: 1"},{"line_number":304,"context_line":"        targets: [ VDU2 ]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    - instantiation_levels:"},{"line_number":307,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"28a97869_6bda609a","line":304,"updated":"2021-04-28 01:55:22.000000000","message":"Is this fix intentional?\nIn that case, it will be unmatched with resource_name, so I think that resource_name should also be modified.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"56a28a304fef8d1a2d88c0a7327513012ce8c16f","unresolved":false,"context_lines":[{"line_number":301,"context_line":"          deltas:"},{"line_number":302,"context_line":"            delta_1:"},{"line_number":303,"context_line":"              number_of_instances: 1"},{"line_number":304,"context_line":"        targets: [ VDU2 ]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    - instantiation_levels:"},{"line_number":307,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e911ddfa_ef144ed9","line":304,"in_reply_to":"1ea52033_ca04b615","updated":"2021-05-14 06:35:40.000000000","message":"Done","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"89505bd39f5e21ea681823957ac29573e772a3b3","unresolved":true,"context_lines":[{"line_number":301,"context_line":"          deltas:"},{"line_number":302,"context_line":"            delta_1:"},{"line_number":303,"context_line":"              number_of_instances: 1"},{"line_number":304,"context_line":"        targets: [ VDU2 ]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    - instantiation_levels:"},{"line_number":307,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"613079ce_0e9153ff","line":304,"in_reply_to":"28a97869_6bda609a","updated":"2021-05-11 03:08:47.000000000","message":"\u003e Is this fix intentional?\n\u003e In that case, it will be unmatched with resource_name, so I think that resource_name should also be modified.\n\nThe part was modified to match vnfc_resource_info.\nCould you please point out which resource_name you are referring to?","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4936de14a9263adde524f00b743571435db7c939","unresolved":true,"context_lines":[{"line_number":301,"context_line":"          deltas:"},{"line_number":302,"context_line":"            delta_1:"},{"line_number":303,"context_line":"              number_of_instances: 1"},{"line_number":304,"context_line":"        targets: [ VDU2 ]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    - instantiation_levels:"},{"line_number":307,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d93f047a_e642acc8","line":304,"in_reply_to":"613079ce_0e9153ff","updated":"2021-05-11 04:50:42.000000000","message":"I think this resource name should be \u0027VDU2_scaling_aspect_deltas\u0027 instead of \u0027VDU1_scaling_aspect_deltas\u0027.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"7d8eae0cffa7bd30cda65559355c0e8a3d2c7336","unresolved":true,"context_lines":[{"line_number":301,"context_line":"          deltas:"},{"line_number":302,"context_line":"            delta_1:"},{"line_number":303,"context_line":"              number_of_instances: 1"},{"line_number":304,"context_line":"        targets: [ VDU2 ]"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    - instantiation_levels:"},{"line_number":307,"context_line":"        type: tosca.policies.nfv.InstantiationLevels"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ea52033_ca04b615","line":304,"in_reply_to":"d93f047a_e642acc8","updated":"2021-05-11 10:32:15.000000000","message":"\u003e I think this resource name should be \u0027VDU2_scaling_aspect_deltas\u0027 instead of \u0027VDU1_scaling_aspect_deltas\u0027.\n\nModified as pointed out.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"}],"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f3767c6d21b79bc9c345775bcbd16e958b2b9ed7","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"91095b4a_34f0cabf","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"updated":"2021-05-06 06:30:11.000000000","message":"Almost the same `grant_obj` was created for the other test methods. Can\u0027t it be a sub module like `_get_grant_obj()`?\nOnly the `zone` parameter of the `test_create_grant_zone_id_none()` method seems to be different (* 1).\n\n(*1) https://review.opendev.org/c/openstack/tacker/+/787711/1/tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py#939","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"89505bd39f5e21ea681823957ac29573e772a3b3","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5946afcd_f5c62b73","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"4ee3a841_fdb2daca","updated":"2021-05-11 03:08:47.000000000","message":"\u003e Yes, only `zone_id` is different as I commented but almost same.\n\u003e I thought it would be better to create a sub module with `zone_id` as a parameter.\n\nnew subfunction/submodule _get_grant_obj is created.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"881ee87191bbd9a14c5dea475bdaad42b0ac1854","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d2c57b4_c553e51d","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"5946afcd_f5c62b73","updated":"2021-05-11 04:31:56.000000000","message":"Thanks for updating!\nHow about using _get_grant_obj() method for the following test methods?\n* test_create_grant_scale_vdu_nolist\n* test_create_grant_scale_none\n* test_create_grant_zone_add","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"52c63d5a22e71da775966604e5fe9ad39f12a72d","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d32e5817_9b8601c3","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"6d2c57b4_c553e51d","updated":"2021-05-14 04:17:23.000000000","message":"Sorry, could you respond to the following comments?\n\n\u003e How about using _get_grant_obj() method for the following test methods?\n\u003e * test_create_grant_scale_vdu_nolist\n\u003e * test_create_grant_scale_none\n\u003e * test_create_grant_zone_add\n\nI think above methods are using same grant_obj. thanks.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"425c9793fcdfd394432f05601ca37a81ccef647d","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ee3a841_fdb2daca","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"72833211_170ae361","updated":"2021-05-06 08:50:34.000000000","message":"Yes, only `zone_id` is different as I commented but almost same.\nI thought it would be better to create a sub module with `zone_id` as a parameter.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"7e5f34d421d0634f33903cb2257ba1948d646688","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed1f2f40_b4e8ff28","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"832609d0_b34cd78e","updated":"2021-07-13 09:21:46.000000000","message":"Thank you for rework, I\u0027ve confirmed.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"0b32e7264d693875c393556288df9d5de56321db","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"72833211_170ae361","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"91095b4a_34f0cabf","updated":"2021-05-06 08:35:42.000000000","message":"\u003e Almost the same `grant_obj` was created for the other test methods. Can\u0027t it be a sub module like `_get_grant_obj()`?\n\u003e Only the `zone` parameter of the `test_create_grant_zone_id_none()` method seems to be different (* 1).\n\u003e \n\u003e (*1) https://review.opendev.org/c/openstack/tacker/+/787711/1/tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py#939\n\nThe content is similar, but the test scenario differs depending on the presence or absence of zone_id.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"7ee927a87f49975f8f31af5b2503c3d3ef1d3207","unresolved":true,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"832609d0_b34cd78e","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"d32e5817_9b8601c3","updated":"2021-06-21 08:12:14.000000000","message":"Thanks for your suggestions, we have updated the code accordingly.","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"080f37290d0655ce61a7ca80e8cc8fa3d6cfd057","unresolved":false,"context_lines":[{"line_number":413,"context_line":"             \u0027type\u0027: \u0027OS::Heat::AutoScalingGroup\u0027})"},{"line_number":414,"context_line":"        mock_get_base_hot_dict.return_value \u003d \\"},{"line_number":415,"context_line":"            base_hot_dict, nested_hot_dict"},{"line_number":416,"context_line":"        vim_assets \u003d {"},{"line_number":417,"context_line":"            \u0027compute_resource_flavours\u0027: ["},{"line_number":418,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":419,"context_line":"                 \u0027vnfd_virtual_compute_desc_id\u0027: \u0027VDU1\u0027,"},{"line_number":420,"context_line":"                 \u0027vim_flavour_id\u0027: \u0027m1.tiny\u0027}],"},{"line_number":421,"context_line":"            \u0027softwareImages\u0027: ["},{"line_number":422,"context_line":"                {\u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":423,"context_line":"                 \u0027vnfd_software_image_id\u0027: \u0027VDU1\u0027,"},{"line_number":424,"context_line":"                 \u0027vim_software_image_id\u0027: \u0027cirros\u0027}"},{"line_number":425,"context_line":"            ]}"},{"line_number":426,"context_line":"        res_add_resource \u003d []"},{"line_number":427,"context_line":"        resource \u003d {"},{"line_number":428,"context_line":"            \u0027resource_definition_id\u0027: \u00272c6e5cc7-240d-4458-a683-1fe648351280\u0027,"},{"line_number":429,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":430,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":431,"context_line":"        res_add_resource.append(resource)"},{"line_number":432,"context_line":"        resource \u003d {"},{"line_number":433,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa9\u0027,"},{"line_number":434,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":435,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":436,"context_line":"        res_add_resource.append(resource)"},{"line_number":437,"context_line":"        resource \u003d {"},{"line_number":438,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa0\u0027,"},{"line_number":439,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":440,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":441,"context_line":"        res_add_resource.append(resource)"},{"line_number":442,"context_line":"        resource \u003d {"},{"line_number":443,"context_line":"            \u0027resource_definition_id\u0027: \u0027faf14707-da7c-4eec-be99-8099fa1e9fa1\u0027,"},{"line_number":444,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id,"},{"line_number":445,"context_line":"            \u0027zone_id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027}"},{"line_number":446,"context_line":"        res_add_resource.append(resource)"},{"line_number":447,"context_line":"        zone \u003d {"},{"line_number":448,"context_line":"            \u0027id\u0027: \u00275e4da3c3-4a55-412a-b624-843921f8b51d\u0027,"},{"line_number":449,"context_line":"            \u0027zone_id\u0027: \u0027nova\u0027,"},{"line_number":450,"context_line":"            \u0027vim_connection_id\u0027: uuidsentinel.vim_id}"},{"line_number":451,"context_line":"        vim_obj \u003d {"},{"line_number":452,"context_line":"            \u0027id\u0027: \u00270b9c66bb-9e1f-4bb2-92c3-913074e52e2b\u0027,"},{"line_number":453,"context_line":"            \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":454,"context_line":"            \u0027vim_type\u0027: \u0027openstack\u0027,"},{"line_number":455,"context_line":"            \u0027access_info\u0027: {"},{"line_number":456,"context_line":"                \u0027password\u0027: \u0027test_pw\u0027,"},{"line_number":457,"context_line":"                \u0027username\u0027: \u0027test_user\u0027,"},{"line_number":458,"context_line":"                \u0027region\u0027: \u0027test_region\u0027,"},{"line_number":459,"context_line":"                \u0027tenant\u0027: uuidsentinel.tenant}}"},{"line_number":460,"context_line":"        grant_dict \u003d {}"},{"line_number":461,"context_line":"        grant_dict[\u0027id\u0027] \u003d \u0027c213e465-8220-487e-9464-f79104e81e96\u0027"},{"line_number":462,"context_line":"        grant_dict[\u0027vnf_instance_id\u0027] \u003d uuidsentinel.vnf_instance_id"},{"line_number":463,"context_line":"        grant_dict[\u0027vnf_lcm_op_occ_id\u0027] \u003d uuidsentinel.vnf_lcm_op_occ_id"},{"line_number":464,"context_line":"        grant_dict[\u0027add_resources\u0027] \u003d []"},{"line_number":465,"context_line":"        grant_dict[\u0027add_resources\u0027].extend(res_add_resource)"},{"line_number":466,"context_line":"        grant_dict[\u0027vim_assets\u0027] \u003d vim_assets"},{"line_number":467,"context_line":"        grant_dict[\u0027zones\u0027] \u003d [zone]"},{"line_number":468,"context_line":"        grant_dict[\u0027vim_connections\u0027] \u003d [vim_obj]"},{"line_number":469,"context_line":"        grant_obj \u003d objects.Grant.obj_from_primitive("},{"line_number":470,"context_line":"            grant_dict, context\u003dself.context)"},{"line_number":471,"context_line":"        vnf[\u0027grant\u0027] \u003d grant_obj"},{"line_number":472,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":473,"context_line":"        vnf_instance.instantiated_vnf_info.reinitialize()"}],"source_content_type":"text/x-python","patch_set":1,"id":"35c6777c_43410a03","line":470,"range":{"start_line":416,"start_character":0,"end_line":470,"end_character":45},"in_reply_to":"ed1f2f40_b4e8ff28","updated":"2021-09-15 12:25:48.000000000","message":"Done","commit_id":"a1f5acd290b23a7365ea332e59d6efef6b052059"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":411,"context_line":"        nested_hot_dict \u003d {\u0027VDU1.yaml\u0027: self._read_nested_file()}"},{"line_number":412,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":413,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":414,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":415,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":416,"context_line":"                {\u0027properties\u0027: {\u0027zone\u0027: {"},{"line_number":417,"context_line":"                    \u0027get_param\u0027: [\u0027nfv\u0027, \u0027VDU\u0027, \u0027VDU1\u0027, \u0027zone\u0027]}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"cd01a68d_9e122dbb","line":414,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        nested_hot_dict \u003d {\u0027VDU1.yaml\u0027: self._read_nested_file()}"},{"line_number":412,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":413,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":414,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":415,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":416,"context_line":"                {\u0027properties\u0027: {\u0027zone\u0027: {"},{"line_number":417,"context_line":"                    \u0027get_param\u0027: [\u0027nfv\u0027, \u0027VDU\u0027, \u0027VDU1\u0027, \u0027zone\u0027]}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"25fe43c9_c1b3daf3","line":414,"in_reply_to":"cd01a68d_9e122dbb","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":537,"context_line":"            [\u0027VDU1\u0027][\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":538,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":539,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":540,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":541,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":542,"context_line":"                {\u0027properties\u0027: {},"},{"line_number":543,"context_line":"                \u0027type\u0027: \u0027VDU1.yaml\u0027}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"ef6cca2a_65c285f2","line":540,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":537,"context_line":"            [\u0027VDU1\u0027][\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":538,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":539,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":540,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":541,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":542,"context_line":"                {\u0027properties\u0027: {},"},{"line_number":543,"context_line":"                \u0027type\u0027: \u0027VDU1.yaml\u0027}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"9450f11d_1a625e90","line":540,"in_reply_to":"ef6cca2a_65c285f2","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":609,"context_line":"            [\u0027VDU1\u0027][\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":610,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":611,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":612,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":613,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":614,"context_line":"                {\u0027properties\u0027: {},"},{"line_number":615,"context_line":"                \u0027type\u0027: \u0027VDU1.yaml\u0027}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"e2d110ac_4a883040","line":612,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":609,"context_line":"            [\u0027VDU1\u0027][\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":610,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":611,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":612,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":613,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":614,"context_line":"                {\u0027properties\u0027: {},"},{"line_number":615,"context_line":"                \u0027type\u0027: \u0027VDU1.yaml\u0027}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"55e59d48_35da3401","line":612,"in_reply_to":"e2d110ac_4a883040","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":746,"context_line":"            [\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":747,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":748,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":749,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":750,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":751,"context_line":"                {\u0027properties\u0027: {},"},{"line_number":752,"context_line":"                \u0027type\u0027: \u0027VDU1.yaml\u0027}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"15b538f1_9657f59a","line":749,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":746,"context_line":"            [\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":747,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":748,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":749,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":750,"context_line":"            {\u0027properties\u0027: {\u0027resource\u0027:"},{"line_number":751,"context_line":"                {\u0027properties\u0027: {},"},{"line_number":752,"context_line":"                \u0027type\u0027: \u0027VDU1.yaml\u0027}},"}],"source_content_type":"text/x-python","patch_set":11,"id":"ad7a3291_dce56982","line":749,"in_reply_to":"15b538f1_9657f59a","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ce0b0651c737d1e599d2111d20871d02c14c1cc2","unresolved":true,"context_lines":[{"line_number":818,"context_line":"            [\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":819,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":820,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":821,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":822,"context_line":"            {\u0027properties\u0027:"},{"line_number":823,"context_line":"                {\u0027resource\u0027:"},{"line_number":824,"context_line":"                    {\u0027properties\u0027: {},"}],"source_content_type":"text/x-python","patch_set":11,"id":"dd818894_0edfea24","line":821,"updated":"2021-09-13 08:15:56.000000000","message":"ditto","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"696525a627a02eef26b028ac99f6af04d3001103","unresolved":false,"context_lines":[{"line_number":818,"context_line":"            [\u0027properties\u0027][\u0027availability_zone\u0027])"},{"line_number":819,"context_line":"        base_hot_dict \u003d self._read_file()"},{"line_number":820,"context_line":"        base_hot_dict[\u0027resources\u0027].setdefault("},{"line_number":821,"context_line":"            \u0027VDU1_scale_group\u0027,"},{"line_number":822,"context_line":"            {\u0027properties\u0027:"},{"line_number":823,"context_line":"                {\u0027resource\u0027:"},{"line_number":824,"context_line":"                    {\u0027properties\u0027: {},"}],"source_content_type":"text/x-python","patch_set":11,"id":"59e74259_2ed5623c","line":821,"in_reply_to":"dd818894_0edfea24","updated":"2021-09-14 03:15:30.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"56a28a304fef8d1a2d88c0a7327513012ce8c16f","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scaling_group_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""},{"line_number":195,"context_line":"            if scaling_group_dict:"},{"line_number":196,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":197,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"32e63206_ad638cd1","line":194,"updated":"2021-05-14 06:35:40.000000000","message":"\u0027scale_group_dict\u0027 and \u0027scaling_group_dict\u0027 are very similar variable names and should be fixed.","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"7ee927a87f49975f8f31af5b2503c3d3ef1d3207","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scaling_group_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""},{"line_number":195,"context_line":"            if scaling_group_dict:"},{"line_number":196,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":197,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9767229e_ff299fad","line":194,"in_reply_to":"32e63206_ad638cd1","updated":"2021-06-21 08:12:14.000000000","message":"we have updated the variable name.thanks","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"29bde72a9fdeb35072bcf6f8082e380fc02610cc","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scaling_group_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""},{"line_number":195,"context_line":"            if scaling_group_dict:"},{"line_number":196,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":197,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c2301a8a_0cb0f753","line":194,"in_reply_to":"35157e0d_f54e7a68","updated":"2021-09-13 07:31:07.000000000","message":"I saw PS11, I think it is degraded variable names for this comment.\nCould you confirm it?","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"563474d06774a5455dd80eda8216568a91ef3073","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scaling_group_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""},{"line_number":195,"context_line":"            if scaling_group_dict:"},{"line_number":196,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":197,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"35157e0d_f54e7a68","line":194,"in_reply_to":"9767229e_ff299fad","updated":"2021-07-14 00:46:19.000000000","message":"Done","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59fdc0eb2e53c621a67063da1cb4de0dcf5ae8e3","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scaling_group_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""},{"line_number":195,"context_line":"            if scaling_group_dict:"},{"line_number":196,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":197,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"cb8b8749_8e879d1b","line":194,"in_reply_to":"c2301a8a_0cb0f753","updated":"2021-09-14 02:27:06.000000000","message":"I\u0027ve confirmed it has been updated in PS 13.","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"56a28a304fef8d1a2d88c0a7327513012ce8c16f","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            nested_hot_dict, scale_group_dict, vdu_name):"},{"line_number":431,"context_line":"        vdu_none_flg \u003d True"},{"line_number":432,"context_line":"        for aspect in scale_group_dict[\u0027scaleGroupDict\u0027]:"},{"line_number":433,"context_line":"            aspect_id \u003d aspect + \"_group\""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            # vdu_list check"},{"line_number":436,"context_line":"            if vdu_name not in (scale_group_dict[\u0027scaleGroupDict\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"891a27a5_60499205","line":433,"updated":"2021-05-14 06:35:40.000000000","message":"https://review.opendev.org/c/openstack/tacker/+/787779\nI think you should fix in relation to the above patch, but what about?","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"16a100b51d6f9a95b964826f46f19df480f77e2d","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            nested_hot_dict, scale_group_dict, vdu_name):"},{"line_number":431,"context_line":"        vdu_none_flg \u003d True"},{"line_number":432,"context_line":"        for aspect in scale_group_dict[\u0027scaleGroupDict\u0027]:"},{"line_number":433,"context_line":"            aspect_id \u003d aspect + \"_group\""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            # vdu_list check"},{"line_number":436,"context_line":"            if vdu_name not in (scale_group_dict[\u0027scaleGroupDict\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f5b05ce_1fd4715f","line":433,"in_reply_to":"203f0954_e4c20d72","updated":"2021-07-19 02:58:23.000000000","message":"Done","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"a5d260c66584094ab33682b95daf492971082ff4","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            nested_hot_dict, scale_group_dict, vdu_name):"},{"line_number":431,"context_line":"        vdu_none_flg \u003d True"},{"line_number":432,"context_line":"        for aspect in scale_group_dict[\u0027scaleGroupDict\u0027]:"},{"line_number":433,"context_line":"            aspect_id \u003d aspect + \"_group\""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            # vdu_list check"},{"line_number":436,"context_line":"            if vdu_name not in (scale_group_dict[\u0027scaleGroupDict\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8d862fa_4008a0a6","line":433,"in_reply_to":"891a27a5_60499205","updated":"2021-06-28 06:09:44.000000000","message":"ok, we understood but these both are two different patches, and this patch was uploaded earlier than https://review.opendev.org/c/openstack/tacker/+/787779","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"563474d06774a5455dd80eda8216568a91ef3073","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            nested_hot_dict, scale_group_dict, vdu_name):"},{"line_number":431,"context_line":"        vdu_none_flg \u003d True"},{"line_number":432,"context_line":"        for aspect in scale_group_dict[\u0027scaleGroupDict\u0027]:"},{"line_number":433,"context_line":"            aspect_id \u003d aspect + \"_group\""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            # vdu_list check"},{"line_number":436,"context_line":"            if vdu_name not in (scale_group_dict[\u0027scaleGroupDict\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ebd03856_18bbeb50","line":433,"in_reply_to":"a8d862fa_4008a0a6","updated":"2021-07-14 00:46:19.000000000","message":"Yes, I also understand that this patch and the 787779 patch are independent.\nAfter this patch is merged, do you plan to add a fix to remove this \"_group\" in 787779?\nIf you do not correspond this, you will have to newly correspond like \"Remove the restriction of scaling group name\", which is corresponded in 787779.","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"c8e8cbb11cd3b9ad9064f31ba299f35d2d8440b8","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            nested_hot_dict, scale_group_dict, vdu_name):"},{"line_number":431,"context_line":"        vdu_none_flg \u003d True"},{"line_number":432,"context_line":"        for aspect in scale_group_dict[\u0027scaleGroupDict\u0027]:"},{"line_number":433,"context_line":"            aspect_id \u003d aspect + \"_group\""},{"line_number":434,"context_line":""},{"line_number":435,"context_line":"            # vdu_list check"},{"line_number":436,"context_line":"            if vdu_name not in (scale_group_dict[\u0027scaleGroupDict\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"203f0954_e4c20d72","line":433,"in_reply_to":"ebd03856_18bbeb50","updated":"2021-07-14 07:44:20.000000000","message":"ok we understood, will do fix as in function _update_hot_available_scale in https://review.opendev.org/c/openstack/tacker/+/787779 patch itself","commit_id":"1896e0058b0e39184ff5258ecfc5c09577a17ed0"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ae96b7d9233ebc0ba3e60fb0afda4f2fabefca0f","unresolved":true,"context_lines":[{"line_number":99,"context_line":"ALARMING_POLICY \u003d \u0027tosca.policies.tacker.Alarming\u0027"},{"line_number":100,"context_line":"SCALING_POLICY \u003d \u0027tosca.policies.tacker.Scaling\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"NOVA_SERVER_RESOURCE \u003d \"OS::Nova::Server\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def get_scaling_policy_name(action, policy_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"daf8d43c_8f949de0","line":102,"updated":"2021-07-20 17:26:19.000000000","message":"Why don\u0027t you remove this duplicated definition same as L.59?","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"080f37290d0655ce61a7ca80e8cc8fa3d6cfd057","unresolved":false,"context_lines":[{"line_number":99,"context_line":"ALARMING_POLICY \u003d \u0027tosca.policies.tacker.Alarming\u0027"},{"line_number":100,"context_line":"SCALING_POLICY \u003d \u0027tosca.policies.tacker.Scaling\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"NOVA_SERVER_RESOURCE \u003d \"OS::Nova::Server\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def get_scaling_policy_name(action, policy_name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"35e440c7_b46bd665","line":102,"in_reply_to":"daf8d43c_8f949de0","updated":"2021-09-15 12:25:48.000000000","message":"Done","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ae96b7d9233ebc0ba3e60fb0afda4f2fabefca0f","unresolved":true,"context_lines":[{"line_number":188,"context_line":"            LOG.debug(\u0027VNF package path: %s\u0027, vnf_package_path)"},{"line_number":189,"context_line":"            scale_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scale_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"4d93f8b9_fa52dc84","line":191,"range":{"start_line":191,"start_character":35,"end_line":191,"end_character":61},"updated":"2021-07-20 17:26:19.000000000","message":"It should be replaced with `SCALING_GROUP_RESOURCE `.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"080f37290d0655ce61a7ca80e8cc8fa3d6cfd057","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            LOG.debug(\u0027VNF package path: %s\u0027, vnf_package_path)"},{"line_number":189,"context_line":"            scale_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scale_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"8f4f79b6_0db78b41","line":191,"range":{"start_line":191,"start_character":35,"end_line":191,"end_character":61},"in_reply_to":"4d93f8b9_fa52dc84","updated":"2021-09-15 12:25:48.000000000","message":"Done","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ae96b7d9233ebc0ba3e60fb0afda4f2fabefca0f","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scale_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""},{"line_number":195,"context_line":"            if scale_dict:"},{"line_number":196,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":197,"context_line":"                    jsonutils.dump_as_bytes(scale_dict)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fbd0e530_4a5822ef","line":194,"updated":"2021-07-20 17:26:19.000000000","message":"nit. Why do you initialize it with empty string?","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"080f37290d0655ce61a7ca80e8cc8fa3d6cfd057","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    key_name \u003d name.replace(\u0027_group\u0027, \u0027\u0027)"},{"line_number":193,"context_line":"                    scale_dict[key_name] \u003d name"},{"line_number":194,"context_line":"            scale_group_dict \u003d \"\""},{"line_number":195,"context_line":"            if scale_dict:"},{"line_number":196,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":197,"context_line":"                    jsonutils.dump_as_bytes(scale_dict)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f54e7d0_7ef965da","line":194,"in_reply_to":"fbd0e530_4a5822ef","updated":"2021-09-15 12:25:48.000000000","message":"Done","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b645660de5934076f851150646076ca263ec050f","unresolved":true,"context_lines":[{"line_number":447,"context_line":"                vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":448,"context_line":"                if not vdu_rsrc_prop.get(\u0027zone\u0027):"},{"line_number":449,"context_line":"                    vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027:"},{"line_number":450,"context_line":"                            [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":451,"context_line":"                # nested_hot add"},{"line_number":452,"context_line":"                yaml_name \u003d vdu_prop[\u0027resource\u0027][\u0027type\u0027]"},{"line_number":453,"context_line":"                if not nested_hot_dict[yaml_name][\u0027parameters\u0027].get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1afe7da6_eeb51aac","line":450,"updated":"2021-07-15 06:49:53.000000000","message":"Why is `vdu` here in lowercase? The `VDU` of L421 is capitalized. The result should not be matched, and the zone value cannot be obtained.\nhttps://review.opendev.org/c/openstack/tacker/+/787711/6/tacker/vnfm/infra_drivers/openstack/openstack.py#419","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"eae2b5d05e38148fbd6e09328a87be2d2920b8f4","unresolved":true,"context_lines":[{"line_number":447,"context_line":"                vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":448,"context_line":"                if not vdu_rsrc_prop.get(\u0027zone\u0027):"},{"line_number":449,"context_line":"                    vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027:"},{"line_number":450,"context_line":"                            [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":451,"context_line":"                # nested_hot add"},{"line_number":452,"context_line":"                yaml_name \u003d vdu_prop[\u0027resource\u0027][\u0027type\u0027]"},{"line_number":453,"context_line":"                if not nested_hot_dict[yaml_name][\u0027parameters\u0027].get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e1b6012a_b85cf4fd","line":450,"in_reply_to":"1afe7da6_eeb51aac","updated":"2021-07-22 05:09:38.000000000","message":"I think before code re-factoring also, vdu was in lower_case in this dictionary \n{\u0027get_param\u0027:[\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]} \n\nAnd vdu was capitalized in \n\nhparam[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name] dictionary.\n\nand hot_param_dict[\u0027nfv\u0027][\u0027VDU\u0027][vdu_name] and \u0027get_param\u0027:[\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027] both are two different dictionaries\n\nso, we think it will not cause any problem.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"080f37290d0655ce61a7ca80e8cc8fa3d6cfd057","unresolved":true,"context_lines":[{"line_number":447,"context_line":"                vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":448,"context_line":"                if not vdu_rsrc_prop.get(\u0027zone\u0027):"},{"line_number":449,"context_line":"                    vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027:"},{"line_number":450,"context_line":"                            [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":451,"context_line":"                # nested_hot add"},{"line_number":452,"context_line":"                yaml_name \u003d vdu_prop[\u0027resource\u0027][\u0027type\u0027]"},{"line_number":453,"context_line":"                if not nested_hot_dict[yaml_name][\u0027parameters\u0027].get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e6513088_9b44a6c2","line":450,"in_reply_to":"2c4648f6_4298363c","updated":"2021-09-15 12:25:48.000000000","message":"Dear Yi Feng,\n\nI have analysed existing packages structure and it seems it should be small vdu.Please find below structure:\n\n\n\nresources:\n  VDU1:\n    type: OS::Heat::AutoScalingGroup\n    properties:\n      min_size: 1\n      max_size: 3\n      desired_capacity: 1\n      resource:\n        type: VDU1.yaml\n        properties:\n          flavor: { get_param: [ nfv, VDU, VDU1, flavor ] }\n          image: { get_param: [ nfv, VDU, VirtualStorage, image ] }\n          zone: { get_param: [ nfv, vdu, VDU1, zone ] }\n          net1: { get_param: [ nfv, CP, VDU1_CP1, network ] }\n          net2: { get_param: [ nfv, CP, VDU1_CP2, network ] }\n          net3: { get_resource: extmanageNW_1 }\n          net4: { get_resource: extmanageNW_2 }\n          net5: { get_resource: internalNW_1 }","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"2df1062a837203e2fcc8458b5b7f12c4e4b67a90","unresolved":true,"context_lines":[{"line_number":447,"context_line":"                vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":448,"context_line":"                if not vdu_rsrc_prop.get(\u0027zone\u0027):"},{"line_number":449,"context_line":"                    vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027:"},{"line_number":450,"context_line":"                            [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":451,"context_line":"                # nested_hot add"},{"line_number":452,"context_line":"                yaml_name \u003d vdu_prop[\u0027resource\u0027][\u0027type\u0027]"},{"line_number":453,"context_line":"                if not nested_hot_dict[yaml_name][\u0027parameters\u0027].get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f7e86fcd_f99706fd","line":450,"in_reply_to":"2c4648f6_4298363c","updated":"2021-09-14 09:14:44.000000000","message":"Thanks, Yi Feng san for pointing it out, will capitalized VDU in L450.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"500cdab351a7d23998410e2be2e7eb8b94a08096","unresolved":true,"context_lines":[{"line_number":447,"context_line":"                vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":448,"context_line":"                if not vdu_rsrc_prop.get(\u0027zone\u0027):"},{"line_number":449,"context_line":"                    vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027:"},{"line_number":450,"context_line":"                            [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":451,"context_line":"                # nested_hot add"},{"line_number":452,"context_line":"                yaml_name \u003d vdu_prop[\u0027resource\u0027][\u0027type\u0027]"},{"line_number":453,"context_line":"                if not nested_hot_dict[yaml_name][\u0027parameters\u0027].get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"2c4648f6_4298363c","line":450,"in_reply_to":"e1b6012a_b85cf4fd","updated":"2021-07-27 04:59:18.000000000","message":"Although hot_param_dict and get_param are two different dictionaries, there is a calling relationship between them.\nRefer to the following URL for get-param usage.\nhttps://docs.openstack.org/heat/latest/template_guide/hot_spec.html#get-param\n\nAccording to Zuul’s log,\nhttps://147cd08d0cb7a69a15c6-11a2e186f8f6505f790122d590a395c2.ssl.cf1.rackcdn.com/787711/6/check/tacker-functional-devstack-multinode-sol-separated-nfvo/f9ce5e2/controller-tacker/logs/screen-tacker-conductor.txt\nThe hot_template converted according to your code is as follows\n  parameters:\n    nfv:\n      type: json\n  resources:\n    VDU1_scale_group:\n      properties:\n        resource:\n          properties:\n            zone:\n              get_param:\n              - nfv\n              - vdu\n              - VDU1\n              - zone\n          type: VDU1.yaml\n      type: OS::Heat::AutoScalingGroup\n\nBut the value of get_param is as follows\n  \u0027parameters\u0027: {\n    \u0027nfv\u0027: {\n      \u0027VDU\u0027: {\n        \u0027VDU1\u0027: {\n          \u0027flavor\u0027: \u00271\u0027,\n          \u0027image\u0027: \u0027e3c67046-3a1a-4cc8-bf28-c18244d172d9\u0027,\n          \u0027zone\u0027: \u0027nova\u0027\n        }\n      }\n    }\n  }\n\nIt is impossible to get the value of zone in this way.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b645660de5934076f851150646076ca263ec050f","unresolved":true,"context_lines":[{"line_number":468,"context_line":"            vdu_prop \u003d (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":469,"context_line":"                [\u0027properties\u0027])"},{"line_number":470,"context_line":"            if not vdu_prop.get(\u0027resource\u0027):"},{"line_number":471,"context_line":"                vdu_prop[\u0027resource\u0027] \u003d {\u0027properties\u0027: {}}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":474,"context_line":"            if not vdu_rsrc_prop.get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"28f52388_8d202a31","line":471,"updated":"2021-07-15 06:49:53.000000000","message":"When the VDU type is OS::Nova::Server, the converted heat-template is originally as follows.\n  VDU1:\n    type: OS::Nova::Server\n    properties:\n      availability_zone:\n        get_param:\n        - nfv\n        - vdu\n        - VDU1\n        - zone\n\nBut this line changes its structure and becomes as follows.\n  VDU1:\n    type: OS::Nova::Server\n    properties:\n      resource:\n        properties:\n          zone:\n            get_param:\n            - nfv\n            - vdu\n            - VDU1\n            - zone\n\nUse this heat-template to create a stack, an error will occur in the heat.\n  tacker.extensions.vnfm.HeatClientException: ERROR: Property error: : resources.VDU1.properties: : Unknown Property resource","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ae96b7d9233ebc0ba3e60fb0afda4f2fabefca0f","unresolved":true,"context_lines":[{"line_number":468,"context_line":"            vdu_prop \u003d (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":469,"context_line":"                [\u0027properties\u0027])"},{"line_number":470,"context_line":"            if not vdu_prop.get(\u0027resource\u0027):"},{"line_number":471,"context_line":"                vdu_prop[\u0027resource\u0027] \u003d {\u0027properties\u0027: {}}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":474,"context_line":"            if not vdu_rsrc_prop.get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f8df21ce_5531275f","line":471,"in_reply_to":"28f52388_8d202a31","updated":"2021-07-20 17:26:19.000000000","message":"\u003e Yi Feng\nYour point is it\u0027s OK for `OS::Heat::AutoScalingGroup`, but not for `OS::Nova::Server`, so we need to ensure that, right?","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"080f37290d0655ce61a7ca80e8cc8fa3d6cfd057","unresolved":true,"context_lines":[{"line_number":468,"context_line":"            vdu_prop \u003d (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":469,"context_line":"                [\u0027properties\u0027])"},{"line_number":470,"context_line":"            if not vdu_prop.get(\u0027resource\u0027):"},{"line_number":471,"context_line":"                vdu_prop[\u0027resource\u0027] \u003d {\u0027properties\u0027: {}}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":474,"context_line":"            if not vdu_rsrc_prop.get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"f6cb6ac9_b8642931","line":471,"in_reply_to":"b1656c14_00783ba0","updated":"2021-09-15 12:25:48.000000000","message":"The code has fixed in patch 16.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"500cdab351a7d23998410e2be2e7eb8b94a08096","unresolved":true,"context_lines":[{"line_number":468,"context_line":"            vdu_prop \u003d (base_hot_dict[\u0027resources\u0027][vdu_name]"},{"line_number":469,"context_line":"                [\u0027properties\u0027])"},{"line_number":470,"context_line":"            if not vdu_prop.get(\u0027resource\u0027):"},{"line_number":471,"context_line":"                vdu_prop[\u0027resource\u0027] \u003d {\u0027properties\u0027: {}}"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"            vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":474,"context_line":"            if not vdu_rsrc_prop.get(\u0027zone\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b1656c14_00783ba0","line":471,"in_reply_to":"f8df21ce_5531275f","updated":"2021-07-27 04:59:18.000000000","message":"Yes, that\u0027s what I meant.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b645660de5934076f851150646076ca263ec050f","unresolved":true,"context_lines":[{"line_number":473,"context_line":"            vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":474,"context_line":"            if not vdu_rsrc_prop.get(\u0027zone\u0027):"},{"line_number":475,"context_line":"                vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027:"},{"line_number":476,"context_line":"                    [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":477,"context_line":"        return base_hot_dict"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    @log.log"}],"source_content_type":"text/x-python","patch_set":6,"id":"f30b576e_e8156d41","line":476,"updated":"2021-07-15 06:49:53.000000000","message":"This line is also the same as L450.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"eae2b5d05e38148fbd6e09328a87be2d2920b8f4","unresolved":true,"context_lines":[{"line_number":473,"context_line":"            vdu_rsrc_prop \u003d vdu_prop[\u0027resource\u0027][\u0027properties\u0027]"},{"line_number":474,"context_line":"            if not vdu_rsrc_prop.get(\u0027zone\u0027):"},{"line_number":475,"context_line":"                vdu_rsrc_prop[\u0027zone\u0027] \u003d {\u0027get_param\u0027:"},{"line_number":476,"context_line":"                    [\u0027nfv\u0027, \u0027vdu\u0027, vdu_name, \u0027zone\u0027]}"},{"line_number":477,"context_line":"        return base_hot_dict"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    @log.log"}],"source_content_type":"text/x-python","patch_set":6,"id":"9516077b_e1136b11","line":476,"in_reply_to":"f30b576e_e8156d41","updated":"2021-07-22 05:09:38.000000000","message":"same comment as L450","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"ae96b7d9233ebc0ba3e60fb0afda4f2fabefca0f","unresolved":true,"context_lines":[{"line_number":1562,"context_line":"                scale_resurce_list \u003d heatclient.resource_get_list("},{"line_number":1563,"context_line":"                    scale_rsc.physical_resource_id)"},{"line_number":1564,"context_line":"                for rsc in scale_resurce_list:"},{"line_number":1565,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Nova::Server\u0027:"},{"line_number":1566,"context_line":"                        if rsc.physical_resource_id not in vnfc_rsc_list:"},{"line_number":1567,"context_line":"                            rsc_info \u003d heatclient.resource_get("},{"line_number":1568,"context_line":"                                scale_rsc.physical_resource_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"6dc45bf9_69a923f9","line":1565,"range":{"start_line":1565,"start_character":44,"end_line":1565,"end_character":62},"updated":"2021-07-20 17:26:19.000000000","message":"It should be replaced with `NOVA_SERVER_RESOURCE `.","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"080f37290d0655ce61a7ca80e8cc8fa3d6cfd057","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"                scale_resurce_list \u003d heatclient.resource_get_list("},{"line_number":1563,"context_line":"                    scale_rsc.physical_resource_id)"},{"line_number":1564,"context_line":"                for rsc in scale_resurce_list:"},{"line_number":1565,"context_line":"                    if rsc.resource_type \u003d\u003d \u0027OS::Nova::Server\u0027:"},{"line_number":1566,"context_line":"                        if rsc.physical_resource_id not in vnfc_rsc_list:"},{"line_number":1567,"context_line":"                            rsc_info \u003d heatclient.resource_get("},{"line_number":1568,"context_line":"                                scale_rsc.physical_resource_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"cdfd18a8_89614c4a","line":1565,"range":{"start_line":1565,"start_character":44,"end_line":1565,"end_character":62},"in_reply_to":"6dc45bf9_69a923f9","updated":"2021-09-15 12:25:48.000000000","message":"Done","commit_id":"223e853c3a142ece02d9bdf0b6eb3ab8245ab145"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"29bde72a9fdeb35072bcf6f8082e380fc02610cc","unresolved":true,"context_lines":[{"line_number":185,"context_line":"            vnfd_dict \u003d yaml.safe_load(vnfd_str)"},{"line_number":186,"context_line":"            LOG.debug(\u0027VNFD: %s\u0027, vnfd_dict)"},{"line_number":187,"context_line":"            LOG.debug(\u0027VNF package path: %s\u0027, vnf_package_path)"},{"line_number":188,"context_line":"            scaling_group_dict\u003d {}"},{"line_number":189,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":190,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d SCALING_GROUP_RESOURCE :"},{"line_number":191,"context_line":"                    scaling_group_dict[name] \u003d name"}],"source_content_type":"text/x-python","patch_set":11,"id":"1321bf32_48d4ba15","line":188,"range":{"start_line":188,"start_character":30,"end_line":188,"end_character":31},"updated":"2021-09-13 07:31:07.000000000","message":"I think it was pointed out on pep8, but could you add space before \"\u003d\"?","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59fdc0eb2e53c621a67063da1cb4de0dcf5ae8e3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            vnfd_dict \u003d yaml.safe_load(vnfd_str)"},{"line_number":186,"context_line":"            LOG.debug(\u0027VNFD: %s\u0027, vnfd_dict)"},{"line_number":187,"context_line":"            LOG.debug(\u0027VNF package path: %s\u0027, vnf_package_path)"},{"line_number":188,"context_line":"            scaling_group_dict\u003d {}"},{"line_number":189,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":190,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d SCALING_GROUP_RESOURCE :"},{"line_number":191,"context_line":"                    scaling_group_dict[name] \u003d name"}],"source_content_type":"text/x-python","patch_set":11,"id":"714e1c73_93c22925","line":188,"range":{"start_line":188,"start_character":30,"end_line":188,"end_character":31},"in_reply_to":"1321bf32_48d4ba15","updated":"2021-09-14 02:27:06.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"29bde72a9fdeb35072bcf6f8082e380fc02610cc","unresolved":true,"context_lines":[{"line_number":187,"context_line":"            LOG.debug(\u0027VNF package path: %s\u0027, vnf_package_path)"},{"line_number":188,"context_line":"            scaling_group_dict\u003d {}"},{"line_number":189,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":190,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d SCALING_GROUP_RESOURCE :"},{"line_number":191,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":192,"context_line":"            if scaling_group_dict:"},{"line_number":193,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"c0efe217_17f240e3","line":190,"range":{"start_line":190,"start_character":56,"end_line":190,"end_character":57},"updated":"2021-09-13 07:31:07.000000000","message":"I think it was pointed out on pep8, but could you delete the space?","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59fdc0eb2e53c621a67063da1cb4de0dcf5ae8e3","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            LOG.debug(\u0027VNF package path: %s\u0027, vnf_package_path)"},{"line_number":188,"context_line":"            scaling_group_dict\u003d {}"},{"line_number":189,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":190,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d SCALING_GROUP_RESOURCE :"},{"line_number":191,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":192,"context_line":"            if scaling_group_dict:"},{"line_number":193,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"760522f7_9d757a92","line":190,"range":{"start_line":190,"start_character":56,"end_line":190,"end_character":57},"in_reply_to":"c0efe217_17f240e3","updated":"2021-09-14 02:27:06.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"29bde72a9fdeb35072bcf6f8082e380fc02610cc","unresolved":true,"context_lines":[{"line_number":1598,"context_line":"                scale_resurce_list \u003d heatclient.resource_get_list("},{"line_number":1599,"context_line":"                    scale_rsc.physical_resource_id)"},{"line_number":1600,"context_line":"                for rsc in scale_resurce_list:"},{"line_number":1601,"context_line":"                    if rsc.resource_type \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":1602,"context_line":"                        if rsc.physical_resource_id not in vnfc_rsc_list:"},{"line_number":1603,"context_line":"                            rsc_info \u003d heatclient.resource_get("},{"line_number":1604,"context_line":"                                scale_rsc.physical_resource_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"d1cec068_e0d54757","line":1601,"range":{"start_line":1601,"start_character":64,"end_line":1601,"end_character":65},"updated":"2021-09-13 07:31:07.000000000","message":"ditto.","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59fdc0eb2e53c621a67063da1cb4de0dcf5ae8e3","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"                scale_resurce_list \u003d heatclient.resource_get_list("},{"line_number":1599,"context_line":"                    scale_rsc.physical_resource_id)"},{"line_number":1600,"context_line":"                for rsc in scale_resurce_list:"},{"line_number":1601,"context_line":"                    if rsc.resource_type \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":1602,"context_line":"                        if rsc.physical_resource_id not in vnfc_rsc_list:"},{"line_number":1603,"context_line":"                            rsc_info \u003d heatclient.resource_get("},{"line_number":1604,"context_line":"                                scale_rsc.physical_resource_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"68ce1376_254ac1c8","line":1601,"range":{"start_line":1601,"start_character":64,"end_line":1601,"end_character":65},"in_reply_to":"d1cec068_e0d54757","updated":"2021-09-14 02:27:06.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"29bde72a9fdeb35072bcf6f8082e380fc02610cc","unresolved":true,"context_lines":[{"line_number":1739,"context_line":"            after_st_list \u003d []"},{"line_number":1740,"context_line":"            after_port_list \u003d []"},{"line_number":1741,"context_line":"            for rsc in resurce_list:"},{"line_number":1742,"context_line":"                if rsc.resource_type \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":1743,"context_line":"                    after_vnfcs_list.append(rsc.physical_resource_id)"},{"line_number":1744,"context_line":"                if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":1745,"context_line":"                    after_st_list.append(rsc.physical_resource_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9e8a115f_9a161f9b","line":1742,"range":{"start_line":1742,"start_character":60,"end_line":1742,"end_character":61},"updated":"2021-09-13 07:31:07.000000000","message":"ditto.","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59fdc0eb2e53c621a67063da1cb4de0dcf5ae8e3","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"            after_st_list \u003d []"},{"line_number":1740,"context_line":"            after_port_list \u003d []"},{"line_number":1741,"context_line":"            for rsc in resurce_list:"},{"line_number":1742,"context_line":"                if rsc.resource_type \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":1743,"context_line":"                    after_vnfcs_list.append(rsc.physical_resource_id)"},{"line_number":1744,"context_line":"                if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":1745,"context_line":"                    after_st_list.append(rsc.physical_resource_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"0818319b_2e2dfcd8","line":1742,"range":{"start_line":1742,"start_character":60,"end_line":1742,"end_character":61},"in_reply_to":"9e8a115f_9a161f9b","updated":"2021-09-14 02:27:06.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"29bde72a9fdeb35072bcf6f8082e380fc02610cc","unresolved":true,"context_lines":[{"line_number":1934,"context_line":"        nested_hot \u003d yaml.safe_load("},{"line_number":1935,"context_line":"            vnf_info[\u0027attributes\u0027][yaml_name])"},{"line_number":1936,"context_line":"        for resource_name, resource in nested_hot[\u0027resources\u0027].items():"},{"line_number":1937,"context_line":"            if resource[\u0027type\u0027] \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":1938,"context_line":"                for i in range(size):"},{"line_number":1939,"context_line":"                    add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":1940,"context_line":"                    rsc \u003d objects.ResourceDefinition("}],"source_content_type":"text/x-python","patch_set":11,"id":"44db5ff6_5c89785d","line":1937,"range":{"start_line":1937,"start_character":55,"end_line":1937,"end_character":56},"updated":"2021-09-13 07:31:07.000000000","message":"ditto.","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59fdc0eb2e53c621a67063da1cb4de0dcf5ae8e3","unresolved":false,"context_lines":[{"line_number":1934,"context_line":"        nested_hot \u003d yaml.safe_load("},{"line_number":1935,"context_line":"            vnf_info[\u0027attributes\u0027][yaml_name])"},{"line_number":1936,"context_line":"        for resource_name, resource in nested_hot[\u0027resources\u0027].items():"},{"line_number":1937,"context_line":"            if resource[\u0027type\u0027] \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":1938,"context_line":"                for i in range(size):"},{"line_number":1939,"context_line":"                    add_uuid \u003d uuidutils.generate_uuid()"},{"line_number":1940,"context_line":"                    rsc \u003d objects.ResourceDefinition("}],"source_content_type":"text/x-python","patch_set":11,"id":"51772e21_3d21f3e5","line":1937,"range":{"start_line":1937,"start_character":55,"end_line":1937,"end_character":56},"in_reply_to":"44db5ff6_5c89785d","updated":"2021-09-14 02:27:06.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"29bde72a9fdeb35072bcf6f8082e380fc02610cc","unresolved":true,"context_lines":[{"line_number":2034,"context_line":"        for del_rsc in del_list:"},{"line_number":2035,"context_line":"            scale_resurce_list \u003d heatclient.resource_get_list(del_rsc)"},{"line_number":2036,"context_line":"            for rsc in scale_resurce_list:"},{"line_number":2037,"context_line":"                if rsc.resource_type \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":2038,"context_line":"                    for vnfc_resource in inst_info.vnfc_resource_info:"},{"line_number":2039,"context_line":"                        if vnfc_resource.\\"},{"line_number":2040,"context_line":"                            compute_resource.resource_id \u003d\u003d \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"c6b6a291_3d46a9d3","line":2037,"range":{"start_line":2037,"start_character":60,"end_line":2037,"end_character":61},"updated":"2021-09-13 07:31:07.000000000","message":"ditto.","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"59fdc0eb2e53c621a67063da1cb4de0dcf5ae8e3","unresolved":false,"context_lines":[{"line_number":2034,"context_line":"        for del_rsc in del_list:"},{"line_number":2035,"context_line":"            scale_resurce_list \u003d heatclient.resource_get_list(del_rsc)"},{"line_number":2036,"context_line":"            for rsc in scale_resurce_list:"},{"line_number":2037,"context_line":"                if rsc.resource_type \u003d\u003d NOVA_SERVER_RESOURCE :"},{"line_number":2038,"context_line":"                    for vnfc_resource in inst_info.vnfc_resource_info:"},{"line_number":2039,"context_line":"                        if vnfc_resource.\\"},{"line_number":2040,"context_line":"                            compute_resource.resource_id \u003d\u003d \\"}],"source_content_type":"text/x-python","patch_set":11,"id":"cfbf7e83_6f3cf2fe","line":2037,"range":{"start_line":2037,"start_character":60,"end_line":2037,"end_character":61},"in_reply_to":"c6b6a291_3d46a9d3","updated":"2021-09-14 02:27:06.000000000","message":"Done","commit_id":"36dee0c40ab7a3cf4c33c16ec5ec6160704168a8"}]}