)]}'
{"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"ef655bc21a5f5e9112fd48c1c9488afedd80c461","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        vnf_package_path_test \u003d os.path.abspath("},{"line_number":208,"context_line":"            os.path.join(os.path.dirname(__file__),"},{"line_number":209,"context_line":"                         \"../../../../etc/samples/etsi/nfv\","},{"line_number":210,"context_line":"                         \"user_data_sample_normal\"))"},{"line_number":211,"context_line":"        inst_req_info_test \u003d type(\u0027\u0027, (), {})"},{"line_number":212,"context_line":"        test_json \u003d self._json_load("},{"line_number":213,"context_line":"            \u0027instantiate_vnf_request_lcm_userdata.json\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b303ef5c_9756ff30","line":210,"range":{"start_line":210,"start_character":26,"end_line":210,"end_character":49},"updated":"2021-05-06 02:17:24.000000000","message":"The basehot file in `user_data_sample_nomal` folder does not seems not contain the \"OS::Heat::AutoScalingGroup\" type. Are you selecting the correct file?\n\nAnd could you let me know if this is a test to ensure that it will work without suffix \"_group\". Isn\u0027t it necessary to add FT or change name of \"AutoScalingGroup\" type for checking scale operation without suffix \"_group\"?","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3b9057474e44d9da519652ba1c38794abb7bf9a7","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        vnf_package_path_test \u003d os.path.abspath("},{"line_number":208,"context_line":"            os.path.join(os.path.dirname(__file__),"},{"line_number":209,"context_line":"                         \"../../../../etc/samples/etsi/nfv\","},{"line_number":210,"context_line":"                         \"user_data_sample_normal\"))"},{"line_number":211,"context_line":"        inst_req_info_test \u003d type(\u0027\u0027, (), {})"},{"line_number":212,"context_line":"        test_json \u003d self._json_load("},{"line_number":213,"context_line":"            \u0027instantiate_vnf_request_lcm_userdata.json\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2c611c25_b0e94e3c","line":210,"range":{"start_line":210,"start_character":26,"end_line":210,"end_character":49},"in_reply_to":"46559de5_ab210af1","updated":"2021-07-02 10:02:31.000000000","message":"I\u0027ve confirmed in Patchset 3.","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"42eac9b7dc02dc126b8ef5401e0e14dfacd94947","unresolved":true,"context_lines":[{"line_number":207,"context_line":"        vnf_package_path_test \u003d os.path.abspath("},{"line_number":208,"context_line":"            os.path.join(os.path.dirname(__file__),"},{"line_number":209,"context_line":"                         \"../../../../etc/samples/etsi/nfv\","},{"line_number":210,"context_line":"                         \"user_data_sample_normal\"))"},{"line_number":211,"context_line":"        inst_req_info_test \u003d type(\u0027\u0027, (), {})"},{"line_number":212,"context_line":"        test_json \u003d self._json_load("},{"line_number":213,"context_line":"            \u0027instantiate_vnf_request_lcm_userdata.json\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"46559de5_ab210af1","line":210,"range":{"start_line":210,"start_character":26,"end_line":210,"end_character":49},"in_reply_to":"b303ef5c_9756ff30","updated":"2021-05-12 04:27:05.000000000","message":"\u003e The basehot file in `user_data_sample_nomal` folder does not seems not contain the \"OS::Heat::AutoScalingGroup\" type. Are you selecting the correct file?\n\u003e \n\u003e And could you let me know if this is a test to ensure that it will work without suffix \"_group\". Isn\u0027t it necessary to add FT or change name of \"AutoScalingGroup\" type for checking scale operation without suffix \"_group\"?\n\nWe updated FT test data so that name without the suffix \"_group\" is checked.","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bc02f3ab57f971dd643af7a6cfe45480a91d367e","unresolved":true,"context_lines":[{"line_number":196,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._get_vnflcm_interface\u0027)"},{"line_number":197,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils.get_base_nest_hot_dict\u0027)"},{"line_number":198,"context_line":"    @mock.patch(\u0027tacker.common.clients.OpenstackClients\u0027)"},{"line_number":199,"context_line":"    def test_create_normal_with_scaling_group(self, mock_OpenstackClients_heat,"},{"line_number":200,"context_line":"                           mock_get_base_hot_dict,"},{"line_number":201,"context_line":"                           mock_get_vnflcm_interface,"},{"line_number":202,"context_line":"                           mock_format_base_hot):"}],"source_content_type":"text/x-python","patch_set":3,"id":"989c7eff_fb329fb5","line":199,"updated":"2021-05-14 06:14:28.000000000","message":"tacker / vnfm / infra_drivers / openstack / openstack.py # L192\nI made related comments above, but is this unittest for confirming the above processing route?\nIf so, I don\u0027t think it\u0027s testing as expected as a unittest.","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"61ee3b4d931799c5c40c84bbef5ee77b625994d5","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._get_vnflcm_interface\u0027)"},{"line_number":197,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils.get_base_nest_hot_dict\u0027)"},{"line_number":198,"context_line":"    @mock.patch(\u0027tacker.common.clients.OpenstackClients\u0027)"},{"line_number":199,"context_line":"    def test_create_normal_with_scaling_group(self, mock_OpenstackClients_heat,"},{"line_number":200,"context_line":"                           mock_get_base_hot_dict,"},{"line_number":201,"context_line":"                           mock_get_vnflcm_interface,"},{"line_number":202,"context_line":"                           mock_format_base_hot):"}],"source_content_type":"text/x-python","patch_set":3,"id":"38accaf2_368dbb0d","line":199,"in_reply_to":"36193177_d4d8d091","updated":"2021-07-14 01:07:00.000000000","message":"Done","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4404f1f1547553327734e80aedf620fa141847e4","unresolved":true,"context_lines":[{"line_number":196,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils._get_vnflcm_interface\u0027)"},{"line_number":197,"context_line":"    @mock.patch(\u0027tacker.vnflcm.utils.get_base_nest_hot_dict\u0027)"},{"line_number":198,"context_line":"    @mock.patch(\u0027tacker.common.clients.OpenstackClients\u0027)"},{"line_number":199,"context_line":"    def test_create_normal_with_scaling_group(self, mock_OpenstackClients_heat,"},{"line_number":200,"context_line":"                           mock_get_base_hot_dict,"},{"line_number":201,"context_line":"                           mock_get_vnflcm_interface,"},{"line_number":202,"context_line":"                           mock_format_base_hot):"}],"source_content_type":"text/x-python","patch_set":3,"id":"36193177_d4d8d091","line":199,"in_reply_to":"989c7eff_fb329fb5","updated":"2021-06-22 01:24:16.000000000","message":"\u003e tacker / vnfm / infra_drivers / openstack / openstack.py # L192\n\u003e I made related comments above, but is this unittest for confirming the above processing route?\n\u003e If so, I don\u0027t think it\u0027s testing as expected as a unittest.\n\nThis test code was added to confirm the changes. The existing test code method test_create_normal called utils.get_dummy_vnf_etsi but parameter scaling_group was set to False by default. In this new test code, scaling_group was set to True.","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"781eb02aa59f1d32cc08706095bc10d897d6f873","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            scaling_group_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":193,"context_line":"            if scaling_group_dict:"},{"line_number":194,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":195,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7a31b3_d872f39f","line":192,"updated":"2021-05-11 04:59:01.000000000","message":"It seems that unittest is not implemented to confirm this process.\n\nhttps://7da843395e58799905aa-21ca7001bf7d7d872d350759bb1a995f.ssl.cf2.rackcdn.com/787779/2/check/openstack-tox-cover/a65b016/cover/tacker_vnfm_infra_drivers_openstack_openstack_py.html#t192","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"dc5c6d1bc73c16babdc9b0e90a2f17ae6d65a56f","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            scaling_group_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":193,"context_line":"            if scaling_group_dict:"},{"line_number":194,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":195,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ac405af_7a248ca5","line":192,"in_reply_to":"1c5c9029_931b13bb","updated":"2021-07-19 02:52:52.000000000","message":"Looking at the result of tox-cover below, it seems that the unittest has not passed this L192 process.\nCould you check it again?\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_378/787779/3/check/openstack-tox-cover/3785f96/cover/tacker_vnfm_infra_drivers_openstack_openstack_py.html#t192","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"bc02f3ab57f971dd643af7a6cfe45480a91d367e","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            scaling_group_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":193,"context_line":"            if scaling_group_dict:"},{"line_number":194,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":195,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c19e5d0_f31e646e","line":192,"in_reply_to":"20fff38f_274131eb","updated":"2021-05-14 06:14:28.000000000","message":"Since this is a BUG-FIX patch, I think you should add not only FT but also a unittest that can confirm that it passes the modified part normally.","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"0e960f03c0ff39b76c51ea12dd5456c604bbab27","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            scaling_group_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":193,"context_line":"            if scaling_group_dict:"},{"line_number":194,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":195,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fec8dbe3_58e12fa2","line":192,"in_reply_to":"2ac405af_7a248ca5","updated":"2021-07-23 03:00:01.000000000","message":"The UT has been updated and now covering the L192. Below is the validation:\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bcd/787779/4/check/openstack-tox-cover/bcd2e65/cover/tacker_vnfm_infra_drivers_openstack_openstack_py.html","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4404f1f1547553327734e80aedf620fa141847e4","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            scaling_group_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":193,"context_line":"            if scaling_group_dict:"},{"line_number":194,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":195,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c5c9029_931b13bb","line":192,"in_reply_to":"3c19e5d0_f31e646e","updated":"2021-06-22 01:24:16.000000000","message":"\u003e Since this is a BUG-FIX patch, I think you should add not only FT but also a unittest that can confirm that it passes the modified part normally.\n\nWe add a UT code for this and the existing UT code also confirms the removal of \"_group\"","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"42eac9b7dc02dc126b8ef5401e0e14dfacd94947","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            scaling_group_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":193,"context_line":"            if scaling_group_dict:"},{"line_number":194,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":195,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"20fff38f_274131eb","line":192,"in_reply_to":"5f7a31b3_d872f39f","updated":"2021-05-12 04:27:05.000000000","message":"\u003e It seems that unittest is not implemented to confirm this process.\n\u003e \n\u003e https://7da843395e58799905aa-21ca7001bf7d7d872d350759bb1a995f.ssl.cf2.rackcdn.com/787779/2/check/openstack-tox-cover/a65b016/cover/tacker_vnfm_infra_drivers_openstack_openstack_py.html#t192\n\nWe updated FT test data so that name without the suffix \"_group\" is checked.","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"26448dc7d33803ea4d48a5b3265e2cb6fb3fd950","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            scaling_group_dict \u003d {}"},{"line_number":190,"context_line":"            for name, rsc in base_hot_dict.get(\u0027resources\u0027).items():"},{"line_number":191,"context_line":"                if rsc[\u0027type\u0027] \u003d\u003d \u0027OS::Heat::AutoScalingGroup\u0027:"},{"line_number":192,"context_line":"                    scaling_group_dict[name] \u003d name"},{"line_number":193,"context_line":"            if scaling_group_dict:"},{"line_number":194,"context_line":"                vnf[\u0027attributes\u0027][\u0027scaling_group_names\u0027] \u003d \\"},{"line_number":195,"context_line":"                    jsonutils.dump_as_bytes(scaling_group_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ca8024a8_cf365d5d","line":192,"in_reply_to":"fec8dbe3_58e12fa2","updated":"2021-07-27 02:45:28.000000000","message":"I\u0027ve confirmed. Thanks!","commit_id":"736b448ac18136372a2c1b6a17becf82a9438971"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f19a08c05a75b5af5b818a4a941a39c35fffc0e6","unresolved":true,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fc18f095_628f0d1d","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"updated":"2021-05-13 01:03:25.000000000","message":"Why is this branch needed?\n\nIf you added this branch it because it didn\u0027t pass the unit test, I suspect that the test data is wrong.\nYou need to add `before_error_point` to fixture policy data (*1) that used in scale_wait() method.\n(*1) https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/unit/vnfm/infra_drivers/openstack/fixture_data/fixture_data_utils.py#L72","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"db6fc2a8cd411dd1dd0d35885b8340ac566ba688","unresolved":true,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d8814b36_149ad024","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"in_reply_to":"30adb717_1e8f461a","updated":"2021-07-26 06:20:49.000000000","message":"thanks","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"3b9057474e44d9da519652ba1c38794abb7bf9a7","unresolved":true,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ef788979_1d92ad77","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"in_reply_to":"4294c769_48c7d8aa","updated":"2021-07-02 10:02:31.000000000","message":"Thanks for your reply, I understood.","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"0e960f03c0ff39b76c51ea12dd5456c604bbab27","unresolved":true,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"30adb717_1e8f461a","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"in_reply_to":"4593fb8a_4495ae40","updated":"2021-07-23 03:00:01.000000000","message":"Comment added in patch set4.","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"4404f1f1547553327734e80aedf620fa141847e4","unresolved":true,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"4294c769_48c7d8aa","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"in_reply_to":"b2969e36_22bdf11d","updated":"2021-06-22 01:24:16.000000000","message":"\u003e Sorry, there was a mistake in the previous comment.\n\u003e \n\u003e fixture policy data (*1) that used in scale_wait () method.\n\u003e -\u003e fixture policy data (*1) that used in unit test for scale_wait().\n\nThis was added because the method is common with the legacy and ETSI codes. This serves as guard so that legacy codes will not be affected with the changes.","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e6f088510fc387f6d20d16e204fbcd93ad52ab98","unresolved":false,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"b7a8902b_9969fce8","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"in_reply_to":"d8814b36_149ad024","updated":"2021-07-26 14:12:12.000000000","message":"Thanks for adding short note. I think it\u0027s easier to understand for later developers!","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f90848fc6fba23232d68cd9bd6e051d36952b957","unresolved":true,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"4593fb8a_4495ae40","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"in_reply_to":"ef788979_1d92ad77","updated":"2021-07-16 09:41:10.000000000","message":"Aldinson, why don\u0027t you add a short note as a comment?","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"37124e953e0df8a8f69ae7cda28d475ff4a7add7","unresolved":true,"context_lines":[{"line_number":773,"context_line":"        stack_retries \u003d self.STACK_RETRIES"},{"line_number":774,"context_line":"        stack_id \u003d policy[\u0027instance_id\u0027]"},{"line_number":775,"context_line":"        policy_name \u003d policy[\u0027name\u0027]"},{"line_number":776,"context_line":"        if \u0027before_error_point\u0027 not in policy[\u0027vnf\u0027]:"},{"line_number":777,"context_line":"            policy_name +\u003d \u0027_group\u0027"},{"line_number":778,"context_line":"        grp \u003d heatclient.resource_get(stack_id, policy_name)"},{"line_number":779,"context_line":"        while (True):"},{"line_number":780,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"b2969e36_22bdf11d","line":777,"range":{"start_line":776,"start_character":8,"end_line":777,"end_character":35},"in_reply_to":"fc18f095_628f0d1d","updated":"2021-05-13 01:25:36.000000000","message":"Sorry, there was a mistake in the previous comment.\n\nfixture policy data (*1) that used in scale_wait () method.\n-\u003e fixture policy data (*1) that used in unit test for scale_wait().","commit_id":"a07d3fa0c5bcab968074a2770ae87a5e86d16495"}]}