)]}'
{"tacker/tests/functional/sol/vnflcm/test_vnf_instance.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":454,"context_line":"            # in nova."},{"line_number":455,"context_line":"            self._get_server(vdu_resource_id_current)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _change_ext_conn_vnf_request(self, vim_id\u003dNone, ext_vl\u003dNone):"},{"line_number":458,"context_line":"        request_body \u003d {}"},{"line_number":459,"context_line":"        if ext_vl:"},{"line_number":460,"context_line":"            request_body[\"extVirtualLinks\"] \u003d ext_vl"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if vim_id:"},{"line_number":463,"context_line":"            request_body[\"vimConnectionInfo\"] \u003d ["},{"line_number":464,"context_line":"                {\"id\": uuidutils.generate_uuid(),"},{"line_number":465,"context_line":"                 \"vimId\": vim_id,"},{"line_number":466,"context_line":"                 \"vimType\": \"ETSINFV.OPENSTACK_KEYSTONE.v_2\"}]"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        return request_body"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _change_ext_conn_vnf_instance(self, vnf_instance, request_body,"},{"line_number":471,"context_line":"            expected_stack_status\u003dinfra_cnst.STACK_UPDATE_COMPLETE):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f31fbc9b_a3835056","line":468,"range":{"start_line":457,"start_character":4,"end_line":468,"end_character":27},"updated":"2021-05-12 08:21:53.000000000","message":"Is it possible to use \u0027fake_vnflcm.VnfInstances.make_change_ext_conn_request_body\u0027 used in test_vnf_instance_with_user_data.py?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            # in nova."},{"line_number":455,"context_line":"            self._get_server(vdu_resource_id_current)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _change_ext_conn_vnf_request(self, vim_id\u003dNone, ext_vl\u003dNone):"},{"line_number":458,"context_line":"        request_body \u003d {}"},{"line_number":459,"context_line":"        if ext_vl:"},{"line_number":460,"context_line":"            request_body[\"extVirtualLinks\"] \u003d ext_vl"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if vim_id:"},{"line_number":463,"context_line":"            request_body[\"vimConnectionInfo\"] \u003d ["},{"line_number":464,"context_line":"                {\"id\": uuidutils.generate_uuid(),"},{"line_number":465,"context_line":"                 \"vimId\": vim_id,"},{"line_number":466,"context_line":"                 \"vimType\": \"ETSINFV.OPENSTACK_KEYSTONE.v_2\"}]"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        return request_body"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _change_ext_conn_vnf_instance(self, vnf_instance, request_body,"},{"line_number":471,"context_line":"            expected_stack_status\u003dinfra_cnst.STACK_UPDATE_COMPLETE):"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e3633c8_5afa9d2c","line":468,"range":{"start_line":457,"start_character":4,"end_line":468,"end_character":27},"in_reply_to":"26aeee8d_4e3330b9","updated":"2021-07-14 01:59:42.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":454,"context_line":"            # in nova."},{"line_number":455,"context_line":"            self._get_server(vdu_resource_id_current)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def _change_ext_conn_vnf_request(self, vim_id\u003dNone, ext_vl\u003dNone):"},{"line_number":458,"context_line":"        request_body \u003d {}"},{"line_number":459,"context_line":"        if ext_vl:"},{"line_number":460,"context_line":"            request_body[\"extVirtualLinks\"] \u003d ext_vl"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if vim_id:"},{"line_number":463,"context_line":"            request_body[\"vimConnectionInfo\"] \u003d ["},{"line_number":464,"context_line":"                {\"id\": uuidutils.generate_uuid(),"},{"line_number":465,"context_line":"                 \"vimId\": vim_id,"},{"line_number":466,"context_line":"                 \"vimType\": \"ETSINFV.OPENSTACK_KEYSTONE.v_2\"}]"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        return request_body"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def _change_ext_conn_vnf_instance(self, vnf_instance, request_body,"},{"line_number":471,"context_line":"            expected_stack_status\u003dinfra_cnst.STACK_UPDATE_COMPLETE):"}],"source_content_type":"text/x-python","patch_set":1,"id":"26aeee8d_4e3330b9","line":468,"range":{"start_line":457,"start_character":4,"end_line":468,"end_character":27},"in_reply_to":"f31fbc9b_a3835056","updated":"2021-07-05 04:48:47.000000000","message":"The content of the request is different from that of fake_vnflcm.VnfInstances.make_change_ext_conn_request_body, so it is not possible.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":481,"context_line":"        self._stack_update_wait(stack.id, expected_stack_status,"},{"line_number":482,"context_line":"                                VNF_CHANGE_EXT_CONN_TIMEOUT)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _get_heat_stack(self, vnf_instance_id, stack_name):"},{"line_number":485,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":486,"context_line":"        try:"},{"line_number":487,"context_line":"            stacks \u003d heatclient.stacks.list()"},{"line_number":488,"context_line":"        except Exception:"},{"line_number":489,"context_line":"            return None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        target_stakcs \u003d list("},{"line_number":492,"context_line":"            filter("},{"line_number":493,"context_line":"                lambda x: x.stack_name \u003d\u003d stack_name,"},{"line_number":494,"context_line":"                stacks))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if len(target_stakcs) \u003d\u003d 0:"},{"line_number":497,"context_line":"            return None"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        return target_stakcs[0]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_heat_resource_list(self, stack_id, nested_depth\u003d0):"},{"line_number":502,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            resources \u003d heatclient.resources.list("},{"line_number":505,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":506,"context_line":"        except Exception:"},{"line_number":507,"context_line":"            return None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        return resources"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_heat_resource(self, stack_id, resource_name):"},{"line_number":512,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            resource \u003d heatclient.resources.get("},{"line_number":515,"context_line":"                stack_id, resource_name)"},{"line_number":516,"context_line":"        except Exception:"},{"line_number":517,"context_line":"            return None"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"67ad40ea_fa337e6b","line":519,"range":{"start_line":484,"start_character":4,"end_line":519,"end_character":23},"updated":"2021-05-12 08:21:53.000000000","message":"By inheriting vnflcm_base.BaseVnfLcmTest, can you use similar code defined in tacker/tests/functional/sol/vnflcm/base.py instead of newly defining it?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a75fd26e2f61a7a1a595e0e7fd9bccedbd131bd4","unresolved":true,"context_lines":[{"line_number":481,"context_line":"        self._stack_update_wait(stack.id, expected_stack_status,"},{"line_number":482,"context_line":"                                VNF_CHANGE_EXT_CONN_TIMEOUT)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _get_heat_stack(self, vnf_instance_id, stack_name):"},{"line_number":485,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":486,"context_line":"        try:"},{"line_number":487,"context_line":"            stacks \u003d heatclient.stacks.list()"},{"line_number":488,"context_line":"        except Exception:"},{"line_number":489,"context_line":"            return None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        target_stakcs \u003d list("},{"line_number":492,"context_line":"            filter("},{"line_number":493,"context_line":"                lambda x: x.stack_name \u003d\u003d stack_name,"},{"line_number":494,"context_line":"                stacks))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if len(target_stakcs) \u003d\u003d 0:"},{"line_number":497,"context_line":"            return None"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        return target_stakcs[0]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_heat_resource_list(self, stack_id, nested_depth\u003d0):"},{"line_number":502,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            resources \u003d heatclient.resources.list("},{"line_number":505,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":506,"context_line":"        except Exception:"},{"line_number":507,"context_line":"            return None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        return resources"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_heat_resource(self, stack_id, resource_name):"},{"line_number":512,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            resource \u003d heatclient.resources.get("},{"line_number":515,"context_line":"                stack_id, resource_name)"},{"line_number":516,"context_line":"        except Exception:"},{"line_number":517,"context_line":"            return None"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"955ccfa6_2d2bd5f1","line":519,"range":{"start_line":484,"start_character":4,"end_line":519,"end_character":23},"in_reply_to":"0e757adf_1c7eb05b","updated":"2021-07-19 07:07:16.000000000","message":"I understood that there is a difference in \"_get_heat_stack\".\nCan \"_get_heat_resource_list\" and \"_get_heat_resource\" be commonized?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":true,"context_lines":[{"line_number":481,"context_line":"        self._stack_update_wait(stack.id, expected_stack_status,"},{"line_number":482,"context_line":"                                VNF_CHANGE_EXT_CONN_TIMEOUT)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _get_heat_stack(self, vnf_instance_id, stack_name):"},{"line_number":485,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":486,"context_line":"        try:"},{"line_number":487,"context_line":"            stacks \u003d heatclient.stacks.list()"},{"line_number":488,"context_line":"        except Exception:"},{"line_number":489,"context_line":"            return None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        target_stakcs \u003d list("},{"line_number":492,"context_line":"            filter("},{"line_number":493,"context_line":"                lambda x: x.stack_name \u003d\u003d stack_name,"},{"line_number":494,"context_line":"                stacks))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if len(target_stakcs) \u003d\u003d 0:"},{"line_number":497,"context_line":"            return None"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        return target_stakcs[0]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_heat_resource_list(self, stack_id, nested_depth\u003d0):"},{"line_number":502,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            resources \u003d heatclient.resources.list("},{"line_number":505,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":506,"context_line":"        except Exception:"},{"line_number":507,"context_line":"            return None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        return resources"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_heat_resource(self, stack_id, resource_name):"},{"line_number":512,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            resource \u003d heatclient.resources.get("},{"line_number":515,"context_line":"                stack_id, resource_name)"},{"line_number":516,"context_line":"        except Exception:"},{"line_number":517,"context_line":"            return None"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"2d10aee1_ccd2de7e","line":519,"range":{"start_line":484,"start_character":4,"end_line":519,"end_character":23},"in_reply_to":"2858be36_de2db1f5","updated":"2021-07-14 01:59:42.000000000","message":"Sorry I misunderstood the inheritance of this code.\nHowever could you delete this code and move similar code from \"tacker/tests/functional/sol/vnflcm/base.py\" to \"tacker/tests/functional/base.py\".\nThat\u0027s because we don\u0027t want to create new similar code as possible as we can.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"af7c0bd3bb0410743e12b0045d03d64af87c411b","unresolved":true,"context_lines":[{"line_number":481,"context_line":"        self._stack_update_wait(stack.id, expected_stack_status,"},{"line_number":482,"context_line":"                                VNF_CHANGE_EXT_CONN_TIMEOUT)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _get_heat_stack(self, vnf_instance_id, stack_name):"},{"line_number":485,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":486,"context_line":"        try:"},{"line_number":487,"context_line":"            stacks \u003d heatclient.stacks.list()"},{"line_number":488,"context_line":"        except Exception:"},{"line_number":489,"context_line":"            return None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        target_stakcs \u003d list("},{"line_number":492,"context_line":"            filter("},{"line_number":493,"context_line":"                lambda x: x.stack_name \u003d\u003d stack_name,"},{"line_number":494,"context_line":"                stacks))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if len(target_stakcs) \u003d\u003d 0:"},{"line_number":497,"context_line":"            return None"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        return target_stakcs[0]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_heat_resource_list(self, stack_id, nested_depth\u003d0):"},{"line_number":502,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            resources \u003d heatclient.resources.list("},{"line_number":505,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":506,"context_line":"        except Exception:"},{"line_number":507,"context_line":"            return None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        return resources"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_heat_resource(self, stack_id, resource_name):"},{"line_number":512,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            resource \u003d heatclient.resources.get("},{"line_number":515,"context_line":"                stack_id, resource_name)"},{"line_number":516,"context_line":"        except Exception:"},{"line_number":517,"context_line":"            return None"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"0e757adf_1c7eb05b","line":519,"range":{"start_line":484,"start_character":4,"end_line":519,"end_character":23},"in_reply_to":"2d10aee1_ccd2de7e","updated":"2021-07-16 06:42:54.000000000","message":"These function name and return data is same but internal workflow of functions is different.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":481,"context_line":"        self._stack_update_wait(stack.id, expected_stack_status,"},{"line_number":482,"context_line":"                                VNF_CHANGE_EXT_CONN_TIMEOUT)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _get_heat_stack(self, vnf_instance_id, stack_name):"},{"line_number":485,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":486,"context_line":"        try:"},{"line_number":487,"context_line":"            stacks \u003d heatclient.stacks.list()"},{"line_number":488,"context_line":"        except Exception:"},{"line_number":489,"context_line":"            return None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        target_stakcs \u003d list("},{"line_number":492,"context_line":"            filter("},{"line_number":493,"context_line":"                lambda x: x.stack_name \u003d\u003d stack_name,"},{"line_number":494,"context_line":"                stacks))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if len(target_stakcs) \u003d\u003d 0:"},{"line_number":497,"context_line":"            return None"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        return target_stakcs[0]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_heat_resource_list(self, stack_id, nested_depth\u003d0):"},{"line_number":502,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            resources \u003d heatclient.resources.list("},{"line_number":505,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":506,"context_line":"        except Exception:"},{"line_number":507,"context_line":"            return None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        return resources"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_heat_resource(self, stack_id, resource_name):"},{"line_number":512,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            resource \u003d heatclient.resources.get("},{"line_number":515,"context_line":"                stack_id, resource_name)"},{"line_number":516,"context_line":"        except Exception:"},{"line_number":517,"context_line":"            return None"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"2858be36_de2db1f5","line":519,"range":{"start_line":484,"start_character":4,"end_line":519,"end_character":23},"in_reply_to":"67ad40ea_fa337e6b","updated":"2021-07-05 04:48:47.000000000","message":"This test case inherits base.BaseTackerTest. Do you mean we need to change the inheritance source, or do multiple inheritance?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"63451d73118128380c079a55059d4ea53f5d296b","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        self._stack_update_wait(stack.id, expected_stack_status,"},{"line_number":482,"context_line":"                                VNF_CHANGE_EXT_CONN_TIMEOUT)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _get_heat_stack(self, vnf_instance_id, stack_name):"},{"line_number":485,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":486,"context_line":"        try:"},{"line_number":487,"context_line":"            stacks \u003d heatclient.stacks.list()"},{"line_number":488,"context_line":"        except Exception:"},{"line_number":489,"context_line":"            return None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        target_stakcs \u003d list("},{"line_number":492,"context_line":"            filter("},{"line_number":493,"context_line":"                lambda x: x.stack_name \u003d\u003d stack_name,"},{"line_number":494,"context_line":"                stacks))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if len(target_stakcs) \u003d\u003d 0:"},{"line_number":497,"context_line":"            return None"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        return target_stakcs[0]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_heat_resource_list(self, stack_id, nested_depth\u003d0):"},{"line_number":502,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            resources \u003d heatclient.resources.list("},{"line_number":505,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":506,"context_line":"        except Exception:"},{"line_number":507,"context_line":"            return None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        return resources"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_heat_resource(self, stack_id, resource_name):"},{"line_number":512,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            resource \u003d heatclient.resources.get("},{"line_number":515,"context_line":"                stack_id, resource_name)"},{"line_number":516,"context_line":"        except Exception:"},{"line_number":517,"context_line":"            return None"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"f60e084b_a9939538","line":519,"range":{"start_line":484,"start_character":4,"end_line":519,"end_character":23},"in_reply_to":"70177d3f_3592a89c","updated":"2021-07-27 02:46:22.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d670f8a468269bc7ba5189ece2698fa6258c2bd8","unresolved":true,"context_lines":[{"line_number":481,"context_line":"        self._stack_update_wait(stack.id, expected_stack_status,"},{"line_number":482,"context_line":"                                VNF_CHANGE_EXT_CONN_TIMEOUT)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _get_heat_stack(self, vnf_instance_id, stack_name):"},{"line_number":485,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":486,"context_line":"        try:"},{"line_number":487,"context_line":"            stacks \u003d heatclient.stacks.list()"},{"line_number":488,"context_line":"        except Exception:"},{"line_number":489,"context_line":"            return None"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        target_stakcs \u003d list("},{"line_number":492,"context_line":"            filter("},{"line_number":493,"context_line":"                lambda x: x.stack_name \u003d\u003d stack_name,"},{"line_number":494,"context_line":"                stacks))"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        if len(target_stakcs) \u003d\u003d 0:"},{"line_number":497,"context_line":"            return None"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        return target_stakcs[0]"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def _get_heat_resource_list(self, stack_id, nested_depth\u003d0):"},{"line_number":502,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":503,"context_line":"        try:"},{"line_number":504,"context_line":"            resources \u003d heatclient.resources.list("},{"line_number":505,"context_line":"                stack_id, nested_depth\u003dnested_depth)"},{"line_number":506,"context_line":"        except Exception:"},{"line_number":507,"context_line":"            return None"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        return resources"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def _get_heat_resource(self, stack_id, resource_name):"},{"line_number":512,"context_line":"        heatclient \u003d self.heatclient()"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            resource \u003d heatclient.resources.get("},{"line_number":515,"context_line":"                stack_id, resource_name)"},{"line_number":516,"context_line":"        except Exception:"},{"line_number":517,"context_line":"            return None"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"70177d3f_3592a89c","line":519,"range":{"start_line":484,"start_character":4,"end_line":519,"end_character":23},"in_reply_to":"955ccfa6_2d2bd5f1","updated":"2021-07-19 13:05:20.000000000","message":"Thanks, for pointing it out we have incorporated the changes in new patch","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"},{"line_number":523,"context_line":"        vnf_instance_name \u003d vnf_instance[\u0027vnfInstanceName\u0027]"},{"line_number":524,"context_line":"        res_name \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"b115c36a_8e232834","line":521,"updated":"2021-05-12 08:21:53.000000000","message":"Since similar code is defined in tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py, can you move it to tacker/tests/functional/sol/vnflcm/base.py and use it?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"},{"line_number":523,"context_line":"        vnf_instance_name \u003d vnf_instance[\u0027vnfInstanceName\u0027]"},{"line_number":524,"context_line":"        res_name \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfaeb4ac_b3ce53d6","line":521,"in_reply_to":"20955a4b_87ac8e9c","updated":"2021-07-14 01:59:42.000000000","message":"Could you delete this code and move similar code from \"tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py\" to \"tacker/tests/functional/base.py\".\nThat\u0027s because we don\u0027t want to create new similar code as possible as we can.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a75fd26e2f61a7a1a595e0e7fd9bccedbd131bd4","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"},{"line_number":523,"context_line":"        vnf_instance_name \u003d vnf_instance[\u0027vnfInstanceName\u0027]"},{"line_number":524,"context_line":"        res_name \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"8470430f_a4bcf043","line":521,"in_reply_to":"2b1d6267_2417f594","updated":"2021-07-19 07:07:16.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"},{"line_number":523,"context_line":"        vnf_instance_name \u003d vnf_instance[\u0027vnfInstanceName\u0027]"},{"line_number":524,"context_line":"        res_name \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"20955a4b_87ac8e9c","line":521,"in_reply_to":"b115c36a_8e232834","updated":"2021-07-05 04:48:47.000000000","message":"Need to consider it together with the change of inheriting BaseVnfLcmTest class.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"af7c0bd3bb0410743e12b0045d03d64af87c411b","unresolved":true,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        return resource"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def _get_fixed_ips(self, vnf_instance, request_body):"},{"line_number":522,"context_line":"        vnf_instance_id \u003d vnf_instance[\u0027id\u0027]"},{"line_number":523,"context_line":"        vnf_instance_name \u003d vnf_instance[\u0027vnfInstanceName\u0027]"},{"line_number":524,"context_line":"        res_name \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b1d6267_2417f594","line":521,"in_reply_to":"bfaeb4ac_b3ce53d6","updated":"2021-07-16 06:42:54.000000000","message":"The function name and return data is same but internal workflow of function is different.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        return ans_list"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _list_op_occs(self, filter_string\u003d\u0027\u0027):"},{"line_number":573,"context_line":"        show_url \u003d os.path.join("},{"line_number":574,"context_line":"            self.base_vnf_lcm_op_occs_url)"},{"line_number":575,"context_line":"        resp, response_body \u003d self.http_client.do_request("},{"line_number":576,"context_line":"            show_url + filter_string, \"GET\")"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab50ba09_2156aefe","line":578,"range":{"start_line":572,"start_character":4,"end_line":578,"end_character":34},"updated":"2021-05-12 08:21:53.000000000","message":"By inheriting vnflcm_base.BaseVnfLcmTest, can you use similar code defined in tacker/tests/functional/sol/vnflcm/base.py instead of newly defining it?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a75fd26e2f61a7a1a595e0e7fd9bccedbd131bd4","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        return ans_list"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _list_op_occs(self, filter_string\u003d\u0027\u0027):"},{"line_number":573,"context_line":"        show_url \u003d os.path.join("},{"line_number":574,"context_line":"            self.base_vnf_lcm_op_occs_url)"},{"line_number":575,"context_line":"        resp, response_body \u003d self.http_client.do_request("},{"line_number":576,"context_line":"            show_url + filter_string, \"GET\")"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b7503c1_ef390d09","line":578,"range":{"start_line":572,"start_character":4,"end_line":578,"end_character":34},"in_reply_to":"1ab458ae_20447f3d","updated":"2021-07-19 07:07:16.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        return ans_list"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _list_op_occs(self, filter_string\u003d\u0027\u0027):"},{"line_number":573,"context_line":"        show_url \u003d os.path.join("},{"line_number":574,"context_line":"            self.base_vnf_lcm_op_occs_url)"},{"line_number":575,"context_line":"        resp, response_body \u003d self.http_client.do_request("},{"line_number":576,"context_line":"            show_url + filter_string, \"GET\")"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"de0599b5_a062df6b","line":578,"range":{"start_line":572,"start_character":4,"end_line":578,"end_character":34},"in_reply_to":"ab50ba09_2156aefe","updated":"2021-07-05 04:48:47.000000000","message":"This test case inherits base.BaseTackerTest. Do you mean we need to change the inheritance source, or do multiple inheritance?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":true,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        return ans_list"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _list_op_occs(self, filter_string\u003d\u0027\u0027):"},{"line_number":573,"context_line":"        show_url \u003d os.path.join("},{"line_number":574,"context_line":"            self.base_vnf_lcm_op_occs_url)"},{"line_number":575,"context_line":"        resp, response_body \u003d self.http_client.do_request("},{"line_number":576,"context_line":"            show_url + filter_string, \"GET\")"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3a45fbc_570df83b","line":578,"range":{"start_line":572,"start_character":4,"end_line":578,"end_character":34},"in_reply_to":"de0599b5_a062df6b","updated":"2021-07-14 01:59:42.000000000","message":"Same with L484.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"af7c0bd3bb0410743e12b0045d03d64af87c411b","unresolved":true,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"        return ans_list"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _list_op_occs(self, filter_string\u003d\u0027\u0027):"},{"line_number":573,"context_line":"        show_url \u003d os.path.join("},{"line_number":574,"context_line":"            self.base_vnf_lcm_op_occs_url)"},{"line_number":575,"context_line":"        resp, response_body \u003d self.http_client.do_request("},{"line_number":576,"context_line":"            show_url + filter_string, \"GET\")"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ab458ae_20447f3d","line":578,"range":{"start_line":572,"start_character":4,"end_line":578,"end_character":34},"in_reply_to":"e3a45fbc_570df83b","updated":"2021-07-16 06:42:54.000000000","message":"ok, we understood we will do modification and incorporate these comments","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        # Only check required parameters."}],"source_content_type":"text/x-python","patch_set":1,"id":"256304d9_b37c2b3d","line":580,"updated":"2021-05-12 08:21:53.000000000","message":"Since similar code is defined in tacker/tests/functional/sol/vnflcm/test_vnf_instance_with_user_data.py, can you move it to tacker/tests/functional/sol/vnflcm/base.py and use it?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        # Only check required parameters."}],"source_content_type":"text/x-python","patch_set":1,"id":"779ae42c_60461d49","line":580,"in_reply_to":"256304d9_b37c2b3d","updated":"2021-07-05 04:48:47.000000000","message":"Need to consider it together with the change of inheriting BaseVnfLcmTest class.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a75fd26e2f61a7a1a595e0e7fd9bccedbd131bd4","unresolved":false,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        # Only check required parameters."}],"source_content_type":"text/x-python","patch_set":1,"id":"ad1d3d5b_9ae9cb51","line":580,"in_reply_to":"2c73e1ab_bc0c2ab5","updated":"2021-07-19 07:07:16.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"af7c0bd3bb0410743e12b0045d03d64af87c411b","unresolved":true,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        # Only check required parameters."}],"source_content_type":"text/x-python","patch_set":1,"id":"2c73e1ab_bc0c2ab5","line":580,"in_reply_to":"57ca1935_71b26f70","updated":"2021-07-16 06:42:54.000000000","message":"ok, we understood we will do modification and incorporate these comments","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":true,"context_lines":[{"line_number":577,"context_line":""},{"line_number":578,"context_line":"        return resp, response_body"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _assert_occ_list(self, resp, op_occs_list):"},{"line_number":581,"context_line":"        self.assertEqual(200, resp.status_code)"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        # Only check required parameters."}],"source_content_type":"text/x-python","patch_set":1,"id":"57ca1935_71b26f70","line":580,"in_reply_to":"779ae42c_60461d49","updated":"2021-07-14 01:59:42.000000000","message":"Same with L521.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    def test_inst_chgextconn_term_tosca(self):"},{"line_number":1081,"context_line":"        \"\"\"Test change external vnf connectivity."},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        This test will instantiate vnf with external virtual link and"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc1005c6_150db9c1","line":1080,"range":{"start_line":1080,"start_character":8,"end_line":1080,"end_character":39},"updated":"2021-05-12 08:21:53.000000000","message":"This file contains only FT for TOSCA, so I think the test function name should be \u0027test_inst_chgextconn_term\u0027.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    def test_inst_chgextconn_term_tosca(self):"},{"line_number":1081,"context_line":"        \"\"\"Test change external vnf connectivity."},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        This test will instantiate vnf with external virtual link and"}],"source_content_type":"text/x-python","patch_set":1,"id":"de05be99_1af6e2ec","line":1080,"range":{"start_line":1080,"start_character":8,"end_line":1080,"end_character":39},"in_reply_to":"cc1005c6_150db9c1","updated":"2021-07-05 04:48:47.000000000","message":"ok, we understood will do modification","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":false,"context_lines":[{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":"        self._delete_vnf_instance(vnf_instance[\u0027id\u0027])"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    def test_inst_chgextconn_term_tosca(self):"},{"line_number":1081,"context_line":"        \"\"\"Test change external vnf connectivity."},{"line_number":1082,"context_line":""},{"line_number":1083,"context_line":"        This test will instantiate vnf with external virtual link and"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b7a6b8c_55732eef","line":1080,"range":{"start_line":1080,"start_character":8,"end_line":1080,"end_character":39},"in_reply_to":"de05be99_1af6e2ec","updated":"2021-07-14 01:59:42.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":1117,"context_line":"        if not net_mgmt_id:"},{"line_number":1118,"context_line":"            self.fail(\"net_mgmt network is not available\")"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        subnet0_id \u003d subnets.get(\u0027subnet0\u0027)"},{"line_number":1121,"context_line":"        if not subnet0_id:"},{"line_number":1122,"context_line":"            self.fail(\"subnet0 subnet is not available\")"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"        subnet1_id \u003d subnets.get(\u0027subnet1\u0027)"},{"line_number":1125,"context_line":"        if not subnet1_id:"},{"line_number":1126,"context_line":"            self.fail(\"subnet1 subnet is not available\")"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        subnet_mgmt_id \u003d subnets.get(\u0027subnet_mgmt\u0027)"},{"line_number":1129,"context_line":"        if not subnet_mgmt_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c7082db_df285496","line":1126,"range":{"start_line":1120,"start_character":8,"end_line":1126,"end_character":56},"updated":"2021-05-12 08:21:53.000000000","message":"Do you need these confirmations?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"        if not net_mgmt_id:"},{"line_number":1118,"context_line":"            self.fail(\"net_mgmt network is not available\")"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        subnet0_id \u003d subnets.get(\u0027subnet0\u0027)"},{"line_number":1121,"context_line":"        if not subnet0_id:"},{"line_number":1122,"context_line":"            self.fail(\"subnet0 subnet is not available\")"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"        subnet1_id \u003d subnets.get(\u0027subnet1\u0027)"},{"line_number":1125,"context_line":"        if not subnet1_id:"},{"line_number":1126,"context_line":"            self.fail(\"subnet1 subnet is not available\")"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        subnet_mgmt_id \u003d subnets.get(\u0027subnet_mgmt\u0027)"},{"line_number":1129,"context_line":"        if not subnet_mgmt_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6eb7abbd_bac3b92d","line":1126,"range":{"start_line":1120,"start_character":8,"end_line":1126,"end_character":56},"in_reply_to":"9b8711b4_97da2f36","updated":"2021-07-14 01:59:42.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":1117,"context_line":"        if not net_mgmt_id:"},{"line_number":1118,"context_line":"            self.fail(\"net_mgmt network is not available\")"},{"line_number":1119,"context_line":""},{"line_number":1120,"context_line":"        subnet0_id \u003d subnets.get(\u0027subnet0\u0027)"},{"line_number":1121,"context_line":"        if not subnet0_id:"},{"line_number":1122,"context_line":"            self.fail(\"subnet0 subnet is not available\")"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"        subnet1_id \u003d subnets.get(\u0027subnet1\u0027)"},{"line_number":1125,"context_line":"        if not subnet1_id:"},{"line_number":1126,"context_line":"            self.fail(\"subnet1 subnet is not available\")"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"        subnet_mgmt_id \u003d subnets.get(\u0027subnet_mgmt\u0027)"},{"line_number":1129,"context_line":"        if not subnet_mgmt_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9b8711b4_97da2f36","line":1126,"range":{"start_line":1120,"start_character":8,"end_line":1126,"end_character":56},"in_reply_to":"9c7082db_df285496","updated":"2021-07-05 04:48:47.000000000","message":"These confirmations are not needed, so we will remove.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":1170,"context_line":"        self._assert_occ_list(resp, op_occs_info)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        # Wait for operation state completed"},{"line_number":1173,"context_line":"        time.sleep(10)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        # Terminate vnf gracefully with graceful timeout set to 60"},{"line_number":1176,"context_line":"        terminate_req_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"23063805_89166874","line":1173,"updated":"2021-05-12 08:21:53.000000000","message":"What is this sleep for?\nIf you have a reason, please add a supplement in NOTE.\nAlso, is 10 seconds appropriate?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"99df35f1c9bfc5b631cc5459a46b57c8041637bf","unresolved":true,"context_lines":[{"line_number":1170,"context_line":"        self._assert_occ_list(resp, op_occs_info)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        # Wait for operation state completed"},{"line_number":1173,"context_line":"        time.sleep(10)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        # Terminate vnf gracefully with graceful timeout set to 60"},{"line_number":1176,"context_line":"        terminate_req_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"709e0e4a_99731191","line":1173,"in_reply_to":"23063805_89166874","updated":"2021-07-05 04:48:47.000000000","message":"In _change_ext_conn_vnf_instance, it is finished after finishing update of stack. At this time, LCM operation status doesn\u0027t shift to COMPLETE immediately, so sleeping process was added to avoid conflict with Termination process. It is avoidable to sleep during 2 or 3 sec., but set 10 sec as enough time.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"        self._assert_occ_list(resp, op_occs_info)"},{"line_number":1171,"context_line":""},{"line_number":1172,"context_line":"        # Wait for operation state completed"},{"line_number":1173,"context_line":"        time.sleep(10)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        # Terminate vnf gracefully with graceful timeout set to 60"},{"line_number":1176,"context_line":"        terminate_req_body \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6b53465_156bd3ae","line":1173,"in_reply_to":"709e0e4a_99731191","updated":"2021-07-14 01:59:42.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"28ebe5ad68a7efe87b7ca8230579192d16501d86","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import importlib"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":1,"id":"e840f663_36c582c6","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":9},"updated":"2021-05-17 10:27:19.000000000","message":"I think this part was changed in the following patch: \nhttps://review.opendev.org/c/openstack/tacker/+/784756\n\nCould you check if you posted this patch based the old file and merged wrong?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import importlib"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b6be1a1_519b683e","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":9},"in_reply_to":"2e53116a_3c3e8dc7","updated":"2021-07-14 01:59:42.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d8bacff2ec363393274274f98bda7a7aa8dd7a95","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import importlib"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":1,"id":"1def241d_9e900555","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":9},"in_reply_to":"3b6be1a1_519b683e","updated":"2021-07-30 00:55:17.000000000","message":"I\u0027ve confirmed.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d874ebee71d0d6ac2743cd5e1f395cd19dca0ecd","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import eventlet"},{"line_number":19,"context_line":"import importlib"},{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import re"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":"import time"},{"line_number":24,"context_line":"import yaml"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e53116a_3c3e8dc7","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":9},"in_reply_to":"e840f663_36c582c6","updated":"2021-07-05 04:51:02.000000000","message":"ok, we understood will make changes accordingly","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":1560,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"},{"line_number":1563,"context_line":"                                    cp_protocol_info.layer_protocol \u003d \u0027\\"},{"line_number":1564,"context_line":"                                        IP_OVER_ETHERNET\u0027"},{"line_number":1565,"context_line":"                                    ip_over_ethernet \u003d objects.\\"},{"line_number":1566,"context_line":"                                        IpOverEthernetAddressInfo()"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9e0c34a_d35c8c8f","line":1563,"updated":"2021-05-12 08:21:53.000000000","message":"I think this fix will insert a whitespace at the beginning of the IP_OVER_ETHERNET string.\nSo I think it needs not to be fixed, but is it intentional?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d874ebee71d0d6ac2743cd5e1f395cd19dca0ecd","unresolved":true,"context_lines":[{"line_number":1560,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"},{"line_number":1563,"context_line":"                                    cp_protocol_info.layer_protocol \u003d \u0027\\"},{"line_number":1564,"context_line":"                                        IP_OVER_ETHERNET\u0027"},{"line_number":1565,"context_line":"                                    ip_over_ethernet \u003d objects.\\"},{"line_number":1566,"context_line":"                                        IpOverEthernetAddressInfo()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d57cce7d_138efa1b","line":1563,"in_reply_to":"c9e0c34a_d35c8c8f","updated":"2021-07-05 04:51:02.000000000","message":"ok, we understood will make changes accordingly","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"},{"line_number":1563,"context_line":"                                    cp_protocol_info.layer_protocol \u003d \u0027\\"},{"line_number":1564,"context_line":"                                        IP_OVER_ETHERNET\u0027"},{"line_number":1565,"context_line":"                                    ip_over_ethernet \u003d objects.\\"},{"line_number":1566,"context_line":"                                        IpOverEthernetAddressInfo()"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6a6019f_d1065125","line":1563,"in_reply_to":"d57cce7d_138efa1b","updated":"2021-07-14 01:59:42.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"28ebe5ad68a7efe87b7ca8230579192d16501d86","unresolved":true,"context_lines":[{"line_number":1560,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"},{"line_number":1563,"context_line":"                                    cp_protocol_info.layer_protocol \u003d \u0027\\"},{"line_number":1564,"context_line":"                                        IP_OVER_ETHERNET\u0027"},{"line_number":1565,"context_line":"                                    ip_over_ethernet \u003d objects.\\"},{"line_number":1566,"context_line":"                                        IpOverEthernetAddressInfo()"},{"line_number":1567,"context_line":"                                    ip_over_ethernet.mac_address \u003d rsc_info.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"08f5d6bb_868a02c5","line":1564,"range":{"start_line":1563,"start_character":70,"end_line":1564,"end_character":57},"updated":"2021-05-17 10:27:19.000000000","message":"ditto","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d874ebee71d0d6ac2743cd5e1f395cd19dca0ecd","unresolved":true,"context_lines":[{"line_number":1560,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"},{"line_number":1563,"context_line":"                                    cp_protocol_info.layer_protocol \u003d \u0027\\"},{"line_number":1564,"context_line":"                                        IP_OVER_ETHERNET\u0027"},{"line_number":1565,"context_line":"                                    ip_over_ethernet \u003d objects.\\"},{"line_number":1566,"context_line":"                                        IpOverEthernetAddressInfo()"},{"line_number":1567,"context_line":"                                    ip_over_ethernet.mac_address \u003d rsc_info.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbe365c7_8a2c76b2","line":1564,"range":{"start_line":1563,"start_character":70,"end_line":1564,"end_character":57},"in_reply_to":"08f5d6bb_868a02c5","updated":"2021-07-05 04:51:02.000000000","message":"ok, we understood will make changes accordingly","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d8bacff2ec363393274274f98bda7a7aa8dd7a95","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1561,"context_line":""},{"line_number":1562,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"},{"line_number":1563,"context_line":"                                    cp_protocol_info.layer_protocol \u003d \u0027\\"},{"line_number":1564,"context_line":"                                        IP_OVER_ETHERNET\u0027"},{"line_number":1565,"context_line":"                                    ip_over_ethernet \u003d objects.\\"},{"line_number":1566,"context_line":"                                        IpOverEthernetAddressInfo()"},{"line_number":1567,"context_line":"                                    ip_over_ethernet.mac_address \u003d rsc_info.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"273be844_934aeb81","line":1564,"range":{"start_line":1563,"start_character":70,"end_line":1564,"end_character":57},"in_reply_to":"dbe365c7_8a2c76b2","updated":"2021-07-30 00:55:17.000000000","message":"I\u0027ve confirmed.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"28ebe5ad68a7efe87b7ca8230579192d16501d86","unresolved":true,"context_lines":[{"line_number":1575,"context_line":"                                    ip_addresses.addresses \u003d []"},{"line_number":1576,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1577,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1578,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1579,"context_line":"                                        if re.match("},{"line_number":1580,"context_line":"                                            r\u0027^\\d{1,3}\\"},{"line_number":1581,"context_line":"                                                (\\.\\d{1,3}){3}\\"},{"line_number":1582,"context_line":"                                                    (/\\d{1,2})?$\u0027,"},{"line_number":1583,"context_line":"                                                ip_addr):"},{"line_number":1584,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1585,"context_line":"                                        else:"},{"line_number":1586,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1587,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1588,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("},{"line_number":1589,"context_line":"                                            \u0027subnet_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3cdeb717_8ce159d5","line":1586,"range":{"start_line":1578,"start_character":0,"end_line":1586,"end_character":70},"updated":"2021-05-17 10:27:19.000000000","message":"ditto","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d874ebee71d0d6ac2743cd5e1f395cd19dca0ecd","unresolved":true,"context_lines":[{"line_number":1575,"context_line":"                                    ip_addresses.addresses \u003d []"},{"line_number":1576,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1577,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1578,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1579,"context_line":"                                        if re.match("},{"line_number":1580,"context_line":"                                            r\u0027^\\d{1,3}\\"},{"line_number":1581,"context_line":"                                                (\\.\\d{1,3}){3}\\"},{"line_number":1582,"context_line":"                                                    (/\\d{1,2})?$\u0027,"},{"line_number":1583,"context_line":"                                                ip_addr):"},{"line_number":1584,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1585,"context_line":"                                        else:"},{"line_number":1586,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1587,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1588,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("},{"line_number":1589,"context_line":"                                            \u0027subnet_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e2c9f667_2aa714ff","line":1586,"range":{"start_line":1578,"start_character":0,"end_line":1586,"end_character":70},"in_reply_to":"3cdeb717_8ce159d5","updated":"2021-07-05 04:51:02.000000000","message":"ok, we understood will make changes accordingly","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d8bacff2ec363393274274f98bda7a7aa8dd7a95","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"                                    ip_addresses.addresses \u003d []"},{"line_number":1576,"context_line":"                                    for fixed_ip in rsc_info.attributes.get("},{"line_number":1577,"context_line":"                                            \u0027fixed_ips\u0027):"},{"line_number":1578,"context_line":"                                        ip_addr \u003d fixed_ip.get(\u0027ip_address\u0027)"},{"line_number":1579,"context_line":"                                        if re.match("},{"line_number":1580,"context_line":"                                            r\u0027^\\d{1,3}\\"},{"line_number":1581,"context_line":"                                                (\\.\\d{1,3}){3}\\"},{"line_number":1582,"context_line":"                                                    (/\\d{1,2})?$\u0027,"},{"line_number":1583,"context_line":"                                                ip_addr):"},{"line_number":1584,"context_line":"                                            ip_addresses.type \u003d \u0027IPV4\u0027"},{"line_number":1585,"context_line":"                                        else:"},{"line_number":1586,"context_line":"                                            ip_addresses.type \u003d \u0027IPV6\u0027"},{"line_number":1587,"context_line":"                                        ip_addresses.addresses.append(ip_addr)"},{"line_number":1588,"context_line":"                                        ip_addresses.subnet_id \u003d fixed_ip.get("},{"line_number":1589,"context_line":"                                            \u0027subnet_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e64a9fb_7edd7fac","line":1586,"range":{"start_line":1578,"start_character":0,"end_line":1586,"end_character":70},"in_reply_to":"e2c9f667_2aa714ff","updated":"2021-07-30 00:55:17.000000000","message":"I\u0027ve confirmed.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":1602,"context_line":"                                            resource.resource_id \u003d\\"},{"line_number":1603,"context_line":"                                                rsc_info.physical_resource_id"},{"line_number":1604,"context_line":"                                            resource.vim_level_resource_type \u003d \u0027\\"},{"line_number":1605,"context_line":"                                                OS::Neutron::Port\u0027"},{"line_number":1606,"context_line":"                                            if not vl.vnf_link_ports:"},{"line_number":1607,"context_line":"                                                vl.vnf_link_ports \u003d []"},{"line_number":1608,"context_line":"                                            link_port_info \u003d objects.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2f55719_43d24676","line":1605,"updated":"2021-05-12 08:21:53.000000000","message":"I think you can use NEUTRON_PORT_RESOURCE.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"28ebe5ad68a7efe87b7ca8230579192d16501d86","unresolved":true,"context_lines":[{"line_number":1601,"context_line":"                                                vim_connection_info.id"},{"line_number":1602,"context_line":"                                            resource.resource_id \u003d\\"},{"line_number":1603,"context_line":"                                                rsc_info.physical_resource_id"},{"line_number":1604,"context_line":"                                            resource.vim_level_resource_type \u003d \u0027\\"},{"line_number":1605,"context_line":"                                                OS::Neutron::Port\u0027"},{"line_number":1606,"context_line":"                                            if not vl.vnf_link_ports:"},{"line_number":1607,"context_line":"                                                vl.vnf_link_ports \u003d []"},{"line_number":1608,"context_line":"                                            link_port_info \u003d objects.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aae96a6_55eded4d","line":1605,"range":{"start_line":1604,"start_character":79,"end_line":1605,"end_character":66},"updated":"2021-05-17 10:27:19.000000000","message":"ditto","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d8bacff2ec363393274274f98bda7a7aa8dd7a95","unresolved":false,"context_lines":[{"line_number":1601,"context_line":"                                                vim_connection_info.id"},{"line_number":1602,"context_line":"                                            resource.resource_id \u003d\\"},{"line_number":1603,"context_line":"                                                rsc_info.physical_resource_id"},{"line_number":1604,"context_line":"                                            resource.vim_level_resource_type \u003d \u0027\\"},{"line_number":1605,"context_line":"                                                OS::Neutron::Port\u0027"},{"line_number":1606,"context_line":"                                            if not vl.vnf_link_ports:"},{"line_number":1607,"context_line":"                                                vl.vnf_link_ports \u003d []"},{"line_number":1608,"context_line":"                                            link_port_info \u003d objects.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"27905797_4f425ad9","line":1605,"range":{"start_line":1604,"start_character":79,"end_line":1605,"end_character":66},"in_reply_to":"0bc3473d_d25db2db","updated":"2021-07-30 00:55:17.000000000","message":"I\u0027ve confirmed.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":false,"context_lines":[{"line_number":1602,"context_line":"                                            resource.resource_id \u003d\\"},{"line_number":1603,"context_line":"                                                rsc_info.physical_resource_id"},{"line_number":1604,"context_line":"                                            resource.vim_level_resource_type \u003d \u0027\\"},{"line_number":1605,"context_line":"                                                OS::Neutron::Port\u0027"},{"line_number":1606,"context_line":"                                            if not vl.vnf_link_ports:"},{"line_number":1607,"context_line":"                                                vl.vnf_link_ports \u003d []"},{"line_number":1608,"context_line":"                                            link_port_info \u003d objects.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"a55a60d7_c30a4c3d","line":1605,"in_reply_to":"55d51bfd_11654896","updated":"2021-07-14 01:59:42.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d874ebee71d0d6ac2743cd5e1f395cd19dca0ecd","unresolved":true,"context_lines":[{"line_number":1601,"context_line":"                                                vim_connection_info.id"},{"line_number":1602,"context_line":"                                            resource.resource_id \u003d\\"},{"line_number":1603,"context_line":"                                                rsc_info.physical_resource_id"},{"line_number":1604,"context_line":"                                            resource.vim_level_resource_type \u003d \u0027\\"},{"line_number":1605,"context_line":"                                                OS::Neutron::Port\u0027"},{"line_number":1606,"context_line":"                                            if not vl.vnf_link_ports:"},{"line_number":1607,"context_line":"                                                vl.vnf_link_ports \u003d []"},{"line_number":1608,"context_line":"                                            link_port_info \u003d objects.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bc3473d_d25db2db","line":1605,"range":{"start_line":1604,"start_character":79,"end_line":1605,"end_character":66},"in_reply_to":"5aae96a6_55eded4d","updated":"2021-07-05 04:51:02.000000000","message":"ok, we understood will make changes accordingly","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d874ebee71d0d6ac2743cd5e1f395cd19dca0ecd","unresolved":true,"context_lines":[{"line_number":1602,"context_line":"                                            resource.resource_id \u003d\\"},{"line_number":1603,"context_line":"                                                rsc_info.physical_resource_id"},{"line_number":1604,"context_line":"                                            resource.vim_level_resource_type \u003d \u0027\\"},{"line_number":1605,"context_line":"                                                OS::Neutron::Port\u0027"},{"line_number":1606,"context_line":"                                            if not vl.vnf_link_ports:"},{"line_number":1607,"context_line":"                                                vl.vnf_link_ports \u003d []"},{"line_number":1608,"context_line":"                                            link_port_info \u003d objects.\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"55d51bfd_11654896","line":1605,"in_reply_to":"c2f55719_43d24676","updated":"2021-07-05 04:51:02.000000000","message":"ok, we understood will make changes accordingly","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"4bbf2152c9ee8888c3b0c57b8bfcce6adbdd1156","unresolved":true,"context_lines":[{"line_number":2178,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id)"},{"line_number":2179,"context_line":"        vnf_dict[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(stack_param)})"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def _change_ext_conn_vnf("},{"line_number":2182,"context_line":"            self,"},{"line_number":2183,"context_line":"            context,"},{"line_number":2184,"context_line":"            hot_updater,"}],"source_content_type":"text/x-python","patch_set":1,"id":"92b0ef99_e189d75f","line":2181,"range":{"start_line":2181,"start_character":8,"end_line":2181,"end_character":28},"updated":"2021-05-12 08:21:53.000000000","message":"I think \u0027_change_ext_conn_vnf_with_tosca\u0027 is better.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"a75fd26e2f61a7a1a595e0e7fd9bccedbd131bd4","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id)"},{"line_number":2179,"context_line":"        vnf_dict[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(stack_param)})"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def _change_ext_conn_vnf("},{"line_number":2182,"context_line":"            self,"},{"line_number":2183,"context_line":"            context,"},{"line_number":2184,"context_line":"            hot_updater,"}],"source_content_type":"text/x-python","patch_set":1,"id":"90d8028e_c2315ff2","line":2181,"range":{"start_line":2181,"start_character":8,"end_line":2181,"end_character":28},"in_reply_to":"5b9985ec_f9a34b1b","updated":"2021-07-19 07:07:16.000000000","message":"Done","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"b38f801854a30afe273c72b29a7eb994bc8f7626","unresolved":true,"context_lines":[{"line_number":2178,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id)"},{"line_number":2179,"context_line":"        vnf_dict[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(stack_param)})"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def _change_ext_conn_vnf("},{"line_number":2182,"context_line":"            self,"},{"line_number":2183,"context_line":"            context,"},{"line_number":2184,"context_line":"            hot_updater,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b9985ec_f9a34b1b","line":2181,"range":{"start_line":2181,"start_character":8,"end_line":2181,"end_character":28},"in_reply_to":"5be909e6_300b1155","updated":"2021-07-14 01:59:42.000000000","message":"It doesn\u0027t seem to be fixed.\nCould you check it again?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d8bacff2ec363393274274f98bda7a7aa8dd7a95","unresolved":true,"context_lines":[{"line_number":2178,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id)"},{"line_number":2179,"context_line":"        vnf_dict[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(stack_param)})"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def _change_ext_conn_vnf("},{"line_number":2182,"context_line":"            self,"},{"line_number":2183,"context_line":"            context,"},{"line_number":2184,"context_line":"            hot_updater,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ddfb8d8b_2b51618f","line":2181,"range":{"start_line":2181,"start_character":8,"end_line":2181,"end_character":28},"in_reply_to":"90d8028e_c2315ff2","updated":"2021-07-30 00:55:17.000000000","message":"It seems to be degraded from PS6. Could you check again?","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"d874ebee71d0d6ac2743cd5e1f395cd19dca0ecd","unresolved":true,"context_lines":[{"line_number":2178,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id)"},{"line_number":2179,"context_line":"        vnf_dict[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(stack_param)})"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def _change_ext_conn_vnf("},{"line_number":2182,"context_line":"            self,"},{"line_number":2183,"context_line":"            context,"},{"line_number":2184,"context_line":"            hot_updater,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5be909e6_300b1155","line":2181,"range":{"start_line":2181,"start_character":8,"end_line":2181,"end_character":28},"in_reply_to":"92b0ef99_e189d75f","updated":"2021-07-05 04:51:02.000000000","message":"ok, we understood will make changes accordingly","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"58210dafcfc126d4495ac8e6a1f93a2edc585871","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id)"},{"line_number":2179,"context_line":"        vnf_dict[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(stack_param)})"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def _change_ext_conn_vnf("},{"line_number":2182,"context_line":"            self,"},{"line_number":2183,"context_line":"            context,"},{"line_number":2184,"context_line":"            hot_updater,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e3f8dba_23324122","line":2181,"range":{"start_line":2181,"start_character":8,"end_line":2181,"end_character":28},"in_reply_to":"b46586d9_858301dc","updated":"2021-08-02 00:30:46.000000000","message":"Thanks for rework, I\u0027ve confirmed.","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"5cb540592d4a109fd84007237d8706835c9cdaa4","unresolved":true,"context_lines":[{"line_number":2178,"context_line":"            vnf_instance.instantiated_vnf_info.instance_id)"},{"line_number":2179,"context_line":"        vnf_dict[\u0027attributes\u0027].update({\u0027stack_param\u0027: str(stack_param)})"},{"line_number":2180,"context_line":""},{"line_number":2181,"context_line":"    def _change_ext_conn_vnf("},{"line_number":2182,"context_line":"            self,"},{"line_number":2183,"context_line":"            context,"},{"line_number":2184,"context_line":"            hot_updater,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b46586d9_858301dc","line":2181,"range":{"start_line":2181,"start_character":8,"end_line":2181,"end_character":28},"in_reply_to":"ddfb8d8b_2b51618f","updated":"2021-08-01 11:31:03.000000000","message":"Thanks. for pointing it out we have incorporated the changes in patchset 8","commit_id":"f47cdf65484d39d28ba289bb16f448bab5c35068"}]}