)]}'
{"tacker/tests/unit/vnflcm/test_controller.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"d0e8c1ec3beda28ad52fa1db3e5285cecd8fe629","unresolved":true,"context_lines":[{"line_number":638,"context_line":"        req \u003d fake_request.HTTPRequest.blank("},{"line_number":639,"context_line":"            \u0027/vnf_instances/%s/instantiate\u0027 % uuidsentinel.vnf_instance_id)"},{"line_number":640,"context_line":"        req.body \u003d jsonutils.dump_as_bytes(body)"},{"line_number":641,"context_line":"        req.headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":642,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        # Call Instantiate API"}],"source_content_type":"text/x-python","patch_set":2,"id":"aa3ee3d9_649ee52b","line":641,"range":{"start_line":641,"start_character":9,"end_line":641,"end_character":56},"updated":"2021-06-09 05:42:39.000000000","message":"The content-type is \u0027application/json\u0027, IMO this should change as well to \u0027application/problem+json\u0027. Please share your opinion.","commit_id":"2c3799edbd414029e997c27715dea2198da3cb54"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"8aa3669785460dbd2de9812eb54132c94e458ef3","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        req \u003d fake_request.HTTPRequest.blank("},{"line_number":639,"context_line":"            \u0027/vnf_instances/%s/instantiate\u0027 % uuidsentinel.vnf_instance_id)"},{"line_number":640,"context_line":"        req.body \u003d jsonutils.dump_as_bytes(body)"},{"line_number":641,"context_line":"        req.headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":642,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        # Call Instantiate API"}],"source_content_type":"text/x-python","patch_set":2,"id":"47e3c1c9_1e9aa276","line":641,"range":{"start_line":641,"start_character":9,"end_line":641,"end_character":56},"in_reply_to":"17efe9ef_804d291f","updated":"2021-06-11 01:17:26.000000000","message":"I added a verification of whether `resp.content_type` is `application/problem+json` in the test.","commit_id":"2c3799edbd414029e997c27715dea2198da3cb54"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"2b0a4f576994a1a2bb2a2f286cf9f0fa1d31a5d3","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        req \u003d fake_request.HTTPRequest.blank("},{"line_number":639,"context_line":"            \u0027/vnf_instances/%s/instantiate\u0027 % uuidsentinel.vnf_instance_id)"},{"line_number":640,"context_line":"        req.body \u003d jsonutils.dump_as_bytes(body)"},{"line_number":641,"context_line":"        req.headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":642,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        # Call Instantiate API"}],"source_content_type":"text/x-python","patch_set":2,"id":"17efe9ef_804d291f","line":641,"range":{"start_line":641,"start_character":9,"end_line":641,"end_character":56},"in_reply_to":"a44a240c_9ba7a1c2","updated":"2021-06-09 06:11:50.000000000","message":"My bad!! Thank you for correcting me. Yes totally agree with your opinion, the request should not change but we could check response content type.","commit_id":"2c3799edbd414029e997c27715dea2198da3cb54"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"a6fa49c5d81ae34587af2c84c09bee5c1e8473f6","unresolved":true,"context_lines":[{"line_number":638,"context_line":"        req \u003d fake_request.HTTPRequest.blank("},{"line_number":639,"context_line":"            \u0027/vnf_instances/%s/instantiate\u0027 % uuidsentinel.vnf_instance_id)"},{"line_number":640,"context_line":"        req.body \u003d jsonutils.dump_as_bytes(body)"},{"line_number":641,"context_line":"        req.headers[\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":642,"context_line":"        req.method \u003d \u0027POST\u0027"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"        # Call Instantiate API"}],"source_content_type":"text/x-python","patch_set":2,"id":"a44a240c_9ba7a1c2","line":641,"range":{"start_line":641,"start_character":9,"end_line":641,"end_character":56},"in_reply_to":"aa3ee3d9_649ee52b","updated":"2021-06-09 05:54:19.000000000","message":"I suppose this is a request and thus doesn\u0027t need to be changed.\nAm I correct?\nBut, it might be better to check `resp.content_type` in the tests.","commit_id":"2c3799edbd414029e997c27715dea2198da3cb54"}],"tacker/wsgi.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"74367a230831685b669b2c3800a2ebb21ec21b8b","unresolved":true,"context_lines":[{"line_number":1038,"context_line":"class Fault(webob.exc.HTTPException):"},{"line_number":1039,"context_line":"    \"\"\"Wrap webob.exc.HTTPException to provide API friendly response.\"\"\""},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"    _fault_names \u003d {"},{"line_number":1042,"context_line":"        400: \"Bad Request\","},{"line_number":1043,"context_line":"        401: \"Unauthorized\","},{"line_number":1044,"context_line":"        403: \"Forbidden\","},{"line_number":1045,"context_line":"        404: \"Not Found\","},{"line_number":1046,"context_line":"        405: \"Method Not Allowed\","},{"line_number":1047,"context_line":"        406: \"Not Acceptable\","},{"line_number":1048,"context_line":"        409: \"Conflict\","},{"line_number":1049,"context_line":"        413: \"Payload Too Large\","},{"line_number":1050,"context_line":"        414: \"URI Too Long\","},{"line_number":1051,"context_line":"        415: \"Unsupported Media Type\","},{"line_number":1052,"context_line":"        422: \"Unprocessable Entity\","},{"line_number":1053,"context_line":"        429: \"Too Many Requests\","},{"line_number":1054,"context_line":"        500: \"Internal Server Error\","},{"line_number":1055,"context_line":"        501: \"Not Implemented\","},{"line_number":1056,"context_line":"        503: \"Service Unavailable\","},{"line_number":1057,"context_line":"        504: \"Gateway Timeout\"}"},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"    def __init__(self, exception):"},{"line_number":1060,"context_line":"        \"\"\"Create a Fault for the given webob.exc.exception.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffde5e1e_94a4b9b0","line":1057,"range":{"start_line":1041,"start_character":0,"end_line":1057,"end_character":31},"updated":"2021-07-20 02:12:58.000000000","message":"You should use default package `http.client` if you make the reasons as RFC. `http.client.response[code]` returns a reason for `code`, such as following example. So, I recommend to remove the definition.\n\n```\nhttp.client.responses[404]\n\u003e\u003e\u003e \u0027Not Found\u0027\n```","commit_id":"52ea7f3469061179df0e14af530e212d9bd0e167"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"97847ef93bce6e2d9491b3ab431d18ff7aeb7fdb","unresolved":true,"context_lines":[{"line_number":1038,"context_line":"class Fault(webob.exc.HTTPException):"},{"line_number":1039,"context_line":"    \"\"\"Wrap webob.exc.HTTPException to provide API friendly response.\"\"\""},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"    _fault_names \u003d {"},{"line_number":1042,"context_line":"        400: \"Bad Request\","},{"line_number":1043,"context_line":"        401: \"Unauthorized\","},{"line_number":1044,"context_line":"        403: \"Forbidden\","},{"line_number":1045,"context_line":"        404: \"Not Found\","},{"line_number":1046,"context_line":"        405: \"Method Not Allowed\","},{"line_number":1047,"context_line":"        406: \"Not Acceptable\","},{"line_number":1048,"context_line":"        409: \"Conflict\","},{"line_number":1049,"context_line":"        413: \"Payload Too Large\","},{"line_number":1050,"context_line":"        414: \"URI Too Long\","},{"line_number":1051,"context_line":"        415: \"Unsupported Media Type\","},{"line_number":1052,"context_line":"        422: \"Unprocessable Entity\","},{"line_number":1053,"context_line":"        429: \"Too Many Requests\","},{"line_number":1054,"context_line":"        500: \"Internal Server Error\","},{"line_number":1055,"context_line":"        501: \"Not Implemented\","},{"line_number":1056,"context_line":"        503: \"Service Unavailable\","},{"line_number":1057,"context_line":"        504: \"Gateway Timeout\"}"},{"line_number":1058,"context_line":""},{"line_number":1059,"context_line":"    def __init__(self, exception):"},{"line_number":1060,"context_line":"        \"\"\"Create a Fault for the given webob.exc.exception.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"16e2bd19_42b4362d","line":1057,"range":{"start_line":1041,"start_character":0,"end_line":1057,"end_character":31},"in_reply_to":"ffde5e1e_94a4b9b0","updated":"2021-07-30 07:20:24.000000000","message":"Thank you for your comment.\nI removed the definition.","commit_id":"52ea7f3469061179df0e14af530e212d9bd0e167"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"74367a230831685b669b2c3800a2ebb21ec21b8b","unresolved":true,"context_lines":[{"line_number":1069,"context_line":"        user_locale \u003d req.best_match_language()"},{"line_number":1070,"context_line":"        # Replace the body with fault details."},{"line_number":1071,"context_line":"        code \u003d self.wrapped_exc.status_int"},{"line_number":1072,"context_line":"        fault_name \u003d self._fault_names.get(code)"},{"line_number":1073,"context_line":"        explanation \u003d self.wrapped_exc.explanation"},{"line_number":1074,"context_line":"        LOG.debug(\"Returning %(code)s to user: %(explanation)s\","},{"line_number":1075,"context_line":"                  {\u0027code\u0027: code, \u0027explanation\u0027: explanation})"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc45d2f6_8a36cd8d","line":1072,"updated":"2021-07-20 02:12:58.000000000","message":"It\u0027s better to use `http.client.responses[code] instead.","commit_id":"52ea7f3469061179df0e14af530e212d9bd0e167"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"97847ef93bce6e2d9491b3ab431d18ff7aeb7fdb","unresolved":true,"context_lines":[{"line_number":1069,"context_line":"        user_locale \u003d req.best_match_language()"},{"line_number":1070,"context_line":"        # Replace the body with fault details."},{"line_number":1071,"context_line":"        code \u003d self.wrapped_exc.status_int"},{"line_number":1072,"context_line":"        fault_name \u003d self._fault_names.get(code)"},{"line_number":1073,"context_line":"        explanation \u003d self.wrapped_exc.explanation"},{"line_number":1074,"context_line":"        LOG.debug(\"Returning %(code)s to user: %(explanation)s\","},{"line_number":1075,"context_line":"                  {\u0027code\u0027: code, \u0027explanation\u0027: explanation})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae6d8ec0_adc225b9","line":1072,"in_reply_to":"cc45d2f6_8a36cd8d","updated":"2021-07-30 07:20:24.000000000","message":"I used `http.client.responses[code]` instead.","commit_id":"52ea7f3469061179df0e14af530e212d9bd0e167"}]}