)]}'
{"tacker/conductor/conductor_server.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0b1ab6159b403eed048aed6dc6e4317d0648382c","unresolved":true,"context_lines":[{"line_number":1203,"context_line":"        self.vnf_manager.invoke("},{"line_number":1204,"context_line":"            vim_connection_info.vim_type,"},{"line_number":1205,"context_line":"            \u0027get_grant_resource\u0027,"},{"line_number":1206,"context_line":"            plugin\u003dself,"},{"line_number":1207,"context_line":"            vnf_instance\u003dvnf_instance,"},{"line_number":1208,"context_line":"            vnf_info\u003dvnf_dict,"},{"line_number":1209,"context_line":"            scale_vnf_request\u003dscale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d92b226d_ce2a9eb4","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":0,"end_line":1206,"end_character":1},"updated":"2021-06-07 07:59:40.000000000","message":"Could you please leave this arg?\nAs discussed at https://bugs.launchpad.net/tacker/+bug/1924956, we\u0027re concerned about deleting `plugin` arg might break the common style in `conductor_server` that almost every method have this arg.\nSo, my suggestion is to leave `plugin` arg and add it to the abstract class. \nIf you agree, please modify your patch to leave this arg.\nI\u0027ll post my patch after your patch is merged.","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"0ec704f9775c46a0791490cf1887449f88606dbf","unresolved":true,"context_lines":[{"line_number":1203,"context_line":"        self.vnf_manager.invoke("},{"line_number":1204,"context_line":"            vim_connection_info.vim_type,"},{"line_number":1205,"context_line":"            \u0027get_grant_resource\u0027,"},{"line_number":1206,"context_line":"            plugin\u003dself,"},{"line_number":1207,"context_line":"            vnf_instance\u003dvnf_instance,"},{"line_number":1208,"context_line":"            vnf_info\u003dvnf_dict,"},{"line_number":1209,"context_line":"            scale_vnf_request\u003dscale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7de16430_90d18e80","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":0,"end_line":1206,"end_character":1},"in_reply_to":"6a37e7d8_202db84f","updated":"2021-06-08 08:51:37.000000000","message":"I have added this arg into conductor_server, infra_driver and abstract class again in the newest patch. Please kindly check it again.","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ba347e5c21308a8e828f96813b9e07afbb6b88a6","unresolved":false,"context_lines":[{"line_number":1203,"context_line":"        self.vnf_manager.invoke("},{"line_number":1204,"context_line":"            vim_connection_info.vim_type,"},{"line_number":1205,"context_line":"            \u0027get_grant_resource\u0027,"},{"line_number":1206,"context_line":"            plugin\u003dself,"},{"line_number":1207,"context_line":"            vnf_instance\u003dvnf_instance,"},{"line_number":1208,"context_line":"            vnf_info\u003dvnf_dict,"},{"line_number":1209,"context_line":"            scale_vnf_request\u003dscale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"47227f5e_479fd772","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":0,"end_line":1206,"end_character":1},"in_reply_to":"7de16430_90d18e80","updated":"2021-06-09 02:00:49.000000000","message":"Thank you for your response.\nAs for https://bugs.launchpad.net/tacker/+bug/1924956, LGTM.\nAs your latest patch solve the above bug, it seems no need to post my patch.","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1"},{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"9018bd9404c773b4e5fc934a8b040e92e312b92a","unresolved":true,"context_lines":[{"line_number":1203,"context_line":"        self.vnf_manager.invoke("},{"line_number":1204,"context_line":"            vim_connection_info.vim_type,"},{"line_number":1205,"context_line":"            \u0027get_grant_resource\u0027,"},{"line_number":1206,"context_line":"            plugin\u003dself,"},{"line_number":1207,"context_line":"            vnf_instance\u003dvnf_instance,"},{"line_number":1208,"context_line":"            vnf_info\u003dvnf_dict,"},{"line_number":1209,"context_line":"            scale_vnf_request\u003dscale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a37e7d8_202db84f","side":"PARENT","line":1206,"range":{"start_line":1206,"start_character":0,"end_line":1206,"end_character":1},"in_reply_to":"d92b226d_ce2a9eb4","updated":"2021-06-08 08:31:59.000000000","message":"Thank you for your comment. I have added this arg into conductor_server, infra_driver and abstract class again in the newest patch. Please kindly check it again.","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"2276764b8852f25d3fdb631a8d5caae7a25f3bb1","unresolved":true,"context_lines":[{"line_number":1251,"context_line":"        add_resources \u003d []"},{"line_number":1252,"context_line":"        update_resources \u003d []"},{"line_number":1253,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1254,"context_line":"            # init remove_resources"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1257,"context_line":"                resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":5,"id":"f30022f0_32a80f95","line":1254,"updated":"2021-06-10 05:12:37.000000000","message":"Since the process is long, can it be made into a subfunction like \"def init_remove_resources\"?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c686c6e7c017de0b438dbf4bdf87887c2444cd3a","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"        add_resources \u003d []"},{"line_number":1252,"context_line":"        update_resources \u003d []"},{"line_number":1253,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1254,"context_line":"            # init remove_resources"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1257,"context_line":"                resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":5,"id":"82ad14a7_0226f2c5","line":1254,"in_reply_to":"c0911493_f7183a56","updated":"2021-07-19 06:43:09.000000000","message":"Done","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bac837e4cfe0cf68c273f89b5dacc86ff5de4e95","unresolved":true,"context_lines":[{"line_number":1251,"context_line":"        add_resources \u003d []"},{"line_number":1252,"context_line":"        update_resources \u003d []"},{"line_number":1253,"context_line":"        if not heal_vnf_request.vnfc_instance_id:"},{"line_number":1254,"context_line":"            # init remove_resources"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":"            for vnfc_resource in vnf_inf.vnfc_resource_info:"},{"line_number":1257,"context_line":"                resource \u003d objects.ResourceDefinition()"}],"source_content_type":"text/x-python","patch_set":5,"id":"c0911493_f7183a56","line":1254,"in_reply_to":"f30022f0_32a80f95","updated":"2021-06-15 08:58:08.000000000","message":"Thank you for you comment. I will add a subfunction in next patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"2276764b8852f25d3fdb631a8d5caae7a25f3bb1","unresolved":true,"context_lines":[{"line_number":1322,"context_line":"                        resource.resource \u003d st_rh"},{"line_number":1323,"context_line":"                        rm_resources.append(resource)"},{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"            # init add_resources"},{"line_number":1326,"context_line":"            instantiate_vnf_request \u003d objects.InstantiateVnfRequest. \\"},{"line_number":1327,"context_line":"                from_vnf_instance(vnf_instance)"},{"line_number":1328,"context_line":"            vnfd_dict \u003d vnflcm_utils._get_vnfd_dict("}],"source_content_type":"text/x-python","patch_set":5,"id":"2b59fdc2_976a0f1b","line":1325,"updated":"2021-06-10 05:12:37.000000000","message":"ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bac837e4cfe0cf68c273f89b5dacc86ff5de4e95","unresolved":true,"context_lines":[{"line_number":1322,"context_line":"                        resource.resource \u003d st_rh"},{"line_number":1323,"context_line":"                        rm_resources.append(resource)"},{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"            # init add_resources"},{"line_number":1326,"context_line":"            instantiate_vnf_request \u003d objects.InstantiateVnfRequest. \\"},{"line_number":1327,"context_line":"                from_vnf_instance(vnf_instance)"},{"line_number":1328,"context_line":"            vnfd_dict \u003d vnflcm_utils._get_vnfd_dict("}],"source_content_type":"text/x-python","patch_set":5,"id":"94d0fbe5_c4c836e2","line":1325,"in_reply_to":"2b59fdc2_976a0f1b","updated":"2021-06-15 08:58:08.000000000","message":"ditto.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c686c6e7c017de0b438dbf4bdf87887c2444cd3a","unresolved":false,"context_lines":[{"line_number":1322,"context_line":"                        resource.resource \u003d st_rh"},{"line_number":1323,"context_line":"                        rm_resources.append(resource)"},{"line_number":1324,"context_line":""},{"line_number":1325,"context_line":"            # init add_resources"},{"line_number":1326,"context_line":"            instantiate_vnf_request \u003d objects.InstantiateVnfRequest. \\"},{"line_number":1327,"context_line":"                from_vnf_instance(vnf_instance)"},{"line_number":1328,"context_line":"            vnfd_dict \u003d vnflcm_utils._get_vnfd_dict("}],"source_content_type":"text/x-python","patch_set":5,"id":"644493a8_06dc6dce","line":1325,"in_reply_to":"94d0fbe5_c4c836e2","updated":"2021-07-19 06:43:09.000000000","message":"Done","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"}],"tacker/tests/etc/samples/etsi/nfv/functional7/Definitions/helloworld3_df_simple.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b9f0c65981d71f81f0dd55a9eaaef1d2d73b3795","unresolved":true,"context_lines":[{"line_number":64,"context_line":"          min_number_of_instances: 1"},{"line_number":65,"context_line":"          max_number_of_instances: 3"},{"line_number":66,"context_line":"        sw_image_data:"},{"line_number":67,"context_line":"          name: cirros-0.4.0-x86_64-disk"},{"line_number":68,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":69,"context_line":"          checksum:"},{"line_number":70,"context_line":"            algorithm: sha-256"},{"line_number":71,"context_line":"            hash: a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"13e108db_998e8458","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":26},"updated":"2021-09-10 07:50:54.000000000","message":"cirros version is updated to 0.5.2 in the merged patch [1].\n[1] https://review.opendev.org/c/openstack/tacker/+/798781\n\nCould you update it? Note that the hash value must also be changed.","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"de64cfff304bef8a9e60186a16d72ae9d05943a8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"          min_number_of_instances: 1"},{"line_number":65,"context_line":"          max_number_of_instances: 3"},{"line_number":66,"context_line":"        sw_image_data:"},{"line_number":67,"context_line":"          name: cirros-0.4.0-x86_64-disk"},{"line_number":68,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":69,"context_line":"          checksum:"},{"line_number":70,"context_line":"            algorithm: sha-256"},{"line_number":71,"context_line":"            hash: a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"18b60b67_aeedc553","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":26},"in_reply_to":"13e108db_998e8458","updated":"2021-09-13 12:44:26.000000000","message":"Updated code for review comments.","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d9d63a086414713b8e6d95c222ed89c957b6b104","unresolved":false,"context_lines":[{"line_number":64,"context_line":"          min_number_of_instances: 1"},{"line_number":65,"context_line":"          max_number_of_instances: 3"},{"line_number":66,"context_line":"        sw_image_data:"},{"line_number":67,"context_line":"          name: cirros-0.4.0-x86_64-disk"},{"line_number":68,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":69,"context_line":"          checksum:"},{"line_number":70,"context_line":"            algorithm: sha-256"},{"line_number":71,"context_line":"            hash: a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"80fcc9bd_5d9d24ad","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":26},"in_reply_to":"18b60b67_aeedc553","updated":"2021-09-15 07:21:31.000000000","message":"I have modified it to 0.5.2 in PS 18.","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2dc9a7e68c74390150f0cf5935bdf7aab886ccae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"          min_number_of_instances: 1"},{"line_number":65,"context_line":"          max_number_of_instances: 3"},{"line_number":66,"context_line":"        sw_image_data:"},{"line_number":67,"context_line":"          name: cirros-0.4.0-x86_64-disk"},{"line_number":68,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":69,"context_line":"          checksum:"},{"line_number":70,"context_line":"            algorithm: sha-256"},{"line_number":71,"context_line":"            hash: a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f5bd20c5_c043c39e","line":68,"range":{"start_line":67,"start_character":0,"end_line":68,"end_character":26},"in_reply_to":"80fcc9bd_5d9d24ad","updated":"2021-09-15 09:40:23.000000000","message":"I\u0027ve confirmed.","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b9f0c65981d71f81f0dd55a9eaaef1d2d73b3795","unresolved":true,"context_lines":[{"line_number":99,"context_line":"          min_number_of_instances: 1"},{"line_number":100,"context_line":"          max_number_of_instances: 1"},{"line_number":101,"context_line":"        sw_image_data:"},{"line_number":102,"context_line":"          name: cirros-0.4.0-x86_64-disk"},{"line_number":103,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":104,"context_line":"          checksum:"},{"line_number":105,"context_line":"            algorithm: sha-256"},{"line_number":106,"context_line":"            hash: a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d45b8a68_b5f44e9f","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":26},"updated":"2021-09-10 07:50:54.000000000","message":"ditto.","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2dc9a7e68c74390150f0cf5935bdf7aab886ccae","unresolved":false,"context_lines":[{"line_number":99,"context_line":"          min_number_of_instances: 1"},{"line_number":100,"context_line":"          max_number_of_instances: 1"},{"line_number":101,"context_line":"        sw_image_data:"},{"line_number":102,"context_line":"          name: cirros-0.4.0-x86_64-disk"},{"line_number":103,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":104,"context_line":"          checksum:"},{"line_number":105,"context_line":"            algorithm: sha-256"},{"line_number":106,"context_line":"            hash: a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1ad0742e_bc801dfa","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":26},"in_reply_to":"cd536f39_58eeb9ce","updated":"2021-09-15 09:40:23.000000000","message":"I\u0027ve confirmed.","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d9d63a086414713b8e6d95c222ed89c957b6b104","unresolved":true,"context_lines":[{"line_number":99,"context_line":"          min_number_of_instances: 1"},{"line_number":100,"context_line":"          max_number_of_instances: 1"},{"line_number":101,"context_line":"        sw_image_data:"},{"line_number":102,"context_line":"          name: cirros-0.4.0-x86_64-disk"},{"line_number":103,"context_line":"          version: \u00270.4.0\u0027"},{"line_number":104,"context_line":"          checksum:"},{"line_number":105,"context_line":"            algorithm: sha-256"},{"line_number":106,"context_line":"            hash: a8dd75ecffd4cdd96072d60c2237b448e0c8b2bc94d57f10fdbc8c481d9005b8"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"cd536f39_58eeb9ce","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":26},"in_reply_to":"d45b8a68_b5f44e9f","updated":"2021-09-15 07:21:31.000000000","message":"ditto","commit_id":"7d1430195b18900076420579346bb676c76f929a"}],"tacker/tests/etc/samples/helloworld3_types.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"04feb211d715d2392c4546bfbca7f2d07a608113","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9434173a_d3a44a64","line":1,"in_reply_to":"8b023395_1e8247c0","updated":"2021-07-28 01:37:43.000000000","message":"This file is etsi/nfv definition, so I think you should move to tacker/tests/etc/samples/etsi/nfv. (Create folder and move in if necessary.)","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"92310357342a34ef88510cc08f6ed7ce200f148e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"60dcb3a7_47b869f5","line":1,"in_reply_to":"9434173a_d3a44a64","updated":"2021-07-28 04:41:31.000000000","message":"I\u0027ve confirmed in PS9.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"}],"tacker/tests/etc/samples/sample_vnfd.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"04feb211d715d2392c4546bfbca7f2d07a608113","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"557325a0_4d73332d","line":1,"in_reply_to":"445fd4e0_257b7c6e","updated":"2021-07-28 01:37:43.000000000","message":"This file is etsi/nfv definition, so I think you should move to tacker/tests/etc/samples/etsi/nfv. (Create folder and move in if necessary.)","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"92310357342a34ef88510cc08f6ed7ce200f148e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"063ed6f0_61dcab87","line":1,"in_reply_to":"557325a0_4d73332d","updated":"2021-07-28 04:41:31.000000000","message":"I\u0027ve confirmed in PS9.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c686c6e7c017de0b438dbf4bdf87887c2444cd3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de45ce17_8efb705e","line":60,"range":{"start_line":42,"start_character":6,"end_line":60,"end_character":42},"in_reply_to":"b0cc8874_68dce654","updated":"2021-07-19 06:43:09.000000000","message":"Done","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"}],"tacker/tests/unit/conductor/helloworld3_types.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"56e1f0d9b9aa4edc65321d86f0350f5402bec8c1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b77119eb_e027d053","line":1,"updated":"2021-06-11 14:59:13.000000000","message":"I think `sample VNFD yaml file` should not be put in this directory.\nWhy don\u0027t you move to under tacker/tests/etc/samples?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f3e4f0c79a815f5c4086e6328840f8b4c9da52fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"description: VNF type definition"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8b023395_1e8247c0","line":1,"in_reply_to":"b77119eb_e027d053","updated":"2021-06-15 09:01:54.000000000","message":"I will add this file into tacker/tests/etc/samples in next patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"}],"tacker/tests/unit/conductor/sample_vnfd.yaml":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"56e1f0d9b9aa4edc65321d86f0350f5402bec8c1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"topology_template:"},{"line_number":4,"context_line":"  inputs:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b97aa034_42e5a9b0","line":1,"updated":"2021-06-11 14:59:13.000000000","message":"I think `sample VNFD yaml file` should not be put in this directory.\nWhy don\u0027t you move to under tacker/tests/etc/samples?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f3e4f0c79a815f5c4086e6328840f8b4c9da52fc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"tosca_definitions_version: tosca_simple_yaml_1_2"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"topology_template:"},{"line_number":4,"context_line":"  inputs:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"445fd4e0_257b7c6e","line":1,"in_reply_to":"b97aa034_42e5a9b0","updated":"2021-06-15 09:01:54.000000000","message":"I will add this file into tacker/tests/etc/samples in next patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"2276764b8852f25d3fdb631a8d5caae7a25f3bb1","unresolved":true,"context_lines":[{"line_number":39,"context_line":"      type: company.provider.VNF"},{"line_number":40,"context_line":"      properties:"},{"line_number":41,"context_line":"        flavour_description: A simple flavour"},{"line_number":42,"context_line":"      interfaces:"},{"line_number":43,"context_line":"        Vnflcm:"},{"line_number":44,"context_line":"          instantiate_end:"},{"line_number":45,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":46,"context_line":"          terminate_end:"},{"line_number":47,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":48,"context_line":"          heal_start:"},{"line_number":49,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":50,"context_line":"          heal_end:"},{"line_number":51,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":52,"context_line":"          scale_start:"},{"line_number":53,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":54,"context_line":"          scale_end:"},{"line_number":55,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":56,"context_line":"      artifacts:"},{"line_number":57,"context_line":"        mgmt-drivers-kubernetes:"},{"line_number":58,"context_line":"          description: Management driver for kubernetes cluster"},{"line_number":59,"context_line":"          type: tosca.artifacts.Implementation.Python"},{"line_number":60,"context_line":"          file: Scripts/kubernetes_mgmt.py"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    VDU1:"},{"line_number":63,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"a9737dfa_df7b0e8b","line":60,"range":{"start_line":42,"start_character":6,"end_line":60,"end_character":42},"updated":"2021-06-10 05:12:37.000000000","message":"Do you need these definitions to execute UT?\nIf you don\u0027t need it, you should better to delete it and make it a simpler VNFD.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bac837e4cfe0cf68c273f89b5dacc86ff5de4e95","unresolved":true,"context_lines":[{"line_number":39,"context_line":"      type: company.provider.VNF"},{"line_number":40,"context_line":"      properties:"},{"line_number":41,"context_line":"        flavour_description: A simple flavour"},{"line_number":42,"context_line":"      interfaces:"},{"line_number":43,"context_line":"        Vnflcm:"},{"line_number":44,"context_line":"          instantiate_end:"},{"line_number":45,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":46,"context_line":"          terminate_end:"},{"line_number":47,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":48,"context_line":"          heal_start:"},{"line_number":49,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":50,"context_line":"          heal_end:"},{"line_number":51,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":52,"context_line":"          scale_start:"},{"line_number":53,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":54,"context_line":"          scale_end:"},{"line_number":55,"context_line":"            implementation: mgmt-drivers-kubernetes"},{"line_number":56,"context_line":"      artifacts:"},{"line_number":57,"context_line":"        mgmt-drivers-kubernetes:"},{"line_number":58,"context_line":"          description: Management driver for kubernetes cluster"},{"line_number":59,"context_line":"          type: tosca.artifacts.Implementation.Python"},{"line_number":60,"context_line":"          file: Scripts/kubernetes_mgmt.py"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    VDU1:"},{"line_number":63,"context_line":"      type: tosca.nodes.nfv.Vdu.Compute"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b0cc8874_68dce654","line":60,"range":{"start_line":42,"start_character":6,"end_line":60,"end_character":42},"in_reply_to":"a9737dfa_df7b0e8b","updated":"2021-06-15 08:58:08.000000000","message":"Thank you for your comment. I think you\u0027re right. I will delete these definitions in next patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"}],"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"3bc79a38b6ff8ff7fe83bda8a91d22e32c71f9b4","unresolved":true,"context_lines":[{"line_number":2797,"context_line":"            context, vnf_instance,"},{"line_number":2798,"context_line":"            scale_vnf_request, vnf_info,"},{"line_number":2799,"context_line":"            vim_connection_info)"},{"line_number":2800,"context_line":"        self.assertEqual("},{"line_number":2801,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0].id,"},{"line_number":2802,"context_line":"            uuidsentinel.vnfc_resource_id)"},{"line_number":2803,"context_line":"        return_vnfc_res \u003d \\"},{"line_number":2804,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0]"},{"line_number":2805,"context_line":"        self.assertEqual(return_vnfc_res.vnfc_cp_info[0].id,"},{"line_number":2806,"context_line":"                         uuidsentinel.vnfc_cp_info_id)"},{"line_number":2807,"context_line":""},{"line_number":2808,"context_line":"    @mock.patch.object(hc.HeatClient, \"resource_get\")"},{"line_number":2809,"context_line":"    @mock.patch.object(hc.HeatClient, \"resource_get_list\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d45ad82_d3ab19f0","line":2806,"range":{"start_line":2800,"start_character":0,"end_line":2806,"end_character":54},"updated":"2021-06-11 05:25:11.000000000","message":"I think you should also check the \u0027OS::Cinder::Volume\u0027 Resource type. Why don\u0027t you also check `virtual_storage_resource_info.id`?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ea99020f86e712506aceb23e06ee9bdaf2969fc9","unresolved":true,"context_lines":[{"line_number":2797,"context_line":"            context, vnf_instance,"},{"line_number":2798,"context_line":"            scale_vnf_request, vnf_info,"},{"line_number":2799,"context_line":"            vim_connection_info)"},{"line_number":2800,"context_line":"        self.assertEqual("},{"line_number":2801,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0].id,"},{"line_number":2802,"context_line":"            uuidsentinel.vnfc_resource_id)"},{"line_number":2803,"context_line":"        return_vnfc_res \u003d \\"},{"line_number":2804,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0]"},{"line_number":2805,"context_line":"        self.assertEqual(return_vnfc_res.vnfc_cp_info[0].id,"},{"line_number":2806,"context_line":"                         uuidsentinel.vnfc_cp_info_id)"},{"line_number":2807,"context_line":""},{"line_number":2808,"context_line":"    @mock.patch.object(hc.HeatClient, \"resource_get\")"},{"line_number":2809,"context_line":"    @mock.patch.object(hc.HeatClient, \"resource_get_list\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"dcd8cf6b_c89aaebc","line":2806,"range":{"start_line":2800,"start_character":0,"end_line":2806,"end_character":54},"in_reply_to":"1d45ad82_d3ab19f0","updated":"2021-06-15 08:59:50.000000000","message":"Thank you. I will add \u0027OS::Cinder::Volume\u0027 Resource into UT test in next patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"400d20d12b2f144e41851547b487effe36ca9573","unresolved":false,"context_lines":[{"line_number":2797,"context_line":"            context, vnf_instance,"},{"line_number":2798,"context_line":"            scale_vnf_request, vnf_info,"},{"line_number":2799,"context_line":"            vim_connection_info)"},{"line_number":2800,"context_line":"        self.assertEqual("},{"line_number":2801,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0].id,"},{"line_number":2802,"context_line":"            uuidsentinel.vnfc_resource_id)"},{"line_number":2803,"context_line":"        return_vnfc_res \u003d \\"},{"line_number":2804,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0]"},{"line_number":2805,"context_line":"        self.assertEqual(return_vnfc_res.vnfc_cp_info[0].id,"},{"line_number":2806,"context_line":"                         uuidsentinel.vnfc_cp_info_id)"},{"line_number":2807,"context_line":""},{"line_number":2808,"context_line":"    @mock.patch.object(hc.HeatClient, \"resource_get\")"},{"line_number":2809,"context_line":"    @mock.patch.object(hc.HeatClient, \"resource_get_list\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"263030da_d411c696","line":2806,"range":{"start_line":2800,"start_character":0,"end_line":2806,"end_character":54},"in_reply_to":"dcd8cf6b_c89aaebc","updated":"2021-07-21 21:22:08.000000000","message":"Done. I\u0027ve confirmed your fix.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"3bc79a38b6ff8ff7fe83bda8a91d22e32c71f9b4","unresolved":true,"context_lines":[{"line_number":2878,"context_line":"            context, vnf_instance,"},{"line_number":2879,"context_line":"            scale_vnf_request, vnf_info,"},{"line_number":2880,"context_line":"            vim_connection_info)"},{"line_number":2881,"context_line":"        self.assertNotEqual("},{"line_number":2882,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0].id,"},{"line_number":2883,"context_line":"            uuidsentinel.vnfc_resource_id)"},{"line_number":2884,"context_line":"        return_vnfc_res \u003d \\"},{"line_number":2885,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0]"},{"line_number":2886,"context_line":"        self.assertNotEqual(return_vnfc_res.vnfc_cp_info[0].id,"},{"line_number":2887,"context_line":"                         uuidsentinel.vnfc_cp_info_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"95bb11c0_06635e82","line":2887,"range":{"start_line":2881,"start_character":0,"end_line":2887,"end_character":54},"updated":"2021-06-11 05:25:11.000000000","message":"ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"ea99020f86e712506aceb23e06ee9bdaf2969fc9","unresolved":true,"context_lines":[{"line_number":2878,"context_line":"            context, vnf_instance,"},{"line_number":2879,"context_line":"            scale_vnf_request, vnf_info,"},{"line_number":2880,"context_line":"            vim_connection_info)"},{"line_number":2881,"context_line":"        self.assertNotEqual("},{"line_number":2882,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0].id,"},{"line_number":2883,"context_line":"            uuidsentinel.vnfc_resource_id)"},{"line_number":2884,"context_line":"        return_vnfc_res \u003d \\"},{"line_number":2885,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0]"},{"line_number":2886,"context_line":"        self.assertNotEqual(return_vnfc_res.vnfc_cp_info[0].id,"},{"line_number":2887,"context_line":"                         uuidsentinel.vnfc_cp_info_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a4c06e97_18625700","line":2887,"range":{"start_line":2881,"start_character":0,"end_line":2887,"end_character":54},"in_reply_to":"95bb11c0_06635e82","updated":"2021-06-15 08:59:50.000000000","message":"ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"400d20d12b2f144e41851547b487effe36ca9573","unresolved":false,"context_lines":[{"line_number":2878,"context_line":"            context, vnf_instance,"},{"line_number":2879,"context_line":"            scale_vnf_request, vnf_info,"},{"line_number":2880,"context_line":"            vim_connection_info)"},{"line_number":2881,"context_line":"        self.assertNotEqual("},{"line_number":2882,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0].id,"},{"line_number":2883,"context_line":"            uuidsentinel.vnfc_resource_id)"},{"line_number":2884,"context_line":"        return_vnfc_res \u003d \\"},{"line_number":2885,"context_line":"            vnf_instance.instantiated_vnf_info.vnfc_resource_info[0]"},{"line_number":2886,"context_line":"        self.assertNotEqual(return_vnfc_res.vnfc_cp_info[0].id,"},{"line_number":2887,"context_line":"                         uuidsentinel.vnfc_cp_info_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"aa4e21d7_91e241ab","line":2887,"range":{"start_line":2881,"start_character":0,"end_line":2887,"end_character":54},"in_reply_to":"a4c06e97_18625700","updated":"2021-07-21 21:22:08.000000000","message":"Done. ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"2276764b8852f25d3fdb631a8d5caae7a25f3bb1","unresolved":true,"context_lines":[{"line_number":443,"context_line":"                        id\u003dvnf_instance.id,"},{"line_number":444,"context_line":"                        error\u003dencodeutils.exception_to_unicode(exp))"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        if vnf_instance.instantiated_vnf_info.instance_id:"},{"line_number":447,"context_line":"            self._vnf_manager.invoke(vim_connection_info.vim_type,"},{"line_number":448,"context_line":"                                    \u0027post_vnf_instantiation\u0027, context\u003dcontext,"},{"line_number":449,"context_line":"                                    vnf_instance\u003dvnf_instance,"},{"line_number":450,"context_line":"                                    vim_connection_info\u003dvim_connection_info,"},{"line_number":451,"context_line":"                                    instantiate_vnf_req\u003dinstantiate_vnf_req)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def _get_file_hash(self, path):"},{"line_number":454,"context_line":"        hash_obj \u003d hashlib.sha256()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f877fcb_91d095fb","line":451,"range":{"start_line":446,"start_character":0,"end_line":451,"end_character":76},"updated":"2021-06-10 05:12:37.000000000","message":"I wasn\u0027t sure if this fix was directly related to this bug, do you need it?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ae667547cc95f2eb7596fa2f711465a1f3812a90","unresolved":true,"context_lines":[{"line_number":443,"context_line":"                        id\u003dvnf_instance.id,"},{"line_number":444,"context_line":"                        error\u003dencodeutils.exception_to_unicode(exp))"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        if vnf_instance.instantiated_vnf_info.instance_id:"},{"line_number":447,"context_line":"            self._vnf_manager.invoke(vim_connection_info.vim_type,"},{"line_number":448,"context_line":"                                    \u0027post_vnf_instantiation\u0027, context\u003dcontext,"},{"line_number":449,"context_line":"                                    vnf_instance\u003dvnf_instance,"},{"line_number":450,"context_line":"                                    vim_connection_info\u003dvim_connection_info,"},{"line_number":451,"context_line":"                                    instantiate_vnf_req\u003dinstantiate_vnf_req)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def _get_file_hash(self, path):"},{"line_number":454,"context_line":"        hash_obj \u003d hashlib.sha256()"}],"source_content_type":"text/x-python","patch_set":5,"id":"f3eb400f_4a1ece8e","line":451,"range":{"start_line":446,"start_character":0,"end_line":451,"end_character":76},"in_reply_to":"07533303_3ab01eb1","updated":"2021-06-16 03:00:29.000000000","message":"I understand your answer.\nI asked because the bugreport content and the commit message didn\u0027t have that information.\nIf it\u0027s a fix for that reason, I think you can just add it to the commit message for this patch instead of creating a new patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bac837e4cfe0cf68c273f89b5dacc86ff5de4e95","unresolved":true,"context_lines":[{"line_number":443,"context_line":"                        id\u003dvnf_instance.id,"},{"line_number":444,"context_line":"                        error\u003dencodeutils.exception_to_unicode(exp))"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        if vnf_instance.instantiated_vnf_info.instance_id:"},{"line_number":447,"context_line":"            self._vnf_manager.invoke(vim_connection_info.vim_type,"},{"line_number":448,"context_line":"                                    \u0027post_vnf_instantiation\u0027, context\u003dcontext,"},{"line_number":449,"context_line":"                                    vnf_instance\u003dvnf_instance,"},{"line_number":450,"context_line":"                                    vim_connection_info\u003dvim_connection_info,"},{"line_number":451,"context_line":"                                    instantiate_vnf_req\u003dinstantiate_vnf_req)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def _get_file_hash(self, path):"},{"line_number":454,"context_line":"        hash_obj \u003d hashlib.sha256()"}],"source_content_type":"text/x-python","patch_set":5,"id":"07533303_3ab01eb1","line":451,"range":{"start_line":446,"start_character":0,"end_line":451,"end_character":76},"in_reply_to":"5f877fcb_91d095fb","updated":"2021-06-15 08:58:08.000000000","message":"This change is related instantiate_grant. If we will use grant\u0027s info after instantiate, we should have vnf_instance.vnfc_resource_info instantiated. In order to pass my FT, I changed this code, if you think it is not related to this bug, I will report a new bug and fix it.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c686c6e7c017de0b438dbf4bdf87887c2444cd3a","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                        id\u003dvnf_instance.id,"},{"line_number":444,"context_line":"                        error\u003dencodeutils.exception_to_unicode(exp))"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        if vnf_instance.instantiated_vnf_info.instance_id:"},{"line_number":447,"context_line":"            self._vnf_manager.invoke(vim_connection_info.vim_type,"},{"line_number":448,"context_line":"                                    \u0027post_vnf_instantiation\u0027, context\u003dcontext,"},{"line_number":449,"context_line":"                                    vnf_instance\u003dvnf_instance,"},{"line_number":450,"context_line":"                                    vim_connection_info\u003dvim_connection_info,"},{"line_number":451,"context_line":"                                    instantiate_vnf_req\u003dinstantiate_vnf_req)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    def _get_file_hash(self, path):"},{"line_number":454,"context_line":"        hash_obj \u003d hashlib.sha256()"}],"source_content_type":"text/x-python","patch_set":5,"id":"32a3bb15_d12eb65c","line":451,"range":{"start_line":446,"start_character":0,"end_line":451,"end_character":76},"in_reply_to":"f3eb400f_4a1ece8e","updated":"2021-07-19 06:43:09.000000000","message":"Done","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"e8860968723afcaa6d914b2ed80c9519c4edd03e","unresolved":true,"context_lines":[{"line_number":1478,"context_line":"        return return_list, return_rs_list, grp.physical_resource_id, cap_size"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    @log.log"},{"line_number":1481,"context_line":"    def scale_resource_update(self, context, vnf_instance,"},{"line_number":1482,"context_line":"                              scale_vnf_request, vnf_info,"},{"line_number":1483,"context_line":"                              vim_connection_info):"},{"line_number":1484,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"af5a8f91_e7ea8aea","line":1481,"updated":"2021-06-15 10:00:37.000000000","message":"Why don\u0027t you add FT code to `nfvo_separate` for checking that scale out problem has fixed?\n\nThere seems to be no test for scale out in current `nfvo_separate` test.\nhttps://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol_separated_nfvo/vnflcm/test_vnf_instance_with_user_data_nfvo_separate.py","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"92310357342a34ef88510cc08f6ed7ce200f148e","unresolved":true,"context_lines":[{"line_number":1478,"context_line":"        return return_list, return_rs_list, grp.physical_resource_id, cap_size"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    @log.log"},{"line_number":1481,"context_line":"    def scale_resource_update(self, context, vnf_instance,"},{"line_number":1482,"context_line":"                              scale_vnf_request, vnf_info,"},{"line_number":1483,"context_line":"                              vim_connection_info):"},{"line_number":1484,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"fea359be_ce619621","line":1481,"in_reply_to":"12ef9bab_a7338b5b","updated":"2021-07-28 04:41:31.000000000","message":"If this patch\u0027s fixes don\u0027t work well until it is merged, I think you should wait for the merge.\nWhy don\u0027t you set the patch as a parent and submit the FT code?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"e9dcde8c173040d377799eb40d145fb6c712f829","unresolved":true,"context_lines":[{"line_number":1478,"context_line":"        return return_list, return_rs_list, grp.physical_resource_id, cap_size"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    @log.log"},{"line_number":1481,"context_line":"    def scale_resource_update(self, context, vnf_instance,"},{"line_number":1482,"context_line":"                              scale_vnf_request, vnf_info,"},{"line_number":1483,"context_line":"                              vim_connection_info):"},{"line_number":1484,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"12ef9bab_a7338b5b","line":1481,"in_reply_to":"18703f8e_b97aa9de","updated":"2021-07-28 02:58:01.000000000","message":"The scale_FT for grant will currently fail due to the following bug.\nhttps://bugs.launchpad.net/tacker/+bug/1924216\n\nI can upload the FT code, but it will only pass after the following branch has been merged. \nhttps://review.opendev.org/c/openstack/tacker/+/787711\n\nDo you think we should wait for the branch to be merged and upload the code or upload it again based on the branch?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"04feb211d715d2392c4546bfbca7f2d07a608113","unresolved":true,"context_lines":[{"line_number":1478,"context_line":"        return return_list, return_rs_list, grp.physical_resource_id, cap_size"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    @log.log"},{"line_number":1481,"context_line":"    def scale_resource_update(self, context, vnf_instance,"},{"line_number":1482,"context_line":"                              scale_vnf_request, vnf_info,"},{"line_number":1483,"context_line":"                              vim_connection_info):"},{"line_number":1484,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"18703f8e_b97aa9de","line":1481,"in_reply_to":"af5a8f91_e7ea8aea","updated":"2021-07-28 01:37:43.000000000","message":"Do you need to rework to this comment?\nIf it is not necessary, please tell me why it is not necessary.\nIs adding unit test or changing `fake_grant.py` enough?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"1b18d9715236a823e94512ac388fce874e411e39","unresolved":true,"context_lines":[{"line_number":1478,"context_line":"        return return_list, return_rs_list, grp.physical_resource_id, cap_size"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    @log.log"},{"line_number":1481,"context_line":"    def scale_resource_update(self, context, vnf_instance,"},{"line_number":1482,"context_line":"                              scale_vnf_request, vnf_info,"},{"line_number":1483,"context_line":"                              vim_connection_info):"},{"line_number":1484,"context_line":"        inst_vnf_info \u003d vnf_instance.instantiated_vnf_info"}],"source_content_type":"text/x-python","patch_set":5,"id":"6d649089_fffef3aa","line":1481,"in_reply_to":"fea359be_ce619621","updated":"2021-07-29 07:47:59.000000000","message":"I have submitted the FT code based on patch-787711 in patchset 10.\nPlease kindly checkt it again.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"56e1f0d9b9aa4edc65321d86f0350f5402bec8c1","unresolved":true,"context_lines":[{"line_number":1517,"context_line":"                            LOG.debug(\"rsc %s\", rsc_info)"},{"line_number":1518,"context_line":"                            if \u0027COMPLETE\u0027 in rsc.resource_status and \u0027\\"},{"line_number":1519,"context_line":"                            INIT_COMPLETE\u0027 !\u003d rsc.resource_status:"},{"line_number":1520,"context_line":"                                if grant_vnfc_res_info_list:"},{"line_number":1521,"context_line":"                                    for i in range(len("},{"line_number":1522,"context_line":"                                            grant_vnfc_res_info_list) - 1,"},{"line_number":1523,"context_line":"                                            -1, -1):"},{"line_number":1524,"context_line":"                                        if grant_vnfc_res_info_list[i].vdu_id\\"},{"line_number":1525,"context_line":"                                                \u003d\u003d rsc.resource_name:"},{"line_number":1526,"context_line":"                                            vnfc_resource_info \u003d \\"},{"line_number":1527,"context_line":"                                                grant_vnfc_res_info_list.pop("},{"line_number":1528,"context_line":"                                                    i)"},{"line_number":1529,"context_line":"                                            break"},{"line_number":1530,"context_line":"                                else:"},{"line_number":1531,"context_line":"                                    vnfc_resource_info \u003d \\"},{"line_number":1532,"context_line":"                                        objects.VnfcResourceInfo()"},{"line_number":1533,"context_line":"                                    vnfc_resource_info.id \u003d\\"},{"line_number":1534,"context_line":"                                        uuidutils.generate_uuid()"},{"line_number":1535,"context_line":"                                    vnfc_resource_info.vdu_id \u003d \\"},{"line_number":1536,"context_line":"                                        rsc.resource_name"},{"line_number":1537,"context_line":"                                    vnfc_resource_info.vnfc_cp_info \u003d []"},{"line_number":1538,"context_line":"                                    vnfc_resource_info.\\"},{"line_number":1539,"context_line":"                                        storage_resource_ids \u003d []"},{"line_number":1540,"context_line":"                                resource \u003d objects.ResourceHandle()"},{"line_number":1541,"context_line":"                                resource.vim_connection_id \u003d\\"},{"line_number":1542,"context_line":"                                    vim_connection_info.id"}],"source_content_type":"text/x-python","patch_set":5,"id":"e71dca70_3acd7f80","line":1539,"range":{"start_line":1520,"start_character":0,"end_line":1539,"end_character":65},"updated":"2021-06-11 14:59:13.000000000","message":"This part\u0027s nest is too deep.\nCould you refactor using subfunctions?","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"04feb211d715d2392c4546bfbca7f2d07a608113","unresolved":false,"context_lines":[{"line_number":1517,"context_line":"                            LOG.debug(\"rsc %s\", rsc_info)"},{"line_number":1518,"context_line":"                            if \u0027COMPLETE\u0027 in rsc.resource_status and \u0027\\"},{"line_number":1519,"context_line":"                            INIT_COMPLETE\u0027 !\u003d rsc.resource_status:"},{"line_number":1520,"context_line":"                                if grant_vnfc_res_info_list:"},{"line_number":1521,"context_line":"                                    for i in range(len("},{"line_number":1522,"context_line":"                                            grant_vnfc_res_info_list) - 1,"},{"line_number":1523,"context_line":"                                            -1, -1):"},{"line_number":1524,"context_line":"                                        if grant_vnfc_res_info_list[i].vdu_id\\"},{"line_number":1525,"context_line":"                                                \u003d\u003d rsc.resource_name:"},{"line_number":1526,"context_line":"                                            vnfc_resource_info \u003d \\"},{"line_number":1527,"context_line":"                                                grant_vnfc_res_info_list.pop("},{"line_number":1528,"context_line":"                                                    i)"},{"line_number":1529,"context_line":"                                            break"},{"line_number":1530,"context_line":"                                else:"},{"line_number":1531,"context_line":"                                    vnfc_resource_info \u003d \\"},{"line_number":1532,"context_line":"                                        objects.VnfcResourceInfo()"},{"line_number":1533,"context_line":"                                    vnfc_resource_info.id \u003d\\"},{"line_number":1534,"context_line":"                                        uuidutils.generate_uuid()"},{"line_number":1535,"context_line":"                                    vnfc_resource_info.vdu_id \u003d \\"},{"line_number":1536,"context_line":"                                        rsc.resource_name"},{"line_number":1537,"context_line":"                                    vnfc_resource_info.vnfc_cp_info \u003d []"},{"line_number":1538,"context_line":"                                    vnfc_resource_info.\\"},{"line_number":1539,"context_line":"                                        storage_resource_ids \u003d []"},{"line_number":1540,"context_line":"                                resource \u003d objects.ResourceHandle()"},{"line_number":1541,"context_line":"                                resource.vim_connection_id \u003d\\"},{"line_number":1542,"context_line":"                                    vim_connection_info.id"}],"source_content_type":"text/x-python","patch_set":5,"id":"864d13de_1f7ec01a","line":1539,"range":{"start_line":1520,"start_character":0,"end_line":1539,"end_character":65},"in_reply_to":"b053ba1b_0eceab9d","updated":"2021-07-28 01:37:43.000000000","message":"I\u0027ve confirmed.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f3e4f0c79a815f5c4086e6328840f8b4c9da52fc","unresolved":true,"context_lines":[{"line_number":1517,"context_line":"                            LOG.debug(\"rsc %s\", rsc_info)"},{"line_number":1518,"context_line":"                            if \u0027COMPLETE\u0027 in rsc.resource_status and \u0027\\"},{"line_number":1519,"context_line":"                            INIT_COMPLETE\u0027 !\u003d rsc.resource_status:"},{"line_number":1520,"context_line":"                                if grant_vnfc_res_info_list:"},{"line_number":1521,"context_line":"                                    for i in range(len("},{"line_number":1522,"context_line":"                                            grant_vnfc_res_info_list) - 1,"},{"line_number":1523,"context_line":"                                            -1, -1):"},{"line_number":1524,"context_line":"                                        if grant_vnfc_res_info_list[i].vdu_id\\"},{"line_number":1525,"context_line":"                                                \u003d\u003d rsc.resource_name:"},{"line_number":1526,"context_line":"                                            vnfc_resource_info \u003d \\"},{"line_number":1527,"context_line":"                                                grant_vnfc_res_info_list.pop("},{"line_number":1528,"context_line":"                                                    i)"},{"line_number":1529,"context_line":"                                            break"},{"line_number":1530,"context_line":"                                else:"},{"line_number":1531,"context_line":"                                    vnfc_resource_info \u003d \\"},{"line_number":1532,"context_line":"                                        objects.VnfcResourceInfo()"},{"line_number":1533,"context_line":"                                    vnfc_resource_info.id \u003d\\"},{"line_number":1534,"context_line":"                                        uuidutils.generate_uuid()"},{"line_number":1535,"context_line":"                                    vnfc_resource_info.vdu_id \u003d \\"},{"line_number":1536,"context_line":"                                        rsc.resource_name"},{"line_number":1537,"context_line":"                                    vnfc_resource_info.vnfc_cp_info \u003d []"},{"line_number":1538,"context_line":"                                    vnfc_resource_info.\\"},{"line_number":1539,"context_line":"                                        storage_resource_ids \u003d []"},{"line_number":1540,"context_line":"                                resource \u003d objects.ResourceHandle()"},{"line_number":1541,"context_line":"                                resource.vim_connection_id \u003d\\"},{"line_number":1542,"context_line":"                                    vim_connection_info.id"}],"source_content_type":"text/x-python","patch_set":5,"id":"b053ba1b_0eceab9d","line":1539,"range":{"start_line":1520,"start_character":0,"end_line":1539,"end_character":65},"in_reply_to":"e71dca70_3acd7f80","updated":"2021-06-15 09:01:54.000000000","message":"I will add subfunctions in next patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"56e1f0d9b9aa4edc65321d86f0350f5402bec8c1","unresolved":true,"context_lines":[{"line_number":1570,"context_line":"                            LOG.debug(\"rsc %s\", rsc_info)"},{"line_number":1571,"context_line":"                            for vnfc_rsc in vnfc_rscs:"},{"line_number":1572,"context_line":"                                if vnfc_rsc.vdu_id in rsc_info.required_by:"},{"line_number":1573,"context_line":"                                    if vnfc_rsc.vnfc_cp_info:"},{"line_number":1574,"context_line":"                                        for i in range(len("},{"line_number":1575,"context_line":"                                                vnfc_rsc.vnfc_cp_info) - 1,"},{"line_number":1576,"context_line":"                                                -1, -1):"},{"line_number":1577,"context_line":"                                            if vnfc_rsc.\\"},{"line_number":1578,"context_line":"                                                vnfc_cp_info[i].cpd_id \u003d\u003d\\"},{"line_number":1579,"context_line":"                                                    rsc.resource_name:"},{"line_number":1580,"context_line":"                                                vnfc_cp \u003d vnfc_rsc.\\"},{"line_number":1581,"context_line":"                                                    vnfc_cp_info.pop(i)"},{"line_number":1582,"context_line":"                                                break"},{"line_number":1583,"context_line":"                                    else:"},{"line_number":1584,"context_line":"                                        vnfc_cp \u003d objects.VnfcCpInfo()"},{"line_number":1585,"context_line":"                                        vnfc_cp.id \u003d uuidutils.generate_uuid()"},{"line_number":1586,"context_line":"                                        vnfc_cp.cpd_id \u003d rsc.resource_name"},{"line_number":1587,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"}],"source_content_type":"text/x-python","patch_set":5,"id":"0454414c_33ebf07f","line":1586,"range":{"start_line":1573,"start_character":0,"end_line":1586,"end_character":74},"updated":"2021-06-11 14:59:13.000000000","message":"ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f3e4f0c79a815f5c4086e6328840f8b4c9da52fc","unresolved":true,"context_lines":[{"line_number":1570,"context_line":"                            LOG.debug(\"rsc %s\", rsc_info)"},{"line_number":1571,"context_line":"                            for vnfc_rsc in vnfc_rscs:"},{"line_number":1572,"context_line":"                                if vnfc_rsc.vdu_id in rsc_info.required_by:"},{"line_number":1573,"context_line":"                                    if vnfc_rsc.vnfc_cp_info:"},{"line_number":1574,"context_line":"                                        for i in range(len("},{"line_number":1575,"context_line":"                                                vnfc_rsc.vnfc_cp_info) - 1,"},{"line_number":1576,"context_line":"                                                -1, -1):"},{"line_number":1577,"context_line":"                                            if vnfc_rsc.\\"},{"line_number":1578,"context_line":"                                                vnfc_cp_info[i].cpd_id \u003d\u003d\\"},{"line_number":1579,"context_line":"                                                    rsc.resource_name:"},{"line_number":1580,"context_line":"                                                vnfc_cp \u003d vnfc_rsc.\\"},{"line_number":1581,"context_line":"                                                    vnfc_cp_info.pop(i)"},{"line_number":1582,"context_line":"                                                break"},{"line_number":1583,"context_line":"                                    else:"},{"line_number":1584,"context_line":"                                        vnfc_cp \u003d objects.VnfcCpInfo()"},{"line_number":1585,"context_line":"                                        vnfc_cp.id \u003d uuidutils.generate_uuid()"},{"line_number":1586,"context_line":"                                        vnfc_cp.cpd_id \u003d rsc.resource_name"},{"line_number":1587,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"}],"source_content_type":"text/x-python","patch_set":5,"id":"bbe9034a_96f481b9","line":1586,"range":{"start_line":1573,"start_character":0,"end_line":1586,"end_character":74},"in_reply_to":"0454414c_33ebf07f","updated":"2021-06-15 09:01:54.000000000","message":"ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"04feb211d715d2392c4546bfbca7f2d07a608113","unresolved":false,"context_lines":[{"line_number":1570,"context_line":"                            LOG.debug(\"rsc %s\", rsc_info)"},{"line_number":1571,"context_line":"                            for vnfc_rsc in vnfc_rscs:"},{"line_number":1572,"context_line":"                                if vnfc_rsc.vdu_id in rsc_info.required_by:"},{"line_number":1573,"context_line":"                                    if vnfc_rsc.vnfc_cp_info:"},{"line_number":1574,"context_line":"                                        for i in range(len("},{"line_number":1575,"context_line":"                                                vnfc_rsc.vnfc_cp_info) - 1,"},{"line_number":1576,"context_line":"                                                -1, -1):"},{"line_number":1577,"context_line":"                                            if vnfc_rsc.\\"},{"line_number":1578,"context_line":"                                                vnfc_cp_info[i].cpd_id \u003d\u003d\\"},{"line_number":1579,"context_line":"                                                    rsc.resource_name:"},{"line_number":1580,"context_line":"                                                vnfc_cp \u003d vnfc_rsc.\\"},{"line_number":1581,"context_line":"                                                    vnfc_cp_info.pop(i)"},{"line_number":1582,"context_line":"                                                break"},{"line_number":1583,"context_line":"                                    else:"},{"line_number":1584,"context_line":"                                        vnfc_cp \u003d objects.VnfcCpInfo()"},{"line_number":1585,"context_line":"                                        vnfc_cp.id \u003d uuidutils.generate_uuid()"},{"line_number":1586,"context_line":"                                        vnfc_cp.cpd_id \u003d rsc.resource_name"},{"line_number":1587,"context_line":"                                    vnfc_cp.cp_protocol_info \u003d []"},{"line_number":1588,"context_line":""},{"line_number":1589,"context_line":"                                    cp_protocol_info \u003d objects.CpProtocolInfo()"}],"source_content_type":"text/x-python","patch_set":5,"id":"35dadb76_a3205c6a","line":1586,"range":{"start_line":1573,"start_character":0,"end_line":1586,"end_character":74},"in_reply_to":"bbe9034a_96f481b9","updated":"2021-07-28 01:37:43.000000000","message":"I\u0027ve confirmed.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"56e1f0d9b9aa4edc65321d86f0350f5402bec8c1","unresolved":true,"context_lines":[{"line_number":1651,"context_line":"                                    vnfc_rsc.vnfc_cp_info.append(vnfc_cp)"},{"line_number":1652,"context_line":"                        if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":1653,"context_line":"                            if rsc.physical_resource_id not in st_rsc_list:"},{"line_number":1654,"context_line":"                                if grant_st_rsc_list:"},{"line_number":1655,"context_line":"                                    for i in range(len("},{"line_number":1656,"context_line":"                                            grant_st_rsc_list) - 1,"},{"line_number":1657,"context_line":"                                            -1, -1):"},{"line_number":1658,"context_line":"                                        if grant_st_rsc_list[i].\\"},{"line_number":1659,"context_line":"                                                virtual_storage_desc_id \u003d\u003d\\"},{"line_number":1660,"context_line":"                                                rsc.resource_name:"},{"line_number":1661,"context_line":"                                            virtual_storage_resource_info \u003d \\"},{"line_number":1662,"context_line":"                                                grant_st_rsc_list.pop("},{"line_number":1663,"context_line":"                                                    i)"},{"line_number":1664,"context_line":"                                            break"},{"line_number":1665,"context_line":"                                else:"},{"line_number":1666,"context_line":"                                    virtual_storage_resource_info \u003d\\"},{"line_number":1667,"context_line":"                                        objects.VirtualStorageResourceInfo()"},{"line_number":1668,"context_line":"                                    virtual_storage_resource_info.id \u003d\\"},{"line_number":1669,"context_line":"                                        uuidutils.generate_uuid()"},{"line_number":1670,"context_line":"                                    virtual_storage_resource_info.\\"},{"line_number":1671,"context_line":"                                        virtual_storage_desc_id \u003d \\"},{"line_number":1672,"context_line":"                                        rsc.resource_name"},{"line_number":1673,"context_line":"                                resource \u003d objects.ResourceHandle()"},{"line_number":1674,"context_line":"                                resource.vim_connection_id \u003d\\"},{"line_number":1675,"context_line":"                                    vim_connection_info.id"}],"source_content_type":"text/x-python","patch_set":5,"id":"afc81a87_3e1a019a","line":1672,"range":{"start_line":1654,"start_character":0,"end_line":1672,"end_character":57},"updated":"2021-06-11 14:59:13.000000000","message":"ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"04feb211d715d2392c4546bfbca7f2d07a608113","unresolved":false,"context_lines":[{"line_number":1651,"context_line":"                                    vnfc_rsc.vnfc_cp_info.append(vnfc_cp)"},{"line_number":1652,"context_line":"                        if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":1653,"context_line":"                            if rsc.physical_resource_id not in st_rsc_list:"},{"line_number":1654,"context_line":"                                if grant_st_rsc_list:"},{"line_number":1655,"context_line":"                                    for i in range(len("},{"line_number":1656,"context_line":"                                            grant_st_rsc_list) - 1,"},{"line_number":1657,"context_line":"                                            -1, -1):"},{"line_number":1658,"context_line":"                                        if grant_st_rsc_list[i].\\"},{"line_number":1659,"context_line":"                                                virtual_storage_desc_id \u003d\u003d\\"},{"line_number":1660,"context_line":"                                                rsc.resource_name:"},{"line_number":1661,"context_line":"                                            virtual_storage_resource_info \u003d \\"},{"line_number":1662,"context_line":"                                                grant_st_rsc_list.pop("},{"line_number":1663,"context_line":"                                                    i)"},{"line_number":1664,"context_line":"                                            break"},{"line_number":1665,"context_line":"                                else:"},{"line_number":1666,"context_line":"                                    virtual_storage_resource_info \u003d\\"},{"line_number":1667,"context_line":"                                        objects.VirtualStorageResourceInfo()"},{"line_number":1668,"context_line":"                                    virtual_storage_resource_info.id \u003d\\"},{"line_number":1669,"context_line":"                                        uuidutils.generate_uuid()"},{"line_number":1670,"context_line":"                                    virtual_storage_resource_info.\\"},{"line_number":1671,"context_line":"                                        virtual_storage_desc_id \u003d \\"},{"line_number":1672,"context_line":"                                        rsc.resource_name"},{"line_number":1673,"context_line":"                                resource \u003d objects.ResourceHandle()"},{"line_number":1674,"context_line":"                                resource.vim_connection_id \u003d\\"},{"line_number":1675,"context_line":"                                    vim_connection_info.id"}],"source_content_type":"text/x-python","patch_set":5,"id":"a2c46492_026f99ae","line":1672,"range":{"start_line":1654,"start_character":0,"end_line":1672,"end_character":57},"in_reply_to":"a8c0ccd6_e85d28c4","updated":"2021-07-28 01:37:43.000000000","message":"I\u0027ve confirmed.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"f3e4f0c79a815f5c4086e6328840f8b4c9da52fc","unresolved":true,"context_lines":[{"line_number":1651,"context_line":"                                    vnfc_rsc.vnfc_cp_info.append(vnfc_cp)"},{"line_number":1652,"context_line":"                        if rsc.resource_type \u003d\u003d \u0027OS::Cinder::Volume\u0027:"},{"line_number":1653,"context_line":"                            if rsc.physical_resource_id not in st_rsc_list:"},{"line_number":1654,"context_line":"                                if grant_st_rsc_list:"},{"line_number":1655,"context_line":"                                    for i in range(len("},{"line_number":1656,"context_line":"                                            grant_st_rsc_list) - 1,"},{"line_number":1657,"context_line":"                                            -1, -1):"},{"line_number":1658,"context_line":"                                        if grant_st_rsc_list[i].\\"},{"line_number":1659,"context_line":"                                                virtual_storage_desc_id \u003d\u003d\\"},{"line_number":1660,"context_line":"                                                rsc.resource_name:"},{"line_number":1661,"context_line":"                                            virtual_storage_resource_info \u003d \\"},{"line_number":1662,"context_line":"                                                grant_st_rsc_list.pop("},{"line_number":1663,"context_line":"                                                    i)"},{"line_number":1664,"context_line":"                                            break"},{"line_number":1665,"context_line":"                                else:"},{"line_number":1666,"context_line":"                                    virtual_storage_resource_info \u003d\\"},{"line_number":1667,"context_line":"                                        objects.VirtualStorageResourceInfo()"},{"line_number":1668,"context_line":"                                    virtual_storage_resource_info.id \u003d\\"},{"line_number":1669,"context_line":"                                        uuidutils.generate_uuid()"},{"line_number":1670,"context_line":"                                    virtual_storage_resource_info.\\"},{"line_number":1671,"context_line":"                                        virtual_storage_desc_id \u003d \\"},{"line_number":1672,"context_line":"                                        rsc.resource_name"},{"line_number":1673,"context_line":"                                resource \u003d objects.ResourceHandle()"},{"line_number":1674,"context_line":"                                resource.vim_connection_id \u003d\\"},{"line_number":1675,"context_line":"                                    vim_connection_info.id"}],"source_content_type":"text/x-python","patch_set":5,"id":"a8c0ccd6_e85d28c4","line":1672,"range":{"start_line":1654,"start_character":0,"end_line":1672,"end_character":57},"in_reply_to":"afc81a87_3e1a019a","updated":"2021-06-15 09:01:54.000000000","message":"ditto","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"2276764b8852f25d3fdb631a8d5caae7a25f3bb1","unresolved":true,"context_lines":[{"line_number":1986,"context_line":"                            id_type\u003dpl[\u0027id_type\u0027],"},{"line_number":1987,"context_line":"                            resource_id\u003dpl[\u0027resource_id\u0027],"},{"line_number":1988,"context_line":"                            vim_connection_id\u003dvim_id))"},{"line_number":1989,"context_line":"                affinity_or_anti_affinity \u003d \\"},{"line_number":1990,"context_line":"                    placement.affinity_or_anti_affinity"},{"line_number":1991,"context_line":"                placement_constraint \u003d objects.PlacementConstraint("},{"line_number":1992,"context_line":"                    affinity_or_anti_affinity\u003daffinity_or_anti_affinity,"},{"line_number":1993,"context_line":"                    scope\u003d\u0027ZONE\u0027,"},{"line_number":1994,"context_line":"                    resource\u003daddRsc,"},{"line_number":1995,"context_line":"                    fallback_best_effort\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"32317b42_dabdc1c3","line":1992,"range":{"start_line":1989,"start_character":0,"end_line":1992,"end_character":72},"updated":"2021-06-10 05:12:37.000000000","message":"I think this fix is a fix that isn\u0027t mentioned in the commit message.\nI recommend that you shuoud better to add it.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"bac837e4cfe0cf68c273f89b5dacc86ff5de4e95","unresolved":true,"context_lines":[{"line_number":1986,"context_line":"                            id_type\u003dpl[\u0027id_type\u0027],"},{"line_number":1987,"context_line":"                            resource_id\u003dpl[\u0027resource_id\u0027],"},{"line_number":1988,"context_line":"                            vim_connection_id\u003dvim_id))"},{"line_number":1989,"context_line":"                affinity_or_anti_affinity \u003d \\"},{"line_number":1990,"context_line":"                    placement.affinity_or_anti_affinity"},{"line_number":1991,"context_line":"                placement_constraint \u003d objects.PlacementConstraint("},{"line_number":1992,"context_line":"                    affinity_or_anti_affinity\u003daffinity_or_anti_affinity,"},{"line_number":1993,"context_line":"                    scope\u003d\u0027ZONE\u0027,"},{"line_number":1994,"context_line":"                    resource\u003daddRsc,"},{"line_number":1995,"context_line":"                    fallback_best_effort\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"4b4fd02b_b27d1c99","line":1992,"range":{"start_line":1989,"start_character":0,"end_line":1992,"end_character":72},"in_reply_to":"32317b42_dabdc1c3","updated":"2021-06-15 08:58:08.000000000","message":"Thank you four your comment. I will add it into commit message in next patch.","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"c686c6e7c017de0b438dbf4bdf87887c2444cd3a","unresolved":false,"context_lines":[{"line_number":1986,"context_line":"                            id_type\u003dpl[\u0027id_type\u0027],"},{"line_number":1987,"context_line":"                            resource_id\u003dpl[\u0027resource_id\u0027],"},{"line_number":1988,"context_line":"                            vim_connection_id\u003dvim_id))"},{"line_number":1989,"context_line":"                affinity_or_anti_affinity \u003d \\"},{"line_number":1990,"context_line":"                    placement.affinity_or_anti_affinity"},{"line_number":1991,"context_line":"                placement_constraint \u003d objects.PlacementConstraint("},{"line_number":1992,"context_line":"                    affinity_or_anti_affinity\u003daffinity_or_anti_affinity,"},{"line_number":1993,"context_line":"                    scope\u003d\u0027ZONE\u0027,"},{"line_number":1994,"context_line":"                    resource\u003daddRsc,"},{"line_number":1995,"context_line":"                    fallback_best_effort\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"06c8f27f_fc67c231","line":1992,"range":{"start_line":1989,"start_character":0,"end_line":1992,"end_character":72},"in_reply_to":"4b4fd02b_b27d1c99","updated":"2021-07-19 06:43:09.000000000","message":"Done","commit_id":"d7578a1bb20df18d8d85d7baea8be628f3a8fc86"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"b9f0c65981d71f81f0dd55a9eaaef1d2d73b3795","unresolved":true,"context_lines":[{"line_number":1978,"context_line":"        scale_resource \u003d heat_resource[\u0027resources\u0027].\\"},{"line_number":1979,"context_line":"            get(scale_resource_name, {})"},{"line_number":1980,"context_line":"        if not scale_resource:"},{"line_number":1981,"context_line":"            scale_resource_name \u003d scale_vnf_request.aspect_id + \u0027_group\u0027"},{"line_number":1982,"context_line":"            scale_resource \u003d heat_resource[\u0027resources\u0027].\\"},{"line_number":1983,"context_line":"                get(scale_resource_name)"},{"line_number":1984,"context_line":"        yaml_name \u003d scale_resource[\u0027properties\u0027][\u0027resource\u0027][\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"be17f5de_ab4cdcea","line":1981,"range":{"start_line":1981,"start_character":61,"end_line":1981,"end_character":72},"updated":"2021-09-10 07:50:54.000000000","message":"A restriction of scaling group name has been removed in an already merged patch [1].\n[1] https://review.opendev.org/c/openstack/tacker/+/787779\n\nDoes this code work correctly?","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2dc9a7e68c74390150f0cf5935bdf7aab886ccae","unresolved":false,"context_lines":[{"line_number":1978,"context_line":"        scale_resource \u003d heat_resource[\u0027resources\u0027].\\"},{"line_number":1979,"context_line":"            get(scale_resource_name, {})"},{"line_number":1980,"context_line":"        if not scale_resource:"},{"line_number":1981,"context_line":"            scale_resource_name \u003d scale_vnf_request.aspect_id + \u0027_group\u0027"},{"line_number":1982,"context_line":"            scale_resource \u003d heat_resource[\u0027resources\u0027].\\"},{"line_number":1983,"context_line":"                get(scale_resource_name)"},{"line_number":1984,"context_line":"        yaml_name \u003d scale_resource[\u0027properties\u0027][\u0027resource\u0027][\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7797ec2c_53a283f1","line":1981,"range":{"start_line":1981,"start_character":61,"end_line":1981,"end_character":72},"in_reply_to":"91589022_0cc27453","updated":"2021-09-15 09:40:23.000000000","message":"I\u0027ve confirmed.","commit_id":"7d1430195b18900076420579346bb676c76f929a"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"d9d63a086414713b8e6d95c222ed89c957b6b104","unresolved":true,"context_lines":[{"line_number":1978,"context_line":"        scale_resource \u003d heat_resource[\u0027resources\u0027].\\"},{"line_number":1979,"context_line":"            get(scale_resource_name, {})"},{"line_number":1980,"context_line":"        if not scale_resource:"},{"line_number":1981,"context_line":"            scale_resource_name \u003d scale_vnf_request.aspect_id + \u0027_group\u0027"},{"line_number":1982,"context_line":"            scale_resource \u003d heat_resource[\u0027resources\u0027].\\"},{"line_number":1983,"context_line":"                get(scale_resource_name)"},{"line_number":1984,"context_line":"        yaml_name \u003d scale_resource[\u0027properties\u0027][\u0027resource\u0027][\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"91589022_0cc27453","line":1981,"range":{"start_line":1981,"start_character":61,"end_line":1981,"end_character":72},"in_reply_to":"be17f5de_ab4cdcea","updated":"2021-09-15 07:21:31.000000000","message":"I have modified it in PS 18 to adapt the new rule.","commit_id":"7d1430195b18900076420579346bb676c76f929a"}]}