)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"343cc1d294ee47bc1b9039ef9170f1cf2b4e4e76","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Navum Gupta \u003cnavum.gupta@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-01 12:43:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Addition of \u0027groups\u0027 in `topology_template` in `vnf_dict`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will include `groups` in `topology_template`"},{"line_number":10,"context_line":"of `vnf_dict`."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2e30643d_3ac72459","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"updated":"2021-09-10 04:33:07.000000000","message":"The first line seems a little long. Could you make it shorter than 50 characters?\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"e26e7266d9953cb6874061c2b9fa59e8745524ce"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"0afd615b877bab21be6f63677c1a29df1fc41e94","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Navum Gupta \u003cnavum.gupta@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-01 12:43:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Addition of \u0027groups\u0027 in `topology_template` in `vnf_dict`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will include `groups` in `topology_template`"},{"line_number":10,"context_line":"of `vnf_dict`."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"36142f39_7334fd20","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"in_reply_to":"2e30643d_3ac72459","updated":"2021-09-17 05:49:47.000000000","message":"Updated commit message.","commit_id":"e26e7266d9953cb6874061c2b9fa59e8745524ce"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dd24c1ac54dddacb8d493427ce539c409cce207c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Navum Gupta \u003cnavum.gupta@india.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-01 12:43:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Addition of \u0027groups\u0027 in `topology_template` in `vnf_dict`"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will include `groups` in `topology_template`"},{"line_number":10,"context_line":"of `vnf_dict`."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"edcde090_958a4f7f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":57},"in_reply_to":"36142f39_7334fd20","updated":"2021-09-17 08:18:17.000000000","message":"I\u0027ve confirmed.","commit_id":"e26e7266d9953cb6874061c2b9fa59e8745524ce"}],"tacker/tests/unit/vnflcm/fakes.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0158fe6c1d42bae1a4b6ea6e55325ec9f6724c93","unresolved":true,"context_lines":[{"line_number":1074,"context_line":"           \u0027 flavour for Sample VNF\\n\\nimports:\\n\u0027 + \\"},{"line_number":1075,"context_line":"           \u0027  - etsi_nfv_sol001_common_types.yaml\\n\u0027 + \\"},{"line_number":1076,"context_line":"           \u0027  - etsi_nfv_sol001_vnfd_types.yaml\\n\\n\u0027 + \\"},{"line_number":1077,"context_line":"           \u0027topology_template:\\n  node_templates:\\n  groups:\\n\u0027 + \\"},{"line_number":1078,"context_line":"           \u0027    VNF:\\n      type: nec.ossmano.VNF\\n\u0027 + \\"},{"line_number":1079,"context_line":"           \u0027      properties:\\n\u0027 + \\"},{"line_number":1080,"context_line":"           \u0027        flavour_description: A simple flavour\\n\u0027 + \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"c0bebcc8_565a466f","line":1077,"range":{"start_line":1077,"start_character":53,"end_line":1077,"end_character":62},"updated":"2021-09-10 04:21:53.000000000","message":"According to this description,\n```\n...\ntopology_template:\n  node_templates:\n  groups:\n    VNF: ...\n    VDU1: ...\n```\nAs shown above, VNF and VDU1 appear to be defined under groups.\nUnit test is passed, so there may be no problem, but I feel it is a strange definition.\nCould you confirm it?","commit_id":"e26e7266d9953cb6874061c2b9fa59e8745524ce"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"0afd615b877bab21be6f63677c1a29df1fc41e94","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"           \u0027 flavour for Sample VNF\\n\\nimports:\\n\u0027 + \\"},{"line_number":1075,"context_line":"           \u0027  - etsi_nfv_sol001_common_types.yaml\\n\u0027 + \\"},{"line_number":1076,"context_line":"           \u0027  - etsi_nfv_sol001_vnfd_types.yaml\\n\\n\u0027 + \\"},{"line_number":1077,"context_line":"           \u0027topology_template:\\n  node_templates:\\n  groups:\\n\u0027 + \\"},{"line_number":1078,"context_line":"           \u0027    VNF:\\n      type: nec.ossmano.VNF\\n\u0027 + \\"},{"line_number":1079,"context_line":"           \u0027      properties:\\n\u0027 + \\"},{"line_number":1080,"context_line":"           \u0027        flavour_description: A simple flavour\\n\u0027 + \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9194d58_73bbf777","line":1077,"range":{"start_line":1077,"start_character":53,"end_line":1077,"end_character":62},"in_reply_to":"c0bebcc8_565a466f","updated":"2021-09-17 05:49:47.000000000","message":"Updated code and kept groups under topology_template.","commit_id":"e26e7266d9953cb6874061c2b9fa59e8745524ce"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dd24c1ac54dddacb8d493427ce539c409cce207c","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"           \u0027 flavour for Sample VNF\\n\\nimports:\\n\u0027 + \\"},{"line_number":1075,"context_line":"           \u0027  - etsi_nfv_sol001_common_types.yaml\\n\u0027 + \\"},{"line_number":1076,"context_line":"           \u0027  - etsi_nfv_sol001_vnfd_types.yaml\\n\\n\u0027 + \\"},{"line_number":1077,"context_line":"           \u0027topology_template:\\n  node_templates:\\n  groups:\\n\u0027 + \\"},{"line_number":1078,"context_line":"           \u0027    VNF:\\n      type: nec.ossmano.VNF\\n\u0027 + \\"},{"line_number":1079,"context_line":"           \u0027      properties:\\n\u0027 + \\"},{"line_number":1080,"context_line":"           \u0027        flavour_description: A simple flavour\\n\u0027 + \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"245a9952_51a053f1","line":1077,"range":{"start_line":1077,"start_character":53,"end_line":1077,"end_character":62},"in_reply_to":"c9194d58_73bbf777","updated":"2021-09-17 08:18:17.000000000","message":"I\u0027ve confirmed.\nIt would be best if there is a value under groups, but I think there is no problem as it is as test data.","commit_id":"e26e7266d9953cb6874061c2b9fa59e8745524ce"}],"tacker/tests/unit/vnflcm/test_utils.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"64c0ce4e6d218c33f3ef839467a2be58291cdae8","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(expected_flavour_description,"},{"line_number":59,"context_line":"                         param_value[\u0027flavour_description\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_get_param_data_with_group(self):"},{"line_number":62,"context_line":"        vnf_dict \u003d fakes.vnf_dict()"},{"line_number":63,"context_line":"        vnf_keys \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027][\u0027vnfd_simple\u0027]"},{"line_number":64,"context_line":"        self.assertIn(\u0027groups\u0027, vnf_keys)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4531b4ae_a05e3be3","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":41},"updated":"2021-07-28 09:00:26.000000000","message":"I think it\u0027s almost no means to find just `groups` attribute in the dict. Your true purpose　of this patch is ensure that `vnf_dict` has all three expected attributes, `node_templates`, `policies` and `groups` as you described in bug report[1]. So, I\u0027d ask you to check the attributes, and rename the method name.\n\n[1] https://bugs.launchpad.net/tacker/+bug/1929811","commit_id":"92d194375c7e524f840f46053a3993b2b8a5425f"},{"author":{"_account_id":33284,"name":"Navum Gupta","display_name":"Navum Gupta","email":"navum.gupta@india.nec.com","username":"navum"},"change_message_id":"406ceeca59e582e9ae37358f615635d8fd7a2a0c","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(expected_flavour_description,"},{"line_number":59,"context_line":"                         param_value[\u0027flavour_description\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_get_param_data_with_group(self):"},{"line_number":62,"context_line":"        vnf_dict \u003d fakes.vnf_dict()"},{"line_number":63,"context_line":"        vnf_keys \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027][\u0027vnfd_simple\u0027]"},{"line_number":64,"context_line":"        self.assertIn(\u0027groups\u0027, vnf_keys)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbe4d98c_36399625","line":64,"range":{"start_line":61,"start_character":0,"end_line":64,"end_character":41},"in_reply_to":"4531b4ae_a05e3be3","updated":"2021-08-01 12:43:44.000000000","message":"Thanks, for pointed it out we have incorporated the changes for validating \u0027node_templates\u0027 and \u0027policies\u0027too in vnf_dict  in new patchset.","commit_id":"92d194375c7e524f840f46053a3993b2b8a5425f"}]}