)]}'
{"id":"openstack%2Ftacker~797804","triplet_id":"openstack%2Ftacker~master~I51c198d60001dba94dd369f495cecef526e79800","project":"openstack/tacker","branch":"master","topic":"bug/1933169","hashtags":[],"change_id":"I51c198d60001dba94dd369f495cecef526e79800","subject":"Fix create duplicated subscriptions","status":"MERGED","created":"2021-06-24 06:29:09.000000000","updated":"2021-09-27 12:48:48.000000000","submitted":"2021-09-27 12:47:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"797804-bug/1933169","meta_rev_id":"32ca28481864483dd5d3c9f729b1caeb3646ad8c","_number":797804,"virtual_id_number":797804,"owner":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-27 12:47:00.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":0,"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},{"value":2,"date":"2021-09-27 07:38:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":1,"date":"2021-09-22 04:21:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":2,"date":"2021-09-27 12:24:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},{"value":0,"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"value":0,"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"value":1,"date":"2021-09-27 12:24:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"}],"reviewers":{"REVIEWER":[{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-06-24 09:41:57.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-07-02 01:55:02.000000000","updated_by":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"reviewer":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"state":"REVIEWER"},{"updated":"2021-07-02 01:55:02.000000000","updated_by":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"reviewer":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"state":"REVIEWER"},{"updated":"2021-07-02 01:55:02.000000000","updated_by":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"reviewer":{"_account_id":17255,"name":"Toshiaki Takahashi","email":"ts-takahashi@nec.com","username":"takahashi_ts"},"state":"REVIEWER"},{"updated":"2021-07-02 01:55:02.000000000","updated_by":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"reviewer":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"state":"REVIEWER"},{"updated":"2021-07-02 01:55:02.000000000","updated_by":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"reviewer":{"_account_id":26222,"name":"Cong Phuoc Hoang","email":"hoangphuocbk2.07@gmail.com","username":"hoangphuoc"},"state":"REVIEWER"},{"updated":"2021-07-02 01:55:02.000000000","updated_by":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"reviewer":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"state":"REVIEWER"},{"updated":"2021-07-05 01:31:24.000000000","updated_by":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"reviewer":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"state":"REVIEWER"}],"messages":[{"id":"aee5cc4bdcef97a5c89d20c33bcf5941b5da3ae6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-06-24 06:29:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7c8547f334c28367d010a121c57f32f5cb899dc2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-24 09:41:57.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/03680fa4e6104ec6824b5e3b2a809664 : FAILURE in 8m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3ec9d82c2a4246b7854d6e8e8171d268 : SUCCESS in 17m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/24623186875649658c0b2c83f2107750 : SUCCESS in 7m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/90b78bd9d16543a6b523bb23a4ad5c15 : FAILURE in 16m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7298f49f8ec34e40828809df18c2128e : FAILURE in 15m 05s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e87f169e70944ff687514c7f85195f97 : FAILURE in 16m 16s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/02f8734ac20149b7b02f339026cb6d07 : SUCCESS in 8m 37s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/557678d0ddab4a1a959b77cb3ec17bd6 : FAILURE in 2h 55m 31s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/d74c4651d59843b88a800e249a2ff86a : FAILURE in 2h 00m 22s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/27beb6c6d63f45a49de9ba9ef84e7b93 : FAILURE in 58m 09s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/c2feef7e669043d587dee8116919986e : FAILURE in 1h 00m 54s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/818007054f4f4b849cb71cea27419620 : FAILURE in 2h 50m 08s","accounts_in_message":[],"_revision_number":1},{"id":"68ccdd47392ee1de31be48a3d867defd36cb8f1d","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2021-07-05 01:31:24.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThank you for patch.\n\nCould you please consider the following three comments?\n\n1. I think it would be better to test SeeOther is raised correctly at test_vnf_lcm_subscriptions [1] (or another appropriate place). Also, writing such a test helps other developers to see what kind of exceptions can happen without reading many codes.\n\n2. Isn’t it necessary to fix `fake vnfProductsFromProviders` [2] for functional tests?\n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/unit/objects/test_vnf_lcm_subscriptions.py#L116\n\n[2] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol/vnflcm/fake_vnflcm.py#L35\n\n3. Please see the in-line comment at tacker/objects/vnf_lcm_subscriptions.py#245","accounts_in_message":[],"_revision_number":1},{"id":"c85cdb1058ed1580efe5b6404e0c4caf2338035e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-07-12 08:21:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a45b53a3ec4c1658a13bdf07097cce642232b643","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-07-12 08:30:24.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Thank you for patch.\n\u003e \n\u003e Could you please consider the following three comments?\n\u003e \n\u003e 1. I think it would be better to test SeeOther is raised correctly at test_vnf_lcm_subscriptions [1] (or another appropriate place). Also, writing such a test helps other developers to see what kind of exceptions can happen without reading many codes.\n\u003e \n\u003e 2. Isn’t it necessary to fix `fake vnfProductsFromProviders` [2] for functional tests?\n\u003e \n\u003e [1] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/unit/objects/test_vnf_lcm_subscriptions.py#L116\n\u003e \n\u003e [2] https://opendev.org/openstack/tacker/src/branch/master/tacker/tests/functional/sol/vnflcm/fake_vnflcm.py#L35\n\u003e \n\u003e 3. Please see the in-line comment at tacker/objects/vnf_lcm_subscriptions.py#245\n\n1. Sorry, there is currently no test for SeeOther. Since this patch did not modify the old code structure, \nI did not consider adding testcases. From the perspective of unit test coverage, I think there are indeed \na lot of unit tests that need to be added, but I think this is not what this patch should do.\n\n2. According to the definition of SOL003, VnfProductsFromProviders should be an array, not an object, \nso this is an error. In addition, the code for handling VnfProductsFromProviders has been corrected in [1]. \nIf it is not corrected in the functional tests, it will cause an error. So it is necessary to correct this error.\n[1]https://review.opendev.org/c/openstack/tacker/+/797804/1/tacker/objects/vnf_lcm_subscriptions.py#314\n\n3.I replied to the comment in-line.","accounts_in_message":[],"_revision_number":2},{"id":"bf1b1e9696c35e4d5e88d29fd73173073aff2090","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-12 10:30:14.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/825edd55666a40228dffd772f4d57d74 : FAILURE in 7m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/716dcbb4df4b445f954e1ce9809c9df8 : SUCCESS in 17m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0b115131d52a4382bfb50709d59e342b : SUCCESS in 6m 15s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a4c10dbd06354f9088b3fe5bdf9b4ec8 : FAILURE in 15m 29s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3d67fe7399d34b2480f80c46b2745bf0 : FAILURE in 14m 23s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d8eb45563b554e659aec779f8461edac : FAILURE in 14m 30s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ec7718ad342f42ed8af641b058ab8c0b : SUCCESS in 6m 57s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/bc31e46cf4724687bd9a314d33fd2b0f : FAILURE in 2h 01m 54s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/574a4eb8385e4c21abca1a2045bfdac7 : FAILURE in 1h 50m 11s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/94dbb6e881ea4aa3af0ec12d6ab48d0c : FAILURE in 1h 01m 42s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/3a729f51445f4be8af44271ed824289b : FAILURE in 58m 37s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/ab6e842451ca477683c589ab87ad9fc9 : FAILURE in 1h 58m 44s","accounts_in_message":[],"_revision_number":2},{"id":"cc6759ae4861d32d83e458f9561e785f7de3af73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-07-13 02:05:57.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"f6553de56f62ec3a9485bd5e2e93ad74c8e26387","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 04:08:34.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/dc7517387cca4d948900ff7504bf0e78 : SUCCESS in 8m 27s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a2ad2c409b5e4071bc103f56acaec034 : SUCCESS in 15m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dfc6a77d88834d38940033956f9fd04e : SUCCESS in 5m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b3e479e4e42c43c99b0c8af3107feaf4 : SUCCESS in 13m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b4d3155e1d2347f9ac12d3482de17b4d : SUCCESS in 15m 20s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/808ed2567ad741a9bdd00a3d653d06c4 : SUCCESS in 14m 26s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/392c483705db4c98ad0fc001c271b62a : SUCCESS in 7m 13s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/e1d8a7a6f94041d7ac4a8d292fc5f18e : SUCCESS in 2h 00m 34s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/bdef4ac058694415a3de30d0ab745d9f : FAILURE in 1h 18m 50s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/ed46132241ec47a387357035d79d0016 : FAILURE in 57m 25s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/667d4d89ee2e486bb78a720ff4650d2e : SUCCESS in 1h 05m 59s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/08eade8d82a5496099090a20ef82aeb0 : SUCCESS in 1h 48m 32s","accounts_in_message":[],"_revision_number":3},{"id":"0602247e3ac3ed7a161b542e0153c1c4aa221959","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-07-13 06:45:48.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"305cd0f3c0c5b22ec759303bc76a43703e018219","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-13 09:02:11.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7c92cc3c688d4c53aa85f1c676f71fb3 : SUCCESS in 9m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9f624b7c88234747bec342b64e4e5f10 : SUCCESS in 17m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a79be5093f81436798407501c557d685 : SUCCESS in 6m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/208fb430dece4cfa868b1f1738956ba6 : SUCCESS in 15m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c3986f63b0a541ec8cedf1693b93869e : SUCCESS in 15m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c92ba9ddf0dc4a6ab008f4c6f2a2d5f4 : SUCCESS in 14m 52s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e20232b95d74bd9a4d937edd70c910c : SUCCESS in 7m 34s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/6e63ec1d3d554b229da8d14f2451d64a : SUCCESS in 1h 54m 42s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/971284e47df44567b96e1853d9413e34 : FAILURE in 1h 30m 47s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/2c3298d8eadd47c4b35972a8b84debf6 : FAILURE in 56m 16s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/019f889e32954fcf874c4b6cd6d7bf56 : SUCCESS in 1h 12m 38s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/5e2864b98458477fba5d19e60601fa35 : SUCCESS in 1h 49m 25s","accounts_in_message":[],"_revision_number":3},{"id":"f92215ca30f8a2ebb1146d1176c2cb7c80679aca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-07-15 07:31:11.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"c99ad2927732bb22b7a2d0890fa5371248bc0363","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-15 09:55:56.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/543fe129c8cf428d8a396fac2bab4d5d : SUCCESS in 8m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7caa61bfbe7c43a1b412bdb98720b9ce : SUCCESS in 17m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/244d2b4edd27475497bbc4f865643d41 : SUCCESS in 5m 57s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1907ee9da5ca46b5aa9bacf58f41016d : SUCCESS in 14m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8c667f2cad3947afbcb00eb9fc4ac43f : SUCCESS in 14m 20s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8f52ce901177401b8601e3691b25c07a : SUCCESS in 14m 50s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eb14fdab4dc7472384ebb1aa7881731b : SUCCESS in 7m 45s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/3baea4ce197640978ec1b9e776322715 : SUCCESS in 1h 43m 03s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/da83958f24b04371b5a9d921fd8f2858 : SUCCESS in 2h 22m 55s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/9304150681214ffd9780069ef5fc8c0c : SUCCESS in 1h 10m 12s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/8a868a69d02945e5be0ab79802db1f6f : SUCCESS in 1h 11m 50s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/658977f0233c422d9b8deeba0e99af0c : SUCCESS in 1h 43m 22s","accounts_in_message":[],"_revision_number":4},{"id":"a6e5234d1ccce4913f1c3dfa875aa8c53b935b24","author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"date":"2021-07-26 02:25:48.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)\n\nThank you for re-work.\nI\u0027ll add +1.\n\n\u003e1. Sorry, there is currently no test for SeeOther. Since this patch did not modify the old code structure, I did not consider adding testcases. From the perspective of unit test coverage, I think there are indeed a lot of unit tests that need to be added, but I think this is not what this patch should do.\n\nThank you. \nI understood that there\u0027s no changes in the code structure, and thus there\u0027s no reason to add testcases at this moment.\nAlso, I agree with you opinion that there are a lot of unit tests to be added.\nIt\u0027s just my opinion, but we should find the opportunity to do that.\n\n\n\u003e 2. According to the definition of SOL003, VnfProductsFromProviders should be an array, not an object, so this is an error. In addition, the code for handling VnfProductsFromProviders has been corrected in [1]. If it is not corrected in the functional tests, it will cause an error. So it is necessary to correct this error.\n\nSince FT has passed, it seems to be ok.","accounts_in_message":[],"_revision_number":4},{"id":"4eeb1636bfe6777e3dceb201312018cf63d82a10","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2021-08-04 00:41:08.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)\n\nThanks for patch, could you confirm my comment?","accounts_in_message":[],"_revision_number":4},{"id":"26057658def6dfba430d279a5183a670a0aa773b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-08-04 06:12:21.000000000","message":"Patch Set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"e1e4778c8f4d35cb3605cc2c093f77207691cd87","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-08-04 06:12:36.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"ec7ed4bcad4702bebf13ec0ed2aebedf22c4b9de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-04 08:24:19.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e974970c17754023a0c0c29da400cea3 : SUCCESS in 9m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/28c0d786c0f24bf8a114ceafe7967a5c : SUCCESS in 18m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6402bcf8b5534ce59ee4b14fc14c2f3b : SUCCESS in 6m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f49a87c22a7944469bb403ac1b85e22a : SUCCESS in 14m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/185688289a164d439e06b8998452c3c6 : SUCCESS in 15m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b7390b5bd8b744d2a379e4943ad42ef5 : SUCCESS in 15m 06s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d980503ef2df4472878f2b11dab55ad1 : SUCCESS in 9m 27s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/cede1499f3864d36b86d25fd126795d9 : SUCCESS in 1h 51m 15s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/c5b235418ff1405ba93d530567426423 : SUCCESS in 1h 51m 44s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/74087d0a88424848aebf536a6040df0d : SUCCESS in 1h 06m 57s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/c1df69b35e63407fad0a905af3f31cd3 : SUCCESS in 1h 27m 25s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/c218cdad256e4557936d5e0a36c1c6c1 : SUCCESS in 1h 44m 39s","accounts_in_message":[],"_revision_number":5},{"id":"d52d6bc44054d1c23e5214b026d1332dbf55fb40","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2021-08-05 01:06:11.000000000","message":"Patch Set 5: Code-Review+1\n\nThanks for updating, LGTM.","accounts_in_message":[],"_revision_number":5},{"id":"23bbfbb80c236cdf93b4d43db9e3e3f1b2517a25","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-08-05 06:20:51.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"5794cc3fc82d740e3d25db7547bac7ee042cc03d","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2021-09-15 04:42:28.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"2f3cc3b97627d1a9abac1f5a089d195aff0ae1aa","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-09-15 10:06:34.000000000","message":"Patch Set 5: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"8826ac373c5270baaad0016d54b2810f372a6968","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2021-09-15 13:40:27.000000000","message":"Patch Set 5: Code-Review-1\n\nPlease resolve merge conflict. Thanks.","accounts_in_message":[],"_revision_number":5},{"id":"7ed6a07086a4e1a37d9b4b7a645fd0e4b1980780","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-09-20 08:15:18.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"a7ddff8f0d1957670a47d07bb8a97dce00d5bb98","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-09-20 08:17:12.000000000","message":"Patch Set 6:\n\n(2 comments)\n\nTo Yasufumi Ogawa:\nThank you for you advice. I fixed these comments in PS 6.\nPlease kindly check them again.","accounts_in_message":[],"_revision_number":6},{"id":"5059d0f9f7c9d36b7717efd328a1ae860bb678a7","author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"date":"2021-09-20 08:17:37.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 5: Code-Review-1\n\u003e \n\u003e Please resolve merge conflict. Thanks.\n\nI have fixed the conflict in PS 6.","accounts_in_message":[],"_revision_number":6},{"id":"3986d7fde407a82549e8aa426c61a169b348ab86","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-20 10:27:57.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/943a6258e83946618b868460e2bbe43f : SUCCESS in 9m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cf64b536e50a47c8978aade55adec745 : SUCCESS in 15m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/06dbabf9f2d145b8b6af6e84aa4c6f40 : SUCCESS in 7m 03s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/1f59823bc78949c597f2d5c4ee1dcb2b : SUCCESS in 16m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/10d9c1508d8f4b76bda22d7be47ab36f : SUCCESS in 15m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2bafc7b3856641b6ac510c2103835e9d : SUCCESS in 15m 52s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d273bc6051ff4ce9b64b1105808e780b : SUCCESS in 8m 49s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/79e3515082d844f9a32cf43fc4687bad : SUCCESS in 1h 39m 16s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/d82e8f8a587b4059a2660f29260200b7 : SUCCESS in 2h 07m 11s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/1ad2f3b88a794eca80f711a340540d5e : SUCCESS in 1h 02m 45s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/351a0c53d2c54b8f8d9cbc5ccfede11e : SUCCESS in 1h 50m 45s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/392013d9aa87465ca8dbd00a1be85a31 : SUCCESS in 1h 45m 29s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/f0485c267ad748b6a4fcdc2b78b78a76 : SUCCESS in 1h 09m 56s","accounts_in_message":[],"_revision_number":6},{"id":"9306d0548f4341a5ddec3c85bcf3213e5a7015d1","author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"date":"2021-09-22 04:21:17.000000000","message":"Patch Set 6: Code-Review+1\n\nLGTM.","accounts_in_message":[],"_revision_number":6},{"id":"78da97336bef893c0e4c940c3c8e9639c83ba695","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-09-23 07:34:51.000000000","message":"Patch Set 6:\n\nrecheck","accounts_in_message":[],"_revision_number":6},{"id":"bc73e73c14829f8a4dffadd57e8fbb715d38af52","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-23 09:44:51.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/58c0e5a3ae764768b8c27ffda8a3debe : SUCCESS in 8m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ec32e388f11547e49867e4cf653118e1 : FAILURE in 15m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5edc42f1ce7d4102b868d2afcf3fc2d9 : SUCCESS in 6m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/00fe0689f4b944959b7ef9a234aac88b : SUCCESS in 15m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1b608bce0da84ddda61c2db27365d35a : SUCCESS in 15m 33s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/397d7b00dfef4851bf43002d37836037 : SUCCESS in 15m 39s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f1eb36140e034b94aced4b415f95799e : SUCCESS in 7m 17s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/f2d70f06f1994128ae998f5d6e8d9815 : SUCCESS in 1h 41m 41s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/40e144c7b702478bba2bacb76f78fb09 : SUCCESS in 2h 04m 11s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/fb8adfd21d384102954d468c8b88eb6a : SUCCESS in 1h 12m 43s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/36510abc682b4984a72f667ad26912c4 : SUCCESS in 1h 50m 22s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/6688b9a87dd44f069695e680def1c57d : SUCCESS in 1h 42m 26s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/9918addd81a54a3687c0b4d3b52951fa : SUCCESS in 1h 01m 28s","accounts_in_message":[],"_revision_number":6},{"id":"ffacced4e4022dfb29520bbb3e1a1aab3f5b3cbe","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-09-26 06:19:38.000000000","message":"Patch Set 6:\n\nrecheck","accounts_in_message":[],"_revision_number":6},{"id":"9e1482abba2d43a33334d6da3b0d1c094616e5df","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-26 08:47:56.000000000","message":"Patch Set 6:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bcdbf81e330c4a4ea9bc42fb518ed343 : SUCCESS in 10m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f11f15a9a46c4574a61ed67f0f31c441 : SUCCESS in 20m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/470aad7718a34e1a9ba87331149b43a8 : SUCCESS in 8m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/30385836453b46e9a5f3518c38c8adb2 : SUCCESS in 18m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3e7754f0e9fe433a84ae913fcc805c7e : SUCCESS in 17m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/94beffa998ab4d76abdbeae61e02f9a6 : SUCCESS in 19m 26s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1eeb6885343242d39798060eb423d9e9 : SUCCESS in 10m 28s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/29433c558f394acf982b0223689f6467 : SUCCESS in 1h 37m 50s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/4adca33f17be4baf9e2b4435fcfa09b3 : FAILURE in 2h 10m 53s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/e6cfe442253548c099d23749e15bb3ee : SUCCESS in 1h 11m 12s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/8715634307044419806b6f45997fe11f : SUCCESS in 1h 50m 19s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/8430f0f24d9743c6a8f7b50bc76fe937 : SUCCESS in 1h 42m 33s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/9f16b943fc4147eeb12db96f439bd63d : SUCCESS in 55m 02s","accounts_in_message":[],"_revision_number":6},{"id":"569082226b5195607369d612144b7f6c00b80afa","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2021-09-26 11:59:19.000000000","message":"Patch Set 6:\n\nrecheck","accounts_in_message":[],"_revision_number":6},{"id":"5821935ddf766da9ac3e5b8d6d62fc659d62ecc4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-26 14:09:22.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/42708431f92b4841953d9f4d12e9061d : SUCCESS in 8m 33s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f550f87b1e54458981e1fb616eed62ca : SUCCESS in 15m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/478b891e660b4f0da512f1ede87c88c1 : SUCCESS in 7m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6e688b5ed7544433a4fe721c82ba43e2 : SUCCESS in 15m 23s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d65c39265fb24497bdae4b36055e6558 : SUCCESS in 15m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/159b163ef4cd407d948bb0efb2cd6110 : SUCCESS in 16m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1e514d6a5c06408aaf83e2bc873c9293 : SUCCESS in 6m 59s\n- tacker-functional-devstack-multinode-legacy https://zuul.opendev.org/t/openstack/build/c2433b31a35a4f2297a2127686f27065 : SUCCESS in 1h 38m 15s\n- tacker-functional-devstack-multinode-sol https://zuul.opendev.org/t/openstack/build/526c8caefea34c56b47606ad087052ff : SUCCESS in 2h 07m 57s\n- tacker-functional-devstack-multinode-sol-separated-nfvo https://zuul.opendev.org/t/openstack/build/f9bbf585ed5e4e0999f8548fb4a5a774 : SUCCESS in 1h 00m 48s\n- tacker-functional-devstack-multinode-sol-kubernetes https://zuul.opendev.org/t/openstack/build/9b041543f93243a49bdd0617d4eb3e7b : SUCCESS in 1h 28m 25s\n- tacker-functional-devstack-multinode-libs-master https://zuul.opendev.org/t/openstack/build/2f0813a155e541ac9bb18222c0f69730 : SUCCESS in 1h 33m 57s\n- tacker-functional-devstack-multinode-sol-v2 https://zuul.opendev.org/t/openstack/build/c67f0d1402bd4f5f8377a459c93c1f13 : SUCCESS in 58m 23s","accounts_in_message":[],"_revision_number":6},{"id":"782d7d208d1c6be8677ac251293cab69b9112ff0","author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"date":"2021-09-27 07:38:41.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"0130c22d00cdf249b5f8a20a471fd5d94478c518","author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"date":"2021-09-27 12:24:53.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"fbe97d5cc818a3eeb225477b2e21de041fbec5c1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 12:25:15.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"1b640b5e87604361e731904e31950e26bde80e4d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 12:47:00.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/99b08913289a4b5491e2a3d21a45917a : SUCCESS in 15m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/432f861c908c47b0a5ebeabfb413c1b0 : SUCCESS in 5m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/25d6c0dce7a8404b832c9788c93d6620 : SUCCESS in 16m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d8524e8a416b45c9b74d48fc5219e210 : SUCCESS in 16m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d5f5906e9b004796ae91f7b42015e22e : SUCCESS in 8m 05s","accounts_in_message":[],"_revision_number":6},{"id":"220d5523c2fe6239b69c3fb3ddc194c30ab71f73","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 12:47:00.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"32ca28481864483dd5d3c9f729b1caeb3646ad8c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-27 12:48:48.000000000","message":"Patch Set 6:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa5976d0ffa44138aa058ef4c16aa73b : SUCCESS in 1m 25s","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"db9b91aecc63657c7f52d68f8ab3146e9839fccd","revisions":{"210de432a17649f72c153dc86b1082afa7450a9c":{"kind":"REWORK","_number":1,"created":"2021-06-24 06:29:09.000000000","uploader":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"ref":"refs/changes/04/797804/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/04/797804/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/04/797804/1"}}},"commit":{"parents":[{"commit":"8e79746b2819c87ee0dc1654f3478728a1aacad1","subject":"Merge \"Avoid FT errors caused by other projects change\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/8e79746b2819c87ee0dc1654f3478728a1aacad1"}]}],"author":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-06-24 06:27:51.000000000","tz":540},"committer":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-06-24 06:27:51.000000000","tz":540},"subject":"Fix create duplicated subscriptions","message":"Fix create duplicated subscriptions\n\nWhen creating a duplicated subscription, according to spec SOL003,\nthe api should return 303 See Other instead of 201 Created.\n\nTo fix this error, the following things is done in this patch:\n1.Fix the error when the database virtual field extracts\nthe value from json in table `vnf_lcm_filters`.\n2.Fix the error of sql query statement when querying subscription.\n3.Fix type unmatch, request data format error, etc.\n\nCloses-Bug: #1933169\nChange-Id: I51c198d60001dba94dd369f495cecef526e79800\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/210de432a17649f72c153dc86b1082afa7450a9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/210de432a17649f72c153dc86b1082afa7450a9c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"af9dbe9ea83b153cc63f11c94fd2b0c9588a8b49":{"kind":"REWORK","_number":2,"created":"2021-07-12 08:21:46.000000000","uploader":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"ref":"refs/changes/04/797804/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/04/797804/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/04/797804/2"}}},"commit":{"parents":[{"commit":"8e79746b2819c87ee0dc1654f3478728a1aacad1","subject":"Merge \"Avoid FT errors caused by other projects change\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/8e79746b2819c87ee0dc1654f3478728a1aacad1"}]}],"author":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-06-24 06:27:51.000000000","tz":540},"committer":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-07-12 08:21:29.000000000","tz":540},"subject":"Fix create duplicated subscriptions","message":"Fix create duplicated subscriptions\n\nWhen creating a duplicated subscription, according to spec SOL003,\nthe api should return 303 See Other instead of 201 Created.\n\nTo fix this error, the following things is done in this patch:\n1.Fix the error when the database virtual field extracts\nthe value from json in table `vnf_lcm_filters`.\n2.Fix the error of sql query statement when querying subscription.\n3.Fix type unmatch, request data format error, etc.\n\nCloses-Bug: #1933169\nChange-Id: I51c198d60001dba94dd369f495cecef526e79800\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/af9dbe9ea83b153cc63f11c94fd2b0c9588a8b49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/af9dbe9ea83b153cc63f11c94fd2b0c9588a8b49"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"56b8db6d9e3ee591570ab3ac2118c1ed1a6eb5f0":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-07-13 02:05:57.000000000","uploader":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"ref":"refs/changes/04/797804/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/04/797804/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/04/797804/3"}}},"commit":{"parents":[{"commit":"a98cd4eaa9f2c1669f0a1d1c748d6d0028edd1f4","subject":"Merge \"Fix migration for SQLAlchemy 1.4\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/a98cd4eaa9f2c1669f0a1d1c748d6d0028edd1f4"}]}],"author":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-06-24 06:27:51.000000000","tz":540},"committer":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-07-13 02:05:57.000000000","tz":0},"subject":"Fix create duplicated subscriptions","message":"Fix create duplicated subscriptions\n\nWhen creating a duplicated subscription, according to spec SOL003,\nthe api should return 303 See Other instead of 201 Created.\n\nTo fix this error, the following things is done in this patch:\n1.Fix the error when the database virtual field extracts\nthe value from json in table `vnf_lcm_filters`.\n2.Fix the error of sql query statement when querying subscription.\n3.Fix type unmatch, request data format error, etc.\n\nCloses-Bug: #1933169\nChange-Id: I51c198d60001dba94dd369f495cecef526e79800\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/56b8db6d9e3ee591570ab3ac2118c1ed1a6eb5f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/56b8db6d9e3ee591570ab3ac2118c1ed1a6eb5f0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a98cd4eaa9f2c1669f0a1d1c748d6d0028edd1f4","is_merged_in_target_branch":true}],"branch":"refs/heads/master","description":"Rebase"},"673df1b890e18bebc95ec3f82ec7545ab95020f2":{"kind":"REWORK","_number":4,"created":"2021-07-15 07:31:11.000000000","uploader":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"ref":"refs/changes/04/797804/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/04/797804/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/04/797804/4"}}},"commit":{"parents":[{"commit":"8e79746b2819c87ee0dc1654f3478728a1aacad1","subject":"Merge \"Avoid FT errors caused by other projects change\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/8e79746b2819c87ee0dc1654f3478728a1aacad1"}]}],"author":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-06-24 06:27:51.000000000","tz":540},"committer":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-07-15 07:31:16.000000000","tz":540},"subject":"Fix create duplicated subscriptions","message":"Fix create duplicated subscriptions\n\nWhen creating a duplicated subscription, according to spec SOL003,\nthe api should return 303 See Other instead of 201 Created.\n\nTo fix this error, the following things is done in this patch:\n1.Fix the error when the database virtual field extracts\nthe value from json in table `vnf_lcm_filters`.\n2.Fix the error of sql query statement when querying subscription.\n3.Fix type unmatch, request data format error, etc.\n\nCloses-Bug: #1933169\nChange-Id: I51c198d60001dba94dd369f495cecef526e79800\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/673df1b890e18bebc95ec3f82ec7545ab95020f2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/673df1b890e18bebc95ec3f82ec7545ab95020f2"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"c0ded58ddf39c433f2b18779321f75ccd1445ff6":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2021-08-04 06:12:21.000000000","uploader":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"ref":"refs/changes/04/797804/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/04/797804/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/04/797804/5"}}},"commit":{"parents":[{"commit":"8e79746b2819c87ee0dc1654f3478728a1aacad1","subject":"Merge \"Avoid FT errors caused by other projects change\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/8e79746b2819c87ee0dc1654f3478728a1aacad1"}]}],"author":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-06-24 06:27:51.000000000","tz":540},"committer":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-08-04 06:12:21.000000000","tz":0},"subject":"Fix create duplicated subscriptions","message":"Fix create duplicated subscriptions\n\nWhen creating a duplicated subscription, according to spec SOL003,\nthe api should return 303 See Other instead of 201 Created.\n\nTo fix this error, the following things is done in this patch:\n1.Fix the error when the database virtual field extracts\nthe value from json in table `vnf_lcm_filters`.\n2.Fix the error of sql query statement when querying subscription.\n3.The attribute VnfProductsFromProviders should be an array, not an\nobject. Fix this error in UT, FT and schemas.\n4.Fix typos when writing \"object\" as \"objects\" in dict \"_versions\"\nin vnf_lcm schemas.\n5.Rewrite the throwing and catching of SeeOther exception of this\napi to fix the following errors: SeeOther should be thrown instead\nof Exception; the return body should be empty instead of\nProblemDetail; the return header should contain location instead\nof link.\n\nCloses-Bug: #1933169\nChange-Id: I51c198d60001dba94dd369f495cecef526e79800\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c0ded58ddf39c433f2b18779321f75ccd1445ff6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/c0ded58ddf39c433f2b18779321f75ccd1445ff6"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8e79746b2819c87ee0dc1654f3478728a1aacad1","is_merged_in_target_branch":true}],"branch":"refs/heads/master","description":"Edit commit message"},"db9b91aecc63657c7f52d68f8ab3146e9839fccd":{"kind":"REWORK","_number":6,"created":"2021-09-20 08:15:18.000000000","uploader":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"ref":"refs/changes/04/797804/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tacker","ref":"refs/changes/04/797804/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tacker refs/changes/04/797804/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tacker refs/changes/04/797804/6"}}},"commit":{"parents":[{"commit":"6929cbc3f1bc5ed766b33d787da77969f64da1c1","subject":"Support PVs for k8s cluster with MgmtDriver","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/6929cbc3f1bc5ed766b33d787da77969f64da1c1"}]}],"author":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-06-24 06:27:51.000000000","tz":540},"committer":{"name":"Yi Feng","email":"fengyi@fujitsu.com","date":"2021-09-20 08:16:25.000000000","tz":540},"subject":"Fix create duplicated subscriptions","message":"Fix create duplicated subscriptions\n\nWhen creating a duplicated subscription, according to spec SOL003,\nthe api should return 303 See Other instead of 201 Created.\n\nTo fix this error, the following things is done in this patch:\n1.Fix the error when the database virtual field extracts\nthe value from json in table `vnf_lcm_filters`.\n2.Fix the error of sql query statement when querying subscription.\n3.The attribute VnfProductsFromProviders should be an array, not an\nobject. Fix this error in UT, FT and schemas.\n4.Fix typos when writing \"object\" as \"objects\" in dict \"_versions\"\nin vnf_lcm schemas.\n5.Rewrite the throwing and catching of SeeOther exception of this\napi to fix the following errors: SeeOther should be thrown instead\nof Exception; the return body should be empty instead of\nProblemDetail; the return header should contain location instead\nof link.\n\nCloses-Bug: #1933169\nChange-Id: I51c198d60001dba94dd369f495cecef526e79800\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/db9b91aecc63657c7f52d68f8ab3146e9839fccd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tacker/commit/db9b91aecc63657c7f52d68f8ab3146e9839fccd"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"6929cbc3f1bc5ed766b33d787da77969f64da1c1","is_merged_in_target_branch":true,"change_id":"Iaab9b6393e6f2007c637f83a82de0d27cf9db257","change_number":806133,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}