)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"0159750208b10eccb6f47661a1c1d52ee1583b16","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Because the definition of the object had much number of the files,"},{"line_number":16,"context_line":"the patch of logic part is separated to make code review easy."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implementation note:"},{"line_number":19,"context_line":"Objects are defined as is according to ETSI NFV-SOL specifications."},{"line_number":20,"context_line":"This means attributes of objects are not converted to snake case"},{"line_number":21,"context_line":"but camel case as is because the conversion is meaningless"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"840f354c_77931f13","line":18,"updated":"2021-09-03 09:10:07.000000000","message":"I think this patch uses \u0027nullable \u003d True\u0027 not to mean that the field value can be set to null, but to mean that the field value can be omitted.\nSince this is the patch-specific usage, could you add it to the \u0027Implementation note\u0027 like the class naming convention?","commit_id":"61e486687a367ad324438984feff9f6caa7f955e"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"a24e31e24c9100d87cea2ba2b56c400215bdc493","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Because the definition of the object had much number of the files,"},{"line_number":16,"context_line":"the patch of logic part is separated to make code review easy."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implementation note:"},{"line_number":19,"context_line":"Objects are defined as is according to ETSI NFV-SOL specifications."},{"line_number":20,"context_line":"This means attributes of objects are not converted to snake case"},{"line_number":21,"context_line":"but camel case as is because the conversion is meaningless"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"eded4365_2272600b","line":18,"in_reply_to":"840f354c_77931f13","updated":"2021-09-05 22:22:16.000000000","message":"I see. I will add.","commit_id":"61e486687a367ad324438984feff9f6caa7f955e"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"ad9500fc207dfa64f8860978bb8101aaa137da30","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Because the definition of the object had much number of the files,"},{"line_number":16,"context_line":"the patch of logic part is separated to make code review easy."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implementation note:"},{"line_number":19,"context_line":"Objects are defined as is according to ETSI NFV-SOL specifications."},{"line_number":20,"context_line":"This means attributes of objects are not converted to snake case"},{"line_number":21,"context_line":"but camel case as is because the conversion is meaningless"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"93a2ec9a_022faa84","line":18,"in_reply_to":"eded4365_2272600b","updated":"2021-09-06 04:35:38.000000000","message":"Done","commit_id":"61e486687a367ad324438984feff9f6caa7f955e"}],"tacker/sol_refactored/objects/common/fields.py":[{"author":{"_account_id":31668},"change_message_id":"251616410cd0d40b42b4a6c2b731879d1f940cd0","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# NFV-SOL 013"},{"line_number":63,"context_line":"# - v2.7.1 7.1.5"},{"line_number":64,"context_line":"class KeyValuePairsField(AutoTypedField):"},{"line_number":65,"context_line":"    AUTO_TYPE \u003d ovoo_fields.Dict(Jsonable(), nullable\u003dTrue)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"8e659e7a_66c7200b","line":63,"updated":"2021-09-02 05:20:13.000000000","message":"Why is it compliant with major version v2 SOL instead of major version v3?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"676f397fd2bb2a2b923ef0172fc66424277b92eb","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# NFV-SOL 013"},{"line_number":63,"context_line":"# - v2.7.1 7.1.5"},{"line_number":64,"context_line":"class KeyValuePairsField(AutoTypedField):"},{"line_number":65,"context_line":"    AUTO_TYPE \u003d ovoo_fields.Dict(Jsonable(), nullable\u003dTrue)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b4478463_70778f15","line":63,"in_reply_to":"1905ea02_e914cac3","updated":"2021-09-03 00:35:26.000000000","message":"oops, I have changed to v3.3.1. I will change to v3.4.1 at the next chance.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6e2b71bca1680e49f237949bc3db6a424178765e","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# NFV-SOL 013"},{"line_number":63,"context_line":"# - v2.7.1 7.1.5"},{"line_number":64,"context_line":"class KeyValuePairsField(AutoTypedField):"},{"line_number":65,"context_line":"    AUTO_TYPE \u003d ovoo_fields.Dict(Jsonable(), nullable\u003dTrue)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e192a8c6_c28d3f1b","line":63,"in_reply_to":"8e659e7a_66c7200b","updated":"2021-09-02 23:01:37.000000000","message":"may be it is referred when the code was written. there is no difference between v2.7.1 and v3.3.1. but this comment is confusing. so I will change to v3.3.1.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"e06b3435a80d8b0b865c2de5df024b67111edcac","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# NFV-SOL 013"},{"line_number":63,"context_line":"# - v2.7.1 7.1.5"},{"line_number":64,"context_line":"class KeyValuePairsField(AutoTypedField):"},{"line_number":65,"context_line":"    AUTO_TYPE \u003d ovoo_fields.Dict(Jsonable(), nullable\u003dTrue)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"19f988e2_eebd8c3f","line":63,"in_reply_to":"b4478463_70778f15","updated":"2021-09-05 23:55:06.000000000","message":"Done","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"12937eb113febce54c8be04d5e4d7f7809a41ef5","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# NFV-SOL 013"},{"line_number":63,"context_line":"# - v2.7.1 7.1.5"},{"line_number":64,"context_line":"class KeyValuePairsField(AutoTypedField):"},{"line_number":65,"context_line":"    AUTO_TYPE \u003d ovoo_fields.Dict(Jsonable(), nullable\u003dTrue)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1905ea02_e914cac3","line":63,"in_reply_to":"e192a8c6_c28d3f1b","updated":"2021-09-02 23:55:32.000000000","message":"I see.\nI think it\u0027s better to add v3.4.1 instead of v3.3.1 as in the code below(SubscriptionAuthentication).\nhttps://review.opendev.org/c/openstack/tacker/+/803692/5/tacker/sol_refactored/objects/common/subscription_authentication.py\n\nOne of the specs is that the version of SOL013 is described as v3.4.1.\nhttps://specs.openstack.org/openstack/tacker-specs/specs/xena/multi-version-api.html","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/common/ip_over_ethernet_address_data.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":58,"context_line":"class IpOverEthernetAddressInfoV2_IpAddresses_AddressRange("},{"line_number":59,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":4,"id":"b078a1eb_184a2f00","line":58,"updated":"2021-08-25 07:16:46.000000000","message":"It doesn\u0027t correspond to the #L51 (\u0027IpOverEthernetAddressData_IpAddresses_AddressRange\u0027), is it correct?","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":58,"context_line":"class IpOverEthernetAddressInfoV2_IpAddresses_AddressRange("},{"line_number":59,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":4,"id":"8a484930_8c0caf15","line":58,"in_reply_to":"b078a1eb_184a2f00","updated":"2021-08-25 23:59:45.000000000","message":"You are right. I will fix.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":39,"context_line":"class IpOverEthernetAddressData_IpAddresses("},{"line_number":40,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea7eaa0e_beba92cb","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":43},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bd9b99e27852fe22ff15dab754c5f1265a60931c","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":39,"context_line":"class IpOverEthernetAddressData_IpAddresses("},{"line_number":40,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"a62dc149_2b6d08d7","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":43},"in_reply_to":"9d938612_76eb89fa","updated":"2021-09-01 04:45:49.000000000","message":"ueha: What do you think to add a note in commit message for describing the reason? It looks smart naming convention for me to remove such a complexities, but something strange with our our convention for class name of camel case as you pointed out. I think we just need to have an explanation for the new rule.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2be9b4c0b88aa2b8793394d26428c249935bfd5e","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":39,"context_line":"class IpOverEthernetAddressData_IpAddresses("},{"line_number":40,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"be105ae8_0f00332f","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":43},"in_reply_to":"a62dc149_2b6d08d7","updated":"2021-09-01 13:38:29.000000000","message":"yasufum: That\u0027s a good suggestion. If the explanation of naming rule is written in commit message, I think more helpful to other and after developer.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"581822de7e9089d9a45749e8f360ce8fd862fbcc","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":39,"context_line":"class IpOverEthernetAddressData_IpAddresses("},{"line_number":40,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"f93c37f6_cf6cde58","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":43},"in_reply_to":"be105ae8_0f00332f","updated":"2021-09-01 16:14:13.000000000","message":"Thanks!","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":39,"context_line":"class IpOverEthernetAddressData_IpAddresses("},{"line_number":40,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"9d938612_76eb89fa","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":43},"in_reply_to":"ea7eaa0e_beba92cb","updated":"2021-08-26 22:46:48.000000000","message":"It is an inner struct which is not define a separate chapter. Naming convention of such inner structs used in this patch over all is that \u0027parent class name\u0027 + \u0027_\u0027 + \u0027camel case of the attribute name in the parent class\u0027.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":58,"context_line":"class IpOverEthernetAddressData_IpAddresses_AddressRange("},{"line_number":59,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"f8cf6f23_cd6d4b39","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":56},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":58,"context_line":"class IpOverEthernetAddressData_IpAddresses_AddressRange("},{"line_number":59,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"9be3a5b9_2587cebd","line":58,"range":{"start_line":58,"start_character":6,"end_line":58,"end_character":56},"in_reply_to":"f8cf6f23_cd6d4b39","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/common/link.py":[{"author":{"_account_id":31668},"change_message_id":"251616410cd0d40b42b4a6c2b731879d1f940cd0","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class Link(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0fb795a0_16a09f29","line":21,"updated":"2021-09-02 05:20:13.000000000","message":"Why is it compliant with major version v2 SOL instead of major version v3?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6e2b71bca1680e49f237949bc3db6a424178765e","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class Link(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"96342c81_ead7729a","line":21,"in_reply_to":"0fb795a0_16a09f29","updated":"2021-09-02 23:01:37.000000000","message":"I will change to v3.3.1.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"e06b3435a80d8b0b865c2de5df024b67111edcac","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class Link(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"32430c93_8b6b874e","line":21,"in_reply_to":"87ee6451_8664e4b8","updated":"2021-09-05 23:55:06.000000000","message":"Done","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"12937eb113febce54c8be04d5e4d7f7809a41ef5","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class Link(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"87ee6451_8664e4b8","line":21,"in_reply_to":"96342c81_ead7729a","updated":"2021-09-02 23:55:32.000000000","message":"v3.4.1 is better.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/common/notification_link.py":[{"author":{"_account_id":31668},"change_message_id":"251616410cd0d40b42b4a6c2b731879d1f940cd0","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.4"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class NotificationLink(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"00f0fe80_0851d6b0","line":21,"updated":"2021-09-02 05:20:13.000000000","message":"Why is it compliant with major version v2 SOL instead of major version v3?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6e2b71bca1680e49f237949bc3db6a424178765e","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.4"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class NotificationLink(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"0b1c98f6_a2bad115","line":21,"in_reply_to":"00f0fe80_0851d6b0","updated":"2021-09-02 23:01:37.000000000","message":"I will change to v3.3.1.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"12937eb113febce54c8be04d5e4d7f7809a41ef5","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.4"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class NotificationLink(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9bec6c0c_4969b989","line":21,"in_reply_to":"0b1c98f6_a2bad115","updated":"2021-09-02 23:55:32.000000000","message":"v3.4.1 is better.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"e06b3435a80d8b0b865c2de5df024b67111edcac","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 7.1.4"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class NotificationLink(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"24a0eb86_08b39836","line":21,"in_reply_to":"9bec6c0c_4969b989","updated":"2021-09-05 23:55:06.000000000","message":"Done","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/common/problem_details.py":[{"author":{"_account_id":31668},"change_message_id":"251616410cd0d40b42b4a6c2b731879d1f940cd0","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 6.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class ProblemDetails(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f565093_9642c956","line":21,"updated":"2021-09-02 05:20:13.000000000","message":"Why is it compliant with major version v2 SOL instead of major version v3?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"e06b3435a80d8b0b865c2de5df024b67111edcac","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 6.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class ProblemDetails(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d91bd175_6b6eb0b4","line":21,"in_reply_to":"3940fe5e_0ee3576b","updated":"2021-09-05 23:55:06.000000000","message":"Done","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"6e2b71bca1680e49f237949bc3db6a424178765e","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 6.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class ProblemDetails(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"4993dba9_c7547975","line":21,"in_reply_to":"3f565093_9642c956","updated":"2021-09-02 23:01:37.000000000","message":"I will change to v3.3.1.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"12937eb113febce54c8be04d5e4d7f7809a41ef5","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 013"},{"line_number":21,"context_line":"# - v2.7.1 6.3"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class ProblemDetails(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3940fe5e_0ee3576b","line":21,"in_reply_to":"4993dba9_c7547975","updated":"2021-09-02 23:55:32.000000000","message":"v3.4.1 is better.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/common/subscription_authentication.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":47,"context_line":"class SubscriptionAuthentication_ParamsBasic(base.TackerObject,"},{"line_number":48,"context_line":"                                             base.TackerObjectDictCompat):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"c000f11e_bd138543","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":33},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":47,"context_line":"class SubscriptionAuthentication_ParamsBasic(base.TackerObject,"},{"line_number":48,"context_line":"                                             base.TackerObjectDictCompat):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"28e817fe_f44469e5","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":33},"in_reply_to":"c000f11e_bd138543","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":61,"context_line":"# according to a principle, but shortened it as it is too long."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":64,"context_line":"class SubscriptionAuthentication_ParamsOauth2("},{"line_number":65,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"8a1f5c5f_42429327","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":33},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":61,"context_line":"# according to a principle, but shortened it as it is too long."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":64,"context_line":"class SubscriptionAuthentication_ParamsOauth2("},{"line_number":65,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"ee9b6625_fed76e31","line":64,"range":{"start_line":64,"start_character":32,"end_line":64,"end_character":33},"in_reply_to":"8a1f5c5f_42429327","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/common/vnf_instance_subscription_filter.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# but omits it as it is too long."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":43,"context_line":"class _VnfProductsFromProviders("},{"line_number":44,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"a97922ad_7379b442","line":43,"range":{"start_line":43,"start_character":6,"end_line":43,"end_character":7},"updated":"2021-08-26 06:44:32.000000000","message":"Do you need a leading underscore? I think class name should be `upper camel case` like other classes.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# but omits it as it is too long."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":43,"context_line":"class _VnfProductsFromProviders("},{"line_number":44,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"fec42023_c5d3ea7b","line":43,"range":{"start_line":43,"start_character":6,"end_line":43,"end_character":7},"in_reply_to":"a97922ad_7379b442","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py and the NOTE just above. \u0027_\u0027 is left to mean it is an inner class.","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":57,"context_line":"class _VnfProductsFromProviders_VnfProducts("},{"line_number":58,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"da8549ba_e6705d17","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":43},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":57,"context_line":"class _VnfProductsFromProviders_VnfProducts("},{"line_number":58,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"27ef637c_665e75a7","line":57,"range":{"start_line":57,"start_character":6,"end_line":57,"end_character":43},"in_reply_to":"da8549ba_e6705d17","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":71,"context_line":"class _VnfProductsFromProviders_VnfProducts_Versions("},{"line_number":72,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"6609700d_b3ab83f9","line":71,"range":{"start_line":71,"start_character":6,"end_line":71,"end_character":52},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":71,"context_line":"class _VnfProductsFromProviders_VnfProducts_Versions("},{"line_number":72,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"61827f2e_f8080675","line":71,"range":{"start_line":71,"start_character":6,"end_line":71,"end_character":52},"in_reply_to":"6609700d_b3ab83f9","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v1/grant.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        \u0027id\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027vnfInstanceId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027vnfLcmOpOccId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027zones\u0027: fields.ListOfObjectsField("},{"line_number":36,"context_line":"            \u0027ZoneInfoV1\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"39dab15c_a5865164","line":33,"updated":"2021-08-18 08:29:17.000000000","message":"The \"vimConnectionInfo\" data type is \"map(VimConnectionInfo)\".\nIMO, it should be \"fields.DictOfObjectsField\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        \u0027id\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027vnfInstanceId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027vnfLcmOpOccId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027zones\u0027: fields.ListOfObjectsField("},{"line_number":36,"context_line":"            \u0027ZoneInfoV1\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c714b3c_261697dd","line":33,"in_reply_to":"39dab15c_a5865164","updated":"2021-08-19 02:56:20.000000000","message":"vimConnectionInfo is an array because Cardinality is \"0..N\" (ex. same as zones). Each member of an array is a map(VimConnectionInfo).","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \u0027id\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027vnfInstanceId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027vnfLcmOpOccId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027zones\u0027: fields.ListOfObjectsField("},{"line_number":36,"context_line":"            \u0027ZoneInfoV1\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"15385b88_07b95045","line":33,"in_reply_to":"3c714b3c_261697dd","updated":"2021-08-19 05:08:34.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            \u0027GrantInfoV1\u0027, nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027vimAssets\u0027: fields.ObjectField("},{"line_number":48,"context_line":"            \u0027GrantV1_VimAssets\u0027, nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027extVirtualLinks\u0027: fields.ObjectField("},{"line_number":50,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":51,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ObjectField("},{"line_number":52,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"5eec19e5_37077057","line":49,"updated":"2021-08-25 07:16:46.000000000","message":"Since this attribute\u0027s cardinality is 0..N,\nI think fields.ListOfObjectsField is correct.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            \u0027GrantInfoV1\u0027, nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027vimAssets\u0027: fields.ObjectField("},{"line_number":48,"context_line":"            \u0027GrantV1_VimAssets\u0027, nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027extVirtualLinks\u0027: fields.ObjectField("},{"line_number":50,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":51,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ObjectField("},{"line_number":52,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"f733843d_9833c746","line":49,"in_reply_to":"5eec19e5_37077057","updated":"2021-08-25 23:59:45.000000000","message":"You are right. I will fix.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            \u0027GrantV1_VimAssets\u0027, nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027extVirtualLinks\u0027: fields.ObjectField("},{"line_number":50,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":51,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ObjectField("},{"line_number":52,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":53,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":54,"context_line":"        \u0027_links\u0027: fields.ObjectField(\u0027GrantV1_Links\u0027, nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":4,"id":"0984cb43_bf27cdda","line":51,"updated":"2021-08-25 07:16:46.000000000","message":"ditto","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            \u0027GrantV1_VimAssets\u0027, nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027extVirtualLinks\u0027: fields.ObjectField("},{"line_number":50,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":51,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ObjectField("},{"line_number":52,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":53,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":54,"context_line":"        \u0027_links\u0027: fields.ObjectField(\u0027GrantV1_Links\u0027, nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":4,"id":"402a8a0b_31444810","line":51,"in_reply_to":"0984cb43_bf27cdda","updated":"2021-08-25 23:59:45.000000000","message":"ditto","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":59,"context_line":"class GrantV1_VimAssets(base.TackerObject,"},{"line_number":60,"context_line":"                        base.TackerObjectDictCompat):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"002809b0_05d62827","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":14},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":59,"context_line":"class GrantV1_VimAssets(base.TackerObject,"},{"line_number":60,"context_line":"                        base.TackerObjectDictCompat):"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"b1314ffe_16edec02","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":14},"in_reply_to":"002809b0_05d62827","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":76,"context_line":"class GrantV1_Links(base.TackerObject):"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    # Version 1.0: Initial version"},{"line_number":79,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5850fe85_b9001fea","line":76,"range":{"start_line":76,"start_character":13,"end_line":76,"end_character":14},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":76,"context_line":"class GrantV1_Links(base.TackerObject):"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    # Version 1.0: Initial version"},{"line_number":79,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"f04822e1_8aed12ab","line":76,"range":{"start_line":76,"start_character":13,"end_line":76,"end_character":14},"in_reply_to":"5850fe85_b9001fea","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v1/grant_request.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":56,"context_line":"class GrantRequestV1_Links(base.TackerObject):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # Version 1.0: Initial version"},{"line_number":59,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"02067dad_8ba0d59e","line":56,"range":{"start_line":56,"start_character":20,"end_line":56,"end_character":21},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":56,"context_line":"class GrantRequestV1_Links(base.TackerObject):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # Version 1.0: Initial version"},{"line_number":59,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3dad3b10_b2a33972","line":56,"range":{"start_line":56,"start_character":20,"end_line":56,"end_character":21},"in_reply_to":"02067dad_8ba0d59e","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v1/resource_definition.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        ),"},{"line_number":39,"context_line":"        \u0027vduId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027resourceTemplateId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027resource\u0027: fields.ObjectField("},{"line_number":43,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dTrue),"},{"line_number":44,"context_line":"        \u0027snapshotResDef\u0027: fields.ObjectField("}],"source_content_type":"text/x-python","patch_set":1,"id":"339a751e_000d9090","line":41,"updated":"2021-08-18 08:29:17.000000000","message":"IMO, should need \"nullable\u003dFalse\" param. (The cardinality is 1)","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        ),"},{"line_number":39,"context_line":"        \u0027vduId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027resourceTemplateId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027resource\u0027: fields.ObjectField("},{"line_number":43,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dTrue),"},{"line_number":44,"context_line":"        \u0027snapshotResDef\u0027: fields.ObjectField("}],"source_content_type":"text/x-python","patch_set":1,"id":"97e3817c_52bb78d6","line":41,"in_reply_to":"339a751e_000d9090","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        ),"},{"line_number":39,"context_line":"        \u0027vduId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027resourceTemplateId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027resource\u0027: fields.ObjectField("},{"line_number":43,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dTrue),"},{"line_number":44,"context_line":"        \u0027snapshotResDef\u0027: fields.ObjectField("}],"source_content_type":"text/x-python","patch_set":1,"id":"283b294e_dddf5fdd","line":41,"in_reply_to":"97e3817c_52bb78d6","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/cancel_mode.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027cancel_mode\u0027: v2fields.CancelModeTypeField(nullable\u003dFalse),"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"f77b03ca_6531cbac","line":29,"updated":"2021-08-18 08:29:17.000000000","message":"IMO, the field name should be \"cancelMode\" (Camel-case).","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027cancel_mode\u0027: v2fields.CancelModeTypeField(nullable\u003dFalse),"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"625d1728_48dc56c2","line":29,"in_reply_to":"7b1386ef_17e0eda3","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027cancel_mode\u0027: v2fields.CancelModeTypeField(nullable\u003dFalse),"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b1386ef_17e0eda3","line":29,"in_reply_to":"f77b03ca_6531cbac","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/change_current_vnf_pkg_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"c7f7cf6b_6c6a2109","line":35,"updated":"2021-08-19 05:08:34.000000000","message":"Cardinality is \"0..N\" in NFV-SOL 003 v3.3.1 5.5.2.11a.\nIMO, the field should be \"fields.ListOfObjectsField\".","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7c3c563c_8333c3c3","line":35,"in_reply_to":"9b7416ca_3f4ec629","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e9ac8a0015862e91e2b327359b38fc78768eaf38","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b7416ca_3f4ec629","line":35,"in_reply_to":"c7f7cf6b_6c6a2109","updated":"2021-08-19 05:47:55.000000000","message":"Ah, this pattern is a wrong definition actually. I will fix.","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"}],"tacker/sol_refactored/objects/v2/change_ext_vnf_connectivity_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":31,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":33,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":35,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"55b91a7b_46b87e71","line":32,"updated":"2021-08-19 05:08:34.000000000","message":"Cardinality is \"0..N\" in NFV-SOL 003 v3.3.1 5.5.2.11.\nIMO, the field should be \"fields.ListOfObjectsField\".","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e9ac8a0015862e91e2b327359b38fc78768eaf38","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":31,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":33,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":35,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"edeacef5_b46a906e","line":32,"in_reply_to":"55b91a7b_46b87e71","updated":"2021-08-19 05:47:55.000000000","message":"Ack","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":31,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":33,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":35,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"e37c40df_641dc5b6","line":32,"in_reply_to":"edeacef5_b46a906e","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":31,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":33,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"f008a5da_aa900540","line":30,"updated":"2021-08-25 07:16:46.000000000","message":"Since this attribute\u0027s cardinality is 1..N, It think \u0027nullable\u003dFalse\u0027 is correct.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027extVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":31,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":33,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"540a1a01_aaa7e05f","line":30,"in_reply_to":"f008a5da_aa900540","updated":"2021-08-25 23:59:45.000000000","message":"You are right. I will fix.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"}],"tacker/sol_refactored/objects/v2/change_vnf_flavour_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c75d4e6_f73d90fc","line":35,"updated":"2021-08-19 05:08:34.000000000","message":"Cardinality is \"0..N\" in NFV-SOL 003 v3.3.1 5.5.2.7.\nIMO, the field should be \"fields.ListOfObjectsField\".","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e9ac8a0015862e91e2b327359b38fc78768eaf38","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b367cbc_af2bf083","line":35,"in_reply_to":"1c75d4e6_f73d90fc","updated":"2021-08-19 05:47:55.000000000","message":"Ack","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c19c773_8d840bbf","line":35,"in_reply_to":"8b367cbc_af2bf083","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"}],"tacker/sol_refactored/objects/v2/create_vnf_snapshot_request.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        \u0027vnfSnapshotInfoId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027userDefinedData\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"0c24ad5c_ee1a875f","line":33,"updated":"2021-08-25 07:16:46.000000000","message":"vnfcInstanceId defined in SOL002 v3.3.1 5.5.2.21 should be added.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        \u0027vnfSnapshotInfoId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027userDefinedData\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"a9fcc8c6_e1b2f8c6","line":33,"in_reply_to":"0c24ad5c_ee1a875f","updated":"2021-08-25 23:59:45.000000000","message":"I see. I will add it with a comment.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"}],"tacker/sol_refactored/objects/v2/external_artifacts_access_config.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":36,"context_line":"class ExternalArtifactsAccessConfigV2_Artifact("},{"line_number":37,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"0b9331b7_ad2d30ad","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":38},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":36,"context_line":"class ExternalArtifactsAccessConfigV2_Artifact("},{"line_number":37,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"7058713b_9032da6b","line":36,"range":{"start_line":36,"start_character":37,"end_line":36,"end_character":38},"in_reply_to":"0b9331b7_ad2d30ad","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":63,"context_line":"class ExternalArtifactsAccessConfigV2_Artifact_ParamsOauth2ClientCredentials("},{"line_number":64,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"130e2edd_63625196","line":63,"range":{"start_line":63,"start_character":37,"end_line":63,"end_character":47},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":63,"context_line":"class ExternalArtifactsAccessConfigV2_Artifact_ParamsOauth2ClientCredentials("},{"line_number":64,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"ae48ccc7_f5c10581","line":63,"range":{"start_line":63,"start_character":37,"end_line":63,"end_character":47},"in_reply_to":"130e2edd_63625196","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/heal_vnf_request.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027cause\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":30,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":31,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"258e0afa_6a5b2c00","line":31,"updated":"2021-08-25 07:16:46.000000000","message":"vnfcInstanceId and healScript defined in SOL002 v3.3.1 5.5.2.9 should be added.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027cause\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":30,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":31,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"842dc196_ba40a4df","line":31,"in_reply_to":"258e0afa_6a5b2c00","updated":"2021-08-25 23:59:45.000000000","message":"I see. I will add them with a comment.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"}],"tacker/sol_refactored/objects/v2/instantiate_vnf_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027localizationLanguage\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa4d5aab_95de86b9","line":35,"updated":"2021-08-18 08:29:17.000000000","message":"The \"vimConnectionInfo\" data type is \"map(VimConnectionInfo)\".\nIMO, it should be \"fields.DictOfObjectsField\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027localizationLanguage\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"746640ef_1914002c","line":35,"in_reply_to":"a57682f4_a333b2a4","updated":"2021-08-19 05:08:34.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ExtVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extManagedVirtualLinks\u0027: fields.ListOfObjectsField("},{"line_number":34,"context_line":"            \u0027ExtManagedVirtualLinkData\u0027, nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":36,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027localizationLanguage\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"a57682f4_a333b2a4","line":35,"in_reply_to":"fa4d5aab_95de86b9","updated":"2021-08-19 02:56:20.000000000","message":"vimConnectionInfo is an array because Cardinality is \"0..N\" (ex. same as zones). Each member of an array is a map(VimConnectionInfo).","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/ip_over_ethernet_address_info.py":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    fields \u003d {"},{"line_number":45,"context_line":"        \u0027type\u0027: fields.EnumField("},{"line_number":46,"context_line":"            valid_values\u003d[\u0027IPV4\u0027, \u0027IPV6\u0027]),"},{"line_number":47,"context_line":"        \u0027addresses\u0027: fields.ListOfIPAddressesField(nullable\u003dTrue),"},{"line_number":48,"context_line":"        \u0027isDynamic\u0027: fields.BooleanField(nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027addressRange\u0027: fields.ObjectField("}],"source_content_type":"text/x-python","patch_set":1,"id":"509f9971_7a32a5c8","line":46,"updated":"2021-08-19 02:56:20.000000000","message":"should add \u0027nullable\u003dFalse\u0027. I will fix.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":38,"context_line":"class IpOverEthernetAddressInfoV2_IpAddresses("},{"line_number":39,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"2b1b9431_2b9044e4","line":38,"range":{"start_line":38,"start_character":33,"end_line":38,"end_character":34},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":38,"context_line":"class IpOverEthernetAddressInfoV2_IpAddresses("},{"line_number":39,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"7138cbd7_65d28065","line":38,"range":{"start_line":38,"start_character":33,"end_line":38,"end_character":34},"in_reply_to":"2b1b9431_2b9044e4","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":57,"context_line":"class IpOverEthernetAddressInfoV2_IpAddresses_AddressRange("},{"line_number":58,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"461b1eac_309eb419","line":57,"range":{"start_line":57,"start_character":33,"end_line":57,"end_character":46},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":57,"context_line":"class IpOverEthernetAddressInfoV2_IpAddresses_AddressRange("},{"line_number":58,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"662c07db_7ea4c1cc","line":57,"range":{"start_line":57,"start_character":33,"end_line":57,"end_character":46},"in_reply_to":"461b1eac_309eb419","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/lccn_subscription.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            \u0027LifecycleChangeNotificationsFilterV2\u0027, nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027callbackUri\u0027: fields.UriField(nullable\u003dFalse),"},{"line_number":35,"context_line":"        # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":36,"context_line":"        #       original \u0027LccnSubscription\u0027 data type definition."},{"line_number":37,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":38,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("}],"source_content_type":"text/x-python","patch_set":1,"id":"34da1d71_cb9979f4","line":36,"updated":"2021-08-18 08:29:17.000000000","message":"Would you add explains that \"why authentication field is needed?\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \u0027LifecycleChangeNotificationsFilterV2\u0027, nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027callbackUri\u0027: fields.UriField(nullable\u003dFalse),"},{"line_number":35,"context_line":"        # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":36,"context_line":"        #       original \u0027LccnSubscription\u0027 data type definition."},{"line_number":37,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":38,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("}],"source_content_type":"text/x-python","patch_set":1,"id":"2bf0b1c0_7ee7d172","line":36,"in_reply_to":"2069f3a8_6f0fb991","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            \u0027LifecycleChangeNotificationsFilterV2\u0027, nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027callbackUri\u0027: fields.UriField(nullable\u003dFalse),"},{"line_number":35,"context_line":"        # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":36,"context_line":"        #       original \u0027LccnSubscription\u0027 data type definition."},{"line_number":37,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":38,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("}],"source_content_type":"text/x-python","patch_set":1,"id":"2069f3a8_6f0fb991","line":36,"in_reply_to":"34da1d71_cb9979f4","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":40,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("},{"line_number":42,"context_line":"            nullable\u003dTrue),"},{"line_number":43,"context_line":"        \u0027_links\u0027: fields.ObjectField("},{"line_number":44,"context_line":"            \u0027LccnSubscriptionV2_Links\u0027, nullable\u003dFalse),"},{"line_number":45,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"5e7b8c6b_24ba6179","line":42,"updated":"2021-08-25 07:16:46.000000000","message":"Since this attribute\u0027s cardinality is 1, It think \u0027nullable\u003dTrue\u0027 is correct.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":40,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("},{"line_number":42,"context_line":"            nullable\u003dTrue),"},{"line_number":43,"context_line":"        \u0027_links\u0027: fields.ObjectField("},{"line_number":44,"context_line":"            \u0027LccnSubscriptionV2_Links\u0027, nullable\u003dFalse),"},{"line_number":45,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"2c64ff69_b5c0af0c","line":42,"in_reply_to":"5e7b8c6b_24ba6179","updated":"2021-08-25 23:59:45.000000000","message":"I see. \u0027nullable\u003dFalse\u0027 is correct. I will fix.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":49,"context_line":"class LccnSubscriptionV2_Links(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":50,"context_line":"    # Version 1.0: Initial version"},{"line_number":51,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"c971e9a0_616ae0ff","line":49,"range":{"start_line":49,"start_character":24,"end_line":49,"end_character":25},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":49,"context_line":"class LccnSubscriptionV2_Links(base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":50,"context_line":"    # Version 1.0: Initial version"},{"line_number":51,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5aa0ea17_cdcdc1cb","line":49,"range":{"start_line":49,"start_character":24,"end_line":49,"end_character":25},"in_reply_to":"c971e9a0_616ae0ff","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"e5784046e8dffd1785361402f612e91df8bcf602","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":36,"context_line":"        # original \u0027LccnSubscription\u0027 data type definition."},{"line_number":37,"context_line":"        # It is necessary to keep this to be used at sending"},{"line_number":38,"context_line":"        # notifications. Note that it is droped at GET subsctiption."},{"line_number":39,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":40,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("}],"source_content_type":"text/x-python","patch_set":9,"id":"66bd2e9f_d643b53f","line":38,"updated":"2021-09-14 08:57:55.000000000","message":"typo: droped → dropped\ntypo: subsctiption → subscription","commit_id":"b7d65cc7191111f980b5381b9b548360f85b5119"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5ff8df043c10cd0b50aec909f75d068570595977","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":36,"context_line":"        # original \u0027LccnSubscription\u0027 data type definition."},{"line_number":37,"context_line":"        # It is necessary to keep this to be used at sending"},{"line_number":38,"context_line":"        # notifications. Note that it is droped at GET subsctiption."},{"line_number":39,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":40,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("}],"source_content_type":"text/x-python","patch_set":9,"id":"b347469e_ff22c1a9","line":38,"in_reply_to":"66bd2e9f_d643b53f","updated":"2021-09-14 22:19:46.000000000","message":"I will fix.","commit_id":"b7d65cc7191111f980b5381b9b548360f85b5119"},{"author":{"_account_id":31668},"change_message_id":"e839594c3ff9896fb323c95d4d85f102d0b2eee4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # NOTE: \u0027authentication\u0027 attribute is not included in the"},{"line_number":36,"context_line":"        # original \u0027LccnSubscription\u0027 data type definition."},{"line_number":37,"context_line":"        # It is necessary to keep this to be used at sending"},{"line_number":38,"context_line":"        # notifications. Note that it is droped at GET subsctiption."},{"line_number":39,"context_line":"        \u0027authentication\u0027: fields.ObjectField("},{"line_number":40,"context_line":"            \u0027SubscriptionAuthentication\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027verbosity\u0027: v2fields.LcmOpOccNotificationVerbosityTypeField("}],"source_content_type":"text/x-python","patch_set":9,"id":"c6e8ab6d_b119c2f3","line":38,"in_reply_to":"b347469e_ff22c1a9","updated":"2021-09-14 23:53:31.000000000","message":"Done","commit_id":"b7d65cc7191111f980b5381b9b548360f85b5119"}],"tacker/sol_refactored/objects/v2/lifecycle_change_notifications_filter.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            ],"},{"line_number":39,"context_line":"            nullable\u003dTrue,"},{"line_number":40,"context_line":"        ),"},{"line_number":41,"context_line":"        \u0027operationTypes\u0027: fields.Field(fields.List("},{"line_number":42,"context_line":"            v2fields.LcmOperationTypeField(), nullable\u003dTrue)),"},{"line_number":43,"context_line":"        \u0027operationStatus\u0027: fields.Field(fields.List("},{"line_number":44,"context_line":"            v2fields.LcmOperationStateTypeField(), nullable\u003dTrue)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"6e475011_208382fe","line":41,"updated":"2021-08-18 08:29:17.000000000","message":"Do you have any reasons to use `fields.Field(fields.List())` instead of `fields.ListOfObjectsField`?","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            ],"},{"line_number":39,"context_line":"            nullable\u003dTrue,"},{"line_number":40,"context_line":"        ),"},{"line_number":41,"context_line":"        \u0027operationTypes\u0027: fields.Field(fields.List("},{"line_number":42,"context_line":"            v2fields.LcmOperationTypeField(), nullable\u003dTrue)),"},{"line_number":43,"context_line":"        \u0027operationStatus\u0027: fields.Field(fields.List("},{"line_number":44,"context_line":"            v2fields.LcmOperationStateTypeField(), nullable\u003dTrue)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"77354390_a8e456a6","line":41,"in_reply_to":"6e475011_208382fe","updated":"2021-08-19 02:56:20.000000000","message":"LcmOperationType is not object but enum type. There is not convenient type represent list of enum field. There is no way to define this.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            ],"},{"line_number":39,"context_line":"            nullable\u003dTrue,"},{"line_number":40,"context_line":"        ),"},{"line_number":41,"context_line":"        \u0027operationTypes\u0027: fields.Field(fields.List("},{"line_number":42,"context_line":"            v2fields.LcmOperationTypeField(), nullable\u003dTrue)),"},{"line_number":43,"context_line":"        \u0027operationStatus\u0027: fields.Field(fields.List("},{"line_number":44,"context_line":"            v2fields.LcmOperationStateTypeField(), nullable\u003dTrue)),"}],"source_content_type":"text/x-python","patch_set":1,"id":"623d9085_5e8edd26","line":41,"in_reply_to":"77354390_a8e456a6","updated":"2021-08-19 05:08:34.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        \u0027operationTypes\u0027: fields.Field(fields.List("},{"line_number":42,"context_line":"            v2fields.LcmOperationTypeField(), nullable\u003dTrue)),"},{"line_number":43,"context_line":"        \u0027operationStatus\u0027: fields.Field(fields.List("},{"line_number":44,"context_line":"            v2fields.LcmOperationStateTypeField(), nullable\u003dTrue)),"},{"line_number":45,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"4aa33287_a5f382c5","line":44,"updated":"2021-08-18 08:29:17.000000000","message":"Do you have any reasons to use `fields.Field(fields.List())` instead of `fields.ListOfObjectsField`?","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        \u0027operationTypes\u0027: fields.Field(fields.List("},{"line_number":42,"context_line":"            v2fields.LcmOperationTypeField(), nullable\u003dTrue)),"},{"line_number":43,"context_line":"        \u0027operationStatus\u0027: fields.Field(fields.List("},{"line_number":44,"context_line":"            v2fields.LcmOperationStateTypeField(), nullable\u003dTrue)),"},{"line_number":45,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1a64e1a_68862118","line":44,"in_reply_to":"4aa33287_a5f382c5","updated":"2021-08-19 02:56:20.000000000","message":"ditto","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \u0027operationTypes\u0027: fields.Field(fields.List("},{"line_number":42,"context_line":"            v2fields.LcmOperationTypeField(), nullable\u003dTrue)),"},{"line_number":43,"context_line":"        \u0027operationStatus\u0027: fields.Field(fields.List("},{"line_number":44,"context_line":"            v2fields.LcmOperationStateTypeField(), nullable\u003dTrue)),"},{"line_number":45,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"8bffbc4e_659bbb53","line":44,"in_reply_to":"d1a64e1a_68862118","updated":"2021-08-19 05:08:34.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/operate_vnf_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027changeStateTo\u0027: v2fields.VnfOperationalStateTypeField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027instantiationLevelId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027scaleInfo\u0027: fields.ListOfObjectsField(\u0027ScaleInfo\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1e323f1_56f1ef31","line":31,"updated":"2021-08-18 08:29:17.000000000","message":"The OperateVnfRequest hasn\u0027t \u0027instantiationLevelId\u0027 in NFV-SOL 003 v3.3.1 5.5.2.10.\nIsn\u0027t the correct field \"stopType\"?","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027changeStateTo\u0027: v2fields.VnfOperationalStateTypeField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027instantiationLevelId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027scaleInfo\u0027: fields.ListOfObjectsField(\u0027ScaleInfo\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a15be1c_a64fa84b","line":31,"in_reply_to":"133fa1c2_d1be7591","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027changeStateTo\u0027: v2fields.VnfOperationalStateTypeField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027instantiationLevelId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027scaleInfo\u0027: fields.ListOfObjectsField(\u0027ScaleInfo\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"133fa1c2_d1be7591","line":31,"in_reply_to":"c1e323f1_56f1ef31","updated":"2021-08-19 02:56:20.000000000","message":"yes it is wrong.\n\"\u0027stopType\u0027: v2fields.StopTypeField(nullable\u003dTrue),\" is correct.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027changeStateTo\u0027: v2fields.VnfOperationalStateTypeField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027instantiationLevelId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027scaleInfo\u0027: fields.ListOfObjectsField(\u0027ScaleInfo\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"d98b997c_946455a8","line":32,"updated":"2021-08-18 08:29:17.000000000","message":"The OperateVnfRequest hasn\u0027t \u0027scaleInfo\u0027 in NFV-SOL 003 v3.3.1 5.5.2.10.\nIsn\u0027t the correct field \"gracefulStopTimeout\"?","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027changeStateTo\u0027: v2fields.VnfOperationalStateTypeField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027instantiationLevelId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027scaleInfo\u0027: fields.ListOfObjectsField(\u0027ScaleInfo\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"f153a2e4_bad4bf8d","line":32,"in_reply_to":"d98b997c_946455a8","updated":"2021-08-19 02:56:20.000000000","message":"yes it is wrong.\n\"\u0027gracefulStopTimeout\u0027: fields.IntegerField(nullable\u003dTrue),\" is correct.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027changeStateTo\u0027: v2fields.VnfOperationalStateTypeField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027instantiationLevelId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027scaleInfo\u0027: fields.ListOfObjectsField(\u0027ScaleInfo\u0027, nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1c6c1d3_ff9b1a6c","line":32,"in_reply_to":"f153a2e4_bad4bf8d","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \u0027stopType\u0027: v2fields.StopTypeField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027gracefulStopTimeout\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"601dddc6_eb069f96","line":34,"updated":"2021-08-25 07:16:46.000000000","message":"vnfcInstanceId defined in SOL002 v3.3.1 5.5.2.10 should be added.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \u0027stopType\u0027: v2fields.StopTypeField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027gracefulStopTimeout\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"03b557c0_c2b1e4ef","line":34,"in_reply_to":"601dddc6_eb069f96","updated":"2021-08-25 23:59:45.000000000","message":"I see. I will add it with a comment.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"}],"tacker/sol_refactored/objects/v2/pkgm_notification_filter.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":51,"context_line":"class PkgmNotificationFilterV2_VnfProductsFromProviders("},{"line_number":52,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"2dda6d38_7b102a01","line":51,"range":{"start_line":51,"start_character":30,"end_line":51,"end_character":31},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":51,"context_line":"class PkgmNotificationFilterV2_VnfProductsFromProviders("},{"line_number":52,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"a0fafceb_eef55161","line":51,"range":{"start_line":51,"start_character":30,"end_line":51,"end_character":31},"in_reply_to":"2dda6d38_7b102a01","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":66,"context_line":"class PkgmNotificationFilterV2_VnfProductsFromProviders_VnfProducts("},{"line_number":67,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"a9e7b4e6_057b7bcd","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":56},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":66,"context_line":"class PkgmNotificationFilterV2_VnfProductsFromProviders_VnfProducts("},{"line_number":67,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"874ca155_8ff818e2","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":56},"in_reply_to":"a9e7b4e6_057b7bcd","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":82,"context_line":"class PkgmNotificationFilterV2_VnfProductsFromProviders_VnfProducts_Versions("},{"line_number":83,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"90dc6d63_aaabf5a7","line":82,"range":{"start_line":82,"start_character":30,"end_line":82,"end_character":56},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":82,"context_line":"class PkgmNotificationFilterV2_VnfProductsFromProviders_VnfProducts_Versions("},{"line_number":83,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"0753c899_aa147db2","line":82,"range":{"start_line":82,"start_character":30,"end_line":82,"end_character":56},"in_reply_to":"90dc6d63_aaabf5a7","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/pkgm_subscription_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 005"},{"line_number":21,"context_line":"# - v3.3.1 9.5.2.7 (API version: 2.1.0)"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class PkgmSubscriptionRequestV2(base.TackerObject,"},{"line_number":24,"context_line":"                                base.TackerObjectDictCompat):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fcc774a_5490e2ee","line":21,"updated":"2021-08-18 08:29:17.000000000","message":"Maybe, it will \"9.5.2.6\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 005"},{"line_number":21,"context_line":"# - v3.3.1 9.5.2.7 (API version: 2.1.0)"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class PkgmSubscriptionRequestV2(base.TackerObject,"},{"line_number":24,"context_line":"                                base.TackerObjectDictCompat):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba6f81de_13ccff46","line":21,"in_reply_to":"3fcc774a_5490e2ee","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NFV-SOL 005"},{"line_number":21,"context_line":"# - v3.3.1 9.5.2.7 (API version: 2.1.0)"},{"line_number":22,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":23,"context_line":"class PkgmSubscriptionRequestV2(base.TackerObject,"},{"line_number":24,"context_line":"                                base.TackerObjectDictCompat):"}],"source_content_type":"text/x-python","patch_set":1,"id":"79e42cd8_768de601","line":21,"in_reply_to":"ba6f81de_13ccff46","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/revert_to_vnf_snapshot_request.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfSnapshotInfoId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"63074b5f_e4c80084","line":32,"updated":"2021-08-25 07:16:46.000000000","message":"vnfcInstanceId and vnfcSnapshotInfoId defined in SOL002 v3.3.1 5.5.2.24 should be added.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfSnapshotInfoId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f506e5f_2fd976ef","line":32,"in_reply_to":"63074b5f_e4c80084","updated":"2021-08-25 23:59:45.000000000","message":"I see. I will add them with a comment.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"}],"tacker/sol_refactored/objects/v2/scale_vnf_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027type\u0027: fields.EnumField(valid_values\u003d[\u0027SCALE_OUT\u0027, \u0027SCALE_IN\u0027]),"},{"line_number":30,"context_line":"        \u0027aspectId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027numberOfSteps\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7589b3c_bc249687","line":29,"updated":"2021-08-18 08:29:17.000000000","message":"Is `nullable\u003dFalse` missing?","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027type\u0027: fields.EnumField(valid_values\u003d[\u0027SCALE_OUT\u0027, \u0027SCALE_IN\u0027]),"},{"line_number":30,"context_line":"        \u0027aspectId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027numberOfSteps\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"c63731bc_322d3145","line":29,"in_reply_to":"1c587b6a_6c8b94ac","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027type\u0027: fields.EnumField(valid_values\u003d[\u0027SCALE_OUT\u0027, \u0027SCALE_IN\u0027]),"},{"line_number":30,"context_line":"        \u0027aspectId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":31,"context_line":"        \u0027numberOfSteps\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c587b6a_6c8b94ac","line":29,"in_reply_to":"f7589b3c_bc249687","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/terminate_vnf_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027terminationType\u0027: fields.EnumField("},{"line_number":30,"context_line":"            valid_values\u003d[\u0027FORCEFUL\u0027, \u0027GRACEFUL\u0027]),"},{"line_number":31,"context_line":"        \u0027gracefulTerminationTimeout\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a9d779b_5ef4b91b","line":30,"updated":"2021-08-18 08:29:17.000000000","message":"Is `nullable\u003dFalse` missing?","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027terminationType\u0027: fields.EnumField("},{"line_number":30,"context_line":"            valid_values\u003d[\u0027FORCEFUL\u0027, \u0027GRACEFUL\u0027]),"},{"line_number":31,"context_line":"        \u0027gracefulTerminationTimeout\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"c80e56de_74b34816","line":30,"in_reply_to":"0a9d779b_5ef4b91b","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027terminationType\u0027: fields.EnumField("},{"line_number":30,"context_line":"            valid_values\u003d[\u0027FORCEFUL\u0027, \u0027GRACEFUL\u0027]),"},{"line_number":31,"context_line":"        \u0027gracefulTerminationTimeout\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027additionalParams\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"112222cc_6496fc09","line":30,"in_reply_to":"c80e56de_74b34816","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/upload_vnf_package_from_uri_request.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":48,"context_line":"class UploadVnfPackageFromUriRequestV2_ParamsOauth2ClientCredentials("},{"line_number":49,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"b8f49c2a_f84708dd","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":39},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":48,"context_line":"class UploadVnfPackageFromUriRequestV2_ParamsOauth2ClientCredentials("},{"line_number":49,"context_line":"        base.TackerObject, base.TackerObjectDictCompat):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"2e079a7b_0b5d2d7a","line":48,"range":{"start_line":48,"start_character":38,"end_line":48,"end_character":39},"in_reply_to":"b8f49c2a_f84708dd","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/vnf_ext_cp_info.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \u0027cpConfigId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027cpProtocolInfo\u0027: fields.ObjectField("},{"line_number":34,"context_line":"            \u0027CpProtocolInfoV2\u0027, nullable\u003dFalse),"},{"line_number":35,"context_line":"        \u0027extLinkPortId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027associatedVnfcCpId\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"50b01abb_a8d6f44b","line":34,"updated":"2021-08-18 08:29:17.000000000","message":"The `cpProtocolInfo` has \"1..N\" cardinality.\nIMO, it should be \"fields.ListOfObjectsField\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \u0027cpConfigId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027cpProtocolInfo\u0027: fields.ObjectField("},{"line_number":34,"context_line":"            \u0027CpProtocolInfoV2\u0027, nullable\u003dFalse),"},{"line_number":35,"context_line":"        \u0027extLinkPortId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027associatedVnfcCpId\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"78c48352_20346fe4","line":34,"in_reply_to":"50b01abb_a8d6f44b","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027cpConfigId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027cpProtocolInfo\u0027: fields.ObjectField("},{"line_number":34,"context_line":"            \u0027CpProtocolInfoV2\u0027, nullable\u003dFalse),"},{"line_number":35,"context_line":"        \u0027extLinkPortId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027associatedVnfcCpId\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"f3d650e7_7728c0c4","line":34,"in_reply_to":"78c48352_20346fe4","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/vnf_info_modification_request.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfInstanceName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":31,"context_line":"        \u0027vnfInstanceDescription\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"326668b1_197fde0d","line":32,"updated":"2021-08-18 08:29:17.000000000","message":"IMO, should need \"nullable\u003dTrue\" param. (The cardinality is 0..1)","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfInstanceName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":31,"context_line":"        \u0027vnfInstanceDescription\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d5e8b9d_973ae865","line":32,"in_reply_to":"326668b1_197fde0d","updated":"2021-08-19 02:56:20.000000000","message":"ack. I will add comment too.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027vnfInstanceName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":31,"context_line":"        \u0027vnfInstanceDescription\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab095bcd_8fe3edb3","line":32,"in_reply_to":"6d5e8b9d_973ae865","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":40,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"1feab543_f4049c74","line":39,"updated":"2021-08-19 05:08:34.000000000","message":"Cardinality is \"0..N\" in NFV-SOL 003 v3.3.1 5.5.2.12.\nIMO, the field should be \"fields.ListOfObjectsField\".","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e9ac8a0015862e91e2b327359b38fc78768eaf38","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":40,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"a90e78cd_84e0ec90","line":39,"in_reply_to":"1feab543_f4049c74","updated":"2021-08-19 05:47:55.000000000","message":"Ack","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027vimConnectionInfo\u0027: fields.DictOfObjectsField("},{"line_number":40,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"88557064_e6c43422","line":39,"in_reply_to":"a90e78cd_84e0ec90","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"fcd578fd2a240c812342723f13de13bcd24caeb5"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":40,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"8a76512f_4d91730a","line":41,"updated":"2021-08-25 07:16:46.000000000","message":"vnfcInfoModifications defined in SOL002 v3.3.1 5.5.2.12 should be added.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":40,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"ac75e250_3e77e580","line":41,"in_reply_to":"8a76512f_4d91730a","updated":"2021-08-25 23:59:45.000000000","message":"I see. I will add it with a comment.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"}],"tacker/sol_refactored/objects/v2/vnf_info_modifications.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":35,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"93ebdec6_42a40919","line":34,"updated":"2021-08-18 08:29:17.000000000","message":"The \"vimConnectionInfo\" data type is \"map(VimConnectionInfo)\".\nIMO, it should be \"fields.DictOfObjectsField\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":35,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ac334acd_60a408ad","line":34,"in_reply_to":"93ebdec6_42a40919","updated":"2021-08-19 02:56:20.000000000","message":"vimConnectionInfo is an array because Cardinality is \"0..N\" (ex. same as zones). Each member of an array is a map(VimConnectionInfo).","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":32,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":33,"context_line":"        \u0027extensions\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":35,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":37,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"f95a9413_af737206","line":34,"in_reply_to":"ac334acd_60a408ad","updated":"2021-08-19 05:08:34.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"10ed13dc4dc58397eea0ff6e72078db1a13969fa","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vnfdVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"3e4dd2f9_9db9df9a","line":41,"updated":"2021-08-25 07:16:46.000000000","message":"vnfcInfoModifications defined in SOL002 v3.3.1 5.5.2.12a should be added.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9aefa0afbb1499b0edc80fb6731619f993d9ffb8","unresolved":true,"context_lines":[{"line_number":38,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vnfdVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"b1de2cc6_4c89518b","line":41,"in_reply_to":"3e4dd2f9_9db9df9a","updated":"2021-08-25 23:59:45.000000000","message":"I see. I will add it with a comment.\nI will add objects/v2/vnfc_info_modifications.py which defines VnfcInfoModificationsV2 object too.","commit_id":"0642f9e3983b33a0f1b5c3c0fa0234c301c82947"}],"tacker/sol_refactored/objects/v2/vnf_instance.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":35,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":36,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("}],"source_content_type":"text/x-python","patch_set":1,"id":"6dd2e2f2_6f281642","line":37,"updated":"2021-08-18 08:29:17.000000000","message":"The \"vnfSoftwareVersion\" data type is \"Version\".\nIMO, \"fields.VersionField\" is better way.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":35,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":36,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("}],"source_content_type":"text/x-python","patch_set":1,"id":"bc3ee467_5e7bf37f","line":37,"in_reply_to":"6dd2e2f2_6f281642","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":35,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":36,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("}],"source_content_type":"text/x-python","patch_set":1,"id":"8047feb2_88a89d33","line":37,"in_reply_to":"bc3ee467_5e7bf37f","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":36,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":41,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b88b018_071e075a","line":38,"range":{"start_line":38,"start_character":30,"end_line":38,"end_character":41},"updated":"2021-08-18 08:29:17.000000000","message":"The \"vnfdVersion\" data type is \"Version\".\nIMO, \"fields.VersionField\" is better way.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":36,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":41,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"68c6d187_7011fa2b","line":38,"range":{"start_line":38,"start_character":30,"end_line":38,"end_character":41},"in_reply_to":"3b88b018_071e075a","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027vnfProvider\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":36,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":41,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"48d4c36e_4adef62f","line":38,"range":{"start_line":38,"start_character":30,"end_line":38,"end_character":41},"in_reply_to":"68c6d187_7011fa2b","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":41,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027instantiationState\u0027: fields.EnumField("},{"line_number":43,"context_line":"            valid_values\u003d["}],"source_content_type":"text/x-python","patch_set":1,"id":"243b8147_5d75c8ca","line":40,"updated":"2021-08-18 08:29:17.000000000","message":"The \"vimConnectionInfo\" data type is \"map(VimConnectionInfo)\".\nIMO, it should be \"fields.DictOfObjectsField\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"103b47faeb0ff0b9b7203516d27628041d7241ff","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":41,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027instantiationState\u0027: fields.EnumField("},{"line_number":43,"context_line":"            valid_values\u003d["}],"source_content_type":"text/x-python","patch_set":1,"id":"79938531_1f39f12c","line":40,"in_reply_to":"016111fb_45f893cc","updated":"2021-08-19 05:08:34.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027vnfdVersion\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfConfigurableProperties\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":40,"context_line":"        \u0027vimConnectionInfo\u0027: fields.ListOfObjectsField("},{"line_number":41,"context_line":"            \u0027VimConnectionInfo\u0027, nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027instantiationState\u0027: fields.EnumField("},{"line_number":43,"context_line":"            valid_values\u003d["}],"source_content_type":"text/x-python","patch_set":1,"id":"016111fb_45f893cc","line":40,"in_reply_to":"243b8147_5d75c8ca","updated":"2021-08-19 02:56:20.000000000","message":"vimConnectionInfo is an array because Cardinality is \"0..N\" (ex. same as zones). Each member of an array is a map(VimConnectionInfo).","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":57,"context_line":"class VnfInstanceV2_InstantiatedVnfInfo(base.TackerObject,"},{"line_number":58,"context_line":"                                        base.TackerObjectDictCompat):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"bb35974f_4740718d","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":20},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":57,"context_line":"class VnfInstanceV2_InstantiatedVnfInfo(base.TackerObject,"},{"line_number":58,"context_line":"                                        base.TackerObjectDictCompat):"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"13854a99_7d955a99","line":57,"range":{"start_line":57,"start_character":19,"end_line":57,"end_character":20},"in_reply_to":"bb35974f_4740718d","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":91,"context_line":"class VnfInstanceV2_Links(base.TackerObject):"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # Version 1.0: Initial version"},{"line_number":94,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"f82d871b_32a2a837","line":91,"range":{"start_line":91,"start_character":19,"end_line":91,"end_character":20},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":91,"context_line":"class VnfInstanceV2_Links(base.TackerObject):"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # Version 1.0: Initial version"},{"line_number":94,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"b1716a4a_9f0e68e2","line":91,"range":{"start_line":91,"start_character":19,"end_line":91,"end_character":20},"in_reply_to":"f82d871b_32a2a837","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/vnf_lcm_op_occ.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":103,"context_line":"class VnfLcmOpOccV2_ResourceChanges(base.TackerObject,"},{"line_number":104,"context_line":"                                    base.TackerObjectDictCompat):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"92c02574_5083d2ee","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":20},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":103,"context_line":"class VnfLcmOpOccV2_ResourceChanges(base.TackerObject,"},{"line_number":104,"context_line":"                                    base.TackerObjectDictCompat):"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"eb79c58f_744e0593","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":20},"in_reply_to":"92c02574_5083d2ee","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":122,"context_line":"class VnfLcmOpOccV2_Links(base.TackerObject):"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Version 1.0: Initial version"},{"line_number":125,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"d244d52d_85b46d2d","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":20},"updated":"2021-08-26 06:44:32.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":122,"context_line":"class VnfLcmOpOccV2_Links(base.TackerObject):"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    # Version 1.0: Initial version"},{"line_number":125,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"2a8659b7_87ddd212","line":122,"range":{"start_line":122,"start_character":19,"end_line":122,"end_character":20},"in_reply_to":"d244d52d_85b46d2d","updated":"2021-08-26 22:46:48.000000000","message":"ditto","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":31668},"change_message_id":"e5784046e8dffd1785361402f612e91df8bcf602","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        elif obj.operation \u003d\u003d v2fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":52,"context_line":"            cls \u003d objects.ChangeCurrentVnfPkgRequest"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            raise ValueError(_(\"Unexected \u0027operation\u0027 found.\"))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return cls.from_dict(value)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fe3007d8_bec119a4","line":54,"updated":"2021-09-14 08:57:55.000000000","message":"typo: Unexected → Unexpected","commit_id":"b7d65cc7191111f980b5381b9b548360f85b5119"},{"author":{"_account_id":31668},"change_message_id":"e839594c3ff9896fb323c95d4d85f102d0b2eee4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        elif obj.operation \u003d\u003d v2fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":52,"context_line":"            cls \u003d objects.ChangeCurrentVnfPkgRequest"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            raise ValueError(_(\"Unexected \u0027operation\u0027 found.\"))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return cls.from_dict(value)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9d8af167_102f8ee6","line":54,"in_reply_to":"4b2f7505_e9961740","updated":"2021-09-14 23:53:31.000000000","message":"Done","commit_id":"b7d65cc7191111f980b5381b9b548360f85b5119"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"5ff8df043c10cd0b50aec909f75d068570595977","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        elif obj.operation \u003d\u003d v2fields.LcmOperationType.CHANGE_VNFPKG:"},{"line_number":52,"context_line":"            cls \u003d objects.ChangeCurrentVnfPkgRequest"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            raise ValueError(_(\"Unexected \u0027operation\u0027 found.\"))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        return cls.from_dict(value)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"4b2f7505_e9961740","line":54,"in_reply_to":"fe3007d8_bec119a4","updated":"2021-09-14 22:19:46.000000000","message":"I will fix.","commit_id":"b7d65cc7191111f980b5381b9b548360f85b5119"}],"tacker/sol_refactored/objects/v2/vnf_lcm_operation_occurrence_notification.py":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        \u0027subscriptionId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":34,"context_line":"        \u0027timeStamp\u0027: fields.DateTimeField(nullable\u003dFalse),"},{"line_number":35,"context_line":"        \u0027notificationStatus\u0027: fields.EnumField("},{"line_number":36,"context_line":"            valid_values\u003d[\u0027START\u0027, \u0027RESULT\u0027]),"},{"line_number":37,"context_line":"        \u0027operationState\u0027: v2fields.LcmOperationStateTypeField("},{"line_number":38,"context_line":"            nullable\u003dFalse),"},{"line_number":39,"context_line":"        \u0027vnfInstanceId\u0027: fields.StringField(nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"6afb7c20_cc0789ac","line":36,"updated":"2021-08-19 02:56:20.000000000","message":"should add \u0027nullable\u003dFalse\u0027. I will fix.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/vnf_link_port_info.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027cpInstanceId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027cpInstanceType\u0027: fields.EnumField("},{"line_number":35,"context_line":"            valid_values\u003d[\u0027VNFC_CP\u0027, \u0027EXT_CP\u0027]),"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"fdaf9c4f_c2faf819","line":35,"updated":"2021-08-18 08:29:17.000000000","message":"IMO, should need \"nullable\u003dTrue\" param.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027cpInstanceId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027cpInstanceType\u0027: fields.EnumField("},{"line_number":35,"context_line":"            valid_values\u003d[\u0027VNFC_CP\u0027, \u0027EXT_CP\u0027]),"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"289ca3fd_f3ec12cf","line":35,"in_reply_to":"9d50bda3_26f1ae96","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":32,"context_line":"            \u0027ResourceHandle\u0027, nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027cpInstanceId\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027cpInstanceType\u0027: fields.EnumField("},{"line_number":35,"context_line":"            valid_values\u003d[\u0027VNFC_CP\u0027, \u0027EXT_CP\u0027]),"},{"line_number":36,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d50bda3_26f1ae96","line":35,"in_reply_to":"fdaf9c4f_c2faf819","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/vnf_package_artifact_info.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027artifactPath\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":30,"context_line":"        \u0027artifactUri\u0027: fields.UriField(nullable\u003dTrue),"},{"line_number":31,"context_line":"        \u0027checksum\u0027: fields.ChecksumField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027isEncrypted\u0027: fields.BooleanField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027nonManoArtifactSetId\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3870ab28_426551e2","line":30,"updated":"2021-08-18 08:29:17.000000000","message":"Attribute name is camel case is used?\nDefined \"artifactURI\" in in NFV-SOL 005 Table 9.5.3.3-1.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027artifactPath\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":30,"context_line":"        \u0027artifactUri\u0027: fields.UriField(nullable\u003dTrue),"},{"line_number":31,"context_line":"        \u0027checksum\u0027: fields.ChecksumField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027isEncrypted\u0027: fields.BooleanField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027nonManoArtifactSetId\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"c1ded7a0_5c1d659a","line":30,"in_reply_to":"273eb086_6f7b98cf","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    fields \u003d {"},{"line_number":29,"context_line":"        \u0027artifactPath\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":30,"context_line":"        \u0027artifactUri\u0027: fields.UriField(nullable\u003dTrue),"},{"line_number":31,"context_line":"        \u0027checksum\u0027: fields.ChecksumField(nullable\u003dFalse),"},{"line_number":32,"context_line":"        \u0027isEncrypted\u0027: fields.BooleanField(nullable\u003dFalse),"},{"line_number":33,"context_line":"        \u0027nonManoArtifactSetId\u0027: fields.StringField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"273eb086_6f7b98cf","line":30,"in_reply_to":"3870ab28_426551e2","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                \u0027TESTING\u0027,"},{"line_number":38,"context_line":"                \u0027LICENSE\u0027,"},{"line_number":39,"context_line":"            ],"},{"line_number":40,"context_line":"            nullable\u003dFalse,"},{"line_number":41,"context_line":"        ),"},{"line_number":42,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":43,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"0c7eaa5a_66f0f0f7","line":40,"updated":"2021-08-18 08:29:17.000000000","message":"Cardinality is \"0..1\" in NFV-SOL 005 Table 9.5.3.3-1.\nIMO, should need \"nullable\u003dTrue\" param.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                \u0027TESTING\u0027,"},{"line_number":38,"context_line":"                \u0027LICENSE\u0027,"},{"line_number":39,"context_line":"            ],"},{"line_number":40,"context_line":"            nullable\u003dFalse,"},{"line_number":41,"context_line":"        ),"},{"line_number":42,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":43,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d868179_55cd1aa3","line":40,"in_reply_to":"06aaecc4_c69c3a81","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                \u0027TESTING\u0027,"},{"line_number":38,"context_line":"                \u0027LICENSE\u0027,"},{"line_number":39,"context_line":"            ],"},{"line_number":40,"context_line":"            nullable\u003dFalse,"},{"line_number":41,"context_line":"        ),"},{"line_number":42,"context_line":"        \u0027metadata\u0027: fields.KeyValuePairsField(nullable\u003dTrue),"},{"line_number":43,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"06aaecc4_c69c3a81","line":40,"in_reply_to":"0c7eaa5a_66f0f0f7","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/vnf_package_change_notification.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027changeType\u0027: v2fields.PackageChangeTypeField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027operationalState\u0027: v2fields.PackageOperationalStateTypeField("},{"line_number":39,"context_line":"            nullable\u003dFalse),"},{"line_number":40,"context_line":"        \u0027links\u0027: fields.ObjectField(\u0027PkgmLinksV2\u0027, nullable\u003dFalse),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4452e76_6d4ae060","line":39,"updated":"2021-08-18 08:29:17.000000000","message":"Cardinality is \"0..1\" in NFV-SOL 005 Table 9.5.2.9-1.\nIMO, should need \"nullable\u003dTrue\" param.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027changeType\u0027: v2fields.PackageChangeTypeField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027operationalState\u0027: v2fields.PackageOperationalStateTypeField("},{"line_number":39,"context_line":"            nullable\u003dFalse),"},{"line_number":40,"context_line":"        \u0027links\u0027: fields.ObjectField(\u0027PkgmLinksV2\u0027, nullable\u003dFalse),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"0c9dd8fa_a52dd8ac","line":39,"in_reply_to":"a5739865_50da6f44","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        \u0027vnfdId\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027changeType\u0027: v2fields.PackageChangeTypeField(nullable\u003dFalse),"},{"line_number":38,"context_line":"        \u0027operationalState\u0027: v2fields.PackageOperationalStateTypeField("},{"line_number":39,"context_line":"            nullable\u003dFalse),"},{"line_number":40,"context_line":"        \u0027links\u0027: fields.ObjectField(\u0027PkgmLinksV2\u0027, nullable\u003dFalse),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5739865_50da6f44","line":39,"in_reply_to":"e4452e76_6d4ae060","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"}],"tacker/sol_refactored/objects/v2/vnf_pkg_info.py":[{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vnfdVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027compatibleSpecificationVersion\u0027: fields.ListOfVersionsField("},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027checksum\u0027: fields.ChecksumField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027packageSecurityOption\u0027: fields.EnumField("}],"source_content_type":"text/x-python","patch_set":1,"id":"c2fd2ea5_58a3a7b2","line":36,"updated":"2021-08-18 08:29:17.000000000","message":"Missing \"s\" at the end.\nIMO, the field name should be `compatibleSpecificationVersions`.","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vnfdVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027compatibleSpecificationVersion\u0027: fields.ListOfVersionsField("},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027checksum\u0027: fields.ChecksumField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027packageSecurityOption\u0027: fields.EnumField("}],"source_content_type":"text/x-python","patch_set":1,"id":"1701ce9c_9b12da38","line":36,"in_reply_to":"669bd617_efb58e27","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        \u0027vnfProductName\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":34,"context_line":"        \u0027vnfSoftwareVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":35,"context_line":"        \u0027vnfdVersion\u0027: fields.VersionField(nullable\u003dTrue),"},{"line_number":36,"context_line":"        \u0027compatibleSpecificationVersion\u0027: fields.ListOfVersionsField("},{"line_number":37,"context_line":"            nullable\u003dTrue),"},{"line_number":38,"context_line":"        \u0027checksum\u0027: fields.ChecksumField(nullable\u003dTrue),"},{"line_number":39,"context_line":"        \u0027packageSecurityOption\u0027: fields.EnumField("}],"source_content_type":"text/x-python","patch_set":1,"id":"669bd617_efb58e27","line":36,"in_reply_to":"c2fd2ea5_58a3a7b2","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"884410de8e4cfebb8494ddbf75dd9c7ef1adcd37","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \u0027signingCertificate\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027softwareImages\u0027: fields.ListOfObjectsField("},{"line_number":48,"context_line":"            \u0027VnfPackageSoftwareImageInfoV2\u0027, nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027softwareArtifacts\u0027: fields.ListOfObjectsField("},{"line_number":50,"context_line":"            \u0027VnfPackageArtifactInfoV2\u0027, nullable\u003dTrue),"},{"line_number":51,"context_line":"        \u0027onboardingState\u0027: v2fields.PackageOnboardingStateTypeField("},{"line_number":52,"context_line":"            nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"0f9e2a09_00884fbf","line":49,"updated":"2021-08-18 08:29:17.000000000","message":"IMO, the field name should be \"additionalArtifacts\".","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f0acba14c28ddfcf0bfd0b17cbcd3c38715ebe58","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \u0027signingCertificate\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027softwareImages\u0027: fields.ListOfObjectsField("},{"line_number":48,"context_line":"            \u0027VnfPackageSoftwareImageInfoV2\u0027, nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027softwareArtifacts\u0027: fields.ListOfObjectsField("},{"line_number":50,"context_line":"            \u0027VnfPackageArtifactInfoV2\u0027, nullable\u003dTrue),"},{"line_number":51,"context_line":"        \u0027onboardingState\u0027: v2fields.PackageOnboardingStateTypeField("},{"line_number":52,"context_line":"            nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"2b1cec68_ed62fe3e","line":49,"in_reply_to":"0f9e2a09_00884fbf","updated":"2021-08-19 02:56:20.000000000","message":"Ack","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":33458,"name":"Ryosuke.Yamabuki","email":"yamabukir@intellilink.co.jp","username":"yamabukir"},"change_message_id":"c8a45470ac9cfde3044ae4cffd7ccbca673bf0af","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027signingCertificate\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":47,"context_line":"        \u0027softwareImages\u0027: fields.ListOfObjectsField("},{"line_number":48,"context_line":"            \u0027VnfPackageSoftwareImageInfoV2\u0027, nullable\u003dTrue),"},{"line_number":49,"context_line":"        \u0027softwareArtifacts\u0027: fields.ListOfObjectsField("},{"line_number":50,"context_line":"            \u0027VnfPackageArtifactInfoV2\u0027, nullable\u003dTrue),"},{"line_number":51,"context_line":"        \u0027onboardingState\u0027: v2fields.PackageOnboardingStateTypeField("},{"line_number":52,"context_line":"            nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3218abd1_755f7dca","line":49,"in_reply_to":"2b1cec68_ed62fe3e","updated":"2021-08-27 08:58:31.000000000","message":"Done","commit_id":"ad28b17b25726fe3649b6356c184e4454e6d1c61"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":65,"context_line":"class VnfPkgInfoV2_Links(base.TackerObject):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    # Version 1.0: Initial version"},{"line_number":68,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"58649be6_28565258","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":19},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":65,"context_line":"class VnfPkgInfoV2_Links(base.TackerObject):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    # Version 1.0: Initial version"},{"line_number":68,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"7dbe5d67_bc6d465b","line":65,"range":{"start_line":65,"start_character":18,"end_line":65,"end_character":19},"in_reply_to":"58649be6_28565258","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/vnf_snapshot.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":46,"context_line":"class VnfSnapshotV2_Links(base.TackerObject):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Version 1.0: Initial version"},{"line_number":49,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"df1c0b85_a2777b90","line":46,"range":{"start_line":46,"start_character":19,"end_line":46,"end_character":20},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":46,"context_line":"class VnfSnapshotV2_Links(base.TackerObject):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Version 1.0: Initial version"},{"line_number":49,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3bc7c85c_5c69f278","line":46,"range":{"start_line":46,"start_character":19,"end_line":46,"end_character":20},"in_reply_to":"df1c0b85_a2777b90","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/vnf_snapshot_info.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":39,"context_line":"class VnfSnapshotInfoV2_Links(base.TackerObject):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # Version 1.0: Initial version"},{"line_number":42,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"54dc2448_ca9cf896","line":39,"range":{"start_line":39,"start_character":23,"end_line":39,"end_character":24},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":39,"context_line":"class VnfSnapshotInfoV2_Links(base.TackerObject):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # Version 1.0: Initial version"},{"line_number":42,"context_line":"    VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"4473cab2_4f4acfc7","line":39,"range":{"start_line":39,"start_character":23,"end_line":39,"end_character":24},"in_reply_to":"54dc2448_ca9cf896","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/vnfc_resource_info.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":45,"context_line":"class VnfcResourceInfoV2_VnfcCpInfo(base.TackerObject,"},{"line_number":46,"context_line":"                                    base.TackerObjectDictCompat):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"26343d68_bb7a63c3","line":45,"range":{"start_line":45,"start_character":24,"end_line":45,"end_character":25},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"@base.TackerObjectRegistry.register"},{"line_number":45,"context_line":"class VnfcResourceInfoV2_VnfcCpInfo(base.TackerObject,"},{"line_number":46,"context_line":"                                    base.TackerObjectDictCompat):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"60fa8f0b_247b0939","line":45,"range":{"start_line":45,"start_character":24,"end_line":45,"end_character":25},"in_reply_to":"26343d68_bb7a63c3","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}],"tacker/sol_refactored/objects/v2/vnfc_snapshot_info.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"996c0a7466091f1546a315a0ce2bc146a894fac9","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class VnfcSnapshotInfoV2_StorageSnapshotResources(base.TackerObject,"},{"line_number":43,"context_line":"                                                  base.TackerObjectDictCompat):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"1c78c640_8fc913ee","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":25},"updated":"2021-08-26 06:44:32.000000000","message":"I think class name should be `upper camel case` like other classes, can\u0027t you delete the underscore?","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"37b0eaac6d7b2cf1c352da82423fa2b2a8cf95c7","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class VnfcSnapshotInfoV2_StorageSnapshotResources(base.TackerObject,"},{"line_number":43,"context_line":"                                                  base.TackerObjectDictCompat):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # Version 1.0: Initial version"}],"source_content_type":"text/x-python","patch_set":5,"id":"b868ee03_d891c737","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":25},"in_reply_to":"1c78c640_8fc913ee","updated":"2021-08-26 22:46:48.000000000","message":"see the comment of ip_over_ethernet_address_data.py","commit_id":"bfb189219c1199a6cbc2438c839684e4535d561d"}]}