)]}'
{"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6bd09f827a4dab4032fa48809c0ecf3ff31494c8","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"                region_name\u003dvim_connection_info.access_info.get(\u0027region_name\u0027)"},{"line_number":1321,"context_line":"            )"},{"line_number":1322,"context_line":"        else:"},{"line_number":1323,"context_line":"            if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":1324,"context_line":"                # NOTE(ueha): The logic of Scale for OpenStack VIM is widely"},{"line_number":1325,"context_line":"                # hard coded with `vnf_info`. This dependency is to be"},{"line_number":1326,"context_line":"                # refactored in future."},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"                if scale_vnf_request.type \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":1329,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027in\u0027"},{"line_number":1330,"context_line":"                elif scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"},{"line_number":1331,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027out\u0027"},{"line_number":1332,"context_line":"                else:"},{"line_number":1333,"context_line":"                    msg \u003d \u0027Unknown scale type %s\u0027 % scale_vnf_request.type"},{"line_number":1334,"context_line":"                    raise exceptions.VnfScaleFailed(id\u003dvnf_instance.id,"},{"line_number":1335,"context_line":"                                                    error\u003dmsg)"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"            for _ in range(scale_vnf_request.number_of_steps):"},{"line_number":1338,"context_line":"                last_event_id \u003d self._vnf_manager.invoke("}],"source_content_type":"text/x-python","patch_set":8,"id":"29ba5509_823c84b0","line":1335,"range":{"start_line":1323,"start_character":0,"end_line":1335,"end_character":62},"updated":"2021-09-17 12:16:12.000000000","message":"If this part is only setting policy[\u0027action\u0027] after fix, I think you can delete this code because policy[\u0027action\u0027] is already set at L1243-1246.\n\nhttps://review.opendev.org/c/openstack/tacker/+/805329/8/tacker/vnflcm/vnflcm_driver.py#1243","commit_id":"19c8fa1dd3a95a9728baef39dfcee16689fda703"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ed889ae7df447f4f162844d8190a3cc18ef89432","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"                region_name\u003dvim_connection_info.access_info.get(\u0027region_name\u0027)"},{"line_number":1321,"context_line":"            )"},{"line_number":1322,"context_line":"        else:"},{"line_number":1323,"context_line":"            if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":1324,"context_line":"                # NOTE(ueha): The logic of Scale for OpenStack VIM is widely"},{"line_number":1325,"context_line":"                # hard coded with `vnf_info`. This dependency is to be"},{"line_number":1326,"context_line":"                # refactored in future."},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"                if scale_vnf_request.type \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":1329,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027in\u0027"},{"line_number":1330,"context_line":"                elif scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"},{"line_number":1331,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027out\u0027"},{"line_number":1332,"context_line":"                else:"},{"line_number":1333,"context_line":"                    msg \u003d \u0027Unknown scale type %s\u0027 % scale_vnf_request.type"},{"line_number":1334,"context_line":"                    raise exceptions.VnfScaleFailed(id\u003dvnf_instance.id,"},{"line_number":1335,"context_line":"                                                    error\u003dmsg)"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"            for _ in range(scale_vnf_request.number_of_steps):"},{"line_number":1338,"context_line":"                last_event_id \u003d self._vnf_manager.invoke("}],"source_content_type":"text/x-python","patch_set":8,"id":"c5459114_b11bcc6b","line":1335,"range":{"start_line":1323,"start_character":0,"end_line":1335,"end_character":62},"in_reply_to":"29ba5509_823c84b0","updated":"2021-09-21 02:27:51.000000000","message":"Thank you for your comments.\nI fixed it in patch set 9.","commit_id":"19c8fa1dd3a95a9728baef39dfcee16689fda703"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"fbd408d67e4e2480f3f6ff54ed627c441bdc68cb","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"                region_name\u003dvim_connection_info.access_info.get(\u0027region_name\u0027)"},{"line_number":1321,"context_line":"            )"},{"line_number":1322,"context_line":"        else:"},{"line_number":1323,"context_line":"            if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":1324,"context_line":"                # NOTE(ueha): The logic of Scale for OpenStack VIM is widely"},{"line_number":1325,"context_line":"                # hard coded with `vnf_info`. This dependency is to be"},{"line_number":1326,"context_line":"                # refactored in future."},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"                if scale_vnf_request.type \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":1329,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027in\u0027"},{"line_number":1330,"context_line":"                elif scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"},{"line_number":1331,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027out\u0027"},{"line_number":1332,"context_line":"                else:"},{"line_number":1333,"context_line":"                    msg \u003d \u0027Unknown scale type %s\u0027 % scale_vnf_request.type"},{"line_number":1334,"context_line":"                    raise exceptions.VnfScaleFailed(id\u003dvnf_instance.id,"},{"line_number":1335,"context_line":"                                                    error\u003dmsg)"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"            for _ in range(scale_vnf_request.number_of_steps):"},{"line_number":1338,"context_line":"                last_event_id \u003d self._vnf_manager.invoke("}],"source_content_type":"text/x-python","patch_set":8,"id":"1d6e05f9_59a51cc7","line":1335,"range":{"start_line":1323,"start_character":0,"end_line":1335,"end_character":62},"in_reply_to":"93f2bd37_7adb7037","updated":"2021-09-27 02:22:41.000000000","message":"I\u0027ve confirmed.","commit_id":"19c8fa1dd3a95a9728baef39dfcee16689fda703"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"6e24d87126522194ebe950e96191308680c13aef","unresolved":true,"context_lines":[{"line_number":1320,"context_line":"                region_name\u003dvim_connection_info.access_info.get(\u0027region_name\u0027)"},{"line_number":1321,"context_line":"            )"},{"line_number":1322,"context_line":"        else:"},{"line_number":1323,"context_line":"            if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":1324,"context_line":"                # NOTE(ueha): The logic of Scale for OpenStack VIM is widely"},{"line_number":1325,"context_line":"                # hard coded with `vnf_info`. This dependency is to be"},{"line_number":1326,"context_line":"                # refactored in future."},{"line_number":1327,"context_line":""},{"line_number":1328,"context_line":"                if scale_vnf_request.type \u003d\u003d \u0027SCALE_IN\u0027:"},{"line_number":1329,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027in\u0027"},{"line_number":1330,"context_line":"                elif scale_vnf_request.type \u003d\u003d \u0027SCALE_OUT\u0027:"},{"line_number":1331,"context_line":"                    policy[\u0027action\u0027] \u003d \u0027out\u0027"},{"line_number":1332,"context_line":"                else:"},{"line_number":1333,"context_line":"                    msg \u003d \u0027Unknown scale type %s\u0027 % scale_vnf_request.type"},{"line_number":1334,"context_line":"                    raise exceptions.VnfScaleFailed(id\u003dvnf_instance.id,"},{"line_number":1335,"context_line":"                                                    error\u003dmsg)"},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"            for _ in range(scale_vnf_request.number_of_steps):"},{"line_number":1338,"context_line":"                last_event_id \u003d self._vnf_manager.invoke("}],"source_content_type":"text/x-python","patch_set":8,"id":"93f2bd37_7adb7037","line":1335,"range":{"start_line":1323,"start_character":0,"end_line":1335,"end_character":62},"in_reply_to":"c5459114_b11bcc6b","updated":"2021-09-21 04:41:27.000000000","message":"Thanks for your update. I\u0027ve confirmed fixes, but I have one suggestion.\nWhy don\u0027t you add unit test to validate the newly added Exception routes?","commit_id":"19c8fa1dd3a95a9728baef39dfcee16689fda703"}]}