)]}'
{"samples/mgmt_driver/kubernetes_mgmt.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                stdout \u003d result.get_stdout()"},{"line_number":102,"context_line":"                LOG.debug(stdout)"},{"line_number":103,"context_line":"                LOG.debug(err)"},{"line_number":104,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027 or type \u003d\u003d \u0027install\u0027 or type \u003d\u003d \u0027scp\u0027:"},{"line_number":105,"context_line":"            if result.get_return_code() !\u003d 0:"},{"line_number":106,"context_line":"                err \u003d result.get_stderr()"},{"line_number":107,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":19,"id":"efe78f23_a0134c0f","line":104,"updated":"2021-09-13 11:59:19.000000000","message":"Why don\u0027t you use `elif type in (\u0027certificate_key\u0027, \u0027install\u0027, \u0027scp\u0027)`? Does this intend to be same as other expressions?","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                stdout \u003d result.get_stdout()"},{"line_number":102,"context_line":"                LOG.debug(stdout)"},{"line_number":103,"context_line":"                LOG.debug(err)"},{"line_number":104,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027 or type \u003d\u003d \u0027install\u0027 or type \u003d\u003d \u0027scp\u0027:"},{"line_number":105,"context_line":"            if result.get_return_code() !\u003d 0:"},{"line_number":106,"context_line":"                err \u003d result.get_stderr()"},{"line_number":107,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":19,"id":"08292d82_67138b6a","line":104,"in_reply_to":"4b16e375_16e44af6","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":101,"context_line":"                stdout \u003d result.get_stdout()"},{"line_number":102,"context_line":"                LOG.debug(stdout)"},{"line_number":103,"context_line":"                LOG.debug(err)"},{"line_number":104,"context_line":"        elif type \u003d\u003d \u0027certificate_key\u0027 or type \u003d\u003d \u0027install\u0027 or type \u003d\u003d \u0027scp\u0027:"},{"line_number":105,"context_line":"            if result.get_return_code() !\u003d 0:"},{"line_number":106,"context_line":"                err \u003d result.get_stderr()"},{"line_number":107,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":19,"id":"4b16e375_16e44af6","line":104,"in_reply_to":"efe78f23_a0134c0f","updated":"2021-09-13 14:17:03.000000000","message":"Thanks for your suggestion, I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":111,"context_line":"                err \u003d result.get_stderr()[0].replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":112,"context_line":"                if err \u003d\u003d \u0027Error: no repositories to show\u0027:"},{"line_number":113,"context_line":"                    return []"},{"line_number":114,"context_line":"                else:"},{"line_number":115,"context_line":"                    raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":116,"context_line":"        return result.get_stdout()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _create_vim(self, context, vnf_instance, server, bearer_token,"}],"source_content_type":"text/x-python","patch_set":19,"id":"7e36b9c1_8887430e","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":79},"updated":"2021-09-13 11:59:19.000000000","message":"`else` is unnecessary after `return`.\n\n```\nif err \u003d\u003d \u0027Error: no repositories to show\u0027:\n    return []\nraise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)\n```","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":111,"context_line":"                err \u003d result.get_stderr()[0].replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":112,"context_line":"                if err \u003d\u003d \u0027Error: no repositories to show\u0027:"},{"line_number":113,"context_line":"                    return []"},{"line_number":114,"context_line":"                else:"},{"line_number":115,"context_line":"                    raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":116,"context_line":"        return result.get_stdout()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _create_vim(self, context, vnf_instance, server, bearer_token,"}],"source_content_type":"text/x-python","patch_set":19,"id":"ab190358_b2aaa682","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":79},"in_reply_to":"7e36b9c1_8887430e","updated":"2021-09-13 14:17:03.000000000","message":"I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":111,"context_line":"                err \u003d result.get_stderr()[0].replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":112,"context_line":"                if err \u003d\u003d \u0027Error: no repositories to show\u0027:"},{"line_number":113,"context_line":"                    return []"},{"line_number":114,"context_line":"                else:"},{"line_number":115,"context_line":"                    raise exceptions.MgmtDriverRemoteCommandError(err_info\u003derr)"},{"line_number":116,"context_line":"        return result.get_stdout()"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _create_vim(self, context, vnf_instance, server, bearer_token,"}],"source_content_type":"text/x-python","patch_set":19,"id":"8b0fe71c_bdb8a35e","line":115,"range":{"start_line":114,"start_character":0,"end_line":115,"end_character":79},"in_reply_to":"ab190358_b2aaa682","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                            register_ip, server)"},{"line_number":146,"context_line":"            vim_info[\u0027vim\u0027][\u0027auth_url\u0027] \u003d server"},{"line_number":147,"context_line":"            del vim_info[\u0027vim\u0027][\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027]"},{"line_number":148,"context_line":"        extra \u003d dict()"},{"line_number":149,"context_line":"        if masternode_ip_list:"},{"line_number":150,"context_line":"            username \u003d master_vm_dict_list[0].get(\u0027ssh\u0027).get(\u0027username\u0027)"},{"line_number":151,"context_line":"            password \u003d master_vm_dict_list[0].get(\u0027ssh\u0027).get(\u0027password\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"442b5729_38fdfd3d","line":148,"updated":"2021-09-13 11:59:19.000000000","message":"Should use brackets to initialize dictionary.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                            register_ip, server)"},{"line_number":146,"context_line":"            vim_info[\u0027vim\u0027][\u0027auth_url\u0027] \u003d server"},{"line_number":147,"context_line":"            del vim_info[\u0027vim\u0027][\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027]"},{"line_number":148,"context_line":"        extra \u003d dict()"},{"line_number":149,"context_line":"        if masternode_ip_list:"},{"line_number":150,"context_line":"            username \u003d master_vm_dict_list[0].get(\u0027ssh\u0027).get(\u0027username\u0027)"},{"line_number":151,"context_line":"            password \u003d master_vm_dict_list[0].get(\u0027ssh\u0027).get(\u0027password\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"01943562_510e1b68","line":148,"in_reply_to":"22add662_b269a956","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                            register_ip, server)"},{"line_number":146,"context_line":"            vim_info[\u0027vim\u0027][\u0027auth_url\u0027] \u003d server"},{"line_number":147,"context_line":"            del vim_info[\u0027vim\u0027][\u0027auth_cred\u0027][\u0027ssl_ca_cert\u0027]"},{"line_number":148,"context_line":"        extra \u003d dict()"},{"line_number":149,"context_line":"        if masternode_ip_list:"},{"line_number":150,"context_line":"            username \u003d master_vm_dict_list[0].get(\u0027ssh\u0027).get(\u0027username\u0027)"},{"line_number":151,"context_line":"            password \u003d master_vm_dict_list[0].get(\u0027ssh\u0027).get(\u0027password\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"22add662_b269a956","line":148,"in_reply_to":"442b5729_38fdfd3d","updated":"2021-09-13 14:17:03.000000000","message":"I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"        return target_physical_resource_ids"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"    def _prepare_for_restoring_helm(self, commander, master_ip):"},{"line_number":1642,"context_line":"        helm_info \u003d dict()"},{"line_number":1643,"context_line":"        # get helm repo list"},{"line_number":1644,"context_line":"        ssh_command \u003d \"helm repo list -o json\""},{"line_number":1645,"context_line":"        result \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":19,"id":"4bdba3af_d1c23276","line":1642,"updated":"2021-09-13 11:59:19.000000000","message":"ditto","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"        return target_physical_resource_ids"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"    def _prepare_for_restoring_helm(self, commander, master_ip):"},{"line_number":1642,"context_line":"        helm_info \u003d dict()"},{"line_number":1643,"context_line":"        # get helm repo list"},{"line_number":1644,"context_line":"        ssh_command \u003d \"helm repo list -o json\""},{"line_number":1645,"context_line":"        result \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":19,"id":"8955d3a6_377cd8a7","line":1642,"in_reply_to":"3a00c485_449943bf","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":1639,"context_line":"        return target_physical_resource_ids"},{"line_number":1640,"context_line":""},{"line_number":1641,"context_line":"    def _prepare_for_restoring_helm(self, commander, master_ip):"},{"line_number":1642,"context_line":"        helm_info \u003d dict()"},{"line_number":1643,"context_line":"        # get helm repo list"},{"line_number":1644,"context_line":"        ssh_command \u003d \"helm repo list -o json\""},{"line_number":1645,"context_line":"        result \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":19,"id":"3a00c485_449943bf","line":1642,"in_reply_to":"4bdba3af_d1c23276","updated":"2021-09-13 14:17:03.000000000","message":"I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":1927,"context_line":"        # prepare for restoring helm repository"},{"line_number":1928,"context_line":"        helm_inst_script_path \u003d k8s_cluster_installation_param.get("},{"line_number":1929,"context_line":"            \u0027helm_installation_script_path\u0027, None)"},{"line_number":1930,"context_line":"        helm_info \u003d dict()"},{"line_number":1931,"context_line":"        if helm_inst_script_path:"},{"line_number":1932,"context_line":"            helm_info \u003d self._prepare_for_restoring_helm(commander, master_ip)"},{"line_number":1933,"context_line":"            helm_info[\u0027script_path\u0027] \u003d helm_inst_script_path"}],"source_content_type":"text/x-python","patch_set":19,"id":"a21d952a_f734a1d0","line":1930,"updated":"2021-09-13 11:59:19.000000000","message":"ditto","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":1927,"context_line":"        # prepare for restoring helm repository"},{"line_number":1928,"context_line":"        helm_inst_script_path \u003d k8s_cluster_installation_param.get("},{"line_number":1929,"context_line":"            \u0027helm_installation_script_path\u0027, None)"},{"line_number":1930,"context_line":"        helm_info \u003d dict()"},{"line_number":1931,"context_line":"        if helm_inst_script_path:"},{"line_number":1932,"context_line":"            helm_info \u003d self._prepare_for_restoring_helm(commander, master_ip)"},{"line_number":1933,"context_line":"            helm_info[\u0027script_path\u0027] \u003d helm_inst_script_path"}],"source_content_type":"text/x-python","patch_set":19,"id":"03f3f485_6ceff660","line":1930,"in_reply_to":"365a437c_cc1f11e1","updated":"2021-09-16 01:24:06.000000000","message":"Thanks.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":1927,"context_line":"        # prepare for restoring helm repository"},{"line_number":1928,"context_line":"        helm_inst_script_path \u003d k8s_cluster_installation_param.get("},{"line_number":1929,"context_line":"            \u0027helm_installation_script_path\u0027, None)"},{"line_number":1930,"context_line":"        helm_info \u003d dict()"},{"line_number":1931,"context_line":"        if helm_inst_script_path:"},{"line_number":1932,"context_line":"            helm_info \u003d self._prepare_for_restoring_helm(commander, master_ip)"},{"line_number":1933,"context_line":"            helm_info[\u0027script_path\u0027] \u003d helm_inst_script_path"}],"source_content_type":"text/x-python","patch_set":19,"id":"365a437c_cc1f11e1","line":1930,"in_reply_to":"a21d952a_f734a1d0","updated":"2021-09-13 14:17:03.000000000","message":"I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"}],"tacker/tests/functional/sol_kubernetes/vnflcm/test_kubernetes_helm.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bd35c949424fe571fd5db07ac7bbc07baf4d96d0","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \u0027/vnfpkgm/v1/vnf_packages\u0027, \"POST\", body\u003dbody)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # upload vnf package"},{"line_number":49,"context_line":"    csar_package_path \u003d \"../../../etc/samples/etsi/nfv/%s\" % csar_package_name"},{"line_number":50,"context_line":"    file_path \u003d os.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":51,"context_line":"                                             csar_package_path))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"8bf36f5c_34225c16","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":61},"updated":"2021-09-13 17:37:07.000000000","message":"Why don\u0027t you use `format()`? We\u0027d better not to use such a old style for newly added codes.","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"02a6a0c4f782316095a342a6a2d1b9cfe954b703","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        \u0027/vnfpkgm/v1/vnf_packages\u0027, \"POST\", body\u003dbody)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    # upload vnf package"},{"line_number":49,"context_line":"    csar_package_path \u003d \"../../../etc/samples/etsi/nfv/%s\" % csar_package_name"},{"line_number":50,"context_line":"    file_path \u003d os.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":51,"context_line":"                                             csar_package_path))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1dcceef9_ea0b320c","line":49,"range":{"start_line":49,"start_character":55,"end_line":49,"end_character":61},"in_reply_to":"8bf36f5c_34225c16","updated":"2021-09-14 12:24:22.000000000","message":"Thanks for your suggestion, I\u0027ve fixed and applied to this entire file.","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"}],"tacker/tests/unit/vnfm/infra_drivers/kubernetes/test_kubernetes_driver_helm.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bd35c949424fe571fd5db07ac7bbc07baf4d96d0","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        fake_result \u003d FakeCmdResult()\r"},{"line_number":51,"context_line":"        stderr \u003d \u0027\u0027\r"},{"line_number":52,"context_line":"        stdout \u003d \u0027\u0027\r"},{"line_number":53,"context_line":"        return_code \u003d (0) if is_success else (255)\r"},{"line_number":54,"context_line":"        stderr, stdout \u003d (\u0027\u0027, \u0027\u0027) if is_success else (\u0027err\u0027, \u0027\u0027)\r"},{"line_number":55,"context_line":"        if self.errmsg:\r"},{"line_number":56,"context_line":"            stderr \u003d [self.errmsg]\r"}],"source_content_type":"text/x-python","patch_set":20,"id":"78e6fc33_0fdb6feb","line":53,"range":{"start_line":53,"start_character":46,"end_line":53,"end_character":49},"updated":"2021-09-13 17:37:07.000000000","message":"If you intend to set this value as an error code, `1` is the most used value although it\u0027s just a fake. Is there any reason using 255?","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"02a6a0c4f782316095a342a6a2d1b9cfe954b703","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        fake_result \u003d FakeCmdResult()\r"},{"line_number":51,"context_line":"        stderr \u003d \u0027\u0027\r"},{"line_number":52,"context_line":"        stdout \u003d \u0027\u0027\r"},{"line_number":53,"context_line":"        return_code \u003d (0) if is_success else (255)\r"},{"line_number":54,"context_line":"        stderr, stdout \u003d (\u0027\u0027, \u0027\u0027) if is_success else (\u0027err\u0027, \u0027\u0027)\r"},{"line_number":55,"context_line":"        if self.errmsg:\r"},{"line_number":56,"context_line":"            stderr \u003d [self.errmsg]\r"}],"source_content_type":"text/x-python","patch_set":20,"id":"49978738_258cd233","line":53,"range":{"start_line":53,"start_character":46,"end_line":53,"end_character":49},"in_reply_to":"78e6fc33_0fdb6feb","updated":"2021-09-14 12:24:22.000000000","message":"The code I referred to was set to 255, and there is no particular reason.\nTherefore, I set it to 1 as you suggested.","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"}],"tacker/vnfm/infra_drivers/kubernetes/helm/helm_client.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations\r"},{"line_number":14,"context_line":"#    under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import eventlet\r"},{"line_number":17,"context_line":"import os\r"},{"line_number":18,"context_line":"import time\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"from oslo_log import log as logging\r"},{"line_number":21,"context_line":"import paramiko\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"95b69320_d0c1d9bc","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":11},"updated":"2021-09-13 11:59:19.000000000","message":"`os` and `time` are standard libraries of Python, thus import statement should be sorted as below:\n\n```\nimport os\nimport time\n\nimport eventlet\nfrom oslo_log ....\n```","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations\r"},{"line_number":14,"context_line":"#    under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import eventlet\r"},{"line_number":17,"context_line":"import os\r"},{"line_number":18,"context_line":"import time\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"from oslo_log import log as logging\r"},{"line_number":21,"context_line":"import paramiko\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"d1c91f9d_d0a6007e","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":11},"in_reply_to":"40649eff_911e8416","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations\r"},{"line_number":14,"context_line":"#    under the License.\r"},{"line_number":15,"context_line":"\r"},{"line_number":16,"context_line":"import eventlet\r"},{"line_number":17,"context_line":"import os\r"},{"line_number":18,"context_line":"import time\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"from oslo_log import log as logging\r"},{"line_number":21,"context_line":"import paramiko\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"40649eff_911e8416","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":11},"in_reply_to":"95b69320_d0c1d9bc","updated":"2021-09-13 14:17:03.000000000","message":"Thanks for your suggestion, I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"    def delete_helmchart(self, target_path):\r"},{"line_number":117,"context_line":"        # delete helm chart folder\r"},{"line_number":118,"context_line":"        ssh_command \u003d \"sudo rm -r {}\".format(target_path)\r"},{"line_number":119,"context_line":"        self._execute_command(ssh_command)\r"},{"line_number":120,"context_line":"\r"},{"line_number":121,"context_line":"    def install(self, release_name, chart_name, namespace, parameters):\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"02ebe53c_7ffe2170","line":118,"updated":"2021-09-13 11:59:19.000000000","message":"Does system asks users to delete file in CLI? This command line needs `-f` option to forcibly delete files.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"    def delete_helmchart(self, target_path):\r"},{"line_number":117,"context_line":"        # delete helm chart folder\r"},{"line_number":118,"context_line":"        ssh_command \u003d \"sudo rm -r {}\".format(target_path)\r"},{"line_number":119,"context_line":"        self._execute_command(ssh_command)\r"},{"line_number":120,"context_line":"\r"},{"line_number":121,"context_line":"    def install(self, release_name, chart_name, namespace, parameters):\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"cbce4c03_35924222","line":118,"in_reply_to":"02ebe53c_7ffe2170","updated":"2021-09-13 14:17:03.000000000","message":"Thanks for your suggestion, I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":115,"context_line":"\r"},{"line_number":116,"context_line":"    def delete_helmchart(self, target_path):\r"},{"line_number":117,"context_line":"        # delete helm chart folder\r"},{"line_number":118,"context_line":"        ssh_command \u003d \"sudo rm -r {}\".format(target_path)\r"},{"line_number":119,"context_line":"        self._execute_command(ssh_command)\r"},{"line_number":120,"context_line":"\r"},{"line_number":121,"context_line":"    def install(self, release_name, chart_name, namespace, parameters):\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"e3d43682_0db39b36","line":118,"in_reply_to":"cbce4c03_35924222","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        result \u003d self._execute_command(ssh_command)\r"},{"line_number":144,"context_line":"        # convert manifest to text format\r"},{"line_number":145,"context_line":"        mf_content \u003d \"\"\r"},{"line_number":146,"context_line":"        for out in result:\r"},{"line_number":147,"context_line":"            mf_content +\u003d out\r"},{"line_number":148,"context_line":"        return mf_content\r"},{"line_number":149,"context_line":"\r"},{"line_number":150,"context_line":"    def close_session(self):\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"54a36721_a67e2193","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":29},"updated":"2021-09-13 11:59:19.000000000","message":"Seems equivalent to using `str.join()`.\n```\nmf_content \u003d \u0027\u0027.join(result)\n```","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        result \u003d self._execute_command(ssh_command)\r"},{"line_number":144,"context_line":"        # convert manifest to text format\r"},{"line_number":145,"context_line":"        mf_content \u003d \"\"\r"},{"line_number":146,"context_line":"        for out in result:\r"},{"line_number":147,"context_line":"            mf_content +\u003d out\r"},{"line_number":148,"context_line":"        return mf_content\r"},{"line_number":149,"context_line":"\r"},{"line_number":150,"context_line":"    def close_session(self):\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"bc719be0_df914ae2","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":29},"in_reply_to":"13ffc1ee_18941f6a","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        result \u003d self._execute_command(ssh_command)\r"},{"line_number":144,"context_line":"        # convert manifest to text format\r"},{"line_number":145,"context_line":"        mf_content \u003d \"\"\r"},{"line_number":146,"context_line":"        for out in result:\r"},{"line_number":147,"context_line":"            mf_content +\u003d out\r"},{"line_number":148,"context_line":"        return mf_content\r"},{"line_number":149,"context_line":"\r"},{"line_number":150,"context_line":"    def close_session(self):\r"}],"source_content_type":"text/x-python","patch_set":19,"id":"13ffc1ee_18941f6a","line":147,"range":{"start_line":146,"start_character":0,"end_line":147,"end_character":29},"in_reply_to":"54a36721_a67e2193","updated":"2021-09-13 14:17:03.000000000","message":"Thanks for your suggestion, I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"}],"tacker/vnfm/infra_drivers/kubernetes/k8s/translate_outputs.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bd35c949424fe571fd5db07ac7bbc07baf4d96d0","unresolved":true,"context_lines":[{"line_number":334,"context_line":"                kind, file_content_dict)"},{"line_number":335,"context_line":"        except Exception as e:"},{"line_number":336,"context_line":"            if isinstance(e, client.rest.ApiException):"},{"line_number":337,"context_line":"                msg \u003d \\"},{"line_number":338,"context_line":"                    _(\u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":339,"context_line":"                        kind\u003dfile_content_dict.get(\u0027kind\u0027, \u0027\u0027),"},{"line_number":340,"context_line":"                        reason\u003de.body))"},{"line_number":341,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":20,"id":"2715f67a_3bdead50","line":338,"range":{"start_line":337,"start_character":22,"end_line":338,"end_character":22},"updated":"2021-09-13 17:37:07.000000000","message":"nit. Why don\u0027t you remove `\\` and make it one line as `msg \u003d _(`?","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"02a6a0c4f782316095a342a6a2d1b9cfe954b703","unresolved":true,"context_lines":[{"line_number":334,"context_line":"                kind, file_content_dict)"},{"line_number":335,"context_line":"        except Exception as e:"},{"line_number":336,"context_line":"            if isinstance(e, client.rest.ApiException):"},{"line_number":337,"context_line":"                msg \u003d \\"},{"line_number":338,"context_line":"                    _(\u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":339,"context_line":"                        kind\u003dfile_content_dict.get(\u0027kind\u0027, \u0027\u0027),"},{"line_number":340,"context_line":"                        reason\u003de.body))"},{"line_number":341,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":20,"id":"accf0c87_bf83553d","line":338,"range":{"start_line":337,"start_character":22,"end_line":338,"end_character":22},"in_reply_to":"2715f67a_3bdead50","updated":"2021-09-14 12:24:22.000000000","message":"I fixed it. There was no need to add `_(` if it was a single line text.","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bd35c949424fe571fd5db07ac7bbc07baf4d96d0","unresolved":true,"context_lines":[{"line_number":339,"context_line":"                        kind\u003dfile_content_dict.get(\u0027kind\u0027, \u0027\u0027),"},{"line_number":340,"context_line":"                        reason\u003de.body))"},{"line_number":341,"context_line":"            else:"},{"line_number":342,"context_line":"                msg \u003d \\"},{"line_number":343,"context_line":"                    _(\u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":344,"context_line":"                        kind\u003dfile_content_dict.get(\u0027kind\u0027, \u0027\u0027),"},{"line_number":345,"context_line":"                        reason\u003de))"},{"line_number":346,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"33717ab0_0c5d288c","line":343,"range":{"start_line":342,"start_character":22,"end_line":343,"end_character":22},"updated":"2021-09-13 17:37:07.000000000","message":"ditto","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"02a6a0c4f782316095a342a6a2d1b9cfe954b703","unresolved":true,"context_lines":[{"line_number":339,"context_line":"                        kind\u003dfile_content_dict.get(\u0027kind\u0027, \u0027\u0027),"},{"line_number":340,"context_line":"                        reason\u003de.body))"},{"line_number":341,"context_line":"            else:"},{"line_number":342,"context_line":"                msg \u003d \\"},{"line_number":343,"context_line":"                    _(\u0027{kind} create failure. Reason\u003d{reason}\u0027.format("},{"line_number":344,"context_line":"                        kind\u003dfile_content_dict.get(\u0027kind\u0027, \u0027\u0027),"},{"line_number":345,"context_line":"                        reason\u003de))"},{"line_number":346,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fb6c3297_cfcdfc46","line":343,"range":{"start_line":342,"start_character":22,"end_line":343,"end_character":22},"in_reply_to":"33717ab0_0c5d288c","updated":"2021-09-14 12:24:22.000000000","message":"ditto.","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"}],"tacker/vnfm/infra_drivers/kubernetes/kubernetes_driver.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":828,"context_line":"        ip_list \u003d helm_info.get(\u0027masternode_ip\u0027)"},{"line_number":829,"context_line":"        username \u003d helm_info.get(\u0027masternode_username\u0027)"},{"line_number":830,"context_line":"        password \u003d helm_info.get(\u0027masternode_password\u0027)"},{"line_number":831,"context_line":"        k8s_objs \u003d list()"},{"line_number":832,"context_line":"        # initialize HelmClient"},{"line_number":833,"context_line":"        helmclient \u003d helm_client.HelmClient(ip_list[0], username, password)"},{"line_number":834,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"76786f3d_06eb594e","line":831,"updated":"2021-09-13 11:59:19.000000000","message":"Should use `k8s_objs \u003d []`, because other part in this source uses brackets for initializing array.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":828,"context_line":"        ip_list \u003d helm_info.get(\u0027masternode_ip\u0027)"},{"line_number":829,"context_line":"        username \u003d helm_info.get(\u0027masternode_username\u0027)"},{"line_number":830,"context_line":"        password \u003d helm_info.get(\u0027masternode_password\u0027)"},{"line_number":831,"context_line":"        k8s_objs \u003d list()"},{"line_number":832,"context_line":"        # initialize HelmClient"},{"line_number":833,"context_line":"        helmclient \u003d helm_client.HelmClient(ip_list[0], username, password)"},{"line_number":834,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"c7e51dac_8854c45d","line":831,"in_reply_to":"76786f3d_06eb594e","updated":"2021-09-13 14:17:03.000000000","message":"I have modified it in PS20.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":828,"context_line":"        ip_list \u003d helm_info.get(\u0027masternode_ip\u0027)"},{"line_number":829,"context_line":"        username \u003d helm_info.get(\u0027masternode_username\u0027)"},{"line_number":830,"context_line":"        password \u003d helm_info.get(\u0027masternode_password\u0027)"},{"line_number":831,"context_line":"        k8s_objs \u003d list()"},{"line_number":832,"context_line":"        # initialize HelmClient"},{"line_number":833,"context_line":"        helmclient \u003d helm_client.HelmClient(ip_list[0], username, password)"},{"line_number":834,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"6f477ea0_c27e29ee","line":831,"in_reply_to":"c7e51dac_8854c45d","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":1511,"context_line":"            LOG.error(reason)"},{"line_number":1512,"context_line":"            raise vnfm.InvalidVimConnectionInfo(reason\u003dreason)"},{"line_number":1513,"context_line":"        helm_info \u003d self._get_helm_info(vim_connection_info)"},{"line_number":1514,"context_line":"        ip_list \u003d helm_info.get(\u0027masternode_ip\u0027, \u0027\u0027)"},{"line_number":1515,"context_line":"        username \u003d helm_info.get(\u0027masternode_username\u0027, \u0027\u0027)"},{"line_number":1516,"context_line":"        password \u003d helm_info.get(\u0027masternode_username\u0027, \u0027\u0027)"},{"line_number":1517,"context_line":"        if not (ip_list and username and password):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7e7379a9_262e9d69","line":1514,"updated":"2021-09-13 11:59:19.000000000","message":"Question: This statement returns empty string if `masternode_ip` does not exist, but variable name seems to contain list (array) structure. This variable must be array to support multiple masters, but at this point, this variable is only used for validating the attribute, so there\u0027s no problem even if the default value is string, not an array. Right?","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":1511,"context_line":"            LOG.error(reason)"},{"line_number":1512,"context_line":"            raise vnfm.InvalidVimConnectionInfo(reason\u003dreason)"},{"line_number":1513,"context_line":"        helm_info \u003d self._get_helm_info(vim_connection_info)"},{"line_number":1514,"context_line":"        ip_list \u003d helm_info.get(\u0027masternode_ip\u0027, \u0027\u0027)"},{"line_number":1515,"context_line":"        username \u003d helm_info.get(\u0027masternode_username\u0027, \u0027\u0027)"},{"line_number":1516,"context_line":"        password \u003d helm_info.get(\u0027masternode_username\u0027, \u0027\u0027)"},{"line_number":1517,"context_line":"        if not (ip_list and username and password):"}],"source_content_type":"text/x-python","patch_set":19,"id":"f5e5f7df_cfc3d0ec","line":1514,"in_reply_to":"7e7379a9_262e9d69","updated":"2021-09-13 14:17:03.000000000","message":"That\u0027s right, it is only used for validation in this point.\nHowever, I changed the default value to an array because type inconsistencies can confuse developers.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":1511,"context_line":"            LOG.error(reason)"},{"line_number":1512,"context_line":"            raise vnfm.InvalidVimConnectionInfo(reason\u003dreason)"},{"line_number":1513,"context_line":"        helm_info \u003d self._get_helm_info(vim_connection_info)"},{"line_number":1514,"context_line":"        ip_list \u003d helm_info.get(\u0027masternode_ip\u0027, \u0027\u0027)"},{"line_number":1515,"context_line":"        username \u003d helm_info.get(\u0027masternode_username\u0027, \u0027\u0027)"},{"line_number":1516,"context_line":"        password \u003d helm_info.get(\u0027masternode_username\u0027, \u0027\u0027)"},{"line_number":1517,"context_line":"        if not (ip_list and username and password):"}],"source_content_type":"text/x-python","patch_set":19,"id":"4f58d297_e2bba12d","line":1514,"in_reply_to":"f5e5f7df_cfc3d0ec","updated":"2021-09-16 01:24:06.000000000","message":"Thank you for your rework. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"4012739f175db6b9eec5e8a4920d4cb0d2b44fb2","unresolved":true,"context_lines":[{"line_number":1666,"context_line":"            # initialize HelmClient"},{"line_number":1667,"context_line":"            helmclient \u003d helm_client.HelmClient(ip, username, password)"},{"line_number":1668,"context_line":"            try:"},{"line_number":1669,"context_line":"                for param_idx, inst_params in enumerate(helm_inst_param_list):"},{"line_number":1670,"context_line":"                    release_name \u003d inst_params.get(\u0027helmreleasename\u0027)"},{"line_number":1671,"context_line":"                    parameters \u003d inst_params.get(\u0027helmparameter\u0027)"},{"line_number":1672,"context_line":"                    if self._is_exthelmchart(inst_params):"}],"source_content_type":"text/x-python","patch_set":19,"id":"92955740_c1ea83f0","line":1669,"updated":"2021-09-13 11:59:19.000000000","message":"`param_idx` is not used, thus should be `_`","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0ccf52d3542d06c77b9b04698559e264abb352b5","unresolved":true,"context_lines":[{"line_number":1666,"context_line":"            # initialize HelmClient"},{"line_number":1667,"context_line":"            helmclient \u003d helm_client.HelmClient(ip, username, password)"},{"line_number":1668,"context_line":"            try:"},{"line_number":1669,"context_line":"                for param_idx, inst_params in enumerate(helm_inst_param_list):"},{"line_number":1670,"context_line":"                    release_name \u003d inst_params.get(\u0027helmreleasename\u0027)"},{"line_number":1671,"context_line":"                    parameters \u003d inst_params.get(\u0027helmparameter\u0027)"},{"line_number":1672,"context_line":"                    if self._is_exthelmchart(inst_params):"}],"source_content_type":"text/x-python","patch_set":19,"id":"932dcdc1_6f2d3c34","line":1669,"in_reply_to":"92955740_c1ea83f0","updated":"2021-09-13 14:17:03.000000000","message":"Thanks for pointing out, there was no need to loop with enumerate.\nI have modified it without enumerate.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"743cd577626865360a70e40fde6e3774793d2b70","unresolved":true,"context_lines":[{"line_number":1666,"context_line":"            # initialize HelmClient"},{"line_number":1667,"context_line":"            helmclient \u003d helm_client.HelmClient(ip, username, password)"},{"line_number":1668,"context_line":"            try:"},{"line_number":1669,"context_line":"                for param_idx, inst_params in enumerate(helm_inst_param_list):"},{"line_number":1670,"context_line":"                    release_name \u003d inst_params.get(\u0027helmreleasename\u0027)"},{"line_number":1671,"context_line":"                    parameters \u003d inst_params.get(\u0027helmparameter\u0027)"},{"line_number":1672,"context_line":"                    if self._is_exthelmchart(inst_params):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9e4619c4_263b8700","line":1669,"in_reply_to":"932dcdc1_6f2d3c34","updated":"2021-09-16 01:24:06.000000000","message":"Thanks. I\u0027ve confirmed it.","commit_id":"4222d8282a96f8fd098cf60398222c54fe5cd299"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"bd35c949424fe571fd5db07ac7bbc07baf4d96d0","unresolved":true,"context_lines":[{"line_number":836,"context_line":"                release_name \u003d helm_inst_params.get(\u0027helmreleasename\u0027)"},{"line_number":837,"context_line":"                # execute `helm uninstall` command"},{"line_number":838,"context_line":"                helmclient.uninstall(release_name, namespace)"},{"line_number":839,"context_line":"        finally:"},{"line_number":840,"context_line":"            helmclient.close_session()"},{"line_number":841,"context_line":"        return k8s_objs"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    @log.log"}],"source_content_type":"text/x-python","patch_set":20,"id":"7e6ca926_863fa175","line":840,"range":{"start_line":839,"start_character":0,"end_line":840,"end_character":38},"updated":"2021-09-13 17:37:07.000000000","message":"Could I confirm why you close the session in `finally` clause here and after, L.1034 or so? If no exception is happened, you don\u0027t need to use `try` and `finally`, or it\u0027s happened, you\u0027d better to catch the exception. What do you think?","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"02a6a0c4f782316095a342a6a2d1b9cfe954b703","unresolved":true,"context_lines":[{"line_number":836,"context_line":"                release_name \u003d helm_inst_params.get(\u0027helmreleasename\u0027)"},{"line_number":837,"context_line":"                # execute `helm uninstall` command"},{"line_number":838,"context_line":"                helmclient.uninstall(release_name, namespace)"},{"line_number":839,"context_line":"        finally:"},{"line_number":840,"context_line":"            helmclient.close_session()"},{"line_number":841,"context_line":"        return k8s_objs"},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"    @log.log"}],"source_content_type":"text/x-python","patch_set":20,"id":"30ce0b53_c1248108","line":840,"range":{"start_line":839,"start_character":0,"end_line":840,"end_character":38},"in_reply_to":"7e6ca926_863fa175","updated":"2021-09-14 12:24:22.000000000","message":"I have made changes to add a call `close_session()` where the exception is raised in helm_client.\nAs a result, it no longer need \"try/finally\", so I have removed it.\nAnd this fix applies to the entire file.","commit_id":"b572a1db18046442adada01e92cd2405a3e59137"}]}