)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":10,"context_line":"was verified."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The following bugs have been fixed:"},{"line_number":13,"context_line":"1. The retry operation of LCM fails because the status of"},{"line_number":14,"context_line":"   vnf is ERROR."},{"line_number":15,"context_line":"2. When the CNF scale out retry, there is no scaleGroupDict,"},{"line_number":16,"context_line":"   so the retry fails."},{"line_number":17,"context_line":"3. When the terminate retry, the task_state of vnf_instance"},{"line_number":18,"context_line":"   is ERROR, so the retry fails."},{"line_number":19,"context_line":"4. When the scale out retry and before_error_point is greater"},{"line_number":20,"context_line":"   than 4, due to lack of resource_changes，so the retry fails."},{"line_number":21,"context_line":"5. When instantiate/heal/terminate retry and before_error_point"},{"line_number":22,"context_line":"   is 1, the retry fails because the status of vnf is ERROR."},{"line_number":23,"context_line":"6. When scale in/heal retry and before_error_point is 2,"},{"line_number":24,"context_line":"   because the node has been deleted, if it is deleted again,"},{"line_number":25,"context_line":"   the retry will fail."},{"line_number":26,"context_line":"7. When instantiate retry and before_error_point is 3, the"},{"line_number":27,"context_line":"   stack has been created by heat, and if it is created again,"},{"line_number":28,"context_line":"   the retry will fail."},{"line_number":29,"context_line":"8. When instantiate retry and before_error_point is 6,"},{"line_number":30,"context_line":"   (1) Because the worker node has been installed, if it is"},{"line_number":31,"context_line":"       installed again, the retry will fail."},{"line_number":32,"context_line":"   (2) As VIM is already registered, if you register again,"},{"line_number":33,"context_line":"       the retry will fail."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-Bug: #1942277"},{"line_number":36,"context_line":"Change-Id: If4e695120eb432155499a2e866ae651a18a320ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0b0497a0_6bbf5b7d","line":33,"range":{"start_line":13,"start_character":0,"end_line":33,"end_character":27},"updated":"2021-09-30 08:57:15.000000000","message":"I\u0027m not sure where are updated for each issues although you\u0027ve described WHAT are the issues. It\u0027s enough to be explained in bug report. I think your commit message is well explained for behaviors of the issues, but not so well for HOW you fix them.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"8c7f6995038544597ce7ec87f93eadbf8df26dee","unresolved":true,"context_lines":[{"line_number":10,"context_line":"was verified."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The following bugs have been fixed:"},{"line_number":13,"context_line":"1. The retry operation of LCM fails because the status of"},{"line_number":14,"context_line":"   vnf is ERROR."},{"line_number":15,"context_line":"2. When the CNF scale out retry, there is no scaleGroupDict,"},{"line_number":16,"context_line":"   so the retry fails."},{"line_number":17,"context_line":"3. When the terminate retry, the task_state of vnf_instance"},{"line_number":18,"context_line":"   is ERROR, so the retry fails."},{"line_number":19,"context_line":"4. When the scale out retry and before_error_point is greater"},{"line_number":20,"context_line":"   than 4, due to lack of resource_changes，so the retry fails."},{"line_number":21,"context_line":"5. When instantiate/heal/terminate retry and before_error_point"},{"line_number":22,"context_line":"   is 1, the retry fails because the status of vnf is ERROR."},{"line_number":23,"context_line":"6. When scale in/heal retry and before_error_point is 2,"},{"line_number":24,"context_line":"   because the node has been deleted, if it is deleted again,"},{"line_number":25,"context_line":"   the retry will fail."},{"line_number":26,"context_line":"7. When instantiate retry and before_error_point is 3, the"},{"line_number":27,"context_line":"   stack has been created by heat, and if it is created again,"},{"line_number":28,"context_line":"   the retry will fail."},{"line_number":29,"context_line":"8. When instantiate retry and before_error_point is 6,"},{"line_number":30,"context_line":"   (1) Because the worker node has been installed, if it is"},{"line_number":31,"context_line":"       installed again, the retry will fail."},{"line_number":32,"context_line":"   (2) As VIM is already registered, if you register again,"},{"line_number":33,"context_line":"       the retry will fail."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-Bug: #1942277"},{"line_number":36,"context_line":"Change-Id: If4e695120eb432155499a2e866ae651a18a320ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b617e9d4_7fcae49b","line":33,"range":{"start_line":13,"start_character":0,"end_line":33,"end_character":27},"in_reply_to":"0b0497a0_6bbf5b7d","updated":"2021-10-18 04:44:10.000000000","message":"I moved the description of the issues to bugreport, and changed the description here to how to fix these issues.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"efb12a049ce6e64afd0c5c0f42c9f61ec104e39c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in vnf_instance"},{"line_number":18,"context_line":"is changed to None."},{"line_number":19,"context_line":"4. In the scale operation, add an else branch. If before_error_point is"},{"line_number":20,"context_line":"greater than 4, get resource_changes from vinf_info first. If"},{"line_number":21,"context_line":"resource_changes does not exist, get it by calling the"},{"line_number":22,"context_line":"self._scale_resource_update method."},{"line_number":23,"context_line":"5. At the beginning of instantiate/heal/terminate, when modifying the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b7266079_5cfd1d0c","line":20,"range":{"start_line":20,"start_character":42,"end_line":20,"end_character":52},"updated":"2021-10-22 02:45:20.000000000","message":"typo: vnf_info is correct.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1c3514d46238abc522b7522c3db5ad72fc327052","unresolved":false,"context_lines":[{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in vnf_instance"},{"line_number":18,"context_line":"is changed to None."},{"line_number":19,"context_line":"4. In the scale operation, add an else branch. If before_error_point is"},{"line_number":20,"context_line":"greater than 4, get resource_changes from vinf_info first. If"},{"line_number":21,"context_line":"resource_changes does not exist, get it by calling the"},{"line_number":22,"context_line":"self._scale_resource_update method."},{"line_number":23,"context_line":"5. At the beginning of instantiate/heal/terminate, when modifying the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"670802ed_0154b240","line":20,"range":{"start_line":20,"start_character":42,"end_line":20,"end_character":52},"in_reply_to":"4c741ae2_fe4bfb24","updated":"2021-10-27 06:18:28.000000000","message":"I\u0027ve confirmed.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"772e64fb8c18c6fc47b0c3e4ddc2b97869a163fe","unresolved":true,"context_lines":[{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in vnf_instance"},{"line_number":18,"context_line":"is changed to None."},{"line_number":19,"context_line":"4. In the scale operation, add an else branch. If before_error_point is"},{"line_number":20,"context_line":"greater than 4, get resource_changes from vinf_info first. If"},{"line_number":21,"context_line":"resource_changes does not exist, get it by calling the"},{"line_number":22,"context_line":"self._scale_resource_update method."},{"line_number":23,"context_line":"5. At the beginning of instantiate/heal/terminate, when modifying the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"4c741ae2_fe4bfb24","line":20,"range":{"start_line":20,"start_character":42,"end_line":20,"end_character":52},"in_reply_to":"b7266079_5cfd1d0c","updated":"2021-10-26 01:36:36.000000000","message":"I changed vinf_info to vnf_info.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"efb12a049ce6e64afd0c5c0f42c9f61ec104e39c","unresolved":true,"context_lines":[{"line_number":23,"context_line":"5. At the beginning of instantiate/heal/terminate, when modifying the"},{"line_number":24,"context_line":"status of vnf, add the judgment condition. When the status is not ERROR,"},{"line_number":25,"context_line":"it can be modified."},{"line_number":26,"context_line":"6. In the heal/scale operation, add a judgment condition to judge whether"},{"line_number":27,"context_line":"the node exists, and only when the node exists, the delete node command"},{"line_number":28,"context_line":"will be executed."},{"line_number":29,"context_line":"7. In the instantiate operation, before creating the stack, add to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"a5cc4961_b1a8d69f","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":73},"updated":"2021-10-22 02:45:20.000000000","message":"Could you make this line a little shorter.\n\nSubsequent lines should be wrapped at 72 characters.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1c3514d46238abc522b7522c3db5ad72fc327052","unresolved":false,"context_lines":[{"line_number":23,"context_line":"5. At the beginning of instantiate/heal/terminate, when modifying the"},{"line_number":24,"context_line":"status of vnf, add the judgment condition. When the status is not ERROR,"},{"line_number":25,"context_line":"it can be modified."},{"line_number":26,"context_line":"6. In the heal/scale operation, add a judgment condition to judge whether"},{"line_number":27,"context_line":"the node exists, and only when the node exists, the delete node command"},{"line_number":28,"context_line":"will be executed."},{"line_number":29,"context_line":"7. In the instantiate operation, before creating the stack, add to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f4e87057_d0ef8aa9","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":73},"in_reply_to":"22bbc2ee_fc014078","updated":"2021-10-27 06:18:28.000000000","message":"I\u0027ve confirmed.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"772e64fb8c18c6fc47b0c3e4ddc2b97869a163fe","unresolved":true,"context_lines":[{"line_number":23,"context_line":"5. At the beginning of instantiate/heal/terminate, when modifying the"},{"line_number":24,"context_line":"status of vnf, add the judgment condition. When the status is not ERROR,"},{"line_number":25,"context_line":"it can be modified."},{"line_number":26,"context_line":"6. In the heal/scale operation, add a judgment condition to judge whether"},{"line_number":27,"context_line":"the node exists, and only when the node exists, the delete node command"},{"line_number":28,"context_line":"will be executed."},{"line_number":29,"context_line":"7. In the instantiate operation, before creating the stack, add to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"22bbc2ee_fc014078","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":73},"in_reply_to":"a5cc4961_b1a8d69f","updated":"2021-10-26 01:36:36.000000000","message":"I confirmed and modified all the lines longer than 72.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"efb12a049ce6e64afd0c5c0f42c9f61ec104e39c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"7. In the instantiate operation, before creating the stack, add to"},{"line_number":30,"context_line":"determine whether the stack already exists."},{"line_number":31,"context_line":"8. (1) When installing the k8s node with MgmtDriver, add to determine"},{"line_number":32,"context_line":"   whether the node already exists in the cluster. If it exists, skip the"},{"line_number":33,"context_line":"   node and install the next node."},{"line_number":34,"context_line":"   (2) After installing the k8s cluster, when registering VIM, add to"},{"line_number":35,"context_line":"   determine whether the VIM already exists, and if it exists, use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0355ac77_76134351","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":73},"updated":"2021-10-22 02:45:20.000000000","message":"ditto","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"772e64fb8c18c6fc47b0c3e4ddc2b97869a163fe","unresolved":true,"context_lines":[{"line_number":29,"context_line":"7. In the instantiate operation, before creating the stack, add to"},{"line_number":30,"context_line":"determine whether the stack already exists."},{"line_number":31,"context_line":"8. (1) When installing the k8s node with MgmtDriver, add to determine"},{"line_number":32,"context_line":"   whether the node already exists in the cluster. If it exists, skip the"},{"line_number":33,"context_line":"   node and install the next node."},{"line_number":34,"context_line":"   (2) After installing the k8s cluster, when registering VIM, add to"},{"line_number":35,"context_line":"   determine whether the VIM already exists, and if it exists, use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5089e406_e54fe791","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":73},"in_reply_to":"0355ac77_76134351","updated":"2021-10-26 01:36:36.000000000","message":"I made a line break in the patch 5.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1c3514d46238abc522b7522c3db5ad72fc327052","unresolved":false,"context_lines":[{"line_number":29,"context_line":"7. In the instantiate operation, before creating the stack, add to"},{"line_number":30,"context_line":"determine whether the stack already exists."},{"line_number":31,"context_line":"8. (1) When installing the k8s node with MgmtDriver, add to determine"},{"line_number":32,"context_line":"   whether the node already exists in the cluster. If it exists, skip the"},{"line_number":33,"context_line":"   node and install the next node."},{"line_number":34,"context_line":"   (2) After installing the k8s cluster, when registering VIM, add to"},{"line_number":35,"context_line":"   determine whether the VIM already exists, and if it exists, use it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f2bcca3a_b04ff542","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":73},"in_reply_to":"5089e406_e54fe791","updated":"2021-10-27 06:18:28.000000000","message":"I\u0027ve confirmed.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1c3514d46238abc522b7522c3db5ad72fc327052","unresolved":true,"context_lines":[{"line_number":12,"context_line":"To fix these errors, the following things is done in this patch:"},{"line_number":13,"context_line":"1. When executing retry, if the status of vnf is ERROR, change ERROR to"},{"line_number":14,"context_line":"the status of the corresponding lifecycle."},{"line_number":15,"context_line":"2. In the sucale operation, the judgment condition is added. When vim is"},{"line_number":16,"context_line":"not kubernetes, the `scaleGroupDict` assignment will be used."},{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in"},{"line_number":18,"context_line":"vnf_instance is changed to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"50fd119d_54b88d6b","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":16},"updated":"2021-10-27 06:18:28.000000000","message":"typo: \"scale\" is correct.","commit_id":"90c934eb90785326354bbfa8f85dd9ca0622bd77"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2898ed28ee90f8547690f8e8a9d03b99e04526d5","unresolved":true,"context_lines":[{"line_number":12,"context_line":"To fix these errors, the following things is done in this patch:"},{"line_number":13,"context_line":"1. When executing retry, if the status of vnf is ERROR, change ERROR to"},{"line_number":14,"context_line":"the status of the corresponding lifecycle."},{"line_number":15,"context_line":"2. In the sucale operation, the judgment condition is added. When vim is"},{"line_number":16,"context_line":"not kubernetes, the `scaleGroupDict` assignment will be used."},{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in"},{"line_number":18,"context_line":"vnf_instance is changed to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa08d93c_8afef9ef","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":16},"in_reply_to":"50fd119d_54b88d6b","updated":"2021-10-27 06:45:43.000000000","message":"I changed `sucale` to `scale`.","commit_id":"90c934eb90785326354bbfa8f85dd9ca0622bd77"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"60ebe3d7508ab875435d1777be385fb32033ad94","unresolved":false,"context_lines":[{"line_number":12,"context_line":"To fix these errors, the following things is done in this patch:"},{"line_number":13,"context_line":"1. When executing retry, if the status of vnf is ERROR, change ERROR to"},{"line_number":14,"context_line":"the status of the corresponding lifecycle."},{"line_number":15,"context_line":"2. In the sucale operation, the judgment condition is added. When vim is"},{"line_number":16,"context_line":"not kubernetes, the `scaleGroupDict` assignment will be used."},{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in"},{"line_number":18,"context_line":"vnf_instance is changed to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2c57ac3c_8b3a2980","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":16},"in_reply_to":"fa08d93c_8afef9ef","updated":"2021-10-28 07:15:56.000000000","message":"I\u0027ve confirmed.","commit_id":"90c934eb90785326354bbfa8f85dd9ca0622bd77"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"85c57a2a9571989e9c30468407f350b205a66fba","unresolved":true,"context_lines":[{"line_number":12,"context_line":"To fix these errors, the following things is done in this patch:"},{"line_number":13,"context_line":"1. When executing retry, if the status of vnf is ERROR, change ERROR to"},{"line_number":14,"context_line":"the status of the corresponding lifecycle."},{"line_number":15,"context_line":"2. In the sucale operation, the judgment condition is added. When vim is"},{"line_number":16,"context_line":"not kubernetes, the `scaleGroupDict` assignment will be used."},{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in"},{"line_number":18,"context_line":"vnf_instance is changed to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fc36487d_3bb114f1","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":16},"updated":"2022-01-20 07:41:05.000000000","message":"It has been fixed in PS6, but it is typo again.","commit_id":"6e98ee4de3c4bf582ea9397309c11354d3e58643"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"f066195fa1e4f88af53079a9e2bd1ebf16e54038","unresolved":false,"context_lines":[{"line_number":12,"context_line":"To fix these errors, the following things is done in this patch:"},{"line_number":13,"context_line":"1. When executing retry, if the status of vnf is ERROR, change ERROR to"},{"line_number":14,"context_line":"the status of the corresponding lifecycle."},{"line_number":15,"context_line":"2. In the sucale operation, the judgment condition is added. When vim is"},{"line_number":16,"context_line":"not kubernetes, the `scaleGroupDict` assignment will be used."},{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in"},{"line_number":18,"context_line":"vnf_instance is changed to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"07eeba3b_2dd214ac","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":16},"in_reply_to":"fad03c8b_28906ff4","updated":"2022-01-26 08:06:58.000000000","message":"Thank you, I\u0027ve confirmed.","commit_id":"6e98ee4de3c4bf582ea9397309c11354d3e58643"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"b64d82083b84376faee912e34d58fef7eeb804be","unresolved":true,"context_lines":[{"line_number":12,"context_line":"To fix these errors, the following things is done in this patch:"},{"line_number":13,"context_line":"1. When executing retry, if the status of vnf is ERROR, change ERROR to"},{"line_number":14,"context_line":"the status of the corresponding lifecycle."},{"line_number":15,"context_line":"2. In the sucale operation, the judgment condition is added. When vim is"},{"line_number":16,"context_line":"not kubernetes, the `scaleGroupDict` assignment will be used."},{"line_number":17,"context_line":"3. When an exception occurs in terminate, the task_state in"},{"line_number":18,"context_line":"vnf_instance is changed to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fad03c8b_28906ff4","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":16},"in_reply_to":"fc36487d_3bb114f1","updated":"2022-01-21 04:59:17.000000000","message":"Sorry, the commit message has been restored.\nI have fixed it again.","commit_id":"6e98ee4de3c4bf582ea9397309c11354d3e58643"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"efb12a049ce6e64afd0c5c0f42c9f61ec104e39c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ba3b740_3224605f","updated":"2021-10-22 02:45:20.000000000","message":"Thanks for your rework, could you confirm my additional comments.","commit_id":"8cc583674c8ee782fcb677638ba62b23255f84a2"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1c3514d46238abc522b7522c3db5ad72fc327052","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"47c42cb6_4002ed3a","updated":"2021-10-27 06:18:28.000000000","message":"Thanks for rework. There is additional typo. Could you revise it?","commit_id":"90c934eb90785326354bbfa8f85dd9ca0622bd77"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"75bccc0c5fad3872fcab1a35c85db4c7e9c9285e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0f1b813e_6ea8d2ee","updated":"2021-10-28 07:50:05.000000000","message":"Thank you for the patch. I applied this patch to my local environment and confirmed that the issue was fixed.","commit_id":"7dd686b2508a74e95499e1fbee3a72c2553b467c"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"60ebe3d7508ab875435d1777be385fb32033ad94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8935d91e_6c8b34e9","updated":"2021-10-28 07:15:56.000000000","message":"Thanks for rework. LGTM.","commit_id":"7dd686b2508a74e95499e1fbee3a72c2553b467c"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"17fcb0d9035921adb214ea20155436507d9a1a61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"513bdc4e_8abbe337","updated":"2021-11-25 09:56:39.000000000","message":"recheck","commit_id":"44b90a7c15d9ef59b74c2a34ffc4bee52e2f3373"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"119e0462_684474f3","updated":"2021-12-12 23:23:17.000000000","message":"Thank you for the patch.\n\nPlease kindly find my comments below.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d2af9295_dc581238","updated":"2021-12-13 09:07:21.000000000","message":"Thank you for your work. I\u0027ve added comments to your code, please kindly find them.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"218354fd8507e694ea94e353e8402b96b0cfc06b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3447713d_dca445e3","updated":"2022-01-21 07:03:33.000000000","message":"recheck","commit_id":"71fbed8bf4b666ce6637e20278f41e4403c057e8"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"25cfe077a6f4365b58f146463abc87f9e86dbe55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ddb83587_b52637da","updated":"2022-01-21 12:27:14.000000000","message":"recheck","commit_id":"71fbed8bf4b666ce6637e20278f41e4403c057e8"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ad1fd6b2_dcf38d18","updated":"2022-02-08 06:44:25.000000000","message":"Thank you for re-work.\nLGTM","commit_id":"393148bfb4c97ebf569de6faef966b1b63db4bbe"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"2e96007ec04b3694f5884a4611299c398d5d7c74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8b73c991_97cbe337","updated":"2022-02-28 11:34:36.000000000","message":"recheck","commit_id":"382afbabcf1273a2e83ae2e8fd06b944fcfecad4"}],"samples/mgmt_driver/kubernetes_mgmt.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"45a1e3f4646d95dee5450eabd0a71d487ec0636b","unresolved":true,"context_lines":[{"line_number":902,"context_line":"                    user\u003duser, password\u003dpassword, host\u003dhost,"},{"line_number":903,"context_line":"                    timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"                # Check whether the service already exists"},{"line_number":906,"context_line":"                ssh_command \u003d \"kubectl get secret -n kube-system \" \\"},{"line_number":907,"context_line":"                              \"| grep \u0027^admin-token\u0027\""},{"line_number":908,"context_line":"                result \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":3,"id":"afb215e0_2d2b2cc9","line":905,"range":{"start_line":905,"start_character":36,"end_line":905,"end_character":44},"updated":"2021-10-07 14:34:07.000000000","message":"Just a question, is this \"service\" correct?\nbelow ssh_command seems to get \"secret\", Isn\u0027t it a typo?","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"efb12a049ce6e64afd0c5c0f42c9f61ec104e39c","unresolved":false,"context_lines":[{"line_number":902,"context_line":"                    user\u003duser, password\u003dpassword, host\u003dhost,"},{"line_number":903,"context_line":"                    timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"                # Check whether the service already exists"},{"line_number":906,"context_line":"                ssh_command \u003d \"kubectl get secret -n kube-system \" \\"},{"line_number":907,"context_line":"                              \"| grep \u0027^admin-token\u0027\""},{"line_number":908,"context_line":"                result \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":3,"id":"d0ae4e66_b8853eba","line":905,"range":{"start_line":905,"start_character":36,"end_line":905,"end_character":44},"in_reply_to":"20f4a331_e2e4c802","updated":"2021-10-22 02:45:20.000000000","message":"I\u0027ve confirmed.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":902,"context_line":"                    user\u003duser, password\u003dpassword, host\u003dhost,"},{"line_number":903,"context_line":"                    timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"                # Check whether the service already exists"},{"line_number":906,"context_line":"                ssh_command \u003d \"kubectl get secret -n kube-system \" \\"},{"line_number":907,"context_line":"                              \"| grep \u0027^admin-token\u0027\""},{"line_number":908,"context_line":"                result \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":3,"id":"20f4a331_e2e4c802","line":905,"range":{"start_line":905,"start_character":36,"end_line":905,"end_character":44},"in_reply_to":"afb215e0_2d2b2cc9","updated":"2021-10-18 04:32:23.000000000","message":"Thank you for your comment. I will change \"service\" to \"secret\" in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            err \u003d result.get_stderr()"},{"line_number":139,"context_line":"            if result.get_return_code() \u003d\u003d 0:"},{"line_number":140,"context_line":"                pass"},{"line_number":141,"context_line":"            elif result.get_return_code() !\u003d 0 and \\"},{"line_number":142,"context_line":"                    \"kubectl: command not found\" in err:"},{"line_number":143,"context_line":"                return \"False\""},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":8,"id":"12f3d78d_1ebdf60b","line":142,"range":{"start_line":141,"start_character":0,"end_line":142,"end_character":56},"updated":"2021-12-13 09:07:21.000000000","message":"Could you please replace backslash with parentheses? (As Hiromu Asahina pointed out at L195)\n\n```\n            elif (result.get_return_code() !\u003d 0 and\n                    \"kubectl: command not found\" in err):\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            err \u003d result.get_stderr()"},{"line_number":139,"context_line":"            if result.get_return_code() \u003d\u003d 0:"},{"line_number":140,"context_line":"                pass"},{"line_number":141,"context_line":"            elif result.get_return_code() !\u003d 0 and \\"},{"line_number":142,"context_line":"                    \"kubectl: command not found\" in err:"},{"line_number":143,"context_line":"                return \"False\""},{"line_number":144,"context_line":"            else:"},{"line_number":145,"context_line":"                LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e6b8c596_976f4781","line":142,"range":{"start_line":141,"start_character":0,"end_line":142,"end_character":56},"in_reply_to":"12f3d78d_1ebdf60b","updated":"2022-01-19 11:26:50.000000000","message":"I replaced the backslashes with parentheses.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":187,"context_line":"            extra[\u0027helm_info\u0027] \u003d str(helm_info)"},{"line_number":188,"context_line":"            vim_info[\u0027vim\u0027][\u0027extra\u0027] \u003d extra"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"}],"source_content_type":"text/x-python","patch_set":8,"id":"673dd2b0_5bcd15d9","line":190,"updated":"2021-12-12 23:23:17.000000000","message":"Maybe I just don\u0027t understand it, but, are ``created_vim_info`` and ``get_vim`` different?\nIt looks like they are obtained from the same DB table.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            extra[\u0027helm_info\u0027] \u003d str(helm_info)"},{"line_number":188,"context_line":"            vim_info[\u0027vim\u0027][\u0027extra\u0027] \u003d extra"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"}],"source_content_type":"text/x-python","patch_set":8,"id":"67d72978_354d0b04","line":190,"in_reply_to":"63891906_6ef6b603","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":187,"context_line":"            extra[\u0027helm_info\u0027] \u003d str(helm_info)"},{"line_number":188,"context_line":"            vim_info[\u0027vim\u0027][\u0027extra\u0027] \u003d extra"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"}],"source_content_type":"text/x-python","patch_set":8,"id":"63891906_6ef6b603","line":190,"in_reply_to":"673dd2b0_5bcd15d9","updated":"2022-01-19 11:26:50.000000000","message":"Their data sources are the same, but ``created_vim_info`` only has the contents of the vim table. And ``get_vim`` has the contents of vim and vimauths table. The following processing needs to use the auth_url field in the vimauths table.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":188,"context_line":"            vim_info[\u0027vim\u0027][\u0027extra\u0027] \u003d extra"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"fceff3fa_6560f366","line":191,"updated":"2021-12-12 23:23:17.000000000","message":"Maybe we can remove this var by making this block a method.\n\nPlease check the following a pseudo code. \n\n```\n        def get_or_create_vim(context, vim_name, server):\n            created_vim_info \u003d self._get_vim_by_name(context, vim_name)\n            if created_vim_info:\n                vim_info \u003d self.nfvo_plugin.get_vim(context, created_vim_info[\u0027id\u0027])\n                if (vim_info[\u0027auth_url\u0027] \u003d\u003d server and\n                    created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027):\n                    return created_vim_info\n            try:\n                return nfvo_plugin.create_vim(context, vim_info)\n            except Exception as e:\n                LOG.error(\"Failed to register kubernetes vim: %s\" % e)\n                raise exceptions.MgmtDriverOtherError(\n                    error_message\u003d\"Failed to register \"\n                                  \"kubernetes vim: %s\" % e)\n\n\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            vim_info[\u0027vim\u0027][\u0027extra\u0027] \u003d extra"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"bee53313_4e313661","line":191,"in_reply_to":"f694c4f9_a388109a","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":188,"context_line":"            vim_info[\u0027vim\u0027][\u0027extra\u0027] \u003d extra"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"f694c4f9_a388109a","line":191,"in_reply_to":"fceff3fa_6560f366","updated":"2022-01-19 11:26:50.000000000","message":"I removed this var and extracted this part into a method.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"2cfe2087_e4e0a3b4","line":192,"updated":"2021-12-12 23:23:17.000000000","message":"A ``nfvo_plugin`` instance is not always needed, so, could you please move it inside the if block below?\n\nOr, maybe it\u0027s better to make it a member variable (i.e., self.nfvo_plugin) since the ``nfvo_plugin`` is created in many places.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"a48d1007_338f0641","line":192,"in_reply_to":"2cfe2087_e4e0a3b4","updated":"2022-01-19 11:26:50.000000000","message":"I used ``self.nfvo_plugin \u003d NfvoPlugin()`` in place of nfvo_plugin here.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        created_vim_info \u003d self._get_vim_by_name(context, vim_name)"},{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a7fdeee_dbf91bcc","line":192,"in_reply_to":"a48d1007_338f0641","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"},{"line_number":196,"context_line":"                    created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027:"},{"line_number":197,"context_line":"                create_vim \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"9dc81cde_2afcec7a","line":194,"updated":"2021-12-12 23:23:17.000000000","message":"I suppose you can write ``create_vim_info[\u0027id\u0027]``.\nThe ``get_vim`` method doesn\u0027t consider a case where ``vim_id`` arg is empty, which means the ``get_vim`` will raise an exception when the ``vim_id`` is None.\nRaising an exception from ``get_vim`` and raising it from here are not a big difference.\n\nIf I\u0027m wrong, please ignore it.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"},{"line_number":196,"context_line":"                    created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027:"},{"line_number":197,"context_line":"                create_vim \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"d2078aec_9ddd7069","line":194,"in_reply_to":"9dc81cde_2afcec7a","updated":"2022-01-19 11:26:50.000000000","message":"Sorry, I wrote wrong here, ``create_vim_info`` should be an object, so it is changed to ``create_vim_info.id`` here.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        create_vim \u003d True"},{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"},{"line_number":196,"context_line":"                    created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027:"},{"line_number":197,"context_line":"                create_vim \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"0dbdafb7_b093101c","line":194,"in_reply_to":"d2078aec_9ddd7069","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"},{"line_number":196,"context_line":"                    created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027:"},{"line_number":197,"context_line":"                create_vim \u003d False"},{"line_number":198,"context_line":"        if create_vim:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5c02f0f4_a7b04fcf","line":195,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please use parentheses instead of a backslash?\n\nc.f., https://docs.openstack.org/hacking/latest/user/hacking.html#general\n\u003e It is preferred to wrap long lines in parentheses and not a backslash for line continuation.\n\n\n```\n            if (get_vim[\u0027auth_url\u0027] \u003d\u003d server and \n                created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027):\n```\n\nFor the consistency of codeing, maybe it\u0027s a good idea to follow the coding style of the codes under the ``sol_refactored`` directory [1].\nI know it\u0027s not a matter of right or wrong, but keeping the same style will help other developers to understand the codes.\n\n[1] https://github.com/openstack/tacker/tree/master/tacker/sol_refactored","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"},{"line_number":196,"context_line":"                    created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027:"},{"line_number":197,"context_line":"                create_vim \u003d False"},{"line_number":198,"context_line":"        if create_vim:"}],"source_content_type":"text/x-python","patch_set":8,"id":"e456d290_90ad8695","line":195,"in_reply_to":"5c02f0f4_a7b04fcf","updated":"2022-01-19 11:26:50.000000000","message":"I used parentheses instead of backslashes.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        nfvo_plugin \u003d NfvoPlugin()"},{"line_number":193,"context_line":"        if created_vim_info:"},{"line_number":194,"context_line":"            get_vim \u003d nfvo_plugin.get_vim(context, created_vim_info.get(\u0027id\u0027))"},{"line_number":195,"context_line":"            if get_vim[\u0027auth_url\u0027] \u003d\u003d server and \\"},{"line_number":196,"context_line":"                    created_vim_info.get(\u0027status\u0027) \u003d\u003d \u0027REACHABLE\u0027:"},{"line_number":197,"context_line":"                create_vim \u003d False"},{"line_number":198,"context_line":"        if create_vim:"}],"source_content_type":"text/x-python","patch_set":8,"id":"8c9bf4be_6dad23b6","line":195,"in_reply_to":"e456d290_90ad8695","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            try:"},{"line_number":200,"context_line":"                created_vim_info \u003d nfvo_plugin.create_vim(context, vim_info)"},{"line_number":201,"context_line":"            except Exception as e:"},{"line_number":202,"context_line":"                LOG.error(\"Failed to register kubernetes vim: {}\".format(e))"},{"line_number":203,"context_line":"                raise exceptions.MgmtDriverOtherError("},{"line_number":204,"context_line":"                    error_message\u003d\"Failed to register \""},{"line_number":205,"context_line":"                                  \"kubernetes vim: {}\".format(e))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        id \u003d uuidutils.generate_uuid()"},{"line_number":208,"context_line":"        vim_id \u003d created_vim_info.get(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d8416827_6078e12b","line":205,"range":{"start_line":202,"start_character":0,"end_line":205,"end_character":64},"updated":"2021-12-13 09:07:21.000000000","message":"I think f-literal string is ideal in this context for short code.\n\n```\n                LOG.error(f\"Failed to register kubernetes vim: {e}\")\n                raise exceptions.MgmtDriverOtherError(\n                    error_message\u003d\"Failed to register \"\n                                  f\"kubernetes vim: {e}\")\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            try:"},{"line_number":200,"context_line":"                created_vim_info \u003d nfvo_plugin.create_vim(context, vim_info)"},{"line_number":201,"context_line":"            except Exception as e:"},{"line_number":202,"context_line":"                LOG.error(\"Failed to register kubernetes vim: {}\".format(e))"},{"line_number":203,"context_line":"                raise exceptions.MgmtDriverOtherError("},{"line_number":204,"context_line":"                    error_message\u003d\"Failed to register \""},{"line_number":205,"context_line":"                                  \"kubernetes vim: {}\".format(e))"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        id \u003d uuidutils.generate_uuid()"},{"line_number":208,"context_line":"        vim_id \u003d created_vim_info.get(\u0027id\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"d6c20299_d3eb2532","line":205,"range":{"start_line":202,"start_character":0,"end_line":205,"end_character":64},"in_reply_to":"d8416827_6078e12b","updated":"2022-01-19 11:26:50.000000000","message":"I will fix it in the 9 patch.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":778,"context_line":"        # install master node"},{"line_number":779,"context_line":"        for vm_dict in master_vm_dict_list:"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"            # check master_node exist in k8s-cluster"},{"line_number":782,"context_line":"            nic_ip \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027nic_ip\u0027)"},{"line_number":783,"context_line":"            master_name \u003d \u0027master\u0027 + nic_ip.split(\u0027.\u0027)[-1]"},{"line_number":784,"context_line":"            master_installed_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"4027a59c_826882ee","line":781,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please consider to make this block a method?\n\nAlthough using a user-defined method in the for-loop incurs overhead, an abstraction like the following increases the readability.\n\n\n```\n        for vm_dict in master_vm_dict_list:\n             if is_master_installed(SOME ARGS):\n                 continue\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":778,"context_line":"        # install master node"},{"line_number":779,"context_line":"        for vm_dict in master_vm_dict_list:"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"            # check master_node exist in k8s-cluster"},{"line_number":782,"context_line":"            nic_ip \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027nic_ip\u0027)"},{"line_number":783,"context_line":"            master_name \u003d \u0027master\u0027 + nic_ip.split(\u0027.\u0027)[-1]"},{"line_number":784,"context_line":"            master_installed_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"a55afdf1_ea935a96","line":781,"in_reply_to":"4027a59c_826882ee","updated":"2022-01-19 11:26:50.000000000","message":"I moved this block of code into a method.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        # install master node"},{"line_number":779,"context_line":"        for vm_dict in master_vm_dict_list:"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"            # check master_node exist in k8s-cluster"},{"line_number":782,"context_line":"            nic_ip \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027nic_ip\u0027)"},{"line_number":783,"context_line":"            master_name \u003d \u0027master\u0027 + nic_ip.split(\u0027.\u0027)[-1]"},{"line_number":784,"context_line":"            master_installed_flag \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"4d64597f_4538cf30","line":781,"in_reply_to":"a55afdf1_ea935a96","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":779,"context_line":"        for vm_dict in master_vm_dict_list:"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"            # check master_node exist in k8s-cluster"},{"line_number":782,"context_line":"            nic_ip \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027nic_ip\u0027)"},{"line_number":783,"context_line":"            master_name \u003d \u0027master\u0027 + nic_ip.split(\u0027.\u0027)[-1]"},{"line_number":784,"context_line":"            master_installed_flag \u003d False"},{"line_number":785,"context_line":"            user \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027username\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7d708696_68d7ef80","line":782,"updated":"2021-12-12 23:23:17.000000000","message":"Reading the ll.339-430, it seems that if ``master_vm_dict_list`` is NOT empty, ``vm_dict`` always has the key ``ssh`` and ``nic_ip``.\nThus, we don\u0027t have to do ``get(\u0027ssh\u0027)`` and ``get(\u0027nic_ip\u0027)`` here.\nAlso, you do ``nic_ip.split(\u0027.\u0027)[-1]`` just below this line, which will cause an error if ``nic_ip`` is None even if doing ``get(\u0027nic_ip\u0027)`` here. \n\nIt\u0027s just a minor comment so you can ignore it, but I think it\u0027s ideally better to make ``vm_dict`` a class so that you can add any property to get an attribute easily. \nSomething like this.\n\n```\nclass VM:\n    ...\n\n    @property\n    def nic_ip(self):\n        return self._ssh[\u0027nic_ip\u0027]\n        \n    @property\n    def master_name(self):\n        return \u0027master\u0027 + self.nic_ip.split(\u0027.\u0027)[-1]\n\nvm \u003d VM(username, password, ipaddr, nic_ip)\nprint(vm.nic_ip)\n# Output: 192.168.0.1\n\n```\n\nthough I\u0027m not sure defining ``master_name`` property in the above class makes sense...","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":779,"context_line":"        for vm_dict in master_vm_dict_list:"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"            # check master_node exist in k8s-cluster"},{"line_number":782,"context_line":"            nic_ip \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027nic_ip\u0027)"},{"line_number":783,"context_line":"            master_name \u003d \u0027master\u0027 + nic_ip.split(\u0027.\u0027)[-1]"},{"line_number":784,"context_line":"            master_installed_flag \u003d False"},{"line_number":785,"context_line":"            user \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027username\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f3c500a6_a652c0df","line":782,"in_reply_to":"7d708696_68d7ef80","updated":"2022-01-19 11:26:50.000000000","message":"I replaced ``get(\u0027ssh\u0027)`` and ``get(\u0027nic_ip\u0027)`` with ``vm_dict[\u0027ssh\u0027][\u0027nic_ip\u0027]``.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        for vm_dict in master_vm_dict_list:"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"            # check master_node exist in k8s-cluster"},{"line_number":782,"context_line":"            nic_ip \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027nic_ip\u0027)"},{"line_number":783,"context_line":"            master_name \u003d \u0027master\u0027 + nic_ip.split(\u0027.\u0027)[-1]"},{"line_number":784,"context_line":"            master_installed_flag \u003d False"},{"line_number":785,"context_line":"            user \u003d vm_dict.get(\u0027ssh\u0027, {}).get(\u0027username\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b5130d9d_6da4ccb6","line":782,"in_reply_to":"f3c500a6_a652c0df","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":788,"context_line":"            commander \u003d cmd_executer.RemoteCommandExecutor("},{"line_number":789,"context_line":"                user\u003duser, password\u003dpassword,"},{"line_number":790,"context_line":"                host\u003dhost, timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":791,"context_line":"            ssh_command \u003d \"kubectl get node | grep {}\".format(master_name)"},{"line_number":792,"context_line":"            result \u003d self._execute_command(commander, ssh_command,"},{"line_number":793,"context_line":"                                           K8S_CMD_TIMEOUT, \u0027check_node\u0027, 0)"},{"line_number":794,"context_line":"            if result !\u003d \"False\":"}],"source_content_type":"text/x-python","patch_set":8,"id":"cfddc059_a1d9487c","line":791,"updated":"2021-12-13 09:07:21.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":788,"context_line":"            commander \u003d cmd_executer.RemoteCommandExecutor("},{"line_number":789,"context_line":"                user\u003duser, password\u003dpassword,"},{"line_number":790,"context_line":"                host\u003dhost, timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":791,"context_line":"            ssh_command \u003d \"kubectl get node | grep {}\".format(master_name)"},{"line_number":792,"context_line":"            result \u003d self._execute_command(commander, ssh_command,"},{"line_number":793,"context_line":"                                           K8S_CMD_TIMEOUT, \u0027check_node\u0027, 0)"},{"line_number":794,"context_line":"            if result !\u003d \"False\":"}],"source_content_type":"text/x-python","patch_set":8,"id":"d9385b0e_cc46aadc","line":791,"in_reply_to":"cfddc059_a1d9487c","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":935,"context_line":"                    timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"                # Check whether the secret already exists"},{"line_number":938,"context_line":"                ssh_command \u003d \"kubectl get secret -n kube-system \" \\"},{"line_number":939,"context_line":"                              \"| grep \u0027^admin-token\u0027\""},{"line_number":940,"context_line":"                result \u003d self._execute_command("},{"line_number":941,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"cd97551b_edb5aead","line":938,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please consider to make this block a method and use parentheses instead of a backslash?\n\nAnd use that method like this.\n```\n             if not has_secret(SOME ARGS):\n                    ssh_command \u003d \\\n                        \"kubectl create -f /tmp/create_admin_token.yaml\"\n                    self._execute_command(\n                        commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)\n             else:\n...\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":935,"context_line":"                    timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"                # Check whether the secret already exists"},{"line_number":938,"context_line":"                ssh_command \u003d \"kubectl get secret -n kube-system \" \\"},{"line_number":939,"context_line":"                              \"| grep \u0027^admin-token\u0027\""},{"line_number":940,"context_line":"                result \u003d self._execute_command("},{"line_number":941,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"21da5f17_e886f71a","line":938,"in_reply_to":"a7963125_cf856335","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":935,"context_line":"                    timeout\u003dK8S_CMD_TIMEOUT)"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"                # Check whether the secret already exists"},{"line_number":938,"context_line":"                ssh_command \u003d \"kubectl get secret -n kube-system \" \\"},{"line_number":939,"context_line":"                              \"| grep \u0027^admin-token\u0027\""},{"line_number":940,"context_line":"                result \u003d self._execute_command("},{"line_number":941,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"a7963125_cf856335","line":938,"in_reply_to":"cd97551b_edb5aead","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":940,"context_line":"                result \u003d self._execute_command("},{"line_number":941,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":942,"context_line":"                if not result:"},{"line_number":943,"context_line":"                    ssh_command \u003d \\"},{"line_number":944,"context_line":"                        \"kubectl create -f /tmp/create_admin_token.yaml\""},{"line_number":945,"context_line":"                    self._execute_command("},{"line_number":946,"context_line":"                        commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"03b0ba62_29622d69","line":943,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please use parentheses instead of a backslash?","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":940,"context_line":"                result \u003d self._execute_command("},{"line_number":941,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":942,"context_line":"                if not result:"},{"line_number":943,"context_line":"                    ssh_command \u003d \\"},{"line_number":944,"context_line":"                        \"kubectl create -f /tmp/create_admin_token.yaml\""},{"line_number":945,"context_line":"                    self._execute_command("},{"line_number":946,"context_line":"                        commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5e57ad2b_76a565d6","line":943,"in_reply_to":"03b0ba62_29622d69","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":940,"context_line":"                result \u003d self._execute_command("},{"line_number":941,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":942,"context_line":"                if not result:"},{"line_number":943,"context_line":"                    ssh_command \u003d \\"},{"line_number":944,"context_line":"                        \"kubectl create -f /tmp/create_admin_token.yaml\""},{"line_number":945,"context_line":"                    self._execute_command("},{"line_number":946,"context_line":"                        commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e8fe3e5a_a2a332f5","line":943,"in_reply_to":"5e57ad2b_76a565d6","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":944,"context_line":"                        \"kubectl create -f /tmp/create_admin_token.yaml\""},{"line_number":945,"context_line":"                    self._execute_command("},{"line_number":946,"context_line":"                        commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":947,"context_line":"                    time.sleep(30)"},{"line_number":948,"context_line":"                else:"},{"line_number":949,"context_line":"                    ssh_command \u003d \"kubectl get node\""},{"line_number":950,"context_line":"                    get_node_names \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":8,"id":"2e95c179_2fe53c70","line":947,"updated":"2021-12-12 23:23:17.000000000","message":"Maybe I just don\u0027t understand it, but is waiting 30 seconds to create a secret really enough?","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":944,"context_line":"                        \"kubectl create -f /tmp/create_admin_token.yaml\""},{"line_number":945,"context_line":"                    self._execute_command("},{"line_number":946,"context_line":"                        commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":947,"context_line":"                    time.sleep(30)"},{"line_number":948,"context_line":"                else:"},{"line_number":949,"context_line":"                    ssh_command \u003d \"kubectl get node\""},{"line_number":950,"context_line":"                    get_node_names \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":8,"id":"59795b05_b5fe8810","line":947,"in_reply_to":"2e95c179_2fe53c70","updated":"2022-01-19 11:26:50.000000000","message":"Here is another 30 seconds to wait, ``_execute_command`` has already waited 30 seconds.\nGenerally, secret is created in an instant. I think these times should be enough.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                        \"kubectl create -f /tmp/create_admin_token.yaml\""},{"line_number":945,"context_line":"                    self._execute_command("},{"line_number":946,"context_line":"                        commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":947,"context_line":"                    time.sleep(30)"},{"line_number":948,"context_line":"                else:"},{"line_number":949,"context_line":"                    ssh_command \u003d \"kubectl get node\""},{"line_number":950,"context_line":"                    get_node_names \u003d self._execute_command("}],"source_content_type":"text/x-python","patch_set":8,"id":"96791f22_69398d9a","line":947,"in_reply_to":"59795b05_b5fe8810","updated":"2022-02-08 06:44:25.000000000","message":"Thank you for your reply. I understand.\nIf the secret is created in an instant as you mentioned, maybe it\u0027s better to minimize this time by doing polling if it\u0027s possible. Not now, maybe later.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"            # execute install k8s command on VM"},{"line_number":1001,"context_line":"            for get_node_name in get_node_names:"},{"line_number":1002,"context_line":"                if \u0027worker\u0027 + nic_ip.split(\u0027.\u0027)[-1] \u003d\u003d \\"},{"line_number":1003,"context_line":"                        get_node_name.split(\u0027 \u0027)[0]:"},{"line_number":1004,"context_line":"                    break"},{"line_number":1005,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"6d8c7294_387f7f6e","line":1002,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please use parentheses instead of a backslash?","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"            # execute install k8s command on VM"},{"line_number":1001,"context_line":"            for get_node_name in get_node_names:"},{"line_number":1002,"context_line":"                if \u0027worker\u0027 + nic_ip.split(\u0027.\u0027)[-1] \u003d\u003d \\"},{"line_number":1003,"context_line":"                        get_node_name.split(\u0027 \u0027)[0]:"},{"line_number":1004,"context_line":"                    break"},{"line_number":1005,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f547212_bbcd0bd0","line":1002,"in_reply_to":"6d8c7294_387f7f6e","updated":"2022-01-19 11:26:50.000000000","message":"I replaced the backslashes with parentheses.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"            # execute install k8s command on VM"},{"line_number":1001,"context_line":"            for get_node_name in get_node_names:"},{"line_number":1002,"context_line":"                if \u0027worker\u0027 + nic_ip.split(\u0027.\u0027)[-1] \u003d\u003d \\"},{"line_number":1003,"context_line":"                        get_node_name.split(\u0027 \u0027)[0]:"},{"line_number":1004,"context_line":"                    break"},{"line_number":1005,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1538af09_c3f9c165","line":1002,"in_reply_to":"9f547212_bbcd0bd0","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1464,"context_line":"            daemonset_content_str \u003d \u0027\u0027.join(result)"},{"line_number":1465,"context_line":"            daemonset_content \u003d json.loads("},{"line_number":1466,"context_line":"                daemonset_content_str)"},{"line_number":1467,"context_line":"            if len(daemonset_content[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":1468,"context_line":"                continue"},{"line_number":1469,"context_line":"            ssh_command \u003d \\"},{"line_number":1470,"context_line":"                \"kubectl drain {resource} --ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"b874df55_e5b83d59","line":1467,"updated":"2021-12-12 23:23:17.000000000","message":"According to the PEP8 [1], it should be this.\n\n```\n            if daemonset_content[\u0027items\u0027]:\n```\n\n\n\n[1] https://www.python.org/dev/peps/pep-0008/#programming-recommendations\n\n\n\u003e For sequences, (strings, lists, tuples), use the fact that empty sequences are false:\n\u003e \n\u003e # Correct:\n\u003e if not seq:\n\u003e if seq:\n\u003e \n\u003e # Wrong:\n\u003e if len(seq):\n\u003e if not len(seq):","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"            daemonset_content_str \u003d \u0027\u0027.join(result)"},{"line_number":1465,"context_line":"            daemonset_content \u003d json.loads("},{"line_number":1466,"context_line":"                daemonset_content_str)"},{"line_number":1467,"context_line":"            if len(daemonset_content[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":1468,"context_line":"                continue"},{"line_number":1469,"context_line":"            ssh_command \u003d \\"},{"line_number":1470,"context_line":"                \"kubectl drain {resource} --ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"2d89320d_e2c4aef6","line":1467,"in_reply_to":"58115793_edc2fdf0","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1464,"context_line":"            daemonset_content_str \u003d \u0027\u0027.join(result)"},{"line_number":1465,"context_line":"            daemonset_content \u003d json.loads("},{"line_number":1466,"context_line":"                daemonset_content_str)"},{"line_number":1467,"context_line":"            if len(daemonset_content[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":1468,"context_line":"                continue"},{"line_number":1469,"context_line":"            ssh_command \u003d \\"},{"line_number":1470,"context_line":"                \"kubectl drain {resource} --ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"58115793_edc2fdf0","line":1467,"in_reply_to":"891659b0_1890188b","updated":"2022-01-19 11:26:50.000000000","message":"I will fix it in the 9 patch.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b88efd7d2fe3944ff83a5856ab94d6f38a2c0a91","unresolved":true,"context_lines":[{"line_number":1464,"context_line":"            daemonset_content_str \u003d \u0027\u0027.join(result)"},{"line_number":1465,"context_line":"            daemonset_content \u003d json.loads("},{"line_number":1466,"context_line":"                daemonset_content_str)"},{"line_number":1467,"context_line":"            if len(daemonset_content[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":1468,"context_line":"                continue"},{"line_number":1469,"context_line":"            ssh_command \u003d \\"},{"line_number":1470,"context_line":"                \"kubectl drain {resource} --ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"891659b0_1890188b","line":1467,"in_reply_to":"b874df55_e5b83d59","updated":"2021-12-13 00:08:54.000000000","message":"Sorry\n\n```\n            if not daemonset_content[\u0027items\u0027]:\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":2072,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 3)"},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"            # check worker_node exist in k8s-cluster"},{"line_number":2075,"context_line":"            ssh_command \u003d \"kubectl get node | grep {}\".format("},{"line_number":2076,"context_line":"                fixed_master_name)"},{"line_number":2077,"context_line":"            result \u003d self._execute_command(commander, ssh_command,"},{"line_number":2078,"context_line":"                                           K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7fa28f9f_612180db","line":2075,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please consider to make this block a method?\n\nAnd use that method like this.\n```\n             if not is_worker_node_installed(SOME ARGS):\n                 continue\n\n...\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":2072,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 3)"},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"            # check worker_node exist in k8s-cluster"},{"line_number":2075,"context_line":"            ssh_command \u003d \"kubectl get node | grep {}\".format("},{"line_number":2076,"context_line":"                fixed_master_name)"},{"line_number":2077,"context_line":"            result \u003d self._execute_command(commander, ssh_command,"},{"line_number":2078,"context_line":"                                           K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f7030a9_7b7c473b","line":2075,"in_reply_to":"1cf47071_f7342acd","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2072,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 3)"},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"            # check worker_node exist in k8s-cluster"},{"line_number":2075,"context_line":"            ssh_command \u003d \"kubectl get node | grep {}\".format("},{"line_number":2076,"context_line":"                fixed_master_name)"},{"line_number":2077,"context_line":"            result \u003d self._execute_command(commander, ssh_command,"},{"line_number":2078,"context_line":"                                           K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1cf47071_f7342acd","line":2075,"in_reply_to":"7fa28f9f_612180db","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":2072,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 3)"},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"            # check worker_node exist in k8s-cluster"},{"line_number":2075,"context_line":"            ssh_command \u003d \"kubectl get node | grep {}\".format("},{"line_number":2076,"context_line":"                fixed_master_name)"},{"line_number":2077,"context_line":"            result \u003d self._execute_command(commander, ssh_command,"},{"line_number":2078,"context_line":"                                           K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":2079,"context_line":"            if not result:"}],"source_content_type":"text/x-python","patch_set":8,"id":"b6650a64_5f9cae2c","line":2076,"range":{"start_line":2075,"start_character":0,"end_line":2076,"end_character":34},"updated":"2021-12-13 09:07:21.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2072,"context_line":"                    commander, ssh_command, K8S_CMD_TIMEOUT, \u0027common\u0027, 3)"},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"            # check worker_node exist in k8s-cluster"},{"line_number":2075,"context_line":"            ssh_command \u003d \"kubectl get node | grep {}\".format("},{"line_number":2076,"context_line":"                fixed_master_name)"},{"line_number":2077,"context_line":"            result \u003d self._execute_command(commander, ssh_command,"},{"line_number":2078,"context_line":"                                           K8S_CMD_TIMEOUT, \u0027common\u0027, 0)"},{"line_number":2079,"context_line":"            if not result:"}],"source_content_type":"text/x-python","patch_set":8,"id":"212ae9d2_c5ed38c8","line":2076,"range":{"start_line":2075,"start_character":0,"end_line":2076,"end_character":34},"in_reply_to":"b6650a64_5f9cae2c","updated":"2022-01-19 11:26:50.000000000","message":"I will fix it in the 9 patch.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":2148,"context_line":"            worker_node_pod_info_str \u003d \u0027\u0027.join(result)"},{"line_number":2149,"context_line":"            worker_node_pod_info \u003d json.loads("},{"line_number":2150,"context_line":"                worker_node_pod_info_str)"},{"line_number":2151,"context_line":"            if len(worker_node_pod_info[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":2152,"context_line":"                continue"},{"line_number":2153,"context_line":"            ssh_command \u003d \"kubectl drain {} \" \\"},{"line_number":2154,"context_line":"                          \"--ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"18a90860_f9762998","line":2151,"updated":"2021-12-12 23:23:17.000000000","message":"According to the PEP8 [1], it should be this.\n\n```\n            if worker_node_pod_info[\u0027items\u0027]:\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b88efd7d2fe3944ff83a5856ab94d6f38a2c0a91","unresolved":true,"context_lines":[{"line_number":2148,"context_line":"            worker_node_pod_info_str \u003d \u0027\u0027.join(result)"},{"line_number":2149,"context_line":"            worker_node_pod_info \u003d json.loads("},{"line_number":2150,"context_line":"                worker_node_pod_info_str)"},{"line_number":2151,"context_line":"            if len(worker_node_pod_info[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":2152,"context_line":"                continue"},{"line_number":2153,"context_line":"            ssh_command \u003d \"kubectl drain {} \" \\"},{"line_number":2154,"context_line":"                          \"--ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"535e789e_31091fcb","line":2151,"in_reply_to":"18a90860_f9762998","updated":"2021-12-13 00:08:54.000000000","message":"Sorry.\n\n```\n            if not worker_node_pod_info[\u0027items\u0027]:\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2148,"context_line":"            worker_node_pod_info_str \u003d \u0027\u0027.join(result)"},{"line_number":2149,"context_line":"            worker_node_pod_info \u003d json.loads("},{"line_number":2150,"context_line":"                worker_node_pod_info_str)"},{"line_number":2151,"context_line":"            if len(worker_node_pod_info[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":2152,"context_line":"                continue"},{"line_number":2153,"context_line":"            ssh_command \u003d \"kubectl drain {} \" \\"},{"line_number":2154,"context_line":"                          \"--ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"c04ac1a8_45517f84","line":2151,"in_reply_to":"535e789e_31091fcb","updated":"2022-01-19 11:26:50.000000000","message":"I will fix it in the 9 patch.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":2148,"context_line":"            worker_node_pod_info_str \u003d \u0027\u0027.join(result)"},{"line_number":2149,"context_line":"            worker_node_pod_info \u003d json.loads("},{"line_number":2150,"context_line":"                worker_node_pod_info_str)"},{"line_number":2151,"context_line":"            if len(worker_node_pod_info[\u0027items\u0027]) \u003d\u003d 0:"},{"line_number":2152,"context_line":"                continue"},{"line_number":2153,"context_line":"            ssh_command \u003d \"kubectl drain {} \" \\"},{"line_number":2154,"context_line":"                          \"--ignore-daemonsets \" \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"53886b78_d3953d5d","line":2151,"in_reply_to":"c04ac1a8_45517f84","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":1197,"context_line":"            if max_level \u003c scale_level:"},{"line_number":1198,"context_line":"                return self._make_problem_detail("},{"line_number":1199,"context_line":"                    \u0027can not scale_out\u0027, 400, title\u003d\u0027can not scale_out\u0027)"},{"line_number":1200,"context_line":"            if \u0027vnf_lcm_op_occs_id\u0027 in vnf_info and vim_type !\u003d \"kubernets\":"},{"line_number":1201,"context_line":"                num \u003d (scaleGroupDict[\u0027scaleGroupDict\u0027]"},{"line_number":1202,"context_line":"                    [scale_vnf_request.aspect_id][\u0027num\u0027])"},{"line_number":1203,"context_line":"                default \u003d (scaleGroupDict[\u0027scaleGroupDict\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9dddbc59_242e6cf4","line":1200,"updated":"2021-12-13 09:07:21.000000000","message":"typo: kubernetes?","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1197,"context_line":"            if max_level \u003c scale_level:"},{"line_number":1198,"context_line":"                return self._make_problem_detail("},{"line_number":1199,"context_line":"                    \u0027can not scale_out\u0027, 400, title\u003d\u0027can not scale_out\u0027)"},{"line_number":1200,"context_line":"            if \u0027vnf_lcm_op_occs_id\u0027 in vnf_info and vim_type !\u003d \"kubernets\":"},{"line_number":1201,"context_line":"                num \u003d (scaleGroupDict[\u0027scaleGroupDict\u0027]"},{"line_number":1202,"context_line":"                    [scale_vnf_request.aspect_id][\u0027num\u0027])"},{"line_number":1203,"context_line":"                default \u003d (scaleGroupDict[\u0027scaleGroupDict\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"379baad3_73c95e10","line":1200,"in_reply_to":"9dddbc59_242e6cf4","updated":"2022-01-19 11:26:50.000000000","message":"This is a spelling error, I will change it to kubernetes.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"}],"tacker/conductor/conductor_server.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":2046,"context_line":"            vnf_dict[\u0027current_error_point\u0027] \u003d \\"},{"line_number":2047,"context_line":"                fields.ErrorPoint.NOTIFY_PROCESSING"},{"line_number":2048,"context_line":""},{"line_number":2049,"context_line":"            if vnf_dict[\u0027status\u0027] !\u003d \u0027ERROR\u0027 and \\"},{"line_number":2050,"context_line":"                    vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2051,"context_line":"               fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2052,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2053,"context_line":"                                _ACTIVE_STATUS, \u0027PENDING_TERMINATE\u0027)"},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2056,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2057,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_TERMINATE\u0027)"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"            if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2060,"context_line":"               fields.ErrorPoint.VNF_CONFIG_END:"}],"source_content_type":"text/x-python","patch_set":3,"id":"70210272_37f9810e","line":2057,"range":{"start_line":2049,"start_character":0,"end_line":2057,"end_character":75},"updated":"2021-09-30 08:57:15.000000000","message":"Do you think it\u0027s better to put the second condition first and use `elif` for the first one?\n\n```\nif vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:\n    ...\nelif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\\n    ....\n```","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":2046,"context_line":"            vnf_dict[\u0027current_error_point\u0027] \u003d \\"},{"line_number":2047,"context_line":"                fields.ErrorPoint.NOTIFY_PROCESSING"},{"line_number":2048,"context_line":""},{"line_number":2049,"context_line":"            if vnf_dict[\u0027status\u0027] !\u003d \u0027ERROR\u0027 and \\"},{"line_number":2050,"context_line":"                    vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2051,"context_line":"               fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2052,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2053,"context_line":"                                _ACTIVE_STATUS, \u0027PENDING_TERMINATE\u0027)"},{"line_number":2054,"context_line":""},{"line_number":2055,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2056,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2057,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_TERMINATE\u0027)"},{"line_number":2058,"context_line":""},{"line_number":2059,"context_line":"            if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2060,"context_line":"               fields.ErrorPoint.VNF_CONFIG_END:"}],"source_content_type":"text/x-python","patch_set":3,"id":"6fabde45_b46fa3e3","line":2057,"range":{"start_line":2049,"start_character":0,"end_line":2057,"end_character":75},"in_reply_to":"70210272_37f9810e","updated":"2021-10-18 04:32:23.000000000","message":"Thank you for your comments. I will fix it in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":2151,"context_line":"            vnf_dict[\u0027current_error_point\u0027] \u003d \\"},{"line_number":2152,"context_line":"                fields.ErrorPoint.NOTIFY_PROCESSING"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"            if vnf_dict[\u0027status\u0027] !\u003d \u0027ERROR\u0027 and \\"},{"line_number":2155,"context_line":"                    vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2156,"context_line":"               fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2157,"context_line":"                # update vnf status to PENDING_HEAL"},{"line_number":2158,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2159,"context_line":"                                _ACTIVE_STATUS, constants.PENDING_HEAL)"},{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2162,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2163,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_HEAL\u0027)"},{"line_number":2164,"context_line":""},{"line_number":2165,"context_line":"            if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2166,"context_line":"               fields.ErrorPoint.VNF_CONFIG_END:"}],"source_content_type":"text/x-python","patch_set":3,"id":"78a879c7_c104e04e","line":2163,"range":{"start_line":2154,"start_character":0,"end_line":2163,"end_character":70},"updated":"2021-09-30 08:57:15.000000000","message":"ditto","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":2151,"context_line":"            vnf_dict[\u0027current_error_point\u0027] \u003d \\"},{"line_number":2152,"context_line":"                fields.ErrorPoint.NOTIFY_PROCESSING"},{"line_number":2153,"context_line":""},{"line_number":2154,"context_line":"            if vnf_dict[\u0027status\u0027] !\u003d \u0027ERROR\u0027 and \\"},{"line_number":2155,"context_line":"                    vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2156,"context_line":"               fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2157,"context_line":"                # update vnf status to PENDING_HEAL"},{"line_number":2158,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2159,"context_line":"                                _ACTIVE_STATUS, constants.PENDING_HEAL)"},{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2162,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2163,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_HEAL\u0027)"},{"line_number":2164,"context_line":""},{"line_number":2165,"context_line":"            if vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2166,"context_line":"               fields.ErrorPoint.VNF_CONFIG_END:"}],"source_content_type":"text/x-python","patch_set":3,"id":"57637107_c856bd31","line":2163,"range":{"start_line":2154,"start_character":0,"end_line":2163,"end_character":70},"in_reply_to":"78a879c7_c104e04e","updated":"2021-10-18 04:32:23.000000000","message":"Thank you for your comments. I will fix it in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"45a1e3f4646d95dee5450eabd0a71d487ec0636b","unresolved":true,"context_lines":[{"line_number":2237,"context_line":"                vnf_lcm_op_occ_id)"},{"line_number":2238,"context_line":""},{"line_number":2239,"context_line":"        if vnf_info[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2240,"context_line":"            self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2241,"context_line":"                                    _ERROR_STATUS, \u0027PENDING_\u0027"},{"line_number":2242,"context_line":"                                    + scale_vnf_request.type)"},{"line_number":2243,"context_line":""},{"line_number":2244,"context_line":"        self.vnflcm_driver.scale_vnf("},{"line_number":2245,"context_line":"            context, vnf_info, vnf_instance, scale_vnf_request)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5b5150_c47ec481","line":2242,"range":{"start_line":2240,"start_character":0,"end_line":2242,"end_character":61},"updated":"2021-10-07 14:34:07.000000000","message":"nit: How about changing it to the following?\n```\n            self._change_vnf_status(context, vnf_instance.id,\n                                    _ERROR_STATUS,\n                                    \u0027PENDING_\u0027 + scale_vnf_request.type)\n```","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":2237,"context_line":"                vnf_lcm_op_occ_id)"},{"line_number":2238,"context_line":""},{"line_number":2239,"context_line":"        if vnf_info[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2240,"context_line":"            self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2241,"context_line":"                                    _ERROR_STATUS, \u0027PENDING_\u0027"},{"line_number":2242,"context_line":"                                    + scale_vnf_request.type)"},{"line_number":2243,"context_line":""},{"line_number":2244,"context_line":"        self.vnflcm_driver.scale_vnf("},{"line_number":2245,"context_line":"            context, vnf_info, vnf_instance, scale_vnf_request)"}],"source_content_type":"text/x-python","patch_set":3,"id":"aa1b5172_d6609d08","line":2242,"range":{"start_line":2240,"start_character":0,"end_line":2242,"end_character":61},"in_reply_to":"7a5b5150_c47ec481","updated":"2021-10-18 04:32:23.000000000","message":"Thank you for your comments. I will fix it in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"efb12a049ce6e64afd0c5c0f42c9f61ec104e39c","unresolved":false,"context_lines":[{"line_number":2237,"context_line":"                vnf_lcm_op_occ_id)"},{"line_number":2238,"context_line":""},{"line_number":2239,"context_line":"        if vnf_info[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2240,"context_line":"            self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2241,"context_line":"                                    _ERROR_STATUS, \u0027PENDING_\u0027"},{"line_number":2242,"context_line":"                                    + scale_vnf_request.type)"},{"line_number":2243,"context_line":""},{"line_number":2244,"context_line":"        self.vnflcm_driver.scale_vnf("},{"line_number":2245,"context_line":"            context, vnf_info, vnf_instance, scale_vnf_request)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3eb42c80_d1658596","line":2242,"range":{"start_line":2240,"start_character":0,"end_line":2242,"end_character":61},"in_reply_to":"aa1b5172_d6609d08","updated":"2021-10-22 02:45:20.000000000","message":"I\u0027ve confirmed.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":2429,"context_line":"            )"},{"line_number":2430,"context_line":""},{"line_number":2431,"context_line":"            vnf_dict[\u0027current_error_point\u0027] \u003d EP.NOTIFY_PROCESSING"},{"line_number":2432,"context_line":"            if vnf_dict[\u0027status\u0027] !\u003d \u0027ERROR\u0027 and \\"},{"line_number":2433,"context_line":"                    vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.NOTIFY_PROCESSING:"},{"line_number":2434,"context_line":"                # update vnf status to PENDING_CHANGE_EXT_CONN"},{"line_number":2435,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2436,"context_line":"                    _ACTIVE_STATUS, \u0027PENDING_CHANGE_EXT_CONN\u0027)"},{"line_number":2437,"context_line":""},{"line_number":2438,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2439,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2440,"context_line":"                                        _ERROR_STATUS,"},{"line_number":2441,"context_line":"                                        \u0027PENDING_CHANGE_EXT_CONN\u0027)"},{"line_number":2442,"context_line":""},{"line_number":2443,"context_line":"            self.vnflcm_driver.change_ext_conn_vnf("},{"line_number":2444,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"e818fbec_1aa1157f","line":2441,"range":{"start_line":2432,"start_character":0,"end_line":2441,"end_character":66},"updated":"2021-09-30 08:57:15.000000000","message":"ditto","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":2429,"context_line":"            )"},{"line_number":2430,"context_line":""},{"line_number":2431,"context_line":"            vnf_dict[\u0027current_error_point\u0027] \u003d EP.NOTIFY_PROCESSING"},{"line_number":2432,"context_line":"            if vnf_dict[\u0027status\u0027] !\u003d \u0027ERROR\u0027 and \\"},{"line_number":2433,"context_line":"                    vnf_dict[\u0027before_error_point\u0027] \u003c\u003d EP.NOTIFY_PROCESSING:"},{"line_number":2434,"context_line":"                # update vnf status to PENDING_CHANGE_EXT_CONN"},{"line_number":2435,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2436,"context_line":"                    _ACTIVE_STATUS, \u0027PENDING_CHANGE_EXT_CONN\u0027)"},{"line_number":2437,"context_line":""},{"line_number":2438,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2439,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2440,"context_line":"                                        _ERROR_STATUS,"},{"line_number":2441,"context_line":"                                        \u0027PENDING_CHANGE_EXT_CONN\u0027)"},{"line_number":2442,"context_line":""},{"line_number":2443,"context_line":"            self.vnflcm_driver.change_ext_conn_vnf("},{"line_number":2444,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"83360061_f6627275","line":2441,"range":{"start_line":2432,"start_character":0,"end_line":2441,"end_character":66},"in_reply_to":"e818fbec_1aa1157f","updated":"2021-10-18 04:32:23.000000000","message":"Thank you for your comments. I will fix it in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1954,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":1955,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_CREATE\u0027)"},{"line_number":1956,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":1957,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":1958,"context_line":"                # change vnf_status"},{"line_number":1959,"context_line":"                if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027INACTIVE\u0027:"},{"line_number":1960,"context_line":"                    vnf_dict[\u0027status\u0027] \u003d \u0027PENDING_CREATE\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"aeaf8b13_b521cd66","line":1957,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please use parentheses instead of a backslash?\n\nBTW, why don\u0027t you use the alias ``EP`` imported at l.62","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1954,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":1955,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_CREATE\u0027)"},{"line_number":1956,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":1957,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":1958,"context_line":"                # change vnf_status"},{"line_number":1959,"context_line":"                if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027INACTIVE\u0027:"},{"line_number":1960,"context_line":"                    vnf_dict[\u0027status\u0027] \u003d \u0027PENDING_CREATE\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"f198ab64_8249ef8d","line":1957,"in_reply_to":"aeaf8b13_b521cd66","updated":"2022-01-19 11:26:50.000000000","message":"Backslashes have been removed.\nSince it is existing code, it has not been changed.\nI modified them in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1954,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":1955,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_CREATE\u0027)"},{"line_number":1956,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":1957,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":1958,"context_line":"                # change vnf_status"},{"line_number":1959,"context_line":"                if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027INACTIVE\u0027:"},{"line_number":1960,"context_line":"                    vnf_dict[\u0027status\u0027] \u003d \u0027PENDING_CREATE\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"68293618_fe5a01ff","line":1957,"in_reply_to":"f198ab64_8249ef8d","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":2047,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2048,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2049,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_TERMINATE\u0027)"},{"line_number":2050,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2051,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2052,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2053,"context_line":"                                        _ACTIVE_STATUS, \u0027PENDING_TERMINATE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"14ee1d60_8e65e008","line":2050,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2047,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2048,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2049,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_TERMINATE\u0027)"},{"line_number":2050,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2051,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2052,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2053,"context_line":"                                        _ACTIVE_STATUS, \u0027PENDING_TERMINATE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"348cd9e7_b537687a","line":2050,"in_reply_to":"14ee1d60_8e65e008","updated":"2022-01-19 11:26:50.000000000","message":"I modified them in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2048,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2049,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_TERMINATE\u0027)"},{"line_number":2050,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2051,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2052,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2053,"context_line":"                                        _ACTIVE_STATUS, \u0027PENDING_TERMINATE\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f791eb4d_88310f34","line":2050,"in_reply_to":"348cd9e7_b537687a","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":2150,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2151,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2152,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_HEAL\u0027)"},{"line_number":2153,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2154,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2155,"context_line":"                # update vnf status to PENDING_HEAL"},{"line_number":2156,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e6dc7196_39ac3656","line":2153,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2150,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2151,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2152,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_HEAL\u0027)"},{"line_number":2153,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2154,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2155,"context_line":"                # update vnf status to PENDING_HEAL"},{"line_number":2156,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e99e0df0_262554dd","line":2153,"in_reply_to":"e6dc7196_39ac3656","updated":"2022-01-19 11:26:50.000000000","message":"I modified them in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":2150,"context_line":"            if vnf_dict[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":2151,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"},{"line_number":2152,"context_line":"                                        _ERROR_STATUS, \u0027PENDING_HEAL\u0027)"},{"line_number":2153,"context_line":"            elif vnf_dict[\u0027before_error_point\u0027] \u003c\u003d \\"},{"line_number":2154,"context_line":"                    fields.ErrorPoint.NOTIFY_PROCESSING:"},{"line_number":2155,"context_line":"                # update vnf status to PENDING_HEAL"},{"line_number":2156,"context_line":"                self._change_vnf_status(context, vnf_instance.id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"6e330f1e_21fed6ee","line":2153,"in_reply_to":"e99e0df0_262554dd","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":920,"context_line":"            termination_type\u003dfields.VnfInstanceTerminationType.GRACEFUL,"},{"line_number":921,"context_line":"            additional_params\u003d{\"key\": \"value\"})"},{"line_number":922,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":923,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf(instance_id\u003dself.instance_uuid)"},{"line_number":924,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":925,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":926,"context_line":"        self.conductor.terminate(self.context, vnf_lcm_op_occs_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"aba0b560_04cc4fda","line":923,"updated":"2021-12-12 23:23:17.000000000","message":"nits, but could you please create dict as a dictionary literal?\n\n```\n        vnf_dict \u003d {\n            **db_utils.get_dummy_vnf(instance_id\u003dself.instance_uuid),\n            \u0027before_error_point\u0027: fields.ErrorPoint.INITIAL,\n            \u0027status\u0027: \u0027\u0027\n        }\n\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":920,"context_line":"            termination_type\u003dfields.VnfInstanceTerminationType.GRACEFUL,"},{"line_number":921,"context_line":"            additional_params\u003d{\"key\": \"value\"})"},{"line_number":922,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":923,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf(instance_id\u003dself.instance_uuid)"},{"line_number":924,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":925,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":926,"context_line":"        self.conductor.terminate(self.context, vnf_lcm_op_occs_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"cf179186_79e23d8f","line":923,"in_reply_to":"72aed94d_32a0cb30","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":920,"context_line":"            termination_type\u003dfields.VnfInstanceTerminationType.GRACEFUL,"},{"line_number":921,"context_line":"            additional_params\u003d{\"key\": \"value\"})"},{"line_number":922,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":923,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf(instance_id\u003dself.instance_uuid)"},{"line_number":924,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":925,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":926,"context_line":"        self.conductor.terminate(self.context, vnf_lcm_op_occs_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"72aed94d_32a0cb30","line":923,"in_reply_to":"aba0b560_04cc4fda","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1468,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1469,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1470,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1471,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1472,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1473,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":1474,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"6a8a88e3_a1413624","line":1471,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1468,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1469,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1470,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1471,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1472,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1473,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":1474,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"eca3da3b_8f5bad18","line":1471,"in_reply_to":"6a8a88e3_a1413624","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1469,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1470,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1471,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1472,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1473,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":1474,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"caf373f4_62537411","line":1471,"in_reply_to":"eca3da3b_8f5bad18","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1512,"context_line":"        vnf_instance.save()"},{"line_number":1513,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1514,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1515,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1516,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.NOTIFY_PROCESSING"},{"line_number":1517,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1518,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"aec273b8_8b4df493","line":1515,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1512,"context_line":"        vnf_instance.save()"},{"line_number":1513,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1514,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1515,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1516,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.NOTIFY_PROCESSING"},{"line_number":1517,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1518,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"f1916e03_b5f6d450","line":1515,"in_reply_to":"aec273b8_8b4df493","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"        vnf_instance.save()"},{"line_number":1513,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1514,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1515,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1516,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.NOTIFY_PROCESSING"},{"line_number":1517,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1518,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7caaf4a0_a4c73d2a","line":1515,"in_reply_to":"f1916e03_b5f6d450","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1558,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1559,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1560,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INTERNAL_PROCESSING"},{"line_number":1561,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1562,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1563,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":1564,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ab62d152_2b0bb0a1","line":1561,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1558,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1559,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1560,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INTERNAL_PROCESSING"},{"line_number":1561,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1562,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1563,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":1564,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fb2757e9_8ed2ab82","line":1561,"in_reply_to":"08a18f60_f35681f5","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1558,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1559,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1560,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INTERNAL_PROCESSING"},{"line_number":1561,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1562,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1563,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":1564,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"08a18f60_f35681f5","line":1561,"in_reply_to":"ab62d152_2b0bb0a1","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1601,"context_line":"        vnf_instance.save()"},{"line_number":1602,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1603,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1604,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1605,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.NOTIFY_COMPLETED"},{"line_number":1606,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1607,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"4cec71a1_3eaa7747","line":1604,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1601,"context_line":"        vnf_instance.save()"},{"line_number":1602,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1603,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1604,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1605,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.NOTIFY_COMPLETED"},{"line_number":1606,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1607,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"f521ad43_66397cac","line":1604,"in_reply_to":"4cec71a1_3eaa7747","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1601,"context_line":"        vnf_instance.save()"},{"line_number":1602,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":1603,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":1604,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1605,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.NOTIFY_COMPLETED"},{"line_number":1606,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":1607,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3bdcca66_bbfa7f21","line":1604,"in_reply_to":"f521ad43_66397cac","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1667,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1668,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1669,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1670,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1671,"context_line":"        vnf_lcm_op_occs_id \u003d \u0027a9c36d21-21aa-4692-8922-7999bbcae08c\u0027"},{"line_number":1672,"context_line":"        mock_exec.return_value \u003d True"},{"line_number":1673,"context_line":"        mock_act.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"9e5cdfef_120463e5","line":1670,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1668,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1669,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1670,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1671,"context_line":"        vnf_lcm_op_occs_id \u003d \u0027a9c36d21-21aa-4692-8922-7999bbcae08c\u0027"},{"line_number":1672,"context_line":"        mock_exec.return_value \u003d True"},{"line_number":1673,"context_line":"        mock_act.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"861cf5b5_1958c562","line":1670,"in_reply_to":"1f5000d8_43a8a911","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1667,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1668,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1669,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1670,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1671,"context_line":"        vnf_lcm_op_occs_id \u003d \u0027a9c36d21-21aa-4692-8922-7999bbcae08c\u0027"},{"line_number":1672,"context_line":"        mock_exec.return_value \u003d True"},{"line_number":1673,"context_line":"        mock_act.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f5000d8_43a8a911","line":1670,"in_reply_to":"9e5cdfef_120463e5","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1811,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1812,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1813,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1814,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1815,"context_line":"        vnfd_yaml \u003d os.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":1816,"context_line":"                                                 \u0027../../etc/samples/etsi/nfv/\u0027"},{"line_number":1817,"context_line":"                                                 \u0027test_heal_grant_unit/\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"f6c102d6_ae7560a0","line":1814,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1811,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1812,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1813,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1814,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1815,"context_line":"        vnfd_yaml \u003d os.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":1816,"context_line":"                                                 \u0027../../etc/samples/etsi/nfv/\u0027"},{"line_number":1817,"context_line":"                                                 \u0027test_heal_grant_unit/\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"0feba567_b3fad81a","line":1814,"in_reply_to":"95934aa8_d37a5ea9","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1811,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":1812,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1813,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1814,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1815,"context_line":"        vnfd_yaml \u003d os.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":1816,"context_line":"                                                 \u0027../../etc/samples/etsi/nfv/\u0027"},{"line_number":1817,"context_line":"                                                 \u0027test_heal_grant_unit/\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"95934aa8_d37a5ea9","line":1814,"in_reply_to":"f6c102d6_ae7560a0","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1990,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1991,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1992,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":1993,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1994,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":1995,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"},{"line_number":1996,"context_line":"        vnf_lcm_op_occs_id \u003d \u0027a9c36d21-21aa-4692-8922-7999bbcae08c\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"0586c635_5e8de069","line":1993,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1990,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1991,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1992,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":1993,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1994,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":1995,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"},{"line_number":1996,"context_line":"        vnf_lcm_op_occs_id \u003d \u0027a9c36d21-21aa-4692-8922-7999bbcae08c\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"8991baa2_4a006c4d","line":1993,"in_reply_to":"0586c635_5e8de069","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1990,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":1991,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":1992,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":1993,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1994,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":1995,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"},{"line_number":1996,"context_line":"        vnf_lcm_op_occs_id \u003d \u0027a9c36d21-21aa-4692-8922-7999bbcae08c\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"2a266220_6f946a56","line":1993,"in_reply_to":"8991baa2_4a006c4d","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":2092,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":2093,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":2094,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":2095,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2096,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":2097,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":2098,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e5c520c7_386aa264","line":2095,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":2092,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":2093,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":2094,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":2095,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2096,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":2097,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":2098,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"}],"source_content_type":"text/x-python","patch_set":8,"id":"934ec37f_0b3178a3","line":2095,"in_reply_to":"99b56dc3_8049c8ed","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2092,"context_line":"        vnf_dict \u003d db_utils.get_dummy_vnf_etsi(instance_id\u003dself.instance_uuid,"},{"line_number":2093,"context_line":"                                       flavour\u003d\u0027simple\u0027)"},{"line_number":2094,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":2095,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2096,"context_line":"        vnfd_key \u003d \u0027vnfd_\u0027 + vnf_instance.instantiated_vnf_info.flavour_id"},{"line_number":2097,"context_line":"        vnfd_yaml \u003d vnf_dict[\u0027vnfd\u0027][\u0027attributes\u0027].get(vnfd_key, \u0027\u0027)"},{"line_number":2098,"context_line":"        mock_vnfd_dict.return_value \u003d yaml.safe_load(vnfd_yaml)"}],"source_content_type":"text/x-python","patch_set":8,"id":"99b56dc3_8049c8ed","line":2095,"in_reply_to":"e5c520c7_386aa264","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":2152,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":2153,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2154,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":2155,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":2156,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"74fdae91_a1013d91","line":2153,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":2152,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":2153,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2154,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":2155,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":2156,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ab1d21af_fee2dde4","line":2153,"in_reply_to":"74fdae91_a1013d91","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":2152,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":2153,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2154,"context_line":"        vnf_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.INITIAL"},{"line_number":2155,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":2156,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bed14019_e4909a3c","line":2153,"in_reply_to":"ab1d21af_fee2dde4","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":2183,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":2184,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2185,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":2186,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":2187,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"2aba463d_014c8821","line":2184,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":2183,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":2184,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2185,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":2186,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":2187,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"584cff59_f84d65ef","line":2184,"in_reply_to":"2aba463d_014c8821","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":2181,"context_line":""},{"line_number":2182,"context_line":"        heal_vnf_req \u003d objects.HealVnfRequest(cause\u003d\"healing request\")"},{"line_number":2183,"context_line":"        vnf_dict \u003d {\"fake\": \"fake_dict\"}"},{"line_number":2184,"context_line":"        vnf_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":2185,"context_line":"        vnf_lcm_op_occs_id \u003d uuidsentinel.vnf_lcm_op_occs_id"},{"line_number":2186,"context_line":"        self.conductor.heal(self.context, vnf_instance, vnf_dict,"},{"line_number":2187,"context_line":"                            heal_vnf_req, vnf_lcm_op_occs_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"8f77a512_838dfe6a","line":2184,"in_reply_to":"584cff59_f84d65ef","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"}],"tacker/tests/unit/vnfm/infra_drivers/openstack/test_openstack_driver.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1995,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":1996,"context_line":""},{"line_number":1997,"context_line":"        vnfd_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.PRE_VIM_CONTROL"},{"line_number":1998,"context_line":"        vnfd_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1999,"context_line":"        instance_id \u003d self.openstack.instantiate_vnf("},{"line_number":2000,"context_line":"            self.context, vnf_instance, vnfd_dict, vim_connection_info,"},{"line_number":2001,"context_line":"            inst_req_info, grant_response, self.plugin)"}],"source_content_type":"text/x-python","patch_set":8,"id":"14c8cfad_3ece4b8b","line":1998,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1995,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":1996,"context_line":""},{"line_number":1997,"context_line":"        vnfd_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.PRE_VIM_CONTROL"},{"line_number":1998,"context_line":"        vnfd_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1999,"context_line":"        instance_id \u003d self.openstack.instantiate_vnf("},{"line_number":2000,"context_line":"            self.context, vnf_instance, vnfd_dict, vim_connection_info,"},{"line_number":2001,"context_line":"            inst_req_info, grant_response, self.plugin)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9ebf7514_11a43b20","line":1998,"in_reply_to":"14c8cfad_3ece4b8b","updated":"2022-01-19 11:26:50.000000000","message":"I fixed it in patch 9.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1995,"context_line":"        vnf_instance \u003d fd_utils.get_vnf_instance_object()"},{"line_number":1996,"context_line":""},{"line_number":1997,"context_line":"        vnfd_dict[\u0027before_error_point\u0027] \u003d fields.ErrorPoint.PRE_VIM_CONTROL"},{"line_number":1998,"context_line":"        vnfd_dict[\u0027status\u0027] \u003d \u0027\u0027"},{"line_number":1999,"context_line":"        instance_id \u003d self.openstack.instantiate_vnf("},{"line_number":2000,"context_line":"            self.context, vnf_instance, vnfd_dict, vim_connection_info,"},{"line_number":2001,"context_line":"            inst_req_info, grant_response, self.plugin)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e72a314a_016f26dc","line":1998,"in_reply_to":"9ebf7514_11a43b20","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"                                    scale_vnf_request,"},{"line_number":1226,"context_line":"                                    vim_connection_info)"},{"line_number":1227,"context_line":"        else:"},{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"694b0862_56036a94","line":1228,"updated":"2021-12-12 23:23:17.000000000","message":"If I\u0027m right, this if block can be rewritten as follows \n\n```\n                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)\n                if not resource_changes:\n                    resource_changes \u003d self._scale_resource_update(\n                    ...\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"ee9d86a60e8f0626c1d384b3521ac3e0694b7eac","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"                                    scale_vnf_request,"},{"line_number":1226,"context_line":"                                    vim_connection_info)"},{"line_number":1227,"context_line":"        else:"},{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"8dac41b5_8ecabff2","line":1228,"in_reply_to":"307e0a2c_c8448c18","updated":"2021-12-13 09:26:31.000000000","message":"Callable in default value will be evaluated even if the key exists, thus my recommendation is not a good one. Please follow Hiromu\u0027s code sample.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"                                    scale_vnf_request,"},{"line_number":1226,"context_line":"                                    vim_connection_info)"},{"line_number":1227,"context_line":"        else:"},{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"307e0a2c_c8448c18","line":1228,"in_reply_to":"694b0862_56036a94","updated":"2021-12-13 09:07:21.000000000","message":"I think the below seems to be better for refactoring:\n\n```\n            resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027,\n                                            self._scale_resource_update(\n                                                context,\n                                                vnf_info,\n                                                vnf_instance,\n                                                scale_vnf_request,\n                                                vim_connection_info,\n                                                error\u003dTrue))\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"                                    scale_vnf_request,"},{"line_number":1226,"context_line":"                                    vim_connection_info)"},{"line_number":1227,"context_line":"        else:"},{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"9df7ab42_52cab2fe","line":1228,"in_reply_to":"8dac41b5_8ecabff2","updated":"2022-01-19 11:26:50.000000000","message":"I will fix it in the 9 patch.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"                                    scale_vnf_request,"},{"line_number":1226,"context_line":"                                    vim_connection_info)"},{"line_number":1227,"context_line":"        else:"},{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"b77c2099_bd63dd5b","line":1228,"in_reply_to":"9df7ab42_52cab2fe","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"},{"line_number":1232,"context_line":"                    self._scale_resource_update(context,"},{"line_number":1233,"context_line":"                                                vnf_info,"},{"line_number":1234,"context_line":"                                                vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"61f61384_b3dcadde","line":1231,"updated":"2021-12-12 23:23:17.000000000","message":"Could you please use parentheses instead of a backslash?","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"},{"line_number":1232,"context_line":"                    self._scale_resource_update(context,"},{"line_number":1233,"context_line":"                                                vnf_info,"},{"line_number":1234,"context_line":"                                                vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"cf5d9443_c748ceac","line":1231,"in_reply_to":"61f61384_b3dcadde","updated":"2022-01-19 11:26:50.000000000","message":"I changed the position of the line break and removed the backslash.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"            if vnf_info.get(\u0027resource_changes\u0027):"},{"line_number":1229,"context_line":"                resource_changes \u003d vnf_info.get(\u0027resource_changes\u0027)"},{"line_number":1230,"context_line":"            else:"},{"line_number":1231,"context_line":"                resource_changes \u003d \\"},{"line_number":1232,"context_line":"                    self._scale_resource_update(context,"},{"line_number":1233,"context_line":"                                                vnf_info,"},{"line_number":1234,"context_line":"                                                vnf_instance,"}],"source_content_type":"text/x-python","patch_set":8,"id":"13cb5a66_515562d1","line":1231,"in_reply_to":"cf5d9443_c748ceac","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"}],"tacker/vnfm/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":521,"context_line":"                                     base_hot_dict, nested_hot_dict,"},{"line_number":522,"context_line":"                                     hot_param_dict):"},{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_\" + vnf[\"id\"]}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"b7478f5f_10536cc6","line":524,"updated":"2021-09-30 08:57:15.000000000","message":"It\u0027s better to use `format()`, or you need to ensure `vnf[\"id\"]` is a string.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":521,"context_line":"                                     base_hot_dict, nested_hot_dict,"},{"line_number":522,"context_line":"                                     hot_param_dict):"},{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_\" + vnf[\"id\"]}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"8a744f45_f20ec858","line":524,"in_reply_to":"b7478f5f_10536cc6","updated":"2021-10-18 04:32:23.000000000","message":"I will modify it to `\"vnflcm_{}\".format(vnf[\"id\"])` in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_\" + vnf[\"id\"]}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":528,"context_line":"            stack \u003d {\u0027stack\u0027: {}}"},{"line_number":529,"context_line":"            stack[\u0027stack\u0027][\u0027id\u0027] \u003d stack_found.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"1288c69e_e2e0faba","line":526,"range":{"start_line":526,"start_character":31,"end_line":526,"end_character":43},"updated":"2021-09-30 08:57:15.000000000","message":"Why you use this method instead of `in` statement?","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_\" + vnf[\"id\"]}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":528,"context_line":"            stack \u003d {\u0027stack\u0027: {}}"},{"line_number":529,"context_line":"            stack[\u0027stack\u0027][\u0027id\u0027] \u003d stack_found.id"}],"source_content_type":"text/x-python","patch_set":3,"id":"71b7170d_b713f62d","line":526,"range":{"start_line":526,"start_character":31,"end_line":526,"end_character":43},"in_reply_to":"1288c69e_e2e0faba","updated":"2021-10-18 04:32:23.000000000","message":"I will change it to `\"status\" in vnf` in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":528,"context_line":"            stack \u003d {\u0027stack\u0027: {}}"},{"line_number":529,"context_line":"            stack[\u0027stack\u0027][\u0027id\u0027] \u003d stack_found.id"},{"line_number":530,"context_line":"            return stack"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        fields \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"87a9443d_7d656942","line":529,"range":{"start_line":528,"start_character":0,"end_line":529,"end_character":49},"updated":"2021-09-30 08:57:15.000000000","message":"No need to divide it into two lines. `stack \u003d {\u0027stack\u0027: {\u0027id\u0027: stack_found.id}}` is enough.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":528,"context_line":"            stack \u003d {\u0027stack\u0027: {}}"},{"line_number":529,"context_line":"            stack[\u0027stack\u0027][\u0027id\u0027] \u003d stack_found.id"},{"line_number":530,"context_line":"            return stack"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"        fields \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"2df83546_5e60efd5","line":529,"range":{"start_line":528,"start_character":0,"end_line":529,"end_character":49},"in_reply_to":"87a9443d_7d656942","updated":"2021-10-18 04:32:23.000000000","message":"I will modify it in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"14a4ad3e7332394975b29e61d510b66f79b1a169","unresolved":true,"context_lines":[{"line_number":564,"context_line":"    @log.log"},{"line_number":565,"context_line":"    def _create_stack(self, heatclient, vnf, fields):"},{"line_number":566,"context_line":"        # Find existing stack"},{"line_number":567,"context_line":"        filters \u003d {\"name\": \"vnflcm_\" + vnf[\"id\"]}"},{"line_number":568,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":569,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":570,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":571,"context_line":"            stack \u003d {\u0027stack\u0027: {}}"},{"line_number":572,"context_line":"            stack[\u0027stack\u0027][\u0027id\u0027] \u003d stack_found.id"},{"line_number":573,"context_line":"            return stack"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        if \u0027stack_name\u0027 not in fields:"},{"line_number":576,"context_line":"            name \u003d vnf[\u0027name\u0027].replace(\u0027 \u0027, \u0027_\u0027) + \u0027_\u0027 + vnf[\u0027id\u0027]"},{"line_number":577,"context_line":"            if vnf[\u0027attributes\u0027].get(\u0027failure_count\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"8a50d60f_d5b9780b","line":574,"range":{"start_line":567,"start_character":0,"end_line":574,"end_character":0},"updated":"2021-09-30 08:57:15.000000000","message":"ditto","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"3cde229eb4c9653bae698c47ac4af68dd50e1123","unresolved":true,"context_lines":[{"line_number":564,"context_line":"    @log.log"},{"line_number":565,"context_line":"    def _create_stack(self, heatclient, vnf, fields):"},{"line_number":566,"context_line":"        # Find existing stack"},{"line_number":567,"context_line":"        filters \u003d {\"name\": \"vnflcm_\" + vnf[\"id\"]}"},{"line_number":568,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":569,"context_line":"        if stack_found and vnf.__contains__(\"status\") and \\"},{"line_number":570,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":571,"context_line":"            stack \u003d {\u0027stack\u0027: {}}"},{"line_number":572,"context_line":"            stack[\u0027stack\u0027][\u0027id\u0027] \u003d stack_found.id"},{"line_number":573,"context_line":"            return stack"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        if \u0027stack_name\u0027 not in fields:"},{"line_number":576,"context_line":"            name \u003d vnf[\u0027name\u0027].replace(\u0027 \u0027, \u0027_\u0027) + \u0027_\u0027 + vnf[\u0027id\u0027]"},{"line_number":577,"context_line":"            if vnf[\u0027attributes\u0027].get(\u0027failure_count\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"871be1a8_3a2b2fe7","line":574,"range":{"start_line":567,"start_character":0,"end_line":574,"end_character":0},"in_reply_to":"8a50d60f_d5b9780b","updated":"2021-10-18 04:32:23.000000000","message":"I will modify it in patch 4.","commit_id":"6b523aebda1b8edde14c3c7bb86b908e22ebd6b9"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":521,"context_line":"                                     base_hot_dict, nested_hot_dict,"},{"line_number":522,"context_line":"                                     hot_param_dict):"},{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"af097fb3_7d7c1918","line":524,"updated":"2021-12-13 09:07:21.000000000","message":"I think f-literal string is better in this context:\n\n```\n        filters \u003d {\"name\": f\"vnflcm_{vnf[\u0027id\u0027]}\"}\n```","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":521,"context_line":"                                     base_hot_dict, nested_hot_dict,"},{"line_number":522,"context_line":"                                     hot_param_dict):"},{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"87c873cc_897bf688","line":524,"in_reply_to":"af097fb3_7d7c1918","updated":"2022-01-19 11:26:50.000000000","message":"I will fix it in the 9 patch.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":528,"context_line":"            stack \u003d {\u0027stack\u0027: {\u0027id\u0027: stack_found.id}}"},{"line_number":529,"context_line":"            return stack"}],"source_content_type":"text/x-python","patch_set":8,"id":"3e3bcb72_3d243624","line":526,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":528,"context_line":"            stack \u003d {\u0027stack\u0027: {\u0027id\u0027: stack_found.id}}"},{"line_number":529,"context_line":"            return stack"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc039929_c5835099","line":526,"in_reply_to":"3e3bcb72_3d243624","updated":"2022-01-19 11:26:50.000000000","message":"I deleted the backslashes here to make them one line.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        # Find existing stack"},{"line_number":524,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":525,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":526,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":527,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":528,"context_line":"            stack \u003d {\u0027stack\u0027: {\u0027id\u0027: stack_found.id}}"},{"line_number":529,"context_line":"            return stack"}],"source_content_type":"text/x-python","patch_set":8,"id":"4f17e85e_9af8fa9f","line":526,"in_reply_to":"fc039929_c5835099","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"eb6600b7447f36fd0ee6cf33ad05a54c247cd0e9","unresolved":true,"context_lines":[{"line_number":563,"context_line":"    @log.log"},{"line_number":564,"context_line":"    def _create_stack(self, heatclient, vnf, fields):"},{"line_number":565,"context_line":"        # Find existing stack"},{"line_number":566,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":567,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":568,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":569,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"4cf1eeaf_e31d1af8","line":566,"updated":"2021-12-13 09:07:21.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":563,"context_line":"    @log.log"},{"line_number":564,"context_line":"    def _create_stack(self, heatclient, vnf, fields):"},{"line_number":565,"context_line":"        # Find existing stack"},{"line_number":566,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":567,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":568,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":569,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"}],"source_content_type":"text/x-python","patch_set":8,"id":"dc958082_f019fb5d","line":566,"in_reply_to":"4cf1eeaf_e31d1af8","updated":"2022-01-19 11:26:50.000000000","message":"I will fix it in the 9 patch.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ffdef46ed3372d325603d60eb7b236f3028e866f","unresolved":true,"context_lines":[{"line_number":565,"context_line":"        # Find existing stack"},{"line_number":566,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":567,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":568,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":569,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":570,"context_line":"            stack \u003d {\u0027stack\u0027: {\u0027id\u0027: stack_found.id}}"},{"line_number":571,"context_line":"            return stack"}],"source_content_type":"text/x-python","patch_set":8,"id":"f12f7261_ee9a4a7c","line":568,"updated":"2021-12-12 23:23:17.000000000","message":"ditto","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2de754fab0cf6680b5380a54e9b2e143a94c2f49","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        # Find existing stack"},{"line_number":566,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":567,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":568,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":569,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":570,"context_line":"            stack \u003d {\u0027stack\u0027: {\u0027id\u0027: stack_found.id}}"},{"line_number":571,"context_line":"            return stack"}],"source_content_type":"text/x-python","patch_set":8,"id":"66ca2a31_a3732f23","line":568,"in_reply_to":"8bd50f28_82024238","updated":"2022-02-08 06:44:25.000000000","message":"Ack","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"},{"author":{"_account_id":33492,"name":"Yi Feng","email":"fengyi@fujitsu.com","username":"YiFeng"},"change_message_id":"cb4d3709adc010e1d3fe32c7786141a9d4b5a2f3","unresolved":true,"context_lines":[{"line_number":565,"context_line":"        # Find existing stack"},{"line_number":566,"context_line":"        filters \u003d {\"name\": \"vnflcm_{}\".format(vnf[\"id\"])}"},{"line_number":567,"context_line":"        stack_found \u003d heatclient.find_stack(**filters)"},{"line_number":568,"context_line":"        if stack_found and \"status\" in vnf and \\"},{"line_number":569,"context_line":"                vnf[\u0027status\u0027] \u003d\u003d \u0027ERROR\u0027:"},{"line_number":570,"context_line":"            stack \u003d {\u0027stack\u0027: {\u0027id\u0027: stack_found.id}}"},{"line_number":571,"context_line":"            return stack"}],"source_content_type":"text/x-python","patch_set":8,"id":"8bd50f28_82024238","line":568,"in_reply_to":"f12f7261_ee9a4a7c","updated":"2022-01-19 11:26:50.000000000","message":"I deleted the backslashes here to make them one line.","commit_id":"db33d3bb756223ee67fbfb0d963dca76b51f65ae"}]}