)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dae3a0f2e7e871667a9d7f1109d239d8968afad8","unresolved":true,"context_lines":[{"line_number":15,"context_line":"deleted."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Although legacy DB is going to be deleted, the patch is not merged at"},{"line_number":18,"context_line":"this time [1].  Thus, this patch modifies the conductor server to simply"},{"line_number":19,"context_line":"delete records from VNFD table."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://review.opendev.org/c/openstack/tacker/+/763955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da3c1c0b_bf9699c3","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":15},"updated":"2021-10-12 12:03:29.000000000","message":"nit: Could you remove this blank?","commit_id":"5352cb8d1de2b9ca974720f2eb666b6fe811e773"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c75e9f7b9da6c26f497543cae64a9f095c2465e8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"deleted."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Although legacy DB is going to be deleted, the patch is not merged at"},{"line_number":18,"context_line":"this time [1].  Thus, this patch modifies the conductor server to simply"},{"line_number":19,"context_line":"delete records from VNFD table."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://review.opendev.org/c/openstack/tacker/+/763955"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2d38d8f0_054049e0","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":15},"in_reply_to":"da3c1c0b_bf9699c3","updated":"2021-10-18 04:42:41.000000000","message":"I\u0027ve confirmed.","commit_id":"5352cb8d1de2b9ca974720f2eb666b6fe811e773"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dae3a0f2e7e871667a9d7f1109d239d8968afad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a125f3e_d36c9248","updated":"2021-10-12 12:03:29.000000000","message":"Thanks for your patch, almost LGTM. Please confirm my comments.","commit_id":"5352cb8d1de2b9ca974720f2eb666b6fe811e773"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b8170a01b9c5aec7f6e124377b64885993d5473b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1254dba_9182c8e2","updated":"2021-10-14 02:34:14.000000000","message":"Thank you for the review.","commit_id":"9484621f2549081302b08dbf9e8f6db7190cbfcf"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c75e9f7b9da6c26f497543cae64a9f095c2465e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ae171923_4a23bf00","updated":"2021-10-18 04:42:41.000000000","message":"Thanks for rework and sorry for late reply, LGTM.","commit_id":"9484621f2549081302b08dbf9e8f6db7190cbfcf"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"44937fb44cfd612b8fa2b2e64d01b1b566a3ff53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b3d403a2_1a541c9e","updated":"2022-03-07 05:37:59.000000000","message":"recheck","commit_id":"23d222e24d46b48545b75d7d56b1a400021377f4"}],"tacker/tests/unit/conductor/test_conductor_server.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"dae3a0f2e7e871667a9d7f1109d239d8968afad8","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        vnfd_attr \u003d objects.VnfdAttribute(self.context)"},{"line_number":263,"context_line":"        vnfd_attr.id \u003d uuidsentinel.vnfd_attr_id"},{"line_number":264,"context_line":"        vnfd_attr.vnfd_id \u003d vnfd_id"},{"line_number":265,"context_line":"        vnfd_attr.key \u003d \u0027dummy_key\u0027"},{"line_number":266,"context_line":"        vnfd_attr.value \u003d \u0027dummy_value\u0027"},{"line_number":267,"context_line":"        vnfd_attr.create()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # check Vnfd and VnfdAttribute were created"}],"source_content_type":"text/x-python","patch_set":3,"id":"b1c7f525_4a532d85","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":39},"updated":"2021-10-12 12:03:29.000000000","message":"Just a question, I think these key and value are optional parameters. \nvnfd has no optional parameter set. Is there any special meaning in setting it to vnfd_attr?","commit_id":"5352cb8d1de2b9ca974720f2eb666b6fe811e773"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b8170a01b9c5aec7f6e124377b64885993d5473b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        vnfd_attr \u003d objects.VnfdAttribute(self.context)"},{"line_number":263,"context_line":"        vnfd_attr.id \u003d uuidsentinel.vnfd_attr_id"},{"line_number":264,"context_line":"        vnfd_attr.vnfd_id \u003d vnfd_id"},{"line_number":265,"context_line":"        vnfd_attr.key \u003d \u0027dummy_key\u0027"},{"line_number":266,"context_line":"        vnfd_attr.value \u003d \u0027dummy_value\u0027"},{"line_number":267,"context_line":"        vnfd_attr.create()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # check Vnfd and VnfdAttribute were created"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2c41fa3_4c2670fb","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":39},"in_reply_to":"b1c7f525_4a532d85","updated":"2021-10-14 02:34:14.000000000","message":"As you mentioned, they\u0027re optional parameters in versionedobjects [1], but, in sqlalchemy model [2] the `key` field isn\u0027t optional.\n\nAfter reading your comment, I thought the object should follow the definition of the sqlalchemy model, so I\u0027ll change ``key`` field in the object from \"optional\" to \"required\" in patchset4. \n\n[1] https://opendev.org/openstack/tacker/src/branch/master/tacker/objects/vnfd_attribute.py#L84-L85\n[2] https://opendev.org/openstack/tacker/src/branch/master/tacker/db/vnfm/vnfm_db.py#L115-L116","commit_id":"5352cb8d1de2b9ca974720f2eb666b6fe811e773"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"c75e9f7b9da6c26f497543cae64a9f095c2465e8","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        vnfd_attr \u003d objects.VnfdAttribute(self.context)"},{"line_number":263,"context_line":"        vnfd_attr.id \u003d uuidsentinel.vnfd_attr_id"},{"line_number":264,"context_line":"        vnfd_attr.vnfd_id \u003d vnfd_id"},{"line_number":265,"context_line":"        vnfd_attr.key \u003d \u0027dummy_key\u0027"},{"line_number":266,"context_line":"        vnfd_attr.value \u003d \u0027dummy_value\u0027"},{"line_number":267,"context_line":"        vnfd_attr.create()"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # check Vnfd and VnfdAttribute were created"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c60b412_34e11836","line":266,"range":{"start_line":265,"start_character":0,"end_line":266,"end_character":39},"in_reply_to":"d2c41fa3_4c2670fb","updated":"2021-10-18 04:42:41.000000000","message":"I\u0027ve confirmed.","commit_id":"5352cb8d1de2b9ca974720f2eb666b6fe811e773"}]}