)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5867905f44f2c649fc455496b5533a3fe2df75a7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Manpreet Kaur \u003ckaurmanpreet2620@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-08 19:34:41 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tenant validation check between VIM and VNF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a validation check between a VIM and a VNF regarding"},{"line_number":10,"context_line":"tenant."},{"line_number":11,"context_line":"If tenants which a VIM and a VNF belong to are different each other,"},{"line_number":12,"context_line":"Tacker will stop instantiating the VNF."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"cbc6a6d3_10eb4f6c","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":7},"updated":"2022-02-09 18:09:03.000000000","message":"It\u0027s just a little bit unclear for me the purpose. You\u0027d better to say VNF should be instantiated by the VIM of the same tenant.","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"e593b3a6d9695111fce91ff7018885fd6ed0d4ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manpreet Kaur \u003ckaurmanpreet2620@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-08 19:34:41 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tenant validation check between VIM and VNF"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a validation check between a VIM and a VNF regarding"},{"line_number":10,"context_line":"tenant."},{"line_number":11,"context_line":"If tenants which a VIM and a VNF belong to are different each other,"},{"line_number":12,"context_line":"Tacker will stop instantiating the VNF."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"6835bbfa_8c612d53","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":7},"in_reply_to":"cbc6a6d3_10eb4f6c","updated":"2022-02-12 06:08:59.000000000","message":"Thanks for the suggestion, please find the revised commit message.","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32736,"name":"Wataru Juso","email":"w-juso@nec.com","username":"w-juso"},"change_message_id":"2be1d6a412342f5b6d9b7d74d42ab06a1b613cfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"762dade8_ce6441eb","updated":"2022-01-18 09:49:08.000000000","message":"recheck","commit_id":"6fb46461cc10149bc783102aa2038cbaad7c0828"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0387ad898170c2c71f79481bd6273807bbb6dc07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"94dd6931_19f9b217","updated":"2022-02-03 13:04:58.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1d30a2bba6a2f8ba7130aa204e239030c01ded86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"421ffe8c_a0270842","updated":"2022-02-07 17:19:52.000000000","message":"Thanks for your review comments, please find desired changes in Patchset 7.","commit_id":"e3f21a1a7035d2dd57a7918e111a9868a8fa35c6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5867905f44f2c649fc455496b5533a3fe2df75a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f69d2bf_d4f625e9","updated":"2022-02-09 18:09:03.000000000","message":"My comments are not so critical, but I\u0027d appreciate if you consider to revise. Thanks.","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"a070207cc982071f10bb2ce15a729774adbdbb12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"610c23b2_99f367ed","updated":"2022-02-09 00:06:09.000000000","message":"Thanks for review. ","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"e3aaab1d393afabfa9287012501255e6d6e2b52b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2bde1029_d98a2694","updated":"2022-02-08 16:56:54.000000000","message":"recheck","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"a19cebdc80f4302745fef879f7e0193f7a01ef45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"938a08d7_49813ba3","updated":"2022-02-16 13:17:22.000000000","message":"LGTM.","commit_id":"3443bf629945765b058253e714a90e72a04991f2"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"e593b3a6d9695111fce91ff7018885fd6ed0d4ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3aa1743e_677fa6fb","updated":"2022-02-12 06:08:59.000000000","message":"Thanks Ogawa san for your review comments, changes are incorporated in Patchset #9.","commit_id":"3443bf629945765b058253e714a90e72a04991f2"}],"tacker/common/exceptions.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"84b455b569ac08c6f5d2ec2cdc502b20c5474fbf","unresolved":true,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class TenantMatchFailure(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027The tenants which target VNF and its VIM belongs to are \u0027"},{"line_number":438,"context_line":"                \u0027different each other.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"f12a9675_c931ed6a","line":438,"range":{"start_line":438,"start_character":17,"end_line":438,"end_character":39},"updated":"2022-02-07 11:33:53.000000000","message":"Could we rephrase this exception message as \"The tenants which target VNF and its VIM belong to are different from each other.\"","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1d30a2bba6a2f8ba7130aa204e239030c01ded86","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class TenantMatchFailure(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027The tenants which target VNF and its VIM belongs to are \u0027"},{"line_number":438,"context_line":"                \u0027different each other.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"26cbf7d5_9e81e664","line":438,"range":{"start_line":438,"start_character":17,"end_line":438,"end_character":39},"in_reply_to":"f12a9675_c931ed6a","updated":"2022-02-07 17:19:52.000000000","message":"Reframe error message","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5867905f44f2c649fc455496b5533a3fe2df75a7","unresolved":true,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class TenantMatchFailure(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027The target VNF and its VIM belong to different \u0027"},{"line_number":438,"context_line":"                \u0027tenants.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fb5da8bd_74e1185f","line":438,"range":{"start_line":437,"start_character":4,"end_line":438,"end_character":27},"updated":"2022-02-09 18:09:03.000000000","message":"Why don\u0027t you tell the reason directly? The message should be like as \"The target VNF cannot be instantiated from a VIM of different tenant\". Please refer to messages in this file telling the reason directly.","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"e593b3a6d9695111fce91ff7018885fd6ed0d4ca","unresolved":false,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class TenantMatchFailure(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027The target VNF and its VIM belong to different \u0027"},{"line_number":438,"context_line":"                \u0027tenants.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"799becda_e02f3d39","line":438,"range":{"start_line":437,"start_character":4,"end_line":438,"end_character":27},"in_reply_to":"0322bec3_6ec351fe","updated":"2022-02-12 06:08:59.000000000","message":"Thanks, Ogawa san and Ueha san for your input.\nPlease find the revised exception message.","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"2356ac408e212ed80e1abcba57e27f81ae4cf41a","unresolved":true,"context_lines":[{"line_number":434,"context_line":""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"class TenantMatchFailure(TackerException):"},{"line_number":437,"context_line":"    message \u003d _(\u0027The target VNF and its VIM belong to different \u0027"},{"line_number":438,"context_line":"                \u0027tenants.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"0322bec3_6ec351fe","line":438,"range":{"start_line":437,"start_character":4,"end_line":438,"end_character":27},"in_reply_to":"fb5da8bd_74e1185f","updated":"2022-02-09 22:28:37.000000000","message":"I think that a similar Exception will be required like when the tenant is different between VNF package and VNF at the time of create VNF.\n\nI think it\u0027s better to specify the reason to name of Exception as well as write the reason directly like Ogawa-san\u0027s suggestion.\nOr, as a common Exception, specify operation and target (VIM or VNF Package or VNF ...) as format.","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"}],"tacker/tests/unit/conductor/fakes.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5867905f44f2c649fc455496b5533a3fe2df75a7","unresolved":true,"context_lines":[{"line_number":551,"context_line":"        body, None)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def get_vim_obj():"},{"line_number":555,"context_line":"    return {"},{"line_number":556,"context_line":"        \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":557,"context_line":"        \u0027vim_name\u0027: \u0027fake_vim\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9bb8cb4e_15795c58","line":554,"updated":"2022-02-09 18:09:03.000000000","message":"There similar functions in `tests/unit/vnflcm/fakes.py`. Why don\u0027t you consider to define a common function for the task? Or is it better to define them in each functinos?","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"e593b3a6d9695111fce91ff7018885fd6ed0d4ca","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        body, None)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"def get_vim_obj():"},{"line_number":555,"context_line":"    return {"},{"line_number":556,"context_line":"        \u0027vim_id\u0027: uuidsentinel.vim_id,"},{"line_number":557,"context_line":"        \u0027vim_name\u0027: \u0027fake_vim\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"2154e8c7_9bac3347","line":554,"in_reply_to":"9bb8cb4e_15795c58","updated":"2022-02-12 06:08:59.000000000","message":"In order to address the review comment, in Patchset #9 removed duplicate `get_vim_obj` function from `tacker/tests/unit/conductor/fakes.py` and instead used `get_dummy_openstack_vim_obj` method define in  `tests/unit/vnflcm/fakes.py`.","commit_id":"2e67def6a44eebc38fe04e2a2b8a448a4525c930"}],"tacker/tests/unit/vnflcm/test_vnflcm_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0387ad898170c2c71f79481bd6273807bbb6dc07","unresolved":true,"context_lines":[{"line_number":1908,"context_line":"            None]"},{"line_number":1909,"context_line":"        mock_vnf_package_vnfd.return_value \u003d fakes.return_vnf_package_vnfd()"},{"line_number":1910,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":1911,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":1912,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":1913,"context_line":"        driver.scale_vnf(self.context, vnf_info, vnf_instance,"},{"line_number":1914,"context_line":"            scale_vnf_request)"},{"line_number":1915,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"face0cac_ae8c4748","line":1912,"range":{"start_line":1911,"start_character":8,"end_line":1912,"end_character":48},"updated":"2022-02-03 13:04:58.000000000","message":"Why don\u0027t you change not to start a new line with a backslash?\nHow about replacing `get_dummy_kubernetes_vim_obj` with `get_dummy_k8s_vim_obj`?","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9c0e3452adaba618707d73425f2c9237eccd2d76","unresolved":true,"context_lines":[{"line_number":1908,"context_line":"            None]"},{"line_number":1909,"context_line":"        mock_vnf_package_vnfd.return_value \u003d fakes.return_vnf_package_vnfd()"},{"line_number":1910,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":1911,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":1912,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":1913,"context_line":"        driver.scale_vnf(self.context, vnf_info, vnf_instance,"},{"line_number":1914,"context_line":"            scale_vnf_request)"},{"line_number":1915,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"80defb31_cd051d3c","line":1912,"range":{"start_line":1911,"start_character":8,"end_line":1912,"end_character":48},"in_reply_to":"2c805895_b83cedbd","updated":"2022-02-08 13:55:59.000000000","message":"It is changed to `k8`.\nI think `k8s` is good.","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"a070207cc982071f10bb2ce15a729774adbdbb12","unresolved":false,"context_lines":[{"line_number":1908,"context_line":"            None]"},{"line_number":1909,"context_line":"        mock_vnf_package_vnfd.return_value \u003d fakes.return_vnf_package_vnfd()"},{"line_number":1910,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":1911,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":1912,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":1913,"context_line":"        driver.scale_vnf(self.context, vnf_info, vnf_instance,"},{"line_number":1914,"context_line":"            scale_vnf_request)"},{"line_number":1915,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"51f222fc_6ae2e06d","line":1912,"range":{"start_line":1911,"start_character":8,"end_line":1912,"end_character":48},"in_reply_to":"80defb31_cd051d3c","updated":"2022-02-09 00:06:09.000000000","message":"Sorry for the typo, incorporated changes in Patchset 8.","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1d30a2bba6a2f8ba7130aa204e239030c01ded86","unresolved":false,"context_lines":[{"line_number":1908,"context_line":"            None]"},{"line_number":1909,"context_line":"        mock_vnf_package_vnfd.return_value \u003d fakes.return_vnf_package_vnfd()"},{"line_number":1910,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":1911,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":1912,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":1913,"context_line":"        driver.scale_vnf(self.context, vnf_info, vnf_instance,"},{"line_number":1914,"context_line":"            scale_vnf_request)"},{"line_number":1915,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2c805895_b83cedbd","line":1912,"range":{"start_line":1911,"start_character":8,"end_line":1912,"end_character":48},"in_reply_to":"face0cac_ae8c4748","updated":"2022-02-07 17:19:52.000000000","message":"Done.\nThanks for your suggestion ueha san.","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0387ad898170c2c71f79481bd6273807bbb6dc07","unresolved":true,"context_lines":[{"line_number":1945,"context_line":"        mock_vnfd_dict.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":1946,"context_line":"        mock_yaml_safe_load.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":1947,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":1948,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":1949,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":1950,"context_line":"        driver.scale_vnf(self.context, vnf_info, vnf_instance,"},{"line_number":1951,"context_line":"            scale_vnf_request)"},{"line_number":1952,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d0bdde1b_24ba7093","line":1949,"range":{"start_line":1948,"start_character":8,"end_line":1949,"end_character":48},"updated":"2022-02-03 13:04:58.000000000","message":"ditto.","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1d30a2bba6a2f8ba7130aa204e239030c01ded86","unresolved":false,"context_lines":[{"line_number":1945,"context_line":"        mock_vnfd_dict.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":1946,"context_line":"        mock_yaml_safe_load.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":1947,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"},{"line_number":1948,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":1949,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":1950,"context_line":"        driver.scale_vnf(self.context, vnf_info, vnf_instance,"},{"line_number":1951,"context_line":"            scale_vnf_request)"},{"line_number":1952,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"51ee5863_c75a803b","line":1949,"range":{"start_line":1948,"start_character":8,"end_line":1949,"end_character":48},"in_reply_to":"d0bdde1b_24ba7093","updated":"2022-02-07 17:19:52.000000000","message":"Done","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0387ad898170c2c71f79481bd6273807bbb6dc07","unresolved":true,"context_lines":[{"line_number":2992,"context_line":"        mock_vnfd_dict.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":2993,"context_line":"        operation_params \u003d jsonutils.loads(vnf_lcm_op_occs.operation_params)"},{"line_number":2994,"context_line":"        mock_yaml_safe_load.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":2995,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":2996,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":2997,"context_line":""},{"line_number":2998,"context_line":"        self._mock_vnf_manager()"},{"line_number":2999,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"}],"source_content_type":"text/x-python","patch_set":6,"id":"901b3248_5973b079","line":2996,"range":{"start_line":2995,"start_character":8,"end_line":2996,"end_character":48},"updated":"2022-02-03 13:04:58.000000000","message":"ditto.","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1d30a2bba6a2f8ba7130aa204e239030c01ded86","unresolved":false,"context_lines":[{"line_number":2992,"context_line":"        mock_vnfd_dict.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":2993,"context_line":"        operation_params \u003d jsonutils.loads(vnf_lcm_op_occs.operation_params)"},{"line_number":2994,"context_line":"        mock_yaml_safe_load.return_value \u003d fakes.vnfd_dict_cnf()"},{"line_number":2995,"context_line":"        self.vim_client.get_vim.return_value \u003d \\"},{"line_number":2996,"context_line":"            fakes.get_dummy_kubernetes_vim_obj()"},{"line_number":2997,"context_line":""},{"line_number":2998,"context_line":"        self._mock_vnf_manager()"},{"line_number":2999,"context_line":"        driver \u003d vnflcm_driver.VnfLcmDriver()"}],"source_content_type":"text/x-python","patch_set":6,"id":"ad86d214_e9d5b6a4","line":2996,"range":{"start_line":2995,"start_character":8,"end_line":2996,"end_character":48},"in_reply_to":"901b3248_5973b079","updated":"2022-02-07 17:19:52.000000000","message":"Done","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"84b455b569ac08c6f5d2ec2cdc502b20c5474fbf","unresolved":true,"context_lines":[{"line_number":515,"context_line":"                instantiate_vnf_req.vim_connection_info)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if vim_info[\u0027tenant_id\u0027] !\u003d vnf_instance.tenant_id:"},{"line_number":518,"context_line":"            LOG.error(\u0027The tenants which target VNF and its VIM belongs to \u0027"},{"line_number":519,"context_line":"                      \u0027are different each other.\u0027)"},{"line_number":520,"context_line":"            raise exceptions.TenantMatchFailure()"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("}],"source_content_type":"text/x-python","patch_set":6,"id":"1bc1abda_32417678","line":519,"range":{"start_line":518,"start_character":23,"end_line":519,"end_character":47},"updated":"2022-02-07 11:33:53.000000000","message":"Could we rephrase this error message as \"The tenants which target VNF and its VIM belong to are different from each other.\"","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1d30a2bba6a2f8ba7130aa204e239030c01ded86","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                instantiate_vnf_req.vim_connection_info)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if vim_info[\u0027tenant_id\u0027] !\u003d vnf_instance.tenant_id:"},{"line_number":518,"context_line":"            LOG.error(\u0027The tenants which target VNF and its VIM belongs to \u0027"},{"line_number":519,"context_line":"                      \u0027are different each other.\u0027)"},{"line_number":520,"context_line":"            raise exceptions.TenantMatchFailure()"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("}],"source_content_type":"text/x-python","patch_set":6,"id":"0a22e105_205b9dbb","line":519,"range":{"start_line":518,"start_character":23,"end_line":519,"end_character":47},"in_reply_to":"1bc1abda_32417678","updated":"2022-02-07 17:19:52.000000000","message":"Done.\nReframe error message.","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"0387ad898170c2c71f79481bd6273807bbb6dc07","unresolved":true,"context_lines":[{"line_number":515,"context_line":"                instantiate_vnf_req.vim_connection_info)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if vim_info[\u0027tenant_id\u0027] !\u003d vnf_instance.tenant_id:"},{"line_number":518,"context_line":"            LOG.error(\u0027The tenants which target VNF and its VIM belongs to \u0027"},{"line_number":519,"context_line":"                      \u0027are different each other.\u0027)"},{"line_number":520,"context_line":"            raise exceptions.TenantMatchFailure()"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("},{"line_number":523,"context_line":"            vim_info, context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dd19a344_ba62d491","line":520,"range":{"start_line":518,"start_character":0,"end_line":520,"end_character":49},"updated":"2022-02-03 13:04:58.000000000","message":"There seems to be no Unit Test to check the this added route.\nCould you add it?","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"1d30a2bba6a2f8ba7130aa204e239030c01ded86","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                instantiate_vnf_req.vim_connection_info)"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"        if vim_info[\u0027tenant_id\u0027] !\u003d vnf_instance.tenant_id:"},{"line_number":518,"context_line":"            LOG.error(\u0027The tenants which target VNF and its VIM belongs to \u0027"},{"line_number":519,"context_line":"                      \u0027are different each other.\u0027)"},{"line_number":520,"context_line":"            raise exceptions.TenantMatchFailure()"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"        vim_connection_info \u003d objects.VimConnectionInfo.obj_from_primitive("},{"line_number":523,"context_line":"            vim_info, context)"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d2ff1bc_3310921a","line":520,"range":{"start_line":518,"start_character":0,"end_line":520,"end_character":49},"in_reply_to":"dd19a344_ba62d491","updated":"2022-02-07 17:19:52.000000000","message":"Done","commit_id":"a7aee44d13491fbefacbece33d1a02e787710ae6"}]}