)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"90728e5ebcbc0760eef0a9fd6176481c5fab692f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Previously, scaleLevel was updated twice, before invoke scale_end"},{"line_number":13,"context_line":"and after run scale_end, but it is inappropriate to update scaleLevel"},{"line_number":14,"context_line":"before invoke scale_end because it may cause scale_end to fail."},{"line_number":15,"context_line":"Therefore , in my proposal, change it to update only after running"},{"line_number":16,"context_line":"scale_end. And the method of updating scaleLevel was incorrect, so"},{"line_number":17,"context_line":"fixes it."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"025ea163_681710c0","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":10},"updated":"2021-10-28 13:20:15.000000000","message":"nit: Could you remove this blank character?","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"44a25610366b2c6670039d3872a6d6775fd5e31e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Previously, scaleLevel was updated twice, before invoke scale_end"},{"line_number":13,"context_line":"and after run scale_end, but it is inappropriate to update scaleLevel"},{"line_number":14,"context_line":"before invoke scale_end because it may cause scale_end to fail."},{"line_number":15,"context_line":"Therefore , in my proposal, change it to update only after running"},{"line_number":16,"context_line":"scale_end. And the method of updating scaleLevel was incorrect, so"},{"line_number":17,"context_line":"fixes it."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4e0b13ed_1611d0e0","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":10},"in_reply_to":"025ea163_681710c0","updated":"2021-11-01 05:53:53.000000000","message":"I fixed it in the PatchSet 4.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"031f355856109e040cbeecc6d141c67a7554b0fe","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Previously, scaleLevel was updated twice, before invoke scale_end"},{"line_number":13,"context_line":"and after run scale_end, but it is inappropriate to update scaleLevel"},{"line_number":14,"context_line":"before invoke scale_end because it may cause scale_end to fail."},{"line_number":15,"context_line":"Therefore , in my proposal, change it to update only after running"},{"line_number":16,"context_line":"scale_end. And the method of updating scaleLevel was incorrect, so"},{"line_number":17,"context_line":"fixes it."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"44dd8705_3885e484","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":10},"in_reply_to":"4e0b13ed_1611d0e0","updated":"2021-11-02 09:53:56.000000000","message":"I\u0027ve confirmed.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"f83d3566958fb475b3c569be75588fc7e8ce99df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6e9adf16_6ca5cf10","updated":"2021-10-25 06:57:34.000000000","message":"Thanks for the patch, could you please share testing strategy, how to validate these code changes.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"90728e5ebcbc0760eef0a9fd6176481c5fab692f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"670c6168_b4bdba95","updated":"2021-10-28 13:20:15.000000000","message":"Thanks for your patch, could you confirm my comments?","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"d4e5637820e5e6246104f108ea0f4e4f451800f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d66dc05_b8de0129","updated":"2021-10-25 00:03:48.000000000","message":"recheck","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"c7b619f706f273fdfb7b5afb51e51226c39ded55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e401a051_ccc5c5ca","in_reply_to":"6e9adf16_6ca5cf10","updated":"2021-10-29 04:17:32.000000000","message":"Thank you for your comment, and I\u0027m sorry for the late reply.\nTo cause this issue, I need to cause the ScaleOut operation fail at \"error_point\u003d6\" or \"error_point\u003d7\". So I made it fail in a MgmtDriver called from the scale_end[1].\n\nA simple explanation of the contents is as follows. However, I think it\u0027s hard to know what you are without sample. Therefore I have prepared a sample patch[2] to cause this issue. Please refer to the sample patch[2] for more information.\n\n\n\u003cExplanation of the setting to make it fail\u003e\n\nThe scale_end function of the MgmtDriver implement as follows.\n\n\u003ce.g. fail_mgmt.py\u003e\n---\n    def scale_end(self, context, vnf_instance, scale_vnf_request, grant,\n                  grant_request, **kwargs):\n        raise exceptions.MgmtDriverOtherError(\n            error_message\u003d\"Failed to scale_end\")\n---\nReference to [3] for a sample MgmtDriver.\n\nAnd, add the node_templates.VNF.interface and artifacts in a VNFD as follows.\n---\n  node_templates:\n    VNF:\n      type: company.provider.VNF\n      properties:\n        flavour_description: A simple flavour\n      interfaces:\n        Vnflcm:\n          instantiate_end:\n          terminate_end: []\n          heal_start: []\n          heal_end: []\n          scale_start: []\n          scale_end:\n            implementation: mgmt-drivers-fail                    \u003c- add\n      artifacts:                                                 \u003c-\n        mgmt-drivers-fail:                                       \u003c-\n          description: Management driver for kubernetes cluster  \u003c-\n          type: tosca.artifacts.Implementation.Python            \u003c-\n          file: Scripts/fail_mgmt.py                             \u003c-\n---\nNow, the MgmtDriver runs after VNF scales.\n\nMoreover, the configuration of Tacker must be set up in advance.\nCould you please reference to [4] for the tacker configuration settings to the MgmtDriver.\n\n[1] https://github.com/openstack/tacker/blob/master/tacker/vnflcm/vnflcm_driver.py#L972-L979\n[2] https://review.opendev.org/c/openstack/tacker/+/815612\n[3] https://github.com/openstack/tacker/blob/master/samples/mgmt_driver/kubernetes_mgmt.py\n[4] https://docs.openstack.org/tacker/wallaby/user/mgmt_driver_deploy_k8s_usage_guide.html#set-tacker-configuration","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"44a25610366b2c6670039d3872a6d6775fd5e31e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"269f5cd0_b0774ad0","updated":"2021-11-01 05:53:53.000000000","message":"Thank you for your comments. I\u0027ve fixed it, so could you please confirm it.","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"031f355856109e040cbeecc6d141c67a7554b0fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99321e7e_dd019c40","updated":"2021-11-02 09:53:56.000000000","message":"Thanks for rework, please confirm additional comments.","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9dcb031061c405d7be0bc893f3ff748930fdb6bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"42ca3347_555b139b","updated":"2021-11-24 11:51:06.000000000","message":"Thanks for your rework! LGTM.","commit_id":"d13e47315bd6c267543765220667a7bd9e0b4390"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"cf017f56de578bbea83574646cf270799b59a035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de1fe5d0_922ea894","updated":"2021-11-24 07:48:33.000000000","message":"recheck","commit_id":"d13e47315bd6c267543765220667a7bd9e0b4390"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"89ab45e526c4714bb5aff5ef81ccce481cc746a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d3bdaa13_e17b1c1c","updated":"2021-11-08 00:02:03.000000000","message":"recheck\n\nBlazar\u0027s failure during executing devstack may have be fixed in the patch below.\nhttps://review.opendev.org/c/openstack/blazar/+/816627","commit_id":"d13e47315bd6c267543765220667a7bd9e0b4390"},{"author":{"_account_id":33292,"name":"Masaki UENO","email":"masaki.ueno.up@hco.ntt.co.jp","username":"masaki-ueno"},"change_message_id":"c4bbb3793bbcc9049a577e088ec01706e909956a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"af7641d1_c551cdd4","updated":"2021-12-13 09:08:13.000000000","message":"LGTM","commit_id":"4fbd5b4c024a5fa24c263953e58103bf0ec53498"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"d5d8d0683772bb45b3328ceb7c3775fd4e8fb89c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7877db9f_75adb401","updated":"2021-12-06 01:09:34.000000000","message":"Thank you for the patch.\n\nPlease kindly find my comments.","commit_id":"4fbd5b4c024a5fa24c263953e58103bf0ec53498"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"57fc1026fabf5f5584e560cfe71983a093919cce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0c9e459d_02f62f84","updated":"2021-11-29 00:39:15.000000000","message":"recheck","commit_id":"4fbd5b4c024a5fa24c263953e58103bf0ec53498"}],"tacker/vnflcm/vnflcm_driver.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"90728e5ebcbc0760eef0a9fd6176481c5fab692f","unresolved":true,"context_lines":[{"line_number":978,"context_line":"                        grant\u003dvnf_info.get(\u0027grant\u0027), grant_request\u003dNone,"},{"line_number":979,"context_line":"                        **kwargs)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        for scale in vnf_instance.instantiated_vnf_info.scale_status:"},{"line_number":982,"context_line":"            scale.scale_level \u003d vnf_info[\u0027after_scale_level\u0027]"},{"line_number":983,"context_line":"        if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":984,"context_line":"            # NOTE(ueha): The logic of Scale for OpenStack VIM is widely hard"},{"line_number":985,"context_line":"            # coded with `vnf_info`. This dependency is to be refactored in"}],"source_content_type":"text/x-python","patch_set":3,"id":"997c7a52_e9516e76","line":982,"range":{"start_line":981,"start_character":0,"end_line":982,"end_character":61},"updated":"2021-10-28 13:20:15.000000000","message":"I think only the scale_level of entries with matching aspect_id should be updated.\nLike https://review.opendev.org/c/openstack/tacker/+/814089/3/tacker/vnflcm/vnflcm_driver.py#1039.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9dcb031061c405d7be0bc893f3ff748930fdb6bb","unresolved":false,"context_lines":[{"line_number":978,"context_line":"                        grant\u003dvnf_info.get(\u0027grant\u0027), grant_request\u003dNone,"},{"line_number":979,"context_line":"                        **kwargs)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        for scale in vnf_instance.instantiated_vnf_info.scale_status:"},{"line_number":982,"context_line":"            scale.scale_level \u003d vnf_info[\u0027after_scale_level\u0027]"},{"line_number":983,"context_line":"        if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":984,"context_line":"            # NOTE(ueha): The logic of Scale for OpenStack VIM is widely hard"},{"line_number":985,"context_line":"            # coded with `vnf_info`. This dependency is to be refactored in"}],"source_content_type":"text/x-python","patch_set":3,"id":"0010a3e9_be95fd88","line":982,"range":{"start_line":981,"start_character":0,"end_line":982,"end_character":61},"in_reply_to":"72a6fafd_12f5eccb","updated":"2021-11-24 11:51:06.000000000","message":"I\u0027ve confirmed.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"44a25610366b2c6670039d3872a6d6775fd5e31e","unresolved":true,"context_lines":[{"line_number":978,"context_line":"                        grant\u003dvnf_info.get(\u0027grant\u0027), grant_request\u003dNone,"},{"line_number":979,"context_line":"                        **kwargs)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        for scale in vnf_instance.instantiated_vnf_info.scale_status:"},{"line_number":982,"context_line":"            scale.scale_level \u003d vnf_info[\u0027after_scale_level\u0027]"},{"line_number":983,"context_line":"        if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":984,"context_line":"            # NOTE(ueha): The logic of Scale for OpenStack VIM is widely hard"},{"line_number":985,"context_line":"            # coded with `vnf_info`. This dependency is to be refactored in"}],"source_content_type":"text/x-python","patch_set":3,"id":"a3282532_be8cf98c","line":982,"range":{"start_line":981,"start_character":0,"end_line":982,"end_character":61},"in_reply_to":"997c7a52_e9516e76","updated":"2021-11-01 05:53:53.000000000","message":"Thanks, your comment is correct. So I added a condition that aspect_id matches in the PatchSet 4.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"031f355856109e040cbeecc6d141c67a7554b0fe","unresolved":true,"context_lines":[{"line_number":978,"context_line":"                        grant\u003dvnf_info.get(\u0027grant\u0027), grant_request\u003dNone,"},{"line_number":979,"context_line":"                        **kwargs)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        for scale in vnf_instance.instantiated_vnf_info.scale_status:"},{"line_number":982,"context_line":"            scale.scale_level \u003d vnf_info[\u0027after_scale_level\u0027]"},{"line_number":983,"context_line":"        if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":984,"context_line":"            # NOTE(ueha): The logic of Scale for OpenStack VIM is widely hard"},{"line_number":985,"context_line":"            # coded with `vnf_info`. This dependency is to be refactored in"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea630e65_a840675e","line":982,"range":{"start_line":981,"start_character":0,"end_line":982,"end_character":61},"in_reply_to":"a3282532_be8cf98c","updated":"2021-11-02 09:53:56.000000000","message":"Why don\u0027t you add \"break\" after setting scale_level?","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"5e1fe1389c934d001902932e27e99eb9d9be2bc1","unresolved":true,"context_lines":[{"line_number":978,"context_line":"                        grant\u003dvnf_info.get(\u0027grant\u0027), grant_request\u003dNone,"},{"line_number":979,"context_line":"                        **kwargs)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"        for scale in vnf_instance.instantiated_vnf_info.scale_status:"},{"line_number":982,"context_line":"            scale.scale_level \u003d vnf_info[\u0027after_scale_level\u0027]"},{"line_number":983,"context_line":"        if vim_connection_info.vim_type !\u003d \u0027kubernetes\u0027:"},{"line_number":984,"context_line":"            # NOTE(ueha): The logic of Scale for OpenStack VIM is widely hard"},{"line_number":985,"context_line":"            # coded with `vnf_info`. This dependency is to be refactored in"}],"source_content_type":"text/x-python","patch_set":3,"id":"72a6fafd_12f5eccb","line":982,"range":{"start_line":981,"start_character":0,"end_line":982,"end_character":61},"in_reply_to":"ea630e65_a840675e","updated":"2021-11-24 10:05:02.000000000","message":"Thank you for your suggestion. I added a \"break\" in the PatchSet 5.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"90728e5ebcbc0760eef0a9fd6176481c5fab692f","unresolved":true,"context_lines":[{"line_number":1224,"context_line":"                                    vnf_instance,"},{"line_number":1225,"context_line":"                                    scale_vnf_request,"},{"line_number":1226,"context_line":"                                    vim_connection_info,"},{"line_number":1227,"context_line":"                                    error\u003dTrue)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"        vnf_info[\u0027current_error_point\u0027] \u003d EP.INTERNAL_PROCESSING"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2356017b_1c0484dd","line":1227,"range":{"start_line":1227,"start_character":36,"end_line":1227,"end_character":46},"updated":"2021-10-28 13:20:15.000000000","message":"It is unkind to set \"error\u003dTrue\" without any explanation since it is not actually an error.\nWhy don\u0027t you write a note explaining why you set \"error\u003dTrue\"?","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"44a25610366b2c6670039d3872a6d6775fd5e31e","unresolved":true,"context_lines":[{"line_number":1224,"context_line":"                                    vnf_instance,"},{"line_number":1225,"context_line":"                                    scale_vnf_request,"},{"line_number":1226,"context_line":"                                    vim_connection_info,"},{"line_number":1227,"context_line":"                                    error\u003dTrue)"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"        vnf_info[\u0027current_error_point\u0027] \u003d EP.INTERNAL_PROCESSING"},{"line_number":1230,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4dc06e_fd60405d","line":1227,"range":{"start_line":1227,"start_character":36,"end_line":1227,"end_character":46},"in_reply_to":"2356017b_1c0484dd","updated":"2021-11-01 05:53:53.000000000","message":"Thank you for your advice. I added a note about adding `error\u003dTrue` in the PatchSet 4.","commit_id":"3785389b214abe8f047dd9592cdfc13b1f05ba88"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"031f355856109e040cbeecc6d141c67a7554b0fe","unresolved":true,"context_lines":[{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"            # NOTE(horie): `error\u003dTrue` is set in the argument, but it is not"},{"line_number":1226,"context_line":"            # actually an error. However, if it is not set to `error\u003dTrue`,"},{"line_number":1227,"context_line":"            # `scale_leve` will be updated immediately after the VNF scale,"},{"line_number":1228,"context_line":"            # and `scale_leve` will remain updated even if postamble fails."},{"line_number":1229,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1230,"context_line":"                                    vnf_instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a65201f2_78e6100a","line":1227,"range":{"start_line":1227,"start_character":15,"end_line":1227,"end_character":25},"updated":"2021-11-02 09:53:56.000000000","message":"typo: scale_level","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9dcb031061c405d7be0bc893f3ff748930fdb6bb","unresolved":false,"context_lines":[{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"            # NOTE(horie): `error\u003dTrue` is set in the argument, but it is not"},{"line_number":1226,"context_line":"            # actually an error. However, if it is not set to `error\u003dTrue`,"},{"line_number":1227,"context_line":"            # `scale_leve` will be updated immediately after the VNF scale,"},{"line_number":1228,"context_line":"            # and `scale_leve` will remain updated even if postamble fails."},{"line_number":1229,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1230,"context_line":"                                    vnf_instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7813faf8_e8a9c3f1","line":1227,"range":{"start_line":1227,"start_character":15,"end_line":1227,"end_character":25},"in_reply_to":"085af330_e095b907","updated":"2021-11-24 11:51:06.000000000","message":"I\u0027ve confirmed.","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"5e1fe1389c934d001902932e27e99eb9d9be2bc1","unresolved":true,"context_lines":[{"line_number":1224,"context_line":""},{"line_number":1225,"context_line":"            # NOTE(horie): `error\u003dTrue` is set in the argument, but it is not"},{"line_number":1226,"context_line":"            # actually an error. However, if it is not set to `error\u003dTrue`,"},{"line_number":1227,"context_line":"            # `scale_leve` will be updated immediately after the VNF scale,"},{"line_number":1228,"context_line":"            # and `scale_leve` will remain updated even if postamble fails."},{"line_number":1229,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1230,"context_line":"                                    vnf_instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"085af330_e095b907","line":1227,"range":{"start_line":1227,"start_character":15,"end_line":1227,"end_character":25},"in_reply_to":"a65201f2_78e6100a","updated":"2021-11-24 10:05:02.000000000","message":"I fixed it in the PatchSet 5.","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"031f355856109e040cbeecc6d141c67a7554b0fe","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"            # NOTE(horie): `error\u003dTrue` is set in the argument, but it is not"},{"line_number":1226,"context_line":"            # actually an error. However, if it is not set to `error\u003dTrue`,"},{"line_number":1227,"context_line":"            # `scale_leve` will be updated immediately after the VNF scale,"},{"line_number":1228,"context_line":"            # and `scale_leve` will remain updated even if postamble fails."},{"line_number":1229,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1230,"context_line":"                                    vnf_instance,"},{"line_number":1231,"context_line":"                                    scale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fbc397fc_167d5c44","line":1228,"range":{"start_line":1228,"start_character":19,"end_line":1228,"end_character":29},"updated":"2021-11-02 09:53:56.000000000","message":"ditto.","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"9dcb031061c405d7be0bc893f3ff748930fdb6bb","unresolved":false,"context_lines":[{"line_number":1225,"context_line":"            # NOTE(horie): `error\u003dTrue` is set in the argument, but it is not"},{"line_number":1226,"context_line":"            # actually an error. However, if it is not set to `error\u003dTrue`,"},{"line_number":1227,"context_line":"            # `scale_leve` will be updated immediately after the VNF scale,"},{"line_number":1228,"context_line":"            # and `scale_leve` will remain updated even if postamble fails."},{"line_number":1229,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1230,"context_line":"                                    vnf_instance,"},{"line_number":1231,"context_line":"                                    scale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7359360_739e4005","line":1228,"range":{"start_line":1228,"start_character":19,"end_line":1228,"end_character":29},"in_reply_to":"eeecef97_ed95a70e","updated":"2021-11-24 11:51:06.000000000","message":"I\u0027ve confirmed.","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":31730,"name":"Naoaki Horie","email":"naoaki.h.opst@gmail.com","username":"naoaki-horie"},"change_message_id":"5e1fe1389c934d001902932e27e99eb9d9be2bc1","unresolved":true,"context_lines":[{"line_number":1225,"context_line":"            # NOTE(horie): `error\u003dTrue` is set in the argument, but it is not"},{"line_number":1226,"context_line":"            # actually an error. However, if it is not set to `error\u003dTrue`,"},{"line_number":1227,"context_line":"            # `scale_leve` will be updated immediately after the VNF scale,"},{"line_number":1228,"context_line":"            # and `scale_leve` will remain updated even if postamble fails."},{"line_number":1229,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1230,"context_line":"                                    vnf_instance,"},{"line_number":1231,"context_line":"                                    scale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":4,"id":"eeecef97_ed95a70e","line":1228,"range":{"start_line":1228,"start_character":19,"end_line":1228,"end_character":29},"in_reply_to":"fbc397fc_167d5c44","updated":"2021-11-24 10:05:02.000000000","message":"I fixed it in the PatchSet 5.","commit_id":"00f76e53342f184c97853744536d4da0a8c34033"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"dba239e85dae9a839b6640898eca5f1c82376db7","unresolved":true,"context_lines":[{"line_number":1223,"context_line":"                            vim_connection_info,"},{"line_number":1224,"context_line":"                            scale_name_list, grp_id)"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"            # NOTE(horie): `error\u003dTrue` is set in the argument, but it is not"},{"line_number":1227,"context_line":"            # actually an error. However, if it is not set to `error\u003dTrue`,"},{"line_number":1228,"context_line":"            # `scale_level` will be updated immediately after the VNF scale,"},{"line_number":1229,"context_line":"            # and `scale_level` will remain updated even if postamble fails."},{"line_number":1230,"context_line":"            resource_changes \u003d self._scale_resource_update(context, vnf_info,"},{"line_number":1231,"context_line":"                                    vnf_instance,"},{"line_number":1232,"context_line":"                                    scale_vnf_request,"}],"source_content_type":"text/x-python","patch_set":5,"id":"735239db_3f99d29d","line":1229,"range":{"start_line":1226,"start_character":0,"end_line":1229,"end_character":76},"updated":"2021-11-24 18:42:50.000000000","message":"Umm... I think it\u0027s more helpful to change the name of arg `error` and add a docstring to the function `_scale_resource_update` itself instead of adding this NOTE.","commit_id":"d13e47315bd6c267543765220667a7bd9e0b4390"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"d5d8d0683772bb45b3328ceb7c3775fd4e8fb89c","unresolved":true,"context_lines":[{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"    def _scale_resource_update(self, context, vnf_info, vnf_instance,"},{"line_number":1025,"context_line":"                               scale_vnf_request, vim_connection_info,"},{"line_number":1026,"context_line":"                               hold_scale_status\u003dFalse):"},{"line_number":1027,"context_line":"        \"\"\"Update instantiatedVnfInfo after scaling"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        Update about VNFC/VirtualLink/VirtualStorage instances for"}],"source_content_type":"text/x-python","patch_set":6,"id":"1c2bb040_700b106a","line":1026,"updated":"2021-12-06 01:09:34.000000000","message":"I\u0027m just curious. Why is the ``hold_scale_status`` argument necessary, even though it is inappropriate to update scaleLevel before invoke scale_end.","commit_id":"4fbd5b4c024a5fa24c263953e58103bf0ec53498"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"d5d8d0683772bb45b3328ceb7c3775fd4e8fb89c","unresolved":true,"context_lines":[{"line_number":1036,"context_line":"        :param scale_vnf_request: Object of ScaleVnfRequest"},{"line_number":1037,"context_line":"        :param vim_connection_info: Credentials to initialize Vim connection"},{"line_number":1038,"context_line":"        :param hold_scale_status: True if do not change the scale status"},{"line_number":1039,"context_line":"        :return: dict(Resources that have been changed after scaling)"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"        NOTE: The default for \u0027hold_scale_status\u0027 is False."},{"line_number":1042,"context_line":"              If it is set to `hold_scale_status\u003dFalse`, `scale_level` will"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a5a8225_d14dbe88","line":1039,"updated":"2021-12-06 01:09:34.000000000","message":"I\u0027d like to suggest you to follow the styles defined in the following document if you prefer the rst style docstring.\n\nhttps://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#info-field-lists\n\nFor example, you can write this line like the following.\n\n```\n        :return: Resources that have been changed after scaling\n        :rtype: dict\n```","commit_id":"4fbd5b4c024a5fa24c263953e58103bf0ec53498"}]}