)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a5e7db6facdf753d63adc6f0e1a808366518eb6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"63a4b6a7_1d6acf36","updated":"2021-10-21 00:59:27.000000000","message":"recheck","commit_id":"5837c123debc56b7b5a1a83761c2db997616633c"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"26adfbfe67a0d59f12cdc9e3274e5b5203f648d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"733b54d9_b05a3a28","updated":"2022-01-27 08:49:18.000000000","message":"Hi Ogawa san,\n\nThis patch is in WIP state but I have a suggestion if you could look into it.\nThanks.","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"900ccfc5c4ff43f35c91f3cf243b212d620a10ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"33597a7d_ef7fe917","updated":"2022-02-03 02:49:01.000000000","message":"Manpreet,\nIt might take time to fix the error on this update. It\u0027s OK to change the names as you suggested before merging this patch if you\u0027d like to do so. I can rebase after that.\n\nThanks","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e71fdcf97a79a084b13439824d691c1397d78c2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d23f93fc_72715646","updated":"2022-02-02 18:30:27.000000000","message":"Sorry for the late reply.","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"a3ca5e1394e5fcf7d68f0fce1f885bab09853e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8c415de4_e119487d","in_reply_to":"33597a7d_ef7fe917","updated":"2022-02-04 02:21:29.000000000","message":"Sure Ogawa san, \nDoing such a change in Tacker would require a blueprint? As this impacts existing functional test cases. Please share your opinion.\nThanks.","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f38e1bfc7ae7c1ab33622c1632ab9986ec0192e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"d8cc6e30_95d429d1","in_reply_to":"8c415de4_e119487d","updated":"2022-02-04 02:59:17.000000000","message":"I agree to propose the blueprint. I\u0027d appreciate if you share idea of what the names should be which tests will be affected in IRC meeting before you upload a patch. Thaks.","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"742b8a63ada5b16e91daa06f399f2afc1b03c640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"30f8695e_d09f0fcb","in_reply_to":"d8cc6e30_95d429d1","updated":"2022-02-04 03:09:31.000000000","message":"Thank you Ogawa san for sharing your insight. Would do the needful. \nThanks 😊","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"}],"roles/setup-default-vim/defaults/main.yaml":[{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"26adfbfe67a0d59f12cdc9e3274e5b5203f648d5","unresolved":true,"context_lines":[{"line_number":3,"context_line":"os_project: nfv"},{"line_number":4,"context_line":"os_domain: Default"},{"line_number":5,"context_line":"os_vim_name: VIM0"},{"line_number":6,"context_line":"os_vim_conf_path: /tmp/local-vim.yaml"},{"line_number":7,"context_line":"k8s_vim_name: vim-kubernetes"},{"line_number":8,"context_line":"k8s_vim_conf_path: /tmp/local-k8s-vim.yaml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7e10dc8b_29a47116","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":37},"updated":"2022-01-27 08:49:18.000000000","message":"Could we rename this file as local-admin-vim or anything more specific to the user role? Please share your opinion.","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"9d9b9c3e260024f801f2a8266a51ac1c42ad344b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"os_project: nfv"},{"line_number":4,"context_line":"os_domain: Default"},{"line_number":5,"context_line":"os_vim_name: VIM0"},{"line_number":6,"context_line":"os_vim_conf_path: /tmp/local-vim.yaml"},{"line_number":7,"context_line":"k8s_vim_name: vim-kubernetes"},{"line_number":8,"context_line":"k8s_vim_conf_path: /tmp/local-k8s-vim.yaml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"893c31e9_62d33a44","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":37},"in_reply_to":"6bc42a6c_966a5e87","updated":"2022-02-03 02:48:00.000000000","message":"Yes, agree, such activity requires a good amount of file changes and shall be done in a separate patch. \nThanks.","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"e71fdcf97a79a084b13439824d691c1397d78c2a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"os_project: nfv"},{"line_number":4,"context_line":"os_domain: Default"},{"line_number":5,"context_line":"os_vim_name: VIM0"},{"line_number":6,"context_line":"os_vim_conf_path: /tmp/local-vim.yaml"},{"line_number":7,"context_line":"k8s_vim_name: vim-kubernetes"},{"line_number":8,"context_line":"k8s_vim_conf_path: /tmp/local-k8s-vim.yaml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"8c011c94_15504dd2","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":37},"in_reply_to":"7e10dc8b_29a47116","updated":"2022-02-02 18:30:27.000000000","message":"I\u0027d like to know the reason although changing the name seems acceptable. Thanks.","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":32102,"name":"Manpreet Kaur","email":"kaurmanpreet2620@gmail.com","username":"manpreet"},"change_message_id":"fdccc13431c8854315e1a3b397a7a6cd42e2e407","unresolved":true,"context_lines":[{"line_number":3,"context_line":"os_project: nfv"},{"line_number":4,"context_line":"os_domain: Default"},{"line_number":5,"context_line":"os_vim_name: VIM0"},{"line_number":6,"context_line":"os_vim_conf_path: /tmp/local-vim.yaml"},{"line_number":7,"context_line":"k8s_vim_name: vim-kubernetes"},{"line_number":8,"context_line":"k8s_vim_conf_path: /tmp/local-k8s-vim.yaml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ffa33f82_f6869e3a","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":37},"in_reply_to":"8c011c94_15504dd2","updated":"2022-02-03 01:35:11.000000000","message":"Such naming convention could help anyone(especially new contributors) in figuring out VIM ownership, as while implementing the multi-tenant feature this was spotted.\nThat\u0027s was my thought process.\nThanks 😊","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f8ccadbe1de7490c9d7c863249b5270e3961ecc8","unresolved":true,"context_lines":[{"line_number":3,"context_line":"os_project: nfv"},{"line_number":4,"context_line":"os_domain: Default"},{"line_number":5,"context_line":"os_vim_name: VIM0"},{"line_number":6,"context_line":"os_vim_conf_path: /tmp/local-vim.yaml"},{"line_number":7,"context_line":"k8s_vim_name: vim-kubernetes"},{"line_number":8,"context_line":"k8s_vim_conf_path: /tmp/local-k8s-vim.yaml"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"6bc42a6c_966a5e87","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":37},"in_reply_to":"ffa33f82_f6869e3a","updated":"2022-02-03 02:42:16.000000000","message":"I understand, and think it\u0027s good point. However, the VIM created isn\u0027t owned by `admin` but `nfv_user`, so the name of your suggestion might be not appropriate. In addition, I think `/tmp/local-k8s-vim.yaml` should be also changed for the purpose of naming convention. I\u0027ve also concerned that there are several tests expecting the names. So, I think changing the names is better to be done in a different patch. What do you think?","commit_id":"fdc97bf34dce52bab10fa8797a79597ef1228518"}]}