)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4effbb6e821a8c0eb8bc22fc6a7858304e384f88","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In current implementation, if the tacker servers go down during LCM"},{"line_number":10,"context_line":"operation, the operation state will be fixed to `PROCESSING` even after"},{"line_number":11,"context_line":"servers restart. Once this problem happens, users cannot chagne the"},{"line_number":12,"context_line":"operation state with APIs, which means users have to change the state"},{"line_number":13,"context_line":"by updating DB directly."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"b8362962_967d2669","line":11,"range":{"start_line":11,"start_character":57,"end_line":11,"end_character":63},"updated":"2022-01-17 12:59:26.000000000","message":"typo: change","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d6dca2cf2d618bf48a0e0a3bccb1eac51f67dc72","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In current implementation, if the tacker servers go down during LCM"},{"line_number":10,"context_line":"operation, the operation state will be fixed to `PROCESSING` even after"},{"line_number":11,"context_line":"servers restart. Once this problem happens, users cannot chagne the"},{"line_number":12,"context_line":"operation state with APIs, which means users have to change the state"},{"line_number":13,"context_line":"by updating DB directly."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"25c8ab36_132029b3","line":11,"range":{"start_line":11,"start_character":57,"end_line":11,"end_character":63},"in_reply_to":"7bbb6968_080c305d","updated":"2022-02-15 07:40:51.000000000","message":"I\u0027ve confirmed.","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"84b15eff02918ec40bc76ae9b61d9bd5fb7704d4","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In current implementation, if the tacker servers go down during LCM"},{"line_number":10,"context_line":"operation, the operation state will be fixed to `PROCESSING` even after"},{"line_number":11,"context_line":"servers restart. Once this problem happens, users cannot chagne the"},{"line_number":12,"context_line":"operation state with APIs, which means users have to change the state"},{"line_number":13,"context_line":"by updating DB directly."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"7bbb6968_080c305d","line":11,"range":{"start_line":11,"start_character":57,"end_line":11,"end_character":63},"in_reply_to":"b8362962_967d2669","updated":"2022-02-15 05:26:19.000000000","message":"I fixed it in PS21","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4effbb6e821a8c0eb8bc22fc6a7858304e384f88","unresolved":true,"context_lines":[{"line_number":12,"context_line":"operation state with APIs, which means users have to change the state"},{"line_number":13,"context_line":"by updating DB directly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fix this problem by adding a `/vnf_lcm_op_occs/{id}/cancel`"},{"line_number":16,"context_line":"endpoint according to ETSI NFV SOL003 [1]. Users can change the state"},{"line_number":17,"context_line":"of LCM operations in `PROCESSING` to `FAILED_TEMP` with this API."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"c76991cf_da0944f5","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":14},"updated":"2022-01-17 12:59:26.000000000","message":"fixes","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d6dca2cf2d618bf48a0e0a3bccb1eac51f67dc72","unresolved":false,"context_lines":[{"line_number":12,"context_line":"operation state with APIs, which means users have to change the state"},{"line_number":13,"context_line":"by updating DB directly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fix this problem by adding a `/vnf_lcm_op_occs/{id}/cancel`"},{"line_number":16,"context_line":"endpoint according to ETSI NFV SOL003 [1]. Users can change the state"},{"line_number":17,"context_line":"of LCM operations in `PROCESSING` to `FAILED_TEMP` with this API."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"c97abc70_77c03e29","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":14},"in_reply_to":"9aa5ff7f_2b610f7c","updated":"2022-02-15 07:40:51.000000000","message":"I\u0027ve confirmed.","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"84b15eff02918ec40bc76ae9b61d9bd5fb7704d4","unresolved":true,"context_lines":[{"line_number":12,"context_line":"operation state with APIs, which means users have to change the state"},{"line_number":13,"context_line":"by updating DB directly."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fix this problem by adding a `/vnf_lcm_op_occs/{id}/cancel`"},{"line_number":16,"context_line":"endpoint according to ETSI NFV SOL003 [1]. Users can change the state"},{"line_number":17,"context_line":"of LCM operations in `PROCESSING` to `FAILED_TEMP` with this API."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"9aa5ff7f_2b610f7c","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":14},"in_reply_to":"c76991cf_da0944f5","updated":"2022-02-15 05:26:19.000000000","message":"I fixed it in PS21","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4effbb6e821a8c0eb8bc22fc6a7858304e384f88","unresolved":true,"context_lines":[{"line_number":20,"context_line":"PROCESSING -\u003e FAILED_TEMP (i.e., transitions from ROLLING_BACK and"},{"line_number":21,"context_line":"STARTING are not supported)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In addition, as the cuurent ``_get_affected_resources`` doesn\u0027t work"},{"line_number":24,"context_line":"correctly when there are no updated resources, this patch modify"},{"line_number":25,"context_line":"``utils.py`` [2] to fix it and update the tests [3] depending on"},{"line_number":26,"context_line":"``utils.py``."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"c3b65942_dc630a43","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":27},"updated":"2022-01-17 12:59:26.000000000","message":"typo: current","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d6dca2cf2d618bf48a0e0a3bccb1eac51f67dc72","unresolved":false,"context_lines":[{"line_number":20,"context_line":"PROCESSING -\u003e FAILED_TEMP (i.e., transitions from ROLLING_BACK and"},{"line_number":21,"context_line":"STARTING are not supported)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In addition, as the cuurent ``_get_affected_resources`` doesn\u0027t work"},{"line_number":24,"context_line":"correctly when there are no updated resources, this patch modify"},{"line_number":25,"context_line":"``utils.py`` [2] to fix it and update the tests [3] depending on"},{"line_number":26,"context_line":"``utils.py``."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"5cdd6bf3_c48e5e4d","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":27},"in_reply_to":"10aa7ff7_5eb59831","updated":"2022-02-15 07:40:51.000000000","message":"I\u0027ve confirmed.","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"84b15eff02918ec40bc76ae9b61d9bd5fb7704d4","unresolved":true,"context_lines":[{"line_number":20,"context_line":"PROCESSING -\u003e FAILED_TEMP (i.e., transitions from ROLLING_BACK and"},{"line_number":21,"context_line":"STARTING are not supported)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In addition, as the cuurent ``_get_affected_resources`` doesn\u0027t work"},{"line_number":24,"context_line":"correctly when there are no updated resources, this patch modify"},{"line_number":25,"context_line":"``utils.py`` [2] to fix it and update the tests [3] depending on"},{"line_number":26,"context_line":"``utils.py``."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"10aa7ff7_5eb59831","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":27},"in_reply_to":"c3b65942_dc630a43","updated":"2022-02-15 05:26:19.000000000","message":"I fixed it in PS21","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"d4ea9119f5f29a59ceedac81d3cdd45fda156948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"36ad9e9d_ba0ee306","updated":"2021-11-08 00:43:47.000000000","message":"recheck","commit_id":"09e9f318b0d7ac74431d046e69dc6c59c6b0ea16"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"92e99de67d47c8da524c1394b9510dfef568ada2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7977381b_dfdf5563","updated":"2021-11-05 06:56:59.000000000","message":"recheck","commit_id":"09e9f318b0d7ac74431d046e69dc6c59c6b0ea16"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"bc1ac170e3e0e8f5e645ba889cc1a487037aa52c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"11174d17_bf1ac67f","updated":"2021-11-25 03:54:47.000000000","message":"recheck","commit_id":"acc6e7a0e4a920a0423249dd6a69e4a21c3e60ea"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"7c541b2b45f3780e27c64a40a6599a49870d3c3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"24372bcd_57012596","updated":"2021-11-25 01:06:09.000000000","message":"recheck","commit_id":"acc6e7a0e4a920a0423249dd6a69e4a21c3e60ea"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"0113c142b0bdd1af66458832de21629521f7023e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b2bd9c6f_3962cc44","updated":"2021-12-06 13:07:34.000000000","message":"recheck","commit_id":"6ef192c8837b78621a0bf58d40eb72dbd362b236"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"83c5c84a966f2b2349a349762b711c98ce04caa5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"863150c5_2faa68ab","updated":"2021-12-09 01:32:42.000000000","message":"recheck","commit_id":"de5df390f940f88c5ce6a92810acfb302e03c807"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"12055b19b5b5ee3acc5251991578843fd6c1021a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ad966634_517d642c","updated":"2022-01-17 08:50:46.000000000","message":"Thank you for your review.\n\nCould you please read my reply and tell me you opinion?","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4effbb6e821a8c0eb8bc22fc6a7858304e384f88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e95894e5_e89e6ec0","updated":"2022-01-17 12:59:26.000000000","message":"Thanks for your patch, please kindly find my comments.","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"2c0079665e41e61b91ddff2bff8df5ce992c5ada","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"65062e4c_840f3270","updated":"2021-12-27 06:42:30.000000000","message":"Thanks for your response,\n\nIf tacker server is stopped during \"vnflcm heal\" operation then the operation remains in PROCESSING.\nIn database\u0027s vnf table , the state of vnf is in \"PENDING_HEAL\" due to which \"vnflcm op cancel\" gives \"vnf still in use\" exception\n\nThere is problem in check_vnf_status_legality function in vnfm_db.py which raises exception for PENDING_HEAL due to which heal operation can not change from PROCESSING to FAILED_TEMP. \n","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"b00a347358d6a5d8a1a09201019b1887083b3f61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"d00b837b_7b94d763","updated":"2021-12-10 05:25:19.000000000","message":"recheck","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"12055b19b5b5ee3acc5251991578843fd6c1021a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"766f25c1_86549e99","in_reply_to":"65062e4c_840f3270","updated":"2022-01-17 08:50:46.000000000","message":"This line was added when the auto heal is implemented [1,2].\n\nI suppose the purpose of this line is to prevent several consecutive heal requests triggered by the auto heal. \n\nTo solve the problem you pointed out, we have two options: (i) deleting this line; (ii) treating `cancel` operation as an exception.\n\nWhich one do you think appropriate? or if you have another solution please kindly tell me. \n\n\nIMO, it\u0027s acceptable that deleting this line, i.e., (i), as the autoheal is a legacy implementation.\n\n[1] https://github.com/openstack/tacker/blame/0cd9cd8404c15440596bbb36ae00cb0e213ea84b/tacker/db/vnfm/vnfm_db.py#L521-L521\n[2] https://specs.openstack.org/openstack/tacker-specs/specs/stein/vdu-auto-healing.html#proposed-change","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33558,"name":"renu rani","display_name":"Renur","email":"rani.renu@gmail.com","username":"Renu"},"change_message_id":"0be6614049356a1b66f1a99a0f31b694888571e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"a13995f2_a544f346","in_reply_to":"ad966634_517d642c","updated":"2022-01-17 09:35:58.000000000","message":"I think we should go with (ii)treating `cancel` operation as an exception.\nas deleting this line can cause other issues.\n\nOr can we differentiate call ( from where the call is coming if it is from cancel operation than no need to consider constants.PENDING_HEAL and work as per cancel operation otherwise work as usual)","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"84b15eff02918ec40bc76ae9b61d9bd5fb7704d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"142d368f_cbf10972","updated":"2022-02-15 05:26:19.000000000","message":"Thank you for the review.\n\nI did rebase and fixed an error regarding an error message [1].\n\n[1] https://review.opendev.org/c/openstack/tacker/+/815416/20..21/tacker/api/vnflcm/v1/controller.py#1497","commit_id":"4a33622ffc438a22e519a5ee4d71e8f35a019154"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d6dca2cf2d618bf48a0e0a3bccb1eac51f67dc72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7dd147e8_77c67e95","updated":"2022-02-15 07:40:51.000000000","message":"Thanks for your rework, please kindly check additional comment.","commit_id":"4a33622ffc438a22e519a5ee4d71e8f35a019154"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5407dcbcaafc8c4aeec82ced017db017cf1457ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"0e9297b9_831a5a6c","updated":"2022-02-15 01:30:18.000000000","message":"recheck","commit_id":"4a33622ffc438a22e519a5ee4d71e8f35a019154"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"ee9f741605da9d5c1db6eed792119563c2814e5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"8056b19e_d6d3dca4","in_reply_to":"142d368f_cbf10972","updated":"2022-02-15 05:29:21.000000000","message":"Also, I added test cases for 404 and 500 errors and removed unnecessary mocks.","commit_id":"4a33622ffc438a22e519a5ee4d71e8f35a019154"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"89b59f4bb59597a8a36be92501cec4fb8def31b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"50fcd890_692c1d21","updated":"2022-02-15 13:07:46.000000000","message":"Thanks for your rework, LGTM.","commit_id":"d40de6c71ecf9d5d31d31ddc94b4ae8ad40f2ca8"}],"tacker/api/vnflcm/v1/controller.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"f3780a948abc675181e54a066e8348be9590989a","unresolved":true,"context_lines":[{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"        @param request: A request object"},{"line_number":1419,"context_line":"        @param id: Identifier of a VNF lifecycle management operation"},{"line_number":1420,"context_line":"                    occurrence to be cancelled."},{"line_number":1421,"context_line":"        @param body: the content of the request body"},{"line_number":1422,"context_line":"        @return: A response object"},{"line_number":1423,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"a49c636f_ce49e316","line":1420,"updated":"2021-12-07 08:08:37.000000000","message":"Gate test failed because of this indentation and next one. Furthermore, another problem is caused for toctree. Please refer error messages by running `tox -e docs`.","commit_id":"6ef192c8837b78621a0bf58d40eb72dbd362b236"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"5407dcbcaafc8c4aeec82ced017db017cf1457ee","unresolved":false,"context_lines":[{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"        @param request: A request object"},{"line_number":1419,"context_line":"        @param id: Identifier of a VNF lifecycle management operation"},{"line_number":1420,"context_line":"                    occurrence to be cancelled."},{"line_number":1421,"context_line":"        @param body: the content of the request body"},{"line_number":1422,"context_line":"        @return: A response object"},{"line_number":1423,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"f3121a74_b6979857","line":1420,"in_reply_to":"a49c636f_ce49e316","updated":"2022-02-15 01:30:18.000000000","message":"Done","commit_id":"6ef192c8837b78621a0bf58d40eb72dbd362b236"}],"tacker/db/vnfm/vnfm_db.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d6dca2cf2d618bf48a0e0a3bccb1eac51f67dc72","unresolved":true,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def update_vnf_cancel_status(self, context, vnf_id, status):"},{"line_number":526,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":527,"context_line":"            vnf_db \u003d self._get_vnf_db("},{"line_number":528,"context_line":"                context, vnf_id, [*constants.PENDING_STATUSES])"},{"line_number":529,"context_line":"            vnf_db.update({\u0027status\u0027: status})"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def update_vnf_fail_status(self,"},{"line_number":532,"context_line":"                               context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"f542c109_16194724","line":529,"range":{"start_line":527,"start_character":0,"end_line":529,"end_character":45},"updated":"2022-02-15 07:40:51.000000000","message":"Using the `_update_vnf_status_db()` method results in an error when in the `PENDING_*` state, so I understood that this change is necessary.\n\nThe `_update_vnf_status_db_no_check()` method does not seem to check above, but can it be used?","commit_id":"4a33622ffc438a22e519a5ee4d71e8f35a019154"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"89b59f4bb59597a8a36be92501cec4fb8def31b2","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def update_vnf_cancel_status(self, context, vnf_id, status):"},{"line_number":526,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":527,"context_line":"            vnf_db \u003d self._get_vnf_db("},{"line_number":528,"context_line":"                context, vnf_id, [*constants.PENDING_STATUSES])"},{"line_number":529,"context_line":"            vnf_db.update({\u0027status\u0027: status})"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def update_vnf_fail_status(self,"},{"line_number":532,"context_line":"                               context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"198be6cd_9d56eed6","line":529,"range":{"start_line":527,"start_character":0,"end_line":529,"end_character":45},"in_reply_to":"3b9f5373_d5ee6422","updated":"2022-02-15 13:07:46.000000000","message":"I\u0027ve confirmed.","commit_id":"4a33622ffc438a22e519a5ee4d71e8f35a019154"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"2690659c3724801221e25234f0b26a0865dd6a95","unresolved":true,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def update_vnf_cancel_status(self, context, vnf_id, status):"},{"line_number":526,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":527,"context_line":"            vnf_db \u003d self._get_vnf_db("},{"line_number":528,"context_line":"                context, vnf_id, [*constants.PENDING_STATUSES])"},{"line_number":529,"context_line":"            vnf_db.update({\u0027status\u0027: status})"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def update_vnf_fail_status(self,"},{"line_number":532,"context_line":"                               context,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3b9f5373_d5ee6422","line":529,"range":{"start_line":527,"start_character":0,"end_line":529,"end_character":45},"in_reply_to":"f542c109_16194724","updated":"2022-02-15 10:55:40.000000000","message":"Thank you for your advise. I missed it.\nI\u0027ve changed to use ``_update_vnf_status_db_no_check`` in PS22","commit_id":"4a33622ffc438a22e519a5ee4d71e8f35a019154"}],"tacker/policies/vnf_lcm.py":[{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"4effbb6e821a8c0eb8bc22fc6a7858304e384f88","unresolved":true,"context_lines":[{"line_number":168,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":169,"context_line":"        name\u003dVNFLCM % \u0027cancel\u0027,"},{"line_number":170,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":171,"context_line":"        description\u003d\"Fail a VNF instance.\","},{"line_number":172,"context_line":"        operations\u003d["},{"line_number":173,"context_line":"            {"},{"line_number":174,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"814b64f9_89deeb61","line":171,"range":{"start_line":171,"start_character":21,"end_line":171,"end_character":25},"updated":"2022-01-17 12:59:26.000000000","message":"This should not be \"Fail\" but \"Cancel\".","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"d6dca2cf2d618bf48a0e0a3bccb1eac51f67dc72","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":169,"context_line":"        name\u003dVNFLCM % \u0027cancel\u0027,"},{"line_number":170,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":171,"context_line":"        description\u003d\"Fail a VNF instance.\","},{"line_number":172,"context_line":"        operations\u003d["},{"line_number":173,"context_line":"            {"},{"line_number":174,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"37f940d0_277a2875","line":171,"range":{"start_line":171,"start_character":21,"end_line":171,"end_character":25},"in_reply_to":"1c1b1100_b589c781","updated":"2022-02-15 07:40:51.000000000","message":"I\u0027ve confirmed.","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"},{"author":{"_account_id":33455,"name":"Hiromu Asahina","email":"hiromu.a5a@gmail.com","username":"h_asahina"},"change_message_id":"84b15eff02918ec40bc76ae9b61d9bd5fb7704d4","unresolved":true,"context_lines":[{"line_number":168,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":169,"context_line":"        name\u003dVNFLCM % \u0027cancel\u0027,"},{"line_number":170,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":171,"context_line":"        description\u003d\"Fail a VNF instance.\","},{"line_number":172,"context_line":"        operations\u003d["},{"line_number":173,"context_line":"            {"},{"line_number":174,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1c1b1100_b589c781","line":171,"range":{"start_line":171,"start_character":21,"end_line":171,"end_character":25},"in_reply_to":"814b64f9_89deeb61","updated":"2022-02-15 05:26:19.000000000","message":"I fixed it in PS21","commit_id":"9ce3059e10598dcf350e7aa1a22115b3ff5d9790"}]}