)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d3ad9358b0265866322f1e41e87baf967db13041","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"16df36e4_acb36f76","updated":"2021-11-01 22:21:18.000000000","message":"recheck","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ce16a4fd5eb7c70b8f64b210b4e16f2a3ed0be5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"009757e5_810e9730","updated":"2021-11-08 22:58:19.000000000","message":"Thank you for the review.","commit_id":"7441f140423e3833677ae5deaefb7ed163c5af46"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"db5be743c5f0d953f606b293bdc5cafbfd00e05c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8128350_fdfc7327","updated":"2021-11-08 02:55:24.000000000","message":"patch set 2: add release note, fix commit message.","commit_id":"7441f140423e3833677ae5deaefb7ed163c5af46"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d6d413c88eb39f6b431c7576043cd422be119d28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"89492400_6224ad7a","updated":"2021-11-11 03:39:00.000000000","message":"Thank you for the review.","commit_id":"bcca0f1556390198a7e80a856870bb4ce0f951fc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"9da6591f6133f93d1e82bc0b7ee97297424af9f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7ef765d_6624f8cc","updated":"2021-11-09 23:30:59.000000000","message":"recheck","commit_id":"bcca0f1556390198a7e80a856870bb4ce0f951fc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f2f80a16_d49653d2","updated":"2021-12-02 04:24:06.000000000","message":"Thank you for the review.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"5386000a72d1db4ae3b920b432a504a1ce338cd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"60d88a15_bde38f6e","updated":"2021-12-08 08:15:53.000000000","message":"It seems just failing to download cirros image accidentally.","commit_id":"bf51c2bc800f6511a7756eeccddd7d18b7bc8b69"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"24d942b5757c8ad52f2f0bf678dfb61d1d1cd245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"56552776_d1cf4b90","updated":"2021-12-13 23:55:12.000000000","message":"LGTM","commit_id":"bf51c2bc800f6511a7756eeccddd7d18b7bc8b69"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"631424d99c2e10aaf4ef9c7af0cfab2f0efc6d0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"09e0bcef_fde45e69","updated":"2021-12-17 08:28:43.000000000","message":"LGTM.","commit_id":"bf51c2bc800f6511a7756eeccddd7d18b7bc8b69"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d1379329fc6e455b836d498a31570efb2ecf50fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"126b6a49_e26e4cb7","updated":"2021-12-13 22:21:14.000000000","message":"Thank you for the review.","commit_id":"bf51c2bc800f6511a7756eeccddd7d18b7bc8b69"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"96094f7f61d97813fdb8b0117ed4fda63d35ec18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f098adf_b9b4049b","updated":"2021-12-08 14:40:08.000000000","message":"recheck","commit_id":"bf51c2bc800f6511a7756eeccddd7d18b7bc8b69"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"15a5cf8f038b262f547da6ffe12792cab9c0a7b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8728a5c7_3834d280","updated":"2021-12-08 08:15:59.000000000","message":"recheck","commit_id":"bf51c2bc800f6511a7756eeccddd7d18b7bc8b69"}],"tacker/db/migration/alembic_migrations/versions/3ff50553e9d3_add_grant_and_grant_request.py":[{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"86817d31d1cf2ab267b8a8590d372017daa77c62","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    op.create_table(\u0027GrantRequestV1\u0027,"},{"line_number":55,"context_line":"        sa.Column(\u0027vnfInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":56,"context_line":"        sa.Column(\u0027vnfLcmOpOccId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":57,"context_line":"        sa.Column(\u0027vnfdId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":58,"context_line":"        sa.Column(\u0027dstVnfdId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":59,"context_line":"        sa.Column(\u0027flavourId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":60,"context_line":"        sa.Column(\u0027operation\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b79a9188_002db254","line":57,"updated":"2021-11-11 02:43:43.000000000","message":"According to SOL003v3.3.1, the cardinality of vnfdId is 1.\nI think nullable\u003dFalse is correct.","commit_id":"bcca0f1556390198a7e80a856870bb4ce0f951fc"},{"author":{"_account_id":32581,"name":"Hirofumi Noguchi","email":"hirofumi.noguchi.rs@hco.ntt.co.jp","username":"hirofumi-noguchi"},"change_message_id":"36f2a972b0e17126320566361826fe6adf5c0b76","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    op.create_table(\u0027GrantRequestV1\u0027,"},{"line_number":55,"context_line":"        sa.Column(\u0027vnfInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":56,"context_line":"        sa.Column(\u0027vnfLcmOpOccId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":57,"context_line":"        sa.Column(\u0027vnfdId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":58,"context_line":"        sa.Column(\u0027dstVnfdId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":59,"context_line":"        sa.Column(\u0027flavourId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":60,"context_line":"        sa.Column(\u0027operation\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"cac43a15_fe3de5cf","line":57,"in_reply_to":"00d6fff6_3a360b4d","updated":"2021-11-11 04:36:25.000000000","message":"Thank you for the fix.","commit_id":"bcca0f1556390198a7e80a856870bb4ce0f951fc"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d6d413c88eb39f6b431c7576043cd422be119d28","unresolved":true,"context_lines":[{"line_number":54,"context_line":"    op.create_table(\u0027GrantRequestV1\u0027,"},{"line_number":55,"context_line":"        sa.Column(\u0027vnfInstanceId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":56,"context_line":"        sa.Column(\u0027vnfLcmOpOccId\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":57,"context_line":"        sa.Column(\u0027vnfdId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":58,"context_line":"        sa.Column(\u0027dstVnfdId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":59,"context_line":"        sa.Column(\u0027flavourId\u0027, sa.String(length\u003d255), nullable\u003dTrue),"},{"line_number":60,"context_line":"        sa.Column(\u0027operation\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"00d6fff6_3a360b4d","line":57,"in_reply_to":"b79a9188_002db254","updated":"2021-11-11 03:39:00.000000000","message":"right. I will fix.","commit_id":"bcca0f1556390198a7e80a856870bb4ce0f951fc"},{"author":{"_account_id":31668},"change_message_id":"94d914e531a6089e639bfb827eaae040a5904c59","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        sa.Column(\u0027operation\u0027,"},{"line_number":61,"context_line":"                  sa.Enum(\u0027INSTANTIATE\u0027, \u0027SCALE\u0027, \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":62,"context_line":"                          \u0027CHANGE_FLAVOUR\u0027, \u0027TERMINATE\u0027, \u0027HEAL\u0027, \u0027OPERATE\u0027,"},{"line_number":63,"context_line":"                          \u0027CHANGE_EXT_CONN\u0027, \u0027MODIFY_INFO\u0027, \u0027CREATE_SNAPSHOT\u0027,"},{"line_number":64,"context_line":"                          \u0027REVERT_TO_SNAPSHOT\u0027, \u0027CHANGE_VNFPKG\u0027),"},{"line_number":65,"context_line":"                  nullable\u003dFalse),"},{"line_number":66,"context_line":"        sa.Column(\u0027isAutomaticInvocation\u0027, sa.Boolean(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":6,"id":"11bfc045_4f7bf632","line":63,"updated":"2021-12-02 04:48:35.000000000","message":"Is \"MODIFY_INFO\" necessary?","commit_id":"ee95af77769141a74f5b946fbe6277d4525f2241"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"bc17cd3c3582d3256d05598c7c1200e4ef4ad240","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        sa.Column(\u0027operation\u0027,"},{"line_number":61,"context_line":"                  sa.Enum(\u0027INSTANTIATE\u0027, \u0027SCALE\u0027, \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":62,"context_line":"                          \u0027CHANGE_FLAVOUR\u0027, \u0027TERMINATE\u0027, \u0027HEAL\u0027, \u0027OPERATE\u0027,"},{"line_number":63,"context_line":"                          \u0027CHANGE_EXT_CONN\u0027, \u0027MODIFY_INFO\u0027, \u0027CREATE_SNAPSHOT\u0027,"},{"line_number":64,"context_line":"                          \u0027REVERT_TO_SNAPSHOT\u0027, \u0027CHANGE_VNFPKG\u0027),"},{"line_number":65,"context_line":"                  nullable\u003dFalse),"},{"line_number":66,"context_line":"        sa.Column(\u0027isAutomaticInvocation\u0027, sa.Boolean(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":6,"id":"424a5793_c98b13d7","line":63,"in_reply_to":"11bfc045_4f7bf632","updated":"2021-12-02 05:36:09.000000000","message":"It is not necessary. I will remove it.","commit_id":"ee95af77769141a74f5b946fbe6277d4525f2241"},{"author":{"_account_id":31668},"change_message_id":"542c8ffd08e9d35e03e1effe37039fdddf45767c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        sa.Column(\u0027operation\u0027,"},{"line_number":61,"context_line":"                  sa.Enum(\u0027INSTANTIATE\u0027, \u0027SCALE\u0027, \u0027SCALE_TO_LEVEL\u0027,"},{"line_number":62,"context_line":"                          \u0027CHANGE_FLAVOUR\u0027, \u0027TERMINATE\u0027, \u0027HEAL\u0027, \u0027OPERATE\u0027,"},{"line_number":63,"context_line":"                          \u0027CHANGE_EXT_CONN\u0027, \u0027MODIFY_INFO\u0027, \u0027CREATE_SNAPSHOT\u0027,"},{"line_number":64,"context_line":"                          \u0027REVERT_TO_SNAPSHOT\u0027, \u0027CHANGE_VNFPKG\u0027),"},{"line_number":65,"context_line":"                  nullable\u003dFalse),"},{"line_number":66,"context_line":"        sa.Column(\u0027isAutomaticInvocation\u0027, sa.Boolean(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":6,"id":"16515019_04f6154e","line":63,"in_reply_to":"424a5793_c98b13d7","updated":"2021-12-02 05:42:36.000000000","message":"Done","commit_id":"ee95af77769141a74f5b946fbe6277d4525f2241"}],"tacker/sol_refactored/common/lcm_op_occ_utils.py":[{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"535206627e6fd8f9261c2b89e802cf7988bdfd25","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    return grant_reqs[0], grant"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."}],"source_content_type":"text/x-python","patch_set":1,"id":"e4e4f6cf_2b2e3cd3","line":201,"range":{"start_line":201,"start_character":4,"end_line":201,"end_character":28},"updated":"2021-11-08 07:59:56.000000000","message":"This method is checking failed_temp instead of in_progress.\nI think it\u0027s better to include it in the method name.","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"180d4ceaba5a947335e2ddc01ec229444a73febb","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    return grant_reqs[0], grant"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."}],"source_content_type":"text/x-python","patch_set":1,"id":"b631845b_bf288dc6","line":201,"range":{"start_line":201,"start_character":4,"end_line":201,"end_character":28},"in_reply_to":"ac3dde1e_41036e13","updated":"2021-11-11 05:40:58.000000000","message":"I see.","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ce16a4fd5eb7c70b8f64b210b4e16f2a3ed0be5f","unresolved":true,"context_lines":[{"line_number":198,"context_line":"    return grant_reqs[0], grant"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."}],"source_content_type":"text/x-python","patch_set":1,"id":"ac3dde1e_41036e13","line":201,"range":{"start_line":201,"start_character":4,"end_line":201,"end_character":28},"in_reply_to":"e4e4f6cf_2b2e3cd3","updated":"2021-11-08 22:58:19.000000000","message":"This method is to check whether an unfinished LCM operation (i.e. in-progress) is not remain for the vnf instance when a (new) LCM operation for the vnf instance to be started.\nBut as a result, it is enough to check there is FAILED_TEMP LCM for the vnf instance to do it.\n(see the comment bellow)","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"535206627e6fd8f9261c2b89e802cf7988bdfd25","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        context, vnfInstanceId\u003dinst_id,"},{"line_number":209,"context_line":"        operationState\u003dfields.LcmOperationStateType.FAILED_TEMP)"},{"line_number":210,"context_line":"    if lcmoccs:"},{"line_number":211,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"668ad552_54911e40","line":211,"range":{"start_line":211,"start_character":13,"end_line":211,"end_character":45},"updated":"2021-11-08 07:59:56.000000000","message":"Is this exception intended?\nI think it should inform the user that the LCM opration state is FAILED_TEMP.","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ce16a4fd5eb7c70b8f64b210b4e16f2a3ed0be5f","unresolved":true,"context_lines":[{"line_number":208,"context_line":"        context, vnfInstanceId\u003dinst_id,"},{"line_number":209,"context_line":"        operationState\u003dfields.LcmOperationStateType.FAILED_TEMP)"},{"line_number":210,"context_line":"    if lcmoccs:"},{"line_number":211,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba484220_34d4d2c5","line":211,"range":{"start_line":211,"start_character":13,"end_line":211,"end_character":45},"in_reply_to":"668ad552_54911e40","updated":"2021-11-08 22:58:19.000000000","message":"yes, intended.\nA user receive this when a new LCM operation to be started while other LCM operation is not finished.","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"180d4ceaba5a947335e2ddc01ec229444a73febb","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        context, vnfInstanceId\u003dinst_id,"},{"line_number":209,"context_line":"        operationState\u003dfields.LcmOperationStateType.FAILED_TEMP)"},{"line_number":210,"context_line":"    if lcmoccs:"},{"line_number":211,"context_line":"        raise sol_ex.OtherOperationInProgress(inst_id\u003dinst_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"062fc407_3c4defbb","line":211,"range":{"start_line":211,"start_character":13,"end_line":211,"end_character":45},"in_reply_to":"ba484220_34d4d2c5","updated":"2021-11-11 05:40:58.000000000","message":"I see. I understand that there is no problem with this implementation.","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":31668},"change_message_id":"82302a47a4525eb3bd300faa557b23362a1138ca","unresolved":true,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"}],"source_content_type":"text/x-python","patch_set":5,"id":"263db9be_367bee81","line":202,"updated":"2021-12-02 02:29:57.000000000","message":"typo: contorller -\u003e controller","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":true,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"}],"source_content_type":"text/x-python","patch_set":5,"id":"86237abe_223f8d9b","line":202,"in_reply_to":"263db9be_367bee81","updated":"2021-12-02 04:24:06.000000000","message":"I will fix.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"94d914e531a6089e639bfb827eaae040a5904c59","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"}],"source_content_type":"text/x-python","patch_set":5,"id":"52d13d10_25cf466c","line":202,"in_reply_to":"86237abe_223f8d9b","updated":"2021-12-02 04:48:35.000000000","message":"Done","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"82302a47a4525eb3bd300faa557b23362a1138ca","unresolved":true,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"},{"line_number":206,"context_line":"    # FAILED_TEMP operationState."}],"source_content_type":"text/x-python","patch_set":5,"id":"f7337470_0253a3ee","line":203,"updated":"2021-12-02 02:29:57.000000000","message":"typo: instantce -\u003e instance","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"94d914e531a6089e639bfb827eaae040a5904c59","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"},{"line_number":206,"context_line":"    # FAILED_TEMP operationState."}],"source_content_type":"text/x-python","patch_set":5,"id":"39b31b41_b56587b7","line":203,"in_reply_to":"4003c4ff_d110fcc7","updated":"2021-12-02 04:48:35.000000000","message":"Done","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":true,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"},{"line_number":206,"context_line":"    # FAILED_TEMP operationState."}],"source_content_type":"text/x-python","patch_set":5,"id":"4003c4ff_d110fcc7","line":203,"in_reply_to":"f7337470_0253a3ee","updated":"2021-12-02 04:24:06.000000000","message":"I will fix.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"82302a47a4525eb3bd300faa557b23362a1138ca","unresolved":true,"context_lines":[{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"},{"line_number":206,"context_line":"    # FAILED_TEMP operationState."},{"line_number":207,"context_line":"    lcmoccs \u003d objects.VnfLcmOpOccV2.get_by_filter("}],"source_content_type":"text/x-python","patch_set":5,"id":"c0d4a571_aa41f597","line":204,"updated":"2021-12-02 02:29:57.000000000","message":"typo: coordinater -\u003e coordinator","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"94d914e531a6089e639bfb827eaae040a5904c59","unresolved":false,"context_lines":[{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"},{"line_number":206,"context_line":"    # FAILED_TEMP operationState."},{"line_number":207,"context_line":"    lcmoccs \u003d objects.VnfLcmOpOccV2.get_by_filter("}],"source_content_type":"text/x-python","patch_set":5,"id":"b656a37c_f640a4d0","line":204,"in_reply_to":"314da968_e7aa29a8","updated":"2021-12-02 04:48:35.000000000","message":"Done","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":true,"context_lines":[{"line_number":201,"context_line":"def check_lcmocc_in_progress(context, inst_id):"},{"line_number":202,"context_line":"    # if the contorller or conductor executes an operation for the vnf"},{"line_number":203,"context_line":"    # instantce (i.e. operationState is ...ING), other operation for"},{"line_number":204,"context_line":"    # the same vnf instance is exculed by the coordinater."},{"line_number":205,"context_line":"    # check here is existence of lcmocc for the vnf instance with"},{"line_number":206,"context_line":"    # FAILED_TEMP operationState."},{"line_number":207,"context_line":"    lcmoccs \u003d objects.VnfLcmOpOccV2.get_by_filter("}],"source_content_type":"text/x-python","patch_set":5,"id":"314da968_e7aa29a8","line":204,"in_reply_to":"c0d4a571_aa41f597","updated":"2021-12-02 04:24:06.000000000","message":"I will fix.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"}],"tacker/sol_refactored/conductor/conductor_v2.py":[{"author":{"_account_id":31668},"change_message_id":"82302a47a4525eb3bd300faa557b23362a1138ca","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":118,"context_line":"                # save grant_req and grant to be used when retry"},{"line_number":119,"context_line":"                # NOTE: grant_req is saved because it is necessary to interpret"},{"line_number":120,"context_line":"                # the contents of grant. Though grant can be get from NFVO,"},{"line_number":121,"context_line":"                # it is saved here with grant_req so that it is not necessary"},{"line_number":122,"context_line":"                # to comunicate with NFVO when retry. They are saved temporary"},{"line_number":123,"context_line":"                # and will be deleted when operationState becomes an end state"}],"source_content_type":"text/x-python","patch_set":5,"id":"94af9524_9b6088ec","line":120,"updated":"2021-12-02 02:29:57.000000000","message":"typo: get -\u003e gotten","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":118,"context_line":"                # save grant_req and grant to be used when retry"},{"line_number":119,"context_line":"                # NOTE: grant_req is saved because it is necessary to interpret"},{"line_number":120,"context_line":"                # the contents of grant. Though grant can be get from NFVO,"},{"line_number":121,"context_line":"                # it is saved here with grant_req so that it is not necessary"},{"line_number":122,"context_line":"                # to comunicate with NFVO when retry. They are saved temporary"},{"line_number":123,"context_line":"                # and will be deleted when operationState becomes an end state"}],"source_content_type":"text/x-python","patch_set":5,"id":"f65cb248_2a7cb827","line":120,"in_reply_to":"94af9524_9b6088ec","updated":"2021-12-02 04:24:06.000000000","message":"I will fix.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"94d914e531a6089e639bfb827eaae040a5904c59","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            with context.session.begin(subtransactions\u003dTrue):"},{"line_number":118,"context_line":"                # save grant_req and grant to be used when retry"},{"line_number":119,"context_line":"                # NOTE: grant_req is saved because it is necessary to interpret"},{"line_number":120,"context_line":"                # the contents of grant. Though grant can be get from NFVO,"},{"line_number":121,"context_line":"                # it is saved here with grant_req so that it is not necessary"},{"line_number":122,"context_line":"                # to comunicate with NFVO when retry. They are saved temporary"},{"line_number":123,"context_line":"                # and will be deleted when operationState becomes an end state"}],"source_content_type":"text/x-python","patch_set":5,"id":"818f2177_b2919e99","line":120,"in_reply_to":"f65cb248_2a7cb827","updated":"2021-12-02 04:48:35.000000000","message":"Done","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"82302a47a4525eb3bd300faa557b23362a1138ca","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                # NOTE: grant_req is saved because it is necessary to interpret"},{"line_number":120,"context_line":"                # the contents of grant. Though grant can be get from NFVO,"},{"line_number":121,"context_line":"                # it is saved here with grant_req so that it is not necessary"},{"line_number":122,"context_line":"                # to comunicate with NFVO when retry. They are saved temporary"},{"line_number":123,"context_line":"                # and will be deleted when operationState becomes an end state"},{"line_number":124,"context_line":"                # (COMPLETED/FAILED/ROLLED_BACK)."},{"line_number":125,"context_line":"                grant_req.create(context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c44d480c_5f5c778f","line":122,"updated":"2021-12-02 02:29:57.000000000","message":"typo: comunicate -\u003e communicate","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":true,"context_lines":[{"line_number":119,"context_line":"                # NOTE: grant_req is saved because it is necessary to interpret"},{"line_number":120,"context_line":"                # the contents of grant. Though grant can be get from NFVO,"},{"line_number":121,"context_line":"                # it is saved here with grant_req so that it is not necessary"},{"line_number":122,"context_line":"                # to comunicate with NFVO when retry. They are saved temporary"},{"line_number":123,"context_line":"                # and will be deleted when operationState becomes an end state"},{"line_number":124,"context_line":"                # (COMPLETED/FAILED/ROLLED_BACK)."},{"line_number":125,"context_line":"                grant_req.create(context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f988fdca_57bda83f","line":122,"in_reply_to":"c44d480c_5f5c778f","updated":"2021-12-02 04:24:06.000000000","message":"I will fix.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"94d914e531a6089e639bfb827eaae040a5904c59","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                # NOTE: grant_req is saved because it is necessary to interpret"},{"line_number":120,"context_line":"                # the contents of grant. Though grant can be get from NFVO,"},{"line_number":121,"context_line":"                # it is saved here with grant_req so that it is not necessary"},{"line_number":122,"context_line":"                # to comunicate with NFVO when retry. They are saved temporary"},{"line_number":123,"context_line":"                # and will be deleted when operationState becomes an end state"},{"line_number":124,"context_line":"                # (COMPLETED/FAILED/ROLLED_BACK)."},{"line_number":125,"context_line":"                grant_req.create(context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"89b8c589_08747264","line":122,"in_reply_to":"f988fdca_57bda83f","updated":"2021-12-02 04:48:35.000000000","message":"Done","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"82302a47a4525eb3bd300faa557b23362a1138ca","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    def _retry_lcm_op(self, context, lcmocc):"},{"line_number":141,"context_line":"        # just consistency check"},{"line_number":142,"context_line":"        if lcmocc.operationState !\u003d fields.LcmOperationStateType.FAILED_TEMP:"},{"line_number":143,"context_line":"            LOG.error(\"VnfLcmOpOcc unexpected operationState.\")"},{"line_number":144,"context_line":"            return"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        inst \u003d inst_utils.get_inst(context, lcmocc.vnfInstanceId)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c63d6e15_5bb3e579","line":143,"updated":"2021-12-02 02:29:57.000000000","message":"I think it is better to execute \"raise sol_ex.LcmOpOccNotFailedTemp (lcmocc_id \u003d lcmocc.id)\" processing like ”_lcm_op_occ_retry\" of VnfLcmControllerV2.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    def _retry_lcm_op(self, context, lcmocc):"},{"line_number":141,"context_line":"        # just consistency check"},{"line_number":142,"context_line":"        if lcmocc.operationState !\u003d fields.LcmOperationStateType.FAILED_TEMP:"},{"line_number":143,"context_line":"            LOG.error(\"VnfLcmOpOcc unexpected operationState.\")"},{"line_number":144,"context_line":"            return"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        inst \u003d inst_utils.get_inst(context, lcmocc.vnfInstanceId)"}],"source_content_type":"text/x-python","patch_set":5,"id":"e024d54f_c5da26d4","line":143,"in_reply_to":"c63d6e15_5bb3e579","updated":"2021-12-02 04:24:06.000000000","message":"It is just an assertion. It is same as L.61. It means some awfully strange thing happens. Raising exception is for the case that the error may happen.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"ea31e058f68ffb9d8d3078e21ad56e0644529a59","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def _retry_lcm_op(self, context, lcmocc):"},{"line_number":141,"context_line":"        # just consistency check"},{"line_number":142,"context_line":"        if lcmocc.operationState !\u003d fields.LcmOperationStateType.FAILED_TEMP:"},{"line_number":143,"context_line":"            LOG.error(\"VnfLcmOpOcc unexpected operationState.\")"},{"line_number":144,"context_line":"            return"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        inst \u003d inst_utils.get_inst(context, lcmocc.vnfInstanceId)"}],"source_content_type":"text/x-python","patch_set":5,"id":"07c4b77e_400fd7a8","line":143,"in_reply_to":"e024d54f_c5da26d4","updated":"2021-12-02 04:59:28.000000000","message":"OK. I see.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"}],"tacker/sol_refactored/db/api.py":[{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"535206627e6fd8f9261c2b89e802cf7988bdfd25","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51183c66_d07e3943","side":"PARENT","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":0},"updated":"2021-11-08 07:59:56.000000000","message":"Is this change intended?\nDoes this change affect other implements?","commit_id":"5d9d011951ebe955e2f6115ed3c8a00a49022f24"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ce16a4fd5eb7c70b8f64b210b4e16f2a3ed0be5f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b565da51_d2e5d8df","side":"PARENT","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":0},"in_reply_to":"51183c66_d07e3943","updated":"2021-11-08 22:58:19.000000000","message":"yes, intended.\nThis is introduced to raise independency from existing DB operation originally, but it is not necessary at all.\nI found UTs using DB (sqlite) fail by using both tacker/db/api.py and tacker/sol_refactored/db/api.py. To fix it, use original tacker/db/api.py in sol_refactored/ codes instead of this file and remove this file.","commit_id":"5d9d011951ebe955e2f6115ed3c8a00a49022f24"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"180d4ceaba5a947335e2ddc01ec229444a73febb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed6e05d7_7a58539b","side":"PARENT","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":0},"in_reply_to":"b565da51_d2e5d8df","updated":"2021-11-11 05:40:58.000000000","message":"I see.","commit_id":"5d9d011951ebe955e2f6115ed3c8a00a49022f24"}],"tacker/sol_refactored/db/sqlalchemy/models.py":[{"author":{"_account_id":31668},"change_message_id":"82302a47a4525eb3bd300faa557b23362a1138ca","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    operation \u003d sa.Column(sa.Enum("},{"line_number":141,"context_line":"        \u0027INSTANTIATE\u0027, \u0027SCALE\u0027, \u0027SCALE_TO_LEVEL\u0027, \u0027CHANGE_FLAVOUR\u0027,"},{"line_number":142,"context_line":"        \u0027TERMINATE\u0027, \u0027HEAL\u0027, \u0027OPERATE\u0027, \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":143,"context_line":"        \u0027MODIFY_INFO\u0027, \u0027CREATE_SNAPSHOT\u0027, \u0027REVERT_TO_SNAPSHOT\u0027,"},{"line_number":144,"context_line":"        \u0027CHANGE_VNFPKG\u0027, create_constraint\u003dTrue, validate_strings\u003dTrue),"},{"line_number":145,"context_line":"        nullable\u003dFalse)"},{"line_number":146,"context_line":"    isAutomaticInvocation \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"93c565df_074549d0","line":143,"updated":"2021-12-02 02:29:57.000000000","message":"\"MODIFY_INFO\" is not described in \"Table 9.5.4.3-1: Enumeration GrantedLcmOperationType\" of SOL003 v3.3.1.\nIs this a tacker original?","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"180a8eb2e4494b6feb6224afb099c0cfa4216446","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    operation \u003d sa.Column(sa.Enum("},{"line_number":141,"context_line":"        \u0027INSTANTIATE\u0027, \u0027SCALE\u0027, \u0027SCALE_TO_LEVEL\u0027, \u0027CHANGE_FLAVOUR\u0027,"},{"line_number":142,"context_line":"        \u0027TERMINATE\u0027, \u0027HEAL\u0027, \u0027OPERATE\u0027, \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":143,"context_line":"        \u0027MODIFY_INFO\u0027, \u0027CREATE_SNAPSHOT\u0027, \u0027REVERT_TO_SNAPSHOT\u0027,"},{"line_number":144,"context_line":"        \u0027CHANGE_VNFPKG\u0027, create_constraint\u003dTrue, validate_strings\u003dTrue),"},{"line_number":145,"context_line":"        nullable\u003dFalse)"},{"line_number":146,"context_line":"    isAutomaticInvocation \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"a115965b_270729ec","line":143,"in_reply_to":"93c565df_074549d0","updated":"2021-12-02 04:24:06.000000000","message":"MODIFY_INFO is not necessary. I will remove it.","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"},{"author":{"_account_id":31668},"change_message_id":"94d914e531a6089e639bfb827eaae040a5904c59","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    operation \u003d sa.Column(sa.Enum("},{"line_number":141,"context_line":"        \u0027INSTANTIATE\u0027, \u0027SCALE\u0027, \u0027SCALE_TO_LEVEL\u0027, \u0027CHANGE_FLAVOUR\u0027,"},{"line_number":142,"context_line":"        \u0027TERMINATE\u0027, \u0027HEAL\u0027, \u0027OPERATE\u0027, \u0027CHANGE_EXT_CONN\u0027,"},{"line_number":143,"context_line":"        \u0027MODIFY_INFO\u0027, \u0027CREATE_SNAPSHOT\u0027, \u0027REVERT_TO_SNAPSHOT\u0027,"},{"line_number":144,"context_line":"        \u0027CHANGE_VNFPKG\u0027, create_constraint\u003dTrue, validate_strings\u003dTrue),"},{"line_number":145,"context_line":"        nullable\u003dFalse)"},{"line_number":146,"context_line":"    isAutomaticInvocation \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"448e2724_f9f44d01","line":143,"in_reply_to":"a115965b_270729ec","updated":"2021-12-02 04:48:35.000000000","message":"Done","commit_id":"66a7ab1eb8300df9d58eed77cf4f4d60e314465d"}],"tacker/sol_refactored/infra_drivers/openstack/openstack.py":[{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"e5954d3d95b4cbdf248b2a097ea510e41557a922","unresolved":true,"context_lines":[{"line_number":532,"context_line":"        heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":533,"context_line":"        stack_name \u003d heat_utils.get_stack_name(inst)"},{"line_number":534,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":535,"context_line":"        heat_client.wait_stack_delete(stack_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"53f2e573_02624de8","side":"PARENT","line":535,"updated":"2021-12-13 10:06:26.000000000","message":"What is the reason why this process is no longer necessary?","commit_id":"e501198b0f425cb25817314130e2080e8e1715fd"},{"author":{"_account_id":31072,"name":"Hiroo Kitamura","email":"hiroo.kitamura@ntt-at.co.jp","username":"Hiroo.Kitamura"},"change_message_id":"24d942b5757c8ad52f2f0bf678dfb61d1d1cd245","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":533,"context_line":"        stack_name \u003d heat_utils.get_stack_name(inst)"},{"line_number":534,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":535,"context_line":"        heat_client.wait_stack_delete(stack_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"6a1c642d_2c7fcba1","side":"PARENT","line":535,"in_reply_to":"14bbd790_fc239819","updated":"2021-12-13 23:55:12.000000000","message":"Thank you. I got it.","commit_id":"e501198b0f425cb25817314130e2080e8e1715fd"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"d1379329fc6e455b836d498a31570efb2ecf50fc","unresolved":true,"context_lines":[{"line_number":532,"context_line":"        heat_client \u003d heat_utils.HeatClient(vim_info)"},{"line_number":533,"context_line":"        stack_name \u003d heat_utils.get_stack_name(inst)"},{"line_number":534,"context_line":"        heat_client.delete_stack(stack_name)"},{"line_number":535,"context_line":"        heat_client.wait_stack_delete(stack_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"14bbd790_fc239819","side":"PARENT","line":535,"in_reply_to":"53f2e573_02624de8","updated":"2021-12-13 22:21:14.000000000","message":"see infra_drivers/openstack/heat_utils.py L.59. delete_stack has 2nd option which specifies wait deletion or not now. default is wait. note that create_stack and update_stack are same as this.","commit_id":"e501198b0f425cb25817314130e2080e8e1715fd"}],"tacker/tests/unit/sol_refactored/conductor/test_conductor_v2.py":[{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"09017165f75d6494bb4c3abbfbb820f712b42577","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            instantiationState\u003d\u0027NOT_INSTANTIATED\u0027"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        req \u003d {\"flavourId\": \"simple\"}  # instantate request"},{"line_number":54,"context_line":"        lcmocc \u003d objects.VnfLcmOpOccV2("},{"line_number":55,"context_line":"            # required fields"},{"line_number":56,"context_line":"            id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9451b4d7_1e461a74","line":53,"range":{"start_line":53,"start_character":41,"end_line":53,"end_character":51},"updated":"2021-11-08 08:11:20.000000000","message":"Typo: instantiate?","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"ce16a4fd5eb7c70b8f64b210b4e16f2a3ed0be5f","unresolved":true,"context_lines":[{"line_number":50,"context_line":"            instantiationState\u003d\u0027NOT_INSTANTIATED\u0027"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        req \u003d {\"flavourId\": \"simple\"}  # instantate request"},{"line_number":54,"context_line":"        lcmocc \u003d objects.VnfLcmOpOccV2("},{"line_number":55,"context_line":"            # required fields"},{"line_number":56,"context_line":"            id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"f6c13527_6a8ebd9f","line":53,"range":{"start_line":53,"start_character":41,"end_line":53,"end_character":51},"in_reply_to":"9451b4d7_1e461a74","updated":"2021-11-08 22:58:19.000000000","message":"I will fix.","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"},{"author":{"_account_id":33453,"name":"Shun Higuchi","email":"higuchis@intellilink.co.jp","username":"higuchis"},"change_message_id":"180d4ceaba5a947335e2ddc01ec229444a73febb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            instantiationState\u003d\u0027NOT_INSTANTIATED\u0027"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        req \u003d {\"flavourId\": \"simple\"}  # instantate request"},{"line_number":54,"context_line":"        lcmocc \u003d objects.VnfLcmOpOccV2("},{"line_number":55,"context_line":"            # required fields"},{"line_number":56,"context_line":"            id\u003duuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fceae54_95185b91","line":53,"range":{"start_line":53,"start_character":41,"end_line":53,"end_character":51},"in_reply_to":"f6c13527_6a8ebd9f","updated":"2021-11-11 05:40:58.000000000","message":"Done","commit_id":"15dd0a3dc28c99058fcd3daec56b5f8a4aacd045"}]}
